eslint 6.3.0 → 6.6.0

package/lib/rules/keyword-spacing.js

@@ -41,8 +41,7 @@ const KEYS = keywords.concat(["as", "async", "await", "from", "get", "let", "of"
 
 /**
  * Checks whether or not a given token is a "Template" token ends with "${".
- *
- * @param {Token} token - A token to check.
+ * @param {Token} token A token to check.
  * @returns {boolean} `true` if the token is a "Template" token ends with "${".
  */
 function isOpenParenOfTemplate(token) {
@@ -51,8 +50,7 @@ function isOpenParenOfTemplate(token) {
 
 /**
  * Checks whether or not a given token is a "Template" token starts with "}".
- *
- * @param {Token} token - A token to check.
+ * @param {Token} token A token to check.
  * @returns {boolean} `true` if the token is a "Template" token starts with "}".
  */
 function isCloseParenOfTemplate(token) {
@@ -88,8 +86,8 @@ module.exports = {
                             retv[key] = {
                                 type: "object",
                                 properties: {
-                                    before: { type: "boolean", default: true },
-                                    after: { type: "boolean", default: true }
+                                    before: { type: "boolean" },
+                                    after: { type: "boolean" }
                                 },
                                 additionalProperties: false
                             };
@@ -114,9 +112,8 @@ module.exports = {
 
         /**
          * Reports a given token if there are not space(s) before the token.
-         *
-         * @param {Token} token - A token to report.
-         * @param {RegExp} pattern - A pattern of the previous token to check.
+         * @param {Token} token A token to report.
+         * @param {RegExp} pattern A pattern of the previous token to check.
          * @returns {void}
          */
         function expectSpaceBefore(token, pattern) {
@@ -141,9 +138,8 @@ module.exports = {
 
         /**
          * Reports a given token if there are space(s) before the token.
-         *
-         * @param {Token} token - A token to report.
-         * @param {RegExp} pattern - A pattern of the previous token to check.
+         * @param {Token} token A token to report.
+         * @param {RegExp} pattern A pattern of the previous token to check.
          * @returns {void}
          */
         function unexpectSpaceBefore(token, pattern) {
@@ -168,9 +164,8 @@ module.exports = {
 
         /**
          * Reports a given token if there are not space(s) after the token.
-         *
-         * @param {Token} token - A token to report.
-         * @param {RegExp} pattern - A pattern of the next token to check.
+         * @param {Token} token A token to report.
+         * @param {RegExp} pattern A pattern of the next token to check.
          * @returns {void}
          */
         function expectSpaceAfter(token, pattern) {
@@ -195,9 +190,8 @@ module.exports = {
 
         /**
          * Reports a given token if there are space(s) after the token.
-         *
-         * @param {Token} token - A token to report.
-         * @param {RegExp} pattern - A pattern of the next token to check.
+         * @param {Token} token A token to report.
+         * @param {RegExp} pattern A pattern of the next token to check.
          * @returns {void}
          */
         function unexpectSpaceAfter(token, pattern) {
@@ -222,8 +216,7 @@ module.exports = {
 
         /**
          * Parses the option object and determines check methods for each keyword.
-         *
-         * @param {Object|undefined} options - The option object to parse.
+         * @param {Object|undefined} options The option object to parse.
          * @returns {Object} - Normalized option object.
          *      Keys are keywords (there are for every keyword).
          *      Values are instances of `{"before": function, "after": function}`.
@@ -263,9 +256,8 @@ module.exports = {
         /**
          * Reports a given token if usage of spacing followed by the token is
          * invalid.
-         *
-         * @param {Token} token - A token to report.
-         * @param {RegExp|undefined} pattern - Optional. A pattern of the previous
+         * @param {Token} token A token to report.
+         * @param {RegExp} [pattern] Optional. A pattern of the previous
          *      token to check.
          * @returns {void}
          */
@@ -276,9 +268,8 @@ module.exports = {
         /**
          * Reports a given token if usage of spacing preceded by the token is
          * invalid.
-         *
-         * @param {Token} token - A token to report.
-         * @param {RegExp|undefined} pattern - Optional. A pattern of the next
+         * @param {Token} token A token to report.
+         * @param {RegExp} [pattern] Optional. A pattern of the next
          *      token to check.
          * @returns {void}
          */
@@ -288,8 +279,7 @@ module.exports = {
 
         /**
          * Reports a given token if usage of spacing around the token is invalid.
-         *
-         * @param {Token} token - A token to report.
+         * @param {Token} token A token to report.
          * @returns {void}
          */
         function checkSpacingAround(token) {
@@ -300,8 +290,7 @@ module.exports = {
         /**
          * Reports the first token of a given node if the first token is a keyword
          * and usage of spacing around the token is invalid.
-         *
-         * @param {ASTNode|null} node - A node to report.
+         * @param {ASTNode|null} node A node to report.
          * @returns {void}
          */
         function checkSpacingAroundFirstToken(node) {
@@ -318,8 +307,7 @@ module.exports = {
          *
          * This is used for unary operators (e.g. `typeof`), `function`, and `super`.
          * Other rules are handling usage of spacing preceded by those keywords.
-         *
-         * @param {ASTNode|null} node - A node to report.
+         * @param {ASTNode|null} node A node to report.
          * @returns {void}
          */
         function checkSpacingBeforeFirstToken(node) {
@@ -333,8 +321,7 @@ module.exports = {
         /**
          * Reports the previous token of a given node if the token is a keyword and
          * usage of spacing around the token is invalid.
-         *
-         * @param {ASTNode|null} node - A node to report.
+         * @param {ASTNode|null} node A node to report.
          * @returns {void}
          */
         function checkSpacingAroundTokenBefore(node) {
@@ -348,8 +335,7 @@ module.exports = {
         /**
          * Reports `async` or `function` keywords of a given node if usage of
          * spacing around those keywords is invalid.
-         *
-         * @param {ASTNode} node - A node to report.
+         * @param {ASTNode} node A node to report.
          * @returns {void}
          */
         function checkSpacingForFunction(node) {
@@ -366,8 +352,7 @@ module.exports = {
         /**
          * Reports `class` and `extends` keywords of a given node if usage of
          * spacing around those keywords is invalid.
-         *
-         * @param {ASTNode} node - A node to report.
+         * @param {ASTNode} node A node to report.
          * @returns {void}
          */
         function checkSpacingForClass(node) {
@@ -378,8 +363,7 @@ module.exports = {
         /**
          * Reports `if` and `else` keywords of a given node if usage of spacing
          * around those keywords is invalid.
-         *
-         * @param {ASTNode} node - A node to report.
+         * @param {ASTNode} node A node to report.
          * @returns {void}
          */
         function checkSpacingForIfStatement(node) {
@@ -390,8 +374,7 @@ module.exports = {
         /**
          * Reports `try`, `catch`, and `finally` keywords of a given node if usage
          * of spacing around those keywords is invalid.
-         *
-         * @param {ASTNode} node - A node to report.
+         * @param {ASTNode} node A node to report.
          * @returns {void}
          */
         function checkSpacingForTryStatement(node) {
@@ -403,8 +386,7 @@ module.exports = {
         /**
          * Reports `do` and `while` keywords of a given node if usage of spacing
          * around those keywords is invalid.
-         *
-         * @param {ASTNode} node - A node to report.
+         * @param {ASTNode} node A node to report.
          * @returns {void}
          */
         function checkSpacingForDoWhileStatement(node) {
@@ -415,8 +397,7 @@ module.exports = {
         /**
          * Reports `for` and `in` keywords of a given node if usage of spacing
          * around those keywords is invalid.
-         *
-         * @param {ASTNode} node - A node to report.
+         * @param {ASTNode} node A node to report.
          * @returns {void}
          */
         function checkSpacingForForInStatement(node) {
@@ -427,8 +408,7 @@ module.exports = {
         /**
          * Reports `for` and `of` keywords of a given node if usage of spacing
          * around those keywords is invalid.
-         *
-         * @param {ASTNode} node - A node to report.
+         * @param {ASTNode} node A node to report.
          * @returns {void}
          */
         function checkSpacingForForOfStatement(node) {
@@ -449,8 +429,7 @@ module.exports = {
          *
          *     import*as A from "./a"; /*error Expected space(s) after "import".
          *                               error Expected space(s) before "as".
-         *
-         * @param {ASTNode} node - A node to report.
+         * @param {ASTNode} node A node to report.
          * @returns {void}
          */
         function checkSpacingForModuleDeclaration(node) {
@@ -474,8 +453,7 @@ module.exports = {
         /**
          * Reports `as` keyword of a given node if usage of spacing around this
          * keyword is invalid.
-         *
-         * @param {ASTNode} node - A node to report.
+         * @param {ASTNode} node A node to report.
          * @returns {void}
          */
         function checkSpacingForImportNamespaceSpecifier(node) {
@@ -487,8 +465,7 @@ module.exports = {
         /**
          * Reports `static`, `get`, and `set` keywords of a given node if usage of
          * spacing around those keywords is invalid.
-         *
-         * @param {ASTNode} node - A node to report.
+         * @param {ASTNode} node A node to report.
          * @returns {void}
          */
         function checkSpacingForProperty(node) {
@@ -528,8 +505,7 @@ module.exports = {
         /**
          * Reports `await` keyword of a given node if usage of spacing before
          * this keyword is invalid.
-         *
-         * @param {ASTNode} node - A node to report.
+         * @param {ASTNode} node A node to report.
          * @returns {void}
          */
         function checkSpacingForAwaitExpression(node) {

package/lib/rules/lines-around-directive.js

@@ -131,7 +131,7 @@ module.exports = {
 
         /**
          * Check lines around directives in node
-         * @param {ASTNode} node - node to check
+         * @param {ASTNode} node node to check
          * @returns {void}
          */
         function checkDirectives(node) {

package/lib/rules/max-len.js

@@ -198,7 +198,6 @@ module.exports = {
 
         /**
          * Ensure that an array exists at [key] on `object`, and add `value` to it.
-         *
          * @param {Object} object the object to mutate
          * @param {string} key the object's key
          * @param {*} value the value to add
@@ -214,7 +213,6 @@ module.exports = {
 
         /**
          * Retrieves an array containing all strings (" or ') in the source code.
-         *
          * @returns {ASTNode[]} An array of string nodes.
          */
         function getAllStrings() {
@@ -224,7 +222,6 @@ module.exports = {
 
         /**
          * Retrieves an array containing all template literals in the source code.
-         *
          * @returns {ASTNode[]} An array of template literal nodes.
          */
         function getAllTemplateLiterals() {
@@ -234,7 +231,6 @@ module.exports = {
 
         /**
          * Retrieves an array containing all RegExp literals in the source code.
-         *
          * @returns {ASTNode[]} An array of RegExp literal nodes.
          */
         function getAllRegExpLiterals() {
@@ -244,7 +240,6 @@ module.exports = {
 
         /**
          * A reducer to group an AST node by line number, both start and end.
-         *
          * @param {Object} acc the accumulator
          * @param {ASTNode} node the AST node in question
          * @returns {Object} the modified accumulator

package/lib/rules/max-statements-per-line.js

@@ -61,7 +61,6 @@ module.exports = {
 
         /**
          * Reports with the first extra statement, and clears it.
-         *
          * @returns {void}
          */
         function reportFirstExtraStatementAndClear() {
@@ -81,8 +80,7 @@ module.exports = {
 
         /**
          * Gets the actual last token of a given node.
-         *
-         * @param {ASTNode} node - A node to get. This is a node except EmptyStatement.
+         * @param {ASTNode} node A node to get. This is a node except EmptyStatement.
          * @returns {Token} The actual last token.
          */
         function getActualLastToken(node) {
@@ -92,8 +90,7 @@ module.exports = {
         /**
          * Addresses a given node.
          * It updates the state of this rule, then reports the node if the node violated this rule.
-         *
-         * @param {ASTNode} node - A node to check.
+         * @param {ASTNode} node A node to check.
          * @returns {void}
          */
         function enterStatement(node) {
@@ -127,8 +124,7 @@ module.exports = {
 
         /**
          * Updates the state of this rule with the end line of leaving node to check with the next statement.
-         *
-         * @param {ASTNode} node - A node to check.
+         * @param {ASTNode} node A node to check.
          * @returns {void}
          */
         function leaveStatement(node) {

package/lib/rules/multiline-ternary.js

@@ -46,9 +46,9 @@ module.exports = {
 
         /**
          * Tests whether node is preceded by supplied tokens
-         * @param {ASTNode} node - node to check
-         * @param {ASTNode} parentNode - parent of node to report
-         * @param {boolean} expected - whether newline was expected or not
+         * @param {ASTNode} node node to check
+         * @param {ASTNode} parentNode parent of node to report
+         * @param {boolean} expected whether newline was expected or not
          * @returns {void}
          * @private
          */

package/lib/rules/new-parens.js

@@ -65,7 +65,11 @@ module.exports = {
 
                 const lastToken = sourceCode.getLastToken(node);
                 const hasLastParen = lastToken && astUtils.isClosingParenToken(lastToken);
-                const hasParens = hasLastParen && astUtils.isOpeningParenToken(sourceCode.getTokenBefore(lastToken));
+
+                // `hasParens` is true only if the new expression ends with its own parens, e.g., new new foo() does not end with its own parens
+                const hasParens = hasLastParen &&
+                    astUtils.isOpeningParenToken(sourceCode.getTokenBefore(lastToken)) &&
+                    node.callee.range[1] < node.range[1];
 
                 if (always) {
                     if (!hasParens) {

package/lib/rules/newline-after-var.js

@@ -72,8 +72,7 @@ module.exports = {
          *     var foo = 1
          *
          *     ;(a || b).doSomething()
-         *
-         * @param {ASTNode} node - The node to get.
+         * @param {ASTNode} node The node to get.
          * @returns {Token} The token to compare line to the next statement.
          */
         function getLastToken(node) {
@@ -93,7 +92,7 @@ module.exports = {
         /**
          * Determine if provided keyword is a variable declaration
          * @private
-         * @param {string} keyword - keyword to test
+         * @param {string} keyword keyword to test
          * @returns {boolean} True if `keyword` is a type of var
          */
         function isVar(keyword) {
@@ -103,7 +102,7 @@ module.exports = {
         /**
          * Determine if provided keyword is a variant of for specifiers
          * @private
-         * @param {string} keyword - keyword to test
+         * @param {string} keyword keyword to test
          * @returns {boolean} True if `keyword` is a variant of for specifier
          */
         function isForTypeSpecifier(keyword) {
@@ -113,7 +112,7 @@ module.exports = {
         /**
          * Determine if provided keyword is an export specifiers
          * @private
-         * @param {string} nodeType - nodeType to test
+         * @param {string} nodeType nodeType to test
          * @returns {boolean} True if `nodeType` is an export specifier
          */
         function isExportSpecifier(nodeType) {
@@ -124,7 +123,7 @@ module.exports = {
         /**
          * Determine if provided node is the last of their parent block.
          * @private
-         * @param {ASTNode} node - node to test
+         * @param {ASTNode} node node to test
          * @returns {boolean} True if `node` is last of their parent block.
          */
         function isLastNode(node) {
@@ -159,7 +158,7 @@ module.exports = {
          * set to "always", or checks that there is no blank line when mode is set
          * to "never"
          * @private
-         * @param {ASTNode} node - `VariableDeclaration` node to test
+         * @param {ASTNode} node `VariableDeclaration` node to test
          * @returns {void}
          */
         function checkForBlankLine(node) {

package/lib/rules/newline-before-return.js

@@ -39,8 +39,8 @@ module.exports = {
 
         /**
          * Tests whether node is preceded by supplied tokens
-         * @param {ASTNode} node - node to check
-         * @param {Array} testTokens - array of tokens to test against
+         * @param {ASTNode} node node to check
+         * @param {Array} testTokens array of tokens to test against
          * @returns {boolean} Whether or not the node is preceded by one of the supplied tokens
          * @private
          */
@@ -52,7 +52,7 @@ module.exports = {
 
         /**
          * Checks whether node is the first node after statement or in block
-         * @param {ASTNode} node - node to check
+         * @param {ASTNode} node node to check
          * @returns {boolean} Whether or not the node is the first node after statement or in block
          * @private
          */
@@ -80,8 +80,8 @@ module.exports = {
 
         /**
          * Returns the number of lines of comments that precede the node
-         * @param {ASTNode} node - node to check for overlapping comments
-         * @param {number} lineNumTokenBefore - line number of previous token, to check for overlapping comments
+         * @param {ASTNode} node node to check for overlapping comments
+         * @param {number} lineNumTokenBefore line number of previous token, to check for overlapping comments
          * @returns {number} Number of lines of comments that precede the node
          * @private
          */
@@ -115,7 +115,7 @@ module.exports = {
 
         /**
          * Returns the line number of the token before the node that is passed in as an argument
-         * @param {ASTNode} node - The node to use as the start of the calculation
+         * @param {ASTNode} node The node to use as the start of the calculation
          * @returns {number} Line number of the token before `node`
          * @private
          */
@@ -142,7 +142,7 @@ module.exports = {
 
         /**
          * Checks whether node is preceded by a newline
-         * @param {ASTNode} node - node to check
+         * @param {ASTNode} node node to check
          * @returns {boolean} Whether or not the node is preceded by a newline
          * @private
          */
@@ -160,8 +160,7 @@ module.exports = {
          * The fix is not considered safe if the given return statement has leading comments,
          * as we cannot safely determine if the newline should be added before or after the comments.
          * For more information, see: https://github.com/eslint/eslint/issues/5958#issuecomment-222767211
-         *
-         * @param {ASTNode} node - The return statement node to check.
+         * @param {ASTNode} node The return statement node to check.
          * @returns {boolean} `true` if it can fix the node.
          * @private
          */

package/lib/rules/newline-per-chained-call.js

@@ -53,8 +53,7 @@ module.exports = {
          * Get the prefix of a given MemberExpression node.
          * If the MemberExpression node is a computed value it returns a
          * left bracket. If not it returns a period.
-         *
-         * @param  {ASTNode} node - A MemberExpression node to get
+         * @param  {ASTNode} node A MemberExpression node to get
          * @returns {string} The prefix of the node.
          */
         function getPrefix(node) {
@@ -64,8 +63,7 @@ module.exports = {
         /**
          * Gets the property text of a given MemberExpression node.
          * If the text is multiline, this returns only the first line.
-         *
-         * @param {ASTNode} node - A MemberExpression node to get.
+         * @param {ASTNode} node A MemberExpression node to get.
          * @returns {string} The property text of the node.
          */
         function getPropertyText(node) {

package/lib/rules/no-class-assign.js

@@ -33,7 +33,7 @@ module.exports = {
 
         /**
          * Finds and reports references that are non initializer and writable.
-         * @param {Variable} variable - A variable to check.
+         * @param {Variable} variable A variable to check.
          * @returns {void}
          */
         function checkVariable(variable) {
@@ -45,7 +45,7 @@ module.exports = {
 
         /**
          * Finds and reports references that are non initializer and writable.
-         * @param {ASTNode} node - A ClassDeclaration/ClassExpression node to check.
+         * @param {ASTNode} node A ClassDeclaration/ClassExpression node to check.
          * @returns {void}
          */
         function checkForClass(node) {

package/lib/rules/no-compare-neg-zero.js

@@ -35,8 +35,7 @@ module.exports = {
 
         /**
          * Checks a given node is -0
-         *
-         * @param {ASTNode} node - A node to check.
+         * @param {ASTNode} node A node to check.
          * @returns {boolean} `true` if the node is -0.
          */
         function isNegZero(node) {

package/lib/rules/no-confusing-arrow.js

@@ -14,7 +14,7 @@ const astUtils = require("./utils/ast-utils.js");
 
 /**
  * Checks whether or not a node is a conditional expression.
- * @param {ASTNode} node - node to test
+ * @param {ASTNode} node node to test
  * @returns {boolean} `true` if the node is a conditional expression.
  */
 function isConditional(node) {
@@ -59,7 +59,7 @@ module.exports = {
 
         /**
          * Reports if an arrow function contains an ambiguous conditional.
-         * @param {ASTNode} node - A node to check and report.
+         * @param {ASTNode} node A node to check and report.
          * @returns {void}
          */
         function checkArrowFunc(node) {

package/lib/rules/no-console.js

@@ -54,8 +54,7 @@ module.exports = {
 
         /**
          * Checks whether the given reference is 'console' or not.
-         *
-         * @param {eslint-scope.Reference} reference - The reference to check.
+         * @param {eslint-scope.Reference} reference The reference to check.
          * @returns {boolean} `true` if the reference is 'console'.
          */
         function isConsole(reference) {
@@ -67,8 +66,7 @@ module.exports = {
         /**
          * Checks whether the property name of the given MemberExpression node
          * is allowed by options or not.
-         *
-         * @param {ASTNode} node - The MemberExpression node to check.
+         * @param {ASTNode} node The MemberExpression node to check.
          * @returns {boolean} `true` if the property name of the node is allowed.
          */
         function isAllowed(node) {
@@ -80,8 +78,7 @@ module.exports = {
         /**
          * Checks whether the given reference is a member access which is not
          * allowed by options or not.
-         *
-         * @param {eslint-scope.Reference} reference - The reference to check.
+         * @param {eslint-scope.Reference} reference The reference to check.
          * @returns {boolean} `true` if the reference is a member access which
          *      is not allowed by options.
          */
@@ -98,8 +95,7 @@ module.exports = {
 
         /**
          * Reports the given reference as a violation.
-         *
-         * @param {eslint-scope.Reference} reference - The reference to report.
+         * @param {eslint-scope.Reference} reference The reference to report.
          * @returns {void}
          */
         function report(reference) {

package/lib/rules/no-const-assign.js

@@ -33,7 +33,7 @@ module.exports = {
 
         /**
          * Finds and reports references that are non initializer and writable.
-         * @param {Variable} variable - A variable to check.
+         * @param {Variable} variable A variable to check.
          * @returns {void}
          */
         function checkVariable(variable) {

package/lib/rules/no-dupe-args.js

@@ -35,7 +35,7 @@ module.exports = {
 
         /**
          * Checks whether or not a given definition is a parameter's.
-         * @param {eslint-scope.DefEntry} def - A definition to check.
+         * @param {eslint-scope.DefEntry} def A definition to check.
          * @returns {boolean} `true` if the definition is a parameter's.
          */
         function isParameter(def) {

package/lib/rules/no-dupe-class-members.js

@@ -32,8 +32,8 @@ module.exports = {
 
         /**
          * Gets state of a given member name.
-         * @param {string} name - A name of a member.
-         * @param {boolean} isStatic - A flag which specifies that is a static member.
+         * @param {string} name A name of a member.
+         * @param {boolean} isStatic A flag which specifies that is a static member.
          * @returns {Object} A state of a given member name.
          *   - retv.init {boolean} A flag which shows the name is declared as normal member.
          *   - retv.get {boolean} A flag which shows the name is declared as getter.
@@ -55,8 +55,7 @@ module.exports = {
 
         /**
          * Gets the name text of a given node.
-         *
-         * @param {ASTNode} node - A node to get the name.
+         * @param {ASTNode} node A node to get the name.
          * @returns {string} The name text of the node.
          */
         function getName(node) {

package/lib/rules/no-dupe-keys.js

@@ -23,9 +23,10 @@ const SET_KIND = /^(?:init|set)$/u;
  */
 class ObjectInfo {
 
+    // eslint-disable-next-line jsdoc/require-description
     /**
-     * @param {ObjectInfo|null} upper - The information of the outer object.
-     * @param {ASTNode} node - The ObjectExpression node of this information.
+     * @param {ObjectInfo|null} upper The information of the outer object.
+     * @param {ASTNode} node The ObjectExpression node of this information.
      */
     constructor(upper, node) {
         this.upper = upper;
@@ -35,7 +36,7 @@ class ObjectInfo {
 
     /**
      * Gets the information of the given Property node.
-     * @param {ASTNode} node - The Property node to get.
+     * @param {ASTNode} node The Property node to get.
      * @returns {{get: boolean, set: boolean}} The information of the property.
      */
     getPropertyInfo(node) {
@@ -49,7 +50,7 @@ class ObjectInfo {
 
     /**
      * Checks whether the given property has been defined already or not.
-     * @param {ASTNode} node - The Property node to check.
+     * @param {ASTNode} node The Property node to check.
      * @returns {boolean} `true` if the property has been defined.
      */
     isPropertyDefined(node) {
@@ -63,7 +64,7 @@ class ObjectInfo {
 
     /**
      * Defines the given property.
-     * @param {ASTNode} node - The Property node to define.
+     * @param {ASTNode} node The Property node to define.
      * @returns {void}
      */
     defineProperty(node) {