eslint 6.3.0 → 6.6.0

package/lib/rules/array-bracket-spacing.js

@@ -59,7 +59,7 @@ module.exports = {
          * Determines whether an option is set, relative to the spacing option.
          * If spaced is "always", then check whether option is set to false.
          * If spaced is "never", then check whether option is set to true.
-         * @param {Object} option - The option to exclude.
+         * @param {Object} option The option to exclude.
          * @returns {boolean} Whether or not the property is excluded.
          */
         function isOptionSet(option) {
@@ -79,8 +79,8 @@ module.exports = {
 
         /**
          * Reports that there shouldn't be a space after the first token
-         * @param {ASTNode} node - The node to report in the event of an error.
-         * @param {Token} token - The token to use for the report.
+         * @param {ASTNode} node The node to report in the event of an error.
+         * @param {Token} token The token to use for the report.
          * @returns {void}
          */
         function reportNoBeginningSpace(node, token) {
@@ -101,8 +101,8 @@ module.exports = {
 
         /**
          * Reports that there shouldn't be a space before the last token
-         * @param {ASTNode} node - The node to report in the event of an error.
-         * @param {Token} token - The token to use for the report.
+         * @param {ASTNode} node The node to report in the event of an error.
+         * @param {Token} token The token to use for the report.
          * @returns {void}
          */
         function reportNoEndingSpace(node, token) {
@@ -123,8 +123,8 @@ module.exports = {
 
         /**
          * Reports that there should be a space after the first token
-         * @param {ASTNode} node - The node to report in the event of an error.
-         * @param {Token} token - The token to use for the report.
+         * @param {ASTNode} node The node to report in the event of an error.
+         * @param {Token} token The token to use for the report.
          * @returns {void}
          */
         function reportRequiredBeginningSpace(node, token) {
@@ -143,8 +143,8 @@ module.exports = {
 
         /**
          * Reports that there should be a space before the last token
-         * @param {ASTNode} node - The node to report in the event of an error.
-         * @param {Token} token - The token to use for the report.
+         * @param {ASTNode} node The node to report in the event of an error.
+         * @param {Token} token The token to use for the report.
          * @returns {void}
          */
         function reportRequiredEndingSpace(node, token) {
@@ -163,7 +163,7 @@ module.exports = {
 
         /**
          * Determines if a node is an object type
-         * @param {ASTNode} node - The node to check.
+         * @param {ASTNode} node The node to check.
          * @returns {boolean} Whether or not the node is an object type.
          */
         function isObjectType(node) {
@@ -172,7 +172,7 @@ module.exports = {
 
         /**
          * Determines if a node is an array type
-         * @param {ASTNode} node - The node to check.
+         * @param {ASTNode} node The node to check.
          * @returns {boolean} Whether or not the node is an array type.
          */
         function isArrayType(node) {
@@ -181,7 +181,7 @@ module.exports = {
 
         /**
          * Validates the spacing around array brackets
-         * @param {ASTNode} node - The node we're checking for spacing
+         * @param {ASTNode} node The node we're checking for spacing
          * @returns {void}
          */
         function validateArraySpacing(node) {

package/lib/rules/array-callback-return.js

@@ -22,8 +22,7 @@ const TARGET_METHODS = /^(?:every|filter|find(?:Index)?|map|reduce(?:Right)?|som
 
 /**
  * Checks a given code path segment is reachable.
- *
- * @param {CodePathSegment} segment - A segment to check.
+ * @param {CodePathSegment} segment A segment to check.
  * @returns {boolean} `true` if the segment is reachable.
  */
 function isReachable(segment) {
@@ -35,9 +34,8 @@ function isReachable(segment) {
  *
  * - FunctionExpression -> the function name or `function` keyword.
  * - ArrowFunctionExpression -> `=>` token.
- *
- * @param {ASTNode} node - A function node to get.
- * @param {SourceCode} sourceCode - A source code to get tokens.
+ * @param {ASTNode} node A function node to get.
+ * @param {SourceCode} sourceCode A source code to get tokens.
  * @returns {ASTNode|Token} The node or the token of a location.
  */
 function getLocation(node, sourceCode) {
@@ -50,8 +48,7 @@ function getLocation(node, sourceCode) {
 /**
  * Checks a given node is a MemberExpression node which has the specified name's
  * property.
- *
- * @param {ASTNode} node - A node to check.
+ * @param {ASTNode} node A node to check.
  * @returns {boolean} `true` if the node is a MemberExpression node which has
  *      the specified name's property
  */
@@ -65,8 +62,7 @@ function isTargetMethod(node) {
 /**
  * Checks whether or not a given node is a function expression which is the
  * callback of an array method.
- *
- * @param {ASTNode} node - A node to check. This is one of
+ * @param {ASTNode} node A node to check. This is one of
  *      FunctionExpression or ArrowFunctionExpression.
  * @returns {boolean} `true` if the node is the callback of an array method.
  */
@@ -188,8 +184,7 @@ module.exports = {
          *
          * If the last code path segment is reachable, there are paths which are not
          * returned or thrown.
-         *
-         * @param {ASTNode} node - A node to check.
+         * @param {ASTNode} node A node to check.
          * @returns {void}
          */
         function checkLastSegment(node) {

package/lib/rules/array-element-newline.js

@@ -62,8 +62,7 @@ module.exports = {
 
         /**
          * Normalizes a given option value.
-         *
-         * @param {string|Object|undefined} providedOption - An option value to parse.
+         * @param {string|Object|undefined} providedOption An option value to parse.
          * @returns {{multiline: boolean, minItems: number}} Normalized option object.
          */
         function normalizeOptionValue(providedOption) {
@@ -90,8 +89,7 @@ module.exports = {
 
         /**
          * Normalizes a given option value.
-         *
-         * @param {string|Object|undefined} options - An option value to parse.
+         * @param {string|Object|undefined} options An option value to parse.
          * @returns {{ArrayExpression: {multiline: boolean, minItems: number}, ArrayPattern: {multiline: boolean, minItems: number}}} Normalized option object.
          */
         function normalizeOptions(options) {
@@ -102,7 +100,7 @@ module.exports = {
 
         /**
          * Reports that there shouldn't be a line break after the first token
-         * @param {Token} token - The token to use for the report.
+         * @param {Token} token The token to use for the report.
          * @returns {void}
          */
         function reportNoLineBreak(token) {
@@ -151,7 +149,7 @@ module.exports = {
 
         /**
          * Reports that there should be a line break after the first token
-         * @param {Token} token - The token to use for the report.
+         * @param {Token} token The token to use for the report.
          * @returns {void}
          */
         function reportRequiredLineBreak(token) {
@@ -171,8 +169,7 @@ module.exports = {
 
         /**
          * Reports a given node if it violated this rule.
-         *
-         * @param {ASTNode} node - A node to check. This is an ObjectExpression node or an ObjectPattern node.
+         * @param {ASTNode} node A node to check. This is an ObjectExpression node or an ObjectPattern node.
          * @returns {void}
          */
         function check(node) {

package/lib/rules/arrow-parens.js

@@ -16,7 +16,6 @@ const astUtils = require("./utils/ast-utils");
 
 /**
  * Get location should be reported by AST node.
- *
  * @param {ASTNode} node AST Node.
  * @returns {Location} Location information.
  */

package/lib/rules/block-scoped-var.js

@@ -31,7 +31,7 @@ module.exports = {
 
         /**
          * Makes a block scope.
-         * @param {ASTNode} node - A node of a scope.
+         * @param {ASTNode} node A node of a scope.
          * @returns {void}
          */
         function enterScope(node) {
@@ -48,7 +48,7 @@ module.exports = {
 
         /**
          * Reports a given reference.
-         * @param {eslint-scope.Reference} reference - A reference to report.
+         * @param {eslint-scope.Reference} reference A reference to report.
          * @returns {void}
          */
         function report(reference) {
@@ -59,7 +59,7 @@ module.exports = {
 
         /**
          * Finds and reports references which are outside of valid scopes.
-         * @param {ASTNode} node - A node to get variables.
+         * @param {ASTNode} node A node to get variables.
          * @returns {void}
          */
         function checkForVariables(node) {

package/lib/rules/block-spacing.js

@@ -41,7 +41,7 @@ module.exports = {
 
         /**
          * Gets the open brace token from a given node.
-         * @param {ASTNode} node - A BlockStatement/SwitchStatement node to get.
+         * @param {ASTNode} node A BlockStatement/SwitchStatement node to get.
          * @returns {Token} The token of the open brace.
          */
         function getOpenBrace(node) {
@@ -58,8 +58,8 @@ module.exports = {
          * Checks whether or not:
          *   - given tokens are on same line.
          *   - there is/isn't a space between given tokens.
-         * @param {Token} left - A token to check.
-         * @param {Token} right - The token which is next to `left`.
+         * @param {Token} left A token to check.
+         * @param {Token} right The token which is next to `left`.
          * @returns {boolean}
          *    When the option is `"always"`, `true` if there are one or more spaces between given tokens.
          *    When the option is `"never"`, `true` if there are not any spaces between given tokens.
@@ -74,7 +74,7 @@ module.exports = {
 
         /**
          * Reports invalid spacing style inside braces.
-         * @param {ASTNode} node - A BlockStatement/SwitchStatement node to get.
+         * @param {ASTNode} node A BlockStatement/SwitchStatement node to get.
          * @returns {void}
          */
         function checkSpacingInsideBraces(node) {

package/lib/rules/capitalized-comments.js

@@ -54,23 +54,21 @@ const DEFAULTS = {
  *   set is returned. Options specified in overrides will take priority
  *   over options specified in the main options object, which will in
  *   turn take priority over the rule's defaults.
- *
  * @param {Object|string} rawOptions The user-provided options.
  * @param {string} which Either "line" or "block".
  * @returns {Object} The normalized options.
  */
-function getNormalizedOptions(rawOptions = {}, which) {
+function getNormalizedOptions(rawOptions, which) {
     return Object.assign({}, DEFAULTS, rawOptions[which] || rawOptions);
 }
 
 /**
  * Get normalized options for block and line comments.
- *
  * @param {Object|string} rawOptions The user-provided options.
  * @returns {Object} An object with "Line" and "Block" keys and corresponding
  * normalized options objects.
  */
-function getAllNormalizedOptions(rawOptions) {
+function getAllNormalizedOptions(rawOptions = {}) {
     return {
         Line: getNormalizedOptions(rawOptions, "line"),
         Block: getNormalizedOptions(rawOptions, "block")
@@ -82,7 +80,6 @@ function getAllNormalizedOptions(rawOptions) {
  * options.
  *
  * This is done in order to avoid invoking the RegExp constructor repeatedly.
- *
  * @param {Object} normalizedOptions The normalized rule options.
  * @returns {void}
  */
@@ -162,7 +159,6 @@ module.exports = {
          * Also, it follows from this definition that only block comments can
          * be considered as possibly inline. This is because line comments
          * would consume any following tokens on the same line as the comment.
-         *
          * @param {ASTNode} comment The comment node to check.
          * @returns {boolean} True if the comment is an inline comment, false
          * otherwise.
@@ -181,7 +177,6 @@ module.exports = {
 
         /**
          * Determine if a comment follows another comment.
-         *
          * @param {ASTNode} comment The comment to check.
          * @returns {boolean} True if the comment follows a valid comment.
          */
@@ -196,7 +191,6 @@ module.exports = {
 
         /**
          * Check a comment to determine if it is valid for this rule.
-         *
          * @param {ASTNode} comment The comment node to process.
          * @param {Object} options The options for checking this comment.
          * @returns {boolean} True if the comment is valid, false otherwise.
@@ -261,7 +255,6 @@ module.exports = {
 
         /**
          * Process a comment to determine if it needs to be reported.
-         *
          * @param {ASTNode} comment The comment node to process.
          * @returns {void}
          */

package/lib/rules/class-methods-use-this.js

@@ -61,7 +61,7 @@ module.exports = {
 
         /**
          * Check if the node is an instance method
-         * @param {ASTNode} node - node to check
+         * @param {ASTNode} node node to check
          * @returns {boolean} True if its an instance method
          * @private
          */
@@ -71,7 +71,7 @@ module.exports = {
 
         /**
          * Check if the node is an instance method not excluded by config
-         * @param {ASTNode} node - node to check
+         * @param {ASTNode} node node to check
          * @returns {boolean} True if it is an instance method, and not excluded by config
          * @private
          */
@@ -84,7 +84,7 @@ module.exports = {
          * Checks if we are leaving a function that is a method, and reports if 'this' has not been used.
          * Static methods and the constructor are exempt.
          * Then pops the context off the stack.
-         * @param {ASTNode} node - A function node that was entered.
+         * @param {ASTNode} node A function node that was entered.
          * @returns {void}
          * @private
          */

package/lib/rules/comma-dangle.js

@@ -27,8 +27,7 @@ const DEFAULT_OPTIONS = Object.freeze({
 /**
  * Checks whether or not a trailing comma is allowed in a given node.
  * If the `lastItem` is `RestElement` or `RestProperty`, it disallows trailing commas.
- *
- * @param {ASTNode} lastItem - The node of the last element in the given node.
+ * @param {ASTNode} lastItem The node of the last element in the given node.
  * @returns {boolean} `true` if a trailing comma is allowed.
  */
 function isTrailingCommaAllowed(lastItem) {
@@ -41,20 +40,18 @@ function isTrailingCommaAllowed(lastItem) {
 
 /**
  * Normalize option value.
- *
- * @param {string|Object|undefined} optionValue - The 1st option value to normalize.
+ * @param {string|Object|undefined} optionValue The 1st option value to normalize.
+ * @param {number} ecmaVersion The normalized ECMAScript version.
  * @returns {Object} The normalized option value.
  */
-function normalizeOptions(optionValue) {
+function normalizeOptions(optionValue, ecmaVersion) {
     if (typeof optionValue === "string") {
         return {
             arrays: optionValue,
             objects: optionValue,
             imports: optionValue,
             exports: optionValue,
-
-            // For backward compatibility, always ignore functions.
-            functions: "ignore"
+            functions: (!ecmaVersion || ecmaVersion < 8) ? "ignore" : optionValue
         };
     }
     if (typeof optionValue === "object" && optionValue !== null) {
@@ -137,12 +134,13 @@ module.exports = {
     },
 
     create(context) {
-        const options = normalizeOptions(context.options[0]);
+        const options = normalizeOptions(context.options[0], context.parserOptions.ecmaVersion);
+
         const sourceCode = context.getSourceCode();
 
         /**
          * Gets the last item of the given node.
-         * @param {ASTNode} node - The node to get.
+         * @param {ASTNode} node The node to get.
          * @returns {ASTNode|null} The last node or null.
          */
         function getLastItem(node) {
@@ -172,9 +170,8 @@ module.exports = {
          * Gets the trailing comma token of the given node.
          * If the trailing comma does not exist, this returns the token which is
          * the insertion point of the trailing comma token.
-         *
-         * @param {ASTNode} node - The node to get.
-         * @param {ASTNode} lastItem - The last item of the node.
+         * @param {ASTNode} node The node to get.
+         * @param {ASTNode} lastItem The last item of the node.
          * @returns {Token} The trailing comma token or the insertion point.
          */
         function getTrailingToken(node, lastItem) {
@@ -199,8 +196,7 @@ module.exports = {
          * Checks whether or not a given node is multiline.
          * This rule handles a given node as multiline when the closing parenthesis
          * and the last element are not on the same line.
-         *
-         * @param {ASTNode} node - A node to check.
+         * @param {ASTNode} node A node to check.
          * @returns {boolean} `true` if the node is multiline.
          */
         function isMultiline(node) {
@@ -218,8 +214,7 @@ module.exports = {
 
         /**
          * Reports a trailing comma if it exists.
-         *
-         * @param {ASTNode} node - A node to check. Its type is one of
+         * @param {ASTNode} node A node to check. Its type is one of
          *   ObjectExpression, ObjectPattern, ArrayExpression, ArrayPattern,
          *   ImportDeclaration, and ExportNamedDeclaration.
          * @returns {void}
@@ -251,8 +246,7 @@ module.exports = {
          *
          * If a given node is `ArrayPattern` which has `RestElement`, the trailing
          * comma is disallowed, so report if it exists.
-         *
-         * @param {ASTNode} node - A node to check. Its type is one of
+         * @param {ASTNode} node A node to check. Its type is one of
          *   ObjectExpression, ObjectPattern, ArrayExpression, ArrayPattern,
          *   ImportDeclaration, and ExportNamedDeclaration.
          * @returns {void}
@@ -286,8 +280,7 @@ module.exports = {
          * If a given node is multiline, reports the last element of a given node
          * when it does not have a trailing comma.
          * Otherwise, reports a trailing comma if it exists.
-         *
-         * @param {ASTNode} node - A node to check. Its type is one of
+         * @param {ASTNode} node A node to check. Its type is one of
          *   ObjectExpression, ObjectPattern, ArrayExpression, ArrayPattern,
          *   ImportDeclaration, and ExportNamedDeclaration.
          * @returns {void}
@@ -304,8 +297,7 @@ module.exports = {
          * Only if a given node is not multiline, reports the last element of a given node
          * when it does not have a trailing comma.
          * Otherwise, reports a trailing comma if it exists.
-         *
-         * @param {ASTNode} node - A node to check. Its type is one of
+         * @param {ASTNode} node A node to check. Its type is one of
          *   ObjectExpression, ObjectPattern, ArrayExpression, ArrayPattern,
          *   ImportDeclaration, and ExportNamedDeclaration.
          * @returns {void}

package/lib/rules/comma-spacing.js

@@ -105,7 +105,7 @@ module.exports = {
 
         /**
          * Validates the spacing around a comma token.
-         * @param {Object} tokens - The tokens to be validated.
+         * @param {Object} tokens The tokens to be validated.
          * @param {Token} tokens.comma The token representing the comma.
          * @param {Token} [tokens.left] The last token before the comma.
          * @param {Token} [tokens.right] The first token after the comma.

package/lib/rules/computed-property-spacing.js

@@ -26,6 +26,16 @@ module.exports = {
         schema: [
             {
                 enum: ["always", "never"]
+            },
+            {
+                type: "object",
+                properties: {
+                    enforceForClassMembers: {
+                        type: "boolean",
+                        default: false
+                    }
+                },
+                additionalProperties: false
             }
         ],
 
@@ -41,6 +51,7 @@ module.exports = {
     create(context) {
         const sourceCode = context.getSourceCode();
         const propertyNameMustBeSpaced = context.options[0] === "always"; // default is "never"
+        const enforceForClassMembers = context.options[1] && context.options[1].enforceForClassMembers;
 
         //--------------------------------------------------------------------------
         // Helpers
@@ -48,9 +59,9 @@ module.exports = {
 
         /**
          * Reports that there shouldn't be a space after the first token
-         * @param {ASTNode} node - The node to report in the event of an error.
-         * @param {Token} token - The token to use for the report.
-         * @param {Token} tokenAfter - The token after `token`.
+         * @param {ASTNode} node The node to report in the event of an error.
+         * @param {Token} token The token to use for the report.
+         * @param {Token} tokenAfter The token after `token`.
          * @returns {void}
          */
         function reportNoBeginningSpace(node, token, tokenAfter) {
@@ -69,9 +80,9 @@ module.exports = {
 
         /**
          * Reports that there shouldn't be a space before the last token
-         * @param {ASTNode} node - The node to report in the event of an error.
-         * @param {Token} token - The token to use for the report.
-         * @param {Token} tokenBefore - The token before `token`.
+         * @param {ASTNode} node The node to report in the event of an error.
+         * @param {Token} token The token to use for the report.
+         * @param {Token} tokenBefore The token before `token`.
          * @returns {void}
          */
         function reportNoEndingSpace(node, token, tokenBefore) {
@@ -90,8 +101,8 @@ module.exports = {
 
         /**
          * Reports that there should be a space after the first token
-         * @param {ASTNode} node - The node to report in the event of an error.
-         * @param {Token} token - The token to use for the report.
+         * @param {ASTNode} node The node to report in the event of an error.
+         * @param {Token} token The token to use for the report.
          * @returns {void}
          */
         function reportRequiredBeginningSpace(node, token) {
@@ -110,8 +121,8 @@ module.exports = {
 
         /**
          * Reports that there should be a space before the last token
-         * @param {ASTNode} node - The node to report in the event of an error.
-         * @param {Token} token - The token to use for the report.
+         * @param {ASTNode} node The node to report in the event of an error.
+         * @param {Token} token The token to use for the report.
          * @returns {void}
          */
         function reportRequiredEndingSpace(node, token) {
@@ -178,10 +189,16 @@ module.exports = {
         // Public
         //--------------------------------------------------------------------------
 
-        return {
+        const listeners = {
             Property: checkSpacing("key"),
             MemberExpression: checkSpacing("property")
         };
 
+        if (enforceForClassMembers) {
+            listeners.MethodDefinition = checkSpacing("key");
+        }
+
+        return listeners;
+
     }
 };

package/lib/rules/consistent-return.js

@@ -18,8 +18,8 @@ const astUtils = require("./utils/ast-utils");
 
 /**
  * Checks whether or not a given node is an `Identifier` node which was named a given name.
- * @param {ASTNode} node - A node to check.
- * @param {string} name - An expected name of the node.
+ * @param {ASTNode} node A node to check.
+ * @param {string} name An expected name of the node.
  * @returns {boolean} `true` if the node is an `Identifier` node which was named as expected.
  */
 function isIdentifier(node, name) {
@@ -28,7 +28,7 @@ function isIdentifier(node, name) {
 
 /**
  * Checks whether or not a given code path segment is unreachable.
- * @param {CodePathSegment} segment - A CodePathSegment to check.
+ * @param {CodePathSegment} segment A CodePathSegment to check.
  * @returns {boolean} `true` if the segment is unreachable.
  */
 function isUnreachable(segment) {
@@ -88,8 +88,7 @@ module.exports = {
         /**
          * Checks whether of not the implicit returning is consistent if the last
          * code path segment is reachable.
-         *
-         * @param {ASTNode} node - A program/function node to check.
+         * @param {ASTNode} node A program/function node to check.
          * @returns {void}
          */
         function checkLastSegment(node) {

package/lib/rules/consistent-this.js

@@ -46,8 +46,8 @@ module.exports = {
         /**
          * Reports that a variable declarator or assignment expression is assigning
          * a non-'this' value to the specified alias.
-         * @param {ASTNode} node - The assigning node.
-         * @param {string}  name - the name of the alias that was incorrectly used.
+         * @param {ASTNode} node The assigning node.
+         * @param {string}  name the name of the alias that was incorrectly used.
          * @returns {void}
          */
         function reportBadAssignment(node, name) {
@@ -57,9 +57,9 @@ module.exports = {
         /**
          * Checks that an assignment to an identifier only assigns 'this' to the
          * appropriate alias, and the alias is only assigned to 'this'.
-         * @param {ASTNode} node - The assigning node.
-         * @param {Identifier} name - The name of the variable assigned to.
-         * @param {Expression} value - The value of the assignment.
+         * @param {ASTNode} node The assigning node.
+         * @param {Identifier} name The name of the variable assigned to.
+         * @param {Expression} value The value of the assignment.
          * @returns {void}
          */
         function checkAssignment(node, name, value) {