eslint 5.8.0 → 5.9.0

package/lib/rules/no-prototype-builtins.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow calling some `Object.prototype` methods directly on objects",
             category: "Possible Errors",

package/lib/rules/no-redeclare.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow variable redeclaration",
             category: "Best Practices",

package/lib/rules/no-regex-spaces.js

@@ -13,6 +13,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow multiple spaces in regular expressions",
             category: "Possible Errors",
@@ -21,7 +23,6 @@ module.exports = {
         },
 
         schema: [],
-
         fixable: "code"
     },
 

package/lib/rules/no-restricted-globals.js

@@ -17,6 +17,8 @@ const DEFAULT_MESSAGE_TEMPLATE = "Unexpected use of '{{name}}'.",
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow specified global variables",
             category: "Variables",

package/lib/rules/no-restricted-imports.js

@@ -53,6 +53,8 @@ const arrayOfStringsOrObjects = {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow specified modules when loaded by `import`",
             category: "ECMAScript 6",
@@ -234,31 +236,47 @@ module.exports = {
             return restrictedPatterns.length > 0 && restrictedPatternsMatcher.ignores(importSource);
         }
 
-        return {
-            ImportDeclaration(node) {
-                const importSource = node.source.value.trim();
-                const importNames = node.specifiers.reduce((set, specifier) => {
-                    if (specifier.type === "ImportDefaultSpecifier") {
-                        set.add("default");
-                    } else if (specifier.type === "ImportNamespaceSpecifier") {
-                        set.add("*");
-                    } else {
-                        set.add(specifier.imported.name);
-                    }
-                    return set;
-                }, new Set());
-
-                if (isRestrictedForEverythingImported(importSource, importNames)) {
-                    reportPathForEverythingImported(importSource, node);
+        /**
+         * Checks a node to see if any problems should be reported.
+         * @param {ASTNode} node The node to check.
+         * @returns {void}
+         * @private
+         */
+        function checkNode(node) {
+            const importSource = node.source.value.trim();
+            const importNames = node.specifiers ? node.specifiers.reduce((set, specifier) => {
+                if (specifier.type === "ImportDefaultSpecifier") {
+                    set.add("default");
+                } else if (specifier.type === "ImportNamespaceSpecifier") {
+                    set.add("*");
+                } else if (specifier.imported) {
+                    set.add(specifier.imported.name);
+                } else if (specifier.local) {
+                    set.add(specifier.local.name);
                 }
+                return set;
+            }, new Set()) : new Set();
 
-                if (isRestrictedPath(importSource, importNames)) {
-                    reportPath(node);
-                }
-                if (isRestrictedPattern(importSource)) {
-                    reportPathForPatterns(node);
-                }
+            if (isRestrictedForEverythingImported(importSource, importNames)) {
+                reportPathForEverythingImported(importSource, node);
+            }
+
+            if (isRestrictedPath(importSource, importNames)) {
+                reportPath(node);
+            }
+            if (isRestrictedPattern(importSource)) {
+                reportPathForPatterns(node);
             }
+        }
+
+        return {
+            ImportDeclaration: checkNode,
+            ExportNamedDeclaration(node) {
+                if (node.source) {
+                    checkNode(node);
+                }
+            },
+            ExportAllDeclaration: checkNode
         };
     }
 };

package/lib/rules/no-restricted-modules.js

@@ -47,6 +47,8 @@ const arrayOfStringsOrObjects = {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow specified modules when loaded by `require`",
             category: "Node.js and CommonJS",

package/lib/rules/no-restricted-properties.js

@@ -13,6 +13,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow certain properties on certain objects",
             category: "Best Practices",

package/lib/rules/no-restricted-syntax.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow specified syntax",
             category: "Stylistic Issues",

package/lib/rules/no-return-assign.js

@@ -22,6 +22,8 @@ const SENTINEL_TYPE = /^(?:[a-zA-Z]+?Statement|ArrowFunctionExpression|FunctionE
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow assignment operators in `return` statements",
             category: "Best Practices",

package/lib/rules/no-return-await.js

@@ -14,6 +14,8 @@ const message = "Redundant use of `await` on a return value.";
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary `return await`",
             category: "Best Practices",
@@ -22,7 +24,9 @@ module.exports = {
 
             url: "https://eslint.org/docs/rules/no-return-await"
         },
+
         fixable: null,
+
         schema: [
         ]
     },

package/lib/rules/no-script-url.js

@@ -13,6 +13,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `javascript:` urls",
             category: "Best Practices",

package/lib/rules/no-self-assign.js

@@ -165,6 +165,8 @@ function eachSelfAssignment(left, right, props, report) {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow assignments where both sides are exactly the same",
             category: "Best Practices",

package/lib/rules/no-self-compare.js

@@ -12,6 +12,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow comparisons where both sides are exactly the same",
             category: "Best Practices",

package/lib/rules/no-sequences.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow comma operators",
             category: "Best Practices",

package/lib/rules/no-shadow-restricted-names.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow identifiers from shadowing restricted names",
             category: "Variables",

package/lib/rules/no-shadow.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow variable declarations from shadowing variables declared in the outer scope",
             category: "Variables",

package/lib/rules/no-spaced-func.js

@@ -12,16 +12,19 @@
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "disallow spacing between function identifiers and their applications (deprecated)",
             category: "Stylistic Issues",
             recommended: false,
-            replacedBy: ["func-call-spacing"],
             url: "https://eslint.org/docs/rules/no-spaced-func"
         },
 
         deprecated: true,
 
+        replacedBy: ["func-call-spacing"],
+
         fixable: "whitespace",
         schema: []
     },

package/lib/rules/no-sparse-arrays.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow sparse arrays",
             category: "Possible Errors",

package/lib/rules/no-sync.js

@@ -13,6 +13,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow synchronous methods",
             category: "Node.js and CommonJS",

package/lib/rules/no-tabs.js

@@ -18,6 +18,8 @@ const anyNonWhitespaceRegex = /\S/;
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "disallow all tabs",
             category: "Stylistic Issues",

package/lib/rules/no-template-curly-in-string.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow template literal placeholder syntax in regular strings",
             category: "Possible Errors",

package/lib/rules/no-ternary.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow ternary operators",
             category: "Stylistic Issues",

package/lib/rules/no-this-before-super.js

@@ -36,6 +36,8 @@ function isConstructorFunction(node) {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow `this`/`super` before calling `super()` in constructors",
             category: "ECMAScript 6",

package/lib/rules/no-throw-literal.js

@@ -13,6 +13,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow throwing literals as exceptions",
             category: "Best Practices",

package/lib/rules/no-trailing-spaces.js

@@ -16,6 +16,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "disallow trailing whitespace at the end of lines",
             category: "Stylistic Issues",

package/lib/rules/no-undef-init.js

@@ -13,6 +13,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow initializing variables to `undefined`",
             category: "Variables",
@@ -21,7 +23,6 @@ module.exports = {
         },
 
         schema: [],
-
         fixable: "code"
     },
 

package/lib/rules/no-undef.js

@@ -25,6 +25,8 @@ function hasTypeOfOperator(node) {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow the use of undeclared variables unless mentioned in `/*global */` comments",
             category: "Variables",

package/lib/rules/no-undefined.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow the use of `undefined` as an identifier",
             category: "Variables",

package/lib/rules/no-underscore-dangle.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow dangling underscores in identifiers",
             category: "Stylistic Issues",

package/lib/rules/no-unexpected-multiline.js

@@ -16,6 +16,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow confusing multiline expressions",
             category: "Possible Errors",

package/lib/rules/no-unmodified-loop-condition.js

@@ -165,6 +165,8 @@ function updateModifiedFlag(conditions, modifiers) {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow unmodified loop conditions",
             category: "Best Practices",

package/lib/rules/no-unneeded-ternary.js

@@ -24,6 +24,8 @@ const OPERATOR_INVERSES = {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow ternary operators when simpler alternatives exist",
             category: "Stylistic Issues",

package/lib/rules/no-unreachable.js

@@ -101,6 +101,8 @@ class ConsecutiveRange {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow unreachable code after `return`, `throw`, `continue`, and `break` statements",
             category: "Possible Errors",
@@ -180,7 +182,6 @@ module.exports = {
             ContinueStatement: reportIfUnreachable,
             DebuggerStatement: reportIfUnreachable,
             DoWhileStatement: reportIfUnreachable,
-            EmptyStatement: reportIfUnreachable,
             ExpressionStatement: reportIfUnreachable,
             ForInStatement: reportIfUnreachable,
             ForOfStatement: reportIfUnreachable,

package/lib/rules/no-unsafe-finally.js

@@ -20,6 +20,8 @@ const SENTINEL_NODE_TYPE_CONTINUE = /^(?:Program|(?:Function|Class)(?:Declaratio
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow control flow statements in `finally` blocks",
             category: "Possible Errors",

package/lib/rules/no-unsafe-negation.js

@@ -41,12 +41,15 @@ function isNegation(node) {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow negating the left operand of relational operators",
             category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-unsafe-negation"
         },
+
         schema: [],
         fixable: "code"
     },

package/lib/rules/no-unused-expressions.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unused expressions",
             category: "Best Practices",

package/lib/rules/no-unused-labels.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unused labels",
             category: "Best Practices",
@@ -19,7 +21,6 @@ module.exports = {
         },
 
         schema: [],
-
         fixable: "code"
     },
 

package/lib/rules/no-unused-vars.js

@@ -18,6 +18,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow unused variables",
             category: "Variables",
@@ -223,6 +225,32 @@ module.exports = {
             return false;
         }
 
+        /**
+         * Gets a list of function definitions for a specified variable.
+         * @param {Variable} variable - eslint-scope variable object.
+         * @returns {ASTNode[]} Function nodes.
+         * @private
+         */
+        function getFunctionDefinitions(variable) {
+            const functionDefinitions = [];
+
+            variable.defs.forEach(def => {
+                const { type, node } = def;
+
+                // FunctionDeclarations
+                if (type === "FunctionName") {
+                    functionDefinitions.push(node);
+                }
+
+                // FunctionExpressions
+                if (type === "Variable" && node.init &&
+                    (node.init.type === "FunctionExpression" || node.init.type === "ArrowFunctionExpression")) {
+                    functionDefinitions.push(node.init);
+                }
+            });
+            return functionDefinitions;
+        }
+
         /**
          * Checks the position of given nodes.
          *
@@ -372,22 +400,18 @@ module.exports = {
             return ref.isRead() && (
 
                 // self update. e.g. `a += 1`, `a++`
-                (
-                    parent.type === "AssignmentExpression" &&
+                (// in RHS of an assignment for itself. e.g. `a = a + 1`
+                    ((
+                        parent.type === "AssignmentExpression" &&
                     granpa.type === "ExpressionStatement" &&
                     parent.left === id
-                ) ||
+                    ) ||
                 (
                     parent.type === "UpdateExpression" &&
                     granpa.type === "ExpressionStatement"
-                ) ||
-
-                // in RHS of an assignment for itself. e.g. `a = a + 1`
-                (
-                    rhsNode &&
-                    isInside(id, rhsNode) &&
-                    !isInsideOfStorableFunction(id, rhsNode)
-                )
+                ) || rhsNode &&
+                isInside(id, rhsNode) &&
+                !isInsideOfStorableFunction(id, rhsNode)))
             );
         }
 
@@ -435,7 +459,7 @@ module.exports = {
          * @private
          */
         function isUsedVariable(variable) {
-            const functionNodes = variable.defs.filter(def => def.type === "FunctionName").map(def => def.node),
+            const functionNodes = getFunctionDefinitions(variable),
                 isFunctionDefinition = functionNodes.length > 0;
             let rhsNode = null;
 

package/lib/rules/no-use-before-define.js

@@ -136,6 +136,8 @@ function isInInitializer(variable, reference) {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow the use of variables before they are defined",
             category: "Variables",

package/lib/rules/no-useless-call.js

@@ -49,6 +49,8 @@ function isValidThisArg(expectedThis, thisArg, sourceCode) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary calls to `.call()` and `.apply()`",
             category: "Best Practices",

package/lib/rules/no-useless-computed-key.js

@@ -18,6 +18,8 @@ const MESSAGE_UNNECESSARY_COMPUTED = "Unnecessarily computed property [{{propert
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary computed property keys in object literals",
             category: "ECMAScript 6",
@@ -26,7 +28,6 @@ module.exports = {
         },
 
         schema: [],
-
         fixable: "code"
     },
     create(context) {

package/lib/rules/no-useless-concat.js

@@ -66,6 +66,8 @@ function getRight(node) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary concatenation of literals or template literals",
             category: "Best Practices",

package/lib/rules/no-useless-constructor.js

@@ -142,6 +142,8 @@ function isRedundantSuperCall(body, ctorParams) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary constructors",
             category: "ECMAScript 6",

package/lib/rules/no-useless-escape.js

@@ -79,6 +79,8 @@ function parseRegExp(regExpText) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary escape characters",
             category: "Best Practices",