eslint 5.8.0 → 5.9.0

package/lib/rules/no-extend-native.js

@@ -24,6 +24,8 @@ const propertyDefinitionMethods = new Set(["defineProperty", "defineProperties"]
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow extending native types",
             category: "Best Practices",

package/lib/rules/no-extra-bind.js

@@ -22,6 +22,8 @@ const SIDE_EFFECT_FREE_NODE_TYPES = new Set(["Literal", "Identifier", "ThisExpre
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary calls to `.bind()`",
             category: "Best Practices",
@@ -30,7 +32,6 @@ module.exports = {
         },
 
         schema: [],
-
         fixable: "code",
 
         messages: {

package/lib/rules/no-extra-boolean-cast.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary boolean casts",
             category: "Possible Errors",
@@ -25,7 +27,6 @@ module.exports = {
         },
 
         schema: [],
-
         fixable: "code",
 
         messages: {

package/lib/rules/no-extra-label.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary labels",
             category: "Best Practices",
@@ -25,7 +27,6 @@ module.exports = {
         },
 
         schema: [],
-
         fixable: "code",
 
         messages: {

package/lib/rules/no-extra-parens.js

@@ -12,6 +12,8 @@ const astUtils = require("../util/ast-utils.js");
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "disallow unnecessary parentheses",
             category: "Possible Errors",
@@ -382,8 +384,7 @@ module.exports = {
                          * Allow extra parens around a new expression if
                          * there are intervening parentheses.
                          */
-                        callee.type === "MemberExpression" &&
-                        doesMemberExpressionContainCallExpression(callee)
+                        (callee.type === "MemberExpression" && doesMemberExpressionContainCallExpression(callee))
                     )
                 ) {
                     report(node.callee);
@@ -574,15 +575,13 @@ module.exports = {
                              * If `let` is the only thing on the left side of the loop, it's the loop variable: `for ((let) of foo);`
                              * Removing it will cause a syntax error, because it will be parsed as the start of a VariableDeclarator.
                              */
-                            firstLeftToken.range[1] === node.left.range[1] ||
-
-                            /*
+                            (firstLeftToken.range[1] === node.left.range[1] || /*
                              * If `let` is followed by a `[` token, it's a property access on the `let` value: `for ((let[foo]) of bar);`
                              * Removing it will cause the property access to be parsed as a destructuring declaration of `foo` instead.
                              */
                             astUtils.isOpeningBracketToken(
                                 sourceCode.getTokenAfter(firstLeftToken, astUtils.isNotClosingParenToken)
-                            )
+                            ))
                         )
                     ) {
                         tokensToIgnore.add(firstLeftToken);

package/lib/rules/no-extra-semi.js

@@ -18,6 +18,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary semicolons",
             category: "Possible Errors",

package/lib/rules/no-fallthrough.js

@@ -55,6 +55,8 @@ function hasBlankLinesBetween(node, token) {
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow fallthrough of `case` statements",
             category: "Best Practices",

package/lib/rules/no-floating-decimal.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow leading or trailing decimal points in numeric literals",
             category: "Best Practices",
@@ -25,7 +27,6 @@ module.exports = {
         },
 
         schema: [],
-
         fixable: "code"
     },
 

package/lib/rules/no-func-assign.js

@@ -13,6 +13,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow reassigning `function` declarations",
             category: "Possible Errors",

package/lib/rules/no-global-assign.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow assignments to native objects or read-only global variables",
             category: "Best Practices",

package/lib/rules/no-implicit-coercion.js

@@ -152,6 +152,8 @@ function getNonEmptyOperand(node) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow shorthand type conversions",
             category: "Best Practices",
@@ -160,6 +162,7 @@ module.exports = {
         },
 
         fixable: "code",
+
         schema: [{
             type: "object",
             properties: {

package/lib/rules/no-implicit-globals.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow variable and `function` declarations in the global scope",
             category: "Best Practices",

package/lib/rules/no-implied-eval.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow the use of `eval()`-like methods",
             category: "Best Practices",

package/lib/rules/no-inline-comments.js

@@ -12,6 +12,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow inline comments after code",
             category: "Stylistic Issues",

package/lib/rules/no-inner-declarations.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow variable or `function` declarations in nested blocks",
             category: "Possible Errors",

package/lib/rules/no-invalid-regexp.js

@@ -19,6 +19,8 @@ const undefined1 = void 0;
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow invalid regular expression strings in `RegExp` constructors",
             category: "Possible Errors",

package/lib/rules/no-invalid-this.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `this` keywords outside of classes or class-like objects",
             category: "Best Practices",

package/lib/rules/no-irregular-whitespace.js

@@ -27,6 +27,8 @@ const LINE_BREAK = astUtils.createGlobalLinebreakMatcher();
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow irregular whitespace outside of strings and comments",
             category: "Possible Errors",

package/lib/rules/no-iterator.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow the use of the `__iterator__` property",
             category: "Best Practices",

package/lib/rules/no-label-var.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow labels that share a name with a variable",
             category: "Variables",

package/lib/rules/no-labels.js

@@ -16,6 +16,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow labeled statements",
             category: "Best Practices",

package/lib/rules/no-lone-blocks.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unnecessary nested blocks",
             category: "Best Practices",

package/lib/rules/no-lonely-if.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `if` statements as the only statement in `else` blocks",
             category: "Stylistic Issues",
@@ -18,7 +20,6 @@ module.exports = {
         },
 
         schema: [],
-
         fixable: "code"
     },
 

package/lib/rules/no-loop-func.js

@@ -154,6 +154,8 @@ function isSafe(loopNode, reference) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `function` declarations and expressions inside loop statements",
             category: "Best Practices",

package/lib/rules/no-magic-numbers.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow magic numbers",
             category: "Best Practices",
@@ -40,6 +42,7 @@ module.exports = {
             },
             additionalProperties: false
         }],
+
         messages: {
             useConst: "Number constants declarations must use 'const'.",
             noMagic: "No magic number: {{raw}}."

package/lib/rules/no-misleading-character-class.js

@@ -101,13 +101,17 @@ const kinds = Object.keys(hasCharacterSequence);
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow characters which are made with multiple code points in character class syntax",
             category: "Possible Errors",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-misleading-character-class"
         },
+
         schema: [],
+
         messages: {
             surrogatePairWithoutUFlag: "Unexpected surrogate pair in character class. Use 'u' flag.",
             combiningClass: "Unexpected combined character in character class.",

package/lib/rules/no-mixed-operators.js

@@ -71,12 +71,15 @@ function includesBothInAGroup(groups, left, right) {
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow mixed binary operators",
             category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-mixed-operators"
         },
+
         schema: [
             {
                 type: "object",

package/lib/rules/no-mixed-requires.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `require` calls to be mixed with regular variable declarations",
             category: "Node.js and CommonJS",

package/lib/rules/no-mixed-spaces-and-tabs.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "disallow mixed spaces and tabs for indentation",
             category: "Stylistic Issues",

package/lib/rules/no-multi-assign.js

@@ -12,12 +12,15 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow use of chained assignment expressions",
             category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-multi-assign"
         },
+
         schema: []
     },
 

package/lib/rules/no-multi-spaces.js

@@ -13,6 +13,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "disallow multiple spaces",
             category: "Best Practices",

package/lib/rules/no-multi-str.js

@@ -17,6 +17,8 @@ const astUtils = require("../util/ast-utils");
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow multiline strings",
             category: "Best Practices",

package/lib/rules/no-multiple-empty-lines.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "layout",
+
         docs: {
             description: "disallow multiple empty lines",
             category: "Stylistic Issues",

package/lib/rules/no-native-reassign.js

@@ -12,16 +12,19 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow assignments to native objects or read-only global variables",
             category: "Best Practices",
             recommended: false,
-            replacedBy: ["no-global-assign"],
             url: "https://eslint.org/docs/rules/no-native-reassign"
         },
 
         deprecated: true,
 
+        replacedBy: ["no-global-assign"],
+
         schema: [
             {
                 type: "object",

package/lib/rules/no-negated-condition.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow negated conditions",
             category: "Stylistic Issues",

package/lib/rules/no-negated-in-lhs.js

@@ -12,15 +12,18 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow negating the left operand in `in` expressions",
             category: "Possible Errors",
             recommended: false,
-            replacedBy: ["no-unsafe-negation"],
             url: "https://eslint.org/docs/rules/no-negated-in-lhs"
         },
-        deprecated: true,
 
+        replacedBy: ["no-unsafe-negation"],
+
+        deprecated: true,
         schema: []
     },
 

package/lib/rules/no-nested-ternary.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow nested ternary expressions",
             category: "Stylistic Issues",

package/lib/rules/no-new-func.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `new` operators with the `Function` object",
             category: "Best Practices",

package/lib/rules/no-new-object.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `Object` constructors",
             category: "Stylistic Issues",

package/lib/rules/no-new-require.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `new` operators with calls to `require`",
             category: "Node.js and CommonJS",

package/lib/rules/no-new-symbol.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow `new` operators with the `Symbol` object",
             category: "ECMAScript 6",

package/lib/rules/no-new-wrappers.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `new` operators with the `String`, `Number`, and `Boolean` objects",
             category: "Best Practices",

package/lib/rules/no-new.js

@@ -12,6 +12,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow `new` operators outside of assignments or comparisons",
             category: "Best Practices",

package/lib/rules/no-obj-calls.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "problem",
+
         docs: {
             description: "disallow calling global object properties as functions",
             category: "Possible Errors",

package/lib/rules/no-octal-escape.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow octal escape sequences in string literals",
             category: "Best Practices",

package/lib/rules/no-octal.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow octal literals",
             category: "Best Practices",

package/lib/rules/no-param-reassign.js

@@ -12,6 +12,8 @@ const stopNodePattern = /(?:Statement|Declaration|Function(?:Expression)?|Progra
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow reassigning `function` parameters",
             category: "Best Practices",

package/lib/rules/no-path-concat.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow string concatenation with `__dirname` and `__filename`",
             category: "Node.js and CommonJS",

package/lib/rules/no-plusplus.js

@@ -12,6 +12,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow the unary operators `++` and `--`",
             category: "Stylistic Issues",

package/lib/rules/no-process-env.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow the use of `process.env`",
             category: "Node.js and CommonJS",

package/lib/rules/no-process-exit.js

@@ -10,6 +10,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow the use of `process.exit()`",
             category: "Node.js and CommonJS",

package/lib/rules/no-proto.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow the use of the `__proto__` property",
             category: "Best Practices",