eslint-plugin-sonarjs 4.0.3 → 4.1.0

package/cjs/S2699/rule.js

@@ -48,8 +48,20 @@ const Mocha = __importStar(require("../helpers/mocha.js"));
 const Sinon = __importStar(require("../helpers/sinon.js"));
 const Vitest = __importStar(require("../helpers/vitest.js"));
 const Supertest = __importStar(require("../helpers/supertest.js"));
+const Cypress = __importStar(require("../helpers/cypress.js"));
 const meta = __importStar(require("./generated-meta.js"));
 const typescript_1 = __importDefault(require("typescript"));
+const ASSERTION_LIBRARIES = [
+    'chai',
+    'sinon',
+    'vitest',
+    'supertest',
+    '@playwright/test',
+    'assert',
+    'node:assert',
+];
+// runners that expose assertion APIs as globals (no import required).
+const GLOBAL_ASSERTION_DEPENDENCIES = ['jasmine', 'jest', 'cypress', '@playwright/test'];
 /**
  * We assume that the user is using a single assertion library per file,
  * this is why we are not saving if an assertion has been performed for
@@ -58,10 +70,7 @@ const typescript_1 = __importDefault(require("typescript"));
 exports.rule = {
     meta: (0, generate_meta_js_1.generateMeta)(meta),
     create(context) {
-        if (!(Chai.isImported(context) ||
-            Sinon.isImported(context) ||
-            Vitest.isImported(context) ||
-            Supertest.isImported(context))) {
+        if (!hasSupportedAssertionLibrary(context)) {
             return {};
         }
         const visitedNodes = new Map();
@@ -76,6 +85,9 @@ exports.rule = {
         };
     },
 };
+function hasSupportedAssertionLibrary(context) {
+    return (0, module_js_1.importsOrDependsOnModule)(context, ASSERTION_LIBRARIES, GLOBAL_ASSERTION_DEPENDENCIES);
+}
 /**
  * Checks if a test uses the Mocha done callback as an assertion mechanism.
  * Only valid when done is called with an error argument OR passed to an error-handling position.
@@ -195,7 +207,8 @@ class TestCaseAssertionVisitor {
             Chai.isTSAssertion(services, node) ||
             Sinon.isTSAssertion(services, node) ||
             Supertest.isTSAssertion(services, node) ||
-            Vitest.isTSAssertion(services, node)) {
+            Vitest.isTSAssertion(services, node) ||
+            Cypress.isTSAssertion(node)) {
             visitedTSNodes.set(node, true);
             return true;
         }
@@ -223,6 +236,7 @@ class TestCaseAssertionVisitor {
             Sinon.isAssertion(context, node) ||
             Vitest.isAssertion(context, node) ||
             Supertest.isAssertion(context, node) ||
+            Cypress.isAssertion(node) ||
             isGlobalAssertion(context, node)) {
             visitedNodes.set(node, true);
             return true;

package/cjs/S2703/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S2703';
 exports.scope = 'Main';
 exports.languages = ['js'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S2737/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S2737';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = true;

package/cjs/S2755/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S2755';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S2757/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S2757';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S2817/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S2817';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S2819/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S2819';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S2870/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S2870';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S2871/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S2871';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S2871/rule.js

@@ -51,11 +51,34 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
+const ancestor_js_1 = require("../helpers/ancestor.js");
 const collection_js_1 = require("../helpers/collection.js");
 const generate_meta_js_1 = require("../helpers/generate-meta.js");
 const type_js_1 = require("../helpers/type.js");
 const parser_services_js_1 = require("../helpers/parser-services.js");
 const meta = __importStar(require("./generated-meta.js"));
+const allSortLike = new Set([...collection_js_1.sortLike, ...collection_js_1.copyingSortLike]);
+const equalityOperators = new Set(['==', '!=', '===', '!==']);
+// Matches JSON.stringify(<expr>) — exactly one argument, non-computed property access.
+// Does not match: JSON.stringify(x, replacer, space), JSON['stringify'](x), myObj.stringify(x).
+function isJsonStringifyCall(node) {
+    if (node.type !== 'CallExpression') {
+        return false;
+    }
+    const callExpr = node;
+    if (callExpr.arguments.length !== 1) {
+        return false;
+    }
+    const callee = callExpr.callee;
+    if (callee.type !== 'MemberExpression') {
+        return false;
+    }
+    return (!callee.computed &&
+        callee.object.type === 'Identifier' &&
+        callee.object.name === 'JSON' &&
+        callee.property.type === 'Identifier' &&
+        callee.property.name === 'stringify');
+}
 const compareNumberFunctionPlaceholder = '(a, b) => (a - b)';
 const compareBigIntFunctionPlaceholder = [
     '(a, b) => {',
@@ -90,13 +113,74 @@ exports.rule = {
                 const { object, property: node } = call.callee;
                 const text = sourceCode.getText(node);
                 const type = (0, type_js_1.getTypeFromTreeNode)(object, services);
-                if ([...collection_js_1.sortLike, ...collection_js_1.copyingSortLike].includes(text) && (0, type_js_1.isArrayLikeType)(type, services)) {
+                if (allSortLike.has(text) && (0, type_js_1.isArrayLikeType)(type, services)) {
+                    if (isJsonStringifySortComparison(call)) {
+                        return;
+                    }
                     const suggest = getSuggestions(call, type);
                     const messageId = getMessageId(type);
                     context.report({ node, suggest, messageId });
                 }
             },
         };
+        // Matches JSON.stringify(arr.sort()) == JSON.stringify(arr.sort()) or
+        // JSON.stringify(arr.toSorted()) == JSON.stringify(arr.toSorted()) when both
+        // sides use the same sort family over primitive arrays with known-safe
+        // default sort semantics (number, string, boolean, bigint).
+        function isJsonStringifySortComparison(call) {
+            const parent = (0, ancestor_js_1.getNodeParent)(call);
+            if (!isJsonStringifyCall(parent) || parent.arguments[0] !== call) {
+                return false;
+            }
+            const grandparent = (0, ancestor_js_1.getNodeParent)(parent);
+            if (grandparent.type !== 'BinaryExpression' || !equalityOperators.has(grandparent.operator)) {
+                return false;
+            }
+            const sibling = grandparent.left === parent ? grandparent.right : grandparent.left;
+            if (!isJsonStringifyCall(sibling)) {
+                return false;
+            }
+            const callInfo = getBareSortInfo(call);
+            const siblingInfo = getBareSortInfo(sibling.arguments[0]);
+            if (callInfo === null || siblingInfo === null) {
+                return false;
+            }
+            return (callInfo.methodName === siblingInfo.methodName &&
+                isPrimitiveSortReceiver(callInfo.receiver) &&
+                isPrimitiveSortReceiver(siblingInfo.receiver));
+        }
+        function getBareSortInfo(node) {
+            if (node.type !== 'CallExpression') {
+                return null;
+            }
+            const callExpr = node;
+            if (callExpr.arguments.length !== 0) {
+                return null;
+            }
+            if (callExpr.callee.type !== 'MemberExpression') {
+                return null;
+            }
+            const callee = callExpr.callee;
+            const text = sourceCode.getText(callee.property);
+            if (!allSortLike.has(text)) {
+                return null;
+            }
+            const receiverType = (0, type_js_1.getTypeFromTreeNode)(callee.object, services);
+            if (!(0, type_js_1.isArrayLikeType)(receiverType, services)) {
+                return null;
+            }
+            return {
+                methodName: text,
+                receiver: callee.object,
+            };
+        }
+        function isPrimitiveSortReceiver(receiver) {
+            const receiverType = (0, type_js_1.getTypeFromTreeNode)(receiver, services);
+            return ((0, type_js_1.isNumberArray)(receiverType, services) ||
+                (0, type_js_1.isBigIntArray)(receiverType, services) ||
+                (0, type_js_1.isStringArray)(receiverType, services) ||
+                (0, type_js_1.isBooleanArray)(receiverType, services));
+        }
         function getSuggestions(call, type) {
             const suggestions = [];
             if ((0, type_js_1.isNumberArray)(type, services)) {

package/cjs/S2970/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S2970';
 exports.scope = 'Tests';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = true;

package/cjs/S2990/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S2990';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S2999/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -53,3 +53,4 @@ exports.sonarKey = 'S2999';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S3001/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S3001';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S3003/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S3003';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S3317/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredEcmaVersion = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.requiredEcmaVersion = exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,4 +49,5 @@ exports.sonarKey = 'S3317';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;
 exports.requiredEcmaVersion = 2015;

package/cjs/S3330/generated-meta.js

@@ -31,12 +31,12 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
     docs: {
-        description: 'Creating cookies without the "HttpOnly" flag is security-sensitive',
+        description: 'Cookies should have the "HttpOnly" flag',
         recommended: true,
         url: 'https://sonarsource.github.io/rspec/#/rspec/S3330/javascript',
         requiresTypeChecking: false,
@@ -49,3 +49,4 @@ exports.sonarKey = 'S3330';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S3358/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S3358';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = true;

package/cjs/S3402/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S3402';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S3403/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S3403';
 exports.scope = 'Main';
 exports.languages = ['js'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S3403/rule.js

@@ -59,6 +59,7 @@ const generate_meta_js_1 = require("../helpers/generate-meta.js");
 const type_js_1 = require("../helpers/type.js");
 const parser_services_js_1 = require("../helpers/parser-services.js");
 const location_js_1 = require("../helpers/location.js");
+const ast_js_1 = require("../helpers/ast.js");
 const meta = __importStar(require("./generated-meta.js"));
 exports.rule = {
     meta: (0, generate_meta_js_1.generateMeta)(meta, { hasSuggestions: true }),
@@ -82,7 +83,9 @@ exports.rule = {
         return {
             BinaryExpression: (node) => {
                 const { left, operator, right } = node;
-                if (['===', '!=='].includes(operator) && !isComparableTo(left, right)) {
+                if (['===', '!=='].includes(operator) &&
+                    !isDefensiveIndexedNullishCheck(left, right) &&
+                    !isComparableTo(left, right)) {
                     const [actual, expected, outcome] = operator === '===' ? ['===', '==', 'false'] : ['!==', '!=', 'true'];
                     const operatorToken = context.sourceCode
                         .getTokensBetween(left, right)
@@ -102,6 +105,23 @@ exports.rule = {
         };
     },
 };
+function isDefensiveIndexedNullishCheck(left, right) {
+    return ((isNullishLiteral(left) && isIndexedAccess(right)) ||
+        (isNullishLiteral(right) && isIndexedAccess(left)));
+}
+function isNullishLiteral(node) {
+    return ((0, ast_js_1.isNullLiteral)(node) ||
+        (0, ast_js_1.isUndefined)(node) ||
+        (node.type === 'UnaryExpression' && node.operator === 'void'));
+}
+function isIndexedAccess(node) {
+    if (node.type === 'MemberExpression') {
+        return node.computed;
+    }
+    return (node.type === 'ChainExpression' &&
+        node.expression.type === 'MemberExpression' &&
+        node.expression.computed);
+}
 /**
  * Checks if a type is indeterminate (its actual value cannot be determined at compile time).
  * - Unknown: can be compared with anything

package/cjs/S3415/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S3415';
 exports.scope = 'Tests';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = true;

package/cjs/S3499/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredEcmaVersion = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.requiredEcmaVersion = exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,4 +49,5 @@ exports.sonarKey = 'S3499';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;
 exports.requiredEcmaVersion = 2015;

package/cjs/S3500/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredEcmaVersion = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.requiredEcmaVersion = exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -49,4 +49,5 @@ exports.sonarKey = 'S3500';
 exports.scope = 'Main';
 exports.languages = ['js'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;
 exports.requiredEcmaVersion = 2015;

package/cjs/S3513/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredEcmaVersion = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.requiredEcmaVersion = exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,4 +49,5 @@ exports.sonarKey = 'S3513';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;
 exports.requiredEcmaVersion = 2015;

package/cjs/S3514/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredEcmaVersion = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.requiredEcmaVersion = exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,4 +49,5 @@ exports.sonarKey = 'S3514';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;
 exports.requiredEcmaVersion = 2015;

package/cjs/S3516/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S3516';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = true;

package/cjs/S3524/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredEcmaVersion = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.requiredEcmaVersion = exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -54,4 +54,5 @@ exports.sonarKey = 'S3524';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;
 exports.requiredEcmaVersion = 2015;

package/cjs/S3525/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredEcmaVersion = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.requiredEcmaVersion = exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,4 +49,5 @@ exports.sonarKey = 'S3525';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;
 exports.requiredEcmaVersion = 2015;

package/cjs/S3531/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredEcmaVersion = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.requiredEcmaVersion = exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -49,4 +49,5 @@ exports.sonarKey = 'S3531';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;
 exports.requiredEcmaVersion = 2015;