eslint-plugin-sonarjs 4.0.3 → 4.1.0

package/cjs/S6418/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -54,3 +54,4 @@ exports.sonarKey = 'S6418';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S6426/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S6426';
 exports.scope = 'Tests';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S6426/rule.js

@@ -53,7 +53,9 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.rule = void 0;
 const generate_meta_js_1 = require("../helpers/generate-meta.js");
 const ast_js_1 = require("../helpers/ast.js");
+const Playwright = __importStar(require("../helpers/playwright.js"));
 const meta = __importStar(require("./generated-meta.js"));
+const exclusiveTestFunctionNames = ['context', 'describe', 'it', 'specify', 'test'];
 exports.rule = {
     meta: (0, generate_meta_js_1.generateMeta)(meta, {
         hasSuggestions: true,
@@ -67,7 +69,7 @@ exports.rule = {
             CallExpression: (node) => {
                 if ((0, ast_js_1.isMethodCall)(node)) {
                     const { property, object } = node.callee;
-                    if ((0, ast_js_1.isIdentifier)(property, 'only') && (0, ast_js_1.isIdentifier)(object, 'describe', 'it', 'test')) {
+                    if ((0, ast_js_1.isIdentifier)(property, 'only') && isExclusiveTestFunction(object)) {
                         context.report({
                             messageId: 'issue',
                             node: property,
@@ -91,3 +93,6 @@ exports.rule = {
         };
     },
 };
+function isExclusiveTestFunction(node) {
+    return (0, ast_js_1.isIdentifier)(node, ...exclusiveTestFunctionNames) || Playwright.isDescribe(node);
+}

package/cjs/S6437/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S6437';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S6437/rule.js

@@ -174,10 +174,12 @@ exports.rule = {
                 if (!fqn) {
                     return;
                 }
-                if (node.arguments.length > 0 && fqn in secretSignatures) {
+                // `getFullyQualifiedName()` can resolve built-ins such as `toString`.
+                // Restrict lookups to own keys so prototype members never masquerade as configured signatures.
+                if (node.arguments.length > 0 && Object.hasOwn(secretSignatures, fqn)) {
                     checkSecretArgument(node, fqn);
                 }
-                if (fqn in secretObjectSignatures) {
+                if (Object.hasOwn(secretObjectSignatures, fqn)) {
                     checkSecretProperty(node, fqn);
                 }
             },

package/cjs/S6439/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S6439';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = ['react', 'react-native'];
+exports.skipOnGeneratedSource = false;

package/cjs/S6442/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S6442';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = ['react'];
+exports.skipOnGeneratedSource = false;

package/cjs/S6443/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S6443';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = ['react'];
+exports.skipOnGeneratedSource = false;

package/cjs/S6486/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S6486';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S6486/rule.js

@@ -80,7 +80,7 @@ function checkPropValue(context, node) {
         // key={bar}
         context.report({
             messageId: 'noGeneratedKeys',
-            node: node,
+            node,
         });
         return;
     }
@@ -89,7 +89,7 @@ function checkPropValue(context, node) {
         if (node.expressions.some(isGeneratedExpression)) {
             context.report({
                 messageId: 'noGeneratedKeys',
-                node: node,
+                node,
             });
         }
         return;
@@ -100,7 +100,7 @@ function checkPropValue(context, node) {
         if (callExpressions.some(isGeneratedExpression)) {
             context.report({
                 messageId: 'noGeneratedKeys',
-                node: node,
+                node,
             });
         }
         return;
@@ -114,7 +114,7 @@ function checkPropValue(context, node) {
         // key={bar.toString()}
         context.report({
             messageId: 'noGeneratedKeys',
-            node: node,
+            node,
         });
         return;
     }

package/cjs/S6564/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S6564';
 exports.scope = 'Main';
 exports.languages = ['ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S6594/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S6594';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = true;

package/cjs/S6627/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S6627';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S6759/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S6759';
 exports.scope = 'Main';
 exports.languages = ['ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S6759/rule.js

@@ -180,5 +180,35 @@ function isReadOnly(props, services) {
         return true;
     }
     /* All properties must be read-only */
-    return properties.every(property => (0, ts_api_utils_1.isPropertyReadonlyInType)(type, property.getEscapedName(), checker));
+    return properties.every(property => isPropertyReadonlyIncludingBaseTypes(type, property, checker));
+}
+function isPropertyReadonlyIncludingBaseTypes(type, property, checker, seen = new Set()) {
+    const name = property.getEscapedName();
+    if ((0, ts_api_utils_1.isPropertyReadonlyInType)(type, name, checker)) {
+        return true;
+    }
+    // Inherited properties can be exposed as transient symbols whose declarations
+    // no longer carry readonly modifiers from mapped base types like Readonly<T>.
+    if (!(property.flags & typescript_1.default.SymbolFlags.Transient)) {
+        return false;
+    }
+    if (!(type.flags & typescript_1.default.TypeFlags.Object) || seen.has(type)) {
+        return false;
+    }
+    seen.add(type);
+    const objectType = type;
+    if (!(objectType.objectFlags & typescript_1.default.ObjectFlags.ClassOrInterface)) {
+        return false;
+    }
+    const baseTypes = checker.getBaseTypes(objectType);
+    return (baseTypes?.some(baseType => {
+        const baseProperty = getPropertyFromType(baseType, name);
+        return (baseProperty !== undefined &&
+            isPropertyReadonlyIncludingBaseTypes(baseType, baseProperty, checker, seen));
+    }) ?? false);
+}
+function getPropertyFromType(type, name) {
+    return String(name).startsWith('__')
+        ? type.getProperties().find(property => property.getEscapedName() === name)
+        : type.getProperty(String(name));
 }

package/cjs/S6958/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S6958';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S6959/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S6959';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S7059/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredEcmaVersion = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.requiredEcmaVersion = exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'suggestion',
@@ -49,4 +49,5 @@ exports.sonarKey = 'S7059';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;
 exports.requiredEcmaVersion = 2017;

package/cjs/S7639/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S7639';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S7790/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S7790';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S8441/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -49,3 +49,4 @@ exports.sonarKey = 'S8441';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/S8479/generated-meta.js

@@ -31,7 +31,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
     type: 'problem',
@@ -39,7 +39,7 @@ exports.meta = {
         description: 'DOMPurify configuration should not be bypassable',
         recommended: true,
         url: 'https://sonarsource.github.io/rspec/#/rspec/S8479/javascript',
-        requiresTypeChecking: false,
+        requiresTypeChecking: true,
     },
     fixable: undefined,
     deprecated: false,
@@ -49,3 +49,4 @@ exports.sonarKey = 'S8479';
 exports.scope = 'Main';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/{S4817 → S8754}/generated-meta.js

@@ -15,7 +15,7 @@
  * You should have received a copy of the Sonar Source-Available License
  * along with this program; if not, see https://sonarsource.com/license/ssal/
  */
-// https://sonarsource.github.io/rspec/#/rspec/S4817/javascript
+// https://sonarsource.github.io/rspec/#/rspec/S8754/javascript
 var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
     if (k2 === undefined) k2 = k;
     var desc = Object.getOwnPropertyDescriptor(m, k);
@@ -31,21 +31,22 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
+exports.skipOnGeneratedSource = exports.requiredDependency = exports.languages = exports.scope = exports.sonarKey = exports.meta = void 0;
 __exportStar(require("./meta.js"), exports);
 exports.meta = {
-    type: 'problem',
+    type: 'suggestion',
     docs: {
-        description: 'Executing XPath expressions is security-sensitive',
-        recommended: false,
-        url: 'https://sonarsource.github.io/rspec/#/rspec/S4817/javascript',
+        description: 'Test titles should be unique within the same suite',
+        recommended: true,
+        url: 'https://sonarsource.github.io/rspec/#/rspec/S8754/javascript',
         requiresTypeChecking: false,
     },
     fixable: undefined,
-    deprecated: true,
+    deprecated: false,
     defaultOptions: [],
 };
-exports.sonarKey = 'S4817';
-exports.scope = 'Main';
+exports.sonarKey = 'S8754';
+exports.scope = 'Tests';
 exports.languages = ['js', 'ts'];
 exports.requiredDependency = [];
+exports.skipOnGeneratedSource = false;

package/cjs/{S5743 → S8754}/meta.js

@@ -18,5 +18,5 @@ exports.hasSecondaries = exports.eslintId = exports.implementation = void 0;
  * along with this program; if not, see https://sonarsource.com/license/ssal/
  */
 exports.implementation = 'original';
-exports.eslintId = 'dns-prefetching';
+exports.eslintId = 'no-duplicate-test-title';
 exports.hasSecondaries = true;