eslint-plugin-no-jquery 2.7.0 → 3.0.0

package/src/rules/no-sizzle.js

@@ -39,8 +39,8 @@ module.exports = {
 		]
 	},
 
-	create: function ( context ) {
-		const forbiddenPositional = /:eq|:even|:first([^-]|$)|:gt|:last([^-]|$)|:lt|:nth|:odd/;
+	create: ( context ) => {
+		const forbiddenPositional = /:eq|:even|:first([^-]|$)|:gt|:last([^-]|$)|:lt|:nth([^-]|$)|:odd/;
 		const forbiddenOther = /:animated|:button|:checkbox|:file|:has|:header|:hidden|:image|:input|:parent|:password|:radio|:reset|:selected|:submit|:text|:visible/;
 		const traversals = [
 			'children',
@@ -63,7 +63,7 @@ module.exports = {
 		];
 
 		return {
-			'CallExpression:exit': function ( node ) {
+			'CallExpression:exit': ( node ) => {
 				if (
 					!node.arguments[ 0 ] ||
 					!utils.isjQuery( context, node.callee ) ||
@@ -83,12 +83,12 @@ module.exports = {
 
 				if ( !allowPositional && forbiddenPositional.test( value ) ) {
 					context.report( {
-						node: node,
+						node,
 						message: 'Positional selector extensions are not allowed'
 					} );
 				} else if ( !allowOther && forbiddenOther.test( value ) ) {
 					context.report( {
-						node: node,
+						node,
 						message: 'Selector extensions are not allowed'
 					} );
 				}

package/src/rules/no-slide.js

@@ -6,5 +6,5 @@ module.exports = utils.createCollectionMethodRule(
 	[ 'slideDown', 'slideToggle', 'slideUp' ],
 	( node ) => node === true ?
 		'Prefer CSS transitions' :
-		`Prefer CSS transitions to .${node.callee.property.name}`
+		`Prefer CSS transitions to .${ node.callee.property.name }`
 );

package/src/rules/no-unique.js

@@ -7,8 +7,6 @@ module.exports = utils.createUtilMethodRule(
 	'Prefer `$.uniqueSort` to `$.unique`',
 	{
 		fixable: 'code',
-		fix: function ( node, context, fixer ) {
-			return fixer.replaceText( node.callee.property, 'uniqueSort' );
-		}
+		fix: ( node, context, fixer ) => fixer.replaceText( node.callee.property, 'uniqueSort' )
 	}
 );

package/src/rules/no-visibility.js

@@ -5,5 +5,5 @@ const utils = require( '../utils.js' );
 module.exports = utils.createCollectionMethodRule(
 	[ 'show', 'hide', 'toggle' ],
 	( node ) => node === true ? '' :
-		`.${node.callee.property.name} is not allowed`
+		`.${ node.callee.property.name } is not allowed`
 );

package/src/rules/no-wrap.js

@@ -5,5 +5,5 @@ const utils = require( '../utils.js' );
 module.exports = utils.createCollectionMethodRule(
 	[ 'wrap', 'wrapAll', 'wrapInner', 'unwrap' ],
 	( node ) => node === true ? '' :
-		`.${node.callee.property.name} is not allowed`
+		`.${ node.callee.property.name } is not allowed`
 );

package/src/rules/variable-pattern.js

@@ -11,7 +11,7 @@ module.exports = {
 		schema: []
 	},
 
-	create: function ( context ) {
+	create: ( context ) => {
 		function test( node, left, right ) {
 			if (
 				!utils.isjQuery( context, left ) &&
@@ -22,17 +22,17 @@ module.exports = {
 				right && utils.isjQuery( context, right )
 			) {
 				context.report( {
-					node: node,
+					node,
 					message: 'jQuery collection names must match the variablePattern'
 				} );
 			}
 		}
 
 		return {
-			'AssignmentExpression:exit': function ( node ) {
+			'AssignmentExpression:exit': ( node ) => {
 				test( node, node.left, node.right );
 			},
-			'VariableDeclarator:exit': function ( node ) {
+			'VariableDeclarator:exit': ( node ) => {
 				test( node, node.id, node.init );
 			}
 		};

package/src/utils.js

@@ -203,14 +203,14 @@ function createRule( create, description, fixable, deprecated, schema ) {
 		meta: {
 			type: 'suggestion',
 			docs: {
-				description: description,
+				description,
 				deprecated: !!deprecated,
 				replacedBy: Array.isArray( deprecated ) ? deprecated : undefined
 			},
-			fixable: fixable,
+			fixable,
 			schema: schema || []
 		},
-		create: create
+		create
 	};
 }
 
@@ -336,38 +336,36 @@ function createCollectionMethodRule( methods, message, options ) {
 			'* `"set"` the method can only be used as a setter i.e. with arguments';
 	}
 
-	return createRule( function ( context ) {
-		return {
-			'CallExpression:exit': function ( node ) {
-				if ( node.callee.type !== 'MemberExpression' ) {
-					return;
-				}
-				const name = node.callee.property.name;
-				if (
-					!methods.includes( name ) ||
+	return createRule( ( context ) => ( {
+		'CallExpression:exit': ( node ) => {
+			if ( node.callee.type !== 'MemberExpression' ) {
+				return;
+			}
+			const name = node.callee.property.name;
+			if (
+				!methods.includes( name ) ||
 					isjQueryConstructor( context, node.callee.object.name )
-				) {
-					return;
-				}
-				const allowGetOrSet = ( context.options[ 0 ] && context.options[ 0 ].allowGetOrSet ) || 'none';
-				// TODO: nonCollectionReturningValueAccessors have 1 argument in getter mode
-				if (
-					( allowGetOrSet === 'get' && !node.arguments.length ) ||
+			) {
+				return;
+			}
+			const allowGetOrSet = ( context.options[ 0 ] && context.options[ 0 ].allowGetOrSet ) || 'none';
+			// TODO: nonCollectionReturningValueAccessors have 1 argument in getter mode
+			if (
+				( allowGetOrSet === 'get' && !node.arguments.length ) ||
 					( allowGetOrSet === 'set' && node.arguments.length )
-				) {
-					return;
-				}
+			) {
+				return;
+			}
 
-				if ( isjQuery( context, node.callee ) ) {
-					context.report( {
-						node: node,
-						message: messageToPlainString( message, node, name, options ),
-						fix: options.fix && options.fix.bind( this, node, context )
-					} );
-				}
+			if ( isjQuery( context, node.callee ) ) {
+				context.report( {
+					node,
+					message: messageToPlainString( message, node, name, options ),
+					fix: options.fix && options.fix.bind( this, node, context )
+				} );
 			}
-		};
-	}, description, options.fixable, options.deprecated, schema );
+		}
+	} ), description, options.fixable, options.deprecated, schema );
 }
 
 /**
@@ -387,26 +385,24 @@ function createCollectionPropertyRule( property, message, options ) {
 
 	description += messageSuffix( message );
 
-	return createRule( function ( context ) {
-		return {
-			'MemberExpression:exit': function ( node ) {
-				const name = node.property.name;
-				if (
-					name !== property ||
+	return createRule( ( context ) => ( {
+		'MemberExpression:exit': ( node ) => {
+			const name = node.property.name;
+			if (
+				name !== property ||
 					node.parent.callee === node
-				) {
-					return;
-				}
-				if ( isjQuery( context, node.object ) ) {
-					context.report( {
-						node: node,
-						message: messageToPlainString( message, node, name, options ),
-						fix: options.fix && options.fix.bind( this, node, context )
-					} );
-				}
+			) {
+				return;
+			}
+			if ( isjQuery( context, node.object ) ) {
+				context.report( {
+					node,
+					message: messageToPlainString( message, node, name, options ),
+					fix: options.fix && options.fix.bind( this, node, context )
+				} );
 			}
-		};
-	}, description, options.fixable, options.deprecated );
+		}
+	} ), description, options.fixable, options.deprecated );
 }
 
 /**
@@ -429,28 +425,26 @@ function createUtilMethodRule( methods, message, options ) {
 
 	description += messageSuffix( message );
 
-	return createRule( function ( context ) {
-		return {
-			'CallExpression:exit': function ( node ) {
-				if ( node.callee.type !== 'MemberExpression' ) {
-					return;
-				}
-				const name = node.callee.property.name;
-				if (
-					!methods.includes( name ) ||
+	return createRule( ( context ) => ( {
+		'CallExpression:exit': ( node ) => {
+			if ( node.callee.type !== 'MemberExpression' ) {
+				return;
+			}
+			const name = node.callee.property.name;
+			if (
+				!methods.includes( name ) ||
 					!isjQueryConstructor( context, node.callee.object.name )
-				) {
-					return;
-				}
-
-				context.report( {
-					node: node,
-					message: messageToPlainString( message, node, name, options ),
-					fix: options.fix && options.fix.bind( this, node, context )
-				} );
+			) {
+				return;
 			}
-		};
-	}, description, options.fixable, options.deprecated );
+
+			context.report( {
+				node,
+				message: messageToPlainString( message, node, name, options ),
+				fix: options.fix && options.fix.bind( this, node, context )
+			} );
+		}
+	} ), description, options.fixable, options.deprecated );
 }
 
 /**
@@ -470,25 +464,23 @@ function createUtilPropertyRule( property, message, options ) {
 
 	description += messageSuffix( message );
 
-	return createRule( function ( context ) {
-		return {
-			'MemberExpression:exit': function ( node ) {
-				if ( !isjQueryConstructor( context, node.object.name ) ) {
-					return;
-				}
-				const name = node.property.name;
-				if ( name !== property ) {
-					return;
-				}
-
-				context.report( {
-					node: node,
-					message: messageToPlainString( message, node, name, options ),
-					fix: options.fix && options.fix.bind( this, node, context )
-				} );
+	return createRule( ( context ) => ( {
+		'MemberExpression:exit': ( node ) => {
+			if ( !isjQueryConstructor( context, node.object.name ) ) {
+				return;
+			}
+			const name = node.property.name;
+			if ( name !== property ) {
+				return;
 			}
-		};
-	}, description, options.fixable, options.deprecated );
+
+			context.report( {
+				node,
+				message: messageToPlainString( message, node, name, options ),
+				fix: options.fix && options.fix.bind( this, node, context )
+			} );
+		}
+	} ), description, options.fixable, options.deprecated );
 }
 
 /**
@@ -514,26 +506,24 @@ function createCollectionOrUtilMethodRule( methods, message, options ) {
 
 	description += messageSuffix( message );
 
-	return createRule( function ( context ) {
-		return {
-			'CallExpression:exit': function ( node ) {
-				if ( node.callee.type !== 'MemberExpression' ) {
-					return;
-				}
-				const name = node.callee.property.name;
-				if ( !methods.includes( name ) ) {
-					return;
-				}
-				if ( isjQuery( context, node.callee ) ) {
-					context.report( {
-						node: node,
-						message: messageToPlainString( message, node, name, options ),
-						fix: options.fix && options.fix.bind( this, node, context )
-					} );
-				}
+	return createRule( ( context ) => ( {
+		'CallExpression:exit': ( node ) => {
+			if ( node.callee.type !== 'MemberExpression' ) {
+				return;
+			}
+			const name = node.callee.property.name;
+			if ( !methods.includes( name ) ) {
+				return;
 			}
-		};
-	}, description, options.fixable, options.deprecated );
+			if ( isjQuery( context, node.callee ) ) {
+				context.report( {
+					node,
+					message: messageToPlainString( message, node, name, options ),
+					fix: options.fix && options.fix.bind( this, node, context )
+				} );
+			}
+		}
+	} ), description, options.fixable, options.deprecated );
 }
 
 function eventShorthandFixer( node, context, fixer ) {
@@ -552,15 +542,15 @@ function eventShorthandFixer( node, context, fixer ) {
 }
 
 module.exports = {
-	isjQuery: isjQuery,
-	isjQueryConstructor: isjQueryConstructor,
-	isFunction: isFunction,
-	createCollectionMethodRule: createCollectionMethodRule,
-	createCollectionPropertyRule: createCollectionPropertyRule,
-	createUtilMethodRule: createUtilMethodRule,
-	createUtilPropertyRule: createUtilPropertyRule,
-	createCollectionOrUtilMethodRule: createCollectionOrUtilMethodRule,
-	eventShorthandFixer: eventShorthandFixer,
-	jQueryCollectionLink: jQueryCollectionLink,
-	jQueryGlobalLink: jQueryGlobalLink
+	isjQuery,
+	isjQueryConstructor,
+	isFunction,
+	createCollectionMethodRule,
+	createCollectionPropertyRule,
+	createUtilMethodRule,
+	createUtilPropertyRule,
+	createCollectionOrUtilMethodRule,
+	eventShorthandFixer,
+	jQueryCollectionLink,
+	jQueryGlobalLink
 };