eslint-plugin-no-jquery 2.7.0 → 3.0.0

package/src/rules/no-global-selector.js

@@ -28,61 +28,59 @@ module.exports = {
 		]
 	},
 
-	create: function ( context ) {
-		return {
-			'CallExpression:exit': function ( node ) {
-				if (
-					node.callee.type !== 'Identifier' ||
+	create: ( context ) => ( {
+		'CallExpression:exit': ( node ) => {
+			if (
+				node.callee.type !== 'Identifier' ||
 					!utils.isjQueryConstructor( context, node.callee.name ) ||
 					!node.arguments[ 0 ] ||
 					node.arguments[ 0 ].type !== 'Literal'
-				) {
-					return;
-				}
-				const value = node.arguments[ 0 ].value;
-				const allowIds = context.options[ 0 ] && context.options[ 0 ].allowIds;
-				if (
-					typeof value !== 'string' ||
+			) {
+				return;
+			}
+			const value = node.arguments[ 0 ].value;
+			const allowIds = context.options[ 0 ] && context.options[ 0 ].allowIds;
+			if (
+				typeof value !== 'string' ||
 					!value ||
 					value === '#' ||
 					( allowIds && idPattern.test( value.trim() ) )
-				) {
-					return;
-				}
+			) {
+				return;
+			}
 
-				// Simple HTML check (copied from jQuery)
-				if (
-					value[ 0 ] === '<' &&
+			// Simple HTML check (copied from jQuery)
+			if (
+				value[ 0 ] === '<' &&
 					value[ value.length - 1 ] === '>' &&
 					value.length >= 3
-				) {
-					return;
-				}
-				if ( rquickExpr.exec( value ) ) {
-					return;
-				}
+			) {
+				return;
+			}
+			if ( rquickExpr.exec( value ) ) {
+				return;
+			}
 
-				const selectorContext = node.arguments[ 1 ];
-				if ( selectorContext ) {
-					if (
-						selectorContext.type !== 'Literal' &&
+			const selectorContext = node.arguments[ 1 ];
+			if ( selectorContext ) {
+				if (
+					selectorContext.type !== 'Literal' &&
 						!(
 							selectorContext.type === 'Identifier' &&
 							selectorContext.name === 'undefined'
 						)
-					) {
-						return;
-					}
-					if ( selectorContext.value === '#' ) {
-						return;
-					}
+				) {
+					return;
+				}
+				if ( selectorContext.value === '#' ) {
+					return;
 				}
-
-				context.report( {
-					node: node,
-					message: 'Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible.'
-				} );
 			}
-		};
-	}
+
+			context.report( {
+				node,
+				message: 'Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible.'
+			} );
+		}
+	} )
 };

package/src/rules/no-is-array.js

@@ -7,8 +7,6 @@ module.exports = utils.createUtilMethodRule(
 	'Prefer `Array.isArray` to `$.isArray`',
 	{
 		fixable: 'code',
-		fix: function ( node, context, fixer ) {
-			return fixer.replaceText( node.callee, 'Array.isArray' );
-		}
+		fix: ( node, context, fixer ) => fixer.replaceText( node.callee, 'Array.isArray' )
 	}
 );

package/src/rules/no-is-function.js

@@ -7,7 +7,7 @@ module.exports = utils.createUtilMethodRule(
 	'Prefer `typeof` to `$.isFunction`',
 	{
 		fixable: 'code',
-		fix: function ( node, context, fixer ) {
+		fix: ( node, context, fixer ) => {
 			const calleeRange = node.callee.range;
 			return [
 				fixer.replaceTextRange( [ calleeRange[ 0 ], calleeRange[ 1 ] + 1 ], 'typeof ' ),

package/src/rules/no-jquery-constructor.js

@@ -11,21 +11,19 @@ module.exports = {
 		schema: []
 	},
 
-	create: function ( context ) {
-		return {
-			'CallExpression:exit': function ( node ) {
-				if (
-					node.callee.type !== 'Identifier' ||
+	create: ( context ) => ( {
+		'CallExpression:exit': ( node ) => {
+			if (
+				node.callee.type !== 'Identifier' ||
 					!utils.isjQueryConstructor( context, node.callee.name )
-				) {
-					return;
-				}
-
-				context.report( {
-					node: node,
-					message: 'The jQuery constructor is not allowed'
-				} );
+			) {
+				return;
 			}
-		};
-	}
+
+			context.report( {
+				node,
+				message: 'The jQuery constructor is not allowed'
+			} );
+		}
+	} )
 };

package/src/rules/no-load-shorthand.js

@@ -12,28 +12,26 @@ module.exports = {
 		schema: []
 	},
 
-	create: function ( context ) {
-		return {
-			'CallExpression:exit': function ( node ) {
-				if ( !(
-					node.callee.type === 'MemberExpression' &&
+	create: ( context ) => ( {
+		'CallExpression:exit': ( node ) => {
+			if ( !(
+				node.callee.type === 'MemberExpression' &&
 					!utils.isjQueryConstructor( context, node.callee.object.name ) &&
 					node.callee.property.name === 'load' && (
-						node.arguments.length === 0 ||
+					node.arguments.length === 0 ||
 						utils.isFunction( node.arguments[ 0 ] )
-					)
-				) ) {
-					return;
-				}
+				)
+			) ) {
+				return;
+			}
 
-				if ( utils.isjQuery( context, node.callee ) ) {
-					context.report( {
-						node: node,
-						message: 'Prefer .on or .trigger to .load',
-						fix: utils.eventShorthandFixer.bind( this, node, context )
-					} );
-				}
+			if ( utils.isjQuery( context, node.callee ) ) {
+				context.report( {
+					node,
+					message: 'Prefer .on or .trigger to .load',
+					fix: utils.eventShorthandFixer.bind( this, node, context )
+				} );
 			}
-		};
-	}
+		}
+	} )
 };

package/src/rules/no-noop.js

@@ -7,8 +7,6 @@ module.exports = utils.createUtilPropertyRule(
 	'Prefer `function(){}` to `$.noop`',
 	{
 		fixable: 'code',
-		fix: function ( node, context, fixer ) {
-			return fixer.replaceText( node, '(function(){})' );
-		}
+		fix: ( node, context, fixer ) => fixer.replaceText( node, '(function(){})' )
 	}
 );

package/src/rules/no-now.js

@@ -7,8 +7,6 @@ module.exports = utils.createUtilMethodRule(
 	'Prefer `Date.now` to `$.now`',
 	{
 		fixable: 'code',
-		fix: function ( node, context, fixer ) {
-			return fixer.replaceText( node.callee, 'Date.now' );
-		}
+		fix: ( node, context, fixer ) => fixer.replaceText( node.callee, 'Date.now' )
 	}
 );

package/src/rules/no-on-ready.js

@@ -12,41 +12,36 @@ module.exports = {
 		schema: []
 	},
 
-	create: function ( context ) {
-		return {
-			'CallExpression:exit': function ( node ) {
-				if (
-					node.callee.type !== 'MemberExpression' ||
+	create: ( context ) => ( {
+		'CallExpression:exit': ( node ) => {
+			if (
+				node.callee.type !== 'MemberExpression' ||
 					node.callee.property.name !== 'on'
-				) {
-					return;
-				}
-				const arg = node.arguments[ 0 ];
-				if ( !arg || arg.value !== 'ready' ) {
-					return;
-				}
+			) {
+				return;
+			}
+			const arg = node.arguments[ 0 ];
+			if ( !arg || arg.value !== 'ready' ) {
+				return;
+			}
 
-				if ( utils.isjQuery( context, node.callee ) ) {
-					context.report( {
-						node: node,
-						message: '.on("ready") is not allowed',
-						fix: function ( fixer ) {
-							if ( node.arguments.length > 1 ) {
-								return [
-									fixer.replaceText( node.callee.property, 'ready' ),
-									fixer.replaceTextRange(
-										[
-											node.arguments[ 0 ].range[ 0 ],
-											node.arguments[ 1 ].range[ 0 ]
-										],
-										''
-									)
-								];
-							}
-						}
-					} );
-				}
+			if ( utils.isjQuery( context, node.callee ) ) {
+				context.report( {
+					node,
+					message: '.on("ready") is not allowed',
+					fix: ( fixer ) => ( node.arguments.length > 1 ) ?
+						[
+							fixer.replaceText( node.callee.property, 'ready' ),
+							fixer.replaceTextRange(
+								[
+									node.arguments[ 0 ].range[ 0 ],
+									node.arguments[ 1 ].range[ 0 ]
+								],
+								''
+							)
+						] : null
+				} );
 			}
-		};
-	}
+		}
+	} )
 };

package/src/rules/no-other-methods.js

@@ -94,28 +94,26 @@ module.exports = {
 		schema: []
 	},
 
-	create: function ( context ) {
-		return {
-			'CallExpression:exit': function ( node ) {
-				if ( node.callee.type !== 'MemberExpression' ) {
-					return;
-				}
-				const name = node.callee.property.name;
-				if (
-					!name ||
+	create: ( context ) => ( {
+		'CallExpression:exit': ( node ) => {
+			if ( node.callee.type !== 'MemberExpression' ) {
+				return;
+			}
+			const name = node.callee.property.name;
+			if (
+				!name ||
 					methodsWithRules.includes( name ) ||
 					utils.isjQueryConstructor( context, node.callee.object.name )
-				) {
-					return;
-				}
-				if ( utils.isjQuery( context, node.callee ) ) {
-					context.report( {
-						node: node,
-						message: '.{{name}} is not allowed',
-						data: { name: name }
-					} );
-				}
+			) {
+				return;
+			}
+			if ( utils.isjQuery( context, node.callee ) ) {
+				context.report( {
+					node,
+					message: '.{{name}} is not allowed',
+					data: { name }
+				} );
 			}
-		};
-	}
+		}
+	} )
 };

package/src/rules/no-other-utils.js

@@ -62,27 +62,25 @@ module.exports = {
 		schema: []
 	},
 
-	create: function ( context ) {
-		return {
-			'CallExpression:exit': function ( node ) {
-				if ( node.callee.type !== 'MemberExpression' ) {
-					return;
-				}
-				const name = node.callee.property.name;
-				if (
-					!name ||
+	create: ( context ) => ( {
+		'CallExpression:exit': ( node ) => {
+			if ( node.callee.type !== 'MemberExpression' ) {
+				return;
+			}
+			const name = node.callee.property.name;
+			if (
+				!name ||
 					utilsWithRules.includes( name ) ||
 					!utils.isjQueryConstructor( context, node.callee.object.name )
-				) {
-					return;
-				}
-
-				context.report( {
-					node: node,
-					message: '$.{{name}} is not allowed',
-					data: { name: name }
-				} );
+			) {
+				return;
 			}
-		};
-	}
+
+			context.report( {
+				node,
+				message: '$.{{name}} is not allowed',
+				data: { name }
+			} );
+		}
+	} )
 };

package/src/rules/no-parse-html-literal.js

@@ -56,89 +56,82 @@ module.exports = {
 		]
 	},
 
-	create: function ( context ) {
-		return {
-			'CallExpression:exit': function ( node ) {
-				let allowSingle,
-					message = 'Prefer DOM building to parsing HTML literals';
+	create: ( context ) => ( {
+		'CallExpression:exit': ( node ) => {
+			let allowSingle,
+				message = 'Prefer DOM building to parsing HTML literals';
 
-				if ( node.callee.type === 'Identifier' ) {
-					if ( !(
-						utils.isjQueryConstructor( context, node.callee.name ) &&
+			if ( node.callee.type === 'Identifier' ) {
+				if ( !(
+					utils.isjQueryConstructor( context, node.callee.name ) &&
 						node.arguments[ 0 ] &&
 						(
 							node.arguments[ 0 ].type === 'Literal' ||
 							node.arguments[ 0 ].type === 'BinaryExpression'
 						)
-					) ) {
-						return;
-					}
-					allowSingle = true;
-				} else if ( node.callee.type === 'MemberExpression' ) {
-					if (
-						utils.isjQueryConstructor( context, node.callee.object.name ) &&
+				) ) {
+					return;
+				}
+				allowSingle = true;
+			} else if ( node.callee.type === 'MemberExpression' ) {
+				if (
+					utils.isjQueryConstructor( context, node.callee.object.name ) &&
 						node.callee.property.name === 'parseHTML'
-					) {
-						allowSingle = false;
-					} else if (
-						[ 'html', 'append', 'add' ].includes( node.callee.property.name ) &&
+				) {
+					allowSingle = false;
+				} else if (
+					[ 'html', 'append', 'add' ].includes( node.callee.property.name ) &&
 						utils.isjQuery( context, node )
-					) {
-						allowSingle = true;
-					} else {
-						return;
-					}
+				) {
+					allowSingle = true;
 				} else {
 					return;
 				}
+			} else {
+				return;
+			}
 
-				let expectedTag;
-				const arg = node.arguments[ 0 ];
-				if ( allowSingle ) {
-					const value = arg && allLiteral( arg ) && joinLiterals( arg );
-					if ( !( typeof value === 'string' && value ) || !rquickExpr.exec( value ) ) {
-						// Empty or non-string, or non-HTML
-						return;
-					}
-					let match;
-					if ( ( match = rsingleTag.exec( value ) ) ) {
-						// Single tag
-						const singleTagStyle = ( context.options[ 0 ] && context.options[ 0 ].singleTagStyle ) || 'minimal';
-						if ( singleTagStyle === 'minimal' ) {
-							if ( !rsingleTagMinimal.exec( value ) ) {
-								expectedTag = '<' + match[ 1 ] + '>';
-								message = 'Single tag must use the format: ' + expectedTag;
-							} else {
-								return;
-							}
-						} else if ( singleTagStyle === 'self-closing' ) {
-							if ( !rsingleTagSelfClosing.exec( value ) ) {
-								expectedTag = '<' + match[ 1 ] + '/>';
-								message = 'Single tag must use the format: ' + expectedTag;
-							} else {
-								return;
-							}
+			let expectedTag;
+			const arg = node.arguments[ 0 ];
+			if ( allowSingle ) {
+				const value = arg && allLiteral( arg ) && joinLiterals( arg );
+				if ( !( typeof value === 'string' && value ) || !rquickExpr.exec( value ) ) {
+					// Empty or non-string, or non-HTML
+					return;
+				}
+				let match;
+				if ( ( match = rsingleTag.exec( value ) ) ) {
+					// Single tag
+					const singleTagStyle = ( context.options[ 0 ] && context.options[ 0 ].singleTagStyle ) || 'minimal';
+					if ( singleTagStyle === 'minimal' ) {
+						if ( !rsingleTagMinimal.exec( value ) ) {
+							expectedTag = '<' + match[ 1 ] + '>';
+							message = 'Single tag must use the format: ' + expectedTag;
 						} else {
-							// singleTagStyle === 'any'
 							return;
 						}
-					}
-				} else if ( !( arg && allLiteral( arg ) ) ) {
-					// Non literals passed to $.parseHTML
-					return;
-				}
-
-				context.report( {
-					node: node,
-					message: message,
-					fix: function ( fixer ) {
-						if ( expectedTag ) {
-							return fixer.replaceText( arg, '"' + expectedTag + '"' );
+					} else if ( singleTagStyle === 'self-closing' ) {
+						if ( !rsingleTagSelfClosing.exec( value ) ) {
+							expectedTag = '<' + match[ 1 ] + '/>';
+							message = 'Single tag must use the format: ' + expectedTag;
+						} else {
+							return;
 						}
-						return null;
+					} else {
+						// singleTagStyle === 'any'
+						return;
 					}
-				} );
+				}
+			} else if ( !( arg && allLiteral( arg ) ) ) {
+				// Non literals passed to $.parseHTML
+				return;
 			}
-		};
-	}
+
+			context.report( {
+				node,
+				message,
+				fix: ( fixer ) => expectedTag ? fixer.replaceText( arg, '"' + expectedTag + '"' ) : null
+			} );
+		}
+	} )
 };

package/src/rules/no-parse-json.js

@@ -7,8 +7,6 @@ module.exports = utils.createUtilMethodRule(
 	'Prefer `JSON.parse` to `$.parseJSON`',
 	{
 		fixable: 'code',
-		fix: function ( node, context, fixer ) {
-			return fixer.replaceText( node.callee, 'JSON.parse' );
-		}
+		fix: ( node, context, fixer ) => fixer.replaceText( node.callee, 'JSON.parse' )
 	}
 );

package/src/rules/no-parse-xml.js

@@ -7,7 +7,7 @@ module.exports = utils.createUtilMethodRule(
 	'Prefer `DOMParser#parseFromString` to `$.parseXML`',
 	{
 		fixable: 'code',
-		fix: function ( node, context, fixer ) {
+		fix: ( node, context, fixer ) => {
 			if ( node.arguments.length ) {
 				return [
 					fixer.replaceText( node.callee, '( new window.DOMParser() ).parseFromString' ),

package/src/rules/no-prop.js

@@ -6,5 +6,5 @@ module.exports = utils.createCollectionOrUtilMethodRule(
 	[ 'prop', 'removeProp' ],
 	( node ) => node === true ?
 		'Prefer direct property access' :
-		`Prefer direct property access to .${node.callee.property.name}/$.${node.callee.property.name}`
+		`Prefer direct property access to .${ node.callee.property.name }/$.${ node.callee.property.name }`
 );

package/src/rules/no-proxy.js

@@ -7,7 +7,7 @@ module.exports = utils.createUtilMethodRule(
 	'Prefer `Function#bind` to `$.proxy`',
 	{
 		fixable: 'code',
-		fix: function ( node, context, fixer ) {
+		fix: ( node, context, fixer ) => {
 			if (
 				node.arguments.length >= 2 &&
 				node.arguments[ 1 ].type !== 'Literal'

package/src/rules/no-ready-shorthand.js

@@ -7,7 +7,7 @@ module.exports = utils.createCollectionMethodRule(
 	'Prefer `$()` to `.ready`',
 	{
 		fixable: 'code',
-		fix: function ( node, context, fixer ) {
+		fix: ( node, context, fixer ) => {
 			if ( node.parent.type === 'ExpressionStatement' ) {
 				return fixer.replaceText( node.callee, '$' );
 			}

package/src/rules/no-ready.js

@@ -30,16 +30,14 @@ module.exports = {
 		schema: []
 	},
 
-	create: function ( context ) {
-		return {
-			'CallExpression:exit': function ( node ) {
-				if ( isDirect( context, node ) || isChained( context, node ) ) {
-					context.report( {
-						node: node,
-						message: '.ready is not allowed'
-					} );
-				}
+	create: ( context ) => ( {
+		'CallExpression:exit': ( node ) => {
+			if ( isDirect( context, node ) || isChained( context, node ) ) {
+				context.report( {
+					node,
+					message: '.ready is not allowed'
+				} );
 			}
-		};
-	}
+		}
+	} )
 };

package/src/rules/no-serialize.js

@@ -6,5 +6,5 @@ module.exports = utils.createCollectionMethodRule(
 	[ 'serialize', 'serializeArray' ],
 	( node ) => node === true ?
 		'Prefer `FormData` or `URLSearchParams`' :
-		`Prefer FormData or URLSearchParams to .${node.callee.property.name}`
+		`Prefer FormData or URLSearchParams to .${ node.callee.property.name }`
 );

package/src/rules/no-size.js

@@ -7,8 +7,6 @@ module.exports = utils.createCollectionMethodRule(
 	'Prefer `.length` to `.size`',
 	{
 		fixable: 'code',
-		fix: function ( node, context, fixer ) {
-			return fixer.replaceTextRange( [ node.callee.property.range[ 0 ], node.range[ 1 ] ], 'length' );
-		}
+		fix: ( node, context, fixer ) => fixer.replaceTextRange( [ node.callee.property.range[ 0 ], node.range[ 1 ] ], 'length' )
 	}
 );