eslint-plugin-no-jquery 2.6.0 → 3.0.0

package/src/rules/no-parse-html-literal.js

@@ -56,89 +56,82 @@ module.exports = {
 		]
 	},
 
-	create: function ( context ) {
-		return {
-			'CallExpression:exit': function ( node ) {
-				let allowSingle,
-					message = 'Prefer DOM building to parsing HTML literals';
+	create: ( context ) => ( {
+		'CallExpression:exit': ( node ) => {
+			let allowSingle,
+				message = 'Prefer DOM building to parsing HTML literals';
 
-				if ( node.callee.type === 'Identifier' ) {
-					if ( !(
-						utils.isjQueryConstructor( context, node.callee.name ) &&
+			if ( node.callee.type === 'Identifier' ) {
+				if ( !(
+					utils.isjQueryConstructor( context, node.callee.name ) &&
 						node.arguments[ 0 ] &&
 						(
 							node.arguments[ 0 ].type === 'Literal' ||
 							node.arguments[ 0 ].type === 'BinaryExpression'
 						)
-					) ) {
-						return;
-					}
-					allowSingle = true;
-				} else if ( node.callee.type === 'MemberExpression' ) {
-					if (
-						utils.isjQueryConstructor( context, node.callee.object.name ) &&
+				) ) {
+					return;
+				}
+				allowSingle = true;
+			} else if ( node.callee.type === 'MemberExpression' ) {
+				if (
+					utils.isjQueryConstructor( context, node.callee.object.name ) &&
 						node.callee.property.name === 'parseHTML'
-					) {
-						allowSingle = false;
-					} else if (
-						[ 'html', 'append', 'add' ].includes( node.callee.property.name ) &&
+				) {
+					allowSingle = false;
+				} else if (
+					[ 'html', 'append', 'add' ].includes( node.callee.property.name ) &&
 						utils.isjQuery( context, node )
-					) {
-						allowSingle = true;
-					} else {
-						return;
-					}
+				) {
+					allowSingle = true;
 				} else {
 					return;
 				}
+			} else {
+				return;
+			}
 
-				let expectedTag;
-				const arg = node.arguments[ 0 ];
-				if ( allowSingle ) {
-					const value = arg && allLiteral( arg ) && joinLiterals( arg );
-					if ( !( typeof value === 'string' && value ) || !rquickExpr.exec( value ) ) {
-						// Empty or non-string, or non-HTML
-						return;
-					}
-					let match;
-					if ( ( match = rsingleTag.exec( value ) ) ) {
-						// Single tag
-						const singleTagStyle = ( context.options[ 0 ] && context.options[ 0 ].singleTagStyle ) || 'minimal';
-						if ( singleTagStyle === 'minimal' ) {
-							if ( !rsingleTagMinimal.exec( value ) ) {
-								expectedTag = '<' + match[ 1 ] + '>';
-								message = 'Single tag must use the format: ' + expectedTag;
-							} else {
-								return;
-							}
-						} else if ( singleTagStyle === 'self-closing' ) {
-							if ( !rsingleTagSelfClosing.exec( value ) ) {
-								expectedTag = '<' + match[ 1 ] + '/>';
-								message = 'Single tag must use the format: ' + expectedTag;
-							} else {
-								return;
-							}
+			let expectedTag;
+			const arg = node.arguments[ 0 ];
+			if ( allowSingle ) {
+				const value = arg && allLiteral( arg ) && joinLiterals( arg );
+				if ( !( typeof value === 'string' && value ) || !rquickExpr.exec( value ) ) {
+					// Empty or non-string, or non-HTML
+					return;
+				}
+				let match;
+				if ( ( match = rsingleTag.exec( value ) ) ) {
+					// Single tag
+					const singleTagStyle = ( context.options[ 0 ] && context.options[ 0 ].singleTagStyle ) || 'minimal';
+					if ( singleTagStyle === 'minimal' ) {
+						if ( !rsingleTagMinimal.exec( value ) ) {
+							expectedTag = '<' + match[ 1 ] + '>';
+							message = 'Single tag must use the format: ' + expectedTag;
 						} else {
-							// singleTagStyle === 'any'
 							return;
 						}
-					}
-				} else if ( !( arg && allLiteral( arg ) ) ) {
-					// Non literals passed to $.parseHTML
-					return;
-				}
-
-				context.report( {
-					node: node,
-					message: message,
-					fix: function ( fixer ) {
-						if ( expectedTag ) {
-							return fixer.replaceText( arg, '"' + expectedTag + '"' );
+					} else if ( singleTagStyle === 'self-closing' ) {
+						if ( !rsingleTagSelfClosing.exec( value ) ) {
+							expectedTag = '<' + match[ 1 ] + '/>';
+							message = 'Single tag must use the format: ' + expectedTag;
+						} else {
+							return;
 						}
-						return null;
+					} else {
+						// singleTagStyle === 'any'
+						return;
 					}
-				} );
+				}
+			} else if ( !( arg && allLiteral( arg ) ) ) {
+				// Non literals passed to $.parseHTML
+				return;
 			}
-		};
-	}
+
+			context.report( {
+				node,
+				message,
+				fix: ( fixer ) => expectedTag ? fixer.replaceText( arg, '"' + expectedTag + '"' ) : null
+			} );
+		}
+	} )
 };

package/src/rules/no-parse-json.js

@@ -7,8 +7,6 @@ module.exports = utils.createUtilMethodRule(
 	'Prefer `JSON.parse` to `$.parseJSON`',
 	{
 		fixable: 'code',
-		fix: function ( node, context, fixer ) {
-			return fixer.replaceText( node.callee, 'JSON.parse' );
-		}
+		fix: ( node, context, fixer ) => fixer.replaceText( node.callee, 'JSON.parse' )
 	}
 );

package/src/rules/no-parse-xml.js

@@ -7,7 +7,7 @@ module.exports = utils.createUtilMethodRule(
 	'Prefer `DOMParser#parseFromString` to `$.parseXML`',
 	{
 		fixable: 'code',
-		fix: function ( node, context, fixer ) {
+		fix: ( node, context, fixer ) => {
 			if ( node.arguments.length ) {
 				return [
 					fixer.replaceText( node.callee, '( new window.DOMParser() ).parseFromString' ),

package/src/rules/no-prop.js

@@ -6,5 +6,5 @@ module.exports = utils.createCollectionOrUtilMethodRule(
 	[ 'prop', 'removeProp' ],
 	( node ) => node === true ?
 		'Prefer direct property access' :
-		`Prefer direct property access to .${node.callee.property.name}/$.${node.callee.property.name}`
+		`Prefer direct property access to .${ node.callee.property.name }/$.${ node.callee.property.name }`
 );

package/src/rules/no-proxy.js

@@ -7,7 +7,7 @@ module.exports = utils.createUtilMethodRule(
 	'Prefer `Function#bind` to `$.proxy`',
 	{
 		fixable: 'code',
-		fix: function ( node, context, fixer ) {
+		fix: ( node, context, fixer ) => {
 			if (
 				node.arguments.length >= 2 &&
 				node.arguments[ 1 ].type !== 'Literal'

package/src/rules/no-ready-shorthand.js

@@ -7,7 +7,7 @@ module.exports = utils.createCollectionMethodRule(
 	'Prefer `$()` to `.ready`',
 	{
 		fixable: 'code',
-		fix: function ( node, context, fixer ) {
+		fix: ( node, context, fixer ) => {
 			if ( node.parent.type === 'ExpressionStatement' ) {
 				return fixer.replaceText( node.callee, '$' );
 			}

package/src/rules/no-ready.js

@@ -30,16 +30,14 @@ module.exports = {
 		schema: []
 	},
 
-	create: function ( context ) {
-		return {
-			'CallExpression:exit': function ( node ) {
-				if ( isDirect( context, node ) || isChained( context, node ) ) {
-					context.report( {
-						node: node,
-						message: '.ready is not allowed'
-					} );
-				}
+	create: ( context ) => ( {
+		'CallExpression:exit': ( node ) => {
+			if ( isDirect( context, node ) || isChained( context, node ) ) {
+				context.report( {
+					node,
+					message: '.ready is not allowed'
+				} );
 			}
-		};
-	}
+		}
+	} )
 };

package/src/rules/no-serialize.js

@@ -6,5 +6,5 @@ module.exports = utils.createCollectionMethodRule(
 	[ 'serialize', 'serializeArray' ],
 	( node ) => node === true ?
 		'Prefer `FormData` or `URLSearchParams`' :
-		`Prefer FormData or URLSearchParams to .${node.callee.property.name}`
+		`Prefer FormData or URLSearchParams to .${ node.callee.property.name }`
 );

package/src/rules/no-size.js

@@ -7,8 +7,6 @@ module.exports = utils.createCollectionMethodRule(
 	'Prefer `.length` to `.size`',
 	{
 		fixable: 'code',
-		fix: function ( node, context, fixer ) {
-			return fixer.replaceTextRange( [ node.callee.property.range[ 0 ], node.range[ 1 ] ], 'length' );
-		}
+		fix: ( node, context, fixer ) => fixer.replaceTextRange( [ node.callee.property.range[ 0 ], node.range[ 1 ] ], 'length' )
 	}
 );

package/src/rules/no-sizzle.js

@@ -39,8 +39,8 @@ module.exports = {
 		]
 	},
 
-	create: function ( context ) {
-		const forbiddenPositional = /:eq|:even|:first([^-]|$)|:gt|:last([^-]|$)|:lt|:nth|:odd/;
+	create: ( context ) => {
+		const forbiddenPositional = /:eq|:even|:first([^-]|$)|:gt|:last([^-]|$)|:lt|:nth([^-]|$)|:odd/;
 		const forbiddenOther = /:animated|:button|:checkbox|:file|:has|:header|:hidden|:image|:input|:parent|:password|:radio|:reset|:selected|:submit|:text|:visible/;
 		const traversals = [
 			'children',
@@ -63,7 +63,7 @@ module.exports = {
 		];
 
 		return {
-			'CallExpression:exit': function ( node ) {
+			'CallExpression:exit': ( node ) => {
 				if (
 					!node.arguments[ 0 ] ||
 					!utils.isjQuery( context, node.callee ) ||
@@ -83,12 +83,12 @@ module.exports = {
 
 				if ( !allowPositional && forbiddenPositional.test( value ) ) {
 					context.report( {
-						node: node,
+						node,
 						message: 'Positional selector extensions are not allowed'
 					} );
 				} else if ( !allowOther && forbiddenOther.test( value ) ) {
 					context.report( {
-						node: node,
+						node,
 						message: 'Selector extensions are not allowed'
 					} );
 				}

package/src/rules/no-slide.js

@@ -6,5 +6,5 @@ module.exports = utils.createCollectionMethodRule(
 	[ 'slideDown', 'slideToggle', 'slideUp' ],
 	( node ) => node === true ?
 		'Prefer CSS transitions' :
-		`Prefer CSS transitions to .${node.callee.property.name}`
+		`Prefer CSS transitions to .${ node.callee.property.name }`
 );

package/src/rules/no-submit.js

@@ -4,5 +4,6 @@ const utils = require( '../utils.js' );
 
 module.exports = utils.createCollectionMethodRule(
 	'submit',
-	'Prefer `EventTarget#dispatchEvent` + `HTMLFormElement#submit` to `.submit`'
+	'Prefer `EventTarget#dispatchEvent` + `HTMLFormElement#submit` to `.submit`',
+	{ deprecated: [ 'no-event-shorthand' ] }
 );

package/src/rules/no-unique.js

@@ -7,8 +7,6 @@ module.exports = utils.createUtilMethodRule(
 	'Prefer `$.uniqueSort` to `$.unique`',
 	{
 		fixable: 'code',
-		fix: function ( node, context, fixer ) {
-			return fixer.replaceText( node.callee.property, 'uniqueSort' );
-		}
+		fix: ( node, context, fixer ) => fixer.replaceText( node.callee.property, 'uniqueSort' )
 	}
 );

package/src/rules/no-visibility.js

@@ -5,5 +5,5 @@ const utils = require( '../utils.js' );
 module.exports = utils.createCollectionMethodRule(
 	[ 'show', 'hide', 'toggle' ],
 	( node ) => node === true ? '' :
-		`.${node.callee.property.name} is not allowed`
+		`.${ node.callee.property.name } is not allowed`
 );

package/src/rules/no-wrap.js

@@ -5,5 +5,5 @@ const utils = require( '../utils.js' );
 module.exports = utils.createCollectionMethodRule(
 	[ 'wrap', 'wrapAll', 'wrapInner', 'unwrap' ],
 	( node ) => node === true ? '' :
-		`.${node.callee.property.name} is not allowed`
+		`.${ node.callee.property.name } is not allowed`
 );

package/src/rules/variable-pattern.js

@@ -11,27 +11,28 @@ module.exports = {
 		schema: []
 	},
 
-	create: function ( context ) {
+	create: ( context ) => {
 		function test( node, left, right ) {
 			if (
 				!utils.isjQuery( context, left ) &&
 				// If the variable name is computed (e.g. foo[bar]) we
 				// can't be sure this is not correctly named.
 				!left.computed &&
-				utils.isjQuery( context, right )
+				// right can be null, e.g. `var x;`
+				right && utils.isjQuery( context, right )
 			) {
 				context.report( {
-					node: node,
+					node,
 					message: 'jQuery collection names must match the variablePattern'
 				} );
 			}
 		}
 
 		return {
-			'AssignmentExpression:exit': function ( node ) {
+			'AssignmentExpression:exit': ( node ) => {
 				test( node, node.left, node.right );
 			},
-			'VariableDeclarator:exit': function ( node ) {
+			'VariableDeclarator:exit': ( node ) => {
 				test( node, node.id, node.init );
 			}
 		};