eslint-plugin-no-jquery 2.6.0 → 3.0.0

package/README.md

@@ -38,7 +38,7 @@ Add `no-jquery` to the plugins section of your `.eslintrc` configuration file. Y
 
 The config **`plugin:no-jquery/recommended`** includes the recommended rule [`no-jquery/variable-pattern`](docs/rules/variable-pattern.md) which is required for method rules to work correctly.
 
-The config **`plugin:no-jquery/deprecated`** includes all known deprecated and removed code, and is updated as new releases of jQuery come out. You can instead use configs targeting specific versions of jQuery if you know the environment in which your code will operate. There is a config for all minor versions from 1.0 to 3.6 (`deprecated-1.0`, ..., `deprecated-3.6`). Deprecation configs are cumulative, so they include all the rules for jQuery versions below them.
+The config **`plugin:no-jquery/deprecated`** includes all known deprecated and removed code, and is updated as new releases of jQuery come out. You can instead use configs targeting specific versions of jQuery if you know the environment in which your code will operate. There is a config for all minor versions from 1.0 to 3.6 (`deprecated-1.0`, ..., `deprecated-3.7`). Deprecation configs are cumulative, so they include all the rules for jQuery versions below them.
 
 The config **`plugin:no-jquery/slim`** includes all features excluded from the official "slim" build of jQuery, specifically the [ajax](https://api.jquery.com/category/ajax/) and [effects](https://api.jquery.com/category/effects/) modules.
 
@@ -81,12 +81,16 @@ The following global settings can be used under the `no-jquery` property to conf
 
 ## 📖 Rules
 
-Where rules are included in the configs `recommended`, `slim`, `all` or `deprecated-X.X` it is indicated below. Where rules are included with options this is indicated with a `†`.
+Rules with options are indicated with ⚙️. Rules which are fixable are indicated with 🔧.
+
+Where rules are included in the configs `recommended`, `slim`, `all` or `deprecated-X.X` it is indicated below. Where rules are included in a config with non-default options this is indicated with a `†`.
+
 * [`no-jquery/no-ajax`](docs/rules/no-ajax.md) `slim`, `all`
 * [`no-jquery/no-ajax-events`](docs/rules/no-ajax-events.md) `slim`
-* [`no-jquery/no-and-self`](docs/rules/no-and-self.md) `1.8`
-* [`no-jquery/no-animate`](docs/rules/no-animate.md) `slim`, `all`
+* [`no-jquery/no-and-self`](docs/rules/no-and-self.md) 🔧 `1.8`
+* [`no-jquery/no-animate`](docs/rules/no-animate.md) ⚙️ `slim`, `all`
 * [`no-jquery/no-animate-toggle`](docs/rules/no-animate-toggle.md) `slim`
+* [`no-jquery/no-append-html`](docs/rules/no-append-html.md)
 * [`no-jquery/no-attr`](docs/rules/no-attr.md) `all`
 * [`no-jquery/no-bind`](docs/rules/no-bind.md) `3.0`, `all`
 * [`no-jquery/no-box-model`](docs/rules/no-box-model.md) `1.3`
@@ -106,11 +110,11 @@ Where rules are included in the configs `recommended`, `slim`, `all` or `depreca
 * [`no-jquery/no-each`](docs/rules/no-each.md)
 * [`no-jquery/no-each-collection`](docs/rules/no-each-collection.md) `all`
 * [`no-jquery/no-each-util`](docs/rules/no-each-util.md) `all`
-* [`no-jquery/no-error`](docs/rules/no-error.md) `all`
-* [`no-jquery/no-error-shorthand`](docs/rules/no-error-shorthand.md) `1.8`
-* [`no-jquery/no-escape-selector`](docs/rules/no-escape-selector.md) `all`
-* [`no-jquery/no-event-shorthand`](docs/rules/no-event-shorthand.md) `3.5`, `3.3†`, `all`
-* [`no-jquery/no-extend`](docs/rules/no-extend.md) `all`
+* [`no-jquery/no-error`](docs/rules/no-error.md) 🔧 `all`
+* [`no-jquery/no-error-shorthand`](docs/rules/no-error-shorthand.md) 🔧 `1.8`
+* [`no-jquery/no-escape-selector`](docs/rules/no-escape-selector.md) 🔧 `all`
+* [`no-jquery/no-event-shorthand`](docs/rules/no-event-shorthand.md) ⚙️ 🔧 `3.5`, `3.3†`, `all`
+* [`no-jquery/no-extend`](docs/rules/no-extend.md) ⚙️ 🔧 `all`
 * [`no-jquery/no-fade`](docs/rules/no-fade.md) `slim`, `all`
 * [`no-jquery/no-filter`](docs/rules/no-filter.md) `all`
 * [`no-jquery/no-find`](docs/rules/no-find.md)
@@ -118,58 +122,57 @@ Where rules are included in the configs `recommended`, `slim`, `all` or `depreca
 * [`no-jquery/no-find-util`](docs/rules/no-find-util.md) `all`
 * [`no-jquery/no-fx-interval`](docs/rules/no-fx-interval.md) `3.0`
 * [`no-jquery/no-global-eval`](docs/rules/no-global-eval.md) `all`
-* [`no-jquery/no-global-selector`](docs/rules/no-global-selector.md)
+* [`no-jquery/no-global-selector`](docs/rules/no-global-selector.md) ⚙️
 * [`no-jquery/no-grep`](docs/rules/no-grep.md) `all`
 * [`no-jquery/no-has`](docs/rules/no-has.md) `all`
 * [`no-jquery/no-hold-ready`](docs/rules/no-hold-ready.md) `3.2`, `all`
-* [`no-jquery/no-html`](docs/rules/no-html.md) `all`
+* [`no-jquery/no-html`](docs/rules/no-html.md) ⚙️ `all`
 * [`no-jquery/no-in-array`](docs/rules/no-in-array.md) `all`
 * [`no-jquery/no-is`](docs/rules/no-is.md) `all`
-* [`no-jquery/no-is-array`](docs/rules/no-is-array.md) `3.2`, `all`
+* [`no-jquery/no-is-array`](docs/rules/no-is-array.md) 🔧 `3.2`, `all`
 * [`no-jquery/no-is-empty-object`](docs/rules/no-is-empty-object.md) `all`
-* [`no-jquery/no-is-function`](docs/rules/no-is-function.md) `3.3`, `all`
+* [`no-jquery/no-is-function`](docs/rules/no-is-function.md) 🔧 `3.3`, `all`
 * [`no-jquery/no-is-numeric`](docs/rules/no-is-numeric.md) `3.3`, `all`
 * [`no-jquery/no-is-plain-object`](docs/rules/no-is-plain-object.md) `all`
 * [`no-jquery/no-is-window`](docs/rules/no-is-window.md) `3.3`, `all`
 * [`no-jquery/no-jquery-constructor`](docs/rules/no-jquery-constructor.md) `all`
 * [`no-jquery/no-live`](docs/rules/no-live.md) `1.7`, `all`
 * [`no-jquery/no-load`](docs/rules/no-load.md) `slim`, `all`
-* [`no-jquery/no-load-shorthand`](docs/rules/no-load-shorthand.md) `1.8`
+* [`no-jquery/no-load-shorthand`](docs/rules/no-load-shorthand.md) 🔧 `1.8`
 * [`no-jquery/no-map`](docs/rules/no-map.md)
 * [`no-jquery/no-map-collection`](docs/rules/no-map-collection.md) `all`
 * [`no-jquery/no-map-util`](docs/rules/no-map-util.md) `all`
 * [`no-jquery/no-merge`](docs/rules/no-merge.md) `all`
 * [`no-jquery/no-node-name`](docs/rules/no-node-name.md) `3.2`, `all`
-* [`no-jquery/no-noop`](docs/rules/no-noop.md) `all`
-* [`no-jquery/no-now`](docs/rules/no-now.md) `3.3`, `all`
-* [`no-jquery/no-on-ready`](docs/rules/no-on-ready.md) `1.8`
+* [`no-jquery/no-noop`](docs/rules/no-noop.md) 🔧 `all`
+* [`no-jquery/no-now`](docs/rules/no-now.md) 🔧 `3.3`, `all`
+* [`no-jquery/no-on-ready`](docs/rules/no-on-ready.md) 🔧 `1.8`
 * [`no-jquery/no-other-methods`](docs/rules/no-other-methods.md) `all`
 * [`no-jquery/no-other-utils`](docs/rules/no-other-utils.md) `all`
 * [`no-jquery/no-param`](docs/rules/no-param.md) `all`
 * [`no-jquery/no-parent`](docs/rules/no-parent.md) `all`
 * [`no-jquery/no-parents`](docs/rules/no-parents.md) `all`
 * [`no-jquery/no-parse-html`](docs/rules/no-parse-html.md) `all`
-* [`no-jquery/no-parse-html-literal`](docs/rules/no-parse-html-literal.md)
-* [`no-jquery/no-parse-json`](docs/rules/no-parse-json.md) `3.0`, `all`
-* [`no-jquery/no-parse-xml`](docs/rules/no-parse-xml.md) `slim`, `all`
+* [`no-jquery/no-parse-html-literal`](docs/rules/no-parse-html-literal.md) ⚙️ 🔧
+* [`no-jquery/no-parse-json`](docs/rules/no-parse-json.md) 🔧 `3.0`, `all`
+* [`no-jquery/no-parse-xml`](docs/rules/no-parse-xml.md) 🔧 `slim`, `all`
 * [`no-jquery/no-prop`](docs/rules/no-prop.md) `all`
-* [`no-jquery/no-proxy`](docs/rules/no-proxy.md) `3.3`, `all`
+* [`no-jquery/no-proxy`](docs/rules/no-proxy.md) 🔧 `3.3`, `all`
 * [`no-jquery/no-ready`](docs/rules/no-ready.md)
-* [`no-jquery/no-ready-shorthand`](docs/rules/no-ready-shorthand.md) `3.0`, `all`
+* [`no-jquery/no-ready-shorthand`](docs/rules/no-ready-shorthand.md) 🔧 `3.0`, `all`
 * [`no-jquery/no-selector-prop`](docs/rules/no-selector-prop.md) `1.7`
 * [`no-jquery/no-serialize`](docs/rules/no-serialize.md) `all`
-* [`no-jquery/no-size`](docs/rules/no-size.md) `1.8`, `all`
-* [`no-jquery/no-sizzle`](docs/rules/no-sizzle.md) `3.4†`
+* [`no-jquery/no-size`](docs/rules/no-size.md) 🔧 `1.8`, `all`
+* [`no-jquery/no-sizzle`](docs/rules/no-sizzle.md) ⚙️ `3.4†`
 * [`no-jquery/no-slide`](docs/rules/no-slide.md) `slim`, `all`
 * [`no-jquery/no-sub`](docs/rules/no-sub.md) `1.7`, `all`
-* [`no-jquery/no-submit`](docs/rules/no-submit.md)
 * [`no-jquery/no-support`](docs/rules/no-support.md) `1.9`
 * [`no-jquery/no-text`](docs/rules/no-text.md) `all`
 * [`no-jquery/no-trigger`](docs/rules/no-trigger.md) `all`
 * [`no-jquery/no-trim`](docs/rules/no-trim.md) `3.5`, `all`
 * [`no-jquery/no-type`](docs/rules/no-type.md) `3.3`, `all`
-* [`no-jquery/no-unique`](docs/rules/no-unique.md) `3.0`, `all`
-* [`no-jquery/no-unload-shorthand`](docs/rules/no-unload-shorthand.md) `1.8`
+* [`no-jquery/no-unique`](docs/rules/no-unique.md) 🔧 `3.0`, `all`
+* [`no-jquery/no-unload-shorthand`](docs/rules/no-unload-shorthand.md) 🔧 `1.8`
 * [`no-jquery/no-val`](docs/rules/no-val.md) `all`
 * [`no-jquery/no-visibility`](docs/rules/no-visibility.md) `all`
 * [`no-jquery/no-when`](docs/rules/no-when.md) `all`
@@ -181,6 +184,7 @@ Where rules are included in the configs `recommended`, `slim`, `all` or `depreca
 * [`no-jquery/no-die`](docs/rules/no-die.md) (use [`no-jquery/no-live`](docs/rules/no-live.md))
 * [`no-jquery/no-hide`](docs/rules/no-hide.md) (use [`no-jquery/no-visibility`](docs/rules/no-visibility.md))
 * [`no-jquery/no-show`](docs/rules/no-show.md) (use [`no-jquery/no-visibility`](docs/rules/no-visibility.md))
+* [`no-jquery/no-submit`](docs/rules/no-submit.md) (use [`no-jquery/no-event-shorthand`](docs/rules/no-event-shorthand.md))
 * [`no-jquery/no-toggle`](docs/rules/no-toggle.md) (use [`no-jquery/no-visibility`](docs/rules/no-visibility.md))
 * [`no-jquery/no-unbind`](docs/rules/no-unbind.md) (use [`no-jquery/no-bind`](docs/rules/no-bind.md))
 * [`no-jquery/no-undelegate`](docs/rules/no-undelegate.md) (use [`no-jquery/no-delegate`](docs/rules/no-delegate.md))

package/README.md.template

@@ -37,7 +37,7 @@ Add `no-jquery` to the plugins section of your `.eslintrc` configuration file. Y
 
 The config **`plugin:no-jquery/recommended`** includes the recommended rule [`no-jquery/variable-pattern`](docs/rules/variable-pattern.md) which is required for method rules to work correctly.
 
-The config **`plugin:no-jquery/deprecated`** includes all known deprecated and removed code, and is updated as new releases of jQuery come out. You can instead use configs targeting specific versions of jQuery if you know the environment in which your code will operate. There is a config for all minor versions from 1.0 to 3.6 (`deprecated-1.0`, ..., `deprecated-3.6`). Deprecation configs are cumulative, so they include all the rules for jQuery versions below them.
+The config **`plugin:no-jquery/deprecated`** includes all known deprecated and removed code, and is updated as new releases of jQuery come out. You can instead use configs targeting specific versions of jQuery if you know the environment in which your code will operate. There is a config for all minor versions from 1.0 to 3.6 (`deprecated-1.0`, ..., `deprecated-3.7`). Deprecation configs are cumulative, so they include all the rules for jQuery versions below them.
 
 The config **`plugin:no-jquery/slim`** includes all features excluded from the official "slim" build of jQuery, specifically the [ajax](https://api.jquery.com/category/ajax/) and [effects](https://api.jquery.com/category/effects/) modules.
 
@@ -80,7 +80,10 @@ The following global settings can be used under the `no-jquery` property to conf
 
 ## 📖 Rules
 
-Where rules are included in the configs `recommended`, `slim`, `all` or `deprecated-X.X` it is indicated below. Where rules are included with options this is indicated with a `†`.
+Rules with options are indicated with ⚙️. Rules which are fixable are indicated with 🔧.
+
+Where rules are included in the configs `recommended`, `slim`, `all` or `deprecated-X.X` it is indicated below. Where rules are included in a config with non-default options this is indicated with a `†`.
+
 <!-- rules -->
 
 ### ⚠️ Deprecated

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "eslint-plugin-no-jquery",
-	"version": "2.6.0",
+	"version": "3.0.0",
 	"description": "Disallow jQuery functions with native equivalents.",
 	"repository": {
 		"type": "git",
@@ -16,7 +16,7 @@
 	"scripts": {
 		"pretest": "eslint --report-unused-disable-directives .",
 		"test": "nyc mocha --reporter dot tests/** && git diff --exit-code docs/ src/ README.md",
-		"onlytest": "mocha --reporter dot tests/** --nofix",
+		"onlytest": "mocha --reporter dot tests/**",
 		"report": "nyc report --reporter=text-lcov > coverage.lcov",
 		"reporthtml": "nyc report --reporter=html",
 		"testpath": "mocha",
@@ -26,18 +26,21 @@
 	"files": [
 		"src"
 	],
+	"engine": {
+		"node": ">=16"
+	},
 	"peerDependencies": {
-		"eslint": ">=2.3.0"
+		"eslint": ">=8.0.0"
 	},
 	"devDependencies": {
-		"codecov": "^3.8.1",
-		"eslint-config-wikimedia": "^0.19.0",
-		"eslint-docgen": "^0.4.5",
-		"eslint-plugin-eslint-plugin": "^2.3.0",
+		"codecov": "^3.8.3",
+		"eslint-config-wikimedia": "^0.28.0",
+		"eslint-docgen": "^0.7.1",
+		"eslint-plugin-eslint-plugin": "^6.1.0",
 		"eslint-plugin-self": "^1.2.1",
-		"jquery": "3.6.0",
-		"jsdom": "^16.5.2",
-		"mocha": "^8.3.2",
+		"jquery": "3.7.1",
+		"jsdom": "^22.1.0",
+		"mocha": "^10.2.0",
 		"nyc": "^15.1.0"
 	},
 	"bugs": {

package/src/.eslintrc.js

@@ -0,0 +1,17 @@
+module.exports = {
+	"overrides": [
+		{
+			// Rules applying to index.js are used to autofix documentation
+			"files": [
+				"index.js"
+			],
+			"rules": {
+				// Allow non-arrow functions in examples
+				"prefer-arrow-callback": "off",
+				// Allow compact single line functions
+				"max-statements-per-line": "off",
+				"brace-style": "off"
+			}
+		}
+	]
+};

package/src/all-methods.js

@@ -1,6 +1,6 @@
 'use strict';
 
-<!-- This file is built by build-all-methods.js; do not edit it directly. -->
+/* This file is built by build-all-methods.js; do not edit it directly. */
 module.exports = [
 	'add',
 	'addBack',
@@ -135,6 +135,7 @@ module.exports = [
 	'triggerHandler',
 	'unbind',
 	'undelegate',
+	'uniqueSort',
 	'unwrap',
 	'val',
 	'width',

package/src/index.js

@@ -7,6 +7,7 @@ module.exports = {
 		'no-and-self': require( './rules/no-and-self' ),
 		'no-animate': require( './rules/no-animate' ),
 		'no-animate-toggle': require( './rules/no-animate-toggle' ),
+		'no-append-html': require( './rules/no-append-html' ),
 		'no-attr': require( './rules/no-attr' ),
 		'no-bind': require( './rules/no-bind' ),
 		'no-box-model': require( './rules/no-box-model' ),
@@ -125,9 +126,12 @@ module.exports = {
 		},
 		// Use this config if you want to avoid all known deprecated jQuery tools.
 		deprecated: {
+			extends: 'plugin:no-jquery/deprecated-3.7'
+		},
+		// Use this config if you're writing code targetting jQuery 3.7.x environments.
+		'deprecated-3.7': {
 			extends: 'plugin:no-jquery/deprecated-3.6'
 		},
-		// Use this config if you're writing code targetting jQuery 3.6.x environments.
 		'deprecated-3.6': {
 			extends: 'plugin:no-jquery/deprecated-3.5'
 		},

package/src/rules/no-ajax-events.js

@@ -3,12 +3,12 @@
 const utils = require( '../utils.js' );
 
 const disallowedEvents = [
-	'ajaxStart',
-	'ajaxSend',
-	'ajaxSuccess',
-	'ajaxError',
 	'ajaxComplete',
-	'ajaxStop'
+	'ajaxError',
+	'ajaxSend',
+	'ajaxStart',
+	'ajaxStop',
+	'ajaxSuccess'
 ];
 
 module.exports = {
@@ -20,36 +20,34 @@ module.exports = {
 		schema: []
 	},
 
-	create: function ( context ) {
-		return {
-			'CallExpression:exit': function ( node ) {
-				if ( node.callee.type !== 'MemberExpression' ) {
-					return;
-				}
-				let usedMethod;
-				if (
-					node.callee.property.name === 'on' &&
+	create: ( context ) => ( {
+		'CallExpression:exit': ( node ) => {
+			if ( node.callee.type !== 'MemberExpression' ) {
+				return;
+			}
+			let usedMethod;
+			if (
+				node.callee.property.name === 'on' &&
 					node.arguments.length >= 1
-				) {
-					const arg = node.arguments[ 0 ];
-					if (
-						arg.type === 'Literal' &&
+			) {
+				const arg = node.arguments[ 0 ];
+				if (
+					arg.type === 'Literal' &&
 						disallowedEvents.includes( arg.value )
-					) {
-						usedMethod = arg.value;
-					}
-				}
-				if ( disallowedEvents.includes( node.callee.property.name ) ) {
-					usedMethod = node.callee.property.name;
-				}
-				if ( usedMethod && utils.isjQuery( context, node ) ) {
-					context.report( {
-						node: node,
-						message: 'Prefer local event to {{method}}',
-						data: { method: usedMethod }
-					} );
+				) {
+					usedMethod = arg.value;
 				}
 			}
-		};
-	}
+			if ( disallowedEvents.includes( node.callee.property.name ) ) {
+				usedMethod = node.callee.property.name;
+			}
+			if ( usedMethod && utils.isjQuery( context, node ) ) {
+				context.report( {
+					node,
+					message: 'Prefer local event to {{method}}',
+					data: { method: usedMethod }
+				} );
+			}
+		}
+	} )
 };

package/src/rules/no-ajax.js

@@ -6,5 +6,5 @@ module.exports = utils.createUtilMethodRule(
 	[ 'ajax', 'get', 'getJSON', 'getScript', 'post' ],
 	( node ) => node === true ?
 		'Prefer `Window.fetch`' :
-		`Prefer Window.fetch to $.${node.callee.property.name}`
+		`Prefer Window.fetch to $.${ node.callee.property.name }`
 );

package/src/rules/no-and-self.js

@@ -7,8 +7,6 @@ module.exports = utils.createCollectionMethodRule(
 	'Prefer `.addBack` to `.andSelf`',
 	{
 		fixable: 'code',
-		fix: function ( node, context, fixer ) {
-			return fixer.replaceText( node.callee.property, 'addBack' );
-		}
+		fix: ( node, context, fixer ) => fixer.replaceText( node.callee.property, 'addBack' )
 	}
 );

package/src/rules/no-animate-toggle.js

@@ -14,11 +14,11 @@ module.exports = {
 		schema: []
 	},
 
-	create: function ( context ) {
+	create: ( context ) => {
 		const forbidden = [ 'show', 'hide', 'toggle' ];
 
 		return {
-			'CallExpression:exit': function ( node ) {
+			'CallExpression:exit': ( node ) => {
 				if (
 					node.callee.type !== 'MemberExpression' ||
 					!forbidden.includes( node.callee.property.name ) ||
@@ -45,7 +45,7 @@ module.exports = {
 
 				if ( utils.isjQuery( context, node ) ) {
 					context.report( {
-						node: node,
+						node,
 						message: 'Prefer CSS transitions to .{{method}}',
 						data: { method: node.callee.property.name }
 					} );

package/src/rules/no-animate.js

@@ -23,39 +23,37 @@ module.exports = {
 		]
 	},
 
-	create: function ( context ) {
-		return {
-			'CallExpression:exit': function ( node ) {
-				if (
-					node.callee.type !== 'MemberExpression' ||
+	create: ( context ) => ( {
+		'CallExpression:exit': ( node ) => {
+			if (
+				node.callee.type !== 'MemberExpression' ||
 					node.callee.property.name !== 'animate'
-				) {
-					return;
-				}
-				const allowScroll = context.options[ 0 ] && context.options[ 0 ].allowScroll;
-				if ( allowScroll ) {
-					const arg = node.arguments[ 0 ];
-					// Check properties list has more than just scrollTop/scrollLeft
-					if ( arg && arg.type === 'ObjectExpression' ) {
-						if (
-							arg.properties.every(
-								( prop ) => prop.key.name === 'scrollTop' || prop.key.name === 'scrollLeft'
-							)
-						) {
-							return;
-						}
+			) {
+				return;
+			}
+			const allowScroll = context.options[ 0 ] && context.options[ 0 ].allowScroll;
+			if ( allowScroll ) {
+				const arg = node.arguments[ 0 ];
+				// Check properties list has more than just scrollTop/scrollLeft
+				if ( arg && arg.type === 'ObjectExpression' ) {
+					if (
+						arg.properties.every(
+							( prop ) => prop.key.name === 'scrollTop' || prop.key.name === 'scrollLeft'
+						)
+					) {
+						return;
 					}
 				}
+			}
 
-				if ( utils.isjQuery( context, node ) ) {
-					context.report( {
-						node: node,
-						message: allowScroll ?
-							'Prefer CSS transitions to .animate' :
-							'Prefer CSS transitions or CSS scroll-behaviour to .animate'
-					} );
-				}
+			if ( utils.isjQuery( context, node ) ) {
+				context.report( {
+					node,
+					message: allowScroll ?
+						'Prefer CSS transitions to .animate' :
+						'Prefer CSS transitions or CSS scroll-behaviour to .animate'
+				} );
 			}
-		};
-	}
+		}
+	} )
 };

package/src/rules/no-append-html.js

@@ -0,0 +1,51 @@
+'use strict';
+
+const utils = require( '../utils.js' );
+const methods = [ 'append', 'prepend', 'before', 'after', 'replaceWith', 'add', 'appendTo', 'prependTo' ];
+
+function alljQueryOrEmpty( context, node ) {
+	if ( node.type === 'ConditionalExpression' ) {
+		return alljQueryOrEmpty( context, node.consequent ) &&
+			alljQueryOrEmpty( context, node.alternate );
+	} else if ( node.type === 'Literal' ) {
+		return node.value === null || (
+			typeof node.value === 'string' && node.value.match( /^\s*$/ )
+		);
+	} else if ( node.type === 'Identifier' && node.name === 'undefined' ) {
+		return true;
+	} else {
+		return utils.isjQuery( context, node );
+	}
+}
+
+module.exports = {
+	meta: {
+		type: 'suggestion',
+		docs: {
+			description: 'Disallows using ' + methods.map( utils.jQueryCollectionLink ).join( '/' ) +
+			' to inject HTML, in order to prevent possible XSS bugs.'
+		},
+		schema: []
+	},
+
+	create: ( context ) => ( {
+		'CallExpression:exit': ( node ) => {
+			if ( !(
+				node.callee.type === 'MemberExpression' &&
+					methods.includes( node.callee.property.name )
+			) ) {
+				return;
+			}
+			if ( node.arguments.every( ( arg ) => alljQueryOrEmpty( context, arg ) ) ) {
+				return;
+			}
+
+			if ( utils.isjQuery( context, node.callee ) ) {
+				context.report( {
+					node,
+					message: 'Avoid injection of possibly unescaped HTML. Create DOM elements instead, or use .text.'
+				} );
+			}
+		}
+	} )
+};

package/src/rules/no-class-state.js

@@ -15,12 +15,11 @@ module.exports = {
 		schema: []
 	},
 
-	create: function ( context ) {
-		return {
-			'CallExpression:exit': function ( node ) {
-				if ( !(
-					node.callee.type === 'MemberExpression' && (
-						node.callee.property.name === 'hasClass' ||
+	create: ( context ) => ( {
+		'CallExpression:exit': ( node ) => {
+			if ( !(
+				node.callee.type === 'MemberExpression' && (
+					node.callee.property.name === 'hasClass' ||
 						// toggleClass with one argument will check if the
 						// class is already in the DOM before deciding what to do,
 						// so it is equivalent to using hasClass.
@@ -28,18 +27,17 @@ module.exports = {
 							node.callee.property.name === 'toggleClass' &&
 							node.arguments.length === 1
 						)
-					)
-				) ) {
-					return;
-				}
+				)
+			) ) {
+				return;
+			}
 
-				if ( utils.isjQuery( context, node.callee ) ) {
-					context.report( {
-						node: node,
-						message: 'Where possible, maintain application state in JS to avoid slower DOM queries'
-					} );
-				}
+			if ( utils.isjQuery( context, node.callee ) ) {
+				context.report( {
+					node,
+					message: 'Where possible, maintain application state in JS to avoid slower DOM queries'
+				} );
 			}
-		};
-	}
+		}
+	} )
 };

package/src/rules/no-class.js

@@ -6,5 +6,5 @@ module.exports = utils.createCollectionMethodRule(
 	[ 'addClass', 'hasClass', 'removeClass', 'toggleClass' ],
 	( node ) => node === true ?
 		'Prefer `Element#classList`' :
-		`Prefer Element#classList to .${node.callee.property.name}`
+		`Prefer Element#classList to .${ node.callee.property.name }`
 );

package/src/rules/no-constructor-attributes.js

@@ -11,35 +11,33 @@ module.exports = {
 		schema: []
 	},
 
-	create: function ( context ) {
-		return {
-			'CallExpression:exit': function ( node ) {
-				if ( node.callee.type === 'MemberExpression' ) {
-					if ( !(
-						node.callee.property.name === 'add' &&
+	create: ( context ) => ( {
+		'CallExpression:exit': ( node ) => {
+			if ( node.callee.type === 'MemberExpression' ) {
+				if ( !(
+					node.callee.property.name === 'add' &&
 						utils.isjQuery( context, node.callee ) &&
 						node.arguments[ 1 ] &&
 						node.arguments[ 1 ].type === 'ObjectExpression'
-					) ) {
-						return;
-					}
-				} else if ( node.callee.type === 'Identifier' ) {
-					if ( !(
-						utils.isjQueryConstructor( context, node.callee.name ) &&
+				) ) {
+					return;
+				}
+			} else if ( node.callee.type === 'Identifier' ) {
+				if ( !(
+					utils.isjQueryConstructor( context, node.callee.name ) &&
 						node.arguments[ 1 ] &&
 						node.arguments[ 1 ].type === 'ObjectExpression'
-					) ) {
-						return;
-					}
-				} else {
+				) ) {
 					return;
 				}
-
-				context.report( {
-					node: node,
-					message: 'Prefer .attr to constructor attributes'
-				} );
+			} else {
+				return;
 			}
-		};
-	}
+
+			context.report( {
+				node,
+				message: 'Prefer .attr to constructor attributes'
+			} );
+		}
+	} )
 };

package/src/rules/no-data.js

@@ -6,5 +6,5 @@ module.exports = utils.createCollectionOrUtilMethodRule(
 	[ 'data', 'removeData', 'hasData' ],
 	( node ) => node === true ?
 		'Prefer `WeakMap`' :
-		`Prefer WeakMap to .${node.callee.property.name}/$.${node.callee.property.name}`
+		`Prefer WeakMap to .${ node.callee.property.name }/$.${ node.callee.property.name }`
 );

package/src/rules/no-deferred.js

@@ -11,7 +11,7 @@ module.exports = {
 		schema: []
 	},
 
-	create: function ( context ) {
+	create: ( context ) => {
 		function enforce( node ) {
 			if (
 				node.callee.type !== 'MemberExpression' ||
@@ -22,7 +22,7 @@ module.exports = {
 			}
 
 			context.report( {
-				node: node,
+				node,
 				message: 'Prefer Promise to $.Deferred'
 			} );
 		}