eslint-plugin-jest 22.21.0 → 23.0.3

package/lib/rules/valid-expect-in-promise.js

@@ -9,14 +9,6 @@ var _experimentalUtils = require("@typescript-eslint/experimental-utils");
 
 var _utils = require("./utils");
 
-function _slicedToArray(arr, i) { return _arrayWithHoles(arr) || _iterableToArrayLimit(arr, i) || _nonIterableRest(); }
-
-function _nonIterableRest() { throw new TypeError("Invalid attempt to destructure non-iterable instance"); }
-
-function _iterableToArrayLimit(arr, i) { if (!(Symbol.iterator in Object(arr) || Object.prototype.toString.call(arr) === "[object Arguments]")) { return; } var _arr = []; var _n = true; var _d = false; var _e = undefined; try { for (var _i = arr[Symbol.iterator](), _s; !(_n = (_s = _i.next()).done); _n = true) { _arr.push(_s.value); if (i && _arr.length === i) break; } } catch (err) { _d = true; _e = err; } finally { try { if (!_n && _i["return"] != null) _i["return"](); } finally { if (_d) throw _e; } } return _arr; }
-
-function _arrayWithHoles(arr) { if (Array.isArray(arr)) return arr; }
-
 const isThenOrCatchCall = node => node.type === _experimentalUtils.AST_NODE_TYPES.CallExpression && node.callee.type === _experimentalUtils.AST_NODE_TYPES.MemberExpression && (0, _utils.isSupportedAccessor)(node.callee.property) && ['then', 'catch'].includes((0, _utils.getAccessorValue)(node.callee.property));
 
 const isExpectCallPresentInFunction = body => {
@@ -125,7 +117,9 @@ var _default = (0, _utils.createRule)({
         const testFunction = findTestFunction(node);
 
         if (testFunction && !isHavingAsyncCallBackParam(testFunction)) {
-          const body = testFunction.body;
+          const {
+            body
+          } = testFunction;
           /* istanbul ignore if https://github.com/typescript-eslint/typescript-eslint/issues/734 */
 
           if (!body) {
@@ -137,15 +131,11 @@ var _default = (0, _utils.createRule)({
           }
 
           const testFunctionBody = body.body;
-
-          const _node$arguments = _slicedToArray(node.arguments, 2),
-                fulfillmentCallback = _node$arguments[0],
-                rejectionCallback = _node$arguments[1]; // then block can have two args, fulfillment & rejection
+          const [fulfillmentCallback, rejectionCallback] = node.arguments; // then block can have two args, fulfillment & rejection
           // then block can have one args, fulfillment
           // catch block can have one args, rejection
           // ref: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise
 
-
           verifyExpectWithReturn([fulfillmentCallback, rejectionCallback], node.callee, context, testFunctionBody);
         }
       }

package/lib/rules/valid-expect.js

@@ -111,10 +111,11 @@ var _default = (0, _utils.createRule)({
           return;
         }
 
-        const _parseExpectCall = (0, _utils.parseExpectCall)(node),
-              expect = _parseExpectCall.expect,
-              modifier = _parseExpectCall.modifier,
-              matcher = _parseExpectCall.matcher;
+        const {
+          expect,
+          modifier,
+          matcher
+        } = (0, _utils.parseExpectCall)(node);
 
         if (expect.arguments.length > 1) {
           const secondArgumentLocStart = expect.arguments[1].loc.start;

package/lib/rules/valid-title.js

@@ -9,15 +9,19 @@ var _experimentalUtils = require("@typescript-eslint/experimental-utils");
 
 var _utils = require("./utils");
 
-function _slicedToArray(arr, i) { return _arrayWithHoles(arr) || _iterableToArrayLimit(arr, i) || _nonIterableRest(); }
-
-function _nonIterableRest() { throw new TypeError("Invalid attempt to destructure non-iterable instance"); }
+const trimFXprefix = word => ['f', 'x'].includes(word.charAt(0)) ? word.substr(1) : word;
 
-function _iterableToArrayLimit(arr, i) { if (!(Symbol.iterator in Object(arr) || Object.prototype.toString.call(arr) === "[object Arguments]")) { return; } var _arr = []; var _n = true; var _d = false; var _e = undefined; try { for (var _i = arr[Symbol.iterator](), _s; !(_n = (_s = _i.next()).done); _n = true) { _arr.push(_s.value); if (i && _arr.length === i) break; } } catch (err) { _d = true; _e = err; } finally { try { if (!_n && _i["return"] != null) _i["return"](); } finally { if (_d) throw _e; } } return _arr; }
+const doesBinaryExpressionContainStringNode = binaryExp => {
+  if ((0, _utils.isStringNode)(binaryExp.right)) {
+    return true;
+  }
 
-function _arrayWithHoles(arr) { if (Array.isArray(arr)) return arr; }
+  if (binaryExp.left.type === _experimentalUtils.AST_NODE_TYPES.BinaryExpression) {
+    return doesBinaryExpressionContainStringNode(binaryExp.left);
+  }
 
-const trimFXprefix = word => ['f', 'x'].includes(word.charAt(0)) ? word.substr(1) : word;
+  return (0, _utils.isStringNode)(binaryExp.left);
+};
 
 var _default = (0, _utils.createRule)({
   name: __filename,
@@ -28,32 +32,64 @@ var _default = (0, _utils.createRule)({
       recommended: false
     },
     messages: {
+      titleMustBeString: 'Title must be a string',
+      emptyTitle: '{{ jestFunctionName }} should not have an empty title',
       duplicatePrefix: 'should not have duplicate prefix',
       accidentalSpace: 'should not have leading or trailing spaces'
     },
     type: 'suggestion',
-    schema: [],
+    schema: [{
+      type: 'object',
+      properties: {
+        ignoreTypeOfDescribeName: {
+          type: 'boolean',
+          default: false
+        }
+      },
+      additionalProperties: false
+    }],
     fixable: 'code'
   },
-  defaultOptions: [],
+  defaultOptions: [{
+    ignoreTypeOfDescribeName: false
+  }],
 
-  create(context) {
+  create(context, [{
+    ignoreTypeOfDescribeName
+  }]) {
     return {
       CallExpression(node) {
         if (!((0, _utils.isDescribe)(node) || (0, _utils.isTestCase)(node)) || !node.arguments.length) {
           return;
         }
 
-        const _node$arguments = _slicedToArray(node.arguments, 1),
-              argument = _node$arguments[0];
+        const [argument] = (0, _utils.getJestFunctionArguments)(node);
 
         if (!(0, _utils.isStringNode)(argument)) {
+          if (argument.type === _experimentalUtils.AST_NODE_TYPES.BinaryExpression && doesBinaryExpressionContainStringNode(argument)) {
+            return;
+          }
+
+          if (argument.type !== _experimentalUtils.AST_NODE_TYPES.TemplateLiteral && !(ignoreTypeOfDescribeName && (0, _utils.isDescribe)(node))) {
+            context.report({
+              messageId: 'titleMustBeString',
+              loc: argument.loc
+            });
+          }
+
           return;
         }
 
         const title = (0, _utils.getStringValue)(argument);
 
         if (!title) {
+          context.report({
+            messageId: 'emptyTitle',
+            data: {
+              jestFunctionName: (0, _utils.isDescribe)(node) ? _utils.DescribeAlias.describe : _utils.TestCaseName.test
+            },
+            node
+          });
           return;
         }
 
@@ -71,10 +107,7 @@ var _default = (0, _utils.createRule)({
         }
 
         const nodeName = trimFXprefix((0, _utils.getNodeName)(node.callee));
-
-        const _title$split = title.split(' '),
-              _title$split2 = _slicedToArray(_title$split, 1),
-              firstWord = _title$split2[0];
+        const [firstWord] = title.split(' ');
 
         if (firstWord.toLowerCase() === nodeName) {
           context.report({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-jest",
-  "version": "22.21.0",
+  "version": "23.0.3",
   "description": "Eslint rules for Jest",
   "repository": "jest-community/eslint-plugin-jest",
   "license": "MIT",
@@ -20,7 +20,7 @@
   ],
   "main": "lib/",
   "engines": {
-    "node": ">=6"
+    "node": ">=8"
   },
   "peerDependencies": {
     "eslint": ">=5"
@@ -37,35 +37,39 @@
     "typecheck": "tsc -p ."
   },
   "dependencies": {
-    "@typescript-eslint/experimental-utils": "^1.13.0"
+    "@typescript-eslint/experimental-utils": "^2.5.0"
   },
   "devDependencies": {
     "@babel/cli": "^7.4.4",
     "@babel/core": "^7.4.4",
     "@babel/preset-env": "^7.4.4",
     "@babel/preset-typescript": "^7.3.3",
-    "@commitlint/cli": "^6.0.0",
-    "@commitlint/config-conventional": "^6.0.0",
-    "@types/eslint": "^4.16.6",
+    "@commitlint/cli": "^8.2.0",
+    "@commitlint/config-conventional": "^8.2.0",
+    "@semantic-release/changelog": "^3.0.5",
+    "@semantic-release/git": "^7.0.17",
+    "@types/eslint": "^6.1.3",
     "@types/jest": "^24.0.15",
     "@types/node": "^12.6.6",
-    "@typescript-eslint/eslint-plugin": "^1.13.0",
-    "@typescript-eslint/parser": "^1.13.0",
+    "@typescript-eslint/eslint-plugin": "^2.5.0",
+    "@typescript-eslint/parser": "^2.5.0",
     "babel-jest": "^24.9.0",
     "babel-plugin-replace-ts-export-assignment": "^0.0.2",
-    "eslint": "^5.1.0",
-    "eslint-config-prettier": "^5.1.0",
+    "eslint": "^5.1.0 || ^6.0.0",
+    "eslint-config-prettier": "^6.5.0",
     "eslint-plugin-eslint-plugin": "^2.0.0",
     "eslint-plugin-import": "^2.18.0",
-    "eslint-plugin-node": "^8.0.0",
+    "eslint-plugin-node": "^10.0.0",
     "eslint-plugin-prettier": "^3.0.0",
-    "husky": "^1.0.1",
+    "husky": "^3.0.9",
     "jest": "^24.9.0",
     "jest-runner-eslint": "^0.7.1",
-    "lint-staged": "^8.0.4",
+    "lint-staged": "^9.4.2",
     "prettier": "^1.10.2",
     "prettylint": "^1.0.0",
+    "resolve-from": "^5.0.0",
     "rimraf": "^3.0.0",
+    "semantic-release": "^15.13.28",
     "typescript": "^3.5.3"
   },
   "prettier": {
@@ -122,5 +126,15 @@
       "commit-msg": "commitlint -e $HUSKY_GIT_PARAMS",
       "pre-commit": "lint-staged"
     }
+  },
+  "release": {
+    "plugins": [
+      "@semantic-release/commit-analyzer",
+      "@semantic-release/release-notes-generator",
+      "@semantic-release/changelog",
+      "@semantic-release/npm",
+      "@semantic-release/git",
+      "@semantic-release/github"
+    ]
   }
 }

package/docs/rules/no-empty-title.md

@@ -1,36 +0,0 @@
-# Disallow empty titles
-
-Having an empty string as your test title is pretty useless. This rule reports
-an error if it finds an empty string as s test title.
-
-This rule is not auto-fixable.
-
-## Rule Details
-
-The following patterns are considered warnings:
-
-```js
-describe('', () => {});
-describe('foo', () => {
-  it('', () => {});
-});
-it('', () => {});
-test('', () => {});
-xdescribe('', () => {});
-xit('', () => {});
-xtest('', () => {});
-```
-
-These patterns would not be considered warnings:
-
-```js
-describe('foo', () => {});
-describe('foo', () => {
-  it('bar', () => {});
-});
-test('foo', () => {});
-it('foo', () => {});
-xdescribe('foo', () => {});
-xit('foo', () => {});
-xtest('foo', () => {});
-```

package/lib/rules/no-empty-title.js

@@ -1,60 +0,0 @@
-"use strict";
-
-Object.defineProperty(exports, "__esModule", {
-  value: true
-});
-exports.default = void 0;
-
-var _utils = require("./utils");
-
-function _slicedToArray(arr, i) { return _arrayWithHoles(arr) || _iterableToArrayLimit(arr, i) || _nonIterableRest(); }
-
-function _nonIterableRest() { throw new TypeError("Invalid attempt to destructure non-iterable instance"); }
-
-function _iterableToArrayLimit(arr, i) { if (!(Symbol.iterator in Object(arr) || Object.prototype.toString.call(arr) === "[object Arguments]")) { return; } var _arr = []; var _n = true; var _d = false; var _e = undefined; try { for (var _i = arr[Symbol.iterator](), _s; !(_n = (_s = _i.next()).done); _n = true) { _arr.push(_s.value); if (i && _arr.length === i) break; } } catch (err) { _d = true; _e = err; } finally { try { if (!_n && _i["return"] != null) _i["return"](); } finally { if (_d) throw _e; } } return _arr; }
-
-function _arrayWithHoles(arr) { if (Array.isArray(arr)) return arr; }
-
-var _default = (0, _utils.createRule)({
-  name: __filename,
-  meta: {
-    docs: {
-      category: 'Best Practices',
-      description: 'Disallow empty titles',
-      recommended: false
-    },
-    messages: {
-      describe: 'describe should not have an empty title',
-      test: 'test should not have an empty title'
-    },
-    type: 'suggestion',
-    schema: []
-  },
-  defaultOptions: [],
-
-  create(context) {
-    return {
-      CallExpression(node) {
-        if (!(0, _utils.isDescribe)(node) && !(0, _utils.isTestCase)(node)) {
-          return;
-        }
-
-        const _node$arguments = _slicedToArray(node.arguments, 1),
-              argument = _node$arguments[0];
-
-        if (!argument || !(0, _utils.isStringNode)(argument, '')) {
-          return;
-        }
-
-        context.report({
-          messageId: (0, _utils.isDescribe)(node) ? _utils.DescribeAlias.describe : _utils.TestCaseName.test,
-          node: argument
-        });
-      }
-
-    };
-  }
-
-});
-
-exports.default = _default;