eslint-plugin-jest 22.21.0 → 23.0.3

package/CHANGELOG.md

@@ -1,6 +1,33 @@
-# [22.2.0](https://github.com/jest-community/eslint-plugin-jest/compare/v22.1.3...v22.2.0) (2019-01-29)
+## [23.0.3](https://github.com/jest-community/eslint-plugin-jest/compare/v23.0.2...v23.0.3) (2019-11-08)
+
+### Bug Fixes
+
+- **no-test-callback:** don't provide fix for `async` functions
+  ([#469](https://github.com/jest-community/eslint-plugin-jest/issues/469))
+  ([09111e0](https://github.com/jest-community/eslint-plugin-jest/commit/09111e0c951aaa930c9a2c8e0ca84251b3196e94)),
+  closes [#466](https://github.com/jest-community/eslint-plugin-jest/issues/466)
+
+## [23.0.2](https://github.com/jest-community/eslint-plugin-jest/compare/v23.0.1...v23.0.2) (2019-10-28)
+
+### Bug Fixes
 
+- **prefer-todo:** ensure argument exists before trying to access it
+  ([#462](https://github.com/jest-community/eslint-plugin-jest/issues/462))
+  ([a87c8c2](https://github.com/jest-community/eslint-plugin-jest/commit/a87c8c29e1faf9d5364c9074d988aa95ef6cc987))
+
+## [23.0.1](https://github.com/jest-community/eslint-plugin-jest/compare/v23.0.0...v23.0.1) (2019-10-28)
+
+### Bug Fixes
+
+- **valid-title:** ignore string addition
+  ([#461](https://github.com/jest-community/eslint-plugin-jest/issues/461))
+  ([b7c1be2](https://github.com/jest-community/eslint-plugin-jest/commit/b7c1be2f279b87366332fb2d3a3e49a71aa75711))
+
+# [22.2.0](https://github.com/jest-community/eslint-plugin-jest/compare/v22.1.3...v22.2.0) (2019-01-29)
 
 ### Features
 
-* **rules:** add prefer-todo rule ([#218](https://github.com/jest-community/eslint-plugin-jest/issues/218)) ([0933d82](https://github.com/jest-community/eslint-plugin-jest/commit/0933d82)), closes [#217](https://github.com/jest-community/eslint-plugin-jest/issues/217)
+- **rules:** add prefer-todo rule
+  ([#218](https://github.com/jest-community/eslint-plugin-jest/issues/218))
+  ([0933d82](https://github.com/jest-community/eslint-plugin-jest/commit/0933d82)),
+  closes [#217](https://github.com/jest-community/eslint-plugin-jest/issues/217)

package/README.md

@@ -1,5 +1,5 @@
-[![Build Status](https://travis-ci.org/jest-community/eslint-plugin-jest.svg?branch=master)](https://travis-ci.org/jest-community/eslint-plugin-jest)
-[![Greenkeeper badge](https://badges.greenkeeper.io/jest-community/eslint-plugin-jest.svg)](https://greenkeeper.io/)
+[![Actions Status](https://github.com/jest-community/eslint-plugin-jest/workflows/Unit%20tests/badge.svg)](https://github.com/jest-community/eslint-plugin-jest/actions)
+[![Renovate badge](https://badges.renovateapi.com/github/jest-community/eslint-plugin-jest)](https://renovatebot.com/)
 
 <div align="center">
   <a href="https://eslint.org/">
@@ -111,15 +111,14 @@ installations requiring long-term consistency.
 | Rule                           | Description                                                       | Configurations   | Fixable             |
 | ------------------------------ | ----------------------------------------------------------------- | ---------------- | ------------------- |
 | [consistent-test-it][]         | Enforce consistent test or it keyword                             |                  | ![fixable-green][]  |
-| [expect-expect][]              | Enforce assertion to be made in a test body                       |                  |                     |
+| [expect-expect][]              | Enforce assertion to be made in a test body                       | ![recommended][] |                     |
 | [lowercase-name][]             | Disallow capitalized test names                                   |                  | ![fixable-green][]  |
-| [no-alias-methods][]           | Disallow alias methods                                            | ![recommended][] | ![fixable-green][]  |
-| [no-commented-out-tests][]     | Disallow commented out tests                                      |                  |                     |
+| [no-alias-methods][]           | Disallow alias methods                                            | ![style][]       | ![fixable-green][]  |
+| [no-commented-out-tests][]     | Disallow commented out tests                                      | ![recommended][] |                     |
 | [no-disabled-tests][]          | Disallow disabled tests                                           | ![recommended][] |                     |
 | [no-duplicate-hooks][]         | Disallow duplicate hooks within a `describe` block                |                  |                     |
-| [no-empty-title][]             | Disallow empty titles                                             |                  |                     |
 | [no-expect-resolves][]         | Disallow using `expect().resolves`                                |                  |                     |
-| [no-export][]                  | Disallow export from test files                                   |                  |                     |
+| [no-export][]                  | Disallow export from test files                                   | ![recommended][] |                     |
 | [no-focused-tests][]           | Disallow focused tests                                            | ![recommended][] |                     |
 | [no-hooks][]                   | Disallow setup and teardown hooks                                 |                  |                     |
 | [no-identical-title][]         | Disallow identical titles                                         | ![recommended][] |                     |
@@ -127,13 +126,13 @@ installations requiring long-term consistency.
 | [no-jasmine-globals][]         | Disallow Jasmine globals                                          | ![recommended][] | ![fixable-yellow][] |
 | [no-jest-import][]             | Disallow importing `jest`                                         | ![recommended][] |                     |
 | [no-large-snapshots][]         | Disallow large snapshots                                          |                  |                     |
-| [no-mocks-import][]            | Disallow manually importing from `__mocks__`                      |                  |                     |
-| [no-standalone-expect][]       | Prevents `expect` statements outside of a `test` or `it` block    |                  |                     |
-| [no-test-callback][]           | Using a callback in asynchronous tests                            |                  | ![fixable-green][]  |
+| [no-mocks-import][]            | Disallow manually importing from `__mocks__`                      | ![recommended][] |                     |
+| [no-standalone-expect][]       | Prevents `expect` statements outside of a `test` or `it` block    | ![recommended][] |                     |
+| [no-test-callback][]           | Using a callback in asynchronous tests                            | ![recommended][] | ![fixable-green][]  |
 | [no-test-prefixes][]           | Disallow using `f` & `x` prefixes to define focused/skipped tests | ![recommended][] | ![fixable-green][]  |
 | [no-test-return-statement][]   | Disallow explicitly returning from tests                          |                  |                     |
 | [no-truthy-falsy][]            | Disallow using `toBeTruthy()` & `toBeFalsy()`                     |                  |                     |
-| [no-try-expect][]              | Prevent `catch` assertions in tests                               |                  |                     |
+| [no-try-expect][]              | Prevent `catch` assertions in tests                               | ![recommended][] |                     |
 | [prefer-called-with][]         | Suggest using `toBeCalledWith()` OR `toHaveBeenCalledWith()`      |                  |                     |
 | [prefer-expect-assertions][]   | Suggest using `expect.assertions()` OR `expect.hasAssertions()`   |                  |                     |
 | [prefer-hooks-on-top][]        | Suggest to have all hooks at top-level before tests               |                  |                     |
@@ -146,7 +145,7 @@ installations requiring long-term consistency.
 | [prefer-to-have-length][]      | Suggest using `toHaveLength()`                                    | ![style][]       | ![fixable-green][]  |
 | [prefer-todo][]                | Suggest using `test.todo()`                                       |                  | ![fixable-green][]  |
 | [require-top-level-describe][] | Require a top-level `describe` block                              |                  |                     |
-| [require-tothrow-message][]    | Require that `toThrow()` and `toThrowError` includes a message    |                  |                     |
+| [require-to-throw-message][]   | Require that `toThrow()` and `toThrowError` includes a message    |                  |                     |
 | [valid-describe][]             | Enforce valid `describe()` callback                               | ![recommended][] |                     |
 | [valid-expect-in-promise][]    | Enforce having return statement when testing with promises        | ![recommended][] |                     |
 | [valid-expect][]               | Enforce valid `expect()` usage                                    | ![recommended][] |                     |
@@ -173,7 +172,6 @@ https://github.com/dangreenisrael/eslint-plugin-jest-formatting
 [no-commented-out-tests]: docs/rules/no-commented-out-tests.md
 [no-disabled-tests]: docs/rules/no-disabled-tests.md
 [no-duplicate-hooks]: docs/rules/no-duplicate-hooks.md
-[no-empty-title]: docs/rules/no-empty-title.md
 [no-expect-resolves]: docs/rules/no-expect-resolves.md
 [no-export]: docs/rules/no-export.md
 [no-focused-tests]: docs/rules/no-focused-tests.md
@@ -202,7 +200,7 @@ https://github.com/dangreenisrael/eslint-plugin-jest-formatting
 [prefer-to-have-length]: docs/rules/prefer-to-have-length.md
 [prefer-todo]: docs/rules/prefer-todo.md
 [require-top-level-describe]: docs/rules/require-top-level-describe.md
-[require-tothrow-message]: docs/rules/require-tothrow-message.md
+[require-to-throw-message]: docs/rules/require-to-throw-message.md
 [valid-describe]: docs/rules/valid-describe.md
 [valid-expect-in-promise]: docs/rules/valid-expect-in-promise.md
 [valid-expect]: docs/rules/valid-expect.md

package/docs/rules/valid-title.md

@@ -2,11 +2,89 @@
 
 Checks that the title of Jest blocks are valid by ensuring that titles are:
 
+- not empty,
+- is a string,
 - not prefixed with their block name,
 - have no leading or trailing spaces
 
 ## Rule Details
 
+**emptyTitle**
+
+An empty title is not informative, and serves little purpose.
+
+Examples of **incorrect** code for this rule:
+
+```js
+describe('', () => {});
+describe('foo', () => {
+  it('', () => {});
+});
+it('', () => {});
+test('', () => {});
+xdescribe('', () => {});
+xit('', () => {});
+xtest('', () => {});
+```
+
+Examples of **correct** code for this rule:
+
+```js
+describe('foo', () => {});
+describe('foo', () => {
+  it('bar', () => {});
+});
+test('foo', () => {});
+it('foo', () => {});
+xdescribe('foo', () => {});
+xit('foo', () => {});
+xtest('foo', () => {});
+```
+
+**titleMustBeString**
+
+Titles for test blocks should always be a string literal or expression.
+
+This is also applied to describe blocks by default, but can be turned off via
+the `ignoreTypeOfDescribeName` option:
+
+Examples of **incorrect** code for this rule:
+
+```js
+it(123, () => {});
+describe(String(/.+/), () => {});
+describe(myFunction, () => {});
+xdescribe(myFunction, () => {});
+describe(6, function() {});
+```
+
+Examples of **correct** code for this rule:
+
+```js
+it('is a string', () => {});
+test('is a string', () => {});
+xtest('is a string', () => {});
+describe('is a string', () => {});
+describe.skip('is a string', () => {});
+fdescribe('is a string', () => {});
+```
+
+Examples of **correct** code when `ignoreTypeOfDescribeName` is `true`:
+
+```js
+it('is a string', () => {});
+test('is a string', () => {});
+xtest('is a string', () => {});
+describe('is a string', () => {});
+describe.skip('is a string', () => {});
+fdescribe('is a string', () => {});
+
+describe(String(/.+/), () => {});
+describe(myFunction, () => {});
+xdescribe(myFunction, () => {});
+describe(6, function() {});
+```
+
 **duplicatePrefix**
 
 A describe/ test block should not start with duplicatePrefix

package/lib/__tests__/__snapshots__/rules.test.ts.snap

@@ -0,0 +1,94 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`rules should export configs that refer to actual rules 1`] = `
+Object {
+  "all": Object {
+    "env": Object {
+      "jest/globals": true,
+    },
+    "plugins": Array [
+      "jest",
+    ],
+    "rules": Object {
+      "jest/consistent-test-it": "error",
+      "jest/expect-expect": "error",
+      "jest/lowercase-name": "error",
+      "jest/no-alias-methods": "error",
+      "jest/no-commented-out-tests": "error",
+      "jest/no-disabled-tests": "error",
+      "jest/no-duplicate-hooks": "error",
+      "jest/no-expect-resolves": "error",
+      "jest/no-export": "error",
+      "jest/no-focused-tests": "error",
+      "jest/no-hooks": "error",
+      "jest/no-identical-title": "error",
+      "jest/no-if": "error",
+      "jest/no-jasmine-globals": "error",
+      "jest/no-jest-import": "error",
+      "jest/no-large-snapshots": "error",
+      "jest/no-mocks-import": "error",
+      "jest/no-standalone-expect": "error",
+      "jest/no-test-callback": "error",
+      "jest/no-test-prefixes": "error",
+      "jest/no-test-return-statement": "error",
+      "jest/no-truthy-falsy": "error",
+      "jest/no-try-expect": "error",
+      "jest/prefer-called-with": "error",
+      "jest/prefer-expect-assertions": "error",
+      "jest/prefer-hooks-on-top": "error",
+      "jest/prefer-inline-snapshots": "error",
+      "jest/prefer-spy-on": "error",
+      "jest/prefer-strict-equal": "error",
+      "jest/prefer-to-be-null": "error",
+      "jest/prefer-to-be-undefined": "error",
+      "jest/prefer-to-contain": "error",
+      "jest/prefer-to-have-length": "error",
+      "jest/prefer-todo": "error",
+      "jest/require-to-throw-message": "error",
+      "jest/require-top-level-describe": "error",
+      "jest/valid-describe": "error",
+      "jest/valid-expect": "error",
+      "jest/valid-expect-in-promise": "error",
+      "jest/valid-title": "error",
+    },
+  },
+  "recommended": Object {
+    "env": Object {
+      "jest/globals": true,
+    },
+    "plugins": Array [
+      "jest",
+    ],
+    "rules": Object {
+      "jest/expect-expect": "warn",
+      "jest/no-commented-out-tests": "warn",
+      "jest/no-disabled-tests": "warn",
+      "jest/no-export": "error",
+      "jest/no-focused-tests": "error",
+      "jest/no-identical-title": "error",
+      "jest/no-jasmine-globals": "warn",
+      "jest/no-jest-import": "error",
+      "jest/no-mocks-import": "error",
+      "jest/no-standalone-expect": "error",
+      "jest/no-test-callback": "error",
+      "jest/no-test-prefixes": "error",
+      "jest/no-try-expect": "error",
+      "jest/valid-describe": "error",
+      "jest/valid-expect": "error",
+      "jest/valid-expect-in-promise": "error",
+    },
+  },
+  "style": Object {
+    "plugins": Array [
+      "jest",
+    ],
+    "rules": Object {
+      "jest/no-alias-methods": "warn",
+      "jest/prefer-to-be-null": "error",
+      "jest/prefer-to-be-undefined": "error",
+      "jest/prefer-to-contain": "error",
+      "jest/prefer-to-have-length": "error",
+    },
+  },
+}
+`;

package/lib/__tests__/rules.test.js

@@ -9,7 +9,7 @@ var _ = _interopRequireDefault(require("../"));
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
 const ruleNames = Object.keys(_.default.rules);
-const numberOfRules = 41;
+const numberOfRules = 40;
 describe('rules', () => {
   it('should have a corresponding doc for each rule', () => {
     ruleNames.forEach(rule => {
@@ -21,10 +21,27 @@ describe('rules', () => {
     });
   });
   it('should have the correct amount of rules', () => {
-    const length = ruleNames.length;
+    const {
+      length
+    } = ruleNames;
 
     if (length !== numberOfRules) {
       throw new Error(`There should be exactly ${numberOfRules} rules, but there are ${length}. If you've added a new rule, please update this number.`);
     }
   });
+  it('should export configs that refer to actual rules', () => {
+    const recommendedConfigs = _.default.configs;
+    expect(recommendedConfigs).toMatchSnapshot();
+    expect(Object.keys(recommendedConfigs)).toEqual(['all', 'recommended', 'style']);
+    expect(Object.keys(recommendedConfigs.all.rules)).toHaveLength(ruleNames.length);
+    const allConfigRules = Object.values(recommendedConfigs).map(config => Object.keys(config.rules)).reduce((previousValue, currentValue) => [...previousValue, ...currentValue]);
+    allConfigRules.forEach(rule => {
+      const ruleNamePrefix = 'jest/';
+      const ruleName = rule.slice(ruleNamePrefix.length);
+      expect(rule.startsWith(ruleNamePrefix)).toBe(true);
+      expect(ruleNames).toContain(ruleName); // eslint-disable-next-line @typescript-eslint/no-require-imports
+
+      expect(() => require(`../rules/${ruleName}`)).not.toThrow();
+    });
+  });
 });

package/lib/index.js

@@ -8,7 +8,7 @@ var _globals = _interopRequireDefault(require("./globals.json"));
 
 var snapshotProcessor = _interopRequireWildcard(require("./processors/snapshot-processor"));
 
-function _getRequireWildcardCache() { if (typeof WeakMap !== "function") return null; var cache = new WeakMap(); _getRequireWildcardCache = function _getRequireWildcardCache() { return cache; }; return cache; }
+function _getRequireWildcardCache() { if (typeof WeakMap !== "function") return null; var cache = new WeakMap(); _getRequireWildcardCache = function () { return cache; }; return cache; }
 
 function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } var cache = _getRequireWildcardCache(); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; if (obj != null) { var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
 
@@ -53,14 +53,19 @@ module.exports = {
         'jest/globals': true
       },
       rules: {
-        'jest/no-alias-methods': 'warn',
+        'jest/expect-expect': 'warn',
+        'jest/no-commented-out-tests': 'warn',
         'jest/no-disabled-tests': 'warn',
+        'jest/no-export': 'error',
         'jest/no-focused-tests': 'error',
         'jest/no-identical-title': 'error',
         'jest/no-jest-import': 'error',
-        // 'jest/no-mocks-import': 'error',
+        'jest/no-mocks-import': 'error',
         'jest/no-jasmine-globals': 'warn',
+        'jest/no-standalone-expect': 'error',
+        'jest/no-test-callback': 'error',
         'jest/no-test-prefixes': 'error',
+        'jest/no-try-expect': 'error',
         'jest/valid-describe': 'error',
         'jest/valid-expect': 'error',
         'jest/valid-expect-in-promise': 'error'
@@ -69,6 +74,7 @@ module.exports = {
     style: {
       plugins: ['jest'],
       rules: {
+        'jest/no-alias-methods': 'warn',
         'jest/prefer-to-be-null': 'error',
         'jest/prefer-to-be-undefined': 'error',
         'jest/prefer-to-contain': 'error',

package/lib/rules/expect-expect.js

@@ -54,32 +54,12 @@ var _default = (0, _utils.createRule)({
           unchecked.push(node);
         } else if (name && assertFunctionNames.includes(name)) {
           // Return early in case of nested `it` statements.
-          var _iteratorNormalCompletion = true;
-          var _didIteratorError = false;
-          var _iteratorError = undefined;
+          for (const ancestor of context.getAncestors()) {
+            const index = ancestor.type === _experimentalUtils.AST_NODE_TYPES.CallExpression ? unchecked.indexOf(ancestor) : -1;
 
-          try {
-            for (var _iterator = context.getAncestors()[Symbol.iterator](), _step; !(_iteratorNormalCompletion = (_step = _iterator.next()).done); _iteratorNormalCompletion = true) {
-              const ancestor = _step.value;
-              const index = ancestor.type === _experimentalUtils.AST_NODE_TYPES.CallExpression ? unchecked.indexOf(ancestor) : -1;
-
-              if (index !== -1) {
-                unchecked.splice(index, 1);
-                break;
-              }
-            }
-          } catch (err) {
-            _didIteratorError = true;
-            _iteratorError = err;
-          } finally {
-            try {
-              if (!_iteratorNormalCompletion && _iterator.return != null) {
-                _iterator.return();
-              }
-            } finally {
-              if (_didIteratorError) {
-                throw _iteratorError;
-              }
+            if (index !== -1) {
+              unchecked.splice(index, 1);
+              break;
             }
           }
         }

package/lib/rules/lowercase-name.js

@@ -9,21 +9,15 @@ var _experimentalUtils = require("@typescript-eslint/experimental-utils");
 
 var _utils = require("./utils");
 
-function _slicedToArray(arr, i) { return _arrayWithHoles(arr) || _iterableToArrayLimit(arr, i) || _nonIterableRest(); }
-
-function _nonIterableRest() { throw new TypeError("Invalid attempt to destructure non-iterable instance"); }
-
-function _iterableToArrayLimit(arr, i) { if (!(Symbol.iterator in Object(arr) || Object.prototype.toString.call(arr) === "[object Arguments]")) { return; } var _arr = []; var _n = true; var _d = false; var _e = undefined; try { for (var _i = arr[Symbol.iterator](), _s; !(_n = (_s = _i.next()).done); _n = true) { _arr.push(_s.value); if (i && _arr.length === i) break; } } catch (err) { _d = true; _e = err; } finally { try { if (!_n && _i["return"] != null) _i["return"](); } finally { if (_d) throw _e; } } return _arr; }
-
-function _arrayWithHoles(arr) { if (Array.isArray(arr)) return arr; }
-
 const hasStringAsFirstArgument = node => node.arguments && node.arguments[0] && (node.arguments[0].type === _experimentalUtils.AST_NODE_TYPES.Literal || node.arguments[0].type === _experimentalUtils.AST_NODE_TYPES.TemplateLiteral);
 
 const isJestFunctionWithLiteralArg = node => ((0, _utils.isTestCase)(node) || (0, _utils.isDescribe)(node)) && node.callee.type === _experimentalUtils.AST_NODE_TYPES.Identifier && hasStringAsFirstArgument(node);
 
 const testDescription = argument => {
   if (argument.type === _experimentalUtils.AST_NODE_TYPES.Literal) {
-    const value = argument.value;
+    const {
+      value
+    } = argument;
 
     if (typeof value === 'string') {
       return value;
@@ -115,9 +109,7 @@ var _default = (0, _utils.createRule)({
             node,
 
             fix(fixer) {
-              const _node$arguments = _slicedToArray(node.arguments, 1),
-                    firstArg = _node$arguments[0]; // guaranteed by jestFunctionName
-
+              const [firstArg] = node.arguments; // guaranteed by jestFunctionName
 
               const description = testDescription(firstArg);
               const rangeIgnoringQuotes = [firstArg.range[0] + 1, firstArg.range[1] - 1];

package/lib/rules/no-alias-methods.js

@@ -35,8 +35,9 @@ var _default = (0, _utils.createRule)({
           return;
         }
 
-        const _parseExpectCall = (0, _utils.parseExpectCall)(node),
-              matcher = _parseExpectCall.matcher;
+        const {
+          matcher
+        } = (0, _utils.parseExpectCall)(node);
 
         if (!matcher) {
           return;

package/lib/rules/no-export.js

@@ -31,31 +31,11 @@ var _default = (0, _utils.createRule)({
     return {
       'Program:exit'() {
         if (hasTestCase && exportNodes.length > 0) {
-          var _iteratorNormalCompletion = true;
-          var _didIteratorError = false;
-          var _iteratorError = undefined;
-
-          try {
-            for (var _iterator = exportNodes[Symbol.iterator](), _step; !(_iteratorNormalCompletion = (_step = _iterator.next()).done); _iteratorNormalCompletion = true) {
-              const node = _step.value;
-              context.report({
-                node,
-                messageId: 'unexpectedExport'
-              });
-            }
-          } catch (err) {
-            _didIteratorError = true;
-            _iteratorError = err;
-          } finally {
-            try {
-              if (!_iteratorNormalCompletion && _iterator.return != null) {
-                _iterator.return();
-              }
-            } finally {
-              if (_didIteratorError) {
-                throw _iteratorError;
-              }
-            }
+          for (const node of exportNodes) {
+            context.report({
+              node,
+              messageId: 'unexpectedExport'
+            });
           }
         }
       },
@@ -71,13 +51,16 @@ var _default = (0, _utils.createRule)({
       },
 
       'AssignmentExpression > MemberExpression'(node) {
-        let object = node.object,
-            property = node.property;
+        let {
+          object,
+          property
+        } = node;
 
         if (object.type === _experimentalUtils.AST_NODE_TYPES.MemberExpression) {
-          var _object = object;
-          object = _object.object;
-          property = _object.property;
+          ({
+            object,
+            property
+          } = object);
         }
 
         if ('name' in object && object.name === 'module' && property.type === _experimentalUtils.AST_NODE_TYPES.Identifier && /^exports?$/.test(property.name)) {

package/lib/rules/no-focused-tests.js

@@ -37,7 +37,9 @@ var _default = (0, _utils.createRule)({
   defaultOptions: [],
   create: context => ({
     CallExpression(node) {
-      const callee = node.callee;
+      const {
+        callee
+      } = node;
 
       if (callee.type === _experimentalUtils.AST_NODE_TYPES.MemberExpression) {
         if (callee.object.type === _experimentalUtils.AST_NODE_TYPES.Identifier && isCallToFocusedTestFunction(callee.object)) {

package/lib/rules/no-identical-title.js

@@ -7,14 +7,6 @@ exports.default = void 0;
 
 var _utils = require("./utils");
 
-function _slicedToArray(arr, i) { return _arrayWithHoles(arr) || _iterableToArrayLimit(arr, i) || _nonIterableRest(); }
-
-function _nonIterableRest() { throw new TypeError("Invalid attempt to destructure non-iterable instance"); }
-
-function _iterableToArrayLimit(arr, i) { if (!(Symbol.iterator in Object(arr) || Object.prototype.toString.call(arr) === "[object Arguments]")) { return; } var _arr = []; var _n = true; var _d = false; var _e = undefined; try { for (var _i = arr[Symbol.iterator](), _s; !(_n = (_s = _i.next()).done); _n = true) { _arr.push(_s.value); if (i && _arr.length === i) break; } } catch (err) { _d = true; _e = err; } finally { try { if (!_n && _i["return"] != null) _i["return"](); } finally { if (_d) throw _e; } } return _arr; }
-
-function _arrayWithHoles(arr) { if (Array.isArray(arr)) return arr; }
-
 const newDescribeContext = () => ({
   describeTitles: [],
   testTitles: []
@@ -47,8 +39,7 @@ var _default = (0, _utils.createRule)({
           contexts.push(newDescribeContext());
         }
 
-        const _node$arguments = _slicedToArray(node.arguments, 1),
-              argument = _node$arguments[0];
+        const [argument] = node.arguments;
 
         if (!argument || !(0, _utils.isStringNode)(argument)) {
           return;

package/lib/rules/no-jasmine-globals.js

@@ -33,7 +33,9 @@ var _default = (0, _utils.createRule)({
   create(context) {
     return {
       CallExpression(node) {
-        const callee = node.callee;
+        const {
+          callee
+        } = node;
         const calleeName = (0, _utils.getNodeName)(callee);
 
         if (!calleeName) {
@@ -126,12 +128,16 @@ var _default = (0, _utils.createRule)({
 
       MemberExpression(node) {
         if ('name' in node.object && node.object.name === 'jasmine') {
-          const parent = node.parent,
-                property = node.property;
+          const {
+            parent,
+            property
+          } = node;
 
           if (parent && parent.type === _experimentalUtils.AST_NODE_TYPES.AssignmentExpression) {
             if ('name' in property && property.name === 'DEFAULT_TIMEOUT_INTERVAL') {
-              const right = parent.right;
+              const {
+                right
+              } = parent;
 
               if (right.type === _experimentalUtils.AST_NODE_TYPES.Literal) {
                 context.report({

package/lib/rules/no-mocks-import.js

@@ -9,14 +9,6 @@ var _path = require("path");
 
 var _utils = require("./utils");
 
-function _slicedToArray(arr, i) { return _arrayWithHoles(arr) || _iterableToArrayLimit(arr, i) || _nonIterableRest(); }
-
-function _nonIterableRest() { throw new TypeError("Invalid attempt to destructure non-iterable instance"); }
-
-function _iterableToArrayLimit(arr, i) { if (!(Symbol.iterator in Object(arr) || Object.prototype.toString.call(arr) === "[object Arguments]")) { return; } var _arr = []; var _n = true; var _d = false; var _e = undefined; try { for (var _i = arr[Symbol.iterator](), _s; !(_n = (_s = _i.next()).done); _n = true) { _arr.push(_s.value); if (i && _arr.length === i) break; } } catch (err) { _d = true; _e = err; } finally { try { if (!_n && _i["return"] != null) _i["return"](); } finally { if (_d) throw _e; } } return _arr; }
-
-function _arrayWithHoles(arr) { if (Array.isArray(arr)) return arr; }
-
 const mocksDirName = '__mocks__';
 
 const isMockPath = path => path.split(_path.posix.sep).includes(mocksDirName);
@@ -51,8 +43,7 @@ var _default = (0, _utils.createRule)({
       },
 
       'CallExpression[callee.name="require"]'(node) {
-        const _node$arguments = _slicedToArray(node.arguments, 1),
-              arg = _node$arguments[0];
+        const [arg] = node.arguments;
 
         if (arg && isMockImportLiteral(arg)) {
           context.report({