ember-source 4.3.0-alpha.2 → 4.4.0-alpha.1

package/dist/header/license.js

@@ -5,5 +5,5 @@
  *            Portions Copyright 2008-2011 Apple Inc. All rights reserved.
  * @license   Licensed under MIT license
  *            See https://raw.github.com/emberjs/ember.js/master/LICENSE
- * @version   4.3.0-alpha.2
+ * @version   4.4.0-alpha.1
  */

package/dist/packages/@ember/-internals/container/index.js

@@ -18,6 +18,7 @@ if (DEBUG) {
         containers = new WeakSet();
         return {
           hasContainers() {
+            // @ts-expect-error We just checked if it is definied
             gc();
             return GetWeakSetValues(containers).length > 0;
           },
@@ -123,7 +124,7 @@ class Container {
 
   lookup(fullName, options) {
     if (this.isDestroyed) {
-      throw new Error(`Can not call \`.lookup\` after the owner has been destroyed`);
+      throw new Error(`Cannot call \`.lookup\` after the owner has been destroyed`);
     }
 
     assert('fullName must be a proper full name', this.registry.isValidFullName(fullName));
@@ -194,7 +195,7 @@ class Container {
 
   factoryFor(fullName) {
     if (this.isDestroyed) {
-      throw new Error(`Can not call \`.factoryFor\` after the owner has been destroyed`);
+      throw new Error(`Cannot call \`.factoryFor\` after the owner has been destroyed`);
     }
 
     let normalizedName = this.registry.normalize(fullName);
@@ -351,9 +352,9 @@ function destroyDestroyables(container) {
   let cache = container.cache;
   let keys = Object.keys(cache);
 
-  for (let i = 0; i < keys.length; i++) {
-    let key = keys[i];
+  for (let key of keys) {
     let value = cache[key];
+    assert('has cached value', value);
 
     if (value.destroy) {
       value.destroy();
@@ -386,7 +387,6 @@ function getFactoryFor(obj) {
 function setFactoryFor(obj, factory) {
   obj[INIT_FACTORY] = factory;
 }
-
 class FactoryManager {
   constructor(container, factory, fullName, normalizedName) {
     this.container = container;
@@ -417,7 +417,7 @@ class FactoryManager {
     } = this;
 
     if (container.isDestroyed) {
-      throw new Error(`Can not create new instances after the owner has been destroyed (you attempted to create ${this.fullName})`);
+      throw new Error(`Cannot create new instances after the owner has been destroyed (you attempted to create ${this.fullName})`);
     }
 
     let props = {};
@@ -781,6 +781,8 @@ class Registry {
     }
 
     let type = fullName.split(':')[0];
+    assert('has type', type); // split always will have at least one value
+
     options = this._typeOptions[type];
 
     if (options && options[optionName] !== undefined) {
@@ -827,8 +829,7 @@ class Registry {
     let localKnown = dictionary(null);
     let registeredNames = Object.keys(this.registrations);
 
-    for (let index = 0; index < registeredNames.length; index++) {
-      let fullName = registeredNames[index];
+    for (let fullName of registeredNames) {
       let itemType = fullName.split(':')[0];
 
       if (itemType === type) {
@@ -863,9 +864,11 @@ if (DEBUG) {
 
     for (let key in hash) {
       if (Object.prototype.hasOwnProperty.call(hash, key)) {
+        let value = hash[key];
+        assert('has value', value);
         let {
           specifier
-        } = hash[key];
+        } = value;
         assert(`Expected a proper full name, given '${specifier}'`, this.isValidFullName(specifier));
         injections.push({
           property: key,
@@ -882,10 +885,10 @@ if (DEBUG) {
       return;
     }
 
-    for (let i = 0; i < injections.length; i++) {
+    for (let injection of injections) {
       let {
         specifier
-      } = injections[i];
+      } = injection;
       assert(`Attempting to inject an unknown injection: '${specifier}'`, this.has(specifier));
     }
   };
@@ -929,6 +932,7 @@ function has(registry, fullName) {
 const privateNames = dictionary(null);
 const privateSuffix = `${Math.random()}${Date.now()}`.replace('.', '');
 function privatize([fullName]) {
+  assert('has a single string argument', arguments.length === 1 && fullName);
   let name = privateNames[fullName];
 
   if (name) {

package/dist/packages/@ember/-internals/extension-support/lib/container_debug_adapter.js

@@ -51,7 +51,7 @@ export default EmberObject.extend({
     The resolver instance of the application
     being debugged. This property will be injected
     on creation.
-     @property resolver
+       @property resolver
     @default null
     @public
   */
@@ -60,7 +60,7 @@ export default EmberObject.extend({
   /**
     Returns true if it is possible to catalog a list of available
     classes in the resolver for a given type.
-     @method canCatalogEntriesByType
+       @method canCatalogEntriesByType
     @param {String} type The type. e.g. "model", "controller", "route".
     @return {boolean} whether a list is available for this type.
     @public
@@ -75,7 +75,7 @@ export default EmberObject.extend({
 
   /**
     Returns the available classes a given type.
-     @method catalogEntriesByType
+       @method catalogEntriesByType
     @param {String} type The type. e.g. "model", "controller", "route".
     @return {Array} An array of strings.
     @public

package/dist/packages/@ember/-internals/extension-support/lib/data_adapter.js

@@ -16,25 +16,6 @@ function iterate(arr, fn) {
 }
 
 class RecordsWatcher {
-  getCacheForItem(record) {
-    let recordCache = this.recordCaches.get(record);
-
-    if (!recordCache) {
-      let hasBeenAdded = false;
-      recordCache = createCache(() => {
-        if (!hasBeenAdded) {
-          this.added.push(this.wrapRecord(record));
-          hasBeenAdded = true;
-        } else {
-          this.updated.push(this.wrapRecord(record));
-        }
-      });
-      this.recordCaches.set(record, recordCache);
-    }
-
-    return recordCache;
-  }
-
   constructor(records, recordsAdded, recordsUpdated, recordsRemoved, wrapRecord, release) {
     this.recordCaches = new Map();
     this.added = [];
@@ -78,6 +59,25 @@ class RecordsWatcher {
     });
   }
 
+  getCacheForItem(record) {
+    let recordCache = this.recordCaches.get(record);
+
+    if (!recordCache) {
+      let hasBeenAdded = false;
+      recordCache = createCache(() => {
+        if (!hasBeenAdded) {
+          this.added.push(this.wrapRecord(record));
+          hasBeenAdded = true;
+        } else {
+          this.updated.push(this.wrapRecord(record));
+        }
+      });
+      this.recordCaches.set(record, recordCache);
+    }
+
+    return recordCache;
+  }
+
   revalidate() {
     getValue(this.recordArrayCache);
   }
@@ -168,7 +168,7 @@ export default EmberObject.extend({
   /**
     The container-debug-adapter which is used
     to list all models.
-     @property containerDebugAdapter
+       @property containerDebugAdapter
     @default undefined
     @since 1.5.0
     @public
@@ -178,7 +178,7 @@ export default EmberObject.extend({
     The number of attributes to send
     as columns. (Enough to make the record
     identifiable).
-     @private
+       @private
     @property attributeLimit
     @default 3
     @since 1.3.0
@@ -189,24 +189,24 @@ export default EmberObject.extend({
      Ember Data > v1.0.0-beta.18
      requires string model names to be passed
      around instead of the actual factories.
-      This is a stamp for the Ember Inspector
+        This is a stamp for the Ember Inspector
      to differentiate between the versions
      to be able to support older versions too.
-      @public
+        @public
      @property acceptsModelName
    */
   acceptsModelName: true,
 
   /**
      Map from records arrays to RecordsWatcher instances
-      @private
+        @private
      @property recordsWatchers
      @since 3.26.0
    */
 
   /**
     Map from records arrays to TypeWatcher instances
-     @private
+       @private
     @property typeWatchers
     @since 3.26.0
    */
@@ -214,15 +214,15 @@ export default EmberObject.extend({
   /**
     Callback that is currently scheduled on backburner end to flush and check
     all active watchers.
-     @private
+       @private
     @property flushWatchers
     @since 3.26.0
-    */
+      */
 
   /**
     Stores all methods that clear observers.
     These methods will be called on destruction.
-     @private
+       @private
     @property releaseMethods
     @since 1.3.0
   */
@@ -231,7 +231,7 @@ export default EmberObject.extend({
     Specifies how records can be filtered.
     Records returned will need to have a `filterValues`
     property with a key for every name in the returned array.
-     @public
+       @public
     @method getFilters
     @return {Array} List of objects defining filters.
      The object should have a `name` and `desc` property.
@@ -242,13 +242,13 @@ export default EmberObject.extend({
 
   /**
     Fetch the model types and observe them for changes.
-     @public
+       @public
     @method watchModelTypes
-     @param {Function} typesAdded Callback to call to add types.
+       @param {Function} typesAdded Callback to call to add types.
     Takes an array of objects containing wrapped types (returned from `wrapModelType`).
-     @param {Function} typesUpdated Callback to call when a type has changed.
+       @param {Function} typesUpdated Callback to call when a type has changed.
     Takes an array of objects containing wrapped types.
-     @return {Function} Method to call to remove all observers
+       @return {Function} Method to call to remove all observers
   */
   watchModelTypes(typesAdded, typesUpdated) {
     let modelTypes = this.getModelTypes();
@@ -283,19 +283,19 @@ export default EmberObject.extend({
 
   /**
     Fetch the records of a given type and observe them for changes.
-     @public
+       @public
     @method watchRecords
-     @param {String} modelName The model name.
-     @param {Function} recordsAdded Callback to call to add records.
+       @param {String} modelName The model name.
+       @param {Function} recordsAdded Callback to call to add records.
     Takes an array of objects containing wrapped records.
     The object should have the following properties:
       columnValues: {Object} The key and value of a table cell.
       object: {Object} The actual record object.
-     @param {Function} recordsUpdated Callback to call when a record has changed.
+       @param {Function} recordsUpdated Callback to call when a record has changed.
     Takes an array of objects containing wrapped records.
-     @param {Function} recordsRemoved Callback to call when a record has removed.
+       @param {Function} recordsRemoved Callback to call when a record has removed.
     Takes an array of objects containing wrapped records.
-     @return {Function} Method to call to remove all observers.
+       @return {Function} Method to call to remove all observers.
   */
   watchRecords(modelName, recordsAdded, recordsUpdated, recordsRemoved) {
     let klass = this._nameToClass(modelName);
@@ -355,9 +355,9 @@ export default EmberObject.extend({
 
   /**
     Detect whether a class is a model.
-     Test that against the model class
+       Test that against the model class
     of your persistence library.
-     @public
+       @public
     @method detect
     @return boolean Whether the class is a model class or not.
   */
@@ -367,7 +367,7 @@ export default EmberObject.extend({
 
   /**
     Get the columns for a given model type.
-     @public
+       @public
     @method columnsForType
     @return {Array} An array of columns of the following format:
      name: {String} The name of the column.
@@ -379,7 +379,7 @@ export default EmberObject.extend({
 
   /**
     Adds observers to a model type class.
-     @private
+       @private
     @method observeModelType
     @param {String} modelName The model type name.
     @param {Function} typesUpdated Called when a type is modified.
@@ -414,7 +414,7 @@ export default EmberObject.extend({
 
   /**
     Wraps a given model type and observes changes to it.
-     @private
+       @private
     @method wrapModelType
     @param {Class} klass A model class.
     @param {String} modelName Name of the class.
@@ -442,7 +442,7 @@ export default EmberObject.extend({
 
   /**
     Fetches all models defined in the application.
-     @private
+       @private
     @method getModelTypes
     @return {Array} Array of model types.
   */
@@ -470,7 +470,7 @@ export default EmberObject.extend({
   /**
     Loops over all namespaces and all objects
     attached to them.
-     @private
+       @private
     @method _getObjectsOnNamespaces
     @return {Array} Array of model type strings.
   */
@@ -498,7 +498,7 @@ export default EmberObject.extend({
 
   /**
     Fetches all loaded records for a given type.
-     @public
+       @public
     @method getRecords
     @return {Array} An array of records.
      This array will be observed for changes,
@@ -510,7 +510,7 @@ export default EmberObject.extend({
 
   /**
     Wraps a record and observers changes to it.
-     @private
+       @private
     @method wrapRecord
     @param {Object} record The record instance.
     @return {Object} The wrapped record. Format:
@@ -530,7 +530,7 @@ export default EmberObject.extend({
 
   /**
     Gets the values for each column.
-     @public
+       @public
     @method getRecordColumnValues
     @return {Object} Keys should match column names defined
     by the model type.
@@ -541,7 +541,7 @@ export default EmberObject.extend({
 
   /**
     Returns keywords to match when searching records.
-     @public
+       @public
     @method getRecordKeywords
     @return {Array} Relevant keywords for search.
   */
@@ -551,7 +551,7 @@ export default EmberObject.extend({
 
   /**
     Returns the values of filters defined by `getFilters`.
-     @public
+       @public
     @method getRecordFilterValues
     @param {Object} record The record instance.
     @return {Object} The filter values.
@@ -562,7 +562,7 @@ export default EmberObject.extend({
 
   /**
     Each record can have a color that represents its state.
-     @public
+       @public
     @method getRecordColor
     @param {Object} record The record instance
     @return {String} The records color.