ember-source 4.3.0-alpha.2 → 4.4.0-alpha.1

package/dist/packages/@ember/-internals/metal/index.js

@@ -685,8 +685,7 @@ function finishLazyChains(meta$$1, key, value) {
   }
 
   if (isObject(value)) {
-    for (let i = 0; i < lazyTags.length; i++) {
-      let [tag, deps] = lazyTags[i];
+    for (let [tag, deps] of lazyTags) {
       updateTag(tag, getChainTagsForKey(value, deps, tagMetaFor(value), peekMeta(value)));
     }
   }
@@ -696,8 +695,8 @@ function finishLazyChains(meta$$1, key, value) {
 function getChainTagsForKeys(obj, keys, tagMeta, meta$$1) {
   let tags = [];
 
-  for (let i = 0; i < keys.length; i++) {
-    getChainTags(tags, obj, keys[i], tagMeta, meta$$1);
+  for (let key of keys) {
+    getChainTags(tags, obj, key, tagMeta, meta$$1);
   }
 
   return combine(tags);
@@ -1313,8 +1312,8 @@ class ComputedProperty extends ComputedDescriptor {
       args.push(property);
     }
 
-    for (let i = 0; i < passedArgs.length; i++) {
-      expandProperties(passedArgs[i], addArg);
+    for (let arg of passedArgs) {
+      expandProperties(arg, addArg);
     }
 
     this._dependentKeys = args;
@@ -1603,13 +1602,16 @@ function computed(...args) {
   assert(`@computed can only be used directly as a native decorator. If you're using tracked in classic classes, add parenthesis to call it like a function: computed()`, !(isElementDescriptor(args.slice(0, 3)) && args.length === 5 && args[4] === true));
 
   if (isElementDescriptor(args)) {
+    // SAFETY: We passed in the impl for this class
     let decorator = makeComputedDecorator(new ComputedProperty([]), ComputedDecoratorImpl);
     return decorator(args[0], args[1], args[2]);
-  }
+  } // SAFETY: We passed in the impl for this class
+
 
   return makeComputedDecorator(new ComputedProperty(args), ComputedDecoratorImpl);
 }
 function autoComputed(...config) {
+  // SAFETY: We passed in the impl for this class
   return makeComputedDecorator(new AutoComputedProperty(config), ComputedDecoratorImpl);
 }
 /**
@@ -1816,12 +1818,12 @@ function _getPath(root, path) {
   let obj = root;
   let parts = typeof path === 'string' ? path.split('.') : path;
 
-  for (let i = 0; i < parts.length; i++) {
+  for (let part of parts) {
     if (obj === undefined || obj === null || obj.isDestroyed) {
       return undefined;
     }
 
-    obj = _getProp(obj, parts[i]);
+    obj = _getProp(obj, part);
   }
 
   return obj;
@@ -1973,7 +1975,8 @@ function trySet(root, path, value) {
 }
 
 function alias(altKey) {
-  assert('You attempted to use @alias as a decorator directly, but it requires a `altKey` parameter', !isElementDescriptor(Array.prototype.slice.call(arguments)));
+  assert('You attempted to use @alias as a decorator directly, but it requires a `altKey` parameter', !isElementDescriptor(Array.prototype.slice.call(arguments))); // SAFETY: We passed in the impl for this class
+
   return makeComputedDecorator(new AliasedProperty(altKey), AliasDecoratorImpl);
 } // TODO: This class can be svelted once `meta` has been deprecated
 
@@ -2312,11 +2315,10 @@ class Libraries {
 
   _getLibraryByName(name) {
     let libs = this._registry;
-    let count = libs.length;
 
-    for (let i = 0; i < count; i++) {
-      if (libs[i].name === name) {
-        return libs[i];
+    for (let lib of libs) {
+      if (lib.name === name) {
+        return lib;
       }
     }
 
@@ -2368,8 +2370,7 @@ if (DEBUG) {
     let maxNameLength = Math.max.apply(null, nameLengths);
     debug('-------------------------------');
 
-    for (let i = 0; i < libs.length; i++) {
-      let lib = libs[i];
+    for (let lib of libs) {
       let spaces = new Array(maxNameLength - lib.name.length + 1).join(' ');
       debug([lib.name, spaces, ' : ', lib.version].join(''));
     }
@@ -2434,10 +2435,8 @@ function setProperties(obj, properties) {
 
   changeProperties(() => {
     let props = Object.keys(properties);
-    let propertyName;
 
-    for (let i = 0; i < props.length; i++) {
-      propertyName = props[i];
+    for (let propertyName of props) {
       set(obj, propertyName, properties[propertyName]);
     }
   });
@@ -2484,9 +2483,8 @@ function findNamespaces() {
   let lookup = context.lookup;
   let keys = Object.keys(lookup);
 
-  for (let i = 0; i < keys.length; i++) {
-    let key = keys[i]; // Only process entities that start with uppercase A-Z
-
+  for (let key of keys) {
+    // Only process entities that start with uppercase A-Z
     if (!isUppercase(key.charCodeAt(0))) {
       continue;
     }
@@ -2519,8 +2517,8 @@ function processAllNamespaces() {
   if (unprocessedNamespaces || unprocessedMixins) {
     let namespaces = NAMESPACES;
 
-    for (let i = 0; i < namespaces.length; i++) {
-      processNamespace(namespaces[i]);
+    for (let namespace of namespaces) {
+      processNamespace(namespace);
     }
 
     unprocessedMixins = false;
@@ -2596,10 +2594,7 @@ const {
 
 function extractAccessors(properties) {
   if (properties !== undefined) {
-    let keys = Object.keys(properties);
-
-    for (let i = 0; i < keys.length; i++) {
-      let key = keys[i];
+    for (let key of Object.keys(properties)) {
       let desc = Object.getOwnPropertyDescriptor(properties, key);
 
       if (desc.get !== undefined || desc.set !== undefined) {
@@ -2681,7 +2676,8 @@ function giveDecoratorSuper(key, decorator, property, descs) {
     }]);
     newProperty._readOnly = property._readOnly;
     newProperty._meta = property._meta;
-    newProperty.enumerable = property.enumerable;
+    newProperty.enumerable = property.enumerable; // SAFETY: We passed in the impl for this class
+
     return makeComputedDecorator(newProperty, ComputedProperty);
   }
 
@@ -2732,8 +2728,7 @@ function applyMergedProperties(key, value, values) {
   let hasFunction = false;
   let props = Object.keys(value);
 
-  for (let i = 0; i < props.length; i++) {
-    let prop = props[i];
+  for (let prop of props) {
     let propValue = value[prop];
 
     if (typeof propValue === 'function') {
@@ -2796,8 +2791,7 @@ function mergeProps(meta$$1, props, descs, values, base, keys, keysWithSuper) {
   let mergings = concatenatedMixinProperties('mergedProperties', props, values, base);
   let propKeys = Object.keys(props);
 
-  for (let i = 0; i < propKeys.length; i++) {
-    let key = propKeys[i];
+  for (let key of propKeys) {
     let value = props[key];
     if (value === undefined) continue;
 
@@ -2860,16 +2854,16 @@ function updateObserversAndListeners(obj, key, fn, add) {
   if (observers !== undefined) {
     let updateObserver = add ? addObserver : removeObserver;
 
-    for (let i = 0; i < observers.paths.length; i++) {
-      updateObserver(obj, observers.paths[i], null, key, observers.sync);
+    for (let path of observers.paths) {
+      updateObserver(obj, path, null, key, observers.sync);
     }
   }
 
   if (listeners !== undefined) {
     let updateListener = add ? addListener : removeListener;
 
-    for (let i = 0; i < listeners.length; i++) {
-      updateListener(obj, listeners[i], null, key);
+    for (let listener of listeners) {
+      updateListener(obj, listener, null, key);
     }
   }
 }
@@ -2890,8 +2884,7 @@ function applyMixin(obj, mixins, _hideKeys = false) {
 
   mergeMixins(mixins, meta$$1, descs, values, obj, keys, keysWithSuper);
 
-  for (let i = 0; i < keys.length; i++) {
-    let key = keys[i];
+  for (let key of keys) {
     let value = values[key];
     let desc = descs[key];
 
@@ -3288,8 +3281,8 @@ function observer(...args) {
   assert('observer called without sync', typeof sync === 'boolean');
   let paths = [];
 
-  for (let i = 0; i < dependentKeys.length; ++i) {
-    expandProperties(dependentKeys[i], path => paths.push(path));
+  for (let dependentKey of dependentKeys) {
+    expandProperties(dependentKey, path => paths.push(path));
   }
 
   setObservers(func, {
@@ -3307,8 +3300,14 @@ if (DEBUG) {
 
 function inject(type, ...args) {
   assert('a string type must be provided to inject', typeof type === 'string');
-  let calledAsDecorator = isElementDescriptor(args);
-  let name = calledAsDecorator ? undefined : args[0];
+  let elementDescriptor;
+  let name;
+
+  if (isElementDescriptor(args)) {
+    elementDescriptor = args;
+  } else if (typeof args[0] === 'string') {
+    name = args[0];
+  }
 
   let getInjection = function (propertyName) {
     let owner = getOwner(this) || this.container; // fallback to `container` for backwards compat
@@ -3333,8 +3332,8 @@ function inject(type, ...args) {
 
   });
 
-  if (calledAsDecorator) {
-    return decorator(args[0], args[1], args[2]);
+  if (elementDescriptor) {
+    return decorator(elementDescriptor[0], elementDescriptor[1], elementDescriptor[2]);
   } else {
     return decorator;
   }

package/dist/packages/@ember/-internals/routing/lib/ext/controller.js

@@ -131,16 +131,16 @@ ControllerMixin.reopen({
     aController.transitionToRoute({ queryParams: { sort: 'date' } });
     ```
        See also [replaceRoute](/ember/release/classes/Ember.ControllerMixin/methods/replaceRoute?anchor=replaceRoute).
-       @param {String} name the name of the route or a URL
+       @for Ember.ControllerMixin
+    @method transitionToRoute
+    @deprecated Use transitionTo from the Router service instead.
+    @param {String} [name] the name of the route or a URL
     @param {...Object} models the model(s) or identifier(s) to be used
       while transitioning to the route.
     @param {Object} [options] optional hash with a queryParams property
       containing a mapping of query parameters
-    @for Ember.ControllerMixin
-    @method transitionToRoute
     @return {Transition} the transition object associated with this
       attempted transition
-    @deprecated Use transitionTo from the Router service instead.
     @public
   */
   transitionToRoute(...args) {
@@ -195,14 +195,16 @@ ControllerMixin.reopen({
     aController.replaceRoute('/');
     aController.replaceRoute('/blog/post/1/comment/13');
     ```
-       @param {String} name the name of the route or a URL
+       @for Ember.ControllerMixin
+    @method replaceRoute
+    @deprecated Use replaceWith from the Router service instead.
+    @param {String} [name] the name of the route or a URL
     @param {...Object} models the model(s) or identifier(s) to be used
     while transitioning to the route.
-    @for Ember.ControllerMixin
-    @method replaceRoute
+    @param {Object} [options] optional hash with a queryParams property
+    containing a mapping of query parameters
     @return {Transition} the transition object associated with this
       attempted transition
-    @deprecated Use replaceWith from the Router service instead.
     @public
   */
   replaceRoute(...args) {

package/dist/packages/@ember/-internals/routing/lib/location/auto_location.js

@@ -82,7 +82,9 @@ export default class AutoLocation extends EmberObject {
       implementation = 'none';
     }
 
-    let concrete = getOwner(this).lookup(`location:${implementation}`);
+    let owner = getOwner(this);
+    assert('AutoLocation is unexpectedly missing an owner', owner);
+    let concrete = owner.lookup(`location:${implementation}`);
     assert(`Could not find location '${implementation}'.`, concrete !== undefined);
     set(concrete, 'rootURL', rootURL);
     set(this, 'concreteImplementation', concrete);