dual-brain 0.2.30 → 0.3.0

package/src/prompt-audit.mjs

@@ -1,231 +0,0 @@
-import { existsSync, mkdirSync, readFileSync, appendFileSync } from 'node:fs';
-import { join } from 'node:path';
-
-const AUDIT_DIR = join(process.cwd(), '.dualbrain', 'prompt-audit');
-
-/**
- * Score a prompt for quality before sending to a provider.
- * Returns score 0-100 and specific feedback.
- */
-export function scorePrompt(prompt, opts = {}) {
-  const { type = 'think', maxTokenBudget = 2000 } = opts;
-
-  const issues = [];
-  const strengths = [];
-  let score = 100;
-
-  // Length efficiency
-  const words = prompt.split(/\s+/).length;
-  const chars = prompt.length;
-
-  if (words < 20) {
-    issues.push({ rule: 'too-short', msg: 'Prompt under 20 words — likely missing context', penalty: 15 });
-    score -= 15;
-  }
-  if (words > 500) {
-    issues.push({ rule: 'too-long', msg: `Prompt is ${words} words — consider trimming`, penalty: 10 });
-    score -= 10;
-  }
-
-  // Structure checks
-  if (type === 'think') {
-    if (!prompt.includes('?')) {
-      issues.push({ rule: 'no-question', msg: 'Think prompt has no question mark — unclear what decision is needed', penalty: 10 });
-      score -= 10;
-    }
-    if (!/\b(should|how|what|which|why|when|where|recommend|decide|choose|compare|tradeoff)\b/i.test(prompt)) {
-      issues.push({ rule: 'no-decision-language', msg: 'No decision-making language found', penalty: 5 });
-      score -= 5;
-    }
-    if (/\b(at least \d+ ideas|generate.*list|brainstorm)\b/i.test(prompt)) {
-      strengths.push('Requests specific output quantity');
-    }
-  }
-
-  // Context quality
-  if (/\b(this project|the codebase|our system)\b/i.test(prompt) && !/\b(module|file|function|export|import)\b/i.test(prompt)) {
-    issues.push({ rule: 'vague-context', msg: 'References "the project" without naming specific modules/files', penalty: 10 });
-    score -= 10;
-  }
-
-  if (/\b(src\/\w+|\.mjs|\.js|\.ts)\b/.test(prompt)) {
-    strengths.push('Names specific files/modules');
-  }
-
-  // Constraint quality
-  if (/\b(at least|minimum|maximum|no more than|ranked|ordered|prioritized)\b/i.test(prompt)) {
-    strengths.push('Includes output constraints');
-  }
-
-  // Anti-patterns
-  if (/\b(please|could you|would you mind)\b/i.test(prompt)) {
-    issues.push({ rule: 'politeness-waste', msg: 'Politeness tokens wasted on AI — be direct', penalty: 2 });
-    score -= 2;
-  }
-
-  if (/\b(I think|I believe|maybe|perhaps|possibly)\b/i.test(prompt) && type === 'think') {
-    issues.push({ rule: 'hedging', msg: 'Hedging language in think prompt — state positions directly', penalty: 5 });
-    score -= 5;
-  }
-
-  // Token efficiency estimate
-  const estimatedTokens = Math.ceil(chars / 4);
-  const efficiency = Math.min(100, Math.round((words / estimatedTokens) * 100));
-
-  // Duplication check
-  const sentences = prompt.split(/[.!?]+/).filter(s => s.trim().length > 10);
-  const unique = new Set(sentences.map(s => s.trim().toLowerCase()));
-  if (sentences.length > 3 && unique.size < sentences.length * 0.7) {
-    issues.push({ rule: 'repetitive', msg: `${sentences.length - unique.size} near-duplicate sentences`, penalty: 10 });
-    score -= 10;
-  }
-
-  score = Math.max(0, Math.min(100, score));
-
-  return {
-    score,
-    grade: score >= 90 ? 'A' : score >= 80 ? 'B' : score >= 70 ? 'C' : score >= 60 ? 'D' : 'F',
-    issues,
-    strengths,
-    stats: {
-      words,
-      chars,
-      estimatedTokens,
-      efficiency,
-      sentences: sentences.length,
-    },
-  };
-}
-
-/**
- * Log a prompt exchange for auditing.
- */
-export function logPromptExchange(exchange) {
-  const {
-    type = 'think',
-    round = 1,
-    prompt,
-    response,
-    provider = 'gpt',
-    model,
-    durationMs,
-    promptScore,
-  } = exchange;
-
-  mkdirSync(AUDIT_DIR, { recursive: true });
-
-  const entry = {
-    timestamp: new Date().toISOString(),
-    type,
-    round,
-    provider,
-    model,
-    durationMs,
-    promptScore: promptScore?.score,
-    promptGrade: promptScore?.grade,
-    promptWords: promptScore?.stats?.words,
-    promptTokens: promptScore?.stats?.estimatedTokens,
-    responseWords: response ? response.split(/\s+/).length : 0,
-    responseTokens: response ? Math.ceil(response.length / 4) : 0,
-    issues: promptScore?.issues?.map(i => i.rule) || [],
-  };
-
-  const logFile = join(AUDIT_DIR, 'exchanges.jsonl');
-  appendFileSync(logFile, JSON.stringify(entry) + '\n');
-
-  return entry;
-}
-
-/**
- * Get prompt quality statistics over time.
- */
-export function getPromptStats(opts = {}) {
-  const { days = 7 } = opts;
-  const logFile = join(AUDIT_DIR, 'exchanges.jsonl');
-
-  if (!existsSync(logFile)) return { available: false };
-
-  const cutoff = new Date(Date.now() - days * 86400000).toISOString();
-  const lines = readFileSync(logFile, 'utf8').trim().split('\n').filter(Boolean);
-
-  const entries = [];
-  for (const line of lines) {
-    try {
-      const entry = JSON.parse(line);
-      if (entry.timestamp >= cutoff) entries.push(entry);
-    } catch {}
-  }
-
-  if (entries.length === 0) return { available: true, count: 0 };
-
-  const avgScore = entries.reduce((s, e) => s + (e.promptScore || 0), 0) / entries.length;
-  const avgPromptTokens = entries.reduce((s, e) => s + (e.promptTokens || 0), 0) / entries.length;
-  const avgResponseTokens = entries.reduce((s, e) => s + (e.responseTokens || 0), 0) / entries.length;
-  const avgDuration = entries.reduce((s, e) => s + (e.durationMs || 0), 0) / entries.length;
-
-  const grades = {};
-  for (const e of entries) {
-    grades[e.promptGrade] = (grades[e.promptGrade] || 0) + 1;
-  }
-
-  const commonIssues = {};
-  for (const e of entries) {
-    for (const issue of (e.issues || [])) {
-      commonIssues[issue] = (commonIssues[issue] || 0) + 1;
-    }
-  }
-
-  const topIssues = Object.entries(commonIssues)
-    .sort((a, b) => b[1] - a[1])
-    .slice(0, 5)
-    .map(([rule, count]) => ({ rule, count, pct: Math.round(count / entries.length * 100) }));
-
-  return {
-    available: true,
-    count: entries.length,
-    avgScore: Math.round(avgScore),
-    avgPromptTokens: Math.round(avgPromptTokens),
-    avgResponseTokens: Math.round(avgResponseTokens),
-    avgDurationMs: Math.round(avgDuration),
-    totalPromptTokens: entries.reduce((s, e) => s + (e.promptTokens || 0), 0),
-    totalResponseTokens: entries.reduce((s, e) => s + (e.responseTokens || 0), 0),
-    grades,
-    topIssues,
-  };
-}
-
-/**
- * Suggest improvements for a prompt.
- */
-export function suggestImprovements(prompt, type = 'think') {
-  const score = scorePrompt(prompt, { type });
-  const suggestions = [];
-
-  for (const issue of score.issues) {
-    switch (issue.rule) {
-      case 'too-short':
-        suggestions.push('Add context: what modules are involved, what decision is needed, what constraints exist');
-        break;
-      case 'too-long':
-        suggestions.push('Trim: remove background the AI already knows from CLAUDE.md. Focus on what\'s unique to this question');
-        break;
-      case 'no-question':
-        suggestions.push('End with a clear question or decision point');
-        break;
-      case 'vague-context':
-        suggestions.push('Name specific files, functions, or modules instead of "the project"');
-        break;
-      case 'politeness-waste':
-        suggestions.push('Remove "please", "could you" — direct prompts produce better output');
-        break;
-      case 'hedging':
-        suggestions.push('State positions directly — "X is better because Y" not "I think maybe X"');
-        break;
-      case 'repetitive':
-        suggestions.push('Remove duplicate sentences — each sentence should add new information');
-        break;
-    }
-  }
-
-  return { score, suggestions };
-}

package/src/prompt-intel.mjs

@@ -1,325 +0,0 @@
-// prompt-intel.mjs — Layer 3 prompt analysis, enrichment, risk detection, and intervention routing.
-// Pure functions only. No I/O, no exec. Caller provides projectBrief and calibration.
-
-const INTENT_PATTERNS = {
-  fix:      /\b(?:fix|bug|broken|error|crash|failing|fails|wrong|issue|problem|broken|not\s+working|doesn't\s+work|doesn't\s+work)\b/i,
-  feature:  /\b(?:add|create|build|implement|new|introduce|support|enable)\b/i,
-  refactor: /\b(?:refactor|clean\s+up|reorganize|simplify|extract|restructure|dedup|consolidate|move)\b/i,
-  review:   /\b(?:review|check|audit|look\s+at|examine|inspect|assess|evaluate)\b/i,
-  ship:     /\b(?:ship|deploy|publish|release|push|merge|go\s+live|launch)\b/i,
-  explore:  /\b(?:what|how|why|where|find|search|explain|show\s+me|tell\s+me|list|which)\b/i,
-  test:     /\b(?:test|spec|coverage|assert|jest|mocha|vitest|unit\s+test|integration)\b/i,
-  docs:     /\b(?:doc|readme|comment|jsdoc|document|explain|annotate)\b/i,
-  deploy:   /\b(?:deploy|provision|infrastructure|ci|cd|pipeline|k8s|kubernetes|docker)\b/i,
-};
-
-const RISK_PATTERNS = [
-  { type: 'destructive',  severity: 'block', re: /\b(?:delete\s+all|remove\s+all|drop\s+all|wipe|destroy|rm\s+-rf|truncate\s+all|nuke)\b/i, detail: 'Prompt contains mass-destructive operation' },
-  { type: 'force_push',   severity: 'block', re: /(?:force\s+push|--force|-f\s+origin|reset\s+--hard)/i,                                      detail: 'Prompt implies forced git operation' },
-  { type: 'secret',       severity: 'warn',  re: /\b(?:api\s+key|access\s+token|secret\s+key|\.env|private\s+key|bearer\s+token)\b/i,         detail: 'Touches secret or credential material' },
-  { type: 'auth',         severity: 'warn',  re: /\b(?:auth(?:entication)?|login|logout|password|credential|jwt|oauth|session\s+token)\b/i,    detail: 'Touches authentication code' },
-  { type: 'deploy',       severity: 'warn',  re: /\b(?:ship\s+to|deploy\s+to|release\s+to|push\s+to\s+prod)\b/i,                              detail: 'Targets a deployment action' },
-  { type: 'data_loss',    severity: 'warn',  re: /\b(?:drop\s+table|alter\s+table|schema\s+migration|migrate\s+data|database\s+reset)\b/i,     detail: 'Touches schema or migration — data loss risk' },
-  { type: 'production',   severity: 'warn',  re: /\b(?:production|prod\b|live\s+environment|live\s+site)\b/i,                                  detail: 'References production environment' },
-];
-
-const FILE_REF_RE   = /(?:src\/|\.mjs|\.tsx?|\.jsx?|\.json|\.ya?ml|\.sh|line\s+\d+|\bL\d+\b)/i;
-const FUNC_REF_RE   = /\b\w+\((?:\)|[^)]{0,40}\))/;
-const STEP_RE       = /\b(?:step\s+\d|first[,\s]|then[,\s]|finally[,\s]|must|should\s+(?:use|call|return|handle))\b/i;
-const CRITERIA_RE   = /\b(?:accept(?:ance)?\s+criteria|definition\s+of\s+done|constraints?|requirements?|must\s+(?:not|be|have)|should\s+not)\b/i;
-
-function clamp(v, min = 1, max = 5) {
-  return Math.min(max, Math.max(min, v));
-}
-
-function scoreSpecificity(prompt) {
-  const hasFile  = FILE_REF_RE.test(prompt);
-  const hasFunc  = FUNC_REF_RE.test(prompt);
-  const hasLine  = /\bL\d+\b|\bline\s+\d+/i.test(prompt);
-  const words    = prompt.trim().split(/\s+/).length;
-
-  if (hasFile && (hasFunc || hasLine)) return 5;
-  if (hasFile || hasFunc) return 4;
-  if (words >= 10) return 3;
-  if (words >= 5)  return 2;
-  return 1;
-}
-
-function scoreActionability(prompt) {
-  const hasStep    = STEP_RE.test(prompt);
-  const hasVerb    = /\b(?:fix|add|remove|refactor|create|update|write|delete|move|rename|replace|ensure|make)\b/i.test(prompt);
-  const hasOutcome = /\b(?:so\s+that|in\s+order\s+to|result(?:ing)?\s+in|should\s+(?:return|output|produce|show))\b/i.test(prompt);
-  const words      = prompt.trim().split(/\s+/).length;
-
-  if (hasStep && hasVerb) return 5;
-  if (hasOutcome && hasVerb) return 4;
-  if (hasVerb && words >= 6) return 3;
-  if (hasVerb) return 2;
-  return 1;
-}
-
-function scoreSafety(risks) {
-  if (risks.some(r => r.severity === 'block')) return 1;
-  if (risks.some(r => r.type === 'auth' || r.type === 'secret' || r.type === 'production')) return 2;
-  if (risks.some(r => r.type === 'deploy' || r.type === 'data_loss')) return 3;
-  if (risks.length > 0) return 4;
-  return 5;
-}
-
-function scoreCompleteness(prompt) {
-  const hasCriteria = CRITERIA_RE.test(prompt);
-  const hasContext  = /\b(?:because|since|currently|right\s+now|the\s+issue\s+is|error\s+is|it\s+(?:crashes|fails|returns))\b/i.test(prompt);
-  const hasScope    = FILE_REF_RE.test(prompt);
-  const words       = prompt.trim().split(/\s+/).length;
-
-  if (hasCriteria && hasContext && hasScope) return 5;
-  if ((hasCriteria || hasContext) && hasScope) return 4;
-  if (hasContext || (hasScope && words >= 8)) return 3;
-  if (words >= 6) return 2;
-  return 1;
-}
-
-function detectIntent(prompt) {
-  const counts = {};
-  for (const [type, re] of Object.entries(INTENT_PATTERNS)) {
-    const matches = prompt.match(new RegExp(re.source, 'gi')) ?? [];
-    if (matches.length > 0) counts[type] = matches.length;
-  }
-
-  const entries = Object.entries(counts).sort((a, b) => b[1] - a[1]);
-  if (entries.length === 0) {
-    return { type: 'unknown', confidence: 0, keywords: [] };
-  }
-
-  const [topType, topCount] = entries[0];
-  const totalMatches = Object.values(counts).reduce((s, n) => s + n, 0);
-  const confidence = Math.min(1, topCount / Math.max(totalMatches, 1) * (entries.length === 1 ? 1.5 : 1));
-
-  const allWords = prompt.match(new RegExp(INTENT_PATTERNS[topType].source, 'gi')) ?? [];
-  const keywords = [...new Set(allWords.map(w => w.toLowerCase().trim()))].slice(0, 5);
-
-  return { type: topType, confidence: Math.round(confidence * 100) / 100, keywords };
-}
-
-function detectRisks(prompt) {
-  const found = [];
-  for (const { type, severity, re, detail } of RISK_PATTERNS) {
-    if (re.test(prompt)) {
-      found.push({ type, severity, detail });
-    }
-  }
-  return found;
-}
-
-function findMissingInfo(prompt, intent, specificity, completeness) {
-  const missing = [];
-
-  if (intent.type === 'fix') {
-    if (!/error|exception|crash|fail|wrong|issue/i.test(prompt)) missing.push('error description or failure symptom');
-    if (!FILE_REF_RE.test(prompt)) missing.push('affected file or component');
-    if (!/repro|reproduce|steps|trigger|when\s+I/i.test(prompt)) missing.push('reproduction steps');
-  }
-
-  if (intent.type === 'feature') {
-    if (!FILE_REF_RE.test(prompt)) missing.push('target file or module to add feature to');
-    if (!/user\s+(?:can|should|will)|should\s+(?:allow|enable|support)/i.test(prompt)) missing.push('user-facing outcome');
-  }
-
-  if (intent.type === 'refactor' && !FILE_REF_RE.test(prompt)) {
-    missing.push('which file or function to refactor');
-  }
-
-  if (specificity < 2) missing.push('file name or component reference');
-  if (completeness < 2) missing.push('context about current behavior');
-
-  return [...new Set(missing)].slice(0, 3);
-}
-
-function chooseIntervention(quality, risks, calibration) {
-  if (risks.some(r => r.severity === 'block')) return 'block';
-
-  const autonomy    = calibration?.autonomy    ?? 3;
-  const specificity = calibration?.specificity ?? 3;
-
-  if (quality.score >= 4 && risks.length === 0 && autonomy > 4) return 'pass';
-  if (quality.score < 2 && specificity < 3)  return 'confirm_rewrite';
-  if (quality.score < 3 && quality.completeness <= 2) return 'clarify_once';
-  return 'silent_enrich';
-}
-
-export function analyzePrompt(prompt, projectBrief, calibration) {
-  const risks        = detectRisks(prompt);
-  const intent       = detectIntent(prompt);
-  const specificity  = scoreSpecificity(prompt);
-  const actionability= scoreActionability(prompt);
-  const safety       = scoreSafety(risks);
-  const completeness = scoreCompleteness(prompt);
-  const score        = Math.round(((specificity + actionability + safety + completeness) / 4) * 10) / 10;
-
-  const quality = { score, specificity, actionability, safety, completeness };
-  const missingInfo   = findMissingInfo(prompt, intent, specificity, completeness);
-  const intervention  = chooseIntervention(quality, risks, calibration);
-
-  return {
-    original:     prompt,
-    quality,
-    intent,
-    risks,
-    missingInfo,
-    intervention,
-  };
-}
-
-function relevantDirtyFiles(dirtyFiles, intent) {
-  if (!Array.isArray(dirtyFiles) || dirtyFiles.length === 0) return [];
-
-  const INTENT_HINTS = {
-    fix:      /\bfix|bug|error\b/i,
-    ship:     /.*/,
-    review:   /.*/,
-    feature:  /src\//i,
-    refactor: /src\//i,
-    test:     /test|spec/i,
-    docs:     /\.md$|readme/i,
-  };
-
-  const re = INTENT_HINTS[intent.type] ?? /src\//i;
-  return dirtyFiles.filter(f => re.test(f)).slice(0, 4);
-}
-
-export function enrichPrompt(prompt, projectBrief, analysis) {
-  if (!projectBrief) return prompt;
-
-  const lines = [prompt, ''];
-  const { branch, dirtyFiles = [], recentCommits = [], aheadOfRemote = 0, recentFailures = [] } = projectBrief;
-  const { intent } = analysis;
-
-  const uncommitted = dirtyFiles.length;
-  if (branch || uncommitted > 0) {
-    const parts = [];
-    if (branch) parts.push(`${branch} branch`);
-    if (uncommitted > 0) parts.push(`${uncommitted} uncommitted file${uncommitted !== 1 ? 's' : ''}`);
-    if (aheadOfRemote > 0) parts.push(`${aheadOfRemote} ahead of remote`);
-    lines.push(`[Context: ${parts.join(', ')}]`);
-  }
-
-  const relFiles = relevantDirtyFiles(dirtyFiles, intent);
-  if (relFiles.length > 0) {
-    lines.push(`[Files: ${relFiles.join(', ')}]`);
-  }
-
-  if (recentCommits.length > 0 && ['fix', 'review', 'ship'].includes(intent.type)) {
-    lines.push(`[Recent: ${recentCommits[0].slice(0, 80)}]`);
-  }
-
-  if (recentFailures.length > 0) {
-    const related = recentFailures.find(f => {
-      const fp = (f.prompt ?? '').toLowerCase();
-      const pp = prompt.toLowerCase();
-      const words = pp.split(/\s+/).filter(w => w.length > 3);
-      return words.some(w => fp.includes(w));
-    });
-    if (related) {
-      lines.push(`[Failures: previous attempt failed — ${(related.error ?? 'unknown error').slice(0, 80)}]`);
-    }
-  }
-
-  return lines.slice(0, lines.length).join('\n');
-}
-
-export function formatRiskWarning(risks) {
-  if (!risks || risks.length === 0) return '';
-  const lines = ['⚠️  RISK DETECTED'];
-  for (const risk of risks) {
-    const icon   = risk.severity === 'block' ? '🔴' : '🟡';
-    const suffix = risk.severity === 'block' ? ' (BLOCKED)' : ' (proceed with caution)';
-    lines.push(`  ${icon} ${risk.type}: ${risk.detail}${suffix}`);
-  }
-  return lines.join('\n');
-}
-
-export function formatQuality(analysis) {
-  const { quality, intent, intervention } = analysis;
-  const q = quality;
-  return `Quality: ${q.score}/5 (specificity:${q.specificity} action:${q.actionability} safety:${q.safety} complete:${q.completeness})\nIntent: ${intent.type} (${intent.confidence}) | Intervention: ${intervention}`;
-}
-
-export function suggestImprovement(analysis) {
-  const { intent, missingInfo, quality } = analysis;
-
-  const templates = {
-    fix:      `Fix the [specific function or behavior] in [file path] — it [symptom/error], causing [impact]`,
-    feature:  `Add [feature name] to [file/component] — it should [user outcome] when [condition]`,
-    refactor: `Refactor [function/module] in [file] to [desired outcome] — keep [what to preserve]`,
-    review:   `Review [file or PR] for [concern] — focus on [specific area or risk]`,
-    ship:     `Ship [branch/feature] — verify [test status], then merge and publish`,
-    explore:  `Explain how [specific mechanism] works in [file/component]`,
-    test:     `Write tests for [function/module] in [file] covering [edge cases]`,
-    docs:     `Document [function or module] in [file] — cover [params, return, examples]`,
-    deploy:   `Deploy [service] to [environment] — confirm [readiness checks]`,
-    unknown:  `Describe what you want changed, which file it's in, and what the expected result is`,
-  };
-
-  const base = templates[intent.type] ?? templates.unknown;
-  const tips  = missingInfo.length > 0
-    ? ` (missing: ${missingInfo.join(', ')})`
-    : '';
-
-  return `Try: '${base}'${tips}`;
-}
-
-export function getTaskTemplate(intentType) {
-  const templates = {
-    fix: {
-      needs:    ['error_description', 'affected_files', 'reproduction_steps'],
-      auto_add: ['test_expectations', 'rollback_plan'],
-    },
-    feature: {
-      needs:    ['feature_description', 'affected_area'],
-      auto_add: ['test_plan', 'acceptance_criteria'],
-    },
-    refactor: {
-      needs:    ['target_code', 'desired_outcome'],
-      auto_add: ['test_preservation', 'scope_boundary'],
-    },
-    review: {
-      needs:    ['scope'],
-      auto_add: ['recent_changes', 'risk_areas'],
-    },
-    ship: {
-      needs:    ['readiness_check'],
-      auto_add: ['test_status', 'git_status', 'uncommitted_changes'],
-    },
-    explore: {
-      needs:    ['topic'],
-      auto_add: ['related_files', 'recent_changes'],
-    },
-    test: {
-      needs:    ['target_function', 'test_framework'],
-      auto_add: ['edge_cases', 'existing_coverage'],
-    },
-    docs: {
-      needs:    ['target_module'],
-      auto_add: ['param_descriptions', 'usage_example'],
-    },
-    deploy: {
-      needs:    ['target_environment', 'service_name'],
-      auto_add: ['pre_deploy_checks', 'rollback_plan'],
-    },
-    unknown: {
-      needs:    ['prompt_clarification'],
-      auto_add: [],
-    },
-  };
-
-  return templates[intentType] ?? templates.unknown;
-}
-
-export function shouldBlock(analysis) {
-  return analysis.risks.some(r => r.severity === 'block');
-}
-
-export function getBlockReason(analysis) {
-  const blocking = analysis.risks.find(r => r.severity === 'block');
-  return blocking ? blocking.detail : null;
-}