dockview-core 7.0.2 → 7.0.4

package/dist/cjs/dockview/dockviewGroupPanel.d.ts

@@ -13,7 +13,7 @@ export interface IDockviewGroupPanel extends IGridviewPanel<DockviewGroupPanelAp
 }
 export declare class DockviewGroupPanel extends GridviewPanel<DockviewGroupPanelApiImpl> implements IDockviewGroupPanel {
     private readonly _model;
-    private _explicitConstraints;
+    private readonly _explicitConstraints;
     get minimumWidth(): number;
     get minimumHeight(): number;
     get maximumWidth(): number;

package/dist/cjs/dockview/dockviewGroupPanelModel.js

@@ -572,7 +572,7 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
         }
         // Remove from any existing group first
         var existingGroup = this.getTabGroupForPanel(panelId);
-        if (existingGroup && existingGroup.id === tabGroupId) {
+        if ((existingGroup === null || existingGroup === void 0 ? void 0 : existingGroup.id) === tabGroupId) {
             return; // already in this group — no mutation
         }
         this._bracketTabGroupMutation(function () {
@@ -593,7 +593,7 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
      */
     DockviewGroupPanelModel.prototype.movePanelWithinGroup = function (tabGroupId, panelId, newIndex) {
         var tabGroup = this._tabGroupMap.get(tabGroupId);
-        if (!tabGroup || !tabGroup.containsPanel(panelId)) {
+        if (!(tabGroup === null || tabGroup === void 0 ? void 0 : tabGroup.containsPanel(panelId))) {
             return;
         }
         // Remove and re-add at new index within the group
@@ -846,7 +846,7 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
         for (var i = activePanelIndex + 1; i < this._panels.length; i++) {
             var candidate = this._panels[i];
             var candidateGroup = this._findTabGroupForPanel(candidate.id);
-            if (!candidateGroup || !candidateGroup.collapsed) {
+            if (!(candidateGroup === null || candidateGroup === void 0 ? void 0 : candidateGroup.collapsed)) {
                 this.doSetActivePanel(candidate);
                 this.updateContainer();
                 return;
@@ -855,7 +855,7 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
         for (var i = activePanelIndex - 1; i >= 0; i--) {
             var candidate = this._panels[i];
             var candidateGroup = this._findTabGroupForPanel(candidate.id);
-            if (!candidateGroup || !candidateGroup.collapsed) {
+            if (!(candidateGroup === null || candidateGroup === void 0 ? void 0 : candidateGroup.collapsed)) {
                 this.doSetActivePanel(candidate);
                 this.updateContainer();
                 return;
@@ -888,9 +888,9 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
             // Bump counter past any restored numeric suffixes to avoid ID collisions
             for (var serializedGroups_1 = __values(serializedGroups), serializedGroups_1_1 = serializedGroups_1.next(); !serializedGroups_1_1.done; serializedGroups_1_1 = serializedGroups_1.next()) {
                 var data = serializedGroups_1_1.value;
-                var match = data.id.match(/-(\d+)$/);
+                var match = /-(\d+)$/.exec(data.id);
                 if (match) {
-                    var num = parseInt(match[1], 10) + 1;
+                    var num = Number.parseInt(match[1], 10) + 1;
                     if (num > this._tabGroupIdCounter) {
                         this._tabGroupIdCounter = num;
                     }
@@ -1049,32 +1049,26 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
         return result;
     };
     DockviewGroupPanelModel.prototype.moveToNext = function (options) {
-        if (!options) {
-            options = {};
-        }
-        if (!options.panel) {
-            options.panel = this.activePanel;
-        }
+        var _a;
+        options !== null && options !== void 0 ? options : (options = {});
+        (_a = options.panel) !== null && _a !== void 0 ? _a : (options.panel = this.activePanel);
         var index = options.panel ? this.panels.indexOf(options.panel) : -1;
         var normalizedIndex;
         if (index < this.panels.length - 1) {
             normalizedIndex = index + 1;
         }
-        else if (!options.suppressRoll) {
-            normalizedIndex = 0;
+        else if (options.suppressRoll) {
+            return;
         }
         else {
-            return;
+            normalizedIndex = 0;
         }
         this.openPanel(this.panels[normalizedIndex]);
     };
     DockviewGroupPanelModel.prototype.moveToPrevious = function (options) {
-        if (!options) {
-            options = {};
-        }
-        if (!options.panel) {
-            options.panel = this.activePanel;
-        }
+        var _a;
+        options !== null && options !== void 0 ? options : (options = {});
+        (_a = options.panel) !== null && _a !== void 0 ? _a : (options.panel = this.activePanel);
         if (!options.panel) {
             return;
         }
@@ -1083,11 +1077,11 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
         if (index > 0) {
             normalizedIndex = index - 1;
         }
-        else if (!options.suppressRoll) {
-            normalizedIndex = this.panels.length - 1;
+        else if (options.suppressRoll) {
+            return;
         }
         else {
-            return;
+            normalizedIndex = this.panels.length - 1;
         }
         this.openPanel(this.panels[normalizedIndex]);
     };
@@ -1202,7 +1196,7 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
         if (!this._activePanel && this.panels.length > 0) {
             var candidate = this._panels.find(function (p) {
                 var tg = _this._findTabGroupForPanel(p.id);
-                return !tg || !tg.collapsed;
+                return !(tg === null || tg === void 0 ? void 0 : tg.collapsed);
             });
             if (candidate) {
                 this.doSetActivePanel(candidate);

package/dist/cjs/dockview/dockviewPanel.js

@@ -178,16 +178,15 @@ var DockviewPanel = /** @class */ (function (_super) {
     };
     DockviewPanel.prototype.update = function (event) {
         var e_1, _a;
-        var _b;
         // merge the new parameters with the existing parameters
-        this._params = __assign(__assign({}, ((_b = this._params) !== null && _b !== void 0 ? _b : {})), event.params);
+        this._params = __assign(__assign({}, this._params), event.params);
         try {
             /**
              * delete new keys that have a value of undefined,
              * allow values of null
              */
-            for (var _c = __values(Object.keys(event.params)), _d = _c.next(); !_d.done; _d = _c.next()) {
-                var key = _d.value;
+            for (var _b = __values(Object.keys(event.params)), _c = _b.next(); !_c.done; _c = _b.next()) {
+                var key = _c.value;
                 if (event.params[key] === undefined) {
                     delete this._params[key];
                 }
@@ -196,7 +195,7 @@ var DockviewPanel = /** @class */ (function (_super) {
         catch (e_1_1) { e_1 = { error: e_1_1 }; }
         finally {
             try {
-                if (_d && !_d.done && (_a = _c.return)) _a.call(_c);
+                if (_c && !_c.done && (_a = _b.return)) _a.call(_b);
             }
             finally { if (e_1) throw e_1.error; }
         }

package/dist/cjs/dockview/dockviewShell.d.ts

@@ -56,16 +56,37 @@ export declare class EdgeGroupView implements IView {
     readonly priority = LayoutPriority.Low;
     private _isCollapsed;
     private _lastExpandedSize;
-    private _collapsedSize;
-    private _expandedMinimumSize;
+    private _baseCollapsedSize;
+    private _baseMinimumSize;
+    private _gapAdd;
     private readonly _expandedMaximumSize;
+    private _measuredTabSize;
+    private readonly _tabSizeDisposables;
+    /**
+     * The effective (pre-gap) collapsed size: the measured tab-strip size when
+     * available, otherwise the configured/theme base.
+     */
+    private get _effectiveBaseCollapsed();
     get minimumSize(): number;
     get maximumSize(): number;
     get element(): HTMLElement;
     get isCollapsed(): boolean;
     get lastExpandedSize(): number;
     get collapsedSize(): number;
-    constructor(options: EdgeGroupOptions, group: IEdgeGroupHost, orientation: 'horizontal' | 'vertical');
+    constructor(options: EdgeGroupOptions, group: IEdgeGroupHost, orientation: 'horizontal' | 'vertical', gapAdd?: number);
+    /**
+     * Watch the group's tab strip so the collapsed size follows the live tab
+     * height. The strip's cross-axis size (height for top/bottom, width for
+     * left/right) is exactly what a collapsed edge group should occupy; a
+     * ResizeObserver keeps them in sync when the tab height changes at runtime.
+     */
+    private _observeTabStrip;
+    /**
+     * Apply a freshly-measured tab-strip cross size. When the group is
+     * collapsed this resizes it in the parent splitview so the collapsed strip
+     * always shows the full tab height.
+     */
+    private _applyMeasuredTabSize;
     layout(size: number, orthogonalSize: number): void;
     setCollapsed(collapsed: boolean): void;
     setVisible(_visible: boolean): void;
@@ -76,11 +97,12 @@ export declare class EdgeGroupView implements IView {
      */
     restoreExpandedSize(size: number): void;
     /**
-     * Apply new effective collapsed and expanded-minimum sizes after a theme
-     * or gap change. The caller (ShellManager) is responsible for computing
-     * the correct values from the original config and the new gap.
+     * Apply a new base (pre-gap) collapsed size, base minimum size and gap
+     * contribution after a theme or gap change. Base values come from the
+     * original config; the ShellManager owns the gap arithmetic. A live
+     * measured tab size (if any) continues to win over the base collapsed size.
      */
-    updateCollapsedSize(newCollapsedSize: number, newExpandedMinimumSize: number): void;
+    updateSizing(baseCollapsedSize: number, baseMinimumSize: number | undefined, gapAdd: number): void;
     dispose(): void;
 }
 export declare class ShellManager implements IDisposable {

package/dist/cjs/dockview/dockviewShell.js

@@ -17,39 +17,55 @@ var lifecycle_1 = require("../lifecycle");
 var splitview_1 = require("../splitview/splitview");
 var dom_1 = require("../dom");
 var EdgeGroupView = /** @class */ (function () {
-    function EdgeGroupView(options, group, orientation) {
+    function EdgeGroupView(options, group, orientation, gapAdd) {
+        if (gapAdd === void 0) { gapAdd = 0; }
         var _a, _b, _c;
         this._onDidChange = new events_1.Emitter();
         this.onDidChange = this._onDidChange.event;
         this.snap = false;
         this.priority = splitview_1.LayoutPriority.Low;
         this._isCollapsed = false;
+        this._tabSizeDisposables = new lifecycle_1.CompositeDisposable();
         this._group = group;
         this._orientation = orientation;
         group.element.classList.add('dv-edge-group');
         group.element.dataset.testid = "dv-edge-group-".concat(options.id);
-        this._collapsedSize = (_a = options.collapsedSize) !== null && _a !== void 0 ? _a : 35;
+        this._baseCollapsedSize = (_a = options.collapsedSize) !== null && _a !== void 0 ? _a : 35;
+        this._baseMinimumSize = options.minimumSize;
+        this._gapAdd = gapAdd;
         this._expandedMaximumSize =
             (_b = options.maximumSize) !== null && _b !== void 0 ? _b : Number.POSITIVE_INFINITY;
-        // If the caller explicitly provides a minimumSize, respect it.
-        // Otherwise fall back to collapsedSize + 50 so the expanded state is
-        // visually distinguishable from the collapsed state.
-        this._expandedMinimumSize =
-            options.minimumSize !== undefined
-                ? options.minimumSize
-                : this._collapsedSize + 50;
         this._lastExpandedSize = (_c = options.initialSize) !== null && _c !== void 0 ? _c : 200;
         if (options.collapsed) {
             this._isCollapsed = true;
             group.element.classList.add('dv-edge-collapsed');
         }
+        this._observeTabStrip();
     }
+    Object.defineProperty(EdgeGroupView.prototype, "_effectiveBaseCollapsed", {
+        /**
+         * The effective (pre-gap) collapsed size: the measured tab-strip size when
+         * available, otherwise the configured/theme base.
+         */
+        get: function () {
+            var _a;
+            return (_a = this._measuredTabSize) !== null && _a !== void 0 ? _a : this._baseCollapsedSize;
+        },
+        enumerable: false,
+        configurable: true
+    });
     Object.defineProperty(EdgeGroupView.prototype, "minimumSize", {
         get: function () {
             // When collapsed, lock size to collapsedSize so sash can't drag it open
-            return this._isCollapsed
-                ? this._collapsedSize
-                : this._expandedMinimumSize;
+            if (this._isCollapsed) {
+                return this.collapsedSize;
+            }
+            // If the caller explicitly provides a minimumSize, respect it.
+            // Otherwise fall back to collapsedSize + 50 so the expanded state is
+            // visually distinguishable from the collapsed state.
+            return this._baseMinimumSize !== undefined
+                ? this._baseMinimumSize + this._gapAdd
+                : this._effectiveBaseCollapsed + 50 + this._gapAdd;
         },
         enumerable: false,
         configurable: true
@@ -58,7 +74,7 @@ var EdgeGroupView = /** @class */ (function () {
         get: function () {
             // When collapsed, lock size to collapsedSize so sash can't drag it open
             return this._isCollapsed
-                ? this._collapsedSize
+                ? this.collapsedSize
                 : this._expandedMaximumSize;
         },
         enumerable: false,
@@ -87,11 +103,43 @@ var EdgeGroupView = /** @class */ (function () {
     });
     Object.defineProperty(EdgeGroupView.prototype, "collapsedSize", {
         get: function () {
-            return this._collapsedSize;
+            return this._effectiveBaseCollapsed + this._gapAdd;
         },
         enumerable: false,
         configurable: true
     });
+    /**
+     * Watch the group's tab strip so the collapsed size follows the live tab
+     * height. The strip's cross-axis size (height for top/bottom, width for
+     * left/right) is exactly what a collapsed edge group should occupy; a
+     * ResizeObserver keeps them in sync when the tab height changes at runtime.
+     */
+    EdgeGroupView.prototype._observeTabStrip = function () {
+        var _this = this;
+        var strip = this._group.element.querySelector('.dv-tabs-and-actions-container');
+        if (!strip) {
+            return;
+        }
+        this._tabSizeDisposables.addDisposables((0, dom_1.watchElementResize)(strip, function () {
+            _this._applyMeasuredTabSize(_this._orientation === 'vertical'
+                ? strip.offsetHeight
+                : strip.offsetWidth);
+        }));
+    };
+    /**
+     * Apply a freshly-measured tab-strip cross size. When the group is
+     * collapsed this resizes it in the parent splitview so the collapsed strip
+     * always shows the full tab height.
+     */
+    EdgeGroupView.prototype._applyMeasuredTabSize = function (size) {
+        if (size <= 0 || size === this._measuredTabSize) {
+            return;
+        }
+        this._measuredTabSize = size;
+        if (this._isCollapsed) {
+            this._onDidChange.fire({ size: this.collapsedSize });
+        }
+    };
     EdgeGroupView.prototype.layout = function (size, orthogonalSize) {
         // Track the last expanded size so we can restore it after collapsing
         if (!this._isCollapsed) {
@@ -126,15 +174,18 @@ var EdgeGroupView = /** @class */ (function () {
         this._lastExpandedSize = size;
     };
     /**
-     * Apply new effective collapsed and expanded-minimum sizes after a theme
-     * or gap change. The caller (ShellManager) is responsible for computing
-     * the correct values from the original config and the new gap.
+     * Apply a new base (pre-gap) collapsed size, base minimum size and gap
+     * contribution after a theme or gap change. Base values come from the
+     * original config; the ShellManager owns the gap arithmetic. A live
+     * measured tab size (if any) continues to win over the base collapsed size.
      */
-    EdgeGroupView.prototype.updateCollapsedSize = function (newCollapsedSize, newExpandedMinimumSize) {
-        this._collapsedSize = newCollapsedSize;
-        this._expandedMinimumSize = newExpandedMinimumSize;
+    EdgeGroupView.prototype.updateSizing = function (baseCollapsedSize, baseMinimumSize, gapAdd) {
+        this._baseCollapsedSize = baseCollapsedSize;
+        this._baseMinimumSize = baseMinimumSize;
+        this._gapAdd = gapAdd;
     };
     EdgeGroupView.prototype.dispose = function () {
+        this._tabSizeDisposables.dispose();
         this._onDidChange.dispose();
     };
     return EdgeGroupView;
@@ -279,15 +330,6 @@ var MiddleColumnView = /** @class */ (function () {
     };
     return MiddleColumnView;
 }());
-function adjustedOpts(base, defaultCollapsed, gapAdd) {
-    var _a;
-    var effectiveCollapsed = ((_a = base.collapsedSize) !== null && _a !== void 0 ? _a : defaultCollapsed) + gapAdd;
-    var result = __assign(__assign({}, base), { collapsedSize: effectiveCollapsed });
-    if (base.minimumSize !== undefined) {
-        result.minimumSize = base.minimumSize + gapAdd;
-    }
-    return result;
-}
 var ShellManager = /** @class */ (function () {
     function ShellManager(container, dockviewElement, layoutGrid, gap, defaultCollapsedSize) {
         if (gap === void 0) { gap = 0; }
@@ -316,6 +358,26 @@ var ShellManager = /** @class */ (function () {
         this._middleIndex = 0;
         this._outerSplitview.addView(this._middleColumn, { type: 'distribute' }, 0);
         this._disposables.addDisposables((0, dom_1.watchElementResize)(this._shellElement, function (entry) {
+            /**
+             * When the shell (or an ancestor) becomes hidden — e.g. a
+             * nested dockview whose `onlyWhenVisible` host panel is
+             * deactivated — the element collapses to (0, 0) or is detached
+             * from the DOM. Propagating that zero size would relayout the
+             * edge-group splitview at 0, clamping the low-priority edge
+             * groups down to their minimum size and destroying the user's
+             * sizing. Skip these cases so sizes are preserved while hidden;
+             * mirrors the guard in the `Resizable` base class. See #1495.
+             *
+             * offsetParent === null is equivalent to display: none on the
+             * element or one of its ancestors.
+             * @see https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/offsetParent
+             */
+            if (!_this._shellElement.offsetParent) {
+                return;
+            }
+            if (!(0, dom_1.isInDocument)(_this._shellElement)) {
+                return;
+            }
             var width = Math.round(entry.contentRect.width);
             var height = Math.round(entry.contentRect.height);
             if (width === _this._currentWidth &&
@@ -356,7 +418,7 @@ var ShellManager = /** @class */ (function () {
         var isHorizontal = position === 'left' || position === 'right';
         var gapAdd = isHorizontal ? outerGapAdd : innerGapAdd;
         var orientation = isHorizontal ? 'horizontal' : 'vertical';
-        var view = new EdgeGroupView(adjustedOpts(__assign({ collapsedSize: this._defaultCollapsedSize }, options), this._defaultCollapsedSize, gapAdd), group, orientation);
+        var view = new EdgeGroupView(__assign({ collapsedSize: this._defaultCollapsedSize }, options), group, orientation, gapAdd);
         var initialSize = view.isCollapsed
             ? view.collapsedSize
             : view.lastExpandedSize;
@@ -423,10 +485,7 @@ var ShellManager = /** @class */ (function () {
         var updateView = function (view, baseCfg, gapAdd) {
             var _a;
             var baseCS = (_a = baseCfg.collapsedSize) !== null && _a !== void 0 ? _a : defaultCollapsedSize;
-            var newCS = baseCS + gapAdd;
-            var baseMS = baseCfg.minimumSize;
-            var newMS = baseMS !== undefined ? baseMS + gapAdd : newCS + 50;
-            view.updateCollapsedSize(newCS, newMS);
+            view.updateSizing(baseCS, baseCfg.minimumSize, gapAdd);
         };
         var topCfg = this._viewConfigs.get('top');
         if (this._topView && topCfg) {
@@ -677,9 +736,8 @@ var ShellManager = /** @class */ (function () {
         }
     };
     ShellManager.prototype.dispose = function () {
-        var _a;
         this._disposables.dispose();
-        (_a = this._shellElement.parentElement) === null || _a === void 0 ? void 0 : _a.removeChild(this._shellElement);
+        this._shellElement.remove();
     };
     return ShellManager;
 }());

package/dist/cjs/dockview/strictEventsSequencing.js

@@ -36,11 +36,11 @@ var StrictEventsSequencing = /** @class */ (function (_super) {
                 panels.add(panel.api.id);
             }
         }), this.accessor.onDidRemovePanel(function (panel) {
-            if (!panels.has(panel.api.id)) {
-                throw new Error("dockview: Invalid event sequence. [onDidRemovePanel] called for panel ".concat(panel.api.id, " but panel does not exists"));
+            if (panels.has(panel.api.id)) {
+                panels.delete(panel.api.id);
             }
             else {
-                panels.delete(panel.api.id);
+                throw new Error("dockview: Invalid event sequence. [onDidRemovePanel] called for panel ".concat(panel.api.id, " but panel does not exists"));
             }
         }), this.accessor.onDidAddGroup(function (group) {
             if (groups.has(group.api.id)) {
@@ -50,11 +50,11 @@ var StrictEventsSequencing = /** @class */ (function (_super) {
                 groups.add(group.api.id);
             }
         }), this.accessor.onDidRemoveGroup(function (group) {
-            if (!groups.has(group.api.id)) {
-                throw new Error("dockview: Invalid event sequence. [onDidRemoveGroup] called for group ".concat(group.api.id, " but group does not exists"));
+            if (groups.has(group.api.id)) {
+                groups.delete(group.api.id);
             }
             else {
-                groups.delete(group.api.id);
+                throw new Error("dockview: Invalid event sequence. [onDidRemoveGroup] called for group ".concat(group.api.id, " but group does not exists"));
             }
         }));
     };

package/dist/cjs/dockview/tabGroup.js

@@ -147,9 +147,9 @@ var TabGroup = /** @class */ (function (_super) {
         if (this._panelIds.includes(panelId)) {
             return;
         }
-        var insertIndex = index !== undefined
-            ? Math.max(0, Math.min(index, this._panelIds.length))
-            : this._panelIds.length;
+        var insertIndex = index === undefined
+            ? this._panelIds.length
+            : Math.max(0, Math.min(index, this._panelIds.length));
         this._panelIds.splice(insertIndex, 0, panelId);
         this._onDidPanelChange.fire({ panelId: panelId, type: 'add' });
     };

package/dist/cjs/dockview/tabGroupAccent.js

@@ -99,9 +99,7 @@ var _fallbackPalette;
  * palette through.
  */
 function getFallbackPalette() {
-    if (!_fallbackPalette) {
-        _fallbackPalette = new TabGroupColorPalette(exports.DEFAULT_TAB_GROUP_COLORS, true);
-    }
+    _fallbackPalette !== null && _fallbackPalette !== void 0 ? _fallbackPalette : (_fallbackPalette = new TabGroupColorPalette(exports.DEFAULT_TAB_GROUP_COLORS, true));
     return _fallbackPalette;
 }
 /**

package/dist/cjs/dom.js

@@ -179,7 +179,7 @@ var FocusTracker = /** @class */ (function (_super) {
         var onBlur = function () {
             if (hasFocus) {
                 loosingFocus = true;
-                window.setTimeout(function () {
+                globalThis.setTimeout(function () {
                     if (loosingFocus) {
                         loosingFocus = false;
                         hasFocus = false;

package/dist/cjs/events.js

@@ -95,7 +95,7 @@ var Stacktrace = /** @class */ (function () {
     }
     Stacktrace.create = function () {
         var _a;
-        return new Stacktrace((_a = new Error().stack) !== null && _a !== void 0 ? _a : '');
+        return new Stacktrace((_a = new Error('listener stacktrace').stack) !== null && _a !== void 0 ? _a : '');
     };
     Stacktrace.prototype.print = function () {
         console.warn('dockview: stacktrace', this.value);

package/dist/cjs/gridview/baseComponentGridview.js

@@ -90,8 +90,7 @@ var BaseGrid = /** @class */ (function (_super) {
         }), _this.onDidViewVisibilityChangeMicroTaskQueue(function () {
             _this.forceRelayout();
         }), lifecycle_1.Disposable.from(function () {
-            var _a;
-            (_a = _this.element.parentElement) === null || _a === void 0 ? void 0 : _a.removeChild(_this.element);
+            _this.element.remove();
         }), _this.gridview.onDidChange(function () {
             _this._bufferOnDidLayoutChange.fire();
         }), events_1.Event.any(_this.onDidAdd, _this.onDidRemove, _this.onDidActiveChange)(function () {
@@ -269,9 +268,7 @@ var BaseGrid = /** @class */ (function (_super) {
     };
     BaseGrid.prototype.moveToNext = function (options) {
         var _a;
-        if (!options) {
-            options = {};
-        }
+        options !== null && options !== void 0 ? options : (options = {});
         if (!options.group) {
             if (!this.activeGroup) {
                 return;
@@ -284,9 +281,7 @@ var BaseGrid = /** @class */ (function (_super) {
     };
     BaseGrid.prototype.moveToPrevious = function (options) {
         var _a;
-        if (!options) {
-            options = {};
-        }
+        options !== null && options !== void 0 ? options : (options = {});
         if (!options.group) {
             if (!this.activeGroup) {
                 return;

package/dist/cjs/gridview/branchNode.js

@@ -66,16 +66,7 @@ var BranchNode = /** @class */ (function (_super) {
         _this._size = size;
         _this.element = document.createElement('div');
         _this.element.className = 'dv-branch-node';
-        if (!childDescriptors) {
-            _this.splitview = new splitview_1.Splitview(_this.element, {
-                orientation: _this.orientation,
-                proportionalLayout: proportionalLayout,
-                styles: styles,
-                margin: margin,
-            });
-            _this.splitview.layout(_this.size, _this.orthogonalSize);
-        }
-        else {
+        if (childDescriptors) {
             var descriptor = {
                 views: childDescriptors.map(function (childDescriptor) {
                     return {
@@ -98,6 +89,15 @@ var BranchNode = /** @class */ (function (_super) {
                 margin: margin,
             });
         }
+        else {
+            _this.splitview = new splitview_1.Splitview(_this.element, {
+                orientation: _this.orientation,
+                proportionalLayout: proportionalLayout,
+                styles: styles,
+                margin: margin,
+            });
+            _this.splitview.layout(_this.size, _this.orthogonalSize);
+        }
         _this.disabled = disabled;
         _this.addDisposables(_this._onDidChange, _this._onDidVisibilityChange, _this.splitview.onDidSashEnd(function () {
             _this._onDidChange.fire({});
@@ -218,15 +218,11 @@ var BranchNode = /** @class */ (function (_super) {
             if (this.children.length === 0) {
                 return splitview_1.LayoutPriority.Normal;
             }
-            var priorities = this.children.map(function (c) {
-                return typeof c.priority === 'undefined'
-                    ? splitview_1.LayoutPriority.Normal
-                    : c.priority;
-            });
-            if (priorities.some(function (p) { return p === splitview_1.LayoutPriority.High; })) {
+            var priorities = new Set(this.children.map(function (c) { var _a; return (_a = c.priority) !== null && _a !== void 0 ? _a : splitview_1.LayoutPriority.Normal; }));
+            if (priorities.has(splitview_1.LayoutPriority.High)) {
                 return splitview_1.LayoutPriority.High;
             }
-            else if (priorities.some(function (p) { return p === splitview_1.LayoutPriority.Low; })) {
+            else if (priorities.has(splitview_1.LayoutPriority.Low)) {
                 return splitview_1.LayoutPriority.Low;
             }
             return splitview_1.LayoutPriority.Normal;