dockview-core 7.0.2 → 7.0.4

package/dist/esm/dockview/dockviewComponent.d.ts

@@ -276,8 +276,8 @@ export declare class DockviewComponent extends BaseGrid<DockviewGroupPanel> impl
     private readonly _api;
     private readonly _moduleRegistry;
     private _options;
-    private _tabGroupColorPalette;
-    private _shellThemeClassnames;
+    private readonly _tabGroupColorPalette;
+    private readonly _shellThemeClassnames;
     readonly overlayRenderContainer: OverlayRenderContainer;
     readonly popupService: PopupService;
     readonly rootDropTargetContainer: DropTargetAnchorContainer;
@@ -340,8 +340,8 @@ export declare class DockviewComponent extends BaseGrid<DockviewGroupPanel> impl
     fireDidTabGroupCollapsedChange(event: DockviewTabGroupCollapsedChangeEvent): void;
     private readonly _onDidMaximizedGroupChange;
     readonly onDidMaximizedGroupChange: Event<DockviewMaximizedGroupChangeEvent>;
-    private _shellManager;
-    private _floatingOverlayHost;
+    private readonly _shellManager;
+    private readonly _floatingOverlayHost;
     private _inShellLayout;
     private readonly _onDidRemoveGroup;
     readonly onDidRemoveGroup: Event<DockviewGroupPanel>;
@@ -514,7 +514,7 @@ export declare class DockviewComponent extends BaseGrid<DockviewGroupPanel> impl
     addPanel<T extends object = Parameters>(options: AddPanelOptions<T>): DockviewPanel;
     private _doAddPanel;
     removePanel(panel: IDockviewPanel, options?: {
-        removeEmptyGroup: boolean;
+        removeEmptyGroup?: boolean;
         skipDispose?: boolean;
         skipSetActiveGroup?: boolean;
     }): void;

package/dist/esm/dockview/dockviewComponent.js

@@ -63,9 +63,9 @@ let _hasWarnedUsingCoreDirectly = false;
  * `process` is undefined.
  */
 function warnIfUsingCoreDirectly() {
+    var _a;
     if (typeof process !== 'undefined' &&
-        process.env &&
-        process.env.NODE_ENV === 'production') {
+        ((_a = process.env) === null || _a === void 0 ? void 0 : _a.NODE_ENV) === 'production') {
         return;
     }
     if (_hasWarnedUsingCoreDirectly || isDockviewPackageLoaded()) {
@@ -456,7 +456,7 @@ export class DockviewComponent extends BaseGrid {
         // The shell always wraps the dockview element so edge groups can be
         // added at any time via addEdgeGroup() without re-parenting the DOM.
         this.disableResizing = true;
-        container.removeChild(this.element);
+        this.element.remove();
         this._shellManager = new ShellManager(container, this.element, (w, h) => this._layoutFromShell(w, h), (_d = (_c = options.theme) === null || _c === void 0 ? void 0 : _c.gap) !== null && _d !== void 0 ? _d : 0, (_e = options.theme) === null || _e === void 0 ? void 0 : _e.edgeGroupCollapsedSize);
         // The shell wraps the dockview element, so move the popup anchor
         // into the shell so overflow dropdowns in edge groups position correctly
@@ -681,15 +681,13 @@ export class DockviewComponent extends BaseGrid {
         return _window
             .open()
             .then((popoutContainer) => {
-            var _a, _b, _c;
+            var _a, _b, _c, _d;
             if (_window.isDisposed) {
                 return false;
             }
-            const referenceGroup = (options === null || options === void 0 ? void 0 : options.referenceGroup)
-                ? options.referenceGroup
-                : itemToPopout instanceof DockviewPanel
-                    ? itemToPopout.group
-                    : itemToPopout;
+            const referenceGroup = (_a = options === null || options === void 0 ? void 0 : options.referenceGroup) !== null && _a !== void 0 ? _a : (itemToPopout instanceof DockviewPanel
+                ? itemToPopout.group
+                : itemToPopout);
             const referenceLocation = itemToPopout.api.location.type;
             /**
              * The group that is being added doesn't already exist within the DOM, the most likely occurrence
@@ -700,7 +698,7 @@ export class DockviewComponent extends BaseGrid {
             if (options === null || options === void 0 ? void 0 : options.overridePopoutGridview) {
                 // Restoring a multi-group window: the anchor group is
                 // already built inside the supplied gridview.
-                group = (_a = options.overridePopoutGroup) !== null && _a !== void 0 ? _a : referenceGroup;
+                group = (_b = options.overridePopoutGroup) !== null && _b !== void 0 ? _b : referenceGroup;
             }
             else if (!isGroupAddedToDom) {
                 group = referenceGroup;
@@ -731,7 +729,7 @@ export class DockviewComponent extends BaseGrid {
             // a nested splitview layout. The window starts with the single
             // anchor group; further groups arrive via drag-and-drop. On
             // restore a pre-populated gridview is supplied instead.
-            const popoutGridview = (_b = options === null || options === void 0 ? void 0 : options.overridePopoutGridview) !== null && _b !== void 0 ? _b : this.createNestedGridview();
+            const popoutGridview = (_c = options === null || options === void 0 ? void 0 : options.overridePopoutGridview) !== null && _c !== void 0 ? _c : this.createNestedGridview();
             if (!(options === null || options === void 0 ? void 0 : options.overridePopoutGridview)) {
                 popoutGridview.addView(group, Sizing.Distribute, [0]);
             }
@@ -772,9 +770,9 @@ export class DockviewComponent extends BaseGrid {
                             break;
                         case 'floating':
                         case 'popout':
-                            floatingBox = (_c = this.floatingGroups
+                            floatingBox = (_d = this.floatingGroups
                                 .find((value) => value.group.api.id ===
-                                itemToPopout.api.id)) === null || _c === void 0 ? void 0 : _c.overlay.toJSON();
+                                itemToPopout.api.id)) === null || _d === void 0 ? void 0 : _d.overlay.toJSON();
                             this.removeGroup(referenceGroup);
                             break;
                     }
@@ -1617,7 +1615,7 @@ export class DockviewComponent extends BaseGrid {
             const createGroupFromSerializedState = (data) => {
                 const { id, locked, hideHeader, headerPosition, views, activeView, } = data;
                 if (typeof id !== 'string') {
-                    throw new Error('dockview: group id must be of type string');
+                    throw new TypeError('dockview: group id must be of type string');
                 }
                 const group = this.createGroup({
                     id,
@@ -1791,8 +1789,7 @@ export class DockviewComponent extends BaseGrid {
                         createdPanels.push(panel);
                     }
                 }
-                for (let i = 0; i < createdPanels.length; i++) {
-                    const panel = createdPanels[i];
+                for (const panel of createdPanels) {
                     const isActive = activeView === panel.id;
                     edgeGroup.model.openPanel(panel, {
                         skipSetActive: !isActive,
@@ -1937,8 +1934,8 @@ export class DockviewComponent extends BaseGrid {
         return this.mutation('add', () => this._doAddPanel(options));
     }
     _doAddPanel(options) {
-        var _a, _b;
-        if (this.panels.find((_) => _.id === options.id)) {
+        var _a, _b, _c, _d;
+        if (this.panels.some((_) => _.id === options.id)) {
             throw new Error(`dockview: panel with id ${options.id} already exists`);
         }
         let referenceGroup;
@@ -1957,18 +1954,24 @@ export class DockviewComponent extends BaseGrid {
                     : options.position.referencePanel;
                 index = options.position.index;
                 if (!referencePanel) {
-                    throw new Error(`dockview: referencePanel '${options.position.referencePanel}' does not exist`);
+                    const referenceId = typeof options.position.referencePanel === 'string'
+                        ? options.position.referencePanel
+                        : (_a = options.position.referencePanel) === null || _a === void 0 ? void 0 : _a.id;
+                    throw new Error(`dockview: referencePanel '${referenceId}' does not exist`);
                 }
                 referenceGroup = this.findGroup(referencePanel);
             }
             else if (isPanelOptionsWithGroup(options.position)) {
                 referenceGroup =
                     typeof options.position.referenceGroup === 'string'
-                        ? (_a = this._groups.get(options.position.referenceGroup)) === null || _a === void 0 ? void 0 : _a.value
+                        ? (_b = this._groups.get(options.position.referenceGroup)) === null || _b === void 0 ? void 0 : _b.value
                         : options.position.referenceGroup;
                 index = options.position.index;
                 if (!referenceGroup) {
-                    throw new Error(`dockview: referenceGroup '${options.position.referenceGroup}' does not exist`);
+                    const referenceId = typeof options.position.referenceGroup === 'string'
+                        ? options.position.referenceGroup
+                        : (_c = options.position.referenceGroup) === null || _c === void 0 ? void 0 : _c.id;
+                    throw new Error(`dockview: referenceGroup '${referenceId}' does not exist`);
                 }
             }
             else {
@@ -1994,7 +1997,7 @@ export class DockviewComponent extends BaseGrid {
         }
         let panel;
         if (referenceGroup) {
-            const target = toTarget(((_b = options.position) === null || _b === void 0 ? void 0 : _b.direction) || 'within');
+            const target = toTarget(((_d = options.position) === null || _d === void 0 ? void 0 : _d.direction) || 'within');
             if (options.floating) {
                 const group = this.createGroup();
                 this._onDidAddGroup.fire(group);
@@ -2076,14 +2079,17 @@ export class DockviewComponent extends BaseGrid {
         }
         return panel;
     }
-    removePanel(panel, options = {
-        removeEmptyGroup: true,
-    }) {
-        this.mutation('remove', () => this._doRemovePanel(panel, options));
+    removePanel(panel, options) {
+        this.mutation('remove', () => {
+            var _a;
+            return this._doRemovePanel(panel, {
+                removeEmptyGroup: (_a = options === null || options === void 0 ? void 0 : options.removeEmptyGroup) !== null && _a !== void 0 ? _a : true,
+                skipDispose: options === null || options === void 0 ? void 0 : options.skipDispose,
+                skipSetActiveGroup: options === null || options === void 0 ? void 0 : options.skipSetActiveGroup,
+            });
+        });
     }
-    _doRemovePanel(panel, options = {
-        removeEmptyGroup: true,
-    }) {
+    _doRemovePanel(panel, options) {
         const group = panel.group;
         if (!group) {
             throw new Error(`dockview: cannot remove panel ${panel.id}. it's missing a group.`);
@@ -2109,28 +2115,34 @@ export class DockviewComponent extends BaseGrid {
         return this.mutation('add', () => this._doAddGroup(options));
     }
     _doAddGroup(options) {
-        var _a;
+        var _a, _b, _c;
         if (options) {
             let referenceGroup;
             if (isGroupOptionsWithPanel(options)) {
                 const referencePanel = typeof options.referencePanel === 'string'
                     ? this.panels.find((panel) => panel.id === options.referencePanel)
                     : options.referencePanel;
+                const referencePanelId = typeof options.referencePanel === 'string'
+                    ? options.referencePanel
+                    : (_a = options.referencePanel) === null || _a === void 0 ? void 0 : _a.id;
                 if (!referencePanel) {
-                    throw new Error(`dockview: reference panel ${options.referencePanel} does not exist`);
+                    throw new Error(`dockview: reference panel ${referencePanelId} does not exist`);
                 }
                 referenceGroup = this.findGroup(referencePanel);
                 if (!referenceGroup) {
-                    throw new Error(`dockview: reference group for reference panel ${options.referencePanel} does not exist`);
+                    throw new Error(`dockview: reference group for reference panel ${referencePanelId} does not exist`);
                 }
             }
             else if (isGroupOptionsWithGroup(options)) {
                 referenceGroup =
                     typeof options.referenceGroup === 'string'
-                        ? (_a = this._groups.get(options.referenceGroup)) === null || _a === void 0 ? void 0 : _a.value
+                        ? (_b = this._groups.get(options.referenceGroup)) === null || _b === void 0 ? void 0 : _b.value
                         : options.referenceGroup;
                 if (!referenceGroup) {
-                    throw new Error(`dockview: reference group ${options.referenceGroup} does not exist`);
+                    const referenceId = typeof options.referenceGroup === 'string'
+                        ? options.referenceGroup
+                        : (_c = options.referenceGroup) === null || _c === void 0 ? void 0 : _c.id;
+                    throw new Error(`dockview: reference group ${referenceId} does not exist`);
                 }
             }
             else {
@@ -2253,14 +2265,14 @@ export class DockviewComponent extends BaseGrid {
             if (this.detachFromNestedWindow(group)) {
                 // The floating window hosts other groups and stays alive —
                 // finalize just this group.
-                if (!(options === null || options === void 0 ? void 0 : options.skipDispose)) {
-                    this.disposeGroupRecord(group);
-                }
-                else {
+                if (options === null || options === void 0 ? void 0 : options.skipDispose) {
                     // Relocation: reset location so the destination root can
                     // re-tag it.
                     group.model.location = { type: 'grid' };
                 }
+                else {
+                    this.disposeGroupRecord(group);
+                }
                 this.activateFallbackGroupIfRemoved(group, options === null || options === void 0 ? void 0 : options.skipActive);
                 return group;
             }
@@ -2281,14 +2293,14 @@ export class DockviewComponent extends BaseGrid {
             if (this.detachFromNestedWindow(group)) {
                 // The popout window hosts other groups and stays alive —
                 // finalize just this group.
-                if (!(options === null || options === void 0 ? void 0 : options.skipDispose)) {
-                    this.disposeGroupRecord(group);
-                }
-                else {
+                if (options === null || options === void 0 ? void 0 : options.skipDispose) {
                     // Relocation: reset location so the destination root can
                     // re-tag it.
                     group.model.location = { type: 'grid' };
                 }
+                else {
+                    this.disposeGroupRecord(group);
+                }
                 this.activateFallbackGroupIfRemoved(group, options === null || options === void 0 ? void 0 : options.skipActive);
                 return group;
             }
@@ -2298,7 +2310,7 @@ export class DockviewComponent extends BaseGrid {
                     const refGroup = selectedGroup.referenceGroup
                         ? this.getPanel(selectedGroup.referenceGroup)
                         : undefined;
-                    if (refGroup && refGroup.panels.length === 0) {
+                    if ((refGroup === null || refGroup === void 0 ? void 0 : refGroup.panels.length) === 0) {
                         this.removeGroup(refGroup);
                     }
                 }
@@ -2974,9 +2986,7 @@ export class DockviewComponent extends BaseGrid {
         return id;
     }
     createGroup(options) {
-        if (!options) {
-            options = {};
-        }
+        options !== null && options !== void 0 ? options : (options = {});
         let id = options === null || options === void 0 ? void 0 : options.id;
         if (id && this._groups.has(options.id)) {
             console.warn(`dockview: Duplicate group id ${options === null || options === void 0 ? void 0 : options.id}. reassigning group id to avoid errors`);
@@ -3172,13 +3182,13 @@ export class DockviewComponent extends BaseGrid {
             entry.gridview.margin = gap;
         }
         (_f = this._shellManager) === null || _f === void 0 ? void 0 : _f.updateTheme(gap, (_g = theme.edgeGroupCollapsedSize) !== null && _g !== void 0 ? _g : 35);
-        if (theme.dndOverlayBorder !== undefined) {
-            this.element.style.setProperty('--dv-drag-over-border', theme.dndOverlayBorder);
-            (_h = this._shellManager) === null || _h === void 0 ? void 0 : _h.element.style.setProperty('--dv-drag-over-border', theme.dndOverlayBorder);
+        if (theme.dndOverlayBorder === undefined) {
+            this.element.style.removeProperty('--dv-drag-over-border');
+            (_h = this._shellManager) === null || _h === void 0 ? void 0 : _h.element.style.removeProperty('--dv-drag-over-border');
         }
         else {
-            this.element.style.removeProperty('--dv-drag-over-border');
-            (_j = this._shellManager) === null || _j === void 0 ? void 0 : _j.element.style.removeProperty('--dv-drag-over-border');
+            this.element.style.setProperty('--dv-drag-over-border', theme.dndOverlayBorder);
+            (_j = this._shellManager) === null || _j === void 0 ? void 0 : _j.element.style.setProperty('--dv-drag-over-border', theme.dndOverlayBorder);
         }
         switch (theme.dndOverlayMounting) {
             case 'absolute':

package/dist/esm/dockview/dockviewGroupPanel.d.ts

@@ -13,7 +13,7 @@ export interface IDockviewGroupPanel extends IGridviewPanel<DockviewGroupPanelAp
 }
 export declare class DockviewGroupPanel extends GridviewPanel<DockviewGroupPanelApiImpl> implements IDockviewGroupPanel {
     private readonly _model;
-    private _explicitConstraints;
+    private readonly _explicitConstraints;
     get minimumWidth(): number;
     get minimumHeight(): number;
     get maximumWidth(): number;

package/dist/esm/dockview/dockviewGroupPanelModel.js

@@ -389,7 +389,7 @@ export class DockviewGroupPanelModel extends CompositeDisposable {
         }
         // Remove from any existing group first
         const existingGroup = this.getTabGroupForPanel(panelId);
-        if (existingGroup && existingGroup.id === tabGroupId) {
+        if ((existingGroup === null || existingGroup === void 0 ? void 0 : existingGroup.id) === tabGroupId) {
             return; // already in this group — no mutation
         }
         this._bracketTabGroupMutation(() => {
@@ -410,7 +410,7 @@ export class DockviewGroupPanelModel extends CompositeDisposable {
      */
     movePanelWithinGroup(tabGroupId, panelId, newIndex) {
         const tabGroup = this._tabGroupMap.get(tabGroupId);
-        if (!tabGroup || !tabGroup.containsPanel(panelId)) {
+        if (!(tabGroup === null || tabGroup === void 0 ? void 0 : tabGroup.containsPanel(panelId))) {
             return;
         }
         // Remove and re-add at new index within the group
@@ -623,7 +623,7 @@ export class DockviewGroupPanelModel extends CompositeDisposable {
         for (let i = activePanelIndex + 1; i < this._panels.length; i++) {
             const candidate = this._panels[i];
             const candidateGroup = this._findTabGroupForPanel(candidate.id);
-            if (!candidateGroup || !candidateGroup.collapsed) {
+            if (!(candidateGroup === null || candidateGroup === void 0 ? void 0 : candidateGroup.collapsed)) {
                 this.doSetActivePanel(candidate);
                 this.updateContainer();
                 return;
@@ -632,7 +632,7 @@ export class DockviewGroupPanelModel extends CompositeDisposable {
         for (let i = activePanelIndex - 1; i >= 0; i--) {
             const candidate = this._panels[i];
             const candidateGroup = this._findTabGroupForPanel(candidate.id);
-            if (!candidateGroup || !candidateGroup.collapsed) {
+            if (!(candidateGroup === null || candidateGroup === void 0 ? void 0 : candidateGroup.collapsed)) {
                 this.doSetActivePanel(candidate);
                 this.updateContainer();
                 return;
@@ -662,9 +662,9 @@ export class DockviewGroupPanelModel extends CompositeDisposable {
     restoreTabGroups(serializedGroups) {
         // Bump counter past any restored numeric suffixes to avoid ID collisions
         for (const data of serializedGroups) {
-            const match = data.id.match(/-(\d+)$/);
+            const match = /-(\d+)$/.exec(data.id);
             if (match) {
-                const num = parseInt(match[1], 10) + 1;
+                const num = Number.parseInt(match[1], 10) + 1;
                 if (num > this._tabGroupIdCounter) {
                     this._tabGroupIdCounter = num;
                 }
@@ -781,32 +781,26 @@ export class DockviewGroupPanelModel extends CompositeDisposable {
         return result;
     }
     moveToNext(options) {
-        if (!options) {
-            options = {};
-        }
-        if (!options.panel) {
-            options.panel = this.activePanel;
-        }
+        var _a;
+        options !== null && options !== void 0 ? options : (options = {});
+        (_a = options.panel) !== null && _a !== void 0 ? _a : (options.panel = this.activePanel);
         const index = options.panel ? this.panels.indexOf(options.panel) : -1;
         let normalizedIndex;
         if (index < this.panels.length - 1) {
             normalizedIndex = index + 1;
         }
-        else if (!options.suppressRoll) {
-            normalizedIndex = 0;
+        else if (options.suppressRoll) {
+            return;
         }
         else {
-            return;
+            normalizedIndex = 0;
         }
         this.openPanel(this.panels[normalizedIndex]);
     }
     moveToPrevious(options) {
-        if (!options) {
-            options = {};
-        }
-        if (!options.panel) {
-            options.panel = this.activePanel;
-        }
+        var _a;
+        options !== null && options !== void 0 ? options : (options = {});
+        (_a = options.panel) !== null && _a !== void 0 ? _a : (options.panel = this.activePanel);
         if (!options.panel) {
             return;
         }
@@ -815,11 +809,11 @@ export class DockviewGroupPanelModel extends CompositeDisposable {
         if (index > 0) {
             normalizedIndex = index - 1;
         }
-        else if (!options.suppressRoll) {
-            normalizedIndex = this.panels.length - 1;
+        else if (options.suppressRoll) {
+            return;
         }
         else {
-            return;
+            normalizedIndex = this.panels.length - 1;
         }
         this.openPanel(this.panels[normalizedIndex]);
     }
@@ -919,7 +913,7 @@ export class DockviewGroupPanelModel extends CompositeDisposable {
         if (!this._activePanel && this.panels.length > 0) {
             const candidate = this._panels.find((p) => {
                 const tg = this._findTabGroupForPanel(p.id);
-                return !tg || !tg.collapsed;
+                return !(tg === null || tg === void 0 ? void 0 : tg.collapsed);
             });
             if (candidate) {
                 this.doSetActivePanel(candidate);

package/dist/esm/dockview/dockviewPanel.js

@@ -103,9 +103,8 @@ export class DockviewPanel extends CompositeDisposable {
         }
     }
     update(event) {
-        var _a;
         // merge the new parameters with the existing parameters
-        this._params = Object.assign(Object.assign({}, ((_a = this._params) !== null && _a !== void 0 ? _a : {})), event.params);
+        this._params = Object.assign(Object.assign({}, this._params), event.params);
         /**
          * delete new keys that have a value of undefined,
          * allow values of null

package/dist/esm/dockview/dockviewShell.d.ts

@@ -56,16 +56,37 @@ export declare class EdgeGroupView implements IView {
     readonly priority = LayoutPriority.Low;
     private _isCollapsed;
     private _lastExpandedSize;
-    private _collapsedSize;
-    private _expandedMinimumSize;
+    private _baseCollapsedSize;
+    private _baseMinimumSize;
+    private _gapAdd;
     private readonly _expandedMaximumSize;
+    private _measuredTabSize;
+    private readonly _tabSizeDisposables;
+    /**
+     * The effective (pre-gap) collapsed size: the measured tab-strip size when
+     * available, otherwise the configured/theme base.
+     */
+    private get _effectiveBaseCollapsed();
     get minimumSize(): number;
     get maximumSize(): number;
     get element(): HTMLElement;
     get isCollapsed(): boolean;
     get lastExpandedSize(): number;
     get collapsedSize(): number;
-    constructor(options: EdgeGroupOptions, group: IEdgeGroupHost, orientation: 'horizontal' | 'vertical');
+    constructor(options: EdgeGroupOptions, group: IEdgeGroupHost, orientation: 'horizontal' | 'vertical', gapAdd?: number);
+    /**
+     * Watch the group's tab strip so the collapsed size follows the live tab
+     * height. The strip's cross-axis size (height for top/bottom, width for
+     * left/right) is exactly what a collapsed edge group should occupy; a
+     * ResizeObserver keeps them in sync when the tab height changes at runtime.
+     */
+    private _observeTabStrip;
+    /**
+     * Apply a freshly-measured tab-strip cross size. When the group is
+     * collapsed this resizes it in the parent splitview so the collapsed strip
+     * always shows the full tab height.
+     */
+    private _applyMeasuredTabSize;
     layout(size: number, orthogonalSize: number): void;
     setCollapsed(collapsed: boolean): void;
     setVisible(_visible: boolean): void;
@@ -76,11 +97,12 @@ export declare class EdgeGroupView implements IView {
      */
     restoreExpandedSize(size: number): void;
     /**
-     * Apply new effective collapsed and expanded-minimum sizes after a theme
-     * or gap change. The caller (ShellManager) is responsible for computing
-     * the correct values from the original config and the new gap.
+     * Apply a new base (pre-gap) collapsed size, base minimum size and gap
+     * contribution after a theme or gap change. Base values come from the
+     * original config; the ShellManager owns the gap arithmetic. A live
+     * measured tab size (if any) continues to win over the base collapsed size.
      */
-    updateCollapsedSize(newCollapsedSize: number, newExpandedMinimumSize: number): void;
+    updateSizing(baseCollapsedSize: number, baseMinimumSize: number | undefined, gapAdd: number): void;
     dispose(): void;
 }
 export declare class ShellManager implements IDisposable {