discord-agent-bridge 0.1.0

package/dist/discord/alwaysAllow.test.js

@@ -0,0 +1,181 @@
+import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import * as fs from 'node:fs';
+import * as os from 'node:os';
+import * as path from 'node:path';
+import { SessionWiring } from './wiring.js';
+import { EventBus } from '../core/eventBus.js';
+import { ModeRegistry } from '../core/modeRegistry.js';
+import { createLogger } from '../core/logger.js';
+import { ConfigStore } from '../core/config.js';
+import { CONFIG_DEFAULTS, CONFIG_VERSION } from '../core/configSchema.js';
+import { parseCustomId } from './renderers/permissionButtons.js';
+import { makeCanUseTool } from '../modes/claude/permissions.js';
+// Always-allow persistence (§7A): when a permission button resolves as "always",
+// the wiring persists the tool into the GLOBAL autoAllowClaudeTools set via the
+// ConfigStore, so a subsequent turn's canUseTool auto-allows it without prompting.
+const logger = createLogger('test', { level: 'error', sink: { write() { } } });
+const CLAUDE_CAPS = {
+    streaming: true,
+    thinking: true,
+    toolThreads: true,
+    permissionPrompts: true,
+    progress: false,
+    transcript: false,
+    sessionResume: true,
+    fileAttach: true,
+    fileDiff: true,
+    usagePanel: true,
+    permissionModes: ['default', 'acceptEdits', 'bypassPermissions', 'plan'],
+};
+class StubMode {
+    name = 'claude';
+    capabilities = CLAUDE_CAPS;
+    async start(_ctx) {
+        return { sessionId: 's', async send() { }, async stop() { } };
+    }
+    async resume(_ctx, id) {
+        return { sessionId: id, async send() { }, async stop() { } };
+    }
+}
+function fakeChannel() {
+    const sent = [];
+    const channel = {
+        send: async (message) => {
+            sent.push(message);
+            return { id: `m${sent.length}`, async edit() { } };
+        },
+        startThread: async () => {
+            throw new Error('not used');
+        },
+    };
+    return { channel, sent };
+}
+function reqIdFromSent(sent) {
+    for (const m of sent) {
+        for (const row of m.components ?? []) {
+            for (const c of row.components) {
+                if (c.type === 'button') {
+                    const parsed = parseCustomId(c.customId);
+                    if (parsed)
+                        return parsed.reqId;
+                }
+            }
+        }
+    }
+    return null;
+}
+function makeConfig() {
+    return {
+        ...CONFIG_DEFAULTS,
+        version: CONFIG_VERSION,
+        discord: { token: 'fake-token', clientId: 'client-000' },
+    };
+}
+// A minimal ModeContext whose config.autoAllowClaudeTools comes from the persisted
+// config — mirroring how the orchestrator threads the resolved allowlist onto ctx.
+function ctxWithAllowlist(tools) {
+    return {
+        guildId: 'g1',
+        channelId: 'c1',
+        cwd: '/tmp/ws',
+        ownerId: 'owner',
+        permMode: 'default',
+        emit: () => { },
+        requestPermission: async () => ({ behavior: 'deny' }),
+        config: { autoAllowClaudeTools: tools },
+        logger,
+        audit: () => { },
+    };
+}
+describe('always-allow persistence', () => {
+    let dir;
+    let store;
+    beforeEach(() => {
+        dir = fs.mkdtempSync(path.join(os.tmpdir(), 'dab-allow-'));
+        store = new ConfigStore(dir);
+        store.save(makeConfig());
+    });
+    afterEach(() => {
+        fs.rmSync(dir, { recursive: true, force: true });
+    });
+    function makeWiring(channel) {
+        const modeRegistry = new ModeRegistry();
+        modeRegistry.register(new StubMode());
+        const channelRegistry = { get: () => ({ ownerId: 'owner' }) };
+        const usageService = {
+            isAvailable: () => false,
+            getUsage: async () => ({ available: false, reason: 'no-credentials' }),
+        };
+        return new SessionWiring({
+            eventBus: new EventBus(),
+            modeRegistry,
+            channelRegistry,
+            usageService,
+            logger,
+            resolveChannel: async () => channel,
+            permissionTimeoutSec: 60,
+            onAlwaysAllow: (tool) => {
+                store.addAutoAllowClaudeTool(tool);
+            },
+        });
+    }
+    it('persists the tool into the config auto-allow set on an Always button', async () => {
+        const { channel, sent } = fakeChannel();
+        const wiring = makeWiring(channel);
+        await wiring.attach('g1', 'c1', 'claude');
+        const decisionP = wiring.requestPermission({ guildId: 'g1', channelId: 'c1', ownerId: 'owner' }, { toolName: 'Bash', input: { command: 'ls' } });
+        await Promise.resolve();
+        await Promise.resolve();
+        const reqId = reqIdFromSent(sent);
+        // Bash is NOT in the default auto-allow set yet.
+        expect(store.load().autoAllowClaudeTools).not.toContain('Bash');
+        await wiring.resolvePermission('g1', 'c1', `perm:${reqId}:always`);
+        const decision = await decisionP;
+        expect(decision.behavior).toBe('allow');
+        // The always-allow was persisted globally.
+        expect(store.load().autoAllowClaudeTools).toContain('Bash');
+    });
+    it('a subsequent turn auto-allows the persisted tool without prompting', async () => {
+        const { channel, sent } = fakeChannel();
+        const wiring = makeWiring(channel);
+        await wiring.attach('g1', 'c1', 'claude');
+        const decisionP = wiring.requestPermission({ guildId: 'g1', channelId: 'c1', ownerId: 'owner' }, { toolName: 'Bash', input: {} });
+        await Promise.resolve();
+        await Promise.resolve();
+        const reqId = reqIdFromSent(sent);
+        await wiring.resolvePermission('g1', 'c1', `perm:${reqId}:always`);
+        await decisionP;
+        // Rebuild the resolved allowlist the way the orchestrator would on the NEXT turn
+        // (PermissionResolver seeds allowedTools from config.autoAllowClaudeTools).
+        const persisted = store.load().autoAllowClaudeTools;
+        const canUse = makeCanUseTool(ctxWithAllowlist(persisted));
+        let prompted = false;
+        const ctxProbe = ctxWithAllowlist(persisted);
+        ctxProbe.requestPermission = async () => {
+            prompted = true;
+            return { behavior: 'deny' };
+        };
+        const result = await makeCanUseTool(ctxProbe)('Bash', { command: 'ls' }, {
+            signal: new AbortController().signal,
+            toolUseID: 'tu-1',
+        });
+        expect(result.behavior).toBe('allow');
+        expect(prompted).toBe(false);
+        // sanity: canUse built from the same allowlist also allows.
+        const r2 = await canUse('Bash', {}, { signal: new AbortController().signal, toolUseID: 'tu-2' });
+        expect(r2.behavior).toBe('allow');
+    });
+    it('a plain Allow (not Always) does NOT persist the tool', async () => {
+        const { channel, sent } = fakeChannel();
+        const wiring = makeWiring(channel);
+        await wiring.attach('g1', 'c1', 'claude');
+        const decisionP = wiring.requestPermission({ guildId: 'g1', channelId: 'c1', ownerId: 'owner' }, { toolName: 'Bash', input: {} });
+        await Promise.resolve();
+        await Promise.resolve();
+        const reqId = reqIdFromSent(sent);
+        await wiring.resolvePermission('g1', 'c1', `perm:${reqId}:allow`);
+        await decisionP;
+        expect(store.load().autoAllowClaudeTools).not.toContain('Bash');
+    });
+});
+//# sourceMappingURL=alwaysAllow.test.js.map

package/dist/discord/alwaysAllow.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"alwaysAllow.test.js","sourceRoot":"","sources":["../../src/discord/alwaysAllow.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,UAAU,EAAE,SAAS,EAAE,MAAM,QAAQ,CAAC;AACrE,OAAO,KAAK,EAAE,MAAM,SAAS,CAAC;AAC9B,OAAO,KAAK,EAAE,MAAM,SAAS,CAAC;AAC9B,OAAO,KAAK,IAAI,MAAM,WAAW,CAAC;AAClC,OAAO,EAAE,aAAa,EAAE,MAAM,aAAa,CAAC;AAC5C,OAAO,EAAE,QAAQ,EAAE,MAAM,qBAAqB,CAAC;AAC/C,OAAO,EAAE,YAAY,EAAE,MAAM,yBAAyB,CAAC;AACvD,OAAO,EAAE,YAAY,EAAE,MAAM,mBAAmB,CAAC;AACjD,OAAO,EAAE,WAAW,EAAE,MAAM,mBAAmB,CAAC;AAChD,OAAO,EAAE,eAAe,EAAE,cAAc,EAAkB,MAAM,yBAAyB,CAAC;AAC1F,OAAO,EAAE,aAAa,EAAE,MAAM,kCAAkC,CAAC;AACjE,OAAO,EAAE,cAAc,EAAE,MAAM,gCAAgC,CAAC;AAYhE,iFAAiF;AACjF,gFAAgF;AAChF,mFAAmF;AAEnF,MAAM,MAAM,GAAG,YAAY,CAAC,MAAM,EAAE,EAAE,KAAK,EAAE,OAAO,EAAE,IAAI,EAAE,EAAE,KAAK,KAAI,CAAC,EAAE,EAAE,CAAC,CAAC;AAE9E,MAAM,WAAW,GAAiB;IAChC,SAAS,EAAE,IAAI;IACf,QAAQ,EAAE,IAAI;IACd,WAAW,EAAE,IAAI;IACjB,iBAAiB,EAAE,IAAI;IACvB,QAAQ,EAAE,KAAK;IACf,UAAU,EAAE,KAAK;IACjB,aAAa,EAAE,IAAI;IACnB,UAAU,EAAE,IAAI;IAChB,QAAQ,EAAE,IAAI;IACd,UAAU,EAAE,IAAI;IAChB,eAAe,EAAE,CAAC,SAAS,EAAE,aAAa,EAAE,mBAAmB,EAAE,MAAM,CAAC;CACzE,CAAC;AAEF,MAAM,QAAQ;IACH,IAAI,GAAG,QAAQ,CAAC;IAChB,YAAY,GAAG,WAAW,CAAC;IACpC,KAAK,CAAC,KAAK,CAAC,IAAiB;QAC3B,OAAO,EAAE,SAAS,EAAE,GAAG,EAAE,KAAK,CAAC,IAAI,KAAI,CAAC,EAAE,KAAK,CAAC,IAAI,KAAI,CAAC,EAAE,CAAC;IAC9D,CAAC;IACD,KAAK,CAAC,MAAM,CAAC,IAAiB,EAAE,EAAU;QACxC,OAAO,EAAE,SAAS,EAAE,EAAE,EAAE,KAAK,CAAC,IAAI,KAAI,CAAC,EAAE,KAAK,CAAC,IAAI,KAAI,CAAC,EAAE,CAAC;IAC7D,CAAC;CACF;AAED,SAAS,WAAW;IAClB,MAAM,IAAI,GAAsB,EAAE,CAAC;IACnC,MAAM,OAAO,GAAmB;QAC9B,IAAI,EAAE,KAAK,EAAE,OAAwB,EAA4B,EAAE;YACjE,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;YACnB,OAAO,EAAE,EAAE,EAAE,IAAI,IAAI,CAAC,MAAM,EAAE,EAAE,KAAK,CAAC,IAAI,KAAI,CAAC,EAAE,CAAC;QACpD,CAAC;QACD,WAAW,EAAE,KAAK,IAAI,EAAE;YACtB,MAAM,IAAI,KAAK,CAAC,UAAU,CAAC,CAAC;QAC9B,CAAC;KACF,CAAC;IACF,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;AAC3B,CAAC;AAED,SAAS,aAAa,CAAC,IAAuB;IAC5C,KAAK,MAAM,CAAC,IAAI,IAAI,EAAE,CAAC;QACrB,KAAK,MAAM,GAAG,IAAI,CAAC,CAAC,UAAU,IAAI,EAAE,EAAE,CAAC;YACrC,KAAK,MAAM,CAAC,IAAI,GAAG,CAAC,UAAU,EAAE,CAAC;gBAC/B,IAAI,CAAC,CAAC,IAAI,KAAK,QAAQ,EAAE,CAAC;oBACxB,MAAM,MAAM,GAAG,aAAa,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC;oBACzC,IAAI,MAAM;wBAAE,OAAO,MAAM,CAAC,KAAK,CAAC;gBAClC,CAAC;YACH,CAAC;QACH,CAAC;IACH,CAAC;IACD,OAAO,IAAI,CAAC;AACd,CAAC;AAED,SAAS,UAAU;IACjB,OAAO;QACL,GAAG,eAAe;QAClB,OAAO,EAAE,cAAc;QACvB,OAAO,EAAE,EAAE,KAAK,EAAE,YAAY,EAAE,QAAQ,EAAE,YAAY,EAAE;KAC5C,CAAC;AACjB,CAAC;AAED,mFAAmF;AACnF,mFAAmF;AACnF,SAAS,gBAAgB,CAAC,KAAe;IACvC,OAAO;QACL,OAAO,EAAE,IAAI;QACb,SAAS,EAAE,IAAI;QACf,GAAG,EAAE,SAAS;QACd,OAAO,EAAE,OAAO;QAChB,QAAQ,EAAE,SAAS;QACnB,IAAI,EAAE,GAAG,EAAE,GAAE,CAAC;QACd,iBAAiB,EAAE,KAAK,IAAI,EAAE,CAAC,CAAC,EAAE,QAAQ,EAAE,MAAM,EAAE,CAAuB;QAC3E,MAAM,EAAE,EAAE,oBAAoB,EAAE,KAAK,EAAE;QACvC,MAAM;QACN,KAAK,EAAE,GAAG,EAAE,GAAE,CAAC;KAChB,CAAC;AACJ,CAAC;AAED,QAAQ,CAAC,0BAA0B,EAAE,GAAG,EAAE;IACxC,IAAI,GAAW,CAAC;IAChB,IAAI,KAAkB,CAAC;IAEvB,UAAU,CAAC,GAAG,EAAE;QACd,GAAG,GAAG,EAAE,CAAC,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,MAAM,EAAE,EAAE,YAAY,CAAC,CAAC,CAAC;QAC3D,KAAK,GAAG,IAAI,WAAW,CAAC,GAAG,CAAC,CAAC;QAC7B,KAAK,CAAC,IAAI,CAAC,UAAU,EAAE,CAAC,CAAC;IAC3B,CAAC,CAAC,CAAC;IACH,SAAS,CAAC,GAAG,EAAE;QACb,EAAE,CAAC,MAAM,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;IACnD,CAAC,CAAC,CAAC;IAEH,SAAS,UAAU,CAAC,OAAuB;QACzC,MAAM,YAAY,GAAG,IAAI,YAAY,EAAE,CAAC;QACxC,YAAY,CAAC,QAAQ,CAAC,IAAI,QAAQ,EAAE,CAAC,CAAC;QACtC,MAAM,eAAe,GAAG,EAAE,GAAG,EAAE,GAAG,EAAE,CAAC,CAAC,EAAE,OAAO,EAAE,OAAO,EAAE,CAAC,EAAgC,CAAC;QAC5F,MAAM,YAAY,GAAG;YACnB,WAAW,EAAE,GAAG,EAAE,CAAC,KAAK;YACxB,QAAQ,EAAE,KAAK,IAAI,EAAE,CAAC,CAAC,EAAE,SAAS,EAAE,KAAc,EAAE,MAAM,EAAE,gBAAyB,EAAE,CAAC;SAC9D,CAAC;QAC7B,OAAO,IAAI,aAAa,CAAC;YACvB,QAAQ,EAAE,IAAI,QAAQ,EAAE;YACxB,YAAY;YACZ,eAAe;YACf,YAAY;YACZ,MAAM;YACN,cAAc,EAAE,KAAK,IAAI,EAAE,CAAC,OAAO;YACnC,oBAAoB,EAAE,EAAE;YACxB,aAAa,EAAE,CAAC,IAAI,EAAE,EAAE;gBACtB,KAAK,CAAC,sBAAsB,CAAC,IAAI,CAAC,CAAC;YACrC,CAAC;SACF,CAAC,CAAC;IACL,CAAC;IAED,EAAE,CAAC,sEAAsE,EAAE,KAAK,IAAI,EAAE;QACpF,MAAM,EAAE,OAAO,EAAE,IAAI,EAAE,GAAG,WAAW,EAAE,CAAC;QACxC,MAAM,MAAM,GAAG,UAAU,CAAC,OAAO,CAAC,CAAC;QACnC,MAAM,MAAM,CAAC,MAAM,CAAC,IAAI,EAAE,IAAI,EAAE,QAAQ,CAAC,CAAC;QAE1C,MAAM,SAAS,GAAG,MAAM,CAAC,iBAAiB,CACxC,EAAE,OAAO,EAAE,IAAI,EAAE,SAAS,EAAE,IAAI,EAAE,OAAO,EAAE,OAAO,EAAE,EACpD,EAAE,QAAQ,EAAE,MAAM,EAAE,KAAK,EAAE,EAAE,OAAO,EAAE,IAAI,EAAE,EAAE,CAC/C,CAAC;QACF,MAAM,OAAO,CAAC,OAAO,EAAE,CAAC;QACxB,MAAM,OAAO,CAAC,OAAO,EAAE,CAAC;QACxB,MAAM,KAAK,GAAG,aAAa,CAAC,IAAI,CAAE,CAAC;QAEnC,iDAAiD;QACjD,MAAM,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;QAEhE,MAAM,MAAM,CAAC,iBAAiB,CAAC,IAAI,EAAE,IAAI,EAAE,QAAQ,KAAK,SAAS,CAAC,CAAC;QACnE,MAAM,QAAQ,GAAG,MAAM,SAAS,CAAC;QACjC,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QAExC,2CAA2C;QAC3C,MAAM,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;IAC9D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oEAAoE,EAAE,KAAK,IAAI,EAAE;QAClF,MAAM,EAAE,OAAO,EAAE,IAAI,EAAE,GAAG,WAAW,EAAE,CAAC;QACxC,MAAM,MAAM,GAAG,UAAU,CAAC,OAAO,CAAC,CAAC;QACnC,MAAM,MAAM,CAAC,MAAM,CAAC,IAAI,EAAE,IAAI,EAAE,QAAQ,CAAC,CAAC;QAE1C,MAAM,SAAS,GAAG,MAAM,CAAC,iBAAiB,CACxC,EAAE,OAAO,EAAE,IAAI,EAAE,SAAS,EAAE,IAAI,EAAE,OAAO,EAAE,OAAO,EAAE,EACpD,EAAE,QAAQ,EAAE,MAAM,EAAE,KAAK,EAAE,EAAE,EAAE,CAChC,CAAC;QACF,MAAM,OAAO,CAAC,OAAO,EAAE,CAAC;QACxB,MAAM,OAAO,CAAC,OAAO,EAAE,CAAC;QACxB,MAAM,KAAK,GAAG,aAAa,CAAC,IAAI,CAAE,CAAC;QACnC,MAAM,MAAM,CAAC,iBAAiB,CAAC,IAAI,EAAE,IAAI,EAAE,QAAQ,KAAK,SAAS,CAAC,CAAC;QACnE,MAAM,SAAS,CAAC;QAEhB,iFAAiF;QACjF,4EAA4E;QAC5E,MAAM,SAAS,GAAG,KAAK,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC;QACpD,MAAM,MAAM,GAAG,cAAc,CAAC,gBAAgB,CAAC,SAAS,CAAC,CAAC,CAAC;QAC3D,IAAI,QAAQ,GAAG,KAAK,CAAC;QACrB,MAAM,QAAQ,GAAG,gBAAgB,CAAC,SAAS,CAAC,CAAC;QAC7C,QAAQ,CAAC,iBAAiB,GAAG,KAAK,IAAI,EAAE;YACtC,QAAQ,GAAG,IAAI,CAAC;YAChB,OAAO,EAAE,QAAQ,EAAE,MAAM,EAAE,CAAC;QAC9B,CAAC,CAAC;QACF,MAAM,MAAM,GAAG,MAAM,cAAc,CAAC,QAAQ,CAAC,CAAC,MAAM,EAAE,EAAE,OAAO,EAAE,IAAI,EAAE,EAAE;YACvE,MAAM,EAAE,IAAI,eAAe,EAAE,CAAC,MAAM;YACpC,SAAS,EAAE,MAAM;SAClB,CAAC,CAAC;QACH,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QACtC,MAAM,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAC7B,4DAA4D;QAC5D,MAAM,EAAE,GAAG,MAAM,MAAM,CAAC,MAAM,EAAE,EAAE,EAAE,EAAE,MAAM,EAAE,IAAI,eAAe,EAAE,CAAC,MAAM,EAAE,SAAS,EAAE,MAAM,EAAE,CAAC,CAAC;QACjG,MAAM,CAAC,EAAE,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IACpC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sDAAsD,EAAE,KAAK,IAAI,EAAE;QACpE,MAAM,EAAE,OAAO,EAAE,IAAI,EAAE,GAAG,WAAW,EAAE,CAAC;QACxC,MAAM,MAAM,GAAG,UAAU,CAAC,OAAO,CAAC,CAAC;QACnC,MAAM,MAAM,CAAC,MAAM,CAAC,IAAI,EAAE,IAAI,EAAE,QAAQ,CAAC,CAAC;QAE1C,MAAM,SAAS,GAAG,MAAM,CAAC,iBAAiB,CACxC,EAAE,OAAO,EAAE,IAAI,EAAE,SAAS,EAAE,IAAI,EAAE,OAAO,EAAE,OAAO,EAAE,EACpD,EAAE,QAAQ,EAAE,MAAM,EAAE,KAAK,EAAE,EAAE,EAAE,CAChC,CAAC;QACF,MAAM,OAAO,CAAC,OAAO,EAAE,CAAC;QACxB,MAAM,OAAO,CAAC,OAAO,EAAE,CAAC;QACxB,MAAM,KAAK,GAAG,aAAa,CAAC,IAAI,CAAE,CAAC;QACnC,MAAM,MAAM,CAAC,iBAAiB,CAAC,IAAI,EAAE,IAAI,EAAE,QAAQ,KAAK,QAAQ,CAAC,CAAC;QAClE,MAAM,SAAS,CAAC;QAEhB,MAAM,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;IAClE,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}