digital-tools 2.1.1 → 2.3.0

package/src/providers/ecommerce/shopify.ts

@@ -24,6 +24,118 @@ import { defineProvider } from '../registry.js'
 
 const API_VERSION = '2023-10'
 
+// =============================================================================
+// Shopify API Response Types
+// =============================================================================
+
+/** Shopify API error response */
+interface ShopifyErrorResponse {
+  errors?: string | Record<string, string[]>
+}
+
+/** Shopify product image from API */
+interface ShopifyImage {
+  id: number
+  src: string
+}
+
+/** Shopify product variant from API */
+interface ShopifyVariant {
+  id: number
+  title: string
+  price: string
+  sku?: string
+  inventory_quantity: number
+  compare_at_price?: string | null
+  inventory_item_id: number
+}
+
+/** Shopify product from API */
+interface ShopifyProduct {
+  id: number
+  title: string
+  body_html?: string
+  vendor?: string
+  product_type?: string
+  tags?: string
+  status?: string
+  variants?: ShopifyVariant[]
+  images?: ShopifyImage[]
+  admin_graphql_api_id?: string
+  created_at: string
+  updated_at: string
+}
+
+/** Shopify address from API */
+interface ShopifyAddress {
+  first_name?: string
+  last_name?: string
+  address1?: string
+  address2?: string
+  city?: string
+  province?: string
+  zip?: string
+  country?: string
+  phone?: string
+}
+
+/** Shopify line item from API */
+interface ShopifyLineItem {
+  product_id?: number
+  variant_id?: number
+  title: string
+  quantity: number
+  price: string
+}
+
+/** Shopify customer reference from API */
+interface ShopifyOrderCustomer {
+  id?: number
+  email?: string
+}
+
+/** Shopify order from API */
+interface ShopifyOrder {
+  id: number
+  name?: string
+  order_number?: number
+  cancelled_at?: string | null
+  closed_at?: string | null
+  financial_status?: string
+  fulfillment_status?: string | null
+  customer?: ShopifyOrderCustomer
+  email?: string
+  line_items?: ShopifyLineItem[]
+  subtotal_price?: string
+  total_tax?: string
+  total_shipping_price_set?: { shop_money?: { amount?: string } }
+  total_price?: string
+  currency?: string
+  shipping_address?: ShopifyAddress
+  billing_address?: ShopifyAddress
+  created_at: string
+  updated_at: string
+}
+
+/** Shopify customer from API */
+interface ShopifyCustomer {
+  id: number
+  email?: string
+  first_name?: string
+  last_name?: string
+  phone?: string
+  orders_count?: number
+  total_spent?: string
+  created_at: string
+}
+
+/** Shopify inventory level from API */
+interface ShopifyInventoryLevel {
+  location_id: number
+  inventory_item_id: number
+  available: number
+}
+
 /**
  * Shopify provider info
  */
@@ -61,14 +173,18 @@ export function createShopifyProvider(config: ProviderConfig): EcommerceProvider
     const response = await fetch(`${baseUrl}${endpoint}`, {
       method,
       headers: getHeaders(),
-      body: body ? JSON.stringify(body) : undefined,
+      ...(body !== undefined && { body: JSON.stringify(body) }),
     })
 
     if (!response.ok) {
-      const errorData = await response.json().catch(() => ({}))
-      throw new Error(
-        `Shopify API error: ${response.status} - ${(errorData as any)?.errors || response.statusText}`
-      )
+      const errorData = (await response.json().catch(() => ({}))) as ShopifyErrorResponse
+      const errorMessage =
+        typeof errorData.errors === 'string'
+          ? errorData.errors
+          : errorData.errors
+          ? JSON.stringify(errorData.errors)
+          : response.statusText
+      throw new Error(`Shopify API error: ${response.status} - ${errorMessage}`)
     }
 
     return response.json() as Promise<T>
@@ -78,8 +194,8 @@ export function createShopifyProvider(config: ProviderConfig): EcommerceProvider
     info: shopifyInfo,
 
     async initialize(cfg: ProviderConfig): Promise<void> {
-      shopDomain = cfg.shopDomain as string
-      accessToken = cfg.accessToken as string
+      shopDomain = cfg['shopDomain'] as string
+      accessToken = cfg['accessToken'] as string
 
       if (!shopDomain) {
         throw new Error('Shopify shop domain is required')
@@ -122,13 +238,23 @@ export function createShopifyProvider(config: ProviderConfig): EcommerceProvider
     },
 
     async createProduct(product: CreateProductOptions): Promise<EcommerceProductData> {
-      const shopifyProduct: any = {
+      const shopifyProduct: {
+        title: string
+        body_html?: string
+        vendor: string
+        product_type: string
+        tags: string
+        status: string
+        variants: Array<{ title: string; price: string; sku?: string; inventory_quantity: number }>
+        images?: Array<{ src: string }>
+      } = {
         title: product.title,
-        body_html: product.description,
+        ...(product.description !== undefined && { body_html: product.description }),
         vendor: 'Default',
         product_type: '',
         tags: product.tags?.join(', ') || '',
         status: product.status || 'active',
+        variants: [],
       }
 
       // Add variants
@@ -136,7 +262,7 @@ export function createShopifyProvider(config: ProviderConfig): EcommerceProvider
         shopifyProduct.variants = product.variants.map((v) => ({
           title: v.title,
           price: v.price.toString(),
-          sku: v.sku,
+          ...(v.sku !== undefined && { sku: v.sku }),
           inventory_quantity: v.inventory || 0,
         }))
       } else {
@@ -145,7 +271,7 @@ export function createShopifyProvider(config: ProviderConfig): EcommerceProvider
           {
             title: 'Default Title',
             price: product.price.toString(),
-            sku: product.sku,
+            ...(product.sku !== undefined && { sku: product.sku }),
             inventory_quantity: product.inventory || 0,
           },
         ]
@@ -156,7 +282,7 @@ export function createShopifyProvider(config: ProviderConfig): EcommerceProvider
         shopifyProduct.images = product.images.map((url) => ({ src: url }))
       }
 
-      const response = await makeRequest<{ product: any }>('/products.json', 'POST', {
+      const response = await makeRequest<{ product: ShopifyProduct }>('/products.json', 'POST', {
         product: shopifyProduct,
       })
 
@@ -165,9 +291,12 @@ export function createShopifyProvider(config: ProviderConfig): EcommerceProvider
 
     async getProduct(productId: string): Promise<EcommerceProductData | null> {
       try {
-        const response = await makeRequest<{ product: any }>(`/products/${productId}.json`, 'GET')
+        const response = await makeRequest<{ product: ShopifyProduct }>(
+          `/products/${productId}.json`,
+          'GET'
+        )
         return mapShopifyProduct(response.product)
-      } catch (error) {
+      } catch {
         return null
       }
     },
@@ -176,7 +305,13 @@ export function createShopifyProvider(config: ProviderConfig): EcommerceProvider
       productId: string,
       updates: Partial<CreateProductOptions>
     ): Promise<EcommerceProductData> {
-      const shopifyUpdates: any = {}
+      const shopifyUpdates: {
+        title?: string
+        body_html?: string
+        tags?: string
+        status?: string
+        images?: Array<{ src: string }>
+      } = {}
 
       if (updates.title) shopifyUpdates.title = updates.title
       if (updates.description) shopifyUpdates.body_html = updates.description
@@ -188,9 +323,13 @@ export function createShopifyProvider(config: ProviderConfig): EcommerceProvider
         shopifyUpdates.images = updates.images.map((url) => ({ src: url }))
       }
 
-      const response = await makeRequest<{ product: any }>(`/products/${productId}.json`, 'PUT', {
-        product: shopifyUpdates,
-      })
+      const response = await makeRequest<{ product: ShopifyProduct }>(
+        `/products/${productId}.json`,
+        'PUT',
+        {
+          product: shopifyUpdates,
+        }
+      )
 
       return mapShopifyProduct(response.product)
     },
@@ -199,12 +338,14 @@ export function createShopifyProvider(config: ProviderConfig): EcommerceProvider
       try {
         await makeRequest(`/products/${productId}.json`, 'DELETE')
         return true
-      } catch (error) {
+      } catch {
         return false
       }
     },
 
-    async listProducts(options?: ProductListOptions): Promise<PaginatedResult<EcommerceProductData>> {
+    async listProducts(
+      options?: ProductListOptions
+    ): Promise<PaginatedResult<EcommerceProductData>> {
       const params = new URLSearchParams()
 
       if (options?.limit) params.append('limit', options.limit.toString())
@@ -215,20 +356,22 @@ export function createShopifyProvider(config: ProviderConfig): EcommerceProvider
       const queryString = params.toString()
       const endpoint = `/products.json${queryString ? `?${queryString}` : ''}`
 
-      const response = await makeRequest<{ products: any[] }>(endpoint, 'GET')
+      const response = await makeRequest<{ products: ShopifyProduct[] }>(endpoint, 'GET')
 
       return {
         items: response.products.map(mapShopifyProduct),
         hasMore: response.products.length === (options?.limit || 50),
-        total: undefined, // Shopify doesn't provide total count in products endpoint
       }
     },
 
     async getOrder(orderId: string): Promise<OrderData | null> {
       try {
-        const response = await makeRequest<{ order: any }>(`/orders/${orderId}.json`, 'GET')
+        const response = await makeRequest<{ order: ShopifyOrder }>(
+          `/orders/${orderId}.json`,
+          'GET'
+        )
         return mapShopifyOrder(response.order)
-      } catch (error) {
+      } catch {
         return null
       }
     },
@@ -239,8 +382,7 @@ export function createShopifyProvider(config: ProviderConfig): EcommerceProvider
       if (options?.limit) params.append('limit', options.limit.toString())
       if (options?.status) params.append('status', options.status)
       if (options?.financialStatus) params.append('financial_status', options.financialStatus)
-      if (options?.fulfillmentStatus)
-        params.append('fulfillment_status', options.fulfillmentStatus)
+      if (options?.fulfillmentStatus) params.append('fulfillment_status', options.fulfillmentStatus)
       if (options?.customerId) params.append('customer_id', options.customerId)
       if (options?.since) params.append('created_at_min', options.since.toISOString())
       if (options?.until) params.append('created_at_max', options.until.toISOString())
@@ -249,31 +391,37 @@ export function createShopifyProvider(config: ProviderConfig): EcommerceProvider
       const queryString = params.toString()
       const endpoint = `/orders.json${queryString ? `?${queryString}` : ''}`
 
-      const response = await makeRequest<{ orders: any[] }>(endpoint, 'GET')
+      const response = await makeRequest<{ orders: ShopifyOrder[] }>(endpoint, 'GET')
 
       return {
         items: response.orders.map(mapShopifyOrder),
         hasMore: response.orders.length === (options?.limit || 50),
-        total: undefined,
       }
     },
 
     async updateOrderStatus(orderId: string, status: string): Promise<OrderData> {
-      const response = await makeRequest<{ order: any }>(`/orders/${orderId}.json`, 'PUT', {
-        order: {
-          id: orderId,
-          tags: status,
-        },
-      })
+      const response = await makeRequest<{ order: ShopifyOrder }>(
+        `/orders/${orderId}.json`,
+        'PUT',
+        {
+          order: {
+            id: orderId,
+            tags: status,
+          },
+        }
+      )
 
       return mapShopifyOrder(response.order)
     },
 
     async getEcommerceCustomer(customerId: string): Promise<EcommerceCustomerData | null> {
       try {
-        const response = await makeRequest<{ customer: any }>(`/customers/${customerId}.json`, 'GET')
+        const response = await makeRequest<{ customer: ShopifyCustomer }>(
+          `/customers/${customerId}.json`,
+          'GET'
+        )
         return mapShopifyCustomer(response.customer)
-      } catch (error) {
+      } catch {
         return null
       }
     },
@@ -289,30 +437,29 @@ export function createShopifyProvider(config: ProviderConfig): EcommerceProvider
       const queryString = params.toString()
       const endpoint = `/customers.json${queryString ? `?${queryString}` : ''}`
 
-      const response = await makeRequest<{ customers: any[] }>(endpoint, 'GET')
+      const response = await makeRequest<{ customers: ShopifyCustomer[] }>(endpoint, 'GET')
 
       return {
         items: response.customers.map(mapShopifyCustomer),
         hasMore: response.customers.length === (options?.limit || 50),
-        total: undefined,
       }
     },
 
     async updateInventory(
-      productId: string,
+      _productId: string,
       variantId: string,
       quantity: number
     ): Promise<boolean> {
       try {
         // First get the inventory item ID from the variant
-        const variantResponse = await makeRequest<{ variant: any }>(
+        const variantResponse = await makeRequest<{ variant: ShopifyVariant }>(
           `/variants/${variantId}.json`,
           'GET'
         )
         const inventoryItemId = variantResponse.variant.inventory_item_id
 
         // Get inventory levels
-        const levelsResponse = await makeRequest<{ inventory_levels: any[] }>(
+        const levelsResponse = await makeRequest<{ inventory_levels: ShopifyInventoryLevel[] }>(
           `/inventory_levels.json?inventory_item_ids=${inventoryItemId}`,
           'GET'
         )
@@ -321,7 +468,11 @@ export function createShopifyProvider(config: ProviderConfig): EcommerceProvider
           throw new Error('No inventory levels found for this variant')
         }
 
-        const locationId = levelsResponse.inventory_levels[0].location_id
+        const firstLevel = levelsResponse.inventory_levels[0]
+        if (!firstLevel) {
+          throw new Error('No inventory levels found for this variant')
+        }
+        const locationId = firstLevel.location_id
 
         // Set the inventory level
         await makeRequest('/inventory_levels/set.json', 'POST', {
@@ -331,7 +482,7 @@ export function createShopifyProvider(config: ProviderConfig): EcommerceProvider
         })
 
         return true
-      } catch (error) {
+      } catch {
         return false
       }
     },
@@ -341,31 +492,33 @@ export function createShopifyProvider(config: ProviderConfig): EcommerceProvider
 /**
  * Map Shopify product to our format
  */
-function mapShopifyProduct(product: any): EcommerceProductData {
+function mapShopifyProduct(product: ShopifyProduct): EcommerceProductData {
   const firstVariant = product.variants?.[0]
 
   return {
     id: product.id.toString(),
     title: product.title,
-    description: product.body_html,
+    ...(product.body_html !== undefined && { description: product.body_html }),
     price: parseFloat(firstVariant?.price || '0'),
-    compareAtPrice: firstVariant?.compare_at_price
-      ? parseFloat(firstVariant.compare_at_price)
-      : undefined,
-    sku: firstVariant?.sku,
-    inventory: firstVariant?.inventory_quantity,
-    images: product.images?.map((img: any) => img.src) || [],
+    ...(firstVariant?.compare_at_price && {
+      compareAtPrice: parseFloat(firstVariant.compare_at_price),
+    }),
+    ...(firstVariant?.sku !== undefined && { sku: firstVariant.sku }),
+    ...(firstVariant?.inventory_quantity !== undefined && {
+      inventory: firstVariant.inventory_quantity,
+    }),
+    images: product.images?.map((img) => img.src) || [],
     variants:
-      product.variants?.map((v: any) => ({
+      product.variants?.map((v) => ({
         id: v.id.toString(),
         title: v.title,
         price: parseFloat(v.price),
-        sku: v.sku,
+        ...(v.sku !== undefined && { sku: v.sku }),
         inventory: v.inventory_quantity,
       })) || [],
     tags: product.tags ? product.tags.split(', ') : [],
-    status: product.status,
-    url: product.admin_graphql_api_id,
+    status: product.status || 'active',
+    ...(product.admin_graphql_api_id !== undefined && { url: product.admin_graphql_api_id }),
     createdAt: new Date(product.created_at),
     updatedAt: new Date(product.updated_at),
   }
@@ -374,19 +527,19 @@ function mapShopifyProduct(product: any): EcommerceProductData {
 /**
  * Map Shopify order to our format
  */
-function mapShopifyOrder(order: any): OrderData {
+function mapShopifyOrder(order: ShopifyOrder): OrderData {
   return {
     id: order.id.toString(),
-    orderNumber: order.name || order.order_number?.toString(),
+    orderNumber: order.name || order.order_number?.toString() || '',
     status: order.cancelled_at ? 'cancelled' : order.closed_at ? 'closed' : 'open',
-    financialStatus: order.financial_status,
+    financialStatus: order.financial_status || 'pending',
     fulfillmentStatus: order.fulfillment_status || 'unfulfilled',
-    customerId: order.customer?.id?.toString(),
+    ...(order.customer?.id !== undefined && { customerId: order.customer.id.toString() }),
     email: order.email || order.customer?.email || '',
     lineItems:
-      order.line_items?.map((item: any) => ({
+      order.line_items?.map((item) => ({
         productId: item.product_id?.toString() || '',
-        variantId: item.variant_id?.toString(),
+        ...(item.variant_id !== undefined && { variantId: item.variant_id.toString() }),
         title: item.title,
         quantity: item.quantity,
         price: parseFloat(item.price),
@@ -395,33 +548,41 @@ function mapShopifyOrder(order: any): OrderData {
     tax: parseFloat(order.total_tax || '0'),
     shipping: parseFloat(order.total_shipping_price_set?.shop_money?.amount || '0'),
     total: parseFloat(order.total_price || '0'),
-    currency: order.currency,
-    shippingAddress: order.shipping_address
-      ? {
-          firstName: order.shipping_address.first_name,
-          lastName: order.shipping_address.last_name,
-          address1: order.shipping_address.address1,
+    currency: order.currency || 'USD',
+    ...(order.shipping_address && {
+      shippingAddress: {
+        firstName: order.shipping_address.first_name || '',
+        lastName: order.shipping_address.last_name || '',
+        address1: order.shipping_address.address1 || '',
+        ...(order.shipping_address.address2 !== undefined && {
           address2: order.shipping_address.address2,
-          city: order.shipping_address.city,
+        }),
+        city: order.shipping_address.city || '',
+        ...(order.shipping_address.province !== undefined && {
           province: order.shipping_address.province,
-          postalCode: order.shipping_address.zip,
-          country: order.shipping_address.country,
-          phone: order.shipping_address.phone,
-        }
-      : undefined,
-    billingAddress: order.billing_address
-      ? {
-          firstName: order.billing_address.first_name,
-          lastName: order.billing_address.last_name,
-          address1: order.billing_address.address1,
+        }),
+        postalCode: order.shipping_address.zip || '',
+        country: order.shipping_address.country || '',
+        ...(order.shipping_address.phone !== undefined && { phone: order.shipping_address.phone }),
+      },
+    }),
+    ...(order.billing_address && {
+      billingAddress: {
+        firstName: order.billing_address.first_name || '',
+        lastName: order.billing_address.last_name || '',
+        address1: order.billing_address.address1 || '',
+        ...(order.billing_address.address2 !== undefined && {
           address2: order.billing_address.address2,
-          city: order.billing_address.city,
+        }),
+        city: order.billing_address.city || '',
+        ...(order.billing_address.province !== undefined && {
           province: order.billing_address.province,
-          postalCode: order.billing_address.zip,
-          country: order.billing_address.country,
-          phone: order.billing_address.phone,
-        }
-      : undefined,
+        }),
+        postalCode: order.billing_address.zip || '',
+        country: order.billing_address.country || '',
+        ...(order.billing_address.phone !== undefined && { phone: order.billing_address.phone }),
+      },
+    }),
     createdAt: new Date(order.created_at),
     updatedAt: new Date(order.updated_at),
   }
@@ -430,13 +591,13 @@ function mapShopifyOrder(order: any): OrderData {
 /**
  * Map Shopify customer to our format
  */
-function mapShopifyCustomer(customer: any): EcommerceCustomerData {
+function mapShopifyCustomer(customer: ShopifyCustomer): EcommerceCustomerData {
   return {
     id: customer.id.toString(),
-    email: customer.email,
-    firstName: customer.first_name,
-    lastName: customer.last_name,
-    phone: customer.phone,
+    email: customer.email || '',
+    ...(customer.first_name !== undefined && { firstName: customer.first_name }),
+    ...(customer.last_name !== undefined && { lastName: customer.last_name }),
+    ...(customer.phone !== undefined && { phone: customer.phone }),
     ordersCount: customer.orders_count || 0,
     totalSpent: parseFloat(customer.total_spent || '0'),
     createdAt: new Date(customer.created_at),