digital-tools 2.1.1 → 2.3.0

package/src/providers/development/github.ts

@@ -26,6 +26,114 @@ import { defineProvider } from '../registry.js'
 
 const GITHUB_API_URL = 'https://api.github.com'
 
+// =============================================================================
+// GitHub API Response Types
+// =============================================================================
+
+/**
+ * GitHub API user/owner object
+ */
+interface GitHubUser {
+  login: string
+  id: number
+  avatar_url: string
+  type: string
+}
+
+/**
+ * GitHub API repository response
+ */
+interface GitHubRepository {
+  id: number
+  name: string
+  full_name: string
+  description: string | null
+  private: boolean
+  default_branch: string
+  html_url: string
+  clone_url: string
+  stargazers_count: number
+  forks_count: number
+  open_issues_count: number
+  created_at: string
+  updated_at: string
+  owner: GitHubUser
+}
+
+/**
+ * GitHub API label object
+ */
+interface GitHubLabel {
+  id: number
+  name: string
+  color: string
+  description: string | null
+}
+
+/**
+ * GitHub API issue response
+ */
+interface GitHubIssue {
+  id: number
+  number: number
+  title: string
+  body: string | null
+  state: 'open' | 'closed'
+  html_url: string
+  created_at: string
+  updated_at: string
+  closed_at: string | null
+  user: GitHubUser
+  labels: GitHubLabel[]
+  assignees: GitHubUser[]
+  pull_request?: {
+    url: string
+    html_url: string
+  }
+}
+
+/**
+ * GitHub API branch reference
+ */
+interface GitHubBranchRef {
+  ref: string
+  sha: string
+  label: string
+  user: GitHubUser
+}
+
+/**
+ * GitHub API pull request response
+ */
+interface GitHubPullRequest {
+  id: number
+  number: number
+  title: string
+  body: string | null
+  state: 'open' | 'closed'
+  html_url: string
+  created_at: string
+  updated_at: string
+  closed_at: string | null
+  merged_at: string | null
+  draft: boolean
+  mergeable: boolean | null
+  user: GitHubUser
+  head: GitHubBranchRef
+  base: GitHubBranchRef
+}
+
+/**
+ * GitHub API comment response
+ */
+interface GitHubComment {
+  id: number
+  body: string
+  created_at: string
+  updated_at: string
+  user: GitHubUser
+}
+
 /**
  * GitHub provider info
  */
@@ -105,27 +213,24 @@ export function createGitHubProvider(config: ProviderConfig): DevelopmentProvide
         params.append('page', options.cursor)
       }
 
-      const response = await fetch(
-        `${baseUrl}/user/repos?${params.toString()}`,
-        {
-          headers: {
-            Authorization: `Bearer ${accessToken}`,
-            Accept: 'application/vnd.github.v3+json',
-          },
-        }
-      )
+      const response = await fetch(`${baseUrl}/user/repos?${params.toString()}`, {
+        headers: {
+          Authorization: `Bearer ${accessToken}`,
+          Accept: 'application/vnd.github.v3+json',
+        },
+      })
 
       if (!response.ok) {
         throw new Error(`GitHub API error: ${response.status} ${response.statusText}`)
       }
 
-      const data = await response.json() as any[]
-      const repos: RepoData[] = data.map((repo: any) => ({
+      const data = (await response.json()) as GitHubRepository[]
+      const repos: RepoData[] = data.map((repo) => ({
         id: String(repo.id),
         owner: repo.owner.login,
         name: repo.name,
         fullName: repo.full_name,
-        description: repo.description,
+        ...(repo.description !== null && { description: repo.description }),
         private: repo.private,
         defaultBranch: repo.default_branch,
         url: repo.html_url,
@@ -144,8 +249,7 @@ export function createGitHubProvider(config: ProviderConfig): DevelopmentProvide
       return {
         items: repos,
         hasMore,
-        nextCursor,
-        total: undefined,
+        ...(nextCursor !== undefined && { nextCursor }),
       }
     },
 
@@ -165,13 +269,13 @@ export function createGitHubProvider(config: ProviderConfig): DevelopmentProvide
         throw new Error(`GitHub API error: ${response.status} ${response.statusText}`)
       }
 
-      const data = await response.json() as any
+      const data = (await response.json()) as GitHubRepository
       return {
         id: String(data.id),
         owner: data.owner.login,
         name: data.name,
         fullName: data.full_name,
-        description: data.description,
+        ...(data.description !== null && { description: data.description }),
         private: data.private,
         defaultBranch: data.default_branch,
         url: data.html_url,
@@ -211,37 +315,30 @@ export function createGitHubProvider(config: ProviderConfig): DevelopmentProvide
         throw new Error(`GitHub API error: ${response.status} ${response.statusText}`)
       }
 
-      const data = await response.json() as any
+      const data = (await response.json()) as GitHubIssue
       return {
         id: String(data.id),
         number: data.number,
         title: data.title,
-        body: data.body,
+        ...(data.body !== null && { body: data.body }),
         state: data.state,
-        labels: data.labels.map((l: any) => l.name),
-        assignees: data.assignees.map((a: any) => a.login),
+        labels: data.labels.map((l) => l.name),
+        assignees: data.assignees.map((a) => a.login),
         authorId: data.user.login,
         url: data.html_url,
         createdAt: new Date(data.created_at),
         updatedAt: new Date(data.updated_at),
-        closedAt: data.closed_at ? new Date(data.closed_at) : undefined,
+        ...(data.closed_at !== null && { closedAt: new Date(data.closed_at) }),
       }
     },
 
-    async getIssue(
-      owner: string,
-      repo: string,
-      issueNumber: number
-    ): Promise<DevIssueData | null> {
-      const response = await fetch(
-        `${baseUrl}/repos/${owner}/${repo}/issues/${issueNumber}`,
-        {
-          headers: {
-            Authorization: `Bearer ${accessToken}`,
-            Accept: 'application/vnd.github.v3+json',
-          },
-        }
-      )
+    async getIssue(owner: string, repo: string, issueNumber: number): Promise<DevIssueData | null> {
+      const response = await fetch(`${baseUrl}/repos/${owner}/${repo}/issues/${issueNumber}`, {
+        headers: {
+          Authorization: `Bearer ${accessToken}`,
+          Accept: 'application/vnd.github.v3+json',
+        },
+      })
 
       if (response.status === 404) {
         return null
@@ -251,20 +348,20 @@ export function createGitHubProvider(config: ProviderConfig): DevelopmentProvide
         throw new Error(`GitHub API error: ${response.status} ${response.statusText}`)
       }
 
-      const data = await response.json() as any
+      const data = (await response.json()) as GitHubIssue
       return {
         id: String(data.id),
         number: data.number,
         title: data.title,
-        body: data.body,
+        ...(data.body !== null && { body: data.body }),
         state: data.state,
-        labels: data.labels.map((l: any) => l.name),
-        assignees: data.assignees.map((a: any) => a.login),
+        labels: data.labels.map((l) => l.name),
+        assignees: data.assignees.map((a) => a.login),
         authorId: data.user.login,
         url: data.html_url,
         createdAt: new Date(data.created_at),
         updatedAt: new Date(data.updated_at),
-        closedAt: data.closed_at ? new Date(data.closed_at) : undefined,
+        ...(data.closed_at !== null && { closedAt: new Date(data.closed_at) }),
       }
     },
 
@@ -276,43 +373,40 @@ export function createGitHubProvider(config: ProviderConfig): DevelopmentProvide
     ): Promise<DevIssueData> {
       const body: Record<string, unknown> = {}
 
-      if (updates.title !== undefined) body.title = updates.title
-      if (updates.body !== undefined) body.body = updates.body
-      if (updates.labels !== undefined) body.labels = updates.labels
-      if (updates.assignees !== undefined) body.assignees = updates.assignees
-      if (updates.milestone !== undefined) body.milestone = updates.milestone
+      if (updates.title !== undefined) body['title'] = updates.title
+      if (updates.body !== undefined) body['body'] = updates.body
+      if (updates.labels !== undefined) body['labels'] = updates.labels
+      if (updates.assignees !== undefined) body['assignees'] = updates.assignees
+      if (updates.milestone !== undefined) body['milestone'] = updates.milestone
 
-      const response = await fetch(
-        `${baseUrl}/repos/${owner}/${repo}/issues/${issueNumber}`,
-        {
-          method: 'PATCH',
-          headers: {
-            Authorization: `Bearer ${accessToken}`,
-            Accept: 'application/vnd.github.v3+json',
-            'Content-Type': 'application/json',
-          },
-          body: JSON.stringify(body),
-        }
-      )
+      const response = await fetch(`${baseUrl}/repos/${owner}/${repo}/issues/${issueNumber}`, {
+        method: 'PATCH',
+        headers: {
+          Authorization: `Bearer ${accessToken}`,
+          Accept: 'application/vnd.github.v3+json',
+          'Content-Type': 'application/json',
+        },
+        body: JSON.stringify(body),
+      })
 
       if (!response.ok) {
         throw new Error(`GitHub API error: ${response.status} ${response.statusText}`)
       }
 
-      const data = await response.json() as any
+      const data = (await response.json()) as GitHubIssue
       return {
         id: String(data.id),
         number: data.number,
         title: data.title,
-        body: data.body,
+        ...(data.body !== null && { body: data.body }),
         state: data.state,
-        labels: data.labels.map((l: any) => l.name),
-        assignees: data.assignees.map((a: any) => a.login),
+        labels: data.labels.map((l) => l.name),
+        assignees: data.assignees.map((a) => a.login),
         authorId: data.user.login,
         url: data.html_url,
         createdAt: new Date(data.created_at),
         updatedAt: new Date(data.updated_at),
-        closedAt: data.closed_at ? new Date(data.closed_at) : undefined,
+        ...(data.closed_at !== null && { closedAt: new Date(data.closed_at) }),
       }
     },
 
@@ -356,22 +450,22 @@ export function createGitHubProvider(config: ProviderConfig): DevelopmentProvide
         throw new Error(`GitHub API error: ${response.status} ${response.statusText}`)
       }
 
-      const data = await response.json() as any
+      const data = (await response.json()) as GitHubIssue[]
       const issues: DevIssueData[] = data
-        .filter((item: any) => !item.pull_request) // Filter out PRs
-        .map((issue: any) => ({
+        .filter((item) => !item.pull_request) // Filter out PRs
+        .map((issue) => ({
           id: String(issue.id),
           number: issue.number,
           title: issue.title,
-          body: issue.body,
+          ...(issue.body !== null && { body: issue.body }),
           state: issue.state,
-          labels: issue.labels.map((l: any) => l.name),
-          assignees: issue.assignees.map((a: any) => a.login),
+          labels: issue.labels.map((l) => l.name),
+          assignees: issue.assignees.map((a) => a.login),
           authorId: issue.user.login,
           url: issue.html_url,
           createdAt: new Date(issue.created_at),
           updatedAt: new Date(issue.updated_at),
-          closedAt: issue.closed_at ? new Date(issue.closed_at) : undefined,
+          ...(issue.closed_at !== null && { closedAt: new Date(issue.closed_at) }),
         }))
 
       const linkHeader = response.headers.get('Link')
@@ -381,16 +475,11 @@ export function createGitHubProvider(config: ProviderConfig): DevelopmentProvide
       return {
         items: issues,
         hasMore,
-        nextCursor,
-        total: undefined,
+        ...(nextCursor !== undefined && { nextCursor }),
       }
     },
 
-    async createPullRequest(
-      owner: string,
-      repo: string,
-      pr: CreatePROptions
-    ): Promise<PRData> {
+    async createPullRequest(owner: string, repo: string, pr: CreatePROptions): Promise<PRData> {
       const body = {
         title: pr.title,
         body: pr.body,
@@ -413,40 +502,33 @@ export function createGitHubProvider(config: ProviderConfig): DevelopmentProvide
         throw new Error(`GitHub API error: ${response.status} ${response.statusText}`)
       }
 
-      const data = await response.json() as any
+      const data = (await response.json()) as GitHubPullRequest
       return {
         id: String(data.id),
         number: data.number,
         title: data.title,
-        body: data.body,
+        ...(data.body !== null && { body: data.body }),
         state: data.merged_at ? 'merged' : data.state,
         head: data.head.ref,
         base: data.base.ref,
         authorId: data.user.login,
         draft: data.draft,
-        mergeable: data.mergeable,
+        ...(data.mergeable !== null && { mergeable: data.mergeable }),
         url: data.html_url,
         createdAt: new Date(data.created_at),
         updatedAt: new Date(data.updated_at),
-        mergedAt: data.merged_at ? new Date(data.merged_at) : undefined,
-        closedAt: data.closed_at ? new Date(data.closed_at) : undefined,
+        ...(data.merged_at !== null && { mergedAt: new Date(data.merged_at) }),
+        ...(data.closed_at !== null && { closedAt: new Date(data.closed_at) }),
       }
     },
 
-    async getPullRequest(
-      owner: string,
-      repo: string,
-      prNumber: number
-    ): Promise<PRData | null> {
-      const response = await fetch(
-        `${baseUrl}/repos/${owner}/${repo}/pulls/${prNumber}`,
-        {
-          headers: {
-            Authorization: `Bearer ${accessToken}`,
-            Accept: 'application/vnd.github.v3+json',
-          },
-        }
-      )
+    async getPullRequest(owner: string, repo: string, prNumber: number): Promise<PRData | null> {
+      const response = await fetch(`${baseUrl}/repos/${owner}/${repo}/pulls/${prNumber}`, {
+        headers: {
+          Authorization: `Bearer ${accessToken}`,
+          Accept: 'application/vnd.github.v3+json',
+        },
+      })
 
       if (response.status === 404) {
         return null
@@ -456,23 +538,23 @@ export function createGitHubProvider(config: ProviderConfig): DevelopmentProvide
         throw new Error(`GitHub API error: ${response.status} ${response.statusText}`)
       }
 
-      const data = await response.json() as any
+      const data = (await response.json()) as GitHubPullRequest
       return {
         id: String(data.id),
         number: data.number,
         title: data.title,
-        body: data.body,
+        ...(data.body !== null && { body: data.body }),
         state: data.merged_at ? 'merged' : data.state,
         head: data.head.ref,
         base: data.base.ref,
         authorId: data.user.login,
         draft: data.draft,
-        mergeable: data.mergeable,
+        ...(data.mergeable !== null && { mergeable: data.mergeable }),
         url: data.html_url,
         createdAt: new Date(data.created_at),
         updatedAt: new Date(data.updated_at),
-        mergedAt: data.merged_at ? new Date(data.merged_at) : undefined,
-        closedAt: data.closed_at ? new Date(data.closed_at) : undefined,
+        ...(data.merged_at !== null && { mergedAt: new Date(data.merged_at) }),
+        ...(data.closed_at !== null && { closedAt: new Date(data.closed_at) }),
       }
     },
 
@@ -499,37 +581,34 @@ export function createGitHubProvider(config: ProviderConfig): DevelopmentProvide
         params.append('page', options.cursor)
       }
 
-      const response = await fetch(
-        `${baseUrl}/repos/${owner}/${repo}/pulls?${params.toString()}`,
-        {
-          headers: {
-            Authorization: `Bearer ${accessToken}`,
-            Accept: 'application/vnd.github.v3+json',
-          },
-        }
-      )
+      const response = await fetch(`${baseUrl}/repos/${owner}/${repo}/pulls?${params.toString()}`, {
+        headers: {
+          Authorization: `Bearer ${accessToken}`,
+          Accept: 'application/vnd.github.v3+json',
+        },
+      })
 
       if (!response.ok) {
         throw new Error(`GitHub API error: ${response.status} ${response.statusText}`)
       }
 
-      const data = await response.json() as any
-      const prs: PRData[] = data.map((pr: any) => ({
+      const data = (await response.json()) as GitHubPullRequest[]
+      const prs: PRData[] = data.map((pr) => ({
         id: String(pr.id),
         number: pr.number,
         title: pr.title,
-        body: pr.body,
+        ...(pr.body !== null && { body: pr.body }),
         state: pr.merged_at ? 'merged' : pr.state,
         head: pr.head.ref,
         base: pr.base.ref,
         authorId: pr.user.login,
         draft: pr.draft,
-        mergeable: pr.mergeable,
+        ...(pr.mergeable !== null && { mergeable: pr.mergeable }),
         url: pr.html_url,
         createdAt: new Date(pr.created_at),
         updatedAt: new Date(pr.updated_at),
-        mergedAt: pr.merged_at ? new Date(pr.merged_at) : undefined,
-        closedAt: pr.closed_at ? new Date(pr.closed_at) : undefined,
+        ...(pr.merged_at !== null && { mergedAt: new Date(pr.merged_at) }),
+        ...(pr.closed_at !== null && { closedAt: new Date(pr.closed_at) }),
       }))
 
       const linkHeader = response.headers.get('Link')
@@ -539,28 +618,20 @@ export function createGitHubProvider(config: ProviderConfig): DevelopmentProvide
       return {
         items: prs,
         hasMore,
-        nextCursor,
-        total: undefined,
+        ...(nextCursor !== undefined && { nextCursor }),
       }
     },
 
-    async mergePullRequest(
-      owner: string,
-      repo: string,
-      prNumber: number
-    ): Promise<boolean> {
-      const response = await fetch(
-        `${baseUrl}/repos/${owner}/${repo}/pulls/${prNumber}/merge`,
-        {
-          method: 'PUT',
-          headers: {
-            Authorization: `Bearer ${accessToken}`,
-            Accept: 'application/vnd.github.v3+json',
-            'Content-Type': 'application/json',
-          },
-          body: JSON.stringify({}),
-        }
-      )
+    async mergePullRequest(owner: string, repo: string, prNumber: number): Promise<boolean> {
+      const response = await fetch(`${baseUrl}/repos/${owner}/${repo}/pulls/${prNumber}/merge`, {
+        method: 'PUT',
+        headers: {
+          Authorization: `Bearer ${accessToken}`,
+          Accept: 'application/vnd.github.v3+json',
+          'Content-Type': 'application/json',
+        },
+        body: JSON.stringify({}),
+      })
 
       return response.ok
     },
@@ -588,7 +659,7 @@ export function createGitHubProvider(config: ProviderConfig): DevelopmentProvide
         throw new Error(`GitHub API error: ${response.status} ${response.statusText}`)
       }
 
-      const data = await response.json() as any
+      const data = (await response.json()) as GitHubComment
       return {
         id: String(data.id),
         body: data.body,