devrites 6.0.4 → 6.1.1

package/engine/internal/lib/workspace_read_test.go

@@ -1,102 +0,0 @@
-package lib
-
-import (
-	"errors"
-	"os"
-	"os/exec"
-	"path/filepath"
-	"runtime"
-	"strings"
-	"testing"
-	"time"
-)
-
-func workspaceReadFixture(t *testing.T) (root, workspace string) {
-	t.Helper()
-	root = t.TempDir()
-	workspace = filepath.Join(root, "work", "feat")
-	if err := os.MkdirAll(workspace, 0o750); err != nil {
-		t.Fatal(err)
-	}
-	return root, workspace
-}
-
-func TestReadWorkspaceArtifactReadsRegularFile(t *testing.T) {
-	root, workspace := workspaceReadFixture(t)
-	if err := os.WriteFile(filepath.Join(workspace, "tasks.md"), []byte("ok"), 0o600); err != nil {
-		t.Fatal(err)
-	}
-	raw, err := readWorkspaceArtifact(root, "feat", "tasks.md")
-	if err != nil || string(raw) != "ok" {
-		t.Fatalf("raw=%q err=%v", raw, err)
-	}
-}
-
-func TestReadWorkspaceArtifactMissingKeepsNotExist(t *testing.T) {
-	root, _ := workspaceReadFixture(t)
-	if _, err := readWorkspaceArtifact(root, "feat", "tasks.md"); !errors.Is(err, os.ErrNotExist) {
-		t.Fatalf("err=%v, want os.ErrNotExist", err)
-	}
-}
-
-func TestReadWorkspaceArtifactRejectsSymlinkLeaf(t *testing.T) {
-	root, workspace := workspaceReadFixture(t)
-	outside := filepath.Join(t.TempDir(), "outside.md")
-	if err := os.WriteFile(outside, []byte("outside secret"), 0o600); err != nil {
-		t.Fatal(err)
-	}
-	if err := os.Symlink(outside, filepath.Join(workspace, "tasks.md")); err != nil {
-		t.Skipf("symlinks unavailable: %v", err)
-	}
-	raw, err := readWorkspaceArtifact(root, "feat", "tasks.md")
-	if err == nil {
-		t.Fatalf("symlinked artifact was read: %q", raw)
-	}
-}
-
-func TestReadWorkspaceArtifactRejectsFIFO(t *testing.T) {
-	if runtime.GOOS == "windows" {
-		t.Skip("mkfifo under Git Bash does not create a real FIFO")
-	}
-	root, workspace := workspaceReadFixture(t)
-	if out, err := exec.Command("mkfifo", filepath.Join(workspace, "tasks.md")).CombinedOutput(); err != nil {
-		t.Skipf("fifo unavailable: %v: %s", err, out)
-	}
-	done := make(chan error, 1)
-	go func() {
-		_, err := readWorkspaceArtifact(root, "feat", "tasks.md")
-		done <- err
-	}()
-	select {
-	case err := <-done:
-		if err == nil {
-			t.Fatal("FIFO artifact read without error")
-		}
-	case <-time.After(time.Second):
-		t.Fatal("readWorkspaceArtifact blocked on a FIFO")
-	}
-}
-
-func TestReadWorkspaceArtifactMissingWorkspaceKeepsNotExist(t *testing.T) {
-	if _, err := readWorkspaceArtifact(t.TempDir(), "absent", "tasks.md"); !errors.Is(err, os.ErrNotExist) {
-		t.Fatalf("err=%v, want os.ErrNotExist", err)
-	}
-}
-
-func TestReadWorkspaceArtifactRejectsOversize(t *testing.T) {
-	root, workspace := workspaceReadFixture(t)
-	path := filepath.Join(workspace, "tasks.md")
-	if err := os.WriteFile(path, nil, 0o600); err != nil {
-		t.Fatal(err)
-	}
-	if err := os.Truncate(path, workspaceArtifactLimit+1); err != nil {
-		t.Fatal(err)
-	}
-	raw, err := readWorkspaceArtifact(root, "feat", "tasks.md")
-	if err == nil {
-		t.Fatalf("oversize artifact was read: %d bytes", len(raw))
-	}
-	if !strings.Contains(err.Error(), "tasks.md") || !strings.Contains(err.Error(), "exceeds") {
-		t.Fatalf("err=%v, want artifact name and limit message", err)
-	}
-}

package/engine/internal/markdowntext/markdowntext_fuzz_test.go

@@ -1,36 +0,0 @@
-package markdowntext
-
-import (
-	"bytes"
-	"testing"
-	"unicode/utf8"
-)
-
-func FuzzStructural(f *testing.F) {
-	f.Add([]byte("# Title\n\n```go\nfmt.Println()\n```\n"))
-	f.Add([]byte("~~~\nunclosed fence\n"))
-	f.Add([]byte("   ```\n  ~~~\n"))
-	f.Add([]byte("code ``` inline\n| not | a | fence |\n"))
-	f.Add([]byte("line\r\nwith\r\ncrlf\r\n"))
-	f.Add([]byte("\xff\xfe invalid utf8 \x00"))
-	f.Add([]byte(""))
-	f.Fuzz(func(t *testing.T, input []byte) {
-		out, err := Structural(input)
-		if err != nil {
-			if utf8.Valid(input) && bytes.IndexByte(input, 0) < 0 {
-				t.Fatalf("Structural rejected input without malformed UTF-8 or NUL: %v", err)
-			}
-			return
-		}
-		if len(out) != len(input) {
-			t.Fatalf("Structural changed length: %d -> %d", len(input), len(out))
-		}
-		if !utf8.Valid(out) {
-			t.Fatal("Structural emitted invalid UTF-8")
-		}
-		stable, err := Structural(out)
-		if err != nil || !bytes.Equal(stable, out) {
-			t.Fatal("Structural is not idempotent")
-		}
-	})
-}

package/engine/internal/markdowntext/markdowntext_test.go

@@ -1,58 +0,0 @@
-package markdowntext
-
-import (
-	"bytes"
-	"encoding/json"
-	"os"
-	"testing"
-)
-
-func TestStructuralMasksFencedBlocksWithoutMovingBytes(t *testing.T) {
-	corpus, err := os.ReadFile("testdata/structural.json")
-	if err != nil {
-		t.Fatal(err)
-	}
-	var cases []struct {
-		Name   string `json:"name"`
-		Input  string `json:"input"`
-		Output string `json:"output"`
-	}
-	if err := json.Unmarshal(corpus, &cases); err != nil {
-		t.Fatal(err)
-	}
-	if len(cases) == 0 {
-		t.Fatal("structural Markdown corpus is empty")
-	}
-
-	for _, test := range cases {
-		t.Run(test.Name, func(t *testing.T) {
-			input := []byte(test.Input)
-			got, err := Structural(input)
-			if err != nil {
-				t.Fatal(err)
-			}
-			if want := []byte(test.Output); !bytes.Equal(got, want) {
-				t.Fatalf("Structural() = %q, want %q", got, want)
-			}
-			if len(got) != len(input) {
-				t.Fatalf("len(Structural()) = %d, want %d", len(got), len(input))
-			}
-			for i, b := range input {
-				if (b == '\n' || b == '\r') && got[i] != b {
-					t.Fatalf("line break at byte %d changed from %q to %q", i, b, got[i])
-				}
-			}
-		})
-	}
-}
-
-func TestStructuralRejectsCorruptText(t *testing.T) {
-	for _, input := range [][]byte{
-		{'o', 'k', 0},
-		{'o', 'k', 0xff},
-	} {
-		if _, err := Structural(input); err == nil {
-			t.Fatalf("Structural(%q) error = nil", input)
-		}
-	}
-}

package/engine/internal/markdowntext/testdata/structural.json

@@ -1,277 +0,0 @@
-[
-  {
-    "name": "indentation boundary",
-    "input": "    ```\nnot fenced\n",
-    "output": "    ```\nnot fenced\n"
-  },
-  {
-    "name": "CRLF marker width and mismatched close",
-    "input": "before\r\n   ````go\r\n## hidden\r\n~~~\r\n```\r\n   ````\r\nafter\r\n",
-    "output": "before\r\n         \r\n         \r\n   \r\n   \r\n       \r\nafter\r\n"
-  },
-  {
-    "name": "backtick info restriction",
-    "input": "```go`bad\nnot fenced\n",
-    "output": "```go`bad\nnot fenced\n"
-  },
-  {
-    "name": "tilde fence through EOF",
-    "input": "~~~\n| hidden |\n",
-    "output": "   \n          \n"
-  },
-  {
-    "name": "Unicode byte length",
-    "input": "π before\n~~~md\n## hïdden π\n~~~\nπ after\n",
-    "output": "π before\n     \n             \n   \nπ after\n"
-  },
-  {
-    "name": "list-indented fence",
-    "input": "- item\n\n    ```\n    ## hidden\n    ```\nafter\n",
-    "output": "- item\n\n       \n             \n       \nafter\n"
-  },
-  {
-    "name": "nested list fence within content indent plus three",
-    "input": "1. one\n   - nested\n\n        ```\n        ## hidden\n        ```\nend\n",
-    "output": "1. one\n   - nested\n\n        ```\n        ## hidden\n        ```\nend\n"
-  },
-  {
-    "name": "fence past container indent plus three is indented code",
-    "input": "- item\n\n         ```\n## visible\n",
-    "output": "- item\n\n         ```\n## visible\n"
-  },
-  {
-    "name": "list marker inside top-level indented code opens no list",
-    "input": "# Q\n\n    - example\n    ```\n\n## Q-001\nstatus: open\ngate: blocking\n",
-    "output": "# Q\n\n    - example\n    ```\n\n## Q-001\nstatus: open\ngate: blocking\n"
-  },
-  {
-    "name": "list marker inside list indented code opens no list",
-    "input": "- a\n\n      - not a list\n       ```\n\n## Q-001\nstatus: open\ngate: blocking\n",
-    "output": "- a\n\n      - not a list\n       ```\n\n## Q-001\nstatus: open\ngate: blocking\n"
-  },
-  {
-    "name": "top-level fence keeps three-column limit after a list ends",
-    "input": "- a\nplain\n\n    ```\n## visible\n",
-    "output": "- a\nplain\n\n    ```\n## visible\n"
-  },
-  {
-    "name": "top-level fence keeps three-column limit without a list",
-    "input": "text\n\n    ```\n## visible\n\n   ```\n## hidden\n```\n",
-    "output": "text\n\n    ```\n## visible\n\n      \n         \n   \n"
-  },
-  {
-    "name": "unclosed list fence stays visible before a dedented heading",
-    "input": "- a\n\n    ```\n\n## Q-001\nstatus: open\ngate: blocking\n",
-    "output": "- a\n\n    ```\n\n## Q-001\nstatus: open\ngate: blocking\n"
-  },
-  {
-    "name": "unclosed ordered list fence stays visible",
-    "input": "1. step\n\n     ```\n## Q-001\nstatus: open\ngate: blocking\n",
-    "output": "1. step\n\n     ```\n## Q-001\nstatus: open\ngate: blocking\n"
-  },
-  {
-    "name": "unclosed nested list fence stays visible",
-    "input": "- a\n  - b\n\n      ```\n\n## Q-001\nstatus: open\ngate: blocking\n",
-    "output": "- a\n  - b\n\n      ```\n\n## Q-001\nstatus: open\ngate: blocking\n"
-  },
-  {
-    "name": "list fence with no close inside the item stays visible",
-    "input": "- example:\n\n    ```\n    code\n## Q-001\nstatus: open\ngate: blocking\n    ```\n",
-    "output": "- example:\n\n    ```\n    code\n## Q-001\nstatus: open\ngate: blocking\n    ```\n"
-  },
-  {
-    "name": "list fence interrupted by a line indented less than the item content stays visible",
-    "input": "- a\n\n    ```\n b\n    ```\n## Q-001\nstatus: open\ngate: blocking\n",
-    "output": "- a\n\n    ```\n b\n    ```\n## Q-001\nstatus: open\ngate: blocking\n"
-  },
-  {
-    "name": "tab-indented line stays inside a list fence",
-    "input": "- a\n\n    ```\n\tcode\n    ```\nafter\n",
-    "output": "- a\n\n       \n     \n       \nafter\n"
-  },
-  {
-    "name": "thematic break star is not a list item",
-    "input": "* * *\n\n    ```\n## Q-001\nstatus: open\ngate: blocking\n",
-    "output": "* * *\n\n    ```\n## Q-001\nstatus: open\ngate: blocking\n"
-  },
-  {
-    "name": "thematic break dash is not a list item",
-    "input": "- - -\n\n    ```\n## Q-001\nstatus: open\ngate: blocking\n",
-    "output": "- - -\n\n    ```\n## Q-001\nstatus: open\ngate: blocking\n"
-  },
-  {
-    "name": "thematic break bare star is not a list item",
-    "input": "***\n\n    ```\n## Q-001\nstatus: open\ngate: blocking\n",
-    "output": "***\n\n    ```\n## Q-001\nstatus: open\ngate: blocking\n"
-  },
-  {
-    "name": "ordered item not starting at one cannot interrupt a paragraph",
-    "input": "text\n2. foo\n\n    ```\n## Q-001\nstatus: open\ngate: blocking\n",
-    "output": "text\n2. foo\n\n    ```\n## Q-001\nstatus: open\ngate: blocking\n"
-  },
-  {
-    "name": "ordered item starting at one interrupts a paragraph",
-    "input": "text\n1. foo\n\n    ```\n    ## hidden\n    ```\nafter\n",
-    "output": "text\n1. foo\n\n    ```\n    ## hidden\n    ```\nafter\n"
-  },
-  {
-    "name": "ordered item not starting at one opens a list after a blank line",
-    "input": "text\n\n2. foo\n\n    ```\n    ## hidden\n    ```\nafter\n",
-    "output": "text\n\n2. foo\n\n       \n             \n       \nafter\n"
-  },
-  {
-    "name": "empty dash marker does not open list context",
-    "input": "-\n\n    ```\n  | ID | Status | Gate |\n  |---|---|---|\n  | Q-1 | open | blocking |\n",
-    "output": "-\n\n    ```\n  | ID | Status | Gate |\n  |---|---|---|\n  | Q-1 | open | blocking |\n"
-  },
-  {
-    "name": "setext dash does not open list context",
-    "input": "Intro\n-\n\n    ```\n  | ID | Status | Gate |\n  |---|---|---|\n  | Q-1 | open | blocking |\n",
-    "output": "Intro\n-\n\n    ```\n  | ID | Status | Gate |\n  |---|---|---|\n  | Q-1 | open | blocking |\n"
-  },
-  {
-    "name": "empty star marker does not open list context",
-    "input": "Some text\n*\n\n    ```\n  | ID | Status | Gate |\n  |---|---|---|\n  | Q-1 | open | blocking |\n",
-    "output": "Some text\n*\n\n    ```\n  | ID | Status | Gate |\n  |---|---|---|\n  | Q-1 | open | blocking |\n"
-  },
-  {
-    "name": "empty marker does not hide acceptance heading",
-    "input": "-\n\n    ```\n  ## Acceptance criteria\n",
-    "output": "-\n\n    ```\n  ## Acceptance criteria\n"
-  },
-  {
-    "name": "list fence closed inside the item masks and ends",
-    "input": "- item\n\n    ```\n    ## Q-1\n    Status: open\n    ```\n## Q-1\nStatus: open\nGate: blocking\n",
-    "output": "- item\n\n       \n          \n                \n       \n## Q-1\nStatus: open\nGate: blocking\n"
-  },
-  {
-    "name": "unclosed list fence stays visible",
-    "input": "- a\n\n    ```\n## Q-1\nStatus: open\nGate: blocking\n",
-    "output": "- a\n\n    ```\n## Q-1\nStatus: open\nGate: blocking\n"
-  },
-  {
-    "name": "unclosed list fence with indented tail stays visible",
-    "input": "- a\n\n    ```\n    text\n",
-    "output": "- a\n\n    ```\n    text\n"
-  },
-  {
-    "name": "list fence dedent before close stays visible",
-    "input": "- a\n\n    ```\n    text\nback\n    ```\n## Q-1\nStatus: open\nGate: blocking\n",
-    "output": "- a\n\n    ```\n    text\nback\n    ```\n## Q-1\nStatus: open\nGate: blocking\n"
-  },
-  {
-    "name": "indented dash then top-level unclosed fence masks to end",
-    "input": "    - x\n```\n## Q-1\nStatus: open\nGate: blocking\n",
-    "output": "    - x\n   \n      \n            \n              \n"
-  },
-  {
-    "name": "tab-indented list fence closer keeps a question table visible",
-    "input": "- a\n\n    ```\n\t```\n  | ID | Status | Gate |\n  |---|---|---|\n  | Q-1 | open | blocking |\n    ```\n",
-    "output": "- a\n\n       \n    \n  | ID | Status | Gate |\n  |---|---|---|\n  | Q-1 | open | blocking |\n    ```\n"
-  },
-  {
-    "name": "tab-indented list fence closer keeps a heading visible",
-    "input": "- a\n\n    ```\n\t```\n  ## Acceptance criteria\n    ```\n",
-    "output": "- a\n\n       \n    \n  ## Acceptance criteria\n    ```\n"
-  },
-  {
-    "name": "tab-indented list fence opener closed by spaces",
-    "input": "- a\n\n\t```\n    ```\n  ## Acceptance criteria\n",
-    "output": "- a\n\n    \n       \n  ## Acceptance criteria\n"
-  },
-  {
-    "name": "fence on the list marker line is never masked and a later lookalike opener masks nothing",
-    "input": "- ```\n    ```\n  | ID | Status | Gate |\n  |---|---|---|\n  | Q-001 | open | blocking |\n\n    ```\n",
-    "output": "- ```\n    ```\n  | ID | Status | Gate |\n  |---|---|---|\n  | Q-001 | open | blocking |\n\n    ```\n"
-  },
-  {
-    "name": "ordered marker line fence is never masked and a later lookalike opener masks nothing",
-    "input": "1. ```\n    ```\n   | ID | Status | Gate |\n   |---|---|---|\n   | Q-001 | open | blocking |\n\n    ```\n",
-    "output": "1. ```\n    ```\n   | ID | Status | Gate |\n   |---|---|---|\n   | Q-001 | open | blocking |\n\n    ```\n"
-  },
-  {
-    "name": "nested marker on the parent line keeps a fence with a shallower table unmasked",
-    "input": "1. - a\n\n      ```\n   | ID | Status | Gate |\n   |---|---|---|\n   | Q-001 | open | blocking |\n\n   ```\n",
-    "output": "1. - a\n\n      ```\n   | ID | Status | Gate |\n   |---|---|---|\n   | Q-001 | open | blocking |\n\n      \n"
-  },
-  {
-    "name": "marker line fence closed by the next line leaves the following item text visible",
-    "input": "- ```\n    ```\n    visible\n    ```\n",
-    "output": "- ```\n    ```\n    visible\n    ```\n"
-  },
-  {
-    "name": "rejected list opener keeps a later pair in the same item unmasked",
-    "input": "- a\n    ```\n  | t |\n\n    ```\n    visible\n    ```\n",
-    "output": "- a\n    ```\n  | t |\n\n    ```\n    visible\n    ```\n"
-  },
-  {
-    "name": "list fence with a deeper closer-like line before the matching closer stays visible",
-    "input": "- a\n    ```\n     ```\n    visible\n    ```\n",
-    "output": "- a\n    ```\n     ```\n    visible\n    ```\n"
-  },
-  {
-    "name": "four-space heading then ordered item does not anchor a fence",
-    "input": "Intro\n    # x\n2. item\n    ```\n    | ID | Status | Gate |\n    |---|---|---|\n    | Q-001 | open | blocking |\n    ```\n",
-    "output": "Intro\n    # x\n2. item\n    ```\n    | ID | Status | Gate |\n    |---|---|---|\n    | Q-001 | open | blocking |\n    ```\n"
-  },
-  {
-    "name": "four-space thematic break then ordered item does not anchor a fence",
-    "input": "Intro\n    ---\n2. item\n    ```\n    | ID | Status | Gate |\n    |---|---|---|\n    | Q-001 | open | blocking |\n    ```\n",
-    "output": "Intro\n    ---\n2. item\n    ```\n    | ID | Status | Gate |\n    |---|---|---|\n    | Q-001 | open | blocking |\n    ```\n"
-  },
-  {
-    "name": "dash item whose content is a star marker does not anchor a fence",
-    "input": "- * x\n    ```\n    | ID | Status | Gate |\n    |---|---|---|\n    | Q-001 | open | blocking |\n    ```\n",
-    "output": "- * x\n    ```\n    | ID | Status | Gate |\n    |---|---|---|\n    | Q-001 | open | blocking |\n    ```\n"
-  },
-  {
-    "name": "ordered item whose content is a dash marker does not anchor a fence",
-    "input": "1. - a\n    ```\n    | ID | Status | Gate |\n    |---|---|---|\n    | Q-001 | open | blocking |\n    ```\n",
-    "output": "1. - a\n    ```\n    | ID | Status | Gate |\n    |---|---|---|\n    | Q-001 | open | blocking |\n    ```\n"
-  },
-  {
-    "name": "dash item whose content is a thematic break does not anchor a fence",
-    "input": "- ---\n    ```\n    | ID | Status | Gate |\n    |---|---|---|\n    | Q-001 | open | blocking |\n    ```\n",
-    "output": "- ---\n    ```\n    | ID | Status | Gate |\n    |---|---|---|\n    | Q-001 | open | blocking |\n    ```\n"
-  },
-  {
-    "name": "list item after a paragraph without a blank line does not anchor a fence",
-    "input": "Intro\n- item\n    ```\n    | ID | Status | Gate |\n    |---|---|---|\n    | Q-001 | open | blocking |\n    ```\n",
-    "output": "Intro\n- item\n    ```\n    | ID | Status | Gate |\n    |---|---|---|\n    | Q-001 | open | blocking |\n    ```\n"
-  },
-  {
-    "name": "nested item does not anchor a fence",
-    "input": "- item\n  - sub\n    ```\n    | ID | Status | Gate |\n    |---|---|---|\n    | Q-001 | open | blocking |\n    ```\n",
-    "output": "- item\n  - sub\n    ```\n    | ID | Status | Gate |\n    |---|---|---|\n    | Q-001 | open | blocking |\n    ```\n"
-  },
-  {
-    "name": "text between the item and the fence does not anchor it",
-    "input": "- item\n\n    text\n\n    ```\n    | ID | Status | Gate |\n    |---|---|---|\n    | Q-001 | open | blocking |\n    ```\n",
-    "output": "- item\n\n    text\n\n    ```\n    | ID | Status | Gate |\n    |---|---|---|\n    | Q-001 | open | blocking |\n    ```\n"
-  },
-  {
-    "name": "anchored list fence masks a note line",
-    "input": "- item\n\n    ```\n    - NOTE x\n    ```\n",
-    "output": "- item\n\n       \n            \n       \n"
-  },
-  {
-    "name": "lone CR inside a list fence region masks nothing",
-    "input": "- a\n\n    ~~~\r| ID | Status | Gate |\r|---|---|---|\r| Q-001 | open | blocking |\r    ~~~\n    ~~~\n",
-    "output": "- a\n\n    ~~~\r| ID | Status | Gate |\r|---|---|---|\r| Q-001 | open | blocking |\r    ~~~\n    ~~~\n"
-  },
-  {
-    "name": "lone CR inside a list fence region keeps a heading unmasked",
-    "input": "- a\n\n    ~~~\r## Q-001\r    ~~~\n    ~~~\n",
-    "output": "- a\n\n    ~~~\r## Q-001\r    ~~~\n    ~~~\n"
-  },
-  {
-    "name": "two-backtick line opens no fence",
-    "input": "``\n## visible\n",
-    "output": "``\n## visible\n"
-  },
-  {
-    "name": "closing fence with trailing text does not close",
-    "input": "~~~\nhidden\n~~~ tail\nstill hidden\n~~~\nafter\n",
-    "output": "   \n      \n        \n            \n   \nafter\n"
-  }
-]