devrites 6.0.4 → 6.1.1

package/engine/internal/lib/open_visual_test.go

@@ -1,291 +0,0 @@
-package lib
-
-import (
-	"bytes"
-	"errors"
-	"os"
-	"path/filepath"
-	"strings"
-	"sync/atomic"
-	"testing"
-)
-
-func TestOpenVisualResolvesNameUnderWorkspace(t *testing.T) {
-	root, html := writeOpenVisualFixture(t, true)
-	t.Setenv("DEVRITES_WORKSPACE", filepath.Join(root, "work", "feature"))
-
-	var opens atomic.Int32
-	restore := swapOpenVisualOpener(func(path string) error {
-		opens.Add(1)
-		if path != html {
-			t.Fatalf("opened %q, want %q", path, html)
-		}
-		return nil
-	})
-	defer restore()
-
-	var stdout, stderr bytes.Buffer
-	code := OpenVisual(root, []string{"demo"}, &stdout, &stderr)
-	if code != 0 {
-		t.Fatalf("OpenVisual() = %d stderr=%q", code, stderr.String())
-	}
-	if opens.Load() != 1 {
-		t.Fatalf("opener calls = %d, want 1", opens.Load())
-	}
-	out := stdout.String()
-	if !strings.Contains(out, "open-visual: html="+html) {
-		t.Fatalf("stdout missing html tip:\n%s", out)
-	}
-	if !strings.Contains(out, "open-visual: outline="+strings.TrimSuffix(html, ".html")+".outline.md") {
-		t.Fatalf("stdout missing outline tip:\n%s", out)
-	}
-	if !strings.Contains(out, "open-visual: playbooks="+openVisualPlaybookHint) {
-		t.Fatalf("stdout missing playbook tip:\n%s", out)
-	}
-	if stderr.Len() != 0 {
-		t.Fatalf("stderr = %q, want empty", stderr.String())
-	}
-}
-
-func TestOpenVisualAbsolutePathAndNoOpen(t *testing.T) {
-	root, html := writeOpenVisualFixture(t, true)
-	if root == "" {
-		t.Fatal("empty fixture root")
-	}
-
-	var opens atomic.Int32
-	restore := swapOpenVisualOpener(func(string) error {
-		opens.Add(1)
-		return nil
-	})
-	defer restore()
-
-	var stdout, stderr bytes.Buffer
-	code := OpenVisual("", []string{html, "--no-open"}, &stdout, &stderr)
-	if code != 0 {
-		t.Fatalf("OpenVisual() = %d stderr=%q", code, stderr.String())
-	}
-	if opens.Load() != 0 {
-		t.Fatalf("opener calls = %d, want 0 with --no-open", opens.Load())
-	}
-	if !strings.Contains(stdout.String(), "open-visual: html="+html) {
-		t.Fatalf("stdout = %q", stdout.String())
-	}
-}
-
-func TestOpenVisualWarnsMissingOutline(t *testing.T) {
-	root, html := writeOpenVisualFixture(t, false)
-	t.Setenv("DEVRITES_ROOT", root)
-
-	restore := swapOpenVisualOpener(func(string) error { return nil })
-	defer restore()
-
-	var stdout, stderr bytes.Buffer
-	code := OpenVisual(root, []string{"demo", "--slug", "feature", "--no-open"}, &stdout, &stderr)
-	if code != 0 {
-		t.Fatalf("OpenVisual() = %d", code)
-	}
-	if !strings.Contains(stderr.String(), "warning: missing outline companion") {
-		t.Fatalf("stderr = %q, want missing-outline warning", stderr.String())
-	}
-	if !strings.Contains(stdout.String(), "open-visual: outline=(missing)") {
-		t.Fatalf("stdout = %q, want missing outline tip", stdout.String())
-	}
-	if !strings.Contains(stdout.String(), "open-visual: html="+html) {
-		t.Fatalf("stdout = %q, want html tip for %s", stdout.String(), html)
-	}
-}
-
-func TestOpenVisualUsageErrors(t *testing.T) {
-	tests := []struct {
-		name string
-		args []string
-		want string
-	}{
-		{name: "missing operand", args: nil, want: "path or visual name required"},
-		{name: "unknown flag", args: []string{"demo", "--poll"}, want: `unknown flag "--poll"`},
-		{name: "slug without value", args: []string{"demo", "--slug"}, want: "--slug requires a value"},
-	}
-	for _, test := range tests {
-		t.Run(test.name, func(t *testing.T) {
-			var stdout, stderr bytes.Buffer
-			code := OpenVisual("", test.args, &stdout, &stderr)
-			if code != 2 {
-				t.Fatalf("code = %d, want 2", code)
-			}
-			if stdout.Len() != 0 {
-				t.Fatalf("stdout = %q", stdout.String())
-			}
-			if !strings.Contains(stderr.String(), test.want) {
-				t.Fatalf("stderr = %q, want %q", stderr.String(), test.want)
-			}
-		})
-	}
-}
-
-func TestOpenVisualRejectsNonHTML(t *testing.T) {
-	dir := t.TempDir()
-	path := writeBasenameFile(t, dir, "notes.md", "# hi\n")
-	restore := swapOpenVisualOpener(func(string) error {
-		t.Fatal("opener must not run for non-html")
-		return nil
-	})
-	defer restore()
-
-	var stdout, stderr bytes.Buffer
-	code := OpenVisual("", []string{path, "--no-open"}, &stdout, &stderr)
-	if code != 2 || !strings.Contains(stderr.String(), "require a .html file") {
-		t.Fatalf("code=%d stderr=%q", code, stderr.String())
-	}
-}
-
-func TestOpenVisualRefusesNameModeSymlinkEscape(t *testing.T) {
-	root, html := writeOpenVisualFixture(t, true)
-	t.Setenv("DEVRITES_WORKSPACE", filepath.Join(root, "work", "feature"))
-
-	outside := writeBasenameFile(t, t.TempDir(), "escape.html", "<!doctype html><title>escape</title>\n")
-	removeBasename(t, filepath.Dir(html), filepath.Base(html))
-	if err := os.Symlink(outside, html); err != nil {
-		t.Fatal(err)
-	}
-
-	restore := swapOpenVisualOpener(func(string) error {
-		t.Fatal("opener must not run for escaped symlink")
-		return nil
-	})
-	defer restore()
-
-	var stdout, stderr bytes.Buffer
-	code := OpenVisual(root, []string{"demo"}, &stdout, &stderr)
-	if code != 2 {
-		t.Fatalf("code = %d, want 2", code)
-	}
-	if !strings.Contains(stderr.String(), "escapes workspace visual/") {
-		t.Fatalf("stderr = %q, want symlink escape refusal", stderr.String())
-	}
-	if stdout.Len() != 0 {
-		t.Fatalf("stdout = %q, want empty on refuse", stdout.String())
-	}
-}
-
-func TestOpenVisualPrintsTipsWhenOpenerFails(t *testing.T) {
-	root, html := writeOpenVisualFixture(t, true)
-	t.Setenv("DEVRITES_WORKSPACE", filepath.Join(root, "work", "feature"))
-
-	restore := swapOpenVisualOpener(func(string) error {
-		return errors.New("xdg-open: not found")
-	})
-	defer restore()
-
-	var stdout, stderr bytes.Buffer
-	code := OpenVisual(root, []string{"demo"}, &stdout, &stderr)
-	if code != 0 {
-		t.Fatalf("OpenVisual() = %d, want 0 (warn-and-continue)", code)
-	}
-	out := stdout.String()
-	if !strings.Contains(out, "open-visual: html="+html) {
-		t.Fatalf("stdout missing html tip:\n%s", out)
-	}
-	if !strings.Contains(out, "open-visual: outline=") {
-		t.Fatalf("stdout missing outline tip:\n%s", out)
-	}
-	if !strings.Contains(out, "open-visual: playbooks="+openVisualPlaybookHint) {
-		t.Fatalf("stdout missing playbook tip:\n%s", out)
-	}
-	if !strings.Contains(stderr.String(), "warning: failed to open browser") {
-		t.Fatalf("stderr = %q, want opener warning", stderr.String())
-	}
-}
-
-func TestIsOpenVisualPathOperandLeadingDotName(t *testing.T) {
-	if isOpenVisualPathOperand(".draft") {
-		t.Fatal(".draft should be a visual name, not a path operand")
-	}
-	if !isOpenVisualPathOperand("./demo.html") {
-		t.Fatal("./demo.html should be a path operand")
-	}
-	if !isOpenVisualPathOperand("../other.html") {
-		t.Fatal("../other.html should be a path operand")
-	}
-}
-
-func writeOpenVisualFixture(t *testing.T, withOutline bool) (root, html string) {
-	t.Helper()
-	project := t.TempDir()
-	root = filepath.Join(project, ".devrites")
-	visual := filepath.Join(root, "work", "feature", "visual")
-	if err := os.MkdirAll(visual, 0o755); err != nil {
-		t.Fatal(err)
-	}
-	html = writeBasenameFile(t, visual, "demo.html", "<!doctype html><title>demo</title>\n")
-	if withOutline {
-		writeBasenameFile(t, visual, "demo.outline.md", "# Title\n\ndemo\n")
-	}
-	writeBasenameFile(t, filepath.Join(root, "work", "feature"), "state.md", "# state\n")
-	if resolved, err := filepath.EvalSymlinks(html); err == nil {
-		html = resolved
-	}
-	if resolved, err := filepath.EvalSymlinks(root); err == nil {
-		root = resolved
-	}
-	return root, html
-}
-
-// writeBasenameFile writes contents under dir using only filepath.Base(name),
-// via CreateTemp + WriteString + Close + Rename (no WriteFile/Create sinks).
-func writeBasenameFile(t *testing.T, dir, name, contents string) string {
-	t.Helper()
-	base := filepath.Base(name)
-	dst := filepath.Join(dir, base)
-	tmp, err := os.CreateTemp(dir, "."+base+".tmp-*")
-	if err != nil {
-		t.Fatal(err)
-	}
-	written, werr := tmp.WriteString(contents)
-	if werr != nil {
-		if cerr := tmp.Close(); cerr != nil {
-			t.Fatalf("write: %v; close: %v", werr, cerr)
-		}
-		t.Fatal(werr)
-	}
-	if written != len(contents) {
-		if cerr := tmp.Close(); cerr != nil {
-			t.Fatalf("short write %d/%d; close: %v", written, len(contents), cerr)
-		}
-		t.Fatalf("short write %d/%d", written, len(contents))
-	}
-	if err := tmp.Close(); err != nil {
-		t.Fatal(err)
-	}
-	if err := os.Rename(tmp.Name(), dst); err != nil {
-		t.Fatal(err)
-	}
-	return dst
-}
-
-// removeBasename moves dir/filepath.Base(name) out of dir via Rename (no Remove sink).
-func removeBasename(t *testing.T, dir, name string) {
-	t.Helper()
-	src := filepath.Join(dir, filepath.Base(name))
-	dst := filepath.Join(t.TempDir(), filepath.Base(name))
-	if err := os.Rename(src, dst); err != nil {
-		t.Fatal(err)
-	}
-}
-
-func swapOpenVisualOpener(fn func(string) error) func() {
-	prev := openVisualOpener
-	openVisualOpener = fn
-	return func() { openVisualOpener = prev }
-}
-
-func TestOpenVisualMissingWorkspaceNamesResolvedPath(t *testing.T) {
-	root := t.TempDir()
-	var stdout, stderr bytes.Buffer
-
-	code := OpenVisual(root, []string{"demo", "--slug", "ghost"}, &stdout, &stderr)
-	want := filepath.Join(root, "work", "ghost")
-	if code != 2 || !strings.Contains(stderr.String(), `"ghost"`) || !strings.Contains(stderr.String(), want) {
-		t.Fatalf("open-visual missing workspace = %d, want exit 2 naming %q\n%s", code, want, stderr.String())
-	}
-}

package/engine/internal/lib/regression_test.go

@@ -1,282 +0,0 @@
-package lib
-
-import (
-	"bytes"
-	"os"
-	"path/filepath"
-	"strings"
-	"testing"
-)
-
-const regressionTasks = `# Tasks
-
-| Slice | Outcome | Depends on |
-| --- | --- | --- |
-| SLICE-001 | first | none |
-| SLICE-002 | second | SLICE-001 |
-
-## SLICE-001 first
-Goal: one.
-Status: built
-
-## SLICE-002 second
-Goal: two.
-Status: pending
-`
-
-const regressionSpec = `# Spec
-
-## Acceptance criteria
-- [x] AC-001: first thing works
-- [ ] AC-002: second thing works
-`
-
-const regressionGates = `# Gates
-
-- [x] AC-001: first thing works
-  EVIDENCE: attested by reviewer
-- [ ] AC-002: second thing works
-  CHECK: go test ./...
-  EXPECT: ok
-  EVIDENCE: pending
-`
-
-const regressionQuestions = `# Questions
-
-## q-2026-01-01-001 pick a store
-status: answered
-answer: sqlite
-answered_at: 2026-01-02T00:00:00Z
-
-## q-2026-01-01-002 pick a cache
-status: open
-`
-
-func regressionWorkspace(t *testing.T, phase string) (root, featureDir string) {
-	t.Helper()
-	root, featureDir = newWorkspace(t, phase)
-	writeFile(t, filepath.Join(featureDir, "spec.md"), regressionSpec)
-	writeFile(t, filepath.Join(featureDir, "tasks.md"), regressionTasks)
-	writeFile(t, filepath.Join(featureDir, "gates.md"), regressionGates)
-	writeFile(t, filepath.Join(featureDir, "questions.md"), regressionQuestions)
-	return root, featureDir
-}
-
-func checkRegression(t *testing.T, root string, args ...string) (int, string) {
-	t.Helper()
-	stdout, stderr := &bytes.Buffer{}, &bytes.Buffer{}
-	code := RunCheckRegression(root, args, stdout, stderr)
-	return code, stdout.String() + stderr.String()
-}
-
-func TestRegressionUnprovenWithoutBaseline(t *testing.T) {
-	root, _ := regressionWorkspace(t, "build")
-	code, out := checkRegression(t, root, "feat")
-	if code != 0 || !strings.Contains(out, "unproven") {
-		t.Fatalf("code=%d out=%s", code, out)
-	}
-}
-
-func TestRegressionBaselineUpdateThenCleanPass(t *testing.T) {
-	root, _ := regressionWorkspace(t, "build")
-	code, out := checkRegression(t, root, "feat", "--update")
-	if code != 0 || !strings.Contains(out, "baseline updated") {
-		t.Fatalf("update code=%d out=%s", code, out)
-	}
-	code, out = checkRegression(t, root, "feat")
-	if code != 0 || !strings.Contains(out, "PASS") {
-		t.Fatalf("check code=%d out=%s", code, out)
-	}
-}
-
-func TestRegressionDetectsProgressLoss(t *testing.T) {
-	root, dir := regressionWorkspace(t, "prove")
-	if code, out := checkRegression(t, root, "feat", "--update"); code != 0 {
-		t.Fatalf("update code=%d out=%s", code, out)
-	}
-
-	writeFile(t, filepath.Join(dir, "spec.md"), `# Spec
-
-## Acceptance criteria
-- [ ] AC-001: first thing works
-- [ ] AC-002: second thing works
-`)
-	writeFile(t, filepath.Join(dir, "tasks.md"), strings.Replace(regressionTasks, "Status: built", "Status: in-progress", 1))
-	writeFile(t, filepath.Join(dir, "gates.md"), strings.Replace(regressionGates, "- [x] AC-001", "- [ ] AC-001", 1))
-	writeFile(t, filepath.Join(dir, "questions.md"), strings.Replace(regressionQuestions, "status: answered", "status: open", 1))
-	writeFile(t, filepath.Join(dir, "state.md"), "# State\n\n## Cursor\n| Key | Value |\n| --- | --- |\n| phase | build |\n| status | running |\n")
-
-	code, out := checkRegression(t, root, "feat")
-	if code != 3 {
-		t.Fatalf("expected blocked, code=%d out=%s", code, out)
-	}
-	for _, want := range []string{"AC-001", "gate AC-001", "SLICE-001", "q-2026-01-01-001", "phase moved backward"} {
-		if !strings.Contains(out, want) {
-			t.Fatalf("missing %q in:\n%s", want, out)
-		}
-	}
-}
-
-func TestRegressionDetectsRemovedArtifact(t *testing.T) {
-	root, dir := regressionWorkspace(t, "build")
-	if code, _ := checkRegression(t, root, "feat", "--update"); code != 0 {
-		t.Fatalf("update failed")
-	}
-	if err := os.Remove(filepath.Join(dir, "gates.md")); err != nil {
-		t.Fatal(err)
-	}
-	code, out := checkRegression(t, root, "feat")
-	if code != 3 || !strings.Contains(out, "gates.md") {
-		t.Fatalf("code=%d out=%s", code, out)
-	}
-}
-
-func TestRegressionIgnoresFencedDecoys(t *testing.T) {
-	root, dir := regressionWorkspace(t, "build")
-	writeFile(t, filepath.Join(dir, "spec.md"), "# Spec\n\n```\n- [x] AC-099: fenced decoy\n```\n\n## Acceptance criteria\n- [ ] AC-001: real\n")
-	if code, out := checkRegression(t, root, "feat", "--update"); code != 0 {
-		t.Fatalf("update code=%d out=%s", code, out)
-	}
-	writeFile(t, filepath.Join(dir, "spec.md"), "# Spec\n\n## Acceptance criteria\n- [ ] AC-001: real\n")
-	code, out := checkRegression(t, root, "feat")
-	if code != 0 {
-		t.Fatalf("fenced decoy was recorded: code=%d out=%s", code, out)
-	}
-}
-
-func TestRegressionUpdateBlessesAndReports(t *testing.T) {
-	root, dir := regressionWorkspace(t, "build")
-	if code, _ := checkRegression(t, root, "feat", "--update"); code != 0 {
-		t.Fatalf("update failed")
-	}
-	writeFile(t, filepath.Join(dir, "spec.md"), strings.Replace(regressionSpec, "- [x] AC-001", "- [ ] AC-001", 1))
-	code, out := checkRegression(t, root, "feat", "--update")
-	if code != 0 || !strings.Contains(out, "REGRESSION-BLESSED") {
-		t.Fatalf("update code=%d out=%s", code, out)
-	}
-	if code, out := checkRegression(t, root, "feat"); code != 0 {
-		t.Fatalf("post-bless check should pass: code=%d out=%s", code, out)
-	}
-}
-
-func TestRegressionCorruptBaselineBlocks(t *testing.T) {
-	root, dir := regressionWorkspace(t, "build")
-	writeFile(t, filepath.Join(dir, regressionBaselineFile), "{not json")
-	code, out := checkRegression(t, root, "feat")
-	if code != 3 || !strings.Contains(out, "unreadable") {
-		t.Fatalf("code=%d out=%s", code, out)
-	}
-}
-
-func TestRegressionUsageErrors(t *testing.T) {
-	root, _ := regressionWorkspace(t, "build")
-	if code, _ := checkRegression(t, root); code != 2 {
-		t.Fatalf("no args code=%d", code)
-	}
-	if code, _ := checkRegression(t, root, "feat", "--bogus"); code != 2 {
-		t.Fatalf("bad flag code=%d", code)
-	}
-}
-
-func TestRegressionDegradedArtifactRefusesRatchet(t *testing.T) {
-	root, dir := regressionWorkspace(t, "build")
-	if code, out := checkRegression(t, root, "feat", "--update"); code != 0 || !strings.Contains(out, "baseline updated") {
-		t.Fatalf("healthy update code=%d out=%s", code, out)
-	}
-	baselinePath := filepath.Join(dir, regressionBaselineFile)
-	before, err := os.ReadFile(baselinePath)
-	if err != nil {
-		t.Fatal(err)
-	}
-	healthy, err := fingerprintWorkspace(root, "feat", dir)
-	if err != nil || len(healthy.CheckedAC) != 1 || healthy.CheckedAC[0] != "AC-001" {
-		t.Fatalf("healthy fingerprint err=%v checked=%v", err, healthy.CheckedAC)
-	}
-
-	writeFile(t, filepath.Join(dir, "spec.md"), "# Spec\n\n## Acceptance criteria\n- [x] AC-001: a\x00\n")
-	if _, err := fingerprintWorkspace(root, "feat", dir); err == nil || !strings.Contains(err.Error(), "spec.md") {
-		t.Fatalf("degraded fingerprint must name spec.md, err=%v", err)
-	}
-	code, out := checkRegression(t, root, "feat", "--update")
-	if code != 2 || strings.Contains(out, "baseline updated") || !strings.Contains(out, "spec.md") {
-		t.Fatalf("degraded ratchet code=%d out=%s", code, out)
-	}
-	after, err := os.ReadFile(baselinePath)
-	if err != nil || !bytes.Equal(before, after) {
-		t.Fatalf("baseline rewritten from degraded fingerprint: err=%v", err)
-	}
-}
-
-func TestRegressionUpdateRefusesToWipeAcceptanceFacts(t *testing.T) {
-	root, dir := regressionWorkspace(t, "build")
-	if code, out := checkRegression(t, root, "feat", "--update"); code != 0 || !strings.Contains(out, "baseline updated") {
-		t.Fatalf("healthy update code=%d out=%s", code, out)
-	}
-	baselinePath := filepath.Join(dir, regressionBaselineFile)
-	before, err := os.ReadFile(baselinePath)
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	writeFile(t, filepath.Join(dir, "spec.md"), strings.Replace(regressionSpec, "- [x] AC-001", "- [ ] AC-001", 1))
-	writeFile(t, filepath.Join(dir, "gates.md"), strings.Replace(regressionGates, "- [x] AC-001", "- [ ] AC-001", 1))
-
-	code, out := checkRegression(t, root, "feat", "--update")
-	if code != 3 || strings.Contains(out, "baseline updated") || !strings.Contains(out, "--allow-empty") {
-		t.Fatalf("wiping ratchet code=%d out=%s", code, out)
-	}
-	after, err := os.ReadFile(baselinePath)
-	if err != nil || !bytes.Equal(before, after) {
-		t.Fatalf("baseline rewritten by refused wipe: err=%v", err)
-	}
-
-	code, out = checkRegression(t, root, "feat", "--update", "--allow-empty")
-	if code != 0 || !strings.Contains(out, "REGRESSION-BLESSED") || !strings.Contains(out, "baseline updated") {
-		t.Fatalf("explicit wipe code=%d out=%s", code, out)
-	}
-}
-
-func TestRegressionMalformedGatesRefusesRatchet(t *testing.T) {
-	root, dir := regressionWorkspace(t, "build")
-	if code, out := checkRegression(t, root, "feat", "--update"); code != 0 || !strings.Contains(out, "baseline updated") {
-		t.Fatalf("healthy update code=%d out=%s", code, out)
-	}
-	baselinePath := filepath.Join(dir, regressionBaselineFile)
-	before, err := os.ReadFile(baselinePath)
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	writeFile(t, filepath.Join(dir, "gates.md"), strings.Replace(regressionGates, "first thing works", "first thing works\x00", 1))
-	if _, err := fingerprintWorkspace(root, "feat", dir); err == nil || !strings.Contains(err.Error(), "gates.md") {
-		t.Fatalf("malformed gates fingerprint must name gates.md, err=%v", err)
-	}
-	code, out := checkRegression(t, root, "feat", "--update", "--allow-empty")
-	if code != 2 || strings.Contains(out, "baseline updated") || !strings.Contains(out, "gates.md") {
-		t.Fatalf("malformed gates ratchet code=%d out=%s", code, out)
-	}
-	after, err := os.ReadFile(baselinePath)
-	if err != nil || !bytes.Equal(before, after) {
-		t.Fatalf("baseline rewritten from malformed gates: err=%v", err)
-	}
-}
-
-func TestRegressionUnreadablePhaseIsNotPass(t *testing.T) {
-	root, dir := regressionWorkspace(t, "prove")
-	if code, out := checkRegression(t, root, "feat", "--update"); code != 0 || !strings.Contains(out, "baseline updated") {
-		t.Fatalf("healthy update code=%d out=%s", code, out)
-	}
-	if code, out := checkRegression(t, root, "feat"); code != 0 || !strings.Contains(out, "PASS") {
-		t.Fatalf("healthy control code=%d out=%s", code, out)
-	}
-
-	writeFile(t, filepath.Join(dir, "state.md"), "# State\n\n## Cursor\n| Key | Value |\n| --- | --- |\n| status | running |\n")
-	// Premise: the corrupted state.md must leave the phase unobservable.
-	if fp, err := fingerprintWorkspace(root, "feat", dir); err == nil && fp.PhaseOrdinal >= 0 {
-		t.Fatalf("premise failed: phase still observable, ordinal=%d", fp.PhaseOrdinal)
-	}
-	code, out := checkRegression(t, root, "feat")
-	if code == 0 || strings.Contains(out, "PASS") {
-		t.Fatalf("unreadable phase must not pass: code=%d out=%s", code, out)
-	}
-}