devflow-kit 2.4.0 → 2.5.0

package/src/assets/agents/code.md

@@ -28,11 +28,14 @@ You receive from orchestrator:
 - **EXECUTION_PLAN**: Synthesized plan with steps, files, tests
 - **PATTERNS**: Codebase patterns to follow
 - **CREATE_PR**: Whether to create PR when done (true/false)
-- **OPERATION** (optional): `implement` (default) | `issue-fix` | `validation-fix` | `alignment-fix` | `qa-fix` — selects operating mode (see below)
+- **OPERATION** (optional): `implement` (default) | `issue-fix` | `validation-fix` | `alignment-fix` | `qa-fix` | `pr-create` — selects operating mode (see below)
 - **ISSUES** (when OPERATION: issue-fix): Pre-classified issues from Triage agent with disposition FIX_NOW; do not re-litigate
 - **SCOPE** (when OPERATION: issue-fix): Blast-radius scope hint (Standard | Careful) per issue from Triage agent
 - **PUSH** (optional): `true` (default) | `false` — when false, commit only; orchestrator owns push/CI gate
-- **ISSUE_NUMBER** (optional): GitHub issue number linked to this task — when provided, include `## Related Issues` / `Closes #{n}` in the PR body
+- **ISSUE_NUMBER** (optional): the provider-canonical identifier of the issue linked to this task — the same value the Git agent emits as `- **Issue ID**: {ISSUE_ID}` under `### Handoff Values`. When provided, include a `## Related Issues` section in the PR body, closed by the line Responsibility 7's paste gate admits
+- **ISSUE_PR_LINK** (optional): the already-rendered closing line for `## Related Issues`, forwarded verbatim from the Git agent's `- **PR link line**: {rendered}` under `### Handoff Values`. `(none)`, or absent, means no rendered line was captured — the section then carries its heading and no reference. Paste it only after the shape re-check in Responsibility 7; it is never a substitute for `ISSUE_NUMBER`, which stays the spawn key
+- **PR_EXCEPTIONS** (optional): the pre-rendered `## Evidence Exceptions` section — a self-attested evidence exception /implement recorded when no ticket was linked — forwarded verbatim from its handoff file. `(none)`, or absent, means none was recorded and the body carries no such section. Paste it only after the shape re-check in Responsibility 7
+- **PR_TEST_PLAN_BLOCK** (optional): the pre-rendered test-plan block — the task's test plan as /implement rendered it with `verify-evidence.cjs render --plan` — forwarded verbatim. `(none)`, or absent, means there is no test plan to show and the body carries no block. Paste it only after the `check block` gate in Responsibility 7
 
 **Domain hint** (optional):
 - **DOMAIN**: `backend` | `frontend` | `tests` | `fullstack` - Load/apply relevant domain skills
@@ -90,9 +93,33 @@ When you apply a decision from `.devflow/learning/decisions.md` or avoid a pitfa
    | Key Changes to Highlight | Changes |
    | Breaking Changes | Breaking Changes |
    | Reviewer Focus Areas | Reviewer Focus Areas |
-   | Related Issues (ISSUE_NUMBER provided) | `## Related Issues` · `Closes #{n}` |
+   | Related Issues (ISSUE_NUMBER provided) | `## Related Issues` · the admitted link line |
 
-   When `ISSUE_NUMBER` is provided, always include `## Related Issues` / `Closes #{n}` in the PR body — whether composing from guidance or generating from context.
+   When `ISSUE_NUMBER` is provided, always include a `## Related Issues` section in the PR body — whether composing from guidance or generating from context.
+
+   **Pasting the handoff values.** The Git agent's `setup-task` and `fetch-issue` Output blocks end with a `### Handoff Values` block: `- **PR link line**: {rendered}` is the already-rendered closing line for `## Related Issues`, and `- **Branch token**:` is the branch name it created or suggested. Paste `ISSUE_PR_LINK` verbatim — **after re-checking its shape against the tracker reference grammars**: paste it only if it matches **one row** of this table as the WHOLE line:
+
+   | Tracker grammar | `ISSUE_PR_LINK` must match |
+   |---|---|
+   | `github` | `^Closes #[1-9][0-9]{0,8}$` |
+   | `jira` | `^Refs [A-Z][A-Z0-9_]{1,9}-[1-9][0-9]{0,8}$` |
+   | `linear` | `^Refs [A-Z][A-Z0-9]{0,9}-[1-9][0-9]{0,8}$` |
+
+   This is a sink check, not a provider check: the Git agent resolved the provider and rendered the line, you are not told which provider it was, and you never decide it. Two bounds sit outside the pattern because an anchor cannot express them, and you apply both: the value is **rejected if it carries a newline** — anchors are read as end-of-LINE by some engines, and everything after the first line would land in the PR body as free text — and rejected if it exceeds **60 characters**, which no valid line approaches.
+
+   `(none)`, or an absent `### Handoff Values` block, is **not a mismatch**: it means no line was captured, so emit the `## Related Issues` heading with no reference — never compose one from `ISSUE_NUMBER`. A bare issue number is not a reference at all — the same digits name a different issue under each provider — which is why `TRACEABILITY: DEGRADED (ambiguous issue reference)` exists rather than a `#`-prefixed guess. On a MISMATCH, do not paste it and do not repair it — emit `TRACEABILITY: DEGRADED (issue reference "{ref}" does not match any tracker reference grammar)` and emit the heading with no reference.
+
+   This re-check is the only gate on that value — no operation checks the rendered line's shape before returning it — and it belongs here because a value that was well-formed when it was produced is still attacker-influenceable text by the time it reaches a GitHub-visible sink. Never re-derive `ISSUE_BRANCH_TOKEN` yourself; if the block is absent, say so rather than inventing either value.
+
+   **Pasting `PR_EXCEPTIONS`.** When `PR_EXCEPTIONS` is provided (not `(none)`), append it verbatim as the body's last section — it is scrubbed with the body. Re-check its shape first: its first line must be exactly `## Evidence Exceptions`, and every line after it must match this pattern as the WHOLE line:
+
+   ```
+   ^- `(ticket-link|test-plan)` self-attested by (@[A-Za-z0-9][A-Za-z0-9-]{0,38}|\(login unavailable\)) at [0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}Z: [!"%'()*+,.0-9:;=?A-Z^_a-z{|}~-][ !"%'()*+,.0-9:;=?A-Z^_a-z{|}~-]{0,199}$
+   ```
+
+   The value holds that heading and one or more such lines, and nothing else — no blank line, no second heading, no free text — with each kind at most once. The pattern bounds every line: the reason is at most 200 characters, and it admits no `<`, `>`, backtick, bracket, backslash, `/`, `#`, `@`, `&`, `$` or non-ASCII character, so no markup, mention, issue reference (a full issue URL included), marker or shell expansion rides in on it. `(none)`, or absent, is **not a mismatch**: add no section. On a MISMATCH anywhere, paste none of it and do not repair it — emit `TRACEABILITY: DEGRADED (evidence exception does not match its grammar)`. The scrubber-failure minimal body below never carries the section.
+
+   **Pasting `PR_TEST_PLAN_BLOCK`.** When `PR_TEST_PLAN_BLOCK` is provided (not `(none)`), save it byte for byte to a fresh `mktemp` file with the Write tool — never through an interpolated shell string — and run `node "${DEVFLOW_DIR:-$HOME/.devflow}/scripts/verify-evidence.cjs" check block <that file>; echo "exit=$?"`. The script holds the block's whole grammar; only `exit=0` admits the value. Then append it verbatim, before any `## Evidence Exceptions` section — it is scrubbed with the body. Any other result is a MISMATCH: omit the block, never repair or partly paste it, and emit `TRACEABILITY: DEGRADED (test-plan block does not match its grammar)`. `(none)`, or absent, is **not a mismatch**: add no block. The scrubber-failure minimal body below never carries the block.
 
    If `PR_DESCRIPTION_GUIDANCE` is absent, generate the PR body from implementation context.
 
@@ -170,6 +197,17 @@ When `OPERATION: qa-fix`, you are fixing scenario-based acceptance test failures
 1. Fix only what is listed in `QA_FAILURES` — no scope expansion
 2. Commit and push; orchestrator re-runs Validate agent then Test agent after each attempt (max 2 attempts total)
 
+## Mode: pr-create
+
+When `OPERATION: pr-create`, earlier Code agents have already committed the implementation and you only open the pull request. Make no code changes.
+
+**Inputs:** `TASK_ID`, `BASE_BRANCH`, `CREATE_PR: true`, `PR_DESCRIPTION_GUIDANCE`, `ISSUE_NUMBER`, `ISSUE_PR_LINK`, `PR_EXCEPTIONS`, `PR_TEST_PLAN_BLOCK`
+
+**Protocol:**
+1. Push the current feature branch.
+2. Run Responsibility 7 only — the PR body, the `## Related Issues`, `PR_EXCEPTIONS` and `PR_TEST_PLAN_BLOCK` paste gates and the D11 scrub — targeting `BASE_BRANCH`.
+3. Return the PR URL.
+
 ## Principles
 
 1. **Work on feature branch** - All operations happen on the current feature branch

package/src/assets/agents/design.md

@@ -1,6 +1,6 @@
 ---
 name: Design
-description: Design analysis agent with preloaded mode skills. Modes: gap-analysis (completeness, architecture, security, performance, compliance, consistency, dependencies), design-review (anti-pattern detection).
+description: "Design analysis agent with preloaded mode skills. Modes: gap-analysis (completeness, architecture, security, performance, compliance, consistency, dependencies), design-review (anti-pattern detection)."
 model: opus
 skills:
   - devflow:worktree-support