devflow-kit 2.4.0 → 2.5.0

package/dist/core/manifest.js

@@ -3,6 +3,7 @@ import * as path from 'path';
 import { LEGACY_PLUGIN_NAMES, DELETED_PLUGIN_NAMES } from './plugins.js';
 import { VIEW_MODES, migrateLegacyFlagsToRecord, sanitizeFlagsRecord, } from './flags.js';
 import { normalizeComplianceFeature } from './compliance.js';
+import { normalizeTrackerFeature } from './tracker.js';
 import { writeFileAtomicExclusive } from './fs-atomic.js';
 /**
  * Parse features.flags across the three on-disk shapes; reports whether a heal is owed.
@@ -54,13 +55,14 @@ function parseManifestFlags(features, knownFlags) {
  * Read and parse the manifest file. Returns null if missing or corrupt.
  *
  * Self-heals the following on-disk inconsistencies (applies ADR-014):
- * - features.kb → features.knowledge rename
- * - features.decisions → features.learning rename
+ * - features.kb → features.knowledge rename (both absent → true, D-FEATURES-ABSENT-ON)
+ * - features.decisions → features.learning rename (both absent → true, D-FEATURES-ABSENT-ON)
  * - features.flags as string[] → FlagsRecord (via migrateLegacyFlagsToRecord)
  * - features.viewMode folded into flags['view-mode'] and stripped from result
  * - features.knownFlags stripped from result (folded into FlagsRecord key-presence)
  * - features.proxy absent → false
  * - features.compliance absent/malformed → {enabled:false, frameworks:[]}
+ * - features.tracker absent/malformed → {provider:'github'}
  *
  * D39: heal-write failure returns the migrated in-memory manifest (not null).
  * The on-disk format remains unhealed; next read triggers another attempt.
@@ -82,15 +84,33 @@ export async function readManifest(devflowDir) {
             typeof data.updatedAt !== 'string') {
             return null;
         }
-        // Self-heal: rename features.kb → features.knowledge on disk
+        // D-FEATURES-ABSENT-ON (a sub-decision of D-FEATURES-MACHINE-WIDE,
+        // src/core/feature-switch.ts): knowledge and learning are machine-wide
+        // switches, and every runtime gate — queue_read_gates in the hooks,
+        // isMachineFeatureOn in the CLI, the knowledge write-back prose gate — reads
+        // an ABSENT key as ON. This reader must agree: init seeds from it and every
+        // syncManifestFeature toggle writes its result back, so a `false` default
+        // here would persist "off" for a feature the runtime is running — a plain
+        // re-init or `devflow hud --enable` on an older manifest silently switching
+        // it off machine-wide. Explicit booleans (and their legacy names) are kept
+        // as they are. memory needs no default: it is in the hard-null set above,
+        // so a manifest without it reads as no prior install and init seeds
+        // FEATURE_DEFAULTS.memory (true).
+        //
+        // Self-heal: rename features.kb → features.knowledge on disk.
+        // Coalesce: features.knowledge wins; fall back to features.kb; default ON.
+        // D-KNOWLEDGE-LEGACY-KB: isMachineFeatureOn applies this exact precedence,
+        // so the legacy key is honoured before the heal lands.
         const knowledge = typeof features.knowledge === 'boolean' ? features.knowledge
             : typeof features.kb === 'boolean' ? features.kb
-                : false;
-        // Self-heal: rename features.decisions → features.learning on disk
-        // Coalesce: features.learning wins; fall back to features.decisions; default false.
+                : true;
+        // Self-heal: rename features.decisions → features.learning on disk (ADR-011).
+        // Coalesce: features.learning wins; fall back to features.decisions; default ON.
+        // D-LEARNING-LEGACY-DECISIONS: isMachineFeatureOn and queue_read_gates apply
+        // this exact precedence, so the legacy key is honoured before the heal lands.
         const learning = typeof features.learning === 'boolean' ? features.learning
             : typeof features.decisions === 'boolean' ? features.decisions
-                : false;
+                : true;
         // Self-heal: non-string-array or absent knownFlags/knownPlugins → undefined (never partial/garbage)
         const asStringArray = (val) => Array.isArray(val) && val.every(e => typeof e === 'string')
             ? val
@@ -138,6 +158,12 @@ export async function readManifest(devflowDir) {
                 proxy: typeof features.proxy === 'boolean' ? features.proxy : false,
                 // Self-heal: absent/malformed compliance → {enabled:false, frameworks:[]}
                 compliance: normalizeComplianceFeature(features.compliance),
+                // Self-heal: absent/malformed/unknown tracker → {provider:'github'} (AC-3.21).
+                // Deliberately NOT in the hard-null set above — see the field's doc comment.
+                // Healing here is silent and emits no DEGRADED: that is the correct
+                // ADR-014 behaviour, and a different condition from a per-repo config
+                // value outside the domain (which does emit `unknown tracker provider`).
+                tracker: normalizeTrackerFeature(features.tracker),
             },
             installedAt: data.installedAt,
             updatedAt: data.updatedAt,