devflow-kit 1.8.2 → 2.0.0

package/plugins/devflow-core-skills/skills/git-workflow/references/pr-patterns.md

@@ -1,127 +0,0 @@
-# Pull Request Patterns
-
-Correct patterns for high-quality PRs.
-
----
-
-## Full PR Description Template
-
-```markdown
-## Summary
-
-{2-3 sentence overview of what this PR does and why}
-
-## Changes
-
-### Features
-- Feature 1 with brief description
-
-### Bug Fixes
-- Fix 1 with impact description
-
-### Refactoring
-- Refactor 1 with rationale
-
-## Breaking Changes
-
-{List breaking changes that require user action, or "None"}
-
-## Testing
-
-### Test Coverage
-- {N} test files modified/added
-- {What's tested}
-
-### Manual Testing
-1. Test scenario 1: steps
-2. Test scenario 2: steps
-
-### Testing Gaps
-{Honest assessment of what's NOT tested}
-
-## Security Considerations
-
-{Security-relevant changes, or "No security impact"}
-
-## Performance Impact
-
-{Expected performance changes, or "No performance impact expected"}
-
-## Deployment Notes
-
-{Special deployment instructions, or "No special deployment steps"}
-
-## Related Issues
-
-Closes #{issue}
-Related to #{issue}
-
-## Reviewer Focus Areas
-
-1. {file:line} - {why this needs attention}
-2. {file:line} - {why this needs attention}
-
----
-
-Generated with [Claude Code](https://claude.com/claude-code)
-```
-
----
-
-## Creating the PR with HEREDOC
-
-```bash
-gh pr create \
-  --base main \
-  --title "feat(auth): add authentication middleware" \
-  --body "$(cat <<'EOF'
-## Summary
-
-Implements JWT-based authentication...
-
-[Full description content]
-
-Generated with [Claude Code](https://claude.com/claude-code)
-EOF
-)"
-```
-
----
-
-## Key Change Detection
-
-| Change Type | Detection | Action |
-|-------------|-----------|--------|
-| Breaking Changes | `grep -i "BREAKING CHANGE" commits` | **MANDATORY** section |
-| Database Migrations | `migration\|schema` in file names | Highlight + deployment notes |
-| Dependency Changes | `package.json`, `Cargo.toml`, etc. | List versions changed |
-| Config Changes | `.config.`, `.yml`, `.toml` | Note configuration impact |
-| Missing Tests | Source changed, no test files | **WARN** in Testing Gaps |
-
----
-
-## Size Guidelines
-
-| Size | Lines Changed | Review Time | Recommendation |
-|------|---------------|-------------|----------------|
-| Small | < 200 | 15 min | Ideal |
-| Medium | 200-500 | 30 min | Acceptable |
-| Large | 500-1000 | 1 hour | Consider splitting |
-| XL | > 1000 | Hours | **Must split** |
-
----
-
-## Pre-Flight Check Script
-
-```bash
-# 1. Verify commits exist
-COMMITS_AHEAD=$(git rev-list --count main..HEAD)
-[ "$COMMITS_AHEAD" -eq 0 ] && echo "ERROR: No commits to review" && exit 1
-
-# 2. Check for existing PR
-PR_EXISTS=$(gh pr list --head "$(git branch --show-current)" --json number --jq '.[0].number')
-[ -n "$PR_EXISTS" ] && echo "PR #$PR_EXISTS already exists" && exit 1
-
-# 3. Ensure branch is pushed
-git ls-remote --exit-code --heads origin "$(git branch --show-current)" || git push -u origin "$(git branch --show-current)"
-```

package/plugins/devflow-core-skills/skills/git-workflow/references/pr-violations.md

@@ -1,96 +0,0 @@
-# Pull Request Violations
-
-Common PR anti-patterns and how to fix them.
-
----
-
-## Violation Table
-
-| Violation | Problem | Fix |
-|-----------|---------|-----|
-| Vague descriptions | Reviewers can't understand changes | Use structured template |
-| Hidden breaking changes | Consumers surprised | Document explicitly |
-| Massive PRs (>1000 lines) | Impossible to review | Split into smaller PRs |
-| Missing test plan | Unknown coverage | Include manual/automated test steps |
-| No related issues | Lost context | Link to issues/tickets |
-| Dishonest limitations | Technical debt hidden | Disclose honestly |
-
----
-
-## Vague Description Examples
-
-```markdown
-# BAD: Vague
-## Summary
-Fixed some bugs and added features.
-
-# GOOD: Specific
-## Summary
-- Fix: Null pointer exception in UserService when email is empty
-- Feat: Add rate limiting to /api/login endpoint (5 req/min)
-```
-
----
-
-## Hidden Breaking Changes
-
-```markdown
-# BAD: Breaking change buried in code
-## Summary
-Refactored authentication module.
-
-# GOOD: Breaking changes called out
-## Breaking Changes
-- `authenticate(token)` now returns `Result<User, AuthError>` instead of `User | null`
-- Required migration: Run `npm run migrate:auth` before deploying
-```
-
----
-
-## Massive PR Split Recommendation
-
-```markdown
-PR SIZE WARNING
-
-This PR changes {X} files and {Y} lines. Consider splitting:
-
-1. PR 1: {Component A} - {files}
-2. PR 2: {Component B} - {files}
-3. PR 3: {Tests} - {files}
-
-Rationale: Smaller PRs are easier to review, safer to merge.
-```
-
----
-
-## Missing Test Plan
-
-```markdown
-# BAD: No testing information
-## Summary
-Added new payment processing.
-
-# GOOD: Clear test plan
-## Testing
-### Automated
-- 12 unit tests for PaymentService
-- 3 integration tests for Stripe webhook
-
-### Gaps
-- Edge case: Partial refunds not tested (tracked in #456)
-```
-
----
-
-## Dishonest Limitations
-
-```markdown
-# BAD: Hiding technical debt
-## Summary
-Implemented caching layer.
-
-# GOOD: Honest about limitations
-## Limitations
-- Cache invalidation not implemented (tracked in #789)
-- Memory usage not bounded - add eviction policy before production load
-```

package/plugins/devflow-core-skills/skills/github-patterns/SKILL.md

@@ -1,153 +0,0 @@
----
-name: github-patterns
-description: This skill should be used when the user asks to "comment on a PR", "create a release", "manage issues", "use gh CLI", "check PR status", or performs GitHub API operations. Provides patterns for PR comments, issue management, release workflows, rate limiting, and gh CLI usage for safe GitHub automation.
-user-invocable: false
-allowed-tools: Bash, Read, Grep, Glob
----
-
-# GitHub Patterns
-
-Foundation skill for GitHub API interactions. Provides patterns for rate limiting, PR comments, issue management, and releases.
-
-## Iron Law
-
-> **RESPECT RATE LIMITS OR FAIL GRACEFULLY**
->
-> GitHub API rate limits are not suggestions. When remaining < 10, wait 60 seconds. Between each API call, wait 1-2 seconds. Batch operations where possible. Never spam the API.
-
----
-
-## Rate Limiting
-
-### Standard Throttling
-
-```bash
-# Between each API call
-sleep 1
-
-# For batch operations (>20 calls)
-sleep 2
-
-# Check remaining rate limit
-REMAINING=$(gh api rate_limit --jq '.resources.core.remaining')
-
-# If low, wait before continuing
-if [ "$REMAINING" -lt 10 ]; then
-    echo "Rate limit low ($REMAINING remaining), waiting 60s..."
-    sleep 60
-fi
-```
-
-### Error Handling
-
-```bash
-make_api_call() {
-    local response
-    response=$(gh api "$@" 2>&1) || {
-        echo "API call failed: $response" >&2
-        return 1
-    }
-    echo "$response"
-}
-```
-
----
-
-## PR Comments
-
-**Key constraints:**
-- Only lines in the PR diff can receive inline comments
-- Deduplicate before posting (same file + line + issue = keep one)
-- Always include suggested fix
-- Add Claude Code attribution footer
-
-```bash
-# Verify file is in PR diff
-gh pr diff $PR_NUMBER --name-only | grep -q "^$FILE_PATH$"
-
-# Create inline comment
-gh api -X POST "repos/${OWNER}/${REPO}/pulls/${PR_NUMBER}/comments" \
-  -f body="$COMMENT_BODY" \
-  -f commit_id="$HEAD_SHA" \
-  -f path="$FILE_PATH" \
-  -F line=$LINE_NUMBER \
-  -f side="RIGHT"
-
-sleep 1  # Rate limiting
-```
-
----
-
-## Issue Management
-
-### Fetching Issues
-
-```bash
-# Full details
-gh issue view "$ISSUE_NUMBER" --json number,title,body,state,labels,assignees
-
-# Search
-gh issue list --search "$SEARCH_TERM" --state open --limit 5
-```
-
-### Branch Name from Issue
-
-```bash
-# Type from labels
-BRANCH_TYPE="feature"  # default (or fix, docs, refactor, chore)
-
-# Slug from title
-SLUG=$(echo "$TITLE" | tr '[:upper:]' '[:lower:]' | tr ' ' '-' | sed 's/[^a-z0-9-]//g' | cut -c1-40)
-
-# Result
-BRANCH_NAME="${BRANCH_TYPE}/${ISSUE_NUMBER}-${SLUG}"
-```
-
----
-
-## Releases
-
-### Create Release
-
-```bash
-# Validate semver
-[[ "$VERSION" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]] || exit 1
-
-# Create tag
-git tag -a "v${VERSION}" -m "Version ${VERSION}"
-git push origin "v${VERSION}"
-
-# Create GitHub release
-gh release create "v${VERSION}" \
-    --title "v${VERSION} - ${RELEASE_TITLE}" \
-    --notes "${RELEASE_NOTES}"
-```
-
----
-
-## Key Principles
-
-1. **Rate limit awareness** - Check remaining calls, throttle appropriately
-2. **Fail gracefully** - Handle API errors, don't crash on failures
-3. **Deduplicate first** - Never spam duplicate comments or issues
-4. **One summary** - Consolidate multiple issues into single comments
-5. **Actionable** - Every comment includes a suggested fix
-6. **Clear attribution** - Always include Claude Code footer
-
----
-
-## Extended References
-
-For extended patterns and examples, see:
-
-- **[references/commands.md](references/commands.md)** - Extended gh CLI command examples
-  - PR creation and queries
-  - Issue operations (create, update, close)
-  - Release workflows
-  - GraphQL examples
-
-- **[references/api.md](references/api.md)** - API patterns
-  - Tech debt management (size limits, archiving, deduplication)
-  - Issue parsing patterns
-  - Error handling with retry/backoff
-  - Webhook and Actions integration