devflow-kit 1.8.2 → 2.0.0

package/plugins/devflow-core-skills/skills/git-safety/references/patterns.md

@@ -1,289 +0,0 @@
-# Git Safety Patterns
-
-Correct patterns for safe git operations.
-
----
-
-## Core Patterns
-
-### Sequential Operations
-
-```bash
-# Always chain git commands with &&
-git add file.ts && git commit -m "message" && git push
-
-# Never run in parallel - use sequential execution
-```
-
-### Lock Handling
-
-```bash
-# Check for and wait on locks
-wait_for_lock_release() {
-  while [ -f .git/index.lock ]; do
-    sleep 0.1
-  done
-}
-```
-
-### Safe Amend
-
-```bash
-# Only amend if not pushed
-if ! git log origin/$(git branch --show-current)..HEAD | grep -q .; then
-  git commit --amend  # Safe - not pushed
-fi
-```
-
----
-
-## Lock File Handling - Full Implementation
-
-```bash
-# Function to wait for lock file release
-wait_for_lock_release() {
-    local max_wait=10
-    local waited=0
-    while [ -f .git/index.lock ]; do
-        if [ $waited -ge $max_wait ]; then
-            echo "ERROR: .git/index.lock still exists after ${max_wait}s"
-            echo "Another git process may be running, or a process crashed."
-            echo "Check: ps aux | grep git"
-            return 1
-        fi
-        echo "Waiting for git lock to be released... (${waited}s)"
-        sleep 1
-        waited=$((waited + 1))
-    done
-    return 0
-}
-
-# Always call before git operations
-wait_for_lock_release || exit 1
-```
-
----
-
-## Complete Commit Flow
-
-```bash
-# 1. Wait for lock
-wait_for_lock_release || exit 1
-
-# 2. Check what's changing
-git status --porcelain
-
-# 3. Review changes
-git diff HEAD --stat
-
-# 4. Stage specific files (not blind 'git add .')
-git add src/specific-file.ts
-
-# 5. Create commit with proper message
-git commit -m "$(cat <<'EOF'
-type(scope): summary
-
-Description
-
-EOF
-)"
-
-# 6. Verify
-git log -1 --stat
-git status
-```
-
----
-
-## Safe Push Workflow
-
-```bash
-# Check remote status first
-git fetch origin
-git status
-
-# If behind, pull first
-if git status | grep -q "behind"; then
-    git pull --rebase origin $(git branch --show-current)
-fi
-
-# Push
-git push -u origin $(git branch --show-current)
-```
-
----
-
-## Protected Branch Check
-
-```bash
-PROTECTED_BRANCHES="main master develop"
-
-check_protected_branch() {
-    local branch="$1"
-    for protected in $PROTECTED_BRANCHES; do
-        if [ "$branch" = "$protected" ]; then
-            echo "ERROR: Cannot force push to $branch"
-            return 1
-        fi
-    done
-    return 0
-}
-```
-
----
-
-## Pre-commit Hook Handling
-
-### If Hook Modifies Files
-
-```bash
-# Run commit
-git commit -m "message"
-
-# If hook modified files, amend to include them
-git add .
-git commit --amend --no-edit
-```
-
-### If Hook Rejects Commit
-
-```bash
-# DO NOT amend - fix the issue and create new commit
-
-# Fix the issue
-eslint --fix src/
-
-# Stage and commit fresh
-git add .
-git commit -m "fix: resolve linting issues"
-```
-
----
-
-## Amend Verification
-
-```bash
-# Check if commit is pushed
-if git status | grep -q "Your branch is ahead"; then
-    echo "Safe to amend - not pushed"
-else
-    echo "DANGER: May be pushed - do NOT amend"
-fi
-
-# Verify commit author
-git log -1 --format='%an %ae'
-```
-
----
-
-## Recovery Workflows
-
-### Undo Last Commit (not pushed)
-
-```bash
-# Keep changes staged
-git reset --soft HEAD~1
-
-# Keep changes unstaged
-git reset HEAD~1
-
-# Discard changes (DANGEROUS)
-git reset --hard HEAD~1
-```
-
-### Recover Deleted Branch
-
-```bash
-# Find the commit
-git reflog
-
-# Recreate branch
-git checkout -b recovered-branch <commit-sha>
-```
-
-### Fix Wrong Branch
-
-```bash
-# If committed to wrong branch
-git reset --soft HEAD~1
-git stash
-git checkout correct-branch
-git stash pop
-git commit -m "message"
-```
-
-### Stash Handling
-
-```bash
-# Save work temporarily
-git stash push -m "description of changes"
-
-# List stashes
-git stash list
-
-# Apply most recent stash (keep in stash list)
-git stash apply
-
-# Apply and remove from list
-git stash pop
-
-# Apply specific stash
-git stash apply stash@{2}
-
-# Drop specific stash
-git stash drop stash@{0}
-
-# Clear all stashes (DANGEROUS)
-git stash clear
-```
-
-### Interactive Stash Recovery
-
-```bash
-# Show stash contents
-git stash show -p stash@{0}
-
-# Create branch from stash
-git stash branch new-branch stash@{0}
-```
-
----
-
-## Branch Naming Examples
-
-```bash
-# Feature branches
-git checkout -b feat/short-description
-
-# Bug fixes
-git checkout -b fix/issue-123-description
-
-# Releases
-git checkout -b release/v1.2.0
-
-# Hotfixes
-git checkout -b hotfix/critical-fix
-```
-
----
-
-## Sequential Operation Patterns
-
-```bash
-# WRONG - parallel execution
-git add . &
-git status &
-wait
-
-# CORRECT - sequential with && chains
-wait_for_lock_release && \
-git add . && \
-git status && \
-echo "Done"
-```
-
----
-
-## Quick Reference
-
-See [detection.md](detection.md) for sensitive file patterns.

package/plugins/devflow-core-skills/skills/git-safety/references/violations.md

@@ -1,18 +0,0 @@
-# Git Safety Violations
-
-Common git safety violations:
-
-## Violations
-
-| Violation | Risk | Fix |
-|-----------|------|-----|
-| Parallel git commands | Index corruption | Run git commands sequentially |
-| Force push to main | Lost commits | Never force push protected branches |
-| Committing secrets | Security breach | Use [detection.md](detection.md) patterns |
-| Amending after push | History rewrite | Create new commit instead |
-| Skipping hooks | Quality bypass | Never use `--no-verify` |
-| Ignoring lock files | Corruption | Wait for lock release |
-
-## Quick Reference
-
-See [commands.md](commands.md) for safe command patterns and [detection.md](detection.md) for sensitive file detection.

package/plugins/devflow-core-skills/skills/git-workflow/SKILL.md

@@ -1,158 +0,0 @@
----
-name: git-workflow
-description: This skill should be used when the user asks to "commit changes", "create a pull request", "stage files", "prepare for review", "write a commit message", or runs git add, git commit, git push, or gh pr operations. Provides atomic commit patterns, conventional commit formatting, PR description templates, and honest change documentation.
-user-invocable: false
-allowed-tools: Bash, Read, Grep, Glob
----
-
-# Git Workflow
-
-Atomic commits and honest PR descriptions. Complements git-safety with commit and PR-specific patterns.
-
-## Iron Law
-
-> **ATOMIC COMMITS WITH HONEST DESCRIPTIONS**
->
-> Every commit MUST represent a single logical change. Every PR description MUST accurately
-> reflect ALL changes, risks, and testing gaps. Mixed concerns, hidden limitations, and
-> dishonest descriptions are violations. No exceptions.
-
----
-
-## Commit Message Format
-
-### Structure
-
-```
-<type>(<scope>): <short summary> (max 50 chars)
-
-<optional body explaining what and why>
-<wrap at 72 characters>
-
-<optional footer with references>
-
-Co-Authored-By: Claude <noreply@anthropic.com>
-```
-
-### Types
-
-| Type | Use When |
-|------|----------|
-| `feat` | New feature or capability |
-| `fix` | Bug fix |
-| `docs` | Documentation only changes |
-| `style` | Code style/formatting (no logic change) |
-| `refactor` | Code change that neither fixes nor adds |
-| `test` | Adding or updating tests |
-| `chore` | Build, dependencies, tooling |
-| `perf` | Performance improvements |
-
-### HEREDOC Format (Required)
-
-Always use HEREDOC for commit messages to handle special characters:
-
-```bash
-git commit -m "$(cat <<'EOF'
-feat(auth): add JWT token validation
-
-Implement token validation middleware with:
-- Signature verification
-- Expiration checking
-- Role-based access control
-
-Closes #123
-
-Co-Authored-By: Claude <noreply@anthropic.com>
-EOF
-)"
-```
-
-## Atomic Commit Grouping
-
-1. **By Feature/Module**: Changes within same directory or module
-2. **By Type**: Source code, tests, docs, config separately
-3. **By Relationship**: Files that change together for single logical purpose
-
-### Anti-Patterns
-
-- **Grab-bag commits**: "Various fixes and updates" - VIOLATION
-- **Mixed concerns**: Feature + refactor + fix in one commit - VIOLATION
-- **Blind staging**: `git add .` without review - VIOLATION
-
----
-
-## Pull Request
-
-### PR Title Format
-
-```
-<type>(<scope>): <description>
-```
-
-**Rules**: Under 72 characters, imperative mood, specific but concise.
-
-### PR Description Structure
-
-Every PR description MUST include these sections:
-
-| Section | Purpose |
-|---------|---------|
-| Summary | 2-3 sentences: what and why |
-| Changes | Features, fixes, refactoring by category |
-| Breaking Changes | User action required (or "None") |
-| Testing | Coverage, manual steps, gaps |
-| Related Issues | Closes/relates to links |
-
-### Size Assessment
-
-| Size | Lines Changed | Action |
-|------|---------------|--------|
-| Small | < 200 | Proceed normally |
-| Medium | 200-500 | Consider splitting if unrelated changes |
-| Large | 500-1000 | Recommend splitting |
-| Very Large | > 1000 | **WARN**: Split into smaller PRs |
-
----
-
-## Safety Checks
-
-Before staging files, apply sensitive file detection and content scanning patterns from `git-safety` skill.
-
-## Pre-Commit Checklist
-
-- [ ] Changes are atomic (single logical change)
-- [ ] No sensitive files included
-- [ ] No secrets in file content
-- [ ] Commit message follows format
-- [ ] Message explains "what" and "why"
-- [ ] Related files grouped together
-
-## Description Quality Checklist
-
-- [ ] Summary clearly explains what and why
-- [ ] Breaking changes documented (or explicitly "None")
-- [ ] Testing gaps honestly disclosed
-- [ ] Related issues linked
-- [ ] Size assessed and split recommended if needed
-
----
-
-## Extended References
-
-For extended examples and templates:
-
-| Reference | Contents |
-|-----------|----------|
-| `references/commit-patterns.md` | Multi-commit flows, bug fix patterns, breaking changes |
-| `references/commit-violations.md` | Grab-bag commits, blind staging, vague messages |
-| `references/pr-patterns.md` | Full PR template, key change detection, pre-flight scripts |
-| `references/pr-violations.md` | Vague descriptions, hidden breaking changes, massive PRs |
-
----
-
-## Related Skills
-
-| Skill | Use For |
-|-------|---------|
-| `git-safety` | Lock handling, sequential ops, sensitive file detection |
-| `github-patterns` | GitHub API, rate limits, PR comments, releases |

package/plugins/devflow-core-skills/skills/git-workflow/references/commit-patterns.md

@@ -1,115 +0,0 @@
-# Commit Patterns
-
-Correct commit practices for atomic, well-documented history.
-
----
-
-## Message Format
-
-```
-<type>(<scope>): <short summary> (max 50 chars)
-
-<optional body explaining what and why>
-<wrap at 72 characters>
-
-<optional footer with references>
-
-Co-Authored-By: Claude <noreply@anthropic.com>
-```
-
-Always use HEREDOC for commit messages:
-
-```bash
-git commit -m "$(cat <<'EOF'
-feat(auth): add JWT token validation
-
-Implement token validation middleware with:
-- Signature verification
-- Expiration checking
-- Role-based access control
-
-Closes #123
-
-Co-Authored-By: Claude <noreply@anthropic.com>
-EOF
-)"
-```
-
----
-
-## Atomic Commit Examples
-
-### Feature Implementation (Multi-Commit Flow)
-
-```bash
-# Step 1: Core implementation
-git add src/services/user-service.ts src/models/user.ts && \
-git commit -m "feat(users): add user service with CRUD operations"
-
-# Step 2: Tests for the feature
-git add tests/services/user-service.test.ts && \
-git commit -m "test(users): add comprehensive user service tests"
-
-# Step 3: API endpoint
-git add src/routes/users.ts src/middleware/user-validation.ts && \
-git commit -m "feat(api): add user API endpoints"
-
-# Step 4: Documentation
-git add docs/api/users.md && \
-git commit -m "docs(api): document user endpoints"
-```
-
-### Bug Fix (Isolated Change)
-
-```bash
-git add src/utils/date-parser.ts tests/utils/date-parser.test.ts && \
-git commit -m "$(cat <<'EOF'
-fix(dates): handle timezone offset in ISO date parsing
-
-Previous implementation assumed UTC, causing off-by-one errors
-for dates near midnight in non-UTC timezones.
-
-Fixes #456
-
-Co-Authored-By: Claude <noreply@anthropic.com>
-EOF
-)"
-```
-
-### Breaking Changes
-
-```bash
-git commit -m "$(cat <<'EOF'
-feat(api)!: change response format to JSON:API spec
-
-BREAKING CHANGE: API responses now follow JSON:API specification.
-All clients must update to handle new response structure.
-
-Migration guide: docs/migration/v2-response-format.md
-
-Co-Authored-By: Claude <noreply@anthropic.com>
-EOF
-)"
-```
-
----
-
-## Splitting Mixed Changes
-
-```bash
-# Check what's changed
-git status
-git diff --stat
-
-# Stage only related files for first commit
-git add src/auth/*.ts
-git commit -m "feat(auth): add session management"
-
-# Stage tests for that feature
-git add tests/auth/*.ts
-git commit -m "test(auth): add session management tests"
-
-# Stage unrelated refactoring
-git add src/utils/string-helpers.ts
-git commit -m "refactor(utils): simplify string helper functions"
-```

package/plugins/devflow-core-skills/skills/git-workflow/references/commit-violations.md

@@ -1,77 +0,0 @@
-# Commit Violations
-
-Common commit anti-patterns to avoid.
-
----
-
-## Summary Table
-
-| Violation | Example | Impact |
-|-----------|---------|--------|
-| Grab-bag commits | "Various fixes and updates" | Hard to review, revert, bisect |
-| Blind staging | `git add .` | Accidental sensitive file commits |
-| Vague messages | "Fix bug" | Lost context, unclear history |
-| Missing context | "Update user.ts" | No explanation of why |
-| Sensitive files | Committing .env | Security breach |
-| Mixed concerns | Feature + fix + chore | Impossible atomic reverts |
-| No type prefix | "Add login" | Inconsistent changelog |
-| Force push shared | `--force` to main | Team work destroyed |
-
----
-
-## Grab-Bag Commits
-
-```bash
-# VIOLATION: Multiple unrelated changes
-git add . && git commit -m "Various fixes and updates"
-
-# FIX: Split into atomic commits by concern
-git add src/auth/*.ts && git commit -m "feat(auth): add login handler"
-git add src/components/button.tsx && git commit -m "fix(ui): correct button color"
-```
-
-## Blind Staging
-
-```bash
-# VIOLATION: No review of what's being committed
-git add .
-git add -A
-
-# FIX: Review and stage specific files
-git status && git diff
-git add src/services/user.ts src/models/user.ts
-```
-
-## Vague Messages
-
-```bash
-# VIOLATION: No context
-git commit -m "Fix bug"
-git commit -m "WIP"
-git commit -m "stuff"
-
-# FIX: Describe what and why
-git commit -m "fix(auth): prevent session timeout during active use"
-```
-
-## Sensitive Files
-
-```bash
-# VIOLATION: Committing secrets
-git add .env
-git add config/credentials.json
-
-# FIX: Add to .gitignore and commit example config
-git add .env.example
-```
-
-## Force Push to Shared Branches
-
-```bash
-# VIOLATION: Rewriting shared history
-git push --force origin main
-
-# FIX: Create new commits for fixes
-git commit -m "fix(auth): correct typo in previous commit"
-git push  # Normal push
-```