devflow-kit 1.1.0 → 1.3.0

package/plugins/devflow-java/skills/java/references/patterns.md

@@ -0,0 +1,235 @@
+# Extended Java Patterns
+
+Correct patterns for Java development. Reference from main SKILL.md.
+
+---
+
+## Builder Pattern (Type-Safe)
+
+```java
+// Compile-time enforcement of required fields
+public record EmailMessage(String to, String subject, String body, List<String> cc) {
+
+    public static Builder builder() { return new Builder(); }
+
+    public static class Builder {
+        private String to;
+        private String subject;
+        private String body;
+        private List<String> cc = List.of();
+
+        public Builder to(String to) { this.to = Objects.requireNonNull(to); return this; }
+        public Builder subject(String subject) { this.subject = Objects.requireNonNull(subject); return this; }
+        public Builder body(String body) { this.body = Objects.requireNonNull(body); return this; }
+        public Builder cc(List<String> cc) { this.cc = List.copyOf(cc); return this; }
+
+        public EmailMessage build() {
+            Objects.requireNonNull(to, "to is required");
+            Objects.requireNonNull(subject, "subject is required");
+            Objects.requireNonNull(body, "body is required");
+            return new EmailMessage(to, subject, body, cc);
+        }
+    }
+}
+
+// Usage
+var email = EmailMessage.builder()
+    .to("user@example.com")
+    .subject("Welcome")
+    .body("Hello!")
+    .build();
+```
+
+---
+
+## Strategy via Interfaces
+
+```java
+// Define strategy as functional interface
+@FunctionalInterface
+public interface PricingStrategy {
+    Money calculatePrice(Order order);
+}
+
+// Implementations as lambdas or classes
+PricingStrategy standard = order -> order.subtotal();
+PricingStrategy discounted = order -> order.subtotal().multiply(0.9);
+PricingStrategy tiered = order -> {
+    if (order.itemCount() > 10) return order.subtotal().multiply(0.8);
+    if (order.itemCount() > 5) return order.subtotal().multiply(0.9);
+    return order.subtotal();
+};
+
+// Inject strategy
+public class OrderService {
+    private final PricingStrategy pricing;
+
+    public OrderService(PricingStrategy pricing) {
+        this.pricing = pricing;
+    }
+
+    public Money calculateTotal(Order order) {
+        return pricing.calculatePrice(order);
+    }
+}
+```
+
+---
+
+## Repository Pattern
+
+```java
+public interface UserRepository {
+    Optional<User> findById(String id);
+    List<User> findByEmail(String email);
+    User save(User user);
+    void deleteById(String id);
+    boolean existsById(String id);
+}
+
+// Implementation with constructor injection
+public class JpaUserRepository implements UserRepository {
+    private final EntityManager em;
+
+    public JpaUserRepository(EntityManager em) {
+        this.em = em;
+    }
+
+    @Override
+    public Optional<User> findById(String id) {
+        return Optional.ofNullable(em.find(User.class, id));
+    }
+
+    @Override
+    public User save(User user) {
+        return em.merge(user);
+    }
+}
+```
+
+---
+
+## Value Objects
+
+```java
+// Immutable value object with validation
+public record Money(BigDecimal amount, Currency currency) {
+    public Money {
+        Objects.requireNonNull(amount, "amount must not be null");
+        Objects.requireNonNull(currency, "currency must not be null");
+        if (amount.scale() > currency.getDefaultFractionDigits()) {
+            throw new IllegalArgumentException("Scale exceeds currency precision");
+        }
+    }
+
+    public Money add(Money other) {
+        requireSameCurrency(other);
+        return new Money(amount.add(other.amount), currency);
+    }
+
+    public Money multiply(double factor) {
+        return new Money(
+            amount.multiply(BigDecimal.valueOf(factor))
+                  .setScale(currency.getDefaultFractionDigits(), RoundingMode.HALF_UP),
+            currency
+        );
+    }
+
+    private void requireSameCurrency(Money other) {
+        if (!currency.equals(other.currency)) {
+            throw new IllegalArgumentException(
+                "Cannot combine %s and %s".formatted(currency, other.currency)
+            );
+        }
+    }
+}
+```
+
+---
+
+## Event-Driven Pattern
+
+```java
+// Domain event as sealed interface
+public sealed interface OrderEvent permits OrderCreated, OrderShipped, OrderCancelled {
+    String orderId();
+    Instant occurredAt();
+}
+
+public record OrderCreated(String orderId, Instant occurredAt, List<LineItem> items)
+    implements OrderEvent {}
+
+public record OrderShipped(String orderId, Instant occurredAt, String trackingNumber)
+    implements OrderEvent {}
+
+public record OrderCancelled(String orderId, Instant occurredAt, String reason)
+    implements OrderEvent {}
+
+// Event handler with exhaustive matching
+public class OrderEventHandler {
+    public void handle(OrderEvent event) {
+        switch (event) {
+            case OrderCreated e -> notifyWarehouse(e.items());
+            case OrderShipped e -> sendTrackingEmail(e.trackingNumber());
+            case OrderCancelled e -> processRefund(e.orderId(), e.reason());
+        }
+    }
+}
+```
+
+---
+
+## Stream Pipelines
+
+```java
+// Declarative collection processing
+public List<String> getActiveUserEmails(List<User> users) {
+    return users.stream()
+        .filter(User::isActive)
+        .map(User::email)
+        .filter(email -> email.contains("@"))
+        .sorted()
+        .toList(); // Unmodifiable list (Java 16+)
+}
+
+// Grouping and aggregation
+public Map<Department, Long> countByDepartment(List<Employee> employees) {
+    return employees.stream()
+        .collect(Collectors.groupingBy(Employee::department, Collectors.counting()));
+}
+
+// Reducing to summary
+public record OrderSummary(int count, Money total) {}
+
+public OrderSummary summarize(List<Order> orders) {
+    return orders.stream()
+        .reduce(
+            new OrderSummary(0, Money.ZERO),
+            (summary, order) -> new OrderSummary(
+                summary.count() + 1,
+                summary.total().add(order.total())
+            ),
+            (a, b) -> new OrderSummary(a.count() + b.count(), a.total().add(b.total()))
+        );
+}
+```
+
+---
+
+## Dependency Injection (Manual)
+
+```java
+// Composition root wires everything together
+public class Application {
+    public static void main(String[] args) {
+        var config = Config.load();
+        var dataSource = createDataSource(config);
+        var userRepo = new JpaUserRepository(dataSource);
+        var eventBus = new InMemoryEventBus();
+        var userService = new UserService(userRepo, eventBus);
+        var userController = new UserController(userService);
+
+        startServer(config.port(), userController);
+    }
+}
+```

package/plugins/devflow-java/skills/java/references/violations.md

@@ -0,0 +1,213 @@
+# Common Java Violations
+
+Extended violation patterns for Java reviews. Reference from main SKILL.md.
+
+---
+
+## Null Returns
+
+### Returning null Instead of Optional
+
+```java
+// VIOLATION: Null return forces callers to null-check
+public User findById(String id) {
+    return userMap.get(id); // Returns null if absent
+}
+
+// Callers must remember to check:
+User user = findById(id);
+user.getName(); // NullPointerException if not found
+```
+
+### Nullable Collections
+
+```java
+// VIOLATION: Returning null instead of empty collection
+public List<Order> getOrders(String userId) {
+    List<Order> orders = orderMap.get(userId);
+    return orders; // null if user has no orders
+}
+
+// Callers iterate without checking:
+for (Order o : getOrders(userId)) { // NullPointerException
+    process(o);
+}
+```
+
+---
+
+## Raw Types
+
+### Unparameterized Generics
+
+```java
+// VIOLATION: Raw List - no type safety
+List users = new ArrayList();
+users.add("not a user"); // No compile error
+users.add(42);           // No compile error
+User first = (User) users.get(0); // ClassCastException at runtime
+
+// VIOLATION: Raw Map
+Map cache = new HashMap();
+cache.put(123, "value");
+String val = (String) cache.get(123); // Unsafe cast
+```
+
+### Raw Type in Method Signatures
+
+```java
+// VIOLATION: Raw Comparable
+public class Price implements Comparable {
+    public int compareTo(Object other) {
+        return Double.compare(this.amount, ((Price) other).amount); // Unsafe cast
+    }
+}
+
+// VIOLATION: Raw Iterator
+Iterator it = collection.iterator();
+while (it.hasNext()) {
+    String s = (String) it.next(); // Unsafe cast
+}
+```
+
+---
+
+## Checked Exception Abuse
+
+### Broad Throws Declarations
+
+```java
+// VIOLATION: throws Exception - hides what can actually go wrong
+public User createUser(String name) throws Exception {
+    // Callers must catch Exception, can't handle specific failures
+}
+
+// VIOLATION: Wrapping everything in checked exceptions
+public void process(String data) throws ProcessingException {
+    try {
+        Integer.parseInt(data);
+    } catch (NumberFormatException e) {
+        throw new ProcessingException("Failed", e); // Unnecessary wrapping
+    }
+}
+```
+
+### Swallowed Exceptions
+
+```java
+// VIOLATION: Empty catch block
+try {
+    connection.close();
+} catch (SQLException e) {
+    // silently ignored - resource leak hidden
+}
+
+// VIOLATION: Catching and logging only
+try {
+    processPayment(order);
+} catch (PaymentException e) {
+    logger.error("Payment failed", e);
+    // Continues as if nothing happened - order in inconsistent state
+}
+```
+
+---
+
+## Mutable Data Objects
+
+### JavaBean-Style Mutability
+
+```java
+// VIOLATION: Mutable DTO with setters
+public class UserDTO {
+    private String name;
+    private String email;
+
+    public void setName(String name) { this.name = name; }
+    public void setEmail(String email) { this.email = email; }
+    public String getName() { return name; }
+    public String getEmail() { return email; }
+}
+
+// Anyone can modify at any time:
+dto.setName("changed"); // No control over when/where mutation happens
+```
+
+### Exposing Internal Mutable State
+
+```java
+// VIOLATION: Getter returns mutable internal list
+public class Team {
+    private List<String> members = new ArrayList<>();
+
+    public List<String> getMembers() {
+        return members; // Caller can modify internal state
+    }
+}
+
+// External code breaks encapsulation:
+team.getMembers().clear(); // Empties the team's internal list
+```
+
+---
+
+## Deep Inheritance
+
+### Fragile Base Class
+
+```java
+// VIOLATION: Deep hierarchy creates tight coupling
+public abstract class AbstractEntity { ... }
+public abstract class AbstractAuditableEntity extends AbstractEntity { ... }
+public abstract class AbstractVersionedEntity extends AbstractAuditableEntity { ... }
+public class User extends AbstractVersionedEntity { ... }
+
+// Changing any base class ripples through all descendants
+// Testing requires understanding 4 levels of behavior
+```
+
+### Inheritance for Code Reuse
+
+```java
+// VIOLATION: Extending just to reuse utility methods
+public class OrderService extends BaseService {
+    // Only extends BaseService to get logAndAudit() method
+    public void processOrder(Order order) {
+        logAndAudit("processing", order.getId()); // Inherited utility
+    }
+}
+// Should be: inject a LogAuditService instead
+```
+
+---
+
+## Concurrency Violations
+
+### Shared Mutable State Without Synchronization
+
+```java
+// VIOLATION: HashMap accessed from multiple threads
+private Map<String, Session> sessions = new HashMap<>();
+
+public void addSession(String id, Session s) {
+    sessions.put(id, s); // Not thread-safe
+}
+```
+
+### Double-Checked Locking Done Wrong
+
+```java
+// VIOLATION: Missing volatile on lazily-initialized field
+private ExpensiveObject instance;
+
+public ExpensiveObject getInstance() {
+    if (instance == null) {
+        synchronized (this) {
+            if (instance == null) {
+                instance = new ExpensiveObject(); // Partially constructed object visible
+            }
+        }
+    }
+    return instance;
+}
+```

package/plugins/devflow-python/.claude-plugin/plugin.json

@@ -0,0 +1,22 @@
+{
+  "name": "devflow-python",
+  "description": "Python language patterns - type hints, protocols, dataclasses, async programming",
+  "author": {
+    "name": "DevFlow Contributors",
+    "email": "dean@keren.dev"
+  },
+  "version": "1.3.0",
+  "homepage": "https://github.com/dean0x/devflow",
+  "repository": "https://github.com/dean0x/devflow",
+  "license": "MIT",
+  "keywords": [
+    "python",
+    "type-hints",
+    "dataclasses",
+    "async"
+  ],
+  "agents": [],
+  "skills": [
+    "python"
+  ]
+}

package/plugins/devflow-python/skills/python/SKILL.md

@@ -0,0 +1,188 @@
+---
+name: python
+description: This skill should be used when the user works with Python files (.py), asks about "type hints", "protocols", "dataclasses", "async/await", "decorators", or discusses Pythonic patterns and data modeling. Provides patterns for type safety, error handling, data modeling, and async programming.
+user-invocable: false
+allowed-tools: Read, Grep, Glob
+activation:
+  file-patterns:
+    - "**/*.py"
+  exclude:
+    - "venv/**"
+    - ".venv/**"
+    - "**/__pycache__/**"
+---
+
+# Python Patterns
+
+Reference for Python-specific patterns, type safety, and idioms.
+
+## Iron Law
+
+> **EXPLICIT IS BETTER THAN IMPLICIT**
+>
+> Type-hint every function signature. Name every exception. Use dataclasses over raw dicts.
+> Python's flexibility is a strength only when boundaries are explicit. Implicit behavior
+> causes debugging nightmares and makes codebases hostile to newcomers.
+
+## When This Skill Activates
+
+- Working with Python codebases
+- Designing typed APIs with type hints
+- Modeling data with dataclasses or Pydantic
+- Implementing async code
+- Structuring Python packages
+
+---
+
+## Type Safety
+
+### Type Hint Everything
+
+```python
+# BAD: def process(data, config): ...
+# GOOD:
+def process(data: list[dict[str, Any]], config: AppConfig) -> ProcessResult:
+    ...
+```
+
+### Use Protocols for Structural Typing
+
+```python
+from typing import Protocol
+
+class Repository(Protocol):
+    def find_by_id(self, id: str) -> User | None: ...
+    def save(self, entity: User) -> User: ...
+
+# Any class with these methods satisfies Repository — no inheritance needed
+```
+
+### Strict Optional Handling
+
+```python
+# BAD: def get_name(user): return user.name
+# GOOD:
+def get_name(user: User | None) -> str:
+    if user is None:
+        return "Anonymous"
+    return user.name
+```
+
+---
+
+## Error Handling
+
+### Custom Exception Hierarchies
+
+```python
+class AppError(Exception):
+    """Base application error."""
+
+class NotFoundError(AppError):
+    def __init__(self, entity: str, id: str) -> None:
+        super().__init__(f"{entity} {id} not found")
+        self.entity = entity
+        self.id = id
+
+class ValidationError(AppError):
+    def __init__(self, field: str, message: str) -> None:
+        super().__init__(f"Validation failed for {field}: {message}")
+```
+
+### Context Managers for Resources
+
+```python
+from contextlib import contextmanager
+
+@contextmanager
+def database_transaction(conn: Connection):
+    try:
+        yield conn
+        conn.commit()
+    except Exception:
+        conn.rollback()
+        raise
+```
+
+---
+
+## Data Modeling
+
+### Dataclasses Over Raw Dicts
+
+```python
+# BAD: user = {"name": "Alice", "email": "alice@example.com"}
+# GOOD:
+@dataclass(frozen=True)
+class User:
+    name: str
+    email: str
+    created_at: datetime = field(default_factory=lambda: datetime.now(timezone.utc))
+```
+
+### Pydantic for Validation at Boundaries
+
+```python
+from pydantic import BaseModel, EmailStr
+
+class CreateUserRequest(BaseModel):
+    name: str
+    email: EmailStr
+    age: int = Field(ge=0, le=150)
+```
+
+---
+
+## Pythonic Patterns
+
+```python
+# Comprehensions over loops for transforms
+names = [user.name for user in users if user.active]
+
+# Enumerate over manual index tracking
+for i, item in enumerate(items):
+    process(i, item)
+
+# EAFP: Easier to Ask Forgiveness than Permission
+try:
+    value = mapping[key]
+except KeyError:
+    value = default
+```
+
+---
+
+## Anti-Patterns
+
+| Pattern | Bad | Good |
+|---------|-----|------|
+| Bare except | `except:` | `except (ValueError, KeyError):` |
+| Mutable default | `def fn(items=[])` | `def fn(items: list | None = None)` |
+| No type hints | `def process(data)` | `def process(data: DataFrame) -> Result` |
+| String typing | `x: "MyClass"` (without reason) | `from __future__ import annotations` |
+| God class | `class App` with 50 methods | Compose smaller focused classes |
+
+---
+
+## Extended References
+
+For additional patterns and examples:
+- `references/violations.md` - Common Python violations
+- `references/patterns.md` - Extended Python patterns
+- `references/detection.md` - Detection patterns for Python issues
+- `references/async.md` - Async Python patterns
+
+---
+
+## Checklist
+
+- [ ] All functions have type hints (params + return)
+- [ ] Custom exceptions with meaningful messages
+- [ ] Dataclasses or Pydantic for structured data
+- [ ] No bare `except:` clauses
+- [ ] No mutable default arguments
+- [ ] Context managers for resource management
+- [ ] `from __future__ import annotations` for forward refs
+- [ ] Protocols for structural typing (not ABC unless needed)
+- [ ] Comprehensions for simple transforms
+- [ ] Tests use pytest with fixtures