devflow-kit 1.1.0 → 1.3.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +69 -1
- package/README.md +23 -6
- package/dist/cli.js +2 -0
- package/dist/commands/ambient.js +5 -4
- package/dist/commands/init.js +4 -2
- package/dist/commands/memory.js +4 -4
- package/dist/commands/skills.d.ts +11 -0
- package/dist/commands/skills.js +116 -0
- package/dist/commands/uninstall.js +11 -1
- package/dist/plugins.js +67 -3
- package/dist/utils/installer.js +20 -2
- package/package.json +4 -2
- package/plugins/devflow-accessibility/.claude-plugin/plugin.json +22 -0
- package/plugins/devflow-ambient/.claude-plugin/plugin.json +4 -2
- package/plugins/devflow-ambient/README.md +8 -8
- package/plugins/devflow-ambient/commands/ambient.md +14 -14
- package/plugins/devflow-ambient/skills/ambient-router/SKILL.md +16 -9
- package/plugins/devflow-ambient/skills/ambient-router/references/skill-catalog.md +6 -2
- package/plugins/devflow-audit-claude/.claude-plugin/plugin.json +1 -1
- package/plugins/devflow-code-review/.claude-plugin/plugin.json +13 -6
- package/plugins/devflow-code-review/agents/reviewer.md +8 -0
- package/plugins/devflow-code-review/commands/code-review-teams.md +11 -1
- package/plugins/devflow-code-review/commands/code-review.md +12 -2
- package/plugins/devflow-code-review/skills/architecture-patterns/SKILL.md +1 -1
- package/plugins/devflow-code-review/skills/complexity-patterns/SKILL.md +1 -1
- package/plugins/devflow-code-review/skills/consistency-patterns/SKILL.md +1 -1
- package/plugins/devflow-code-review/skills/database-patterns/SKILL.md +1 -1
- package/plugins/devflow-code-review/skills/dependencies-patterns/SKILL.md +1 -1
- package/plugins/devflow-code-review/skills/documentation-patterns/SKILL.md +1 -1
- package/plugins/devflow-code-review/skills/performance-patterns/SKILL.md +1 -1
- package/plugins/devflow-code-review/skills/regression-patterns/SKILL.md +1 -1
- package/plugins/devflow-code-review/skills/review-methodology/SKILL.md +1 -1
- package/plugins/devflow-code-review/skills/security-patterns/SKILL.md +1 -1
- package/plugins/devflow-core-skills/.claude-plugin/plugin.json +10 -7
- package/plugins/devflow-core-skills/skills/test-driven-development/SKILL.md +5 -8
- package/plugins/devflow-debug/.claude-plugin/plugin.json +10 -3
- package/plugins/devflow-frontend-design/.claude-plugin/plugin.json +22 -0
- package/plugins/devflow-go/.claude-plugin/plugin.json +22 -0
- package/plugins/devflow-go/skills/go/SKILL.md +187 -0
- package/plugins/devflow-go/skills/go/references/concurrency.md +312 -0
- package/plugins/devflow-go/skills/go/references/detection.md +129 -0
- package/plugins/devflow-go/skills/go/references/patterns.md +232 -0
- package/plugins/devflow-go/skills/go/references/violations.md +205 -0
- package/plugins/devflow-implement/.claude-plugin/plugin.json +19 -5
- package/plugins/devflow-implement/agents/coder.md +11 -6
- package/plugins/devflow-implement/skills/self-review/SKILL.md +1 -1
- package/plugins/devflow-java/.claude-plugin/plugin.json +22 -0
- package/plugins/devflow-java/skills/java/SKILL.md +183 -0
- package/plugins/devflow-java/skills/java/references/detection.md +120 -0
- package/plugins/devflow-java/skills/java/references/modern-java.md +270 -0
- package/plugins/devflow-java/skills/java/references/patterns.md +235 -0
- package/plugins/devflow-java/skills/java/references/violations.md +213 -0
- package/plugins/devflow-python/.claude-plugin/plugin.json +22 -0
- package/plugins/devflow-python/skills/python/SKILL.md +188 -0
- package/plugins/devflow-python/skills/python/references/async.md +220 -0
- package/plugins/devflow-python/skills/python/references/detection.md +128 -0
- package/plugins/devflow-python/skills/python/references/patterns.md +226 -0
- package/plugins/devflow-python/skills/python/references/violations.md +204 -0
- package/plugins/devflow-react/.claude-plugin/plugin.json +22 -0
- package/plugins/{devflow-core-skills → devflow-react}/skills/react/SKILL.md +1 -1
- package/plugins/{devflow-core-skills → devflow-react}/skills/react/references/patterns.md +3 -3
- package/plugins/devflow-resolve/.claude-plugin/plugin.json +13 -3
- package/plugins/devflow-resolve/skills/security-patterns/SKILL.md +1 -1
- package/plugins/devflow-rust/.claude-plugin/plugin.json +22 -0
- package/plugins/devflow-rust/skills/rust/SKILL.md +193 -0
- package/plugins/devflow-rust/skills/rust/references/detection.md +131 -0
- package/plugins/devflow-rust/skills/rust/references/ownership.md +242 -0
- package/plugins/devflow-rust/skills/rust/references/patterns.md +210 -0
- package/plugins/devflow-rust/skills/rust/references/violations.md +191 -0
- package/plugins/devflow-self-review/.claude-plugin/plugin.json +10 -3
- package/plugins/devflow-self-review/skills/self-review/SKILL.md +1 -1
- package/plugins/devflow-specify/.claude-plugin/plugin.json +15 -4
- package/plugins/devflow-typescript/.claude-plugin/plugin.json +22 -0
- package/plugins/{devflow-core-skills → devflow-typescript}/skills/typescript/references/patterns.md +3 -3
- package/scripts/hooks/{ambient-prompt.sh → ambient-prompt} +4 -4
- package/scripts/hooks/{background-memory-update.sh → background-memory-update} +3 -3
- package/scripts/hooks/{ensure-memory-gitignore.sh → ensure-memory-gitignore} +1 -1
- package/scripts/hooks/{pre-compact-memory.sh → pre-compact-memory} +2 -2
- package/scripts/hooks/run-hook +23 -0
- package/scripts/hooks/session-start-memory +151 -0
- package/scripts/hooks/{stop-update-memory.sh → stop-update-memory} +4 -4
- package/shared/agents/coder.md +11 -6
- package/shared/agents/reviewer.md +8 -0
- package/shared/skills/ambient-router/SKILL.md +16 -9
- package/shared/skills/ambient-router/references/skill-catalog.md +6 -2
- package/shared/skills/architecture-patterns/SKILL.md +1 -1
- package/shared/skills/complexity-patterns/SKILL.md +1 -1
- package/shared/skills/consistency-patterns/SKILL.md +1 -1
- package/shared/skills/database-patterns/SKILL.md +1 -1
- package/shared/skills/dependencies-patterns/SKILL.md +1 -1
- package/shared/skills/documentation-patterns/SKILL.md +1 -1
- package/shared/skills/go/SKILL.md +187 -0
- package/shared/skills/go/references/concurrency.md +312 -0
- package/shared/skills/go/references/detection.md +129 -0
- package/shared/skills/go/references/patterns.md +232 -0
- package/shared/skills/go/references/violations.md +205 -0
- package/shared/skills/java/SKILL.md +183 -0
- package/shared/skills/java/references/detection.md +120 -0
- package/shared/skills/java/references/modern-java.md +270 -0
- package/shared/skills/java/references/patterns.md +235 -0
- package/shared/skills/java/references/violations.md +213 -0
- package/shared/skills/performance-patterns/SKILL.md +1 -1
- package/shared/skills/python/SKILL.md +188 -0
- package/shared/skills/python/references/async.md +220 -0
- package/shared/skills/python/references/detection.md +128 -0
- package/shared/skills/python/references/patterns.md +226 -0
- package/shared/skills/python/references/violations.md +204 -0
- package/shared/skills/react/SKILL.md +1 -1
- package/shared/skills/react/references/patterns.md +3 -3
- package/shared/skills/regression-patterns/SKILL.md +1 -1
- package/shared/skills/review-methodology/SKILL.md +1 -1
- package/shared/skills/rust/SKILL.md +193 -0
- package/shared/skills/rust/references/detection.md +131 -0
- package/shared/skills/rust/references/ownership.md +242 -0
- package/shared/skills/rust/references/patterns.md +210 -0
- package/shared/skills/rust/references/violations.md +191 -0
- package/shared/skills/security-patterns/SKILL.md +1 -1
- package/shared/skills/self-review/SKILL.md +1 -1
- package/shared/skills/test-driven-development/SKILL.md +5 -8
- package/shared/skills/typescript/references/patterns.md +3 -3
- package/src/templates/settings.json +3 -3
- package/plugins/devflow-code-review/skills/react/SKILL.md +0 -276
- package/plugins/devflow-code-review/skills/react/references/patterns.md +0 -1331
- package/plugins/devflow-core-skills/skills/accessibility/SKILL.md +0 -229
- package/plugins/devflow-core-skills/skills/accessibility/references/detection.md +0 -171
- package/plugins/devflow-core-skills/skills/accessibility/references/patterns.md +0 -670
- package/plugins/devflow-core-skills/skills/accessibility/references/violations.md +0 -419
- package/plugins/devflow-core-skills/skills/frontend-design/SKILL.md +0 -254
- package/plugins/devflow-core-skills/skills/frontend-design/references/detection.md +0 -184
- package/plugins/devflow-core-skills/skills/frontend-design/references/patterns.md +0 -511
- package/plugins/devflow-core-skills/skills/frontend-design/references/violations.md +0 -453
- package/plugins/devflow-core-skills/skills/react/references/violations.md +0 -565
- package/plugins/devflow-implement/skills/accessibility/SKILL.md +0 -229
- package/plugins/devflow-implement/skills/accessibility/references/detection.md +0 -171
- package/plugins/devflow-implement/skills/accessibility/references/patterns.md +0 -670
- package/plugins/devflow-implement/skills/accessibility/references/violations.md +0 -419
- package/plugins/devflow-implement/skills/frontend-design/SKILL.md +0 -254
- package/plugins/devflow-implement/skills/frontend-design/references/detection.md +0 -184
- package/plugins/devflow-implement/skills/frontend-design/references/patterns.md +0 -511
- package/plugins/devflow-implement/skills/frontend-design/references/violations.md +0 -453
- package/scripts/hooks/session-start-memory.sh +0 -126
- /package/plugins/{devflow-code-review → devflow-accessibility}/skills/accessibility/SKILL.md +0 -0
- /package/plugins/{devflow-code-review → devflow-accessibility}/skills/accessibility/references/detection.md +0 -0
- /package/plugins/{devflow-code-review → devflow-accessibility}/skills/accessibility/references/patterns.md +0 -0
- /package/plugins/{devflow-code-review → devflow-accessibility}/skills/accessibility/references/violations.md +0 -0
- /package/plugins/{devflow-code-review → devflow-frontend-design}/skills/frontend-design/SKILL.md +0 -0
- /package/plugins/{devflow-code-review → devflow-frontend-design}/skills/frontend-design/references/detection.md +0 -0
- /package/plugins/{devflow-code-review → devflow-frontend-design}/skills/frontend-design/references/patterns.md +0 -0
- /package/plugins/{devflow-code-review → devflow-frontend-design}/skills/frontend-design/references/violations.md +0 -0
- /package/plugins/{devflow-code-review → devflow-react}/skills/react/references/violations.md +0 -0
- /package/plugins/{devflow-core-skills → devflow-typescript}/skills/typescript/SKILL.md +0 -0
- /package/plugins/{devflow-core-skills → devflow-typescript}/skills/typescript/references/violations.md +0 -0
|
@@ -25,7 +25,7 @@ Read the `ambient-router` skill:
|
|
|
25
25
|
Apply the ambient-router classification to `$ARGUMENTS`:
|
|
26
26
|
|
|
27
27
|
1. **Intent:** BUILD | DEBUG | REVIEW | PLAN | EXPLORE | CHAT
|
|
28
|
-
2. **Depth:** QUICK |
|
|
28
|
+
2. **Depth:** QUICK | GUIDED | ELEVATE
|
|
29
29
|
|
|
30
30
|
If no arguments provided, output:
|
|
31
31
|
|
|
@@ -37,10 +37,10 @@ Classify intent and auto-load relevant skills.
|
|
|
37
37
|
Usage: /ambient <your prompt>
|
|
38
38
|
|
|
39
39
|
Examples:
|
|
40
|
-
/ambient add a login form → BUILD/
|
|
41
|
-
/ambient fix the auth error → DEBUG/
|
|
40
|
+
/ambient add a login form → BUILD/GUIDED (loads TDD + implementation-patterns)
|
|
41
|
+
/ambient fix the auth error → DEBUG/GUIDED (loads test-patterns + core-patterns)
|
|
42
42
|
/ambient where is the config? → EXPLORE/QUICK (responds normally)
|
|
43
|
-
/ambient refactor the auth system → BUILD/
|
|
43
|
+
/ambient refactor the auth system → BUILD/ELEVATE (suggests /implement)
|
|
44
44
|
|
|
45
45
|
Always-on: devflow ambient --enable
|
|
46
46
|
```
|
|
@@ -50,15 +50,15 @@ Then stop.
|
|
|
50
50
|
### Phase 3: State Classification
|
|
51
51
|
|
|
52
52
|
- **QUICK:** Skip this phase entirely. Respond directly in Phase 4.
|
|
53
|
-
- **
|
|
54
|
-
- **
|
|
53
|
+
- **GUIDED:** Output one line: `Ambient: {INTENT}/{DEPTH}. Loading: {skill1}, {skill2}.`
|
|
54
|
+
- **ELEVATE:** Skip — recommendation happens in Phase 4.
|
|
55
55
|
|
|
56
56
|
### Phase 4: Apply
|
|
57
57
|
|
|
58
58
|
**QUICK:**
|
|
59
59
|
Respond to the user's prompt normally. Zero skill loading. Zero overhead.
|
|
60
60
|
|
|
61
|
-
**
|
|
61
|
+
**GUIDED:**
|
|
62
62
|
Read the selected skills based on the ambient-router's skill selection matrix:
|
|
63
63
|
|
|
64
64
|
| Intent | Primary Skills | Secondary (conditional) |
|
|
@@ -72,7 +72,7 @@ Read up to 3 skills from `~/.claude/skills/{name}/SKILL.md`. Apply their pattern
|
|
|
72
72
|
|
|
73
73
|
For BUILD intent: enforce RED-GREEN-REFACTOR from test-driven-development. Write failing tests before production code.
|
|
74
74
|
|
|
75
|
-
**
|
|
75
|
+
**ELEVATE:**
|
|
76
76
|
Respond to the user's prompt with your best effort, then append:
|
|
77
77
|
|
|
78
78
|
> This task spans multiple files/systems. Consider `/implement` for full lifecycle management (exploration → planning → implementation → review).
|
|
@@ -84,11 +84,11 @@ Respond to the user's prompt with your best effort, then append:
|
|
|
84
84
|
│
|
|
85
85
|
├─ Phase 1: Load ambient-router skill
|
|
86
86
|
├─ Phase 2: Classify intent + depth
|
|
87
|
-
├─ Phase 3: State classification (
|
|
87
|
+
├─ Phase 3: State classification (GUIDED only)
|
|
88
88
|
└─ Phase 4: Apply
|
|
89
89
|
├─ QUICK → respond directly
|
|
90
|
-
├─
|
|
91
|
-
└─
|
|
90
|
+
├─ GUIDED → load 2-3 skills, apply patterns, respond
|
|
91
|
+
└─ ELEVATE → respond + workflow nudge
|
|
92
92
|
```
|
|
93
93
|
|
|
94
94
|
## Edge Cases
|
|
@@ -104,7 +104,7 @@ Respond to the user's prompt with your best effort, then append:
|
|
|
104
104
|
## Principles
|
|
105
105
|
|
|
106
106
|
1. **No agents** — Ambient enhances the main session, never spawns subagents
|
|
107
|
-
2. **Proportional** — QUICK gets zero overhead,
|
|
108
|
-
3. **Transparent** — State classification for
|
|
107
|
+
2. **Proportional** — QUICK gets zero overhead, GUIDED gets 2-3 skills, ELEVATE gets a nudge
|
|
108
|
+
3. **Transparent** — State classification for GUIDED/ELEVATE, silent for QUICK
|
|
109
109
|
4. **Respectful** — Never over-classify; when in doubt, go one tier lower
|
|
110
|
-
5. **TDD for BUILD** —
|
|
110
|
+
5. **TDD for BUILD** — GUIDED depth BUILD tasks enforce test-first workflow
|
|
@@ -36,7 +36,7 @@ Determine what the user is trying to do from their prompt.
|
|
|
36
36
|
| **EXPLORE** | "what is", "where is", "find", "show me", "explain", "how does" | "where is the config?", "explain this function" |
|
|
37
37
|
| **CHAT** | greetings, meta-questions, confirmations, short responses | "thanks", "yes", "what can you do?" |
|
|
38
38
|
|
|
39
|
-
**Ambiguous prompts:** Default to the lowest-overhead classification. "Update the README" → BUILD/
|
|
39
|
+
**Ambiguous prompts:** Default to the lowest-overhead classification. "Update the README" → BUILD/GUIDED. Git operations like "commit this" → QUICK.
|
|
40
40
|
|
|
41
41
|
## Step 2: Classify Depth
|
|
42
42
|
|
|
@@ -45,16 +45,16 @@ Determine how much enforcement the prompt warrants.
|
|
|
45
45
|
| Depth | Criteria | Action |
|
|
46
46
|
|-------|----------|--------|
|
|
47
47
|
| **QUICK** | CHAT intent. EXPLORE with no analytical depth ("where is X?"). Git/devops operations (commit, push, merge, branch, pr, deploy, reinstall). Single-word continuations. | Respond normally. Zero overhead. Do not state classification. |
|
|
48
|
-
| **
|
|
49
|
-
| **
|
|
48
|
+
| **GUIDED** | BUILD/DEBUG/REVIEW/PLAN intent (any word count). EXPLORE with analytical depth ("analyze our X", "discuss how Y works"). | Read and apply 2-3 relevant skills from the selection matrix below. State classification briefly. |
|
|
49
|
+
| **ELEVATE** | Multi-file architectural change, system-wide scope, > 5 files. Detailed implementation plan (100+ words with plan structure). | Respond at best effort + recommend: "This looks like it would benefit from `/implement` for full lifecycle management." |
|
|
50
50
|
|
|
51
|
-
## Step 3: Select Skills (
|
|
51
|
+
## Step 3: Select Skills (GUIDED depth only)
|
|
52
52
|
|
|
53
53
|
Based on classified intent, read the following skills to inform your response.
|
|
54
54
|
|
|
55
55
|
| Intent | Primary Skills | Secondary (if file type matches) |
|
|
56
56
|
|--------|---------------|----------------------------------|
|
|
57
|
-
| **BUILD** | test-driven-development, implementation-patterns | typescript (.ts), react (.tsx/.jsx), frontend-design (CSS/UI), input-validation (forms/API), security-patterns (auth/crypto) |
|
|
57
|
+
| **BUILD** | test-driven-development, implementation-patterns | typescript (.ts), react (.tsx/.jsx), go (.go), java (.java), python (.py), rust (.rs), frontend-design (CSS/UI), input-validation (forms/API), security-patterns (auth/crypto) |
|
|
58
58
|
| **DEBUG** | test-patterns, core-patterns | git-safety (if git operations involved) |
|
|
59
59
|
| **REVIEW** | self-review, core-patterns | test-patterns |
|
|
60
60
|
| **PLAN** | implementation-patterns | core-patterns |
|
|
@@ -65,19 +65,26 @@ See `references/skill-catalog.md` for the full skill-to-intent mapping with file
|
|
|
65
65
|
|
|
66
66
|
## Step 4: Apply
|
|
67
67
|
|
|
68
|
+
<IMPORTANT>
|
|
69
|
+
When classification is GUIDED or ELEVATE, skill application is NON-NEGOTIABLE.
|
|
70
|
+
Do not rationalize skipping skills. Do not respond without loading them first.
|
|
71
|
+
If test-driven-development is selected, you MUST write the failing test before ANY production code.
|
|
72
|
+
</IMPORTANT>
|
|
73
|
+
|
|
68
74
|
- **QUICK:** Respond directly. No preamble, no classification statement.
|
|
69
|
-
- **
|
|
70
|
-
- **
|
|
75
|
+
- **GUIDED:** State classification briefly: `Ambient: BUILD/GUIDED. Loading: test-driven-development, implementation-patterns.` Then read the selected skills and apply their patterns. No exceptions.
|
|
76
|
+
- **ELEVATE:** Respond with your best effort, then append: `> This task spans multiple files/systems. Consider \`/implement\` for full lifecycle.`
|
|
71
77
|
|
|
72
78
|
---
|
|
73
79
|
|
|
74
80
|
## Transparency Rules
|
|
75
81
|
|
|
76
82
|
1. **QUICK → silent.** No classification output.
|
|
77
|
-
2. **
|
|
78
|
-
3. **
|
|
83
|
+
2. **GUIDED → brief statement + full skill enforcement.** One line: intent, depth, skills loaded. Then follow every skill requirement without shortcuts.
|
|
84
|
+
3. **ELEVATE → recommendation.** Best-effort response + workflow nudge.
|
|
79
85
|
4. **Never lie about classification.** If uncertain, say so.
|
|
80
86
|
5. **Never over-classify.** When in doubt, go one tier lower.
|
|
87
|
+
6. **Never under-apply.** Rationalization is the enemy of quality. If a skill requires a step, do the step.
|
|
81
88
|
|
|
82
89
|
## Edge Cases
|
|
83
90
|
|
|
@@ -4,7 +4,7 @@ Full mapping of DevFlow skills to ambient intents and file-type triggers. The am
|
|
|
4
4
|
|
|
5
5
|
## Skills Available for Ambient Loading
|
|
6
6
|
|
|
7
|
-
These skills may be loaded during
|
|
7
|
+
These skills may be loaded during GUIDED-depth ambient routing.
|
|
8
8
|
|
|
9
9
|
### BUILD Intent
|
|
10
10
|
|
|
@@ -16,6 +16,10 @@ These skills may be loaded during STANDARD-depth ambient routing.
|
|
|
16
16
|
| react | React components in scope | `*.tsx`, `*.jsx` |
|
|
17
17
|
| frontend-design | UI/styling work | `*.css`, `*.scss`, `*.tsx` with styling keywords |
|
|
18
18
|
| input-validation | Forms, APIs, user input | Files with form/input/validation keywords |
|
|
19
|
+
| go | Go files in scope | `*.go` |
|
|
20
|
+
| java | Java files in scope | `*.java` |
|
|
21
|
+
| python | Python files in scope | `*.py` |
|
|
22
|
+
| rust | Rust files in scope | `*.rs` |
|
|
19
23
|
| security-patterns | Auth, crypto, secrets | Files with auth/token/crypto/password keywords |
|
|
20
24
|
|
|
21
25
|
### DEBUG Intent
|
|
@@ -61,4 +65,4 @@ These skills are loaded only by explicit DevFlow commands (primarily `/code-revi
|
|
|
61
65
|
- **Maximum 3 skills** per ambient response (primary + up to 2 secondary)
|
|
62
66
|
- **Primary skills** are always loaded for the classified intent
|
|
63
67
|
- **Secondary skills** are loaded only when file patterns match conversation context
|
|
64
|
-
- If more than 3 skills seem relevant, this is an
|
|
68
|
+
- If more than 3 skills seem relevant, this is an ELEVATE signal
|
|
@@ -5,14 +5,23 @@
|
|
|
5
5
|
"name": "DevFlow Contributors",
|
|
6
6
|
"email": "dean@keren.dev"
|
|
7
7
|
},
|
|
8
|
-
"version": "1.
|
|
8
|
+
"version": "1.3.0",
|
|
9
9
|
"homepage": "https://github.com/dean0x/devflow",
|
|
10
10
|
"repository": "https://github.com/dean0x/devflow",
|
|
11
11
|
"license": "MIT",
|
|
12
|
-
"keywords": [
|
|
13
|
-
|
|
12
|
+
"keywords": [
|
|
13
|
+
"review",
|
|
14
|
+
"code-quality",
|
|
15
|
+
"security",
|
|
16
|
+
"architecture",
|
|
17
|
+
"pr-review"
|
|
18
|
+
],
|
|
19
|
+
"agents": [
|
|
20
|
+
"git",
|
|
21
|
+
"reviewer",
|
|
22
|
+
"synthesizer"
|
|
23
|
+
],
|
|
14
24
|
"skills": [
|
|
15
|
-
"accessibility",
|
|
16
25
|
"agent-teams",
|
|
17
26
|
"architecture-patterns",
|
|
18
27
|
"complexity-patterns",
|
|
@@ -20,9 +29,7 @@
|
|
|
20
29
|
"database-patterns",
|
|
21
30
|
"dependencies-patterns",
|
|
22
31
|
"documentation-patterns",
|
|
23
|
-
"frontend-design",
|
|
24
32
|
"performance-patterns",
|
|
25
|
-
"react",
|
|
26
33
|
"regression-patterns",
|
|
27
34
|
"review-methodology",
|
|
28
35
|
"security-patterns",
|
|
@@ -34,6 +34,10 @@ The orchestrator provides:
|
|
|
34
34
|
| `react` | `~/.claude/skills/react/SKILL.md` |
|
|
35
35
|
| `accessibility` | `~/.claude/skills/accessibility/SKILL.md` |
|
|
36
36
|
| `frontend-design` | `~/.claude/skills/frontend-design/SKILL.md` |
|
|
37
|
+
| `go` | `~/.claude/skills/go/SKILL.md` |
|
|
38
|
+
| `java` | `~/.claude/skills/java/SKILL.md` |
|
|
39
|
+
| `python` | `~/.claude/skills/python/SKILL.md` |
|
|
40
|
+
| `rust` | `~/.claude/skills/rust/SKILL.md` |
|
|
37
41
|
|
|
38
42
|
## Responsibilities
|
|
39
43
|
|
|
@@ -117,3 +121,7 @@ Report format for `{output_path}`:
|
|
|
117
121
|
| react | If .tsx/.jsx files changed |
|
|
118
122
|
| accessibility | If .tsx/.jsx files changed |
|
|
119
123
|
| frontend-design | If .tsx/.jsx/.css/.scss files changed |
|
|
124
|
+
| go | If .go files changed |
|
|
125
|
+
| java | If .java files changed |
|
|
126
|
+
| python | If .py files changed |
|
|
127
|
+
| rust | If .rs files changed |
|
|
@@ -42,10 +42,16 @@ Detect file types in diff to determine conditional reviews:
|
|
|
42
42
|
| .tsx/.jsx files | react |
|
|
43
43
|
| .tsx/.jsx files | accessibility |
|
|
44
44
|
| .tsx/.jsx/.css/.scss files | frontend-design |
|
|
45
|
+
| .go files | go |
|
|
46
|
+
| .java files | java |
|
|
47
|
+
| .py files | python |
|
|
48
|
+
| .rs files | rust |
|
|
45
49
|
| DB/migration files | database |
|
|
46
50
|
| Dependency files changed | dependencies |
|
|
47
51
|
| Docs or significant code | documentation |
|
|
48
52
|
|
|
53
|
+
**Skill availability check**: Language/ecosystem reviews (typescript, react, accessibility, frontend-design, go, java, python, rust) require their optional skill plugin to be installed. Before adding a conditional perspective, check if `~/.claude/skills/{focus}/SKILL.md` exists (use Glob). If the skill file doesn't exist, **skip that perspective** — the language plugin isn't installed. Non-language reviews (database, dependencies, documentation) use skills bundled with this plugin and are always available.
|
|
54
|
+
|
|
49
55
|
### Phase 2: Spawn Review Team
|
|
50
56
|
|
|
51
57
|
Create an agent team for adversarial review. Always include 4 core perspectives; conditionally add more based on Phase 1 analysis.
|
|
@@ -61,6 +67,10 @@ Create an agent team for adversarial review. Always include 4 core perspectives;
|
|
|
61
67
|
- **React**: hooks, state, rendering, composition (if .tsx/.jsx changed)
|
|
62
68
|
- **Accessibility**: ARIA, keyboard nav, focus management (if .tsx/.jsx changed)
|
|
63
69
|
- **Frontend Design**: visual consistency, spacing, typography (if .tsx/.jsx/.css changed)
|
|
70
|
+
- **Go**: error handling, interfaces, concurrency (if .go changed)
|
|
71
|
+
- **Java**: records, sealed classes, composition (if .java changed)
|
|
72
|
+
- **Python**: type hints, protocols, data modeling (if .py changed)
|
|
73
|
+
- **Rust**: ownership, error handling, type system (if .rs changed)
|
|
64
74
|
- **Database**: schema, queries, migrations, indexes (if DB files changed)
|
|
65
75
|
- **Dependencies**: CVEs, versions, licenses, supply chain (if package files changed)
|
|
66
76
|
- **Documentation**: doc drift, missing docs, stale comments (if docs or significant code changed)
|
|
@@ -238,7 +248,7 @@ Display results:
|
|
|
238
248
|
│ ├─ Architecture Reviewer (teammate)
|
|
239
249
|
│ ├─ Performance Reviewer (teammate)
|
|
240
250
|
│ ├─ Quality Reviewer (teammate)
|
|
241
|
-
│ └─ [Conditional: TypeScript, React, A11y, Design, DB, Deps, Docs]
|
|
251
|
+
│ └─ [Conditional: TypeScript, React, A11y, Design, Go, Java, Python, Rust, DB, Deps, Docs]
|
|
242
252
|
│
|
|
243
253
|
├─ Phase 3: Debate round
|
|
244
254
|
│ └─ Reviewers challenge each other (max 2 rounds)
|
|
@@ -42,13 +42,19 @@ Detect file types in diff to determine conditional reviews:
|
|
|
42
42
|
| .tsx/.jsx files | react |
|
|
43
43
|
| .tsx/.jsx files | accessibility |
|
|
44
44
|
| .tsx/.jsx/.css/.scss files | frontend-design |
|
|
45
|
+
| .go files | go |
|
|
46
|
+
| .java files | java |
|
|
47
|
+
| .py files | python |
|
|
48
|
+
| .rs files | rust |
|
|
45
49
|
| DB/migration files | database |
|
|
46
50
|
| Dependency files changed | dependencies |
|
|
47
51
|
| Docs or significant code | documentation |
|
|
48
52
|
|
|
53
|
+
**Skill availability check**: Language/ecosystem reviews (typescript, react, accessibility, frontend-design, go, java, python, rust) require their optional skill plugin to be installed. Before spawning a conditional Reviewer for these focuses, check if `~/.claude/skills/{focus}/SKILL.md` exists (use Glob). If the skill file doesn't exist, **skip that review** — the language plugin isn't installed. Non-language reviews (database, dependencies, documentation) use skills bundled with this plugin and are always available.
|
|
54
|
+
|
|
49
55
|
### Phase 2: Run Reviews (Parallel)
|
|
50
56
|
|
|
51
|
-
Spawn Reviewer agents **in a single message**. Always run 7 core reviews; conditionally add
|
|
57
|
+
Spawn Reviewer agents **in a single message**. Always run 7 core reviews; conditionally add more based on changed file types:
|
|
52
58
|
|
|
53
59
|
| Focus | Always | Pattern Skill |
|
|
54
60
|
|-------|--------|---------------|
|
|
@@ -63,6 +69,10 @@ Spawn Reviewer agents **in a single message**. Always run 7 core reviews; condit
|
|
|
63
69
|
| react | conditional | react |
|
|
64
70
|
| accessibility | conditional | accessibility |
|
|
65
71
|
| frontend-design | conditional | frontend-design |
|
|
72
|
+
| go | conditional | go |
|
|
73
|
+
| java | conditional | java |
|
|
74
|
+
| python | conditional | python |
|
|
75
|
+
| rust | conditional | rust |
|
|
66
76
|
| database | conditional | database-patterns |
|
|
67
77
|
| dependencies | conditional | dependencies-patterns |
|
|
68
78
|
| documentation | conditional | documentation-patterns |
|
|
@@ -123,7 +133,7 @@ Display results from all agents:
|
|
|
123
133
|
│ ├─ Reviewer: consistency
|
|
124
134
|
│ ├─ Reviewer: regression
|
|
125
135
|
│ ├─ Reviewer: tests
|
|
126
|
-
│ └─ Reviewer: [conditional: typescript, react, a11y, design, database, deps, docs]
|
|
136
|
+
│ └─ Reviewer: [conditional: typescript, react, a11y, design, go, java, python, rust, database, deps, docs]
|
|
127
137
|
│
|
|
128
138
|
├─ Phase 3: Synthesis (PARALLEL)
|
|
129
139
|
│ ├─ Git agent (comment-pr)
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: architecture-patterns
|
|
3
|
-
description:
|
|
3
|
+
description: This skill should be used when reviewing code for SOLID violations, tight coupling, or layering issues.
|
|
4
4
|
user-invocable: false
|
|
5
5
|
allowed-tools: Read, Grep, Glob
|
|
6
6
|
---
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: complexity-patterns
|
|
3
|
-
description:
|
|
3
|
+
description: This skill should be used when reviewing code for high cyclomatic complexity, deep nesting, or long functions.
|
|
4
4
|
user-invocable: false
|
|
5
5
|
allowed-tools: Read, Grep, Glob
|
|
6
6
|
---
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: consistency-patterns
|
|
3
|
-
description:
|
|
3
|
+
description: This skill should be used when reviewing code for naming convention violations, pattern deviations, or inconsistent API styles.
|
|
4
4
|
user-invocable: false
|
|
5
5
|
allowed-tools: Read, Grep, Glob
|
|
6
6
|
---
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: database-patterns
|
|
3
|
-
description:
|
|
3
|
+
description: This skill should be used when reviewing database queries, migrations, indexes, or schema changes.
|
|
4
4
|
user-invocable: false
|
|
5
5
|
allowed-tools: Read, Grep, Glob
|
|
6
6
|
---
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: dependencies-patterns
|
|
3
|
-
description:
|
|
3
|
+
description: This skill should be used when reviewing dependency changes, lock files, or package additions.
|
|
4
4
|
user-invocable: false
|
|
5
5
|
allowed-tools: Read, Grep, Glob
|
|
6
6
|
---
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: documentation-patterns
|
|
3
|
-
description:
|
|
3
|
+
description: This skill should be used when reviewing for documentation drift, missing API docs, or stale comments.
|
|
4
4
|
user-invocable: false
|
|
5
5
|
allowed-tools: Read, Grep, Glob
|
|
6
6
|
---
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: performance-patterns
|
|
3
|
-
description:
|
|
3
|
+
description: This skill should be used when reviewing code for N+1 queries, memory leaks, or I/O bottlenecks.
|
|
4
4
|
user-invocable: false
|
|
5
5
|
allowed-tools: Read, Grep, Glob
|
|
6
6
|
---
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: regression-patterns
|
|
3
|
-
description:
|
|
3
|
+
description: This skill should be used when reviewing changes that may remove exports, change signatures, or alter behavior.
|
|
4
4
|
user-invocable: false
|
|
5
5
|
allowed-tools: Read, Grep, Glob
|
|
6
6
|
---
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: review-methodology
|
|
3
|
-
description:
|
|
3
|
+
description: This skill should be used when performing a code review to apply the standard 6-step review process.
|
|
4
4
|
user-invocable: false
|
|
5
5
|
allowed-tools: Read, Grep, Glob, Bash
|
|
6
6
|
---
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: security-patterns
|
|
3
|
-
description:
|
|
3
|
+
description: This skill should be used when reviewing code for injection flaws, auth bypasses, or hardcoded secrets.
|
|
4
4
|
user-invocable: false
|
|
5
5
|
allowed-tools: Read, Grep, Glob
|
|
6
6
|
---
|
|
@@ -5,24 +5,27 @@
|
|
|
5
5
|
"name": "DevFlow Contributors",
|
|
6
6
|
"email": "dean@keren.dev"
|
|
7
7
|
},
|
|
8
|
-
"version": "1.
|
|
8
|
+
"version": "1.3.0",
|
|
9
9
|
"homepage": "https://github.com/dean0x/devflow",
|
|
10
10
|
"repository": "https://github.com/dean0x/devflow",
|
|
11
11
|
"license": "MIT",
|
|
12
|
-
"keywords": [
|
|
12
|
+
"keywords": [
|
|
13
|
+
"skills",
|
|
14
|
+
"quality",
|
|
15
|
+
"patterns",
|
|
16
|
+
"auto-activate",
|
|
17
|
+
"enforcement",
|
|
18
|
+
"foundation"
|
|
19
|
+
],
|
|
13
20
|
"agents": [],
|
|
14
21
|
"skills": [
|
|
15
|
-
"accessibility",
|
|
16
22
|
"core-patterns",
|
|
17
23
|
"docs-framework",
|
|
18
|
-
"frontend-design",
|
|
19
24
|
"git-safety",
|
|
20
25
|
"git-workflow",
|
|
21
26
|
"github-patterns",
|
|
22
27
|
"input-validation",
|
|
23
|
-
"react",
|
|
24
28
|
"test-driven-development",
|
|
25
|
-
"test-patterns"
|
|
26
|
-
"typescript"
|
|
29
|
+
"test-patterns"
|
|
27
30
|
]
|
|
28
31
|
}
|
|
@@ -1,9 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: test-driven-development
|
|
3
|
-
description:
|
|
4
|
-
Enforce RED-GREEN-REFACTOR cycle during implementation. Write failing tests before
|
|
5
|
-
production code. Distinct from test-patterns (which reviews test quality) — this
|
|
6
|
-
skill enforces the TDD workflow during code generation.
|
|
3
|
+
description: This skill should be used when implementing new features, fixing bugs, or writing new code. Enforces RED-GREEN-REFACTOR.
|
|
7
4
|
user-invocable: false
|
|
8
5
|
allowed-tools: Read, Grep, Glob
|
|
9
6
|
activation:
|
|
@@ -94,7 +91,7 @@ See `references/rationalization-prevention.md` for extended examples with code.
|
|
|
94
91
|
|
|
95
92
|
## Process Enforcement
|
|
96
93
|
|
|
97
|
-
When implementing any feature under ambient BUILD/
|
|
94
|
+
When implementing any feature under ambient BUILD/GUIDED:
|
|
98
95
|
|
|
99
96
|
1. **Identify the first behavior** — What is the simplest thing this feature must do?
|
|
100
97
|
2. **Write the test** — Describe that behavior as a failing test
|
|
@@ -133,7 +130,7 @@ When skipping TDD, never rationalize. State clearly: "Skipping TDD because: [spe
|
|
|
133
130
|
|
|
134
131
|
## Integration with Ambient Mode
|
|
135
132
|
|
|
136
|
-
- **BUILD/
|
|
133
|
+
- **BUILD/GUIDED** → TDD enforced. Every new function/method gets test-first treatment.
|
|
137
134
|
- **BUILD/QUICK** → TDD skipped (trivial single-file edit).
|
|
138
|
-
- **BUILD/
|
|
139
|
-
- **DEBUG/
|
|
135
|
+
- **BUILD/ELEVATE** → TDD mentioned in nudge toward `/implement`.
|
|
136
|
+
- **DEBUG/GUIDED** → TDD applies to the fix: write a test that reproduces the bug first, then fix.
|
|
@@ -5,12 +5,19 @@
|
|
|
5
5
|
"name": "DevFlow Contributors",
|
|
6
6
|
"email": "dean@keren.dev"
|
|
7
7
|
},
|
|
8
|
-
"version": "1.
|
|
8
|
+
"version": "1.3.0",
|
|
9
9
|
"homepage": "https://github.com/dean0x/devflow",
|
|
10
10
|
"repository": "https://github.com/dean0x/devflow",
|
|
11
11
|
"license": "MIT",
|
|
12
|
-
"keywords": [
|
|
13
|
-
|
|
12
|
+
"keywords": [
|
|
13
|
+
"debugging",
|
|
14
|
+
"hypotheses",
|
|
15
|
+
"investigation",
|
|
16
|
+
"agent-teams"
|
|
17
|
+
],
|
|
18
|
+
"agents": [
|
|
19
|
+
"git"
|
|
20
|
+
],
|
|
14
21
|
"skills": [
|
|
15
22
|
"agent-teams",
|
|
16
23
|
"git-safety"
|
|
@@ -0,0 +1,22 @@
|
|
|
1
|
+
{
|
|
2
|
+
"name": "devflow-frontend-design",
|
|
3
|
+
"description": "Frontend design patterns - typography, color systems, spacing, motion, responsive design",
|
|
4
|
+
"author": {
|
|
5
|
+
"name": "DevFlow Contributors",
|
|
6
|
+
"email": "dean@keren.dev"
|
|
7
|
+
},
|
|
8
|
+
"version": "1.3.0",
|
|
9
|
+
"homepage": "https://github.com/dean0x/devflow",
|
|
10
|
+
"repository": "https://github.com/dean0x/devflow",
|
|
11
|
+
"license": "MIT",
|
|
12
|
+
"keywords": [
|
|
13
|
+
"design",
|
|
14
|
+
"typography",
|
|
15
|
+
"color",
|
|
16
|
+
"css"
|
|
17
|
+
],
|
|
18
|
+
"agents": [],
|
|
19
|
+
"skills": [
|
|
20
|
+
"frontend-design"
|
|
21
|
+
]
|
|
22
|
+
}
|
|
@@ -0,0 +1,22 @@
|
|
|
1
|
+
{
|
|
2
|
+
"name": "devflow-go",
|
|
3
|
+
"description": "Go language patterns - error handling, interfaces, concurrency, package design",
|
|
4
|
+
"author": {
|
|
5
|
+
"name": "DevFlow Contributors",
|
|
6
|
+
"email": "dean@keren.dev"
|
|
7
|
+
},
|
|
8
|
+
"version": "1.3.0",
|
|
9
|
+
"homepage": "https://github.com/dean0x/devflow",
|
|
10
|
+
"repository": "https://github.com/dean0x/devflow",
|
|
11
|
+
"license": "MIT",
|
|
12
|
+
"keywords": [
|
|
13
|
+
"go",
|
|
14
|
+
"golang",
|
|
15
|
+
"concurrency",
|
|
16
|
+
"errors"
|
|
17
|
+
],
|
|
18
|
+
"agents": [],
|
|
19
|
+
"skills": [
|
|
20
|
+
"go"
|
|
21
|
+
]
|
|
22
|
+
}
|