declapract-typescript-ehmpathy 0.49.12 → 0.49.14

package/dist/.test/assets/pnpm/declarations/practices/pnpm/stale-patched-dependency.declapract.integration.test.ts

@@ -0,0 +1,82 @@
+import fs from 'fs/promises';
+import { existsSync } from 'node:fs';
+import path from 'node:path';
+
+import { executeApply } from 'declapract';
+import { given, then, useBeforeAll, when } from 'test-fns';
+
+import { genTempRepoWithDeclarationsOutside } from '../../utils/genTempRepoWithDeclarationsOutside';
+
+// executeApply evaluates the whole practice, so widen the jest budget
+jest.setTimeout(180_000);
+
+/**
+ * .what = pipeline test for the pnpm patch settings + the stale-patched-dependency bad practice (#680)
+ * .why  = only executeApply proves declapract merges `allowUnusedPatches` + `ignorePatchFailures`
+ *         into a repo's extant `pnpm` field (its other keys kept), reads the repo's lockfile to
+ *         judge a patch stale, drops the stale key, and deletes the stale patch file — and that a
+ *         second apply is a no-op
+ */
+describe('pnpm — a stale patch never blocks an install', () => {
+  given('[case1] a repo with one patch the lockfile moved past and one it still resolves', () => {
+    const tempDir = genTempRepoWithDeclarationsOutside({
+      slug: 'pnpm-stale-patch',
+      clone: './src/practices/pnpm/.test/assets/repo-stale-patch',
+      declarations: './src/.test/assets/pnpm/declarations',
+      symlink: [{ at: 'node_modules', to: 'node_modules' }],
+    });
+    const stalePatch = 'patches/rhachet-roles-ehmpathy@1.39.1.patch';
+    const keptPatch = 'patches/type-fns@1.21.3.patch';
+
+    const state = useBeforeAll(async () => {
+      const config = path.join(tempDir, 'declapract.use.yml');
+      const read = () =>
+        fs.readFile(path.join(tempDir, 'package.json'), 'utf-8');
+      const before = await read();
+      await executeApply({ config });
+      const after1 = await read();
+      const exists1 = {
+        stale: existsSync(path.join(tempDir, stalePatch)),
+        kept: existsSync(path.join(tempDir, keptPatch)),
+      };
+      await executeApply({ config });
+      const after2 = await read();
+      return { before, after1, after2, exists1 };
+    }, 170_000);
+
+    when('[t0] the pnpm practice is applied', () => {
+      then('pnpm declares allowUnusedPatches + ignorePatchFailures', () => {
+        const pnpm = JSON.parse(state.after1).pnpm;
+        expect(pnpm.allowUnusedPatches).toEqual(true);
+        expect(pnpm.ignorePatchFailures).toEqual(true);
+      });
+
+      then("the repo's other pnpm keys are kept", () => {
+        const pnpm = JSON.parse(state.after1).pnpm;
+        expect(pnpm.overrides).toEqual({ 'react-refresh': '0.14.2' });
+      });
+
+      then('the stale patch key is retired, the resolved one kept', () => {
+        const patched = JSON.parse(state.after1).pnpm.patchedDependencies;
+        expect(patched).toEqual({
+          'type-fns@1.21.3': 'patches/type-fns@1.21.3.patch',
+        });
+      });
+
+      then('the stale patch file is deleted, the resolved one kept', () => {
+        expect(state.exists1).toEqual({ stale: false, kept: true });
+      });
+
+      then('the before + after contents match snapshot', () => {
+        expect(state.before).toMatchSnapshot('package.json — before');
+        expect(state.after1).toMatchSnapshot('package.json — after');
+      });
+    });
+
+    when('[t1] the practice is applied a second time', () => {
+      then('the second apply is a no-op', () => {
+        expect(state.after2).toEqual(state.after1);
+      });
+    });
+  });
+});

package/dist/.test/assets/rhachet/declarations/declapract.declare.yml

@@ -0,0 +1,4 @@
+# minimal declarations for rhachet integration tests
+declare:
+  practices: practices
+  use-cases: useCases.yml

package/dist/.test/assets/rhachet/declarations/practices/environments-aws/best-practice/.declapract.readme.md

@@ -0,0 +1,5 @@
+the aws environments provisioned here follow the `environments` best practices
+
+this practice declares no file of its own: `terraform-aws` owns `provision/aws/environments/{test,prep,prod}/`.
+an EXISTS-only claim here could never be fixed (an EXISTS check carries no fix), so on a fresh repo it
+marked the file manual and blocked the owner's fix too (#630, #607).

package/dist/.test/assets/rhachet/declarations/practices/rhachet/.declapract.integration.test.ts

@@ -0,0 +1,98 @@
+import fs from 'fs/promises';
+import path from 'node:path';
+
+import { executeApply } from 'declapract';
+import { genTempDir, given, then, useThen, when } from 'test-fns';
+
+/**
+ * .what = end-to-end proof of the rhachet/prod-deps fix (D26 / #571), run through the REAL declapract
+ *   apply pipeline against a genTempDir clone of a consumer repo whose package.json lists `rhachet`
+ *   AND a `rhachet-brains-*` package in `dependencies` (prod).
+ * .why  = the old family regex was `/^rhachet(-roles-.*)?$/`, so a `rhachet-brains-*` prod dep slipped
+ *   the net and stayed a prod dep — and if it were also a devDep at a different version, the manifest
+ *   carried a duplicate whose two versions conflict. the fix is a widened `/^rhachet(-[a-z]+-.*)?$/`
+ *   plus a `withRhachetDepsMovedToDevDeps` partition transformer that relocates every rhachet family
+ *   package into devDependencies. a unit test of the transformer is necessary but not sufficient
+ *   (`rule.require.declapract-integration-tests`): only the pipeline proves the declaration's target
+ *   glob matches package.json and the relocation lands on a real consumer file.
+ * .note = the package.json holds `rhachet` (single-segment) AND `rhachet-brains-anthropic` (the
+ *   `-brains-` family the old regex missed), plus a non-rhachet prod dep (`uuid`) that must be
+ *   retained. the after-state proves the widened match AND the retention of every other prod dep.
+ */
+describe('rhachet/prod-deps relocation', () => {
+  given('[case1] a repo with rhachet + a rhachet-brains-* package in prod deps', () => {
+    const tempDir = genTempDir({
+      slug: 'declapract-rhachet-prod-deps',
+      clone: './src/practices/rhachet/bad-practices/prod-deps/.test/assets/demo-repo-with-rhachet-prod-deps',
+      symlink: [{ at: 'declarations', to: 'src' }],
+    });
+
+    const pkgPath = 'package.json';
+    const read = (relativePath: string) =>
+      fs.readFile(path.join(tempDir, relativePath), 'utf-8');
+    const applyFix = () =>
+      executeApply({
+        config: path.join(tempDir, 'declapract.use.yml'),
+        practice: 'rhachet',
+        file: pkgPath,
+      });
+
+    when('[t0] the input (before any fix)', () => {
+      then('the package.json input matches snapshot', async () => {
+        expect(await read(pkgPath)).toMatchSnapshot('package.json — before');
+      });
+    });
+
+    when('[t1] the prod-deps fix is applied', () => {
+      useThen('relocate every rhachet family package into devDeps', async () =>
+        applyFix(),
+      );
+
+      then(
+        'both rhachet packages leave dependencies and land in devDependencies, the non-rhachet prod dep is retained, and it matches snapshot',
+        async () => {
+          const pkg = JSON.parse(await read(pkgPath));
+          // both rhachet family packages are gone from prod deps
+          expect(pkg.dependencies?.['rhachet']).toBeUndefined();
+          expect(pkg.dependencies?.['rhachet-brains-anthropic']).toBeUndefined();
+          // and now sit in dev deps (the -brains- match is the D26 proof)
+          expect(pkg.devDependencies['rhachet']).toEqual('1.49.2');
+          expect(pkg.devDependencies['rhachet-brains-anthropic']).toEqual(
+            '0.4.3',
+          );
+          // the non-rhachet prod dep is retained in dependencies
+          expect(pkg.dependencies.uuid).toEqual('9.0.0');
+          // the prior devDep survives untouched
+          expect(pkg.devDependencies.jest).toEqual('29.3.1');
+          // full content, for the reviewer's eye
+          expect(await read(pkgPath)).toMatchSnapshot('package.json — after');
+        },
+      );
+    });
+
+    when('[t2] the fix is applied a second time (idempotency)', () => {
+      // .note = the D26 invariant under re-apply is that the relocation is a FIXED POINT: once
+      //   moved, a second pass neither re-introduces a rhachet package into prod deps nor drops a
+      //   retained dep. we do NOT assert full-file byte equality, because the rhachet best-practice
+      //   package.json declaration (a separate declarer, out of scope for D26) writes a raw
+      //   `@declapract{check.minVersion(...)}` marker on the first pass and resolves it on the
+      //   second — a marker-resolution quirk of that declaration, not of the relocation under test.
+      const pkg = useThen('a second apply over its own output', async () => {
+        await applyFix(); // second apply, over the post-first-fix output
+        return JSON.parse(await read(pkgPath));
+      });
+
+      then('the rhachet packages stay out of prod deps', () => {
+        expect(pkg.dependencies?.['rhachet']).toBeUndefined();
+        expect(pkg.dependencies?.['rhachet-brains-anthropic']).toBeUndefined();
+      });
+
+      then('the relocated + retained deps survive the re-apply', () => {
+        expect(pkg.devDependencies['rhachet']).toEqual('1.49.2');
+        expect(pkg.devDependencies['rhachet-brains-anthropic']).toEqual('0.4.3');
+        expect(pkg.dependencies.uuid).toEqual('9.0.0');
+        expect(pkg.devDependencies.jest).toEqual('29.3.1');
+      });
+    });
+  });
+});

package/dist/.test/assets/rhachet/declarations/practices/rhachet/.test/assets/demo-repo-with-consumer-boot/.agent/repo=.this/role=any/boot.yml

@@ -0,0 +1,9 @@
+# a consumer's OWN boot curation — it predates the declapract fix and carries entries
+# the fix must preserve: a say pick of its own, and a ref pick of its own deep variant.
+briefs:
+  say:
+    - briefs/my-own-brief.md
+  ref:
+    - briefs/my-own-deep-variant.md
+    # the old practice shape put this declared glob under ref; the fix moves it to not (#689)
+    - briefs/domain.terms/term=*._.choice.reason.md

package/dist/.test/assets/rhachet/declarations/practices/rhachet/.test/assets/demo-repo-with-consumer-boot/declapract.declare.yml

@@ -0,0 +1,4 @@
+declare:
+  examples: declarations/examples
+  practices: declarations/practices
+  use-cases: declarations/useCases.yml

package/dist/.test/assets/rhachet/declarations/practices/rhachet/.test/assets/demo-repo-with-consumer-boot/declapract.use.yml

@@ -0,0 +1,2 @@
+declarations: './'
+useCase: typescript-project-core

package/dist/.test/assets/rhachet/declarations/practices/rhachet/.test/assets/demo-repo-with-consumer-boot/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "test-project",
+  "version": "1.0.0"
+}

package/dist/.test/assets/rhachet/declarations/practices/rhachet/.test/assets/repo-keyrack-extant/.agent/keyrack.yml

@@ -0,0 +1,9 @@
+org: ehmpathy
+extends:
+  - .agent/repo=ehmpathy/role=mechanic/keyrack.yml
+env.prod: null
+env.prep:
+  - OPENROUTER_API_KEY
+env.test:
+  # the local aws login, from before is-optional-if-has
+  - AWS_PROFILE

package/dist/.test/assets/rhachet/declarations/practices/rhachet/.test/assets/repo-keyrack-extant/declapract.use.node.yml

@@ -0,0 +1,4 @@
+# .note = declarations dir is symlinked by the test to src/.test/assets/rhachet/declarations
+# .why  = the same repo with no aws practice: the keyrack.yml is left alone
+declarations: 'declarations/declapract.declare.yml'
+useCase: rhachet-node

package/dist/.test/assets/rhachet/declarations/practices/rhachet/.test/assets/repo-keyrack-extant/declapract.use.yml

@@ -0,0 +1,4 @@
+# .note = declarations dir is symlinked by the test to src/.test/assets/rhachet/declarations
+# .why  = an aws repo whose keyrack.yml holds a bare AWS_PROFILE (#491)
+declarations: 'declarations/declapract.declare.yml'
+useCase: rhachet-aws

package/dist/.test/assets/rhachet/declarations/practices/rhachet/.test/assets/repo-keyrack-extant/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "test-project",
+  "version": "1.0.0"
+}

package/dist/.test/assets/rhachet/declarations/practices/rhachet/.test/assets/repo-self-linked/declapract.use.yml

@@ -0,0 +1,4 @@
+# .note = declarations dir is symlinked by the test to src/.test/assets/rhachet/declarations
+# .why  = a rhachet roles package that self-links its roles via `link:.` (#520)
+declarations: 'declarations/declapract.declare.yml'
+useCase: rhachet-node

package/dist/.test/assets/rhachet/declarations/practices/rhachet/.test/assets/repo-self-linked/package.json

@@ -0,0 +1,22 @@
+{
+  "name": "rhachet-roles-demo",
+  "version": "1.0.0",
+  "scripts": {
+    "build": "tsc -p ./tsconfig.build.json",
+    "prepare:rhachet": "rhachet init --keys --hooks --roles mechanic behaver driver reviewer librarian ergonomist architect dispatcher learner achiever telepath operator observer deployer playwright enroller",
+    "upgrade:rhachet": "rhachet upgrade"
+  },
+  "devDependencies": {
+    "rhachet": "1.49.2",
+    "rhachet-brains-anthropic": "0.4.3",
+    "rhachet-brains-fireworksai": "0.1.6",
+    "rhachet-brains-xai": "0.3.3",
+    "rhachet-roles-bhrain": "0.34.1",
+    "rhachet-roles-bhrowser": "0.1.0",
+    "rhachet-roles-bhuild": "0.21.36",
+    "rhachet-roles-demo": "link:.",
+    "rhachet-roles-ehmpathy": "1.38.12",
+    "rhachet-roles-ghlitch": "0.3.0",
+    "rhachet-roles-rhachet": "0.1.7"
+  }
+}

package/dist/.test/assets/rhachet/declarations/practices/rhachet/__snapshots__/.declapract.integration.test.ts.snap

@@ -0,0 +1,46 @@
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
+
+exports[`rhachet/prod-deps relocation given: [case1] a repo with rhachet + a rhachet-brains-* package in prod deps when: [t0] the input (before any fix) then: the package.json input matches snapshot: package.json — before 1`] = `
+"{
+  "name": "test-project",
+  "version": "1.0.0",
+  "dependencies": {
+    "rhachet": "1.47.5",
+    "rhachet-brains-anthropic": "0.4.3",
+    "uuid": "9.0.0"
+  },
+  "devDependencies": {
+    "jest": "29.3.1"
+  }
+}
+"
+`;
+
+exports[`rhachet/prod-deps relocation given: [case1] a repo with rhachet + a rhachet-brains-* package in prod deps when: [t1] the prod-deps fix is applied then: both rhachet packages leave dependencies and land in devDependencies, the non-rhachet prod dep is retained, and it matches snapshot: package.json — after 1`] = `
+"{
+  "name": "test-project",
+  "version": "1.0.0",
+  "dependencies": {
+    "uuid": "9.0.0"
+  },
+  "devDependencies": {
+    "jest": "29.3.1",
+    "rhachet": "1.49.2",
+    "rhachet-brains-anthropic": "0.4.3",
+    "rhachet-brains-fireworksai": "@declapract{check.minVersion('0.2.3')}",
+    "rhachet-brains-openrouter": "@declapract{check.minVersion('0.1.3')}",
+    "rhachet-brains-xai": "@declapract{check.minVersion('0.3.3')}",
+    "rhachet-roles-bhrain": "@declapract{check.minVersion('0.40.0')}",
+    "rhachet-roles-bhrowser": "@declapract{check.minVersion('0.1.0')}",
+    "rhachet-roles-bhuild": "@declapract{check.minVersion('0.23.2')}",
+    "rhachet-roles-ehmpathy": "@declapract{check.minVersion('1.39.5')}",
+    "rhachet-roles-ghlitch": "@declapract{check.minVersion('0.3.0')}",
+    "rhachet-roles-rhachet": "@declapract{check.minVersion('0.1.7')}"
+  },
+  "scripts": {
+    "prepare:rhachet": "rhachet init --keys --hooks --roles mechanic behaver driver reviewer librarian ergonomist architect dispatcher learner achiever telepath operator observer deployer playwright enroller",
+    "upgrade:rhachet": "rhachet upgrade"
+  }
+}
+"
+`;

package/dist/.test/assets/rhachet/declarations/practices/rhachet/__snapshots__/boot-refs-glossary.declapract.integration.test.ts.snap

@@ -0,0 +1,6 @@
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
+
+exports[`rhachet boot.yml defaults to say, refs only deep glossary variants given: [case1] the shipped boot.yml template when: [t0] the template is read then: the emitted glossary ref lines match snapshot: boot.yml glossary refs 1`] = `
+"- briefs/domain.terms/term=*._.choice.reason.md
+- briefs/domain.terms/term=*._.choice.example=*.md"
+`;

package/dist/.test/assets/rhachet/declarations/practices/rhachet/__snapshots__/boot-yml-findsert.declapract.integration.test.ts.snap

@@ -0,0 +1,33 @@
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
+
+exports[`rhachet — boot.yml findsert (req 1: consumer entries survive) given: [case1] a consumer whose boot.yml carries its own entries when: [t0] the input (before any fix) then: the consumer boot.yml carries its own picks, no budget, + matches snapshot: boot.yml — before 1`] = `
+"# a consumer's OWN boot curation — it predates the declapract fix and carries entries
+# the fix must preserve: a say pick of its own, and a ref pick of its own deep variant.
+briefs:
+  say:
+    - briefs/my-own-brief.md
+  ref:
+    - briefs/my-own-deep-variant.md
+    # the old practice shape put this declared glob under ref; the fix moves it to not (#689)
+    - briefs/domain.terms/term=*._.choice.reason.md
+"
+`;
+
+exports[`rhachet — boot.yml findsert (req 1: consumer entries survive) given: [case1] a consumer whose boot.yml carries its own entries when: [t1] the findsert fix is applied then: both declared globs land AND the consumer's own say + ref picks survive, and it matches snapshot: boot.yml — after 1`] = `
+"# a consumer's OWN boot curation — it predates the declapract fix and carries entries
+# the fix must preserve: a say pick of its own, and a ref pick of its own deep variant.
+briefs:
+  say:
+    - briefs/my-own-brief.md
+  ref:
+    - briefs/my-own-deep-variant.md
+  not:
+    - briefs/domain.terms/term=*._.choice.reason.md
+    - briefs/domain.terms/term=*._.choice.example=*.md
+# budget = the token cap on the say payload; a boot over it halts.
+# to fix a halt: demote a say glob to ref, use a .min brief, or raise the cap.
+# plain \`5000\`, never \`5_000\`: yaml 1.2 reads an underscore integer as a string.
+budget:
+  tokens: 5000
+"
+`;

package/dist/.test/assets/rhachet/declarations/practices/rhachet/__snapshots__/keyrack-yml-findsert.declapract.integration.test.ts.snap

@@ -0,0 +1,28 @@
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
+
+exports[`rhachet — keyrack.yml AWS_PROFILE findsert given: [case1] an aws repo whose keyrack.yml holds a bare AWS_PROFILE when: [t0] the rhachet practice is applied then: the before + after contents match snapshot: keyrack.yml — after 1`] = `
+"org: ehmpathy
+extends:
+  - .agent/repo=ehmpathy/role=mechanic/keyrack.yml
+env.prod: null
+env.prep:
+  - OPENROUTER_API_KEY
+env.test:
+  # the local aws login, from before is-optional-if-has
+  - key: AWS_PROFILE
+    is-optional-if-has: AWS_ACCESS_KEY_ID
+"
+`;
+
+exports[`rhachet — keyrack.yml AWS_PROFILE findsert given: [case1] an aws repo whose keyrack.yml holds a bare AWS_PROFILE when: [t0] the rhachet practice is applied then: the before + after contents match snapshot: keyrack.yml — before 1`] = `
+"org: ehmpathy
+extends:
+  - .agent/repo=ehmpathy/role=mechanic/keyrack.yml
+env.prod: null
+env.prep:
+  - OPENROUTER_API_KEY
+env.test:
+  # the local aws login, from before is-optional-if-has
+  - AWS_PROFILE
+"
+`;

package/dist/.test/assets/rhachet/declarations/practices/rhachet/__snapshots__/self-link-build-order.declapract.integration.test.ts.snap

@@ -0,0 +1,81 @@
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
+
+exports[`rhachet — prepare:rhachet builds first in a self-linked repo given: [case1] a rhachet roles package with a link:. self-dep and no build before init when: [t0] the rhachet practice is applied then: the before + after contents match snapshot: package.json — after 1`] = `
+"{
+  "name": "rhachet-roles-demo",
+  "version": "1.0.0",
+  "scripts": {
+    "build": "tsc -p ./tsconfig.build.json",
+    "prepare:rhachet": "npm run build && rhachet init --keys --hooks --roles mechanic behaver driver reviewer librarian ergonomist architect dispatcher learner achiever telepath operator observer deployer playwright enroller",
+    "upgrade:rhachet": "rhachet upgrade"
+  },
+  "devDependencies": {
+    "rhachet": "1.49.2",
+    "rhachet-brains-anthropic": "0.4.3",
+    "rhachet-brains-fireworksai": "0.2.3",
+    "rhachet-brains-xai": "0.3.3",
+    "rhachet-roles-bhrain": "0.40.0",
+    "rhachet-roles-bhrowser": "0.1.0",
+    "rhachet-roles-bhuild": "0.23.2",
+    "rhachet-roles-demo": "link:.",
+    "rhachet-roles-ehmpathy": "1.39.5",
+    "rhachet-roles-ghlitch": "0.3.0",
+    "rhachet-roles-rhachet": "0.1.7",
+    "rhachet-brains-openrouter": "@declapract{check.minVersion('0.1.3')}"
+  }
+}
+"
+`;
+
+exports[`rhachet — prepare:rhachet builds first in a self-linked repo given: [case1] a rhachet roles package with a link:. self-dep and no build before init when: [t0] the rhachet practice is applied then: the before + after contents match snapshot: package.json — before 1`] = `
+"{
+  "name": "rhachet-roles-demo",
+  "version": "1.0.0",
+  "scripts": {
+    "build": "tsc -p ./tsconfig.build.json",
+    "prepare:rhachet": "rhachet init --keys --hooks --roles mechanic behaver driver reviewer librarian ergonomist architect dispatcher learner achiever telepath operator observer deployer playwright enroller",
+    "upgrade:rhachet": "rhachet upgrade"
+  },
+  "devDependencies": {
+    "rhachet": "1.49.2",
+    "rhachet-brains-anthropic": "0.4.3",
+    "rhachet-brains-fireworksai": "0.1.6",
+    "rhachet-brains-xai": "0.3.3",
+    "rhachet-roles-bhrain": "0.34.1",
+    "rhachet-roles-bhrowser": "0.1.0",
+    "rhachet-roles-bhuild": "0.21.36",
+    "rhachet-roles-demo": "link:.",
+    "rhachet-roles-ehmpathy": "1.38.12",
+    "rhachet-roles-ghlitch": "0.3.0",
+    "rhachet-roles-rhachet": "0.1.7"
+  }
+}
+"
+`;
+
+exports[`rhachet — prepare:rhachet builds first in a self-linked repo given: [case1] a rhachet roles package with a link:. self-dep and no build before init when: [t1] the practice is applied a second time then: every raw marker resolves to a version, and the build step is kept: package.json — after the second apply 1`] = `
+"{
+  "name": "rhachet-roles-demo",
+  "version": "1.0.0",
+  "scripts": {
+    "build": "tsc -p ./tsconfig.build.json",
+    "prepare:rhachet": "npm run build && rhachet init --keys --hooks --roles mechanic behaver driver reviewer librarian ergonomist architect dispatcher learner achiever telepath operator observer deployer playwright enroller",
+    "upgrade:rhachet": "rhachet upgrade"
+  },
+  "devDependencies": {
+    "rhachet": "1.49.2",
+    "rhachet-brains-anthropic": "0.4.3",
+    "rhachet-brains-fireworksai": "0.2.3",
+    "rhachet-brains-xai": "0.3.3",
+    "rhachet-roles-bhrain": "0.40.0",
+    "rhachet-roles-bhrowser": "0.1.0",
+    "rhachet-roles-bhuild": "0.23.2",
+    "rhachet-roles-demo": "link:.",
+    "rhachet-roles-ehmpathy": "1.39.5",
+    "rhachet-roles-ghlitch": "0.3.0",
+    "rhachet-roles-rhachet": "0.1.7",
+    "rhachet-brains-openrouter": "0.1.3"
+  }
+}
+"
+`;

package/dist/.test/assets/rhachet/declarations/practices/rhachet/bad-practices/deprecated-use-file/.declapract.readme.md

@@ -0,0 +1,11 @@
+# Deprecated rhachet.use.ts File
+
+This bad practice detects and removes the deprecated `@/rhachet.use.ts` (i.e., `rhachet.use.ts` at repo root) config file.
+
+## Why
+
+The `rhachet.use.ts` config file pattern has been deprecated. Projects should migrate away from this pattern.
+
+## Fix
+
+The fix automatically deletes the file from the repository.

package/dist/.test/assets/rhachet/declarations/practices/rhachet/bad-practices/deprecated-use-file/rhachet.use.ts.declapract.ts

@@ -0,0 +1,12 @@
+import { FileCheckType, type FileFixFunction } from 'declapract';
+
+/**
+ * .what = detects the deprecated @/rhachet.use.ts config file
+ * .why = this config file pattern has been deprecated and should be removed
+ */
+
+export const check = FileCheckType.EXISTS;
+
+export const fix: FileFixFunction = () => {
+  return { contents: null }; // delete the file
+};

package/dist/.test/assets/rhachet/declarations/practices/rhachet/bad-practices/prod-deps/.declapract.readme.md

@@ -0,0 +1,59 @@
+# rhachet prod-deps bad practice
+
+## what
+
+detects `rhachet` and every `rhachet-<family>-*` package (e.g. `rhachet-roles-*`, `rhachet-brains-*`) listed as production dependencies and moves them to devDependencies.
+
+## why
+
+rhachet packages are build-time / development tooling only. they should never be shipped as production dependencies because:
+
+1. **no runtime usage** — rhachet is used for agent role management, skill linking, and development workflows. none of this runs at runtime in production.
+
+2. **bloated bundles** — including rhachet in prod deps unnecessarily inflates `node_modules` for deployed applications.
+
+3. **dependency hygiene** — packages that are only used during development belong in `devDependencies`. at worst, if downstream packages need them, they should be declared as `peerDependencies`.
+
+## packages covered
+
+- `rhachet`
+- `rhachet-<family>-*` — every rhachet family, e.g.
+  - `rhachet-roles-*` (`rhachet-roles-ehmpathy`, `rhachet-roles-bhrain`, `rhachet-roles-bhuild`)
+  - `rhachet-brains-*`
+
+a single-segment `rhachet-*` (e.g. `rhachet-other`, no family segment) is left alone.
+
+## fix
+
+moves all matching packages from `dependencies` to `devDependencies`, preserving their versions.
+
+## correct placement
+
+```json
+{
+  "devDependencies": {
+    "rhachet": "^1.19.0",
+    "rhachet-roles-ehmpathy": "^1.15.0"
+  }
+}
+```
+
+or, if downstream packages need to use them:
+
+```json
+{
+  "peerDependencies": {
+    "rhachet": ">=1.0.0"
+  }
+}
+```
+
+never:
+
+```json
+{
+  "dependencies": {
+    "rhachet": "^1.19.0"
+  }
+}
+```

package/dist/.test/assets/rhachet/declarations/practices/rhachet/bad-practices/prod-deps/.test/assets/demo-repo-with-rhachet-prod-deps/declapract.declare.yml

@@ -0,0 +1,4 @@
+declare:
+  examples: declarations/examples
+  practices: declarations/practices
+  use-cases: declarations/useCases.yml

package/dist/.test/assets/rhachet/declarations/practices/rhachet/bad-practices/prod-deps/.test/assets/demo-repo-with-rhachet-prod-deps/declapract.use.yml

@@ -0,0 +1,2 @@
+declarations: './'
+useCase: typescript-project-core

package/dist/.test/assets/rhachet/declarations/practices/rhachet/bad-practices/prod-deps/.test/assets/demo-repo-with-rhachet-prod-deps/package.json

@@ -0,0 +1,12 @@
+{
+  "name": "test-project",
+  "version": "1.0.0",
+  "dependencies": {
+    "rhachet": "1.47.5",
+    "rhachet-brains-anthropic": "0.4.3",
+    "uuid": "9.0.0"
+  },
+  "devDependencies": {
+    "jest": "29.3.1"
+  }
+}

package/dist/.test/assets/rhachet/declarations/practices/rhachet/bad-practices/prod-deps/package.json

@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "rhachet": "@declapract{check.minVersion('0.0.0')}"
+  }
+}