dd-trace 6.15.0 → 6.17.0

package/packages/dd-trace/src/ci-visibility/dynamic-atr-retries.js

@@ -0,0 +1,104 @@
+'use strict'
+
+const log = require('../log')
+
+const {
+  retriesForDuration,
+  retryBucketIndexForDuration,
+} = require('./efd-retry-policy')
+
+const DYNAMIC_ATR_ENABLED_ENV = 'DD_CIVISIBILITY_DYNAMIC_ATR_ENABLED'
+const DYNAMIC_ATR_BUCKETS_ENV = 'DD_CIVISIBILITY_DYNAMIC_ATR_BUCKETS'
+
+const RETRY_BUCKET_COUNT = 5
+const MAX_RETRIES_PER_BUCKET = 20
+
+/**
+ * Returns whether duration-based ATR retry budgets are enabled.
+ *
+ * @param {unknown} value A parsed test-optimization configuration value.
+ */
+function isDynamicAtrEnabled (value) {
+  return value === true
+}
+
+/**
+ * Parses and validates custom ATR retry buckets from the parsed
+ * test-optimization configuration.
+ *
+ * Returns a frozen array of 5 positive integers in [1, 20], or `null`
+ * when the value is unset/empty or invalid (in which case the EFD retry
+ * settings from the backend are used).
+ *
+ * @param {unknown} value A parsed test-optimization configuration value.
+ * @returns {number[] | null}
+ */
+function getDynamicAtrBuckets (value) {
+  if (!Array.isArray(value) || value.length === 0) {
+    return null
+  }
+
+  const parts = value
+  const raw = parts.join(',')
+  if (parts.length !== RETRY_BUCKET_COUNT) {
+    log.warn(
+      'Invalid %s value %o; expected five comma-separated integers in [1, %d]',
+      DYNAMIC_ATR_BUCKETS_ENV, raw, MAX_RETRIES_PER_BUCKET
+    )
+    return null
+  }
+
+  const buckets = []
+  for (const part of parts) {
+    const trimmedPart = typeof part === 'string' ? part.trim() : ''
+    if (!/^\d+$/.test(trimmedPart)) {
+      log.warn(
+        'Invalid %s value %o; expected five comma-separated integers in [1, %d]',
+        DYNAMIC_ATR_BUCKETS_ENV, raw, MAX_RETRIES_PER_BUCKET
+      )
+      return null
+    }
+    const value = Number(trimmedPart)
+    if (!Number.isSafeInteger(value) || value < 1 || value > MAX_RETRIES_PER_BUCKET) {
+      log.warn(
+        'Invalid %s value %o; expected five comma-separated integers in [1, %d]',
+        DYNAMIC_ATR_BUCKETS_ENV, raw, MAX_RETRIES_PER_BUCKET
+      )
+      return null
+    }
+    buckets.push(value)
+  }
+
+  return Object.freeze(buckets)
+}
+
+/**
+ * Computes the dynamic ATR retry count for a test based on its initial-attempt
+ * duration.
+ *
+ * When `customBuckets` is provided, the bucket at the duration index is used.
+ * Otherwise, the EFD retry policy's `retriesForDuration` is used.
+ *
+ * The result is clamped to a minimum of 1.
+ *
+ * @param {number} durationMs - Initial-attempt duration in milliseconds.
+ * @param {import('./efd-retry-policy').EfdRetryPolicy} efdRetryPolicy
+ * @param {number[] | null} customBuckets
+ */
+function getDynamicAtrRetryCount (durationMs, efdRetryPolicy, customBuckets) {
+  let retryCount
+  if (customBuckets) {
+    retryCount = customBuckets[retryBucketIndexForDuration(durationMs)]
+  } else {
+    retryCount = retriesForDuration(durationMs, efdRetryPolicy)
+  }
+  return Math.max(1, retryCount)
+}
+
+module.exports = {
+  DYNAMIC_ATR_BUCKETS_ENV,
+  DYNAMIC_ATR_ENABLED_ENV,
+  getDynamicAtrBuckets,
+  getDynamicAtrRetryCount,
+  isDynamicAtrEnabled,
+}

package/packages/dd-trace/src/ci-visibility/dynamic-instrumentation/worker/index.js

@@ -52,7 +52,6 @@ const limits = {
 
 /**
  * @param {object} value - Snapshot object or sub-object.
- * @returns {boolean}
  */
 function isCapturedValue (value) {
   return typeof value.type === 'string'
@@ -62,7 +61,6 @@ function isCapturedValue (value) {
  * Remove empty capture containers before sending snapshots through the Test Optimization logs path.
  *
  * @param {object} value - Snapshot object or sub-object.
- * @returns {void}
  */
 function removeEmptyCaptureProperties (value) {
   const stack = [value]

package/packages/dd-trace/src/ci-visibility/efd-retry-policy.js

@@ -23,12 +23,43 @@ const EARLY_FLAKE_DETECTION_RETRY_BUCKETS =
  * @property {number} schedulingRetryCount
  */
 
+/**
+ * Returns the zero-based dynamic ATR retry-bucket index for a test duration.
+ *
+ * Bucket boundaries (ms): 5 000, 10 000, 30 000, 300 000.
+ * Durations at a boundary remain in that bucket.
+ *
+ * @param {number} durationMs
+ */
+function retryBucketIndexForDuration (durationMs) {
+  for (let index = 0; index < EARLY_FLAKE_DETECTION_RETRY_THRESHOLDS.length; index++) {
+    if (durationMs <= EARLY_FLAKE_DETECTION_RETRY_THRESHOLDS[index].limitMs) {
+      return index
+    }
+  }
+  return EARLY_FLAKE_DETECTION_RETRY_THRESHOLDS.length // > 5 m bucket
+}
+
+/**
+ * Returns the backend retry budget using dynamic ATR's inclusive duration cutoffs.
+ *
+ * @param {number} durationMs
+ * @param {EfdRetryPolicy} retryPolicy
+ */
+function retriesForDuration (durationMs, retryPolicy) {
+  const index = retryBucketIndexForDuration(durationMs)
+  if (index < retryPolicy.durationRetryCounts.length) {
+    return retryPolicy.durationRetryCounts[index].retryCount
+  }
+  return 0
+}
+
 /**
  * @param {number} durationMs
  * @param {EfdRetryPolicy} retryPolicy
- * @returns {number}
  */
 function getEfdRetryCountForDuration (durationMs, retryPolicy) {
+  // EFD retains exclusive cutoffs, including no retries at exactly five minutes.
   for (const { durationLimitMs, retryCount } of retryPolicy.durationRetryCounts) {
     if (durationMs < durationLimitMs) {
       return retryCount
@@ -62,7 +93,6 @@ function createEfdRetryPolicy (retriesByDuration = {}) {
 
 /**
  * @param {EfdRetryPolicy | undefined} retryPolicy
- * @returns {boolean}
  */
 function hasEfdRetries (retryPolicy) {
   return (retryPolicy?.schedulingRetryCount ?? 0) > 0
@@ -71,7 +101,6 @@ function hasEfdRetries (retryPolicy) {
 /**
  * @param {number} retryIndex
  * @param {number | undefined} retryCount
- * @returns {boolean}
  */
 function shouldSkipEfdRetry (retryIndex, retryCount) {
   return retryCount !== undefined && retryIndex > retryCount
@@ -85,5 +114,7 @@ module.exports = {
   createEfdRetryPolicy,
   getEfdRetryCountForDuration,
   hasEfdRetries,
+  retriesForDuration,
+  retryBucketIndexForDuration,
   shouldSkipEfdRetry,
 }

package/packages/dd-trace/src/ci-visibility/exporters/agentless/coverage-writer.js

@@ -36,7 +36,6 @@ class Writer extends BaseWriter {
    *
    * @param {(error?: Error) => void} [done]
    * @param {{ deadline?: number }} [options]
-   * @returns {void}
    */
   flush (done, options) {
     this.#requestTracker.flush(done, options)

package/packages/dd-trace/src/ci-visibility/exporters/agentless/di-logs-writer.js

@@ -37,7 +37,6 @@ class DynamicInstrumentationLogsWriter extends BaseWriter {
    *
    * @param {(error?: Error) => void} [done]
    * @param {{ deadline?: number }} [options]
-   * @returns {void}
    */
   flush (done, options) {
     this.#requestTracker.flush(done, options)

package/packages/dd-trace/src/ci-visibility/exporters/agentless/writer.js

@@ -36,7 +36,6 @@ class Writer extends BaseWriter {
    *
    * @param {(error?: Error) => void} [done]
    * @param {{ deadline?: number }} [options]
-   * @returns {void}
    */
   flush (done, options) {
     this.#requestTracker.flush(done, options)

package/packages/dd-trace/src/ci-visibility/exporters/ci-validation/index.js

@@ -105,7 +105,6 @@ class CiValidationExporter extends CiVisibilityExporter {
   /**
    * Resolves the inherited git-upload gate without performing an upload.
    *
-   * @returns {void}
    */
   sendGitMetadata () {
     this._resolveGit()
@@ -114,14 +113,12 @@ class CiValidationExporter extends CiVisibilityExporter {
   /**
    * Drops debugger logs in offline validation mode.
    *
-   * @returns {void}
    */
   exportDiLogs () {}
 
   /**
    * Reports that code coverage is outside the offline validator's scope.
    *
-   * @returns {boolean} always false
    */
   canReportCodeCoverage () {
     return false
@@ -140,7 +137,6 @@ class CiValidationExporter extends CiVisibilityExporter {
   /**
    * Reports that screenshot upload is unavailable.
    *
-   * @returns {boolean} always false
    */
   canUploadTestScreenshots () {
     return false

package/packages/dd-trace/src/ci-visibility/exporters/ci-validation/msgpack-to-json.js

@@ -257,7 +257,6 @@ class MsgpackJsonConverter {
     }
   }
 
-  /** @returns {number} unsigned 8-bit integer */
   #readUInt8 () {
     this.#assertAvailable(1)
     return this.#input[this.#offset++]

package/packages/dd-trace/src/ci-visibility/exporters/ci-validation/sink.js

@@ -179,7 +179,6 @@ class CiValidationSink {
   /**
    * Atomically publishes this process's bounded completion evidence.
    *
-   * @returns {boolean} whether the record was published
    */
   #writeCompletionRecord () {
     const directoryPath = path.join(this.#outputRoot, 'completions')
@@ -215,7 +214,6 @@ class CiValidationSink {
    * Writes one completed JSON payload to a unique file.
    *
    * @param {Buffer} payload JSON payload
-   * @returns {boolean} whether the payload was written
    */
   #writePayloadFile (payload) {
     if (this.#fileCount >= MAX_OUTPUT_FILES) {

package/packages/dd-trace/src/ci-visibility/exporters/ci-visibility-exporter.js

@@ -6,6 +6,10 @@ const URL = require('url').URL
 
 const { version: tracerVersion } = require('../../../../../package.json')
 const { EMPTY_EFD_RETRY_POLICY, createEfdRetryPolicy } = require('../efd-retry-policy')
+const {
+  getDynamicAtrBuckets,
+  isDynamicAtrEnabled,
+} = require('../dynamic-atr-retries')
 const { getLibraryConfiguration: getLibraryConfigurationRequest } = require('../requests/get-library-configuration')
 const { getCachePath, withCache, writeToCache } = require('../requests/fs-cache')
 const { getSkippableSuites: getSkippableSuitesRequest } = require('../intelligent-test-runner/get-skippable-suites')
@@ -31,7 +35,7 @@ const {
   FINAL_FLUSH_FALLBACK_DELAY,
   FINAL_FLUSH_TIMEOUT,
 } = require('../final-flush')
-const { incrementCountMetric, TELEMETRY_ENDPOINT_PAYLOAD_DROPPED } = require('../telemetry')
+const { incrementCountMetric, recordDynamicAtrRetries, TELEMETRY_ENDPOINT_PAYLOAD_DROPPED } = require('../telemetry')
 const { sendGitMetadata: sendGitMetadataRequest } = require('./git/git_metadata')
 const buildSettingsCacheKey = require('./settings-cache-key')
 
@@ -108,7 +112,6 @@ function isValidRetryCount (value) {
  * Checks whether a cached EFD retry policy has the complete parsed shape.
  *
  * @param {unknown} retryPolicy - Candidate retry policy.
- * @returns {boolean}
  */
 function isValidCachedEfdRetryPolicy (retryPolicy) {
   if (retryPolicy === null || typeof retryPolicy !== 'object' || Array.isArray(retryPolicy)) return false
@@ -208,6 +211,11 @@ class CiVisibilityExporter extends BufferingExporter {
     this._coverageTimer = undefined
     this._logsTimer = undefined
     this._coverageBuffer = []
+    const dynamicAtrEnabled = config?.testOptimization?.DD_CIVISIBILITY_DYNAMIC_ATR_ENABLED
+    const dynamicAtrBuckets = config?.testOptimization?.DD_CIVISIBILITY_DYNAMIC_ATR_BUCKETS
+    this._dynamicAtrEnabled = isDynamicAtrEnabled(dynamicAtrEnabled)
+    this._dynamicAtrBuckets = this._dynamicAtrEnabled ? getDynamicAtrBuckets(dynamicAtrBuckets) ?? undefined : undefined
+    this._hasRecordedDynamicAtrTelemetry = false
     this._testOptimizationHttpCache = options.testOptimizationHttpCache || new TestOptimizationHttpCache()
     this._isTestOptimizationCacheOnly = options.cacheOnly === true
     const coverageReportFlags = parsers.ARRAY(config?.testOptimization?.DD_CODE_COVERAGE_FLAGS)
@@ -357,7 +365,6 @@ class CiVisibilityExporter extends BufferingExporter {
    *
    * @param {TestConfiguration} testConfiguration
    * @param {(error: Error | null, libraryConfig?: Readonly<Record<string, unknown>>) => void} callback
-   * @returns {void}
    */
   getLibraryConfiguration (testConfiguration, callback) {
     const { repositoryUrl } = testConfiguration
@@ -410,6 +417,7 @@ class CiVisibilityExporter extends BufferingExporter {
           // `_gitUploadPromise` itself. Do not call `_resolveGit()`.
           writeSettingsToCache(libraryConfig)
           this._libraryConfig = this.filterConfiguration(libraryConfig)
+          this._recordDynamicAtrTelemetry()
           return callback(null, this._libraryConfig)
         }
         // Filesystem cache hit: no git upload was started in this process.
@@ -444,11 +452,11 @@ class CiVisibilityExporter extends BufferingExporter {
    * @param {string} repositoryUrl - Repository URL for git metadata upload.
    * @param {boolean} isFilesystemCache - Whether settings came from the cross-process cache.
    * @param {Function} callback - Completion callback.
-   * @returns {void}
    */
   _applyCachedSettings (settings, configuration, repositoryUrl, isFilesystemCache, callback) {
     writeSettingsToCache(settings)
     this._libraryConfig = this.filterConfiguration(settings)
+    this._recordDynamicAtrTelemetry()
     const canUseCachedSkippableSuites = !this.shouldRequestSkippableSuites() ||
       this._testOptimizationHttpCache.hasValidSkippableSuites({
         testLevel: configuration.testLevel,
@@ -471,7 +479,6 @@ class CiVisibilityExporter extends BufferingExporter {
    * @param {string} repositoryUrl - Repository URL for git metadata upload.
    * @param {string|null} cacheKey - Filesystem cache key when this process owns the lock, null otherwise.
    * @param {Function} done - Completion callback.
-   * @returns {void}
    */
   _fetchLibraryConfigurationFromBackend (configuration, repositoryUrl, cacheKey, done) {
     this.sendGitMetadata(repositoryUrl)
@@ -532,6 +539,7 @@ class CiVisibilityExporter extends BufferingExporter {
       DD_TEST_MANAGEMENT_ATTEMPT_TO_FIX_RETRIES: configuredAttemptToFixRetries = 0,
       DD_TEST_MANAGEMENT_ENABLED: isTestManagementAllowed,
     } = testOptimization
+
     const earlyFlakeDetectionRetryPolicy = earlyFlakeDetectionRetryCount === undefined
       ? remoteConfiguration.earlyFlakeDetectionRetryPolicy ?? EMPTY_EFD_RETRY_POLICY
       : createEfdRetryPolicy({
@@ -543,6 +551,20 @@ class CiVisibilityExporter extends BufferingExporter {
     const testManagementAttemptToFixRetries =
       remoteConfiguration.testManagementAttemptToFixRetries ?? configuredAttemptToFixRetries
 
+    const isFlakyTestRetriesEnabled =
+      remoteConfiguration.isFlakyTestRetriesEnabled === true && isFlakyTestRetriesAllowed === true
+    // Dynamic ATR only replaces the flat ATR policy when backend ATR is enabled.
+    const isDynamicAtrEnabled = isFlakyTestRetriesEnabled && this._dynamicAtrEnabled
+    let dynamicAtrBuckets
+    if (isDynamicAtrEnabled) {
+      // Resolve the backend fallback before local EFD overrides can reach any runner.
+      const backendPolicy = remoteConfiguration.earlyFlakeDetectionRetryPolicy ?? EMPTY_EFD_RETRY_POLICY
+      dynamicAtrBuckets = this._dynamicAtrBuckets ?? Object.freeze([
+        ...backendPolicy.durationRetryCounts.map(({ retryCount }) => Math.max(1, retryCount)),
+        1,
+      ])
+    }
+
     return Object.freeze({
       isCodeCoverageEnabled: remoteConfiguration.isCodeCoverageEnabled === true,
       isSuitesSkippingEnabled: remoteConfiguration.isSuitesSkippingEnabled === true,
@@ -552,9 +574,10 @@ class CiVisibilityExporter extends BufferingExporter {
         remoteConfiguration.isEarlyFlakeDetectionEnabled === true && isEarlyFlakeDetectionAllowed === true,
       earlyFlakeDetectionRetryPolicy,
       earlyFlakeDetectionFaultyThreshold: remoteConfiguration.earlyFlakeDetectionFaultyThreshold ?? 30,
-      isFlakyTestRetriesEnabled:
-        remoteConfiguration.isFlakyTestRetriesEnabled === true && isFlakyTestRetriesAllowed === true,
+      isFlakyTestRetriesEnabled,
       flakyTestRetriesCount,
+      isDynamicAtrEnabled,
+      dynamicAtrBuckets,
       isDiEnabled: remoteConfiguration.isDiEnabled === true && isFailedTestReplayAllowed === true,
       isKnownTestsEnabled: remoteConfiguration.isKnownTestsEnabled === true,
       isTestManagementEnabled:
@@ -566,6 +589,13 @@ class CiVisibilityExporter extends BufferingExporter {
     })
   }
 
+  _recordDynamicAtrTelemetry () {
+    if (!this._hasRecordedDynamicAtrTelemetry && this._libraryConfig?.isDynamicAtrEnabled) {
+      this._hasRecordedDynamicAtrTelemetry = true
+      recordDynamicAtrRetries(this._dynamicAtrBuckets !== undefined)
+    }
+  }
+
   sendGitMetadata (repositoryUrl) {
     if (!this._config.testOptimization.DD_CIVISIBILITY_GIT_UPLOAD_ENABLED) {
       this._resolveGit()
@@ -607,7 +637,6 @@ class CiVisibilityExporter extends BufferingExporter {
    * Exports spans that are not retained for late updates to session, module, or suite events.
    *
    * @param {Array<object>} trace
-   * @returns {void}
    */
   #exportTrace (trace) {
     // Until it's initialized, we just store the traces as is
@@ -633,7 +662,6 @@ class CiVisibilityExporter extends BufferingExporter {
    * Retries session, module, and suite traces rejected by writer backpressure within the final deadline.
    *
    * @param {{ deadline?: number }} options final-flush options
-   * @returns {void}
    */
   #exportDeferredTestSessionTraces (options) {
     if (!this._writer || !this.canReportSessionTraces()) return
@@ -859,7 +887,6 @@ class CiVisibilityExporter extends BufferingExporter {
   /**
    * Allows later test activity to establish a new finalization boundary.
    *
-   * @returns {void}
    */
   #resetFinalFlush () {
     this.#finalFlush = undefined
@@ -933,7 +960,6 @@ class CiVisibilityExporter extends BufferingExporter {
   /**
    * Returns whether the exporter can upload test failure screenshots.
    *
-   * @returns {boolean}
    */
   canUploadTestScreenshots () {
     return Boolean(this._testScreenshotUploadUrl) && this._isTestFailureScreenshotsEnabled
@@ -942,7 +968,6 @@ class CiVisibilityExporter extends BufferingExporter {
   /**
    * Returns whether the exporter can upload test failure videos.
    *
-   * @returns {boolean}
    */
   canUploadTestVideos () {
     return Boolean(this._testScreenshotUploadUrl) && this._isTestFailureVideosEnabled
@@ -985,7 +1010,6 @@ class CiVisibilityExporter extends BufferingExporter {
    * @param {number} options.capturedAtMs - Capture time in epoch milliseconds
    * @param {AbortSignal} [options.signal] - Additional signal used to cancel the upload
    * @param {Function} callback - Callback function (err)
-   * @returns {void}
    */
   uploadTestVideo (options, callback) {
     if (!this._testScreenshotUploadUrl) {
@@ -1006,7 +1030,6 @@ class CiVisibilityExporter extends BufferingExporter {
    * @param {number} options.capturedAtMs - Capture time in epoch milliseconds
    * @param {AbortSignal} [options.signal] - Additional signal used to cancel the upload
    * @param {Function} callback - Callback function (err)
-   * @returns {void}
    */
   uploadTestSuiteVideo (options, callback) {
     if (!this._testScreenshotUploadUrl) {
@@ -1024,7 +1047,6 @@ class CiVisibilityExporter extends BufferingExporter {
    * @param {AbortSignal} [uploadOptions.signal] - Additional signal used to cancel the upload
    * @param {Function} callback - Callback function (err)
    * @param {number} [timeoutMs] - Maximum background upload duration
-   * @returns {void}
    */
   #uploadTestMedia (uploadRequest, uploadOptions, callback, timeoutMs = FINAL_FLUSH_TIMEOUT) {
     const { signal } = uploadOptions

package/packages/dd-trace/src/ci-visibility/exporters/git/git_metadata.js

@@ -70,7 +70,6 @@ function getCommonRequestOptions (url) {
  *
  * @param {GitUploadTarget & { latestCommits: string[] }} options
  * @param {(error: Error | null, commitsToUpload?: string[]) => void} callback
- * @returns {void}
  */
 function getCommitsToUpload ({ url, repositoryUrl, latestCommits, isEvpProxy, evpProxyPrefix }, callback) {
   const commonOptions = getCommonRequestOptions(url)
@@ -139,7 +138,6 @@ function getCommitsToUpload ({ url, repositoryUrl, latestCommits, isEvpProxy, ev
  *
  * @param {GitUploadTarget & { packFileToUpload: string, headCommit: string }} options
  * @param {(error: Error | null, uploadSize?: number) => void} callback
- * @returns {void}
  */
 function uploadPackFile ({ url, isEvpProxy, evpProxyPrefix, packFileToUpload, repositoryUrl, headCommit }, callback) {
   const form = new FormData()
@@ -263,7 +261,6 @@ function generateAndUploadPackFiles ({
  * @param {EvpProxyConfiguration} evpProxyConfiguration
  * @param {string | undefined} configRepositoryUrl repository URL from the configuration, if set
  * @param {(error?: Error | null) => void} callback
- * @returns {void}
  */
 function sendGitMetadata (url, { isEvpProxy, evpProxyPrefix }, configRepositoryUrl, callback) {
   if (!isGitAvailable()) {

package/packages/dd-trace/src/ci-visibility/exporters/request.js

@@ -35,7 +35,6 @@ const backpressureWaiters = new Set()
 /**
  * Keeps the shared polling timer alive only while an owned request is waiting.
  *
- * @returns {void}
  */
 function updateBackpressureTimerRef () {
   if (ownedBackpressureWaiters > 0) backpressureTimer.ref?.()
@@ -46,7 +45,6 @@ function updateBackpressureTimerRef () {
  * Schedules the next shared backpressure poll.
  *
  * @param {number} due
- * @returns {void}
  */
 function setBackpressureTimer (due) {
   clearTimeout(backpressureTimer)
@@ -61,7 +59,6 @@ function setBackpressureTimer (due) {
  * @param {BackpressureWaiter} waiter
  * @param {number} delay
  * @param {number} attemptIndex
- * @returns {void}
  */
 function scheduleBackpressureRetry (waiter, delay, attemptIndex) {
   waiter.attemptIndex = attemptIndex
@@ -81,7 +78,6 @@ function scheduleBackpressureRetry (waiter, delay, attemptIndex) {
  * Removes a settled request from the shared backpressure poll.
  *
  * @param {BackpressureWaiter} waiter
- * @returns {void}
  */
 function removeBackpressureWaiter (waiter) {
   if (!backpressureWaiters.delete(waiter)) return
@@ -99,7 +95,6 @@ function removeBackpressureWaiter (waiter) {
 /**
  * Retries every request whose shared backpressure delay has elapsed.
  *
- * @returns {void}
  */
 function runBackpressureWaiters () {
   const now = Date.now()
@@ -125,7 +120,6 @@ function runBackpressureWaiters () {
 
 /**
  * @param {Buffer|string|Array<Buffer|string>|(() => Readable)} data
- * @returns {number}
  */
 function getPayloadSize (data) {
   // Factory-backed payloads are streamed by their custom transport and enforce their own concurrency limit.
@@ -166,7 +160,6 @@ function createRequestTimeoutError () {
 
 /**
  * @param {number} statusCode
- * @returns {boolean}
  */
 function isRetriableHttpStatusCode (statusCode) {
   return statusCode === 408 || statusCode === 429 || (statusCode >= 500 && statusCode <= 599)
@@ -186,7 +179,6 @@ function getAbortError (signal) {
  * @param {Readable} data
  * @param {AbortSignal} [signal]
  * @param {(error: Error|null, data?: Buffer, payloadSize?: number) => void} callback
- * @returns {void}
  */
 function bufferReadable (data, signal, callback) {
   const chunks = []
@@ -256,7 +248,6 @@ function bufferReadable (data, signal, callback) {
  * @param {object} options
  * @param {(error: Error|null, result?: string|null, statusCode?: number,
  *   headers?: import('node:http').IncomingHttpHeaders) => void} callback
- * @returns {void}
  */
 function request (data, options, callback) {
   const { signal } = options
@@ -281,7 +272,6 @@ function request (data, options, callback) {
  * @param {(error: Error|null, result?: string|null, statusCode?: number,
  *   headers?: import('node:http').IncomingHttpHeaders) => void} callback
  * @param {number} [reservedPayloadSize]
- * @returns {void}
  */
 function requestBuffered (data, options, callback, reservedPayloadSize) {
   const { signal } = options
@@ -344,7 +334,6 @@ function requestBuffered (data, options, callback, reservedPayloadSize) {
 
   /**
    * @param {number} attemptIndex
-   * @returns {void}
    */
   function attempt (attemptIndex) {
     if (settled) return

package/packages/dd-trace/src/ci-visibility/exporters/settings-cache-key.js

@@ -10,7 +10,6 @@ const getConfig = require('../../config')
  * applied while parsing the response.
  *
  * @param {object} configuration - Request configuration for the settings endpoint.
- * @returns {string}
  */
 function buildSettingsCacheKey (configuration) {
   const config = getConfig()

package/packages/dd-trace/src/ci-visibility/intelligent-test-runner/get-skippable-suites.js

@@ -86,7 +86,6 @@ function parseSkippableSuitesResponse (
  * }} result - Parsed skippable response.
  * @param {'suite'|'test'} testLevel - Test optimization skipping level.
  * @param {boolean} shouldConsiderLineCoverage - Whether line coverage can affect suite skipping.
- * @returns {void}
  */
 function logSkippableSuitesResponse (result, testLevel, shouldConsiderLineCoverage) {
   if (!shouldConsiderLineCoverage || result.numReceivedSkippableItems === undefined) {

package/packages/dd-trace/src/ci-visibility/requests/fs-cache.js

@@ -16,7 +16,6 @@ const CACHE_LOCK_HEARTBEAT_MS = 30_000 // 30 seconds
 /**
  * Returns whether the filesystem cache is enabled via config.
  *
- * @returns {boolean}
  */
 function isCacheEnabled () {
   return getConfig().DD_EXPERIMENTAL_TEST_REQUESTS_FS_CACHE
@@ -27,7 +26,6 @@ function isCacheEnabled () {
  *
  * @param {string} prefix - Cache file prefix (e.g. 'known-tests', 'skippable', 'test-mgmt')
  * @param {Array<unknown>} parts - Values that uniquely identify the cached response
- * @returns {string}
  */
 function buildCacheKey (prefix, parts) {
   const hash = createHash('sha256').update(JSON.stringify(parts)).digest('hex').slice(0, 16)
@@ -36,7 +34,6 @@ function buildCacheKey (prefix, parts) {
 
 /**
  * @param {string} cacheKey
- * @returns {string}
  */
 function getCachePath (cacheKey) {
   return path.join(tmpdir(), `dd-${cacheKey}.json`)
@@ -44,7 +41,6 @@ function getCachePath (cacheKey) {
 
 /**
  * @param {string} cacheKey
- * @returns {string}
  */
 function getLockPath (cacheKey) {
   return path.join(tmpdir(), `dd-${cacheKey}.lock`)
@@ -138,7 +134,6 @@ function tryAcquireLock (cacheKey) {
  * Removes the lock file.
  *
  * @param {string} cacheKey
- * @returns {boolean}
  */
 function releaseLock (cacheKey) {
   try {
@@ -185,7 +180,6 @@ function startLockHeartbeat (cacheKey) {
  * Checks whether the lock file is stale (older than the lock timeout).
  *
  * @param {string} cacheKey
- * @returns {boolean}
  */
 function isLockStale (cacheKey) {
   try {

package/packages/dd-trace/src/ci-visibility/requests/get-library-configuration.js

@@ -88,7 +88,7 @@ function parseSlowTestRetries (value) {
  * @returns {EarlyFlakeDetectionSettings}
  */
 function parseEarlyFlakeDetectionSettings (value, isKnownTestsEnabled) {
-  if (!isRecord(value) || value.enabled !== true) {
+  if (!isRecord(value)) {
     return {
       enabled: false,
       retryPolicy: DEFAULT_EARLY_FLAKE_DETECTION_RETRY_POLICY,
@@ -117,7 +117,7 @@ function parseEarlyFlakeDetectionSettings (value, isKnownTestsEnabled) {
   }
 
   return {
-    enabled: isKnownTestsEnabled && isValid,
+    enabled: value.enabled === true && isKnownTestsEnabled && isValid,
     retryPolicy,
     faultyThreshold,
   }

package/packages/dd-trace/src/ci-visibility/requests/rate-limit.js

@@ -6,7 +6,6 @@ const EPOCH_SECONDS_THRESHOLD = 1_000_000_000
  * Returns the delay requested by a Test Optimization intake rate-limit response.
  *
  * @param {import('node:http').IncomingHttpHeaders} [headers]
- * @returns {number}
  */
 function getRateLimitResetDelay (headers) {
   let retryAfter = headers?.['retry-after']