dd-trace 6.15.0 → 6.17.0

package/packages/datadog-instrumentations/src/playwright.js

@@ -14,6 +14,7 @@ const {
   hasEfdRetries,
   shouldSkipEfdRetry,
 } = require('../../dd-trace/src/ci-visibility/efd-retry-policy')
+const { getDynamicAtrRetryCount } = require('../../dd-trace/src/ci-visibility/dynamic-atr-retries')
 const {
   parseAnnotations,
   getTestSuitePath,
@@ -65,6 +66,7 @@ const testPageGotoCh = channel('ci:playwright:test:page-goto')
 
 const dispatcherRunCh = tracingChannel('orchestrion:playwright:Dispatcher_run')
 const dispatcherCreateWorkerCh = tracingChannel('orchestrion:playwright:Dispatcher_createWorker')
+const filterForShardCh = tracingChannel('orchestrion:playwright:filterForShard')
 const processHostStartRunnerCh = tracingChannel('orchestrion:playwright:ProcessHost_startRunner')
 const createRootSuiteCh = tracingChannel('orchestrion:playwright:createRootSuite')
 const artifactsRecorderScreenshotPathCh =
@@ -112,6 +114,8 @@ let isEarlyFlakeDetectionFaulty = false
 let earlyFlakeDetectionFaultyThreshold = 0
 let isFlakyTestRetriesEnabled = false
 let flakyTestRetriesCount = 0
+let isDynamicAtrEnabled = false
+let dynamicAtrBuckets
 let knownTests = {}
 let isTestManagementTestsEnabled = false
 let testManagementAttemptToFixRetries = 0
@@ -121,6 +125,9 @@ let modifiedFiles = {}
 let playwrightRunSummary
 let recordedTestOptimizationExecutions = new Set()
 let testsReportedInGenerateSummary = new Set()
+let reportedTestExecutions = new WeakMap()
+let hasTestsAssignedToShard = false
+let hasTestsBeforeSharding = false
 const newTestsWithDynamicNames = new Set()
 const attemptToFixExecutions = new Map()
 const loggedAttemptToFixTests = new Set()
@@ -131,6 +138,8 @@ const efdRetryTestsById = new Map()
 const efdScheduledOriginalTestKeys = new Set()
 const efdStartedOriginalTestKeys = new Set()
 const efdSlowAbortedTests = new Set()
+const dynamicAtrRetryCountByTestKey = new Map()
+const automaticRetryProjects = new Set()
 const ddPropertiesByTestId = new Map()
 const ddPropertiesRequestsByTestId = new Map()
 const disabledTestIds = new Set()
@@ -159,7 +168,6 @@ const automaticFailureVideoPaths = new Set()
  * Returns whether Playwright's internal screenshot recorder created an attachment.
  *
  * @param {object} attachment - Playwright attachment payload
- * @returns {boolean}
  */
 function isAutomaticFailureScreenshotAttachment (attachment) {
   return typeof attachment?.path === 'string' && automaticFailureScreenshotPaths.delete(attachment.path)
@@ -169,7 +177,6 @@ function isAutomaticFailureScreenshotAttachment (attachment) {
  * Returns whether Playwright's internal video recorder created an attachment.
  *
  * @param {object} attachment - Playwright attachment payload
- * @returns {boolean}
  */
 function isAutomaticFailureVideoAttachment (attachment) {
   return typeof attachment?.path === 'string' && automaticFailureVideoPaths.delete(attachment.path)
@@ -230,7 +237,6 @@ function getTestRepeatEachKey (test) {
 
 /**
  * @param {object} test
- * @returns {string}
  */
 function getTestEfdKey (test) {
   const projectKey = getTestProjectKey(test)
@@ -263,9 +269,6 @@ function registerEfdRetryTest (test) {
   })
 }
 
-/**
- * @returns {boolean}
- */
 function shouldRunEarlyFlakeDetection () {
   return isEarlyFlakeDetectionEnabled && hasEfdRetries(earlyFlakeDetectionRetryPolicy)
 }
@@ -389,7 +392,6 @@ function sendDdPropertiesToWorkerWhenAvailable (workerProcess, testId) {
 
 /**
  * @param {object} test
- * @returns {boolean}
  */
 function shouldRequestEfdRetryCount (test) {
   // The main process remains the source of truth. repeatEachIndex is only used as
@@ -519,6 +521,8 @@ function getTestsBySuiteFromTestsById (testsById) {
 }
 
 function getPlaywrightConfig (playwrightRunner) {
+  if (!playwrightRunner) return {}
+
   try {
     return playwrightRunner._configLoader.fullConfig()
   } catch {
@@ -558,7 +562,6 @@ function getProjectsFromRunner (runner, configArg) {
  * Returns whether at least one Playwright project captures automatic screenshots for failed tests.
  *
  * @param {Array<object>} projects - Playwright projects with resolved use options
- * @returns {boolean} Whether failure screenshot capture is enabled
  */
 function isFailureScreenshotCaptureEnabled (projects) {
   for (const project of projects) {
@@ -575,7 +578,6 @@ function isFailureScreenshotCaptureEnabled (projects) {
  * Returns whether at least one Playwright project records videos that can be retained for failures.
  *
  * @param {Array<object>} projects - Playwright projects with resolved use options
- * @returns {boolean} Whether video capture is enabled
  */
 function isFailureVideoCaptureEnabled (projects) {
   for (const project of projects) {
@@ -599,14 +601,19 @@ function getProjectsFromDispatcher (dispatcher) {
   return dispatcher._loader?.fullConfig()?.projects
 }
 
-function getBrowserNameFromProjects (projects, test) {
+/**
+ * Resolves the configured project by Playwright's unique ID or legacy index.
+ * @param {object[]} projects
+ * @param {object} test
+ */
+function getTestProject (projects, test) {
   if (!projects || !test) {
     return null
   }
   const { _projectIndex, _projectId: testProjectId } = test
 
   if (_projectIndex !== undefined) {
-    return projects[_projectIndex]?.name
+    return projects[_projectIndex]
   }
 
   return projects.find(({ __projectId, _id, name }) => {
@@ -617,7 +624,12 @@ function getBrowserNameFromProjects (projects, test) {
       return _id === testProjectId
     }
     return name === testProjectId
-  })?.name
+  })
+}
+
+function getBrowserNameFromProjects (projects, test) {
+  const project = getTestProject(projects, test)
+  return project && project.name
 }
 
 function formatTestHookError (error, hookType, isTimeout) {
@@ -671,8 +683,8 @@ function getTestByTestId (dispatcher, testId) {
 // Inspired by https://github.com/microsoft/playwright/blob/2b77ed4d7aafa85a600caa0b0d101b72c8437eeb/packages/playwright/src/reporters/base.ts#L293
 // We can't use test.outcome() directly because it's set on follow up handlers:
 // our `testEndHandler` is called before the outcome is set.
-function testWillRetry (test, testStatus) {
-  return testStatus === 'fail' && test.results.length <= test.retries
+function testWillRetry (test, status, expectedStatus = test.expectedStatus) {
+  return status !== 'skipped' && status !== expectedStatus && test.results.length <= test.retries
 }
 
 function getFinalStatus ({
@@ -682,7 +694,6 @@ function getFinalStatus ({
   isAtrRetry,
   isEfdManagedTest,
   isAttemptToFix,
-  hasFailedAllRetries,
   hasFailedAttemptToFixRetries,
   hasPassedAnyEfdAttempt,
   testStatus,
@@ -694,7 +705,7 @@ function getFinalStatus ({
     return 'skip'
   }
   if (isAtrRetry) {
-    return hasFailedAllRetries ? 'fail' : 'pass'
+    return testStatus
   }
   if (isEfdManagedTest) {
     return hasPassedAnyEfdAttempt ? 'pass' : 'fail'
@@ -705,6 +716,17 @@ function getFinalStatus ({
   return testStatus
 }
 
+/**
+ * Reports whether another test in the serial group can trigger this test to run again.
+ * @param {object} test
+ */
+function isSerialTest (test) {
+  for (let suite = test.parent; suite; suite = suite.parent) {
+    if (suite._parallelMode === 'serial') return true
+  }
+  return false
+}
+
 function getTestFullname (test) {
   let parent = test.parent
   const names = [test.title]
@@ -789,7 +811,6 @@ function testBeginHandler (test, browserName, shouldCreateTestSpan) {
  *
  * @param {object} test
  * @param {string} testSuiteAbsolutePath
- * @returns {void}
  */
 function recordSkippedTestOptimizationExecution (test, testSuiteAbsolutePath) {
   if (recordedTestOptimizationExecutions.has(test) ||
@@ -852,6 +873,37 @@ function finishTestSuiteIfDone (testSuiteAbsolutePath, projects) {
   }
 }
 
+/**
+ * Checks whether a test inherits the retry limit assigned by Test Optimization.
+ * @param {object} test
+ * @param {object[]} projects
+ */
+function hasAutomaticRetries (test, projects) {
+  if (!automaticRetryProjects.has(getTestProject(projects, test))) return false
+  for (let suite = test.parent; suite; suite = suite.parent) {
+    if (suite._retries !== undefined) return false
+  }
+  return true
+}
+
+/**
+ * Records a completed test in its suite and removes it from pending executions.
+ * @param {object} test
+ * @param {string} testStatus
+ * @param {object} [error]
+ */
+function recordFinalTestStatus (test, testStatus, error) {
+  const testSuiteAbsolutePath = test._requireFile
+  if (testSuiteToTestStatuses.has(testSuiteAbsolutePath)) {
+    testSuiteToTestStatuses.get(testSuiteAbsolutePath).push(testStatus)
+  } else {
+    testSuiteToTestStatuses.set(testSuiteAbsolutePath, [testStatus])
+  }
+  if (error) addErrorToTestSuite(testSuiteAbsolutePath, error)
+  remainingTestsByFile[testSuiteAbsolutePath] = remainingTestsByFile[testSuiteAbsolutePath]
+    .filter(currentTest => currentTest !== test)
+}
+
 function testEndHandler ({
   test,
   annotations,
@@ -860,6 +912,9 @@ function testEndHandler ({
   isTimeout,
   shouldCreateTestSpan,
   projects,
+  testDuration,
+  testResultStatus,
+  expectedStatus = test.expectedStatus,
 }) {
   const {
     _requireFile: testSuiteAbsolutePath,
@@ -892,19 +947,23 @@ function testEndHandler ({
 
   const isEfdManagedTest = isTestEfdManaged(test)
   const testFqn = getTestFullyQualifiedName(test)
-  const testStatusKey = isEfdManagedTest ? getTestEfdKey(test) : testFqn
+  // Dynamic ATR budgets and retry status must be isolated per Playwright project.
+  const testStatusKey = (isEfdManagedTest || isDynamicAtrEnabled) ? getTestEfdKey(test) : testFqn
   const testStatuses = testsToTestStatuses.get(testStatusKey) || []
 
   if (testStatuses.length === 0) {
-    testsToTestStatuses.set(testStatusKey, [testStatus])
+    testsToTestStatuses.set(testStatusKey, testStatuses)
     if (test._ddIsNew && DYNAMIC_NAME_RE.test(getTestFullname(test))) {
       newTestsWithDynamicNames.add(`${getTestSuitePath(test._requireFile, rootDir)} › ${getTestFullname(test)}`)
     }
-  } else {
-    testStatuses.push(testStatus)
+  }
+  testStatuses.push(testStatus)
+  if (testStatus === 'pass' || testStatus === 'fail') {
+    reportedTestExecutions.set(test, { status: testStatus, error })
   }
 
   const testEfdKey = getTestEfdKey(test)
+  const dynamicAtrTestKey = testEfdKey
   if (isEfdManagedTest && !test._ddIsEfdRetry && !efdRetryCountByTestKey.has(testEfdKey)) {
     const testResult = results.at(-1)
     const duration = testResult?.duration > 0 ? testResult.duration : performance.now() - test._ddStartTime
@@ -916,6 +975,23 @@ function testEndHandler ({
   }
 
   const testProperties = getTestProperties(test)
+  if (
+    isDynamicAtrEnabled &&
+    isFlakyTestRetriesEnabled &&
+    !testProperties.attemptToFix &&
+    !test._ddIsEfdRetry &&
+    !isEfdManagedTest &&
+    hasAutomaticRetries(test, projects) &&
+    !dynamicAtrRetryCountByTestKey.has(dynamicAtrTestKey)
+  ) {
+    const testResult = results.at(-1)
+    const duration = testDuration ??
+      (testResult?.duration > 0 ? testResult.duration : performance.now() - test._ddStartTime)
+    const retryCount = getDynamicAtrRetryCount(duration, earlyFlakeDetectionRetryPolicy, dynamicAtrBuckets)
+    dynamicAtrRetryCountByTestKey.set(dynamicAtrTestKey, retryCount)
+    // Serial groups may skip this test before its first actual execution.
+    test.retries = (testResult?.retry ?? 0) + retryCount
+  }
   const hasRecordedTestOptimizationExecution = recordedTestOptimizationExecutions.has(test)
 
   if (!hasRecordedTestOptimizationExecution) {
@@ -968,34 +1044,40 @@ function testEndHandler ({
     test._ddHasFailedAllRetries = true
   }
 
-  // ATR: set _ddHasFailedAllRetries when all auto test retries were exhausted and every attempt failed
+  const willRetry = testWillRetry(test, testResultStatus, expectedStatus)
+
+  // ATR: use the effective native limit for tests with explicit Playwright retries.
+  const atrRetryCount = isDynamicAtrEnabled
+    ? dynamicAtrRetryCountByTestKey.get(dynamicAtrTestKey) ?? test.retries
+    : flakyTestRetriesCount
   if (isFlakyTestRetriesEnabled && !testProperties.attemptToFix && !test._ddIsEfdRetry &&
     !(test._ddIsNew || test._ddIsModified) &&
-    flakyTestRetriesCount != null && flakyTestRetriesCount > 0 &&
-    testStatuses.length === flakyTestRetriesCount + 1 &&
+    atrRetryCount != null && atrRetryCount > 0 &&
+    !willRetry && testResultStatus !== expectedStatus &&
     testStatuses.every(status => status === 'fail')) {
     test._ddHasFailedAllRetries = true
   }
 
-  const willRetry = testWillRetry(test, testStatus)
-
-  // this handles tests that do not go through the worker process (because they're skipped)
+  // Legacy Playwright also creates executed test spans in the main process.
   if (shouldCreateTestSpan) {
     const testResult = results.at(-1)
     const testCtx = testToCtx.get(test)
+    const retryTestId = testStatus !== 'skip' && !isEfdManagedTest &&
+      !test._ddIsAttemptToFix && test.retries > 0
+      ? test.id ?? test._id
+      : undefined
     const isAtrRetry = testResult?.retry > 0 &&
       isFlakyTestRetriesEnabled &&
       !test._ddIsAttemptToFix &&
       !test._ddIsEfdRetry
 
     const finalStatus = getFinalStatus({
-      isFinalExecution: !willRetry,
+      isFinalExecution: retryTestId !== undefined || !willRetry,
       isDisabled: test._ddIsDisabled,
       isQuarantined: test._ddIsQuarantined,
       isAtrRetry,
       isEfdManagedTest,
       isAttemptToFix: test._ddIsAttemptToFix,
-      hasFailedAllRetries: test._ddHasFailedAllRetries,
       hasFailedAttemptToFixRetries: test._ddHasFailedAttemptToFixRetries,
       hasPassedAnyEfdAttempt: testStatuses.includes('pass'),
       testStatus,
@@ -1021,28 +1103,15 @@ function testEndHandler ({
         isAtrRetry,
         isModified: test._ddIsModified,
         finalStatus,
+        retryTestId,
+        deferFinalStatus: willRetry,
         earlyFlakeAbortReason: efdSlowAbortedTests.has(testEfdKey) ? 'slow' : undefined,
         ...testCtx.currentStore,
       })
     }
   }
 
-  if (!willRetry) {
-    if (testSuiteToTestStatuses.has(testSuiteAbsolutePath)) {
-      testSuiteToTestStatuses.get(testSuiteAbsolutePath).push(testStatus)
-    } else {
-      testSuiteToTestStatuses.set(testSuiteAbsolutePath, [testStatus])
-    }
-
-    if (error) {
-      addErrorToTestSuite(testSuiteAbsolutePath, error)
-    }
-  }
-
-  if (!willRetry) {
-    remainingTestsByFile[testSuiteAbsolutePath] = remainingTestsByFile[testSuiteAbsolutePath]
-      .filter(currentTest => currentTest !== test)
-  }
+  if (!willRetry) recordFinalTestStatus(test, testStatus, error)
 
   finishTestSuiteIfDone(testSuiteAbsolutePath, projects)
 }
@@ -1050,10 +1119,35 @@ function testEndHandler ({
 function dispatcherRunWrapper (run) {
   return function (...args) {
     remainingTestsByFile = getTestsBySuiteFromTestsById(this._testById)
+    for (const tests of Object.values(remainingTestsByFile)) {
+      if (tests.length > 0) {
+        hasTestsAssignedToShard = true
+        break
+      }
+    }
     return run.apply(this, args)
   }
 }
 
+function recordTestsBeforeSharding (testGroups) {
+  hasTestsBeforeSharding = testGroups.some(group => group.tests.length > 0)
+}
+
+function testGroupsHook (testGroupsPackage) {
+  const filterForShard = testGroupsPackage.filterForShard
+  const wrappedFilterForShard = function (...args) {
+    recordTestsBeforeSharding(args.at(-1))
+    return filterForShard.apply(this, args)
+  }
+
+  return new Proxy(testGroupsPackage, {
+    get (target, prop, receiver) {
+      if (prop === 'filterForShard') return wrappedFilterForShard
+      return Reflect.get(target, prop, receiver)
+    },
+  })
+}
+
 function deferEfdRetryGroups (testGroups) {
   const groupsWithOriginalTests = []
   const efdRetryOnlyGroups = []
@@ -1090,6 +1184,13 @@ function deferEfdRetryGroups (testGroups) {
 function prepareDispatcherRun (dispatcher, args) {
   let testGroups = args[0]
 
+  for (const group of testGroups) {
+    if (group.tests.length > 0) {
+      hasTestsAssignedToShard = true
+      break
+    }
+  }
+
   // Filter out disabled tests from testGroups before they get scheduled,
   // unless they have attemptToFix (in which case they should still run and be retried)
   if (isTestManagementTestsEnabled) {
@@ -1177,7 +1278,7 @@ function onDispatcherCreateWorker (dispatcher, worker) {
       videos.push(attachment)
     }
   })
-  worker.on('testEnd', ({ testId, status, errors, annotations }) => {
+  worker.on('testEnd', ({ testId, status, errors, annotations, duration, expectedStatus }) => {
     const test = getTestByTestId(dispatcher, testId)
     if (!test) return
 
@@ -1196,6 +1297,9 @@ function onDispatcherCreateWorker (dispatcher, worker) {
         isTimeout,
         shouldCreateTestSpan,
         projects,
+        testDuration: duration,
+        testResultStatus: status,
+        expectedStatus,
       }
     )
     const testResult = test.results.at(-1)
@@ -1241,10 +1345,16 @@ function onDispatcherCreateWorker (dispatcher, worker) {
     } else if (test._ddIsAttemptToFix) {
       isFinalExecution = !!(test._ddHasPassedAttemptToFixRetries || test._ddHasFailedAttemptToFixRetries)
     } else {
-      isFinalExecution = !testWillRetry(test, testStatus)
+      isFinalExecution = !testWillRetry(test, status, expectedStatus)
     }
 
+    const retryTestId = !isEfdManagedTest && !test._ddIsAttemptToFix && test.retries > 0 ? test.id : undefined
+    const deferFinalStatus = retryTestId !== undefined &&
+      (!isFinalExecution || (isSerialTest(test) && test.results.length <= test.retries))
+
     const ddProperties = {
+      _ddRetryTestId: retryTestId,
+      _ddDeferFinalStatus: deferFinalStatus,
       _ddIsDisabled: test._ddIsDisabled,
       _ddIsQuarantined: test._ddIsQuarantined,
       _ddIsAttemptToFix: test._ddIsAttemptToFix,
@@ -1295,6 +1405,7 @@ function dispatcherHook (dispatcherExport) {
             test,
             annotations: params.annotations,
             testStatus: STATUS_TO_TEST_STATUS[testResult.status],
+            testResultStatus: testResult.status,
             error: testResult.error,
             isTimeout,
             shouldCreateTestSpan: true,
@@ -1321,9 +1432,32 @@ function dispatcherHookNew (dispatcherExport, runWrapper) {
 function runAllTestsWrapper (runAllTests, playwrightVersion) {
   // Config parameter is only available from >=1.55.0
   return async function (config) {
+    // A later run must not inherit ATR settings when configuration fails or the plugin is disabled.
+    isFlakyTestRetriesEnabled = false
+    flakyTestRetriesCount = 0
+    isDynamicAtrEnabled = false
+    dynamicAtrBuckets = undefined
+    if (!libraryConfigurationCh.hasSubscribers) {
+      // Instrumentation hooks still run when the plugin is disabled between runs.
+      isKnownTestsEnabled = false
+      isEarlyFlakeDetectionEnabled = false
+      isTestManagementTestsEnabled = false
+      isImpactedTestsEnabled = false
+      knownTests = {}
+      testManagementTests = {}
+      modifiedFiles = {}
+      return runAllTests.apply(this, arguments)
+    }
+
+    testsToTestStatuses.clear()
+    reportedTestExecutions = new WeakMap()
+    dynamicAtrRetryCountByTestKey.clear()
+    automaticRetryProjects.clear()
     reporterError = undefined
     hasReporterError = false
     playwrightRunSummary = undefined
+    hasTestsAssignedToShard = false
+    hasTestsBeforeSharding = false
     let restoreReporterConsoleError
     if (satisfies(playwrightVersion, '>=1.60.0') && config?.config) {
       const DatadogPlaywrightReporter = require('./playwright-reporter')
@@ -1333,6 +1467,8 @@ function runAllTestsWrapper (runAllTests, playwrightVersion) {
         config.config.reporter.unshift([require.resolve('./playwright-reporter')])
       }
     }
+    const runnerConfig = getPlaywrightConfig(this)
+    const playwrightConfig = config?.config || runnerConfig.config || runnerConfig
     rootDir = getRootDir(this, config)
     const projects = getProjectsFromRunner(this, config)
     const isFailureScreenshotEnabled = isFailureScreenshotCaptureEnabled(projects)
@@ -1361,6 +1497,8 @@ function runAllTestsWrapper (runAllTests, playwrightVersion) {
         earlyFlakeDetectionFaultyThreshold = libraryConfig.earlyFlakeDetectionFaultyThreshold
         isFlakyTestRetriesEnabled = libraryConfig.isFlakyTestRetriesEnabled
         flakyTestRetriesCount = libraryConfig.flakyTestRetriesCount
+        isDynamicAtrEnabled = libraryConfig.isDynamicAtrEnabled
+        dynamicAtrBuckets = libraryConfig.dynamicAtrBuckets
         isTestManagementTestsEnabled = libraryConfig.isTestManagementEnabled
         testManagementAttemptToFixRetries = libraryConfig.testManagementAttemptToFixRetries
         isImpactedTestsEnabled = libraryConfig.isImpactedTestsEnabled
@@ -1447,11 +1585,23 @@ function runAllTestsWrapper (runAllTests, playwrightVersion) {
     // ATR and `--retries` are now compatible with Test Management.
     // Test Management tests have their retries set to 0 at the test level,
     // preventing them from being retried by ATR or `--retries`.
-    const shouldSetATRRetries = isFlakyTestRetriesEnabled && flakyTestRetriesCount > 0
+    const shouldSetATRRetries = isFlakyTestRetriesEnabled &&
+      (isDynamicAtrEnabled || flakyTestRetriesCount > 0)
+    const projectsWithAutomaticRetries = []
     if (shouldSetATRRetries) {
+      // Dynamic ATR starts at the maximum budget, then narrows each test after
+      // its initial duration is known.
+      const maximumDynamicAtrRetries = dynamicAtrBuckets
+        ? Math.max(...dynamicAtrBuckets)
+        : earlyFlakeDetectionRetryPolicy.schedulingRetryCount
+      const atrRetries = isDynamicAtrEnabled
+        ? Math.max(1, maximumDynamicAtrRetries)
+        : flakyTestRetriesCount
       for (const project of projects) {
         if (project.retries === 0) { // Only if it hasn't been set by the user
-          project.retries = flakyTestRetriesCount
+          projectsWithAutomaticRetries.push(project)
+          automaticRetryProjects.add(project)
+          project.retries = atrRetries
         }
       }
     }
@@ -1475,6 +1625,9 @@ function runAllTestsWrapper (runAllTests, playwrightVersion) {
       hasReporterError = false
       throw error
     } finally {
+      for (const project of projectsWithAutomaticRetries) {
+        project.retries = 0
+      }
       restoreReporterConsoleError?.()
     }
 
@@ -1486,6 +1639,14 @@ function runAllTestsWrapper (runAllTests, playwrightVersion) {
       // there were tests that did not go through `testBegin` or `testEnd`,
       // because they were skipped
       for (const test of tests) {
+        const lastExecution = reportedTestExecutions.get(test)
+        if (lastExecution) {
+          // Preserve a reported execution whose retry was canceled. Playwright can
+          // also synthesize failed results after hook errors without emitting testEnd.
+          recordFinalTestStatus(test, lastExecution.status, lastExecution.error)
+          finishTestSuiteIfDone(test._requireFile, projects)
+          continue
+        }
         const alreadyReported = testsReportedInGenerateSummary.has(test)
         const browser = getBrowserNameFromProjects(projects, test)
         testBeginHandler(test, browser, !alreadyReported)
@@ -1493,6 +1654,7 @@ function runAllTestsWrapper (runAllTests, playwrightVersion) {
           test,
           annotations: [],
           testStatus: 'skip',
+          testResultStatus: 'skipped',
           error: null,
           isTimeout: false,
           shouldCreateTestSpan: !alreadyReported,
@@ -1520,8 +1682,14 @@ function runAllTestsWrapper (runAllTests, playwrightVersion) {
     const finalStatus = hasReporterError
       ? 'fail'
       : (preventedToFail ? 'pass' : STATUS_TO_TEST_STATUS[sessionStatus])
+    const isExpectedEmptyShard = finalStatus === 'pass' &&
+      Boolean(playwrightConfig.shard) &&
+      hasTestsBeforeSharding &&
+      !hasTestsAssignedToShard &&
+      testsReportedInGenerateSummary.size === 0
     await getChannelPromise(testSessionFinishCh, {
-      status: finalStatus,
+      status: isExpectedEmptyShard ? 'skip' : finalStatus,
+      isExpectedEmptyShard,
       error: finalizationError,
       isEarlyFlakeDetectionEnabled,
       isEarlyFlakeDetectionFaulty,
@@ -1537,6 +1705,8 @@ function runAllTestsWrapper (runAllTests, playwrightVersion) {
     playwrightRunSummary = undefined
     recordedTestOptimizationExecutions = new Set()
     testsReportedInGenerateSummary = new Set()
+    hasTestsAssignedToShard = false
+    hasTestsBeforeSharding = false
     efdManagedTestKeys.clear()
     efdRetryCountByTestKey.clear()
     efdRetryCountRequestsByTestKey.clear()
@@ -1693,6 +1863,12 @@ dispatcherCreateWorkerCh.subscribe({
   },
 })
 
+filterForShardCh.subscribe({
+  start (ctx) {
+    recordTestsBeforeSharding(ctx.arguments.at(-1))
+  },
+})
+
 processHostStartRunnerCh.subscribe({
   start (ctx) {
     prepareProcessHostStartRunner(ctx.self)
@@ -1734,7 +1910,6 @@ reporterRunSummaryCh.subscribe((runSummary) => {
  * Records a reporter failure even when the reporter throws a falsy value.
  *
  * @param {unknown} error
- * @returns {void}
  */
 function recordReporterError (error) {
   if (hasReporterError) return
@@ -1756,7 +1931,6 @@ function recordReporterError (error) {
  * Records a path created by Playwright's automatic screenshot recorder.
  *
  * @param {object} ctx - Orchestrion context
- * @returns {void}
  */
 function recordAutomaticFailureScreenshotPath (ctx) {
   if (isFailureScreenshotUploadEnabled &&
@@ -1770,7 +1944,6 @@ function recordAutomaticFailureScreenshotPath (ctx) {
  * Records only the destination used by Playwright's automatic video recorder.
  *
  * @param {object} ctx - Orchestrion context
- * @returns {void}
  */
 function recordAutomaticFailureVideoPath (ctx) {
   const video = ctx.arguments?.[0]
@@ -1868,6 +2041,12 @@ addHook({
   versions: ['>=1.38.0 <1.60.0'],
 }, (dispatcher) => dispatcherHookNew(dispatcher, dispatcherRunWrapperNew))
 
+addHook({
+  name: 'playwright',
+  file: 'lib/runner/testGroups.js',
+  versions: ['>=1.38.0 <1.60.0'],
+}, testGroupsHook)
+
 addHook({
   name: 'playwright',
   file: 'lib/common/suiteUtils.js',
@@ -2460,14 +2639,16 @@ function instrumentWorkerMainMethods (workerMain) {
     })
     await Promise.race([ddPropertiesPromise, ddPropertiesTimeoutPromise])
 
+    const retryTestId = test._ddRetryTestId
     const finalStatus = getFinalStatus({
-      isFinalExecution: test._ddIsFinalExecution,
+      // Retain a candidate final status while a native retry is possible. The main
+      // process removes it when another execution arrives, or keeps it if retries stop.
+      isFinalExecution: retryTestId !== undefined || test._ddIsFinalExecution,
       isDisabled: test._ddIsDisabled,
       isQuarantined: test._ddIsQuarantined,
       isAtrRetry: test._ddIsAtrRetry,
       isEfdManagedTest: test._ddIsEfdManagedTest,
       isAttemptToFix: test._ddIsAttemptToFix,
-      hasFailedAllRetries: test._ddHasFailedAllRetries,
       hasFailedAttemptToFixRetries: test._ddHasFailedAttemptToFixRetries,
       hasPassedAnyEfdAttempt: test._ddHasPassedAnyEfdAttempt,
       testStatus: STATUS_TO_TEST_STATUS[status],
@@ -2475,6 +2656,8 @@ function instrumentWorkerMainMethods (workerMain) {
 
     await getChannelPromise(testFinishCh, {
       testStatus: STATUS_TO_TEST_STATUS[status],
+      retryTestId,
+      deferFinalStatus: test._ddDeferFinalStatus,
       steps: steps.filter(step => step.testId === testId),
       error,
       extraTags: annotationTags,

package/packages/datadog-instrumentations/src/postgres.js

@@ -0,0 +1,7 @@
+'use strict'
+
+const { addHook, getHooks } = require('./helpers/instrument')
+
+for (const hook of getHooks('postgres').values()) {
+  addHook(hook, exports => exports)
+}