dart-decimate 0.0.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/Cargo.lock +572 -0
- package/Cargo.toml +41 -0
- package/LICENSE +21 -0
- package/README.md +617 -0
- package/assets/dart-decimate-banner.png +0 -0
- package/npm/bin/dart-decimate-mcp.js +48 -0
- package/npm/bin/dart-decimate.js +48 -0
- package/npm/scripts/postinstall.js +46 -0
- package/npm/scripts/test-npx-local.js +54 -0
- package/npm/scripts/test-npx-mcp-local.js +56 -0
- package/package.json +45 -0
- package/src/baseline.rs +643 -0
- package/src/bin/dart-decimate-mcp.rs +11 -0
- package/src/boundaries/tests.rs +60 -0
- package/src/boundaries.rs +317 -0
- package/src/changed_scope.rs +117 -0
- package/src/ci_template.rs +399 -0
- package/src/cli/analyze.rs +462 -0
- package/src/cli/analyzer_options.rs +82 -0
- package/src/cli/audit_run.rs +327 -0
- package/src/cli/boundary_args.rs +44 -0
- package/src/cli/ci_template_run.rs +196 -0
- package/src/cli/command_name.rs +20 -0
- package/src/cli/common_args.rs +167 -0
- package/src/cli/config_run.rs +78 -0
- package/src/cli/coverage_run.rs +393 -0
- package/src/cli/decision_surface_run.rs +99 -0
- package/src/cli/default_command.rs +69 -0
- package/src/cli/dupes_args.rs +150 -0
- package/src/cli/entry_points.rs +121 -0
- package/src/cli/error.rs +149 -0
- package/src/cli/error_output.rs +68 -0
- package/src/cli/explain_run.rs +72 -0
- package/src/cli/fix_run.rs +162 -0
- package/src/cli/flags_args.rs +23 -0
- package/src/cli/health_args.rs +200 -0
- package/src/cli/hooks_run.rs +191 -0
- package/src/cli/impact_run.rs +95 -0
- package/src/cli/init_run.rs +49 -0
- package/src/cli/inspect_args.rs +20 -0
- package/src/cli/inspect_run.rs +66 -0
- package/src/cli/issue_filter_args.rs +240 -0
- package/src/cli/list_run.rs +311 -0
- package/src/cli/mode_args.rs +72 -0
- package/src/cli/output_format.rs +62 -0
- package/src/cli/regression_args.rs +156 -0
- package/src/cli/request_args.rs +175 -0
- package/src/cli/schema_commands.rs +72 -0
- package/src/cli/scope_args.rs +174 -0
- package/src/cli/security_args.rs +175 -0
- package/src/cli/security_gate_run.rs +66 -0
- package/src/cli/security_summary_run.rs +43 -0
- package/src/cli/summary_args.rs +12 -0
- package/src/cli/tests.rs +516 -0
- package/src/cli/trace_args.rs +67 -0
- package/src/cli/trace_run.rs +131 -0
- package/src/cli/trace_tests.rs +235 -0
- package/src/cli/unsupported_run.rs +116 -0
- package/src/cli/watch_run.rs +153 -0
- package/src/cli.rs +603 -0
- package/src/config/boundary_config.rs +235 -0
- package/src/config/cache.rs +25 -0
- package/src/config/dependencies.rs +114 -0
- package/src/config/health.rs +237 -0
- package/src/config/jsonc.rs +66 -0
- package/src/config/policy.rs +91 -0
- package/src/config/rule_aliases.rs +487 -0
- package/src/config/rules.rs +339 -0
- package/src/config.rs +635 -0
- package/src/coverage.rs +469 -0
- package/src/dart_parser.rs +673 -0
- package/src/decision_surface.rs +405 -0
- package/src/dependencies/analyze.rs +218 -0
- package/src/dependencies/codegen.rs +118 -0
- package/src/dependencies/discovery.rs +60 -0
- package/src/dependencies/overrides.rs +76 -0
- package/src/dependencies/private_src_imports.rs +32 -0
- package/src/dependencies/pubspec_document.rs +86 -0
- package/src/dependencies/pubspec_entry.rs +96 -0
- package/src/dependencies/tests.rs +544 -0
- package/src/dependencies/usage.rs +33 -0
- package/src/dependencies.rs +553 -0
- package/src/dependency_scripts.rs +91 -0
- package/src/dupes/lex.rs +236 -0
- package/src/dupes/tests.rs +119 -0
- package/src/dupes.rs +625 -0
- package/src/explain.rs +692 -0
- package/src/extract/directives.rs +252 -0
- package/src/extract/error_tests.rs +25 -0
- package/src/extract/members.rs +210 -0
- package/src/extract/primary_constructors.rs +421 -0
- package/src/extract/references.rs +151 -0
- package/src/extract/routes.rs +691 -0
- package/src/extract/signatures.rs +266 -0
- package/src/extract/string_tests.rs +18 -0
- package/src/extract/strings.rs +107 -0
- package/src/extract/tests.rs +697 -0
- package/src/extract.rs +680 -0
- package/src/feature_flags/tests.rs +76 -0
- package/src/feature_flags.rs +453 -0
- package/src/finding_identity.rs +60 -0
- package/src/fix.rs +551 -0
- package/src/generated.rs +53 -0
- package/src/graph/augment_tests.rs +212 -0
- package/src/graph/conditionals.rs +74 -0
- package/src/graph/package_config_tests.rs +100 -0
- package/src/graph/parts.rs +248 -0
- package/src/graph/pubspec_tests.rs +119 -0
- package/src/graph/tests.rs +837 -0
- package/src/graph/uri_tests.rs +102 -0
- package/src/graph.rs +644 -0
- package/src/health/coverage.rs +309 -0
- package/src/health/ownership.rs +175 -0
- package/src/health/runtime_coverage.rs +616 -0
- package/src/health/runtime_intelligence.rs +511 -0
- package/src/health/scores.rs +296 -0
- package/src/health/tests.rs +240 -0
- package/src/health/threshold_types.rs +163 -0
- package/src/health/thresholds.rs +229 -0
- package/src/health/types.rs +636 -0
- package/src/health.rs +597 -0
- package/src/hooks/agent_settings.rs +175 -0
- package/src/hooks/templates.rs +51 -0
- package/src/hooks.rs +569 -0
- package/src/impact.rs +287 -0
- package/src/init.rs +237 -0
- package/src/inspect.rs +142 -0
- package/src/intelligence/tests.rs +232 -0
- package/src/intelligence.rs +305 -0
- package/src/lib.rs +198 -0
- package/src/main.rs +5 -0
- package/src/manifest/mcp.rs +565 -0
- package/src/manifest.rs +552 -0
- package/src/mcp/cli_args/value_args.rs +175 -0
- package/src/mcp/cli_args.rs +658 -0
- package/src/mcp/cli_args_tests.rs +522 -0
- package/src/mcp/code_execute.rs +671 -0
- package/src/mcp/tools.rs +660 -0
- package/src/mcp.rs +325 -0
- package/src/output/audit_risk.rs +135 -0
- package/src/output/dependency_findings.rs +327 -0
- package/src/output/duplication_findings.rs +114 -0
- package/src/output/feature_flag_findings.rs +122 -0
- package/src/output/format.rs +31 -0
- package/src/output/graph_findings.rs +461 -0
- package/src/output/health_findings.rs +612 -0
- package/src/output/human.rs +27 -0
- package/src/output/next_steps.rs +92 -0
- package/src/output/route_findings.rs +76 -0
- package/src/output/runtime_coverage.rs +515 -0
- package/src/output/scope.rs +183 -0
- package/src/output/security_findings.rs +390 -0
- package/src/output/security_sarif.rs +150 -0
- package/src/output/suppressions.rs +323 -0
- package/src/output/symbol_findings.rs +257 -0
- package/src/output/tests.rs +114 -0
- package/src/output/types.rs +604 -0
- package/src/output/widget_findings.rs +213 -0
- package/src/output.rs +682 -0
- package/src/package_map.rs +495 -0
- package/src/policy/packs.rs +232 -0
- package/src/policy/tests.rs +134 -0
- package/src/policy.rs +640 -0
- package/src/project_list.rs +376 -0
- package/src/report_schema/inventory.rs +418 -0
- package/src/report_schema.rs +488 -0
- package/src/routes.rs +354 -0
- package/src/scan/tests.rs +250 -0
- package/src/scan.rs +275 -0
- package/src/security/detect.rs +639 -0
- package/src/security/tests.rs +178 -0
- package/src/security.rs +373 -0
- package/src/security_gate.rs +555 -0
- package/src/symbols/path_filters.rs +27 -0
- package/src/symbols/private_type_leaks.rs +125 -0
- package/src/symbols/riverpod.rs +113 -0
- package/src/symbols/tests.rs +692 -0
- package/src/symbols.rs +693 -0
- package/src/trace/tests.rs +225 -0
- package/src/trace.rs +690 -0
- package/src/unsupported.rs +47 -0
- package/src/widgets/lifecycle.rs +484 -0
- package/src/widgets/params.rs +236 -0
- package/src/widgets/tests.rs +430 -0
- package/src/widgets/top_level.rs +110 -0
- package/src/widgets/unrendered.rs +374 -0
- package/src/widgets.rs +590 -0
- package/src/workspace_scope.rs +358 -0
|
@@ -0,0 +1,327 @@
|
|
|
1
|
+
use std::path::Path;
|
|
2
|
+
|
|
3
|
+
use super::format::{dependency_kind, display_path};
|
|
4
|
+
use super::{Finding, FindingAction, FindingEdge, FindingKind, Severity};
|
|
5
|
+
use crate::{
|
|
6
|
+
DependencyHygieneReport, DependencyIssue, DependencyOverrideMisconfigReason, DependencySection,
|
|
7
|
+
MisconfiguredDependencyOverride, PrivateSrcImport, UnlistedPackageDependency,
|
|
8
|
+
UnusedPackageDependency,
|
|
9
|
+
};
|
|
10
|
+
|
|
11
|
+
pub(super) fn add_dependency_hygiene_findings(
|
|
12
|
+
root: &Path,
|
|
13
|
+
report: &DependencyHygieneReport,
|
|
14
|
+
findings: &mut Vec<Finding>,
|
|
15
|
+
) {
|
|
16
|
+
findings.extend(
|
|
17
|
+
report
|
|
18
|
+
.unused_dependencies
|
|
19
|
+
.iter()
|
|
20
|
+
.map(|dependency| unused_dependency_finding(root, dependency)),
|
|
21
|
+
);
|
|
22
|
+
findings.extend(
|
|
23
|
+
report
|
|
24
|
+
.misconfigured_dependency_overrides
|
|
25
|
+
.iter()
|
|
26
|
+
.map(|dependency| misconfigured_override_finding(root, dependency)),
|
|
27
|
+
);
|
|
28
|
+
findings.extend(
|
|
29
|
+
report
|
|
30
|
+
.unlisted_dependencies
|
|
31
|
+
.iter()
|
|
32
|
+
.map(|dependency| unlisted_dependency_finding(root, dependency)),
|
|
33
|
+
);
|
|
34
|
+
findings.extend(
|
|
35
|
+
report
|
|
36
|
+
.private_src_imports
|
|
37
|
+
.iter()
|
|
38
|
+
.map(|dependency| private_src_import_finding(root, dependency)),
|
|
39
|
+
);
|
|
40
|
+
}
|
|
41
|
+
|
|
42
|
+
fn unused_dependency_finding(root: &Path, dependency: &UnusedPackageDependency) -> Finding {
|
|
43
|
+
let path = display_path(root, &dependency.pubspec_path);
|
|
44
|
+
Finding {
|
|
45
|
+
rule_id: rule_id(dependency.issue).to_owned(),
|
|
46
|
+
fingerprint: None,
|
|
47
|
+
kind: finding_kind(dependency.issue),
|
|
48
|
+
severity: severity(dependency.issue),
|
|
49
|
+
message: message(dependency),
|
|
50
|
+
path: path.clone(),
|
|
51
|
+
line: dependency.location.line,
|
|
52
|
+
column: dependency.location.column,
|
|
53
|
+
safe_to_delete: dependency.safe_to_delete,
|
|
54
|
+
files: Vec::new(),
|
|
55
|
+
edge: None,
|
|
56
|
+
actions: vec![
|
|
57
|
+
FindingAction::new(
|
|
58
|
+
action(dependency),
|
|
59
|
+
action_description(dependency),
|
|
60
|
+
dependency.safe_to_delete,
|
|
61
|
+
)
|
|
62
|
+
.with_target_path(path.clone())
|
|
63
|
+
.with_target_dependency(dependency.dependency.clone())
|
|
64
|
+
.with_config_key(unused_action_config_key(dependency))
|
|
65
|
+
.with_dart_decimate_args([
|
|
66
|
+
"trace-dependency",
|
|
67
|
+
"--format",
|
|
68
|
+
"json",
|
|
69
|
+
"--dependency",
|
|
70
|
+
dependency.dependency.as_str(),
|
|
71
|
+
]),
|
|
72
|
+
],
|
|
73
|
+
}
|
|
74
|
+
}
|
|
75
|
+
|
|
76
|
+
const fn finding_kind(issue: DependencyIssue) -> FindingKind {
|
|
77
|
+
match issue {
|
|
78
|
+
DependencyIssue::UnusedRuntimeDependency => FindingKind::UnusedDependency,
|
|
79
|
+
DependencyIssue::UnusedDevDependency => FindingKind::UnusedDevDependency,
|
|
80
|
+
DependencyIssue::TestOnlyDependency => FindingKind::TestOnlyDependency,
|
|
81
|
+
DependencyIssue::UnusedDependencyOverride => FindingKind::UnusedDependencyOverride,
|
|
82
|
+
}
|
|
83
|
+
}
|
|
84
|
+
|
|
85
|
+
fn rule_id(issue: DependencyIssue) -> &'static str {
|
|
86
|
+
match issue {
|
|
87
|
+
DependencyIssue::UnusedRuntimeDependency => "dart-decimate/unused-dependency",
|
|
88
|
+
DependencyIssue::UnusedDevDependency => "dart-decimate/unused-dev-dependency",
|
|
89
|
+
DependencyIssue::TestOnlyDependency => "dart-decimate/test-only-dependency",
|
|
90
|
+
DependencyIssue::UnusedDependencyOverride => "dart-decimate/unused-dependency-override",
|
|
91
|
+
}
|
|
92
|
+
}
|
|
93
|
+
|
|
94
|
+
const fn severity(issue: DependencyIssue) -> Severity {
|
|
95
|
+
match issue {
|
|
96
|
+
DependencyIssue::UnusedDependencyOverride => Severity::Warning,
|
|
97
|
+
_ => Severity::Error,
|
|
98
|
+
}
|
|
99
|
+
}
|
|
100
|
+
|
|
101
|
+
fn message(dependency: &UnusedPackageDependency) -> String {
|
|
102
|
+
match dependency.issue {
|
|
103
|
+
DependencyIssue::UnusedRuntimeDependency => format!(
|
|
104
|
+
"{} declares unused pub dependency {}",
|
|
105
|
+
dependency.package, dependency.dependency
|
|
106
|
+
),
|
|
107
|
+
DependencyIssue::UnusedDevDependency => format!(
|
|
108
|
+
"{} declares unused dev dependency {}",
|
|
109
|
+
dependency.package, dependency.dependency
|
|
110
|
+
),
|
|
111
|
+
DependencyIssue::TestOnlyDependency => format!(
|
|
112
|
+
"{} declares runtime dependency {} that is only imported from dev/test files",
|
|
113
|
+
dependency.package, dependency.dependency
|
|
114
|
+
),
|
|
115
|
+
DependencyIssue::UnusedDependencyOverride => format!(
|
|
116
|
+
"{} declares unused dependency override {} that is absent from pubspec.lock resolved packages",
|
|
117
|
+
dependency.package, dependency.dependency
|
|
118
|
+
),
|
|
119
|
+
}
|
|
120
|
+
}
|
|
121
|
+
|
|
122
|
+
fn action(dependency: &UnusedPackageDependency) -> &'static str {
|
|
123
|
+
match dependency.issue {
|
|
124
|
+
DependencyIssue::UnusedRuntimeDependency | DependencyIssue::UnusedDevDependency
|
|
125
|
+
if dependency.safe_to_delete =>
|
|
126
|
+
{
|
|
127
|
+
"remove-pubspec-dependency"
|
|
128
|
+
}
|
|
129
|
+
DependencyIssue::UnusedRuntimeDependency | DependencyIssue::UnusedDevDependency => {
|
|
130
|
+
"review-pubspec-dependency"
|
|
131
|
+
}
|
|
132
|
+
DependencyIssue::TestOnlyDependency => "move-pubspec-dependency-to-dev-dependencies",
|
|
133
|
+
DependencyIssue::UnusedDependencyOverride => "review-unused-dependency-override",
|
|
134
|
+
}
|
|
135
|
+
}
|
|
136
|
+
|
|
137
|
+
fn action_description(dependency: &UnusedPackageDependency) -> &'static str {
|
|
138
|
+
match dependency.issue {
|
|
139
|
+
DependencyIssue::UnusedRuntimeDependency | DependencyIssue::UnusedDevDependency
|
|
140
|
+
if dependency.safe_to_delete =>
|
|
141
|
+
{
|
|
142
|
+
"Remove this simple unused pubspec dependency"
|
|
143
|
+
}
|
|
144
|
+
DependencyIssue::UnusedRuntimeDependency | DependencyIssue::UnusedDevDependency => {
|
|
145
|
+
"Review non-Dart usage such as build tools before removing this pubspec dependency"
|
|
146
|
+
}
|
|
147
|
+
DependencyIssue::TestOnlyDependency => {
|
|
148
|
+
"Move the package from dependencies to dev_dependencies after checking runtime usage"
|
|
149
|
+
}
|
|
150
|
+
DependencyIssue::UnusedDependencyOverride => {
|
|
151
|
+
"Review the dependency override against pubspec.lock before removing it"
|
|
152
|
+
}
|
|
153
|
+
}
|
|
154
|
+
}
|
|
155
|
+
|
|
156
|
+
fn misconfigured_override_finding(
|
|
157
|
+
root: &Path,
|
|
158
|
+
dependency: &MisconfiguredDependencyOverride,
|
|
159
|
+
) -> Finding {
|
|
160
|
+
let path = display_path(root, &dependency.pubspec_path);
|
|
161
|
+
Finding {
|
|
162
|
+
rule_id: "dart-decimate/misconfigured-dependency-override".to_owned(),
|
|
163
|
+
fingerprint: None,
|
|
164
|
+
kind: FindingKind::MisconfiguredDependencyOverride,
|
|
165
|
+
severity: Severity::Error,
|
|
166
|
+
message: misconfigured_override_message(dependency),
|
|
167
|
+
path: path.clone(),
|
|
168
|
+
line: dependency.location.line,
|
|
169
|
+
column: dependency.location.column,
|
|
170
|
+
safe_to_delete: false,
|
|
171
|
+
files: Vec::new(),
|
|
172
|
+
edge: None,
|
|
173
|
+
actions: vec![
|
|
174
|
+
FindingAction::new(
|
|
175
|
+
"fix-dependency-override",
|
|
176
|
+
"Fix the dependency_overrides key or value so Pub can honor it",
|
|
177
|
+
false,
|
|
178
|
+
)
|
|
179
|
+
.with_target_path(path)
|
|
180
|
+
.with_target_dependency(
|
|
181
|
+
dependency
|
|
182
|
+
.dependency
|
|
183
|
+
.clone()
|
|
184
|
+
.unwrap_or_else(|| dependency.raw_key.clone()),
|
|
185
|
+
)
|
|
186
|
+
.with_config_key("dependency_overrides"),
|
|
187
|
+
],
|
|
188
|
+
}
|
|
189
|
+
}
|
|
190
|
+
|
|
191
|
+
fn misconfigured_override_message(dependency: &MisconfiguredDependencyOverride) -> String {
|
|
192
|
+
let reason = match dependency.reason {
|
|
193
|
+
DependencyOverrideMisconfigReason::UnparsableKey => "has an invalid package name",
|
|
194
|
+
DependencyOverrideMisconfigReason::EmptyValue => "has an empty value",
|
|
195
|
+
};
|
|
196
|
+
format!(
|
|
197
|
+
"{} declares dependency override {} that {reason}",
|
|
198
|
+
dependency.package, dependency.raw_key
|
|
199
|
+
)
|
|
200
|
+
}
|
|
201
|
+
|
|
202
|
+
fn unlisted_dependency_finding(root: &Path, dependency: &UnlistedPackageDependency) -> Finding {
|
|
203
|
+
let path = display_path(root, &dependency.path);
|
|
204
|
+
let pubspec_path = display_path(root, &dependency.pubspec_path);
|
|
205
|
+
Finding {
|
|
206
|
+
rule_id: "dart-decimate/unlisted-dependency".to_owned(),
|
|
207
|
+
fingerprint: None,
|
|
208
|
+
kind: FindingKind::UnlistedDependency,
|
|
209
|
+
severity: Severity::Error,
|
|
210
|
+
message: unlisted_message(dependency),
|
|
211
|
+
path: path.clone(),
|
|
212
|
+
line: dependency.location.line,
|
|
213
|
+
column: dependency.location.column,
|
|
214
|
+
safe_to_delete: false,
|
|
215
|
+
files: Vec::new(),
|
|
216
|
+
edge: Some(FindingEdge {
|
|
217
|
+
from: display_path(root, &dependency.path),
|
|
218
|
+
to: dependency.dependency.clone(),
|
|
219
|
+
specifier: dependency.specifier.clone(),
|
|
220
|
+
kind: dependency_kind(dependency.kind),
|
|
221
|
+
}),
|
|
222
|
+
actions: vec![
|
|
223
|
+
FindingAction::new(
|
|
224
|
+
unlisted_action(dependency),
|
|
225
|
+
unlisted_action_description(dependency),
|
|
226
|
+
false,
|
|
227
|
+
)
|
|
228
|
+
.with_target_path(pubspec_path)
|
|
229
|
+
.with_target_dependency(dependency.dependency.clone())
|
|
230
|
+
.with_config_key("dependencies")
|
|
231
|
+
.with_dart_decimate_args([
|
|
232
|
+
"trace-dependency",
|
|
233
|
+
"--format",
|
|
234
|
+
"json",
|
|
235
|
+
"--dependency",
|
|
236
|
+
dependency.dependency.as_str(),
|
|
237
|
+
]),
|
|
238
|
+
],
|
|
239
|
+
}
|
|
240
|
+
}
|
|
241
|
+
|
|
242
|
+
const fn dependency_section_key(section: DependencySection) -> &'static str {
|
|
243
|
+
match section {
|
|
244
|
+
DependencySection::Dependencies => "dependencies",
|
|
245
|
+
DependencySection::DevDependencies => "dev_dependencies",
|
|
246
|
+
DependencySection::DependencyOverrides => "dependency_overrides",
|
|
247
|
+
}
|
|
248
|
+
}
|
|
249
|
+
|
|
250
|
+
const fn unused_action_config_key(dependency: &UnusedPackageDependency) -> &'static str {
|
|
251
|
+
match dependency.issue {
|
|
252
|
+
DependencyIssue::TestOnlyDependency => "dev_dependencies",
|
|
253
|
+
_ => dependency_section_key(dependency.section),
|
|
254
|
+
}
|
|
255
|
+
}
|
|
256
|
+
|
|
257
|
+
fn unlisted_message(dependency: &UnlistedPackageDependency) -> String {
|
|
258
|
+
if dependency.declared_section == Some(DependencySection::DevDependencies) {
|
|
259
|
+
return format!(
|
|
260
|
+
"{} imports {} from runtime code but declares it only in dev_dependencies",
|
|
261
|
+
dependency.package, dependency.dependency
|
|
262
|
+
);
|
|
263
|
+
}
|
|
264
|
+
if dependency.declared_section == Some(DependencySection::DependencyOverrides) {
|
|
265
|
+
return format!(
|
|
266
|
+
"{} imports {} but declares it only in dependency_overrides",
|
|
267
|
+
dependency.package, dependency.dependency
|
|
268
|
+
);
|
|
269
|
+
}
|
|
270
|
+
format!(
|
|
271
|
+
"{} imports {} but does not declare it in pubspec.yaml",
|
|
272
|
+
dependency.package, dependency.dependency
|
|
273
|
+
)
|
|
274
|
+
}
|
|
275
|
+
|
|
276
|
+
fn unlisted_action(dependency: &UnlistedPackageDependency) -> &'static str {
|
|
277
|
+
if dependency.declared_section == Some(DependencySection::DevDependencies) {
|
|
278
|
+
"move-pubspec-dependency-to-dependencies"
|
|
279
|
+
} else {
|
|
280
|
+
"add-pubspec-dependency"
|
|
281
|
+
}
|
|
282
|
+
}
|
|
283
|
+
|
|
284
|
+
fn unlisted_action_description(dependency: &UnlistedPackageDependency) -> &'static str {
|
|
285
|
+
if dependency.declared_section == Some(DependencySection::DevDependencies) {
|
|
286
|
+
"Move the imported package from dev_dependencies to dependencies"
|
|
287
|
+
} else if dependency.declared_section == Some(DependencySection::DependencyOverrides) {
|
|
288
|
+
"Declare the imported package in dependencies or dev_dependencies; dependency_overrides alone does not add it"
|
|
289
|
+
} else {
|
|
290
|
+
"Add the imported package to the importing package's pubspec.yaml"
|
|
291
|
+
}
|
|
292
|
+
}
|
|
293
|
+
|
|
294
|
+
fn private_src_import_finding(root: &Path, dependency: &PrivateSrcImport) -> Finding {
|
|
295
|
+
let path = display_path(root, &dependency.path);
|
|
296
|
+
Finding {
|
|
297
|
+
rule_id: "dart-decimate/private-src-import".to_owned(),
|
|
298
|
+
fingerprint: None,
|
|
299
|
+
kind: FindingKind::PrivateSrcImport,
|
|
300
|
+
severity: Severity::Error,
|
|
301
|
+
message: format!(
|
|
302
|
+
"{} imports private implementation library {} from package {}",
|
|
303
|
+
dependency.package, dependency.specifier, dependency.dependency
|
|
304
|
+
),
|
|
305
|
+
path: path.clone(),
|
|
306
|
+
line: dependency.location.line,
|
|
307
|
+
column: dependency.location.column,
|
|
308
|
+
safe_to_delete: false,
|
|
309
|
+
files: Vec::new(),
|
|
310
|
+
edge: Some(FindingEdge {
|
|
311
|
+
from: path.clone(),
|
|
312
|
+
to: dependency.dependency.clone(),
|
|
313
|
+
specifier: dependency.specifier.clone(),
|
|
314
|
+
kind: dependency_kind(dependency.kind),
|
|
315
|
+
}),
|
|
316
|
+
actions: vec![
|
|
317
|
+
FindingAction::new(
|
|
318
|
+
"replace-package-private-import",
|
|
319
|
+
"Import a public library from the package or move shared code behind a public API",
|
|
320
|
+
false,
|
|
321
|
+
)
|
|
322
|
+
.with_target_path(path)
|
|
323
|
+
.with_target_dependency(dependency.dependency.clone())
|
|
324
|
+
.with_suppression_comment("// dart-decimate-ignore-next-line private-src-import"),
|
|
325
|
+
],
|
|
326
|
+
}
|
|
327
|
+
}
|
|
@@ -0,0 +1,114 @@
|
|
|
1
|
+
use std::collections::BTreeSet;
|
|
2
|
+
use std::path::Path;
|
|
3
|
+
|
|
4
|
+
use super::format::display_path;
|
|
5
|
+
use super::{Finding, FindingAction, FindingKind, Severity};
|
|
6
|
+
use crate::DuplicateCodeReport;
|
|
7
|
+
use serde::{Deserialize, Serialize};
|
|
8
|
+
|
|
9
|
+
/// Clone group serialized in JSON reports.
|
|
10
|
+
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
|
|
11
|
+
pub struct JsonCloneGroup {
|
|
12
|
+
/// Stable clone fingerprint.
|
|
13
|
+
pub fingerprint: String,
|
|
14
|
+
/// Matching clone instances.
|
|
15
|
+
pub instances: Vec<JsonCloneInstance>,
|
|
16
|
+
/// Lines in the duplicated block.
|
|
17
|
+
pub line_count: usize,
|
|
18
|
+
/// Tokens in the duplicated block.
|
|
19
|
+
pub token_count: usize,
|
|
20
|
+
}
|
|
21
|
+
|
|
22
|
+
/// Clone instance serialized in JSON reports.
|
|
23
|
+
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
|
|
24
|
+
pub struct JsonCloneInstance {
|
|
25
|
+
/// Dart file path, root-relative where possible.
|
|
26
|
+
pub path: String,
|
|
27
|
+
/// 1-based start line.
|
|
28
|
+
pub start_line: usize,
|
|
29
|
+
/// 1-based end line.
|
|
30
|
+
pub end_line: usize,
|
|
31
|
+
/// 0-based byte column.
|
|
32
|
+
pub column: usize,
|
|
33
|
+
}
|
|
34
|
+
|
|
35
|
+
pub(super) fn add_duplication_findings(
|
|
36
|
+
root: &Path,
|
|
37
|
+
report: &DuplicateCodeReport,
|
|
38
|
+
findings: &mut Vec<Finding>,
|
|
39
|
+
) {
|
|
40
|
+
findings.extend(
|
|
41
|
+
report
|
|
42
|
+
.clone_groups
|
|
43
|
+
.iter()
|
|
44
|
+
.map(|clone| code_duplication_finding(root, clone)),
|
|
45
|
+
);
|
|
46
|
+
}
|
|
47
|
+
|
|
48
|
+
pub(super) fn json_clone_groups(root: &Path, report: &DuplicateCodeReport) -> Vec<JsonCloneGroup> {
|
|
49
|
+
report
|
|
50
|
+
.clone_groups
|
|
51
|
+
.iter()
|
|
52
|
+
.map(|clone| JsonCloneGroup {
|
|
53
|
+
fingerprint: clone.fingerprint.clone(),
|
|
54
|
+
instances: clone
|
|
55
|
+
.instances
|
|
56
|
+
.iter()
|
|
57
|
+
.map(|instance| JsonCloneInstance {
|
|
58
|
+
path: display_path(root, &instance.path),
|
|
59
|
+
start_line: instance.start_line,
|
|
60
|
+
end_line: instance.end_line,
|
|
61
|
+
column: instance.column,
|
|
62
|
+
})
|
|
63
|
+
.collect(),
|
|
64
|
+
line_count: clone.line_count,
|
|
65
|
+
token_count: clone.token_count,
|
|
66
|
+
})
|
|
67
|
+
.collect()
|
|
68
|
+
}
|
|
69
|
+
|
|
70
|
+
fn code_duplication_finding(root: &Path, clone: &crate::CodeClone) -> Finding {
|
|
71
|
+
let first = &clone.instances[0];
|
|
72
|
+
let path = display_path(root, &first.path);
|
|
73
|
+
let files = clone
|
|
74
|
+
.instances
|
|
75
|
+
.iter()
|
|
76
|
+
.map(|instance| display_path(root, &instance.path))
|
|
77
|
+
.collect::<BTreeSet<_>>()
|
|
78
|
+
.into_iter()
|
|
79
|
+
.collect::<Vec<_>>();
|
|
80
|
+
|
|
81
|
+
Finding {
|
|
82
|
+
rule_id: "dart-decimate/code-duplication".to_owned(),
|
|
83
|
+
fingerprint: Some(clone.fingerprint.clone()),
|
|
84
|
+
kind: FindingKind::CodeDuplication,
|
|
85
|
+
severity: Severity::Warning,
|
|
86
|
+
message: format!(
|
|
87
|
+
"{} duplicated Dart lines appear in {} places",
|
|
88
|
+
clone.line_count,
|
|
89
|
+
clone.instances.len()
|
|
90
|
+
),
|
|
91
|
+
path: path.clone(),
|
|
92
|
+
line: first.start_line,
|
|
93
|
+
column: first.column,
|
|
94
|
+
safe_to_delete: false,
|
|
95
|
+
files,
|
|
96
|
+
edge: None,
|
|
97
|
+
actions: vec![
|
|
98
|
+
FindingAction::new(
|
|
99
|
+
"trace-clone",
|
|
100
|
+
"Trace this clone group before extracting shared code",
|
|
101
|
+
false,
|
|
102
|
+
)
|
|
103
|
+
.with_target_path(path.clone())
|
|
104
|
+
.with_dart_decimate_args([
|
|
105
|
+
"trace-clone",
|
|
106
|
+
"--format",
|
|
107
|
+
"json",
|
|
108
|
+
"--fingerprint",
|
|
109
|
+
clone.fingerprint.as_str(),
|
|
110
|
+
])
|
|
111
|
+
.with_suppression_comment("// dart-decimate-ignore-next-line code-duplication"),
|
|
112
|
+
],
|
|
113
|
+
}
|
|
114
|
+
}
|
|
@@ -0,0 +1,122 @@
|
|
|
1
|
+
use std::collections::BTreeSet;
|
|
2
|
+
use std::path::Path;
|
|
3
|
+
|
|
4
|
+
use serde::{Deserialize, Serialize};
|
|
5
|
+
|
|
6
|
+
use super::format::display_path;
|
|
7
|
+
use super::{Finding, FindingAction, FindingKind, Severity};
|
|
8
|
+
use crate::{FeatureFlag, FeatureFlagConfidence, FeatureFlagReport, FeatureFlagSource};
|
|
9
|
+
|
|
10
|
+
/// Feature flag serialized in JSON reports.
|
|
11
|
+
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
|
|
12
|
+
pub struct JsonFeatureFlag {
|
|
13
|
+
/// Flag key/name.
|
|
14
|
+
pub name: String,
|
|
15
|
+
/// Detection source category.
|
|
16
|
+
pub source: FeatureFlagSource,
|
|
17
|
+
/// Provider or platform surface.
|
|
18
|
+
pub provider: String,
|
|
19
|
+
/// Detection confidence.
|
|
20
|
+
pub confidence: FeatureFlagConfidence,
|
|
21
|
+
/// Occurrences for this flag.
|
|
22
|
+
pub occurrences: Vec<JsonFeatureFlagOccurrence>,
|
|
23
|
+
}
|
|
24
|
+
|
|
25
|
+
/// One feature flag occurrence serialized in JSON reports.
|
|
26
|
+
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
|
|
27
|
+
pub struct JsonFeatureFlagOccurrence {
|
|
28
|
+
/// Dart file path, root-relative where possible.
|
|
29
|
+
pub path: String,
|
|
30
|
+
/// 1-based line.
|
|
31
|
+
pub line: usize,
|
|
32
|
+
/// 0-based byte column.
|
|
33
|
+
pub column: usize,
|
|
34
|
+
/// Matched expression or API surface.
|
|
35
|
+
pub expression: String,
|
|
36
|
+
}
|
|
37
|
+
|
|
38
|
+
pub(super) fn add_feature_flag_findings(
|
|
39
|
+
root: &Path,
|
|
40
|
+
report: &FeatureFlagReport,
|
|
41
|
+
findings: &mut Vec<Finding>,
|
|
42
|
+
) {
|
|
43
|
+
findings.extend(
|
|
44
|
+
report
|
|
45
|
+
.flags
|
|
46
|
+
.iter()
|
|
47
|
+
.map(|flag| feature_flag_finding(root, flag)),
|
|
48
|
+
);
|
|
49
|
+
}
|
|
50
|
+
|
|
51
|
+
pub(super) fn json_feature_flags(root: &Path, report: &FeatureFlagReport) -> Vec<JsonFeatureFlag> {
|
|
52
|
+
report
|
|
53
|
+
.flags
|
|
54
|
+
.iter()
|
|
55
|
+
.map(|flag| JsonFeatureFlag {
|
|
56
|
+
name: flag.name.clone(),
|
|
57
|
+
source: flag.source,
|
|
58
|
+
provider: flag.provider.clone(),
|
|
59
|
+
confidence: flag.confidence,
|
|
60
|
+
occurrences: flag
|
|
61
|
+
.occurrences
|
|
62
|
+
.iter()
|
|
63
|
+
.map(|occurrence| JsonFeatureFlagOccurrence {
|
|
64
|
+
path: display_path(root, &occurrence.path),
|
|
65
|
+
line: occurrence.location.line,
|
|
66
|
+
column: occurrence.location.column,
|
|
67
|
+
expression: occurrence.expression.clone(),
|
|
68
|
+
})
|
|
69
|
+
.collect(),
|
|
70
|
+
})
|
|
71
|
+
.collect()
|
|
72
|
+
}
|
|
73
|
+
|
|
74
|
+
fn feature_flag_finding(root: &Path, flag: &FeatureFlag) -> Finding {
|
|
75
|
+
let first = &flag.occurrences[0];
|
|
76
|
+
let path = display_path(root, &first.path);
|
|
77
|
+
let files = flag
|
|
78
|
+
.occurrences
|
|
79
|
+
.iter()
|
|
80
|
+
.map(|occurrence| display_path(root, &occurrence.path))
|
|
81
|
+
.collect::<BTreeSet<_>>()
|
|
82
|
+
.into_iter()
|
|
83
|
+
.collect::<Vec<_>>();
|
|
84
|
+
|
|
85
|
+
Finding {
|
|
86
|
+
rule_id: "dart-decimate/feature-flag".to_owned(),
|
|
87
|
+
fingerprint: Some(feature_flag_fingerprint(flag)),
|
|
88
|
+
kind: FindingKind::FeatureFlag,
|
|
89
|
+
severity: Severity::Error,
|
|
90
|
+
message: format!(
|
|
91
|
+
"Feature flag {} is referenced via {}",
|
|
92
|
+
flag.name, flag.provider
|
|
93
|
+
),
|
|
94
|
+
path: path.clone(),
|
|
95
|
+
line: first.location.line,
|
|
96
|
+
column: first.location.column,
|
|
97
|
+
safe_to_delete: false,
|
|
98
|
+
files,
|
|
99
|
+
edge: None,
|
|
100
|
+
actions: vec![
|
|
101
|
+
FindingAction::new(
|
|
102
|
+
"review-feature-flag",
|
|
103
|
+
"Verify the flag owner, rollout state, and stale-code cleanup path",
|
|
104
|
+
false,
|
|
105
|
+
)
|
|
106
|
+
.with_target_path(path.clone())
|
|
107
|
+
.with_target_symbol(flag.name.clone())
|
|
108
|
+
.with_dart_decimate_args(["inspect", "--format", "json", "--file", path.as_str()])
|
|
109
|
+
.with_suppression_comment("// dart-decimate-ignore-next-line feature-flag"),
|
|
110
|
+
],
|
|
111
|
+
}
|
|
112
|
+
}
|
|
113
|
+
|
|
114
|
+
fn feature_flag_fingerprint(flag: &FeatureFlag) -> String {
|
|
115
|
+
let text = format!("{}:{}:{}", flag.name, flag.provider, flag.source as u8);
|
|
116
|
+
let mut hash = 0xcbf2_9ce4_8422_2325_u64;
|
|
117
|
+
for byte in text.as_bytes() {
|
|
118
|
+
hash ^= u64::from(*byte);
|
|
119
|
+
hash = hash.wrapping_mul(0x0000_0100_0000_01b3);
|
|
120
|
+
}
|
|
121
|
+
format!("flag:{:08x}", hash & 0xffff_ffff)
|
|
122
|
+
}
|
|
@@ -0,0 +1,31 @@
|
|
|
1
|
+
use std::path::Path;
|
|
2
|
+
|
|
3
|
+
pub(super) fn dependency_kind(kind: crate::DependencyKind) -> String {
|
|
4
|
+
match kind {
|
|
5
|
+
crate::DependencyKind::Import => "import",
|
|
6
|
+
crate::DependencyKind::Export => "export",
|
|
7
|
+
crate::DependencyKind::Part => "part",
|
|
8
|
+
crate::DependencyKind::Augment => "augment",
|
|
9
|
+
}
|
|
10
|
+
.to_owned()
|
|
11
|
+
}
|
|
12
|
+
|
|
13
|
+
pub(super) fn declaration_kind(kind: crate::DeclarationKind) -> &'static str {
|
|
14
|
+
match kind {
|
|
15
|
+
crate::DeclarationKind::Class => "class",
|
|
16
|
+
crate::DeclarationKind::Mixin => "mixin",
|
|
17
|
+
crate::DeclarationKind::Extension => "extension",
|
|
18
|
+
crate::DeclarationKind::ExtensionType => "extension type",
|
|
19
|
+
crate::DeclarationKind::Enum => "enum",
|
|
20
|
+
crate::DeclarationKind::TypeAlias => "typedef",
|
|
21
|
+
crate::DeclarationKind::Variable => "variable",
|
|
22
|
+
crate::DeclarationKind::Function => "function",
|
|
23
|
+
}
|
|
24
|
+
}
|
|
25
|
+
|
|
26
|
+
pub(super) fn display_path(root: &Path, path: &Path) -> String {
|
|
27
|
+
path.strip_prefix(root)
|
|
28
|
+
.unwrap_or(path)
|
|
29
|
+
.to_string_lossy()
|
|
30
|
+
.replace('\\', "/")
|
|
31
|
+
}
|