dart-decimate 0.0.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/Cargo.lock +572 -0
- package/Cargo.toml +41 -0
- package/LICENSE +21 -0
- package/README.md +617 -0
- package/assets/dart-decimate-banner.png +0 -0
- package/npm/bin/dart-decimate-mcp.js +48 -0
- package/npm/bin/dart-decimate.js +48 -0
- package/npm/scripts/postinstall.js +46 -0
- package/npm/scripts/test-npx-local.js +54 -0
- package/npm/scripts/test-npx-mcp-local.js +56 -0
- package/package.json +45 -0
- package/src/baseline.rs +643 -0
- package/src/bin/dart-decimate-mcp.rs +11 -0
- package/src/boundaries/tests.rs +60 -0
- package/src/boundaries.rs +317 -0
- package/src/changed_scope.rs +117 -0
- package/src/ci_template.rs +399 -0
- package/src/cli/analyze.rs +462 -0
- package/src/cli/analyzer_options.rs +82 -0
- package/src/cli/audit_run.rs +327 -0
- package/src/cli/boundary_args.rs +44 -0
- package/src/cli/ci_template_run.rs +196 -0
- package/src/cli/command_name.rs +20 -0
- package/src/cli/common_args.rs +167 -0
- package/src/cli/config_run.rs +78 -0
- package/src/cli/coverage_run.rs +393 -0
- package/src/cli/decision_surface_run.rs +99 -0
- package/src/cli/default_command.rs +69 -0
- package/src/cli/dupes_args.rs +150 -0
- package/src/cli/entry_points.rs +121 -0
- package/src/cli/error.rs +149 -0
- package/src/cli/error_output.rs +68 -0
- package/src/cli/explain_run.rs +72 -0
- package/src/cli/fix_run.rs +162 -0
- package/src/cli/flags_args.rs +23 -0
- package/src/cli/health_args.rs +200 -0
- package/src/cli/hooks_run.rs +191 -0
- package/src/cli/impact_run.rs +95 -0
- package/src/cli/init_run.rs +49 -0
- package/src/cli/inspect_args.rs +20 -0
- package/src/cli/inspect_run.rs +66 -0
- package/src/cli/issue_filter_args.rs +240 -0
- package/src/cli/list_run.rs +311 -0
- package/src/cli/mode_args.rs +72 -0
- package/src/cli/output_format.rs +62 -0
- package/src/cli/regression_args.rs +156 -0
- package/src/cli/request_args.rs +175 -0
- package/src/cli/schema_commands.rs +72 -0
- package/src/cli/scope_args.rs +174 -0
- package/src/cli/security_args.rs +175 -0
- package/src/cli/security_gate_run.rs +66 -0
- package/src/cli/security_summary_run.rs +43 -0
- package/src/cli/summary_args.rs +12 -0
- package/src/cli/tests.rs +516 -0
- package/src/cli/trace_args.rs +67 -0
- package/src/cli/trace_run.rs +131 -0
- package/src/cli/trace_tests.rs +235 -0
- package/src/cli/unsupported_run.rs +116 -0
- package/src/cli/watch_run.rs +153 -0
- package/src/cli.rs +603 -0
- package/src/config/boundary_config.rs +235 -0
- package/src/config/cache.rs +25 -0
- package/src/config/dependencies.rs +114 -0
- package/src/config/health.rs +237 -0
- package/src/config/jsonc.rs +66 -0
- package/src/config/policy.rs +91 -0
- package/src/config/rule_aliases.rs +487 -0
- package/src/config/rules.rs +339 -0
- package/src/config.rs +635 -0
- package/src/coverage.rs +469 -0
- package/src/dart_parser.rs +673 -0
- package/src/decision_surface.rs +405 -0
- package/src/dependencies/analyze.rs +218 -0
- package/src/dependencies/codegen.rs +118 -0
- package/src/dependencies/discovery.rs +60 -0
- package/src/dependencies/overrides.rs +76 -0
- package/src/dependencies/private_src_imports.rs +32 -0
- package/src/dependencies/pubspec_document.rs +86 -0
- package/src/dependencies/pubspec_entry.rs +96 -0
- package/src/dependencies/tests.rs +544 -0
- package/src/dependencies/usage.rs +33 -0
- package/src/dependencies.rs +553 -0
- package/src/dependency_scripts.rs +91 -0
- package/src/dupes/lex.rs +236 -0
- package/src/dupes/tests.rs +119 -0
- package/src/dupes.rs +625 -0
- package/src/explain.rs +692 -0
- package/src/extract/directives.rs +252 -0
- package/src/extract/error_tests.rs +25 -0
- package/src/extract/members.rs +210 -0
- package/src/extract/primary_constructors.rs +421 -0
- package/src/extract/references.rs +151 -0
- package/src/extract/routes.rs +691 -0
- package/src/extract/signatures.rs +266 -0
- package/src/extract/string_tests.rs +18 -0
- package/src/extract/strings.rs +107 -0
- package/src/extract/tests.rs +697 -0
- package/src/extract.rs +680 -0
- package/src/feature_flags/tests.rs +76 -0
- package/src/feature_flags.rs +453 -0
- package/src/finding_identity.rs +60 -0
- package/src/fix.rs +551 -0
- package/src/generated.rs +53 -0
- package/src/graph/augment_tests.rs +212 -0
- package/src/graph/conditionals.rs +74 -0
- package/src/graph/package_config_tests.rs +100 -0
- package/src/graph/parts.rs +248 -0
- package/src/graph/pubspec_tests.rs +119 -0
- package/src/graph/tests.rs +837 -0
- package/src/graph/uri_tests.rs +102 -0
- package/src/graph.rs +644 -0
- package/src/health/coverage.rs +309 -0
- package/src/health/ownership.rs +175 -0
- package/src/health/runtime_coverage.rs +616 -0
- package/src/health/runtime_intelligence.rs +511 -0
- package/src/health/scores.rs +296 -0
- package/src/health/tests.rs +240 -0
- package/src/health/threshold_types.rs +163 -0
- package/src/health/thresholds.rs +229 -0
- package/src/health/types.rs +636 -0
- package/src/health.rs +597 -0
- package/src/hooks/agent_settings.rs +175 -0
- package/src/hooks/templates.rs +51 -0
- package/src/hooks.rs +569 -0
- package/src/impact.rs +287 -0
- package/src/init.rs +237 -0
- package/src/inspect.rs +142 -0
- package/src/intelligence/tests.rs +232 -0
- package/src/intelligence.rs +305 -0
- package/src/lib.rs +198 -0
- package/src/main.rs +5 -0
- package/src/manifest/mcp.rs +565 -0
- package/src/manifest.rs +552 -0
- package/src/mcp/cli_args/value_args.rs +175 -0
- package/src/mcp/cli_args.rs +658 -0
- package/src/mcp/cli_args_tests.rs +522 -0
- package/src/mcp/code_execute.rs +671 -0
- package/src/mcp/tools.rs +660 -0
- package/src/mcp.rs +325 -0
- package/src/output/audit_risk.rs +135 -0
- package/src/output/dependency_findings.rs +327 -0
- package/src/output/duplication_findings.rs +114 -0
- package/src/output/feature_flag_findings.rs +122 -0
- package/src/output/format.rs +31 -0
- package/src/output/graph_findings.rs +461 -0
- package/src/output/health_findings.rs +612 -0
- package/src/output/human.rs +27 -0
- package/src/output/next_steps.rs +92 -0
- package/src/output/route_findings.rs +76 -0
- package/src/output/runtime_coverage.rs +515 -0
- package/src/output/scope.rs +183 -0
- package/src/output/security_findings.rs +390 -0
- package/src/output/security_sarif.rs +150 -0
- package/src/output/suppressions.rs +323 -0
- package/src/output/symbol_findings.rs +257 -0
- package/src/output/tests.rs +114 -0
- package/src/output/types.rs +604 -0
- package/src/output/widget_findings.rs +213 -0
- package/src/output.rs +682 -0
- package/src/package_map.rs +495 -0
- package/src/policy/packs.rs +232 -0
- package/src/policy/tests.rs +134 -0
- package/src/policy.rs +640 -0
- package/src/project_list.rs +376 -0
- package/src/report_schema/inventory.rs +418 -0
- package/src/report_schema.rs +488 -0
- package/src/routes.rs +354 -0
- package/src/scan/tests.rs +250 -0
- package/src/scan.rs +275 -0
- package/src/security/detect.rs +639 -0
- package/src/security/tests.rs +178 -0
- package/src/security.rs +373 -0
- package/src/security_gate.rs +555 -0
- package/src/symbols/path_filters.rs +27 -0
- package/src/symbols/private_type_leaks.rs +125 -0
- package/src/symbols/riverpod.rs +113 -0
- package/src/symbols/tests.rs +692 -0
- package/src/symbols.rs +693 -0
- package/src/trace/tests.rs +225 -0
- package/src/trace.rs +690 -0
- package/src/unsupported.rs +47 -0
- package/src/widgets/lifecycle.rs +484 -0
- package/src/widgets/params.rs +236 -0
- package/src/widgets/tests.rs +430 -0
- package/src/widgets/top_level.rs +110 -0
- package/src/widgets/unrendered.rs +374 -0
- package/src/widgets.rs +590 -0
- package/src/workspace_scope.rs +358 -0
|
@@ -0,0 +1,405 @@
|
|
|
1
|
+
use std::collections::{BTreeMap, BTreeSet};
|
|
2
|
+
use std::fmt::Write as _;
|
|
3
|
+
use std::path::{Path, PathBuf};
|
|
4
|
+
|
|
5
|
+
use serde::{Deserialize, Serialize};
|
|
6
|
+
|
|
7
|
+
use crate::graph::normalize_against;
|
|
8
|
+
use crate::{DependencyKind, ScannedProject};
|
|
9
|
+
|
|
10
|
+
/// Stable decision-surface schema version.
|
|
11
|
+
pub const DECISION_SURFACE_SCHEMA_VERSION: &str = "dart-decimate.decision-surface.v1";
|
|
12
|
+
|
|
13
|
+
/// Advisory review surface for changed Dart/Flutter code.
|
|
14
|
+
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
|
|
15
|
+
pub struct DecisionSurfaceReport {
|
|
16
|
+
/// Schema identifier.
|
|
17
|
+
pub schema_version: String,
|
|
18
|
+
/// Typed JSON envelope discriminator.
|
|
19
|
+
pub kind: String,
|
|
20
|
+
/// Tool name.
|
|
21
|
+
pub tool: String,
|
|
22
|
+
/// Command that produced this report.
|
|
23
|
+
pub command: String,
|
|
24
|
+
/// Git base used to find changed files.
|
|
25
|
+
pub base: String,
|
|
26
|
+
/// Numeric rollup.
|
|
27
|
+
pub summary: DecisionSurfaceSummary,
|
|
28
|
+
/// Ranked structural decisions that need reviewer judgment.
|
|
29
|
+
pub decisions: Vec<DecisionSurfaceDecision>,
|
|
30
|
+
}
|
|
31
|
+
|
|
32
|
+
/// Decision-surface rollup.
|
|
33
|
+
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
|
|
34
|
+
pub struct DecisionSurfaceSummary {
|
|
35
|
+
/// Changed files considered.
|
|
36
|
+
pub changed_files: usize,
|
|
37
|
+
/// Decisions emitted after ranking and truncation.
|
|
38
|
+
pub decisions: usize,
|
|
39
|
+
}
|
|
40
|
+
|
|
41
|
+
/// One advisory structural decision.
|
|
42
|
+
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
|
|
43
|
+
pub struct DecisionSurfaceDecision {
|
|
44
|
+
/// Stable id for this decision.
|
|
45
|
+
pub id: String,
|
|
46
|
+
/// Decision category.
|
|
47
|
+
pub category: DecisionSurfaceCategory,
|
|
48
|
+
/// Lower values are more important.
|
|
49
|
+
pub priority: usize,
|
|
50
|
+
/// Review question to answer.
|
|
51
|
+
pub question: String,
|
|
52
|
+
/// Primary changed file.
|
|
53
|
+
pub path: String,
|
|
54
|
+
/// Related files, root-relative where possible.
|
|
55
|
+
pub files: Vec<String>,
|
|
56
|
+
/// Concrete evidence behind the decision.
|
|
57
|
+
pub evidence: Vec<String>,
|
|
58
|
+
/// Suggested reviewer expertise.
|
|
59
|
+
pub recommended_expert: String,
|
|
60
|
+
/// Read-only commands to run before changing code.
|
|
61
|
+
pub suggested_commands: Vec<String>,
|
|
62
|
+
}
|
|
63
|
+
|
|
64
|
+
/// Decision category.
|
|
65
|
+
#[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Serialize, Deserialize)]
|
|
66
|
+
#[serde(rename_all = "kebab-case")]
|
|
67
|
+
pub enum DecisionSurfaceCategory {
|
|
68
|
+
/// Boundary or coupling judgment.
|
|
69
|
+
CouplingBoundary,
|
|
70
|
+
/// Public API/export-surface judgment.
|
|
71
|
+
PublicApiContract,
|
|
72
|
+
/// Pub dependency ownership judgment.
|
|
73
|
+
Dependency,
|
|
74
|
+
}
|
|
75
|
+
|
|
76
|
+
/// Build the decision surface from current graph facts and changed files.
|
|
77
|
+
#[must_use]
|
|
78
|
+
pub fn decision_surface_report(
|
|
79
|
+
project: &ScannedProject,
|
|
80
|
+
base: &str,
|
|
81
|
+
changed_files: &[PathBuf],
|
|
82
|
+
max_decisions: usize,
|
|
83
|
+
) -> DecisionSurfaceReport {
|
|
84
|
+
decision_surface_report_for_command(
|
|
85
|
+
project,
|
|
86
|
+
base,
|
|
87
|
+
changed_files,
|
|
88
|
+
max_decisions,
|
|
89
|
+
"decision-surface",
|
|
90
|
+
)
|
|
91
|
+
}
|
|
92
|
+
|
|
93
|
+
/// Build the decision surface for a specific CLI command alias.
|
|
94
|
+
#[must_use]
|
|
95
|
+
pub fn decision_surface_report_for_command(
|
|
96
|
+
project: &ScannedProject,
|
|
97
|
+
base: &str,
|
|
98
|
+
changed_files: &[PathBuf],
|
|
99
|
+
max_decisions: usize,
|
|
100
|
+
command: &str,
|
|
101
|
+
) -> DecisionSurfaceReport {
|
|
102
|
+
let changed = changed_files
|
|
103
|
+
.iter()
|
|
104
|
+
.map(|path| normalize_against(&project.root, path))
|
|
105
|
+
.collect::<BTreeSet<_>>();
|
|
106
|
+
let mut decisions = BTreeMap::new();
|
|
107
|
+
|
|
108
|
+
add_coupling_decisions(project, &changed, &mut decisions);
|
|
109
|
+
add_public_api_decisions(project, &changed, &mut decisions);
|
|
110
|
+
add_dependency_decisions(project, &changed, &mut decisions);
|
|
111
|
+
|
|
112
|
+
let mut decisions = decisions.into_values().collect::<Vec<_>>();
|
|
113
|
+
decisions.sort_by(|left, right| {
|
|
114
|
+
(
|
|
115
|
+
left.priority,
|
|
116
|
+
left.category,
|
|
117
|
+
&left.path,
|
|
118
|
+
&left.question,
|
|
119
|
+
&left.id,
|
|
120
|
+
)
|
|
121
|
+
.cmp(&(
|
|
122
|
+
right.priority,
|
|
123
|
+
right.category,
|
|
124
|
+
&right.path,
|
|
125
|
+
&right.question,
|
|
126
|
+
&right.id,
|
|
127
|
+
))
|
|
128
|
+
});
|
|
129
|
+
decisions.truncate(max_decisions);
|
|
130
|
+
|
|
131
|
+
DecisionSurfaceReport {
|
|
132
|
+
schema_version: DECISION_SURFACE_SCHEMA_VERSION.to_owned(),
|
|
133
|
+
kind: "decision-surface".to_owned(),
|
|
134
|
+
tool: "dart-decimate".to_owned(),
|
|
135
|
+
command: command.to_owned(),
|
|
136
|
+
base: base.to_owned(),
|
|
137
|
+
summary: DecisionSurfaceSummary {
|
|
138
|
+
changed_files: changed.len(),
|
|
139
|
+
decisions: decisions.len(),
|
|
140
|
+
},
|
|
141
|
+
decisions,
|
|
142
|
+
}
|
|
143
|
+
}
|
|
144
|
+
|
|
145
|
+
/// Render a concise human decision-surface report.
|
|
146
|
+
#[must_use]
|
|
147
|
+
pub fn render_decision_surface_report(report: &DecisionSurfaceReport) -> String {
|
|
148
|
+
let mut rendered = String::new();
|
|
149
|
+
let _ = writeln!(
|
|
150
|
+
rendered,
|
|
151
|
+
"decision-surface base={} changed_files={} decisions={}",
|
|
152
|
+
report.base, report.summary.changed_files, report.summary.decisions
|
|
153
|
+
);
|
|
154
|
+
for decision in &report.decisions {
|
|
155
|
+
let _ = writeln!(
|
|
156
|
+
rendered,
|
|
157
|
+
"- {:?} {}: {}",
|
|
158
|
+
decision.category, decision.path, decision.question
|
|
159
|
+
);
|
|
160
|
+
}
|
|
161
|
+
rendered
|
|
162
|
+
}
|
|
163
|
+
|
|
164
|
+
fn add_coupling_decisions(
|
|
165
|
+
project: &ScannedProject,
|
|
166
|
+
changed: &BTreeSet<PathBuf>,
|
|
167
|
+
decisions: &mut BTreeMap<String, DecisionSurfaceDecision>,
|
|
168
|
+
) {
|
|
169
|
+
for dependency in project.graph.dependencies() {
|
|
170
|
+
if !changed.contains(&dependency.from_path) && !changed.contains(&dependency.to_path) {
|
|
171
|
+
continue;
|
|
172
|
+
}
|
|
173
|
+
|
|
174
|
+
let Some(from_zone) = architectural_zone(&project.root, &dependency.from_path) else {
|
|
175
|
+
continue;
|
|
176
|
+
};
|
|
177
|
+
let Some(to_zone) = architectural_zone(&project.root, &dependency.to_path) else {
|
|
178
|
+
continue;
|
|
179
|
+
};
|
|
180
|
+
if from_zone == to_zone {
|
|
181
|
+
continue;
|
|
182
|
+
}
|
|
183
|
+
|
|
184
|
+
let from = display_path(&project.root, &dependency.from_path);
|
|
185
|
+
let to = display_path(&project.root, &dependency.to_path);
|
|
186
|
+
let path = if changed.contains(&dependency.from_path) {
|
|
187
|
+
from.clone()
|
|
188
|
+
} else {
|
|
189
|
+
to.clone()
|
|
190
|
+
};
|
|
191
|
+
let id = format!("coupling-boundary:{from}:{to}:{}", dependency.specifier);
|
|
192
|
+
decisions
|
|
193
|
+
.entry(id.clone())
|
|
194
|
+
.or_insert(DecisionSurfaceDecision {
|
|
195
|
+
id,
|
|
196
|
+
category: DecisionSurfaceCategory::CouplingBoundary,
|
|
197
|
+
priority: 1,
|
|
198
|
+
question: format!(
|
|
199
|
+
"Should {from_zone} code in {from} depend on {to_zone} code in {to}?"
|
|
200
|
+
),
|
|
201
|
+
path,
|
|
202
|
+
files: vec![from.clone(), to.clone()],
|
|
203
|
+
evidence: vec![format!(
|
|
204
|
+
"{from} {} {to} via {}",
|
|
205
|
+
dependency_kind(dependency.kind),
|
|
206
|
+
dependency.specifier
|
|
207
|
+
)],
|
|
208
|
+
recommended_expert: "architecture".to_owned(),
|
|
209
|
+
suggested_commands: vec![format!(
|
|
210
|
+
"dart-decimate inspect --format json --file {from}"
|
|
211
|
+
)],
|
|
212
|
+
});
|
|
213
|
+
}
|
|
214
|
+
}
|
|
215
|
+
|
|
216
|
+
fn add_public_api_decisions(
|
|
217
|
+
project: &ScannedProject,
|
|
218
|
+
changed: &BTreeSet<PathBuf>,
|
|
219
|
+
decisions: &mut BTreeMap<String, DecisionSurfaceDecision>,
|
|
220
|
+
) {
|
|
221
|
+
for path in changed
|
|
222
|
+
.iter()
|
|
223
|
+
.filter(|path| is_public_library_path(project, path))
|
|
224
|
+
{
|
|
225
|
+
let display = display_path(&project.root, path);
|
|
226
|
+
let id = format!("public-api-contract:{display}");
|
|
227
|
+
decisions
|
|
228
|
+
.entry(id.clone())
|
|
229
|
+
.or_insert(DecisionSurfaceDecision {
|
|
230
|
+
id,
|
|
231
|
+
category: DecisionSurfaceCategory::PublicApiContract,
|
|
232
|
+
priority: 2,
|
|
233
|
+
question: format!("Does changing public library {display} alter the package API?"),
|
|
234
|
+
path: display.clone(),
|
|
235
|
+
files: vec![display.clone()],
|
|
236
|
+
evidence: vec![format!(
|
|
237
|
+
"{display} is outside lib/src and is public to importers"
|
|
238
|
+
)],
|
|
239
|
+
recommended_expert: "api-owner".to_owned(),
|
|
240
|
+
suggested_commands: vec![format!(
|
|
241
|
+
"dart-decimate inspect --format json --file {display}"
|
|
242
|
+
)],
|
|
243
|
+
});
|
|
244
|
+
}
|
|
245
|
+
|
|
246
|
+
for dependency in project
|
|
247
|
+
.graph
|
|
248
|
+
.dependencies()
|
|
249
|
+
.into_iter()
|
|
250
|
+
.filter(|dependency| dependency.kind == DependencyKind::Export)
|
|
251
|
+
{
|
|
252
|
+
if !changed.contains(&dependency.to_path)
|
|
253
|
+
|| !is_public_library_path(project, &dependency.from_path)
|
|
254
|
+
{
|
|
255
|
+
continue;
|
|
256
|
+
}
|
|
257
|
+
let entry = display_path(&project.root, &dependency.from_path);
|
|
258
|
+
let target = display_path(&project.root, &dependency.to_path);
|
|
259
|
+
let id = format!("public-api-contract:{entry}:{target}");
|
|
260
|
+
decisions
|
|
261
|
+
.entry(id.clone())
|
|
262
|
+
.or_insert(DecisionSurfaceDecision {
|
|
263
|
+
id,
|
|
264
|
+
category: DecisionSurfaceCategory::PublicApiContract,
|
|
265
|
+
priority: 2,
|
|
266
|
+
question: format!(
|
|
267
|
+
"Does changing {target} alter the public API exposed by {entry}?"
|
|
268
|
+
),
|
|
269
|
+
path: target.clone(),
|
|
270
|
+
files: vec![target.clone(), entry.clone()],
|
|
271
|
+
evidence: vec![format!(
|
|
272
|
+
"{entry} exports {target} via {}",
|
|
273
|
+
dependency.specifier
|
|
274
|
+
)],
|
|
275
|
+
recommended_expert: "api-owner".to_owned(),
|
|
276
|
+
suggested_commands: vec![format!(
|
|
277
|
+
"dart-decimate inspect --format json --file {target}"
|
|
278
|
+
)],
|
|
279
|
+
});
|
|
280
|
+
}
|
|
281
|
+
}
|
|
282
|
+
|
|
283
|
+
fn add_dependency_decisions(
|
|
284
|
+
project: &ScannedProject,
|
|
285
|
+
changed: &BTreeSet<PathBuf>,
|
|
286
|
+
decisions: &mut BTreeMap<String, DecisionSurfaceDecision>,
|
|
287
|
+
) {
|
|
288
|
+
for path in changed.iter().filter(|path| {
|
|
289
|
+
path.file_name()
|
|
290
|
+
.is_some_and(|file_name| file_name == "pubspec.yaml")
|
|
291
|
+
}) {
|
|
292
|
+
let display = display_path(&project.root, path);
|
|
293
|
+
let id = format!("dependency:{display}");
|
|
294
|
+
decisions
|
|
295
|
+
.entry(id.clone())
|
|
296
|
+
.or_insert(DecisionSurfaceDecision {
|
|
297
|
+
id,
|
|
298
|
+
category: DecisionSurfaceCategory::Dependency,
|
|
299
|
+
priority: 3,
|
|
300
|
+
question: format!(
|
|
301
|
+
"Does {display} declare the right runtime, dev, and override dependencies?"
|
|
302
|
+
),
|
|
303
|
+
path: display.clone(),
|
|
304
|
+
files: vec![display.clone()],
|
|
305
|
+
evidence: vec![format!(
|
|
306
|
+
"{display} changed and owns Pub dependency declarations"
|
|
307
|
+
)],
|
|
308
|
+
recommended_expert: "pub-dependency-owner".to_owned(),
|
|
309
|
+
suggested_commands: vec![format!(
|
|
310
|
+
"dart-decimate check --format json --file {display}"
|
|
311
|
+
)],
|
|
312
|
+
});
|
|
313
|
+
}
|
|
314
|
+
|
|
315
|
+
for file in project.files.iter().filter(|file| {
|
|
316
|
+
let path = normalize_against(&project.root, &file.path);
|
|
317
|
+
changed.contains(&path)
|
|
318
|
+
}) {
|
|
319
|
+
let path = normalize_against(&project.root, &file.path);
|
|
320
|
+
let display = display_path(&project.root, &path);
|
|
321
|
+
for package in package_imports(file) {
|
|
322
|
+
let id = format!("dependency:{display}:{package}");
|
|
323
|
+
decisions
|
|
324
|
+
.entry(id.clone())
|
|
325
|
+
.or_insert(DecisionSurfaceDecision {
|
|
326
|
+
id,
|
|
327
|
+
category: DecisionSurfaceCategory::Dependency,
|
|
328
|
+
priority: 3,
|
|
329
|
+
question: format!(
|
|
330
|
+
"Should {display} introduce or keep the Pub dependency {package}?"
|
|
331
|
+
),
|
|
332
|
+
path: display.clone(),
|
|
333
|
+
files: vec![display.clone()],
|
|
334
|
+
evidence: vec![format!("{display} imports package:{package}/...")],
|
|
335
|
+
recommended_expert: "pub-dependency-owner".to_owned(),
|
|
336
|
+
suggested_commands: vec![format!(
|
|
337
|
+
"dart-decimate trace-dependency --format json --dependency {package}"
|
|
338
|
+
)],
|
|
339
|
+
});
|
|
340
|
+
}
|
|
341
|
+
}
|
|
342
|
+
}
|
|
343
|
+
|
|
344
|
+
fn package_imports(file: &crate::DartFile) -> BTreeSet<String> {
|
|
345
|
+
file.imports
|
|
346
|
+
.iter()
|
|
347
|
+
.map(|import| &import.uri)
|
|
348
|
+
.chain(file.exports.iter().map(|export| &export.uri))
|
|
349
|
+
.filter_map(|uri| uri.strip_prefix("package:"))
|
|
350
|
+
.filter_map(|rest| rest.split_once('/').map(|(package, _)| package.to_owned()))
|
|
351
|
+
.collect()
|
|
352
|
+
}
|
|
353
|
+
|
|
354
|
+
fn architectural_zone(root: &Path, path: &Path) -> Option<String> {
|
|
355
|
+
let relative = path.strip_prefix(root).unwrap_or(path);
|
|
356
|
+
let components = relative
|
|
357
|
+
.components()
|
|
358
|
+
.filter_map(|component| component.as_os_str().to_str())
|
|
359
|
+
.collect::<Vec<_>>();
|
|
360
|
+
if components.first() != Some(&"lib") {
|
|
361
|
+
return None;
|
|
362
|
+
}
|
|
363
|
+
|
|
364
|
+
for component in &components {
|
|
365
|
+
if matches!(
|
|
366
|
+
*component,
|
|
367
|
+
"core" | "data" | "domain" | "presentation" | "ui"
|
|
368
|
+
) {
|
|
369
|
+
return Some((*component).to_owned());
|
|
370
|
+
}
|
|
371
|
+
}
|
|
372
|
+
|
|
373
|
+
None
|
|
374
|
+
}
|
|
375
|
+
|
|
376
|
+
fn is_public_library_path(project: &ScannedProject, path: &Path) -> bool {
|
|
377
|
+
let relative = path.strip_prefix(&project.root).unwrap_or(path);
|
|
378
|
+
let components = relative
|
|
379
|
+
.components()
|
|
380
|
+
.filter_map(|component| component.as_os_str().to_str())
|
|
381
|
+
.collect::<Vec<_>>();
|
|
382
|
+
components.first() == Some(&"lib")
|
|
383
|
+
&& path
|
|
384
|
+
.extension()
|
|
385
|
+
.is_some_and(|extension| extension == "dart")
|
|
386
|
+
&& components
|
|
387
|
+
.get(1)
|
|
388
|
+
.is_none_or(|component| *component != "src")
|
|
389
|
+
}
|
|
390
|
+
|
|
391
|
+
fn dependency_kind(kind: DependencyKind) -> &'static str {
|
|
392
|
+
match kind {
|
|
393
|
+
DependencyKind::Import => "imports",
|
|
394
|
+
DependencyKind::Export => "exports",
|
|
395
|
+
DependencyKind::Part => "parts",
|
|
396
|
+
DependencyKind::Augment => "augments",
|
|
397
|
+
}
|
|
398
|
+
}
|
|
399
|
+
|
|
400
|
+
fn display_path(root: &Path, path: &Path) -> String {
|
|
401
|
+
path.strip_prefix(root)
|
|
402
|
+
.unwrap_or(path)
|
|
403
|
+
.to_string_lossy()
|
|
404
|
+
.replace('\\', "/")
|
|
405
|
+
}
|
|
@@ -0,0 +1,218 @@
|
|
|
1
|
+
use std::collections::BTreeMap;
|
|
2
|
+
use std::path::{Path, PathBuf};
|
|
3
|
+
|
|
4
|
+
use crate::dependency_scripts::package_used_in_tooling;
|
|
5
|
+
use crate::generated::is_generated_dart_path;
|
|
6
|
+
use crate::{DependencyKind, Location, scan::ScannedProject};
|
|
7
|
+
|
|
8
|
+
use super::codegen::codegen_dependencies_for_file;
|
|
9
|
+
use super::usage::DependencyUsage;
|
|
10
|
+
use super::{
|
|
11
|
+
DependencyHygieneError, DependencyHygieneReport, DependencyIssue, PrivateSrcImport, PubPackage,
|
|
12
|
+
UnlistedPackageDependency, UnusedPackageDependency, dependency_issue, discover_packages,
|
|
13
|
+
imports_private_src, owning_package, package_name,
|
|
14
|
+
};
|
|
15
|
+
|
|
16
|
+
type PackageUsage = BTreeMap<PathBuf, BTreeMap<String, DependencyUsage>>;
|
|
17
|
+
|
|
18
|
+
#[derive(Default)]
|
|
19
|
+
struct ImportUsage {
|
|
20
|
+
used_by_package: PackageUsage,
|
|
21
|
+
unlisted_by_identity: BTreeMap<(PathBuf, String), UnlistedPackageDependency>,
|
|
22
|
+
private_src_imports: Vec<PrivateSrcImport>,
|
|
23
|
+
}
|
|
24
|
+
|
|
25
|
+
/// Analyze Dart `package:` imports against pubspec dependency declarations.
|
|
26
|
+
///
|
|
27
|
+
/// # Errors
|
|
28
|
+
///
|
|
29
|
+
/// Returns [`DependencyHygieneError`] if pubspec discovery or parsing fails.
|
|
30
|
+
pub fn analyze_dependency_hygiene(
|
|
31
|
+
project: &ScannedProject,
|
|
32
|
+
) -> Result<DependencyHygieneReport, DependencyHygieneError> {
|
|
33
|
+
let packages = discover_packages(&project.root)?;
|
|
34
|
+
let mut imports = collect_import_usage(project, &packages);
|
|
35
|
+
let mut unused_dependencies = unused_dependencies(&packages, &imports.used_by_package);
|
|
36
|
+
|
|
37
|
+
sort_unused_dependencies(&mut unused_dependencies);
|
|
38
|
+
sort_private_src_imports(&mut imports.private_src_imports);
|
|
39
|
+
|
|
40
|
+
Ok(DependencyHygieneReport {
|
|
41
|
+
unused_dependencies,
|
|
42
|
+
misconfigured_dependency_overrides: packages
|
|
43
|
+
.into_iter()
|
|
44
|
+
.flat_map(|package| package.misconfigured_dependency_overrides)
|
|
45
|
+
.collect(),
|
|
46
|
+
unlisted_dependencies: imports.unlisted_by_identity.into_values().collect(),
|
|
47
|
+
private_src_imports: imports.private_src_imports,
|
|
48
|
+
})
|
|
49
|
+
}
|
|
50
|
+
|
|
51
|
+
fn collect_import_usage(project: &ScannedProject, packages: &[PubPackage]) -> ImportUsage {
|
|
52
|
+
let mut usage = ImportUsage::default();
|
|
53
|
+
for file in &project.files {
|
|
54
|
+
let Some(owner) = owning_package(packages, &file.path) else {
|
|
55
|
+
continue;
|
|
56
|
+
};
|
|
57
|
+
for (specifier, kind, location) in file
|
|
58
|
+
.imports
|
|
59
|
+
.iter()
|
|
60
|
+
.map(|import| (&import.uri, DependencyKind::Import, import.location))
|
|
61
|
+
.chain(
|
|
62
|
+
file.exports
|
|
63
|
+
.iter()
|
|
64
|
+
.map(|export| (&export.uri, DependencyKind::Export, export.location)),
|
|
65
|
+
)
|
|
66
|
+
{
|
|
67
|
+
record_directive(&mut usage, owner, &file.path, specifier, kind, location);
|
|
68
|
+
}
|
|
69
|
+
for dependency in codegen_dependencies_for_file(file) {
|
|
70
|
+
let dependency_usage = usage
|
|
71
|
+
.used_by_package
|
|
72
|
+
.entry(owner.root.clone())
|
|
73
|
+
.or_default()
|
|
74
|
+
.entry(dependency.name.to_owned())
|
|
75
|
+
.or_default();
|
|
76
|
+
if dependency.production {
|
|
77
|
+
dependency_usage.record(&owner.root, &file.path);
|
|
78
|
+
} else {
|
|
79
|
+
dependency_usage.record_tooling();
|
|
80
|
+
}
|
|
81
|
+
}
|
|
82
|
+
}
|
|
83
|
+
usage
|
|
84
|
+
}
|
|
85
|
+
|
|
86
|
+
fn record_directive(
|
|
87
|
+
usage: &mut ImportUsage,
|
|
88
|
+
owner: &PubPackage,
|
|
89
|
+
file_path: &Path,
|
|
90
|
+
specifier: &str,
|
|
91
|
+
kind: DependencyKind,
|
|
92
|
+
location: Location,
|
|
93
|
+
) {
|
|
94
|
+
let Some(dependency) = package_name(specifier) else {
|
|
95
|
+
return;
|
|
96
|
+
};
|
|
97
|
+
if dependency == owner.name {
|
|
98
|
+
return;
|
|
99
|
+
}
|
|
100
|
+
|
|
101
|
+
if imports_private_src(specifier) && !is_generated_dart_path(file_path) {
|
|
102
|
+
usage.private_src_imports.push(PrivateSrcImport {
|
|
103
|
+
package: owner.name.clone(),
|
|
104
|
+
pubspec_path: owner.pubspec_path.clone(),
|
|
105
|
+
path: file_path.to_path_buf(),
|
|
106
|
+
dependency: dependency.clone(),
|
|
107
|
+
specifier: specifier.to_owned(),
|
|
108
|
+
kind,
|
|
109
|
+
location,
|
|
110
|
+
});
|
|
111
|
+
}
|
|
112
|
+
|
|
113
|
+
usage
|
|
114
|
+
.used_by_package
|
|
115
|
+
.entry(owner.root.clone())
|
|
116
|
+
.or_default()
|
|
117
|
+
.entry(dependency.clone())
|
|
118
|
+
.or_default()
|
|
119
|
+
.record(&owner.root, file_path);
|
|
120
|
+
|
|
121
|
+
if !owner.declares_dependency_for_path(&dependency, file_path) {
|
|
122
|
+
usage
|
|
123
|
+
.unlisted_by_identity
|
|
124
|
+
.entry((owner.root.clone(), dependency.clone()))
|
|
125
|
+
.or_insert_with(|| UnlistedPackageDependency {
|
|
126
|
+
package: owner.name.clone(),
|
|
127
|
+
pubspec_path: owner.pubspec_path.clone(),
|
|
128
|
+
path: file_path.to_path_buf(),
|
|
129
|
+
dependency,
|
|
130
|
+
specifier: specifier.to_owned(),
|
|
131
|
+
kind,
|
|
132
|
+
declared_section: owner.declared_section(specifier),
|
|
133
|
+
location,
|
|
134
|
+
});
|
|
135
|
+
}
|
|
136
|
+
}
|
|
137
|
+
|
|
138
|
+
fn unused_dependencies(
|
|
139
|
+
packages: &[PubPackage],
|
|
140
|
+
used_by_package: &PackageUsage,
|
|
141
|
+
) -> Vec<UnusedPackageDependency> {
|
|
142
|
+
let mut unused_dependencies = Vec::new();
|
|
143
|
+
for package in packages {
|
|
144
|
+
let used = used_by_package.get(&package.root);
|
|
145
|
+
for dependency in &package.dependencies {
|
|
146
|
+
if let Some(unused) = unused_dependency(package, dependency, used) {
|
|
147
|
+
unused_dependencies.push(unused);
|
|
148
|
+
}
|
|
149
|
+
}
|
|
150
|
+
}
|
|
151
|
+
unused_dependencies
|
|
152
|
+
}
|
|
153
|
+
|
|
154
|
+
fn unused_dependency(
|
|
155
|
+
package: &PubPackage,
|
|
156
|
+
dependency: &super::DeclaredDependency,
|
|
157
|
+
used: Option<&BTreeMap<String, DependencyUsage>>,
|
|
158
|
+
) -> Option<UnusedPackageDependency> {
|
|
159
|
+
if dependency.name == package.name {
|
|
160
|
+
return None;
|
|
161
|
+
}
|
|
162
|
+
let mut usage = used
|
|
163
|
+
.and_then(|used| used.get(&dependency.name))
|
|
164
|
+
.copied()
|
|
165
|
+
.unwrap_or_default();
|
|
166
|
+
if package_used_in_tooling(&package.root, &dependency.name) {
|
|
167
|
+
usage.record_tooling();
|
|
168
|
+
}
|
|
169
|
+
let usage = usage.any().then_some(usage);
|
|
170
|
+
let issue = dependency_issue(dependency, usage.as_ref(), package.locked_packages.as_ref())?;
|
|
171
|
+
Some(UnusedPackageDependency {
|
|
172
|
+
package: package.name.clone(),
|
|
173
|
+
pubspec_path: dependency.source_path.clone(),
|
|
174
|
+
dependency: dependency.name.clone(),
|
|
175
|
+
section: dependency.section,
|
|
176
|
+
issue,
|
|
177
|
+
location: dependency.location,
|
|
178
|
+
safe_to_delete: dependency.safe_to_delete
|
|
179
|
+
&& matches!(
|
|
180
|
+
issue,
|
|
181
|
+
DependencyIssue::UnusedRuntimeDependency | DependencyIssue::UnusedDevDependency
|
|
182
|
+
),
|
|
183
|
+
})
|
|
184
|
+
}
|
|
185
|
+
|
|
186
|
+
fn sort_unused_dependencies(unused_dependencies: &mut [UnusedPackageDependency]) {
|
|
187
|
+
unused_dependencies.sort_by(|left, right| {
|
|
188
|
+
(
|
|
189
|
+
&left.package,
|
|
190
|
+
left.section.as_pubspec_key(),
|
|
191
|
+
&left.dependency,
|
|
192
|
+
)
|
|
193
|
+
.cmp(&(
|
|
194
|
+
&right.package,
|
|
195
|
+
right.section.as_pubspec_key(),
|
|
196
|
+
&right.dependency,
|
|
197
|
+
))
|
|
198
|
+
});
|
|
199
|
+
}
|
|
200
|
+
|
|
201
|
+
fn sort_private_src_imports(private_src_imports: &mut [PrivateSrcImport]) {
|
|
202
|
+
private_src_imports.sort_by(|left, right| {
|
|
203
|
+
(
|
|
204
|
+
&left.package,
|
|
205
|
+
&left.path,
|
|
206
|
+
left.location.line,
|
|
207
|
+
&left.dependency,
|
|
208
|
+
&left.specifier,
|
|
209
|
+
)
|
|
210
|
+
.cmp(&(
|
|
211
|
+
&right.package,
|
|
212
|
+
&right.path,
|
|
213
|
+
right.location.line,
|
|
214
|
+
&right.dependency,
|
|
215
|
+
&right.specifier,
|
|
216
|
+
))
|
|
217
|
+
});
|
|
218
|
+
}
|