crewly 1.13.0 → 1.14.0

package/dist/cli/backend/src/services/orc/orc-delivery-enforcer.service.js

@@ -0,0 +1,293 @@
+/**
+ * OrcDeliveryEnforcerService
+ *
+ * **Why this exists** (2026-05-23 incident, the "affiliate research" case):
+ *
+ * Steve asked the team to research affiliate programs at 12:59 PM. ORC
+ * acknowledged at 1:00 PM with "Atlas + Sage/Kai 派出去了, ETA 30-40min".
+ * Sage finished Phase 1 at 1:15, Kai finished Phase 2 at 1:28 — but
+ * Steve never saw the result. ORC's terminal logs claimed the pipeline
+ * was "closed" and the result "already routed to Steve at Slack thread
+ * ...", but there were zero `/api/slack/send` calls all day. ORC's
+ * internal mental model believed delivery happened; the actual skill
+ * call didn't.
+ *
+ * Root cause: ORC's prompt has a HARD pre-yield gate ("any `[CHAT:slack-…]`
+ * MUST have a `reply-slack` before yielding"). But for a long-running
+ * delegation, the user-visible deliverable comes from the *agent* via
+ * `[DONE]`-style status reports — long AFTER ORC's initial ack. ORC
+ * reads the agent's `[DONE]` as internal team chatter, narrates "pipeline
+ * closed", and yields without delivering to Steve. The prompt rule
+ * doesn't catch this case because the prompt looks for `[CHAT:slack-…]`
+ * (user-originating) not `[DONE]` (agent-originating).
+ *
+ * **What this service does:**
+ *
+ *   1. When a worker agent posts `[DONE]` / `[COMPLETED]` to a
+ *      slack-prefixed conversation (chat.controller's "Agent status
+ *      routed to orchestrator" path), call {@link markPendingDelivery}.
+ *      The service records a pending delivery with `dueBy = now + 3 min`.
+ *
+ *   2. When ORC successfully posts via `/api/slack/send` to the same
+ *      thread, call {@link markDelivered}. Pending delivery cleared.
+ *
+ *   3. A timer scans every 30 s. For any pending delivery whose `dueBy`
+ *      has passed AND ORC hasn't replied, enqueue a `[DELIVER_REQUIRED]`
+ *      system message to ORC via MessageQueueService. ORC's prompt
+ *      treats `[DELIVER_REQUIRED]` exactly like `[CHAT:slack-…]` for
+ *      the pre-yield gate.
+ *
+ *   4. Exponential backoff between reminders for the same thread, to
+ *      avoid spamming ORC if it's genuinely stuck or rate-limited.
+ *      First reminder at 3 min, then 10 min, then 30 min, then stop.
+ *
+ * Fire-and-forget on all writes — a fault in the enforcer MUST NOT
+ * block chat or slack flow.
+ *
+ * @module services/orc/orc-delivery-enforcer.service
+ */
+import { LoggerService } from '../core/logger.service.js';
+import { ORCHESTRATOR_SESSION_NAME } from '../../constants.js';
+/** Reminder cadence (ms): first reminder at 3 min, then 10 min, then 30 min, then stop. */
+const REMINDER_CADENCE_MS = [
+    3 * 60 * 1000,
+    10 * 60 * 1000,
+    30 * 60 * 1000,
+];
+const DEFAULT_TICK_INTERVAL_MS = 30 * 1000;
+/** Markers in agent output that indicate user-facing delivery is ready. */
+const DELIVERY_MARKERS = ['[DONE]', '[COMPLETED]', '[DELIVERED]'];
+/**
+ * Singleton scope — there's one ORC, one queue of pending deliveries.
+ */
+export class OrcDeliveryEnforcerService {
+    static instance = null;
+    logger;
+    reminderSink;
+    tickIntervalMs;
+    timer = null;
+    /** key = `${channelId}::${threadTs}` */
+    pending = new Map();
+    constructor(opts) {
+        this.logger = LoggerService.getInstance().createComponentLogger('OrcDeliveryEnforcer');
+        this.reminderSink = opts.reminderSink;
+        this.tickIntervalMs = opts.tickIntervalMs ?? DEFAULT_TICK_INTERVAL_MS;
+    }
+    static getInstance() {
+        return this.instance;
+    }
+    static setInstance(next) {
+        if (this.instance && this.instance !== next)
+            this.instance.stop();
+        this.instance = next;
+    }
+    /** Start the periodic scan. Idempotent. */
+    start() {
+        if (this.timer)
+            return;
+        this.timer = setInterval(() => this.tick(), this.tickIntervalMs);
+        this.timer.unref?.();
+        this.logger.info('OrcDeliveryEnforcer started', {
+            tickIntervalMs: this.tickIntervalMs,
+            cadenceMinutes: REMINDER_CADENCE_MS.map((n) => Math.round(n / 60000)),
+        });
+    }
+    stop() {
+        if (this.timer) {
+            clearInterval(this.timer);
+            this.timer = null;
+            this.logger.info('OrcDeliveryEnforcer stopped');
+        }
+    }
+    /**
+     * Call this from `chat.controller` when an agent posts a `[DONE]`-style
+     * status to a slack-prefixed conversation. Safe to call multiple times
+     * for the same thread — the most recent agent message wins (we
+     * surface only the latest deliverable summary in the reminder).
+     */
+    markPendingDelivery(input) {
+        if (!isAgentDeliveryMarker(input.text))
+            return;
+        // The orchestrator is the deliverer, never the source. Its own
+        // `[DONE] Agent crewly-orc: …` status report is bookkeeping about work
+        // it already did; treating it as an undelivered deliverable made the
+        // enforcer nag ORC to "deliver" its own summary, ORC replied and filed
+        // another [DONE], and the thread never went quiet (2026-09-13, Steve:
+        // "我说了好了 但是crewly还一直在回复").
+        if (isOrchestratorSender(input.agentSender)) {
+            this.logger.debug('OrcDeliveryEnforcer ignoring orchestrator self-report', {
+                conversationId: input.conversationId,
+            });
+            return;
+        }
+        const key = parseSlackConversationId(input.conversationId);
+        if (!key)
+            return; // not a slack thread — ignore
+        const k = serializeKey(key);
+        const now = Date.now();
+        const summary = input.text.slice(0, 200);
+        this.pending.set(k, {
+            key,
+            conversationId: input.conversationId,
+            agentSender: input.agentSender,
+            deliverableSummary: summary,
+            doneAt: now,
+            remindersFired: 0,
+            nextDueAt: now + REMINDER_CADENCE_MS[0],
+        });
+        this.logger.info('OrcDeliveryEnforcer pending delivery recorded', {
+            conversationId: input.conversationId,
+            agentSender: input.agentSender,
+            summaryPreview: summary.slice(0, 80),
+            firstReminderInSec: REMINDER_CADENCE_MS[0] / 1000,
+        });
+    }
+    /**
+     * Call this from `slack.controller` after a successful `/api/slack/send`.
+     * Cleared regardless of which agent originated the underlying deliverable.
+     */
+    markDelivered(input) {
+        if (!input.channelId || !input.threadTs)
+            return;
+        const k = serializeKey({ channelId: input.channelId, threadTs: input.threadTs });
+        const had = this.pending.delete(k);
+        if (had) {
+            this.logger.info('OrcDeliveryEnforcer delivery cleared by reply-slack', {
+                channelId: input.channelId,
+                threadTs: input.threadTs,
+            });
+        }
+    }
+    /** Test affordance — peek at the in-memory ledger. */
+    _peekPending() {
+        return [...this.pending.values()];
+    }
+    /**
+     * Public for tests + the manual-trigger endpoint. Otherwise driven by
+     * the internal timer.
+     */
+    tick(now = Date.now()) {
+        const firedFor = [];
+        for (const [k, item] of this.pending) {
+            if (now < item.nextDueAt)
+                continue;
+            if (item.remindersFired >= REMINDER_CADENCE_MS.length) {
+                // Out of reminder budget — drop the entry so we stop spamming.
+                this.pending.delete(k);
+                this.logger.warn('OrcDeliveryEnforcer reminder budget exhausted — giving up', {
+                    conversationId: item.conversationId,
+                    remindersFired: item.remindersFired,
+                });
+                continue;
+            }
+            const text = this.formatReminder(item);
+            try {
+                this.reminderSink({
+                    conversationId: item.conversationId,
+                    text,
+                });
+                firedFor.push(item.conversationId);
+                this.logger.info('OrcDeliveryEnforcer reminder fired', {
+                    conversationId: item.conversationId,
+                    agentSender: item.agentSender,
+                    reminderIndex: item.remindersFired,
+                    minutesSinceDone: Math.round((now - item.doneAt) / 60000),
+                });
+            }
+            catch (err) {
+                this.logger.warn('OrcDeliveryEnforcer reminderSink threw (swallowed)', {
+                    error: err.message,
+                    conversationId: item.conversationId,
+                });
+            }
+            item.remindersFired += 1;
+            const nextOffset = REMINDER_CADENCE_MS[item.remindersFired];
+            if (nextOffset === undefined) {
+                // Final reminder fired — drop the entry now so we don't keep
+                // re-evaluating it on every tick.
+                this.pending.delete(k);
+            }
+            else {
+                item.nextDueAt = now + nextOffset;
+            }
+        }
+        return { firedFor };
+    }
+    formatReminder(item) {
+        const minutes = Math.round((Date.now() - item.doneAt) / 60000);
+        return [
+            `[DELIVER_REQUIRED] Steve is waiting on a deliverable in Slack thread ${item.conversationId}.`,
+            ``,
+            `Agent \`${item.agentSender}\` posted [DONE] ${minutes} min ago with this content (preview):`,
+            `> ${item.deliverableSummary.slice(0, 200)}${item.deliverableSummary.length > 200 ? '…' : ''}`,
+            ``,
+            `Action required: call reply-slack now with the deliverable. Treat this`,
+            `the same as a [CHAT:slack-...] message — do NOT yield the turn until`,
+            `the reply lands on the thread. If the agent's output isn't the final`,
+            `deliverable yet (e.g. it's "Phase 1 done" out of 2), send Steve a status`,
+            `update via reply-slack saying so + revised ETA, then continue waiting.`,
+        ].join('\n');
+    }
+}
+// =============================================================================
+// Helpers (exported for testing)
+// =============================================================================
+export function isAgentDeliveryMarker(text) {
+    if (!text)
+        return false;
+    const upper = text.toUpperCase();
+    return DELIVERY_MARKERS.some((m) => upper.includes(m));
+}
+/**
+ * Parse a chat-v2 conversation id of the form `slack-<channelId>-<ts>`
+ * into { channelId, threadTs }. Returns null for non-slack ids. Mirrors
+ * the regex in `request-sla.subscriber` so the enforcer agrees with the
+ * SLA layer on what "the same thread" means.
+ */
+export function parseSlackConversationId(conversationId) {
+    if (!conversationId || !conversationId.startsWith('slack-'))
+        return null;
+    // Strip any per-message suffix (`-msg-<ts>`) so we key on thread root,
+    // and any `:<tag>` the orchestrator appends when it names a conversation
+    // (`slack-D0AC…-953849:737ad8eb`). Without this the tag leaked into
+    // threadTs, the key never matched the one `markDelivered` builds from
+    // the real channel + ts, and a reply could never clear the entry.
+    const stripped = conversationId.replace(/:[^:]*$/, '').replace(/-msg-\d+\.\d+$/, '');
+    const rest = stripped.slice('slack-'.length);
+    const lastDash = rest.lastIndexOf('-');
+    if (lastDash < 1)
+        return null;
+    const channelId = rest.slice(0, lastDash);
+    const threadTs = rest.slice(lastDash + 1);
+    // Some producers serialize ts as `1779555555-588569` (dash) or
+    // `1779555555.588569` (dot). Normalize to dotted form to match
+    // Slack-API ts shape.
+    if (/^\d+$/.test(threadTs)) {
+        // No fractional segment in URL form — try one more split.
+        const beforeRest = rest.slice(0, lastDash);
+        const prevDash = beforeRest.lastIndexOf('-');
+        if (prevDash > 0) {
+            const candidate = `${beforeRest.slice(prevDash + 1)}.${threadTs}`;
+            if (/^\d+\.\d+$/.test(candidate)) {
+                return { channelId: beforeRest.slice(0, prevDash), threadTs: candidate };
+            }
+        }
+    }
+    // If threadTs already contains a dot (dotted form), keep as-is.
+    return { channelId, threadTs };
+}
+/**
+ * Is this sender the orchestrator itself (by session name or the display
+ * names the prompt/skills use for it)?
+ *
+ * @param sender - `senderName` as posted to `/chat/agent-response`
+ * @returns True for the orchestrator
+ */
+export function isOrchestratorSender(sender) {
+    const s = (sender ?? '').trim().toLowerCase();
+    return s === ORCHESTRATOR_SESSION_NAME.toLowerCase() || s === 'orchestrator' || s === 'orc';
+}
+function serializeKey(k) {
+    return `${k.channelId}::${k.threadTs}`;
+}
+//# sourceMappingURL=orc-delivery-enforcer.service.js.map

package/dist/cli/backend/src/services/orc/orc-delivery-enforcer.service.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"orc-delivery-enforcer.service.js","sourceRoot":"","sources":["../../../../../../backend/src/services/orc/orc-delivery-enforcer.service.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA+CG;AAEH,OAAO,EAAE,aAAa,EAAmB,MAAM,2BAA2B,CAAC;AAC3E,OAAO,EAAE,yBAAyB,EAAE,MAAM,oBAAoB,CAAC;AAE/D,2FAA2F;AAC3F,MAAM,mBAAmB,GAAG;IAC1B,CAAC,GAAG,EAAE,GAAG,IAAI;IACb,EAAE,GAAG,EAAE,GAAG,IAAI;IACd,EAAE,GAAG,EAAE,GAAG,IAAI;CACN,CAAC;AAEX,MAAM,wBAAwB,GAAG,EAAE,GAAG,IAAI,CAAC;AAE3C,2EAA2E;AAC3E,MAAM,gBAAgB,GAAG,CAAC,QAAQ,EAAE,aAAa,EAAE,aAAa,CAAC,CAAC;AA4ClE;;GAEG;AACH,MAAM,OAAO,0BAA0B;IAC7B,MAAM,CAAC,QAAQ,GAAsC,IAAI,CAAC;IACjD,MAAM,CAAkB;IACxB,YAAY,CAAuB;IACnC,cAAc,CAAS;IAChC,KAAK,GAA0B,IAAI,CAAC;IAC5C,wCAAwC;IACvB,OAAO,GAAG,IAAI,GAAG,EAA2B,CAAC;IAE9D,YAAY,IAAgC;QAC1C,IAAI,CAAC,MAAM,GAAG,aAAa,CAAC,WAAW,EAAE,CAAC,qBAAqB,CAAC,qBAAqB,CAAC,CAAC;QACvF,IAAI,CAAC,YAAY,GAAG,IAAI,CAAC,YAAY,CAAC;QACtC,IAAI,CAAC,cAAc,GAAG,IAAI,CAAC,cAAc,IAAI,wBAAwB,CAAC;IACxE,CAAC;IAED,MAAM,CAAC,WAAW;QAChB,OAAO,IAAI,CAAC,QAAQ,CAAC;IACvB,CAAC;IAED,MAAM,CAAC,WAAW,CAAC,IAAuC;QACxD,IAAI,IAAI,CAAC,QAAQ,IAAI,IAAI,CAAC,QAAQ,KAAK,IAAI;YAAE,IAAI,CAAC,QAAQ,CAAC,IAAI,EAAE,CAAC;QAClE,IAAI,CAAC,QAAQ,GAAG,IAAI,CAAC;IACvB,CAAC;IAED,2CAA2C;IAC3C,KAAK;QACH,IAAI,IAAI,CAAC,KAAK;YAAE,OAAO;QACvB,IAAI,CAAC,KAAK,GAAG,WAAW,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC,IAAI,EAAE,EAAE,IAAI,CAAC,cAAc,CAAC,CAAC;QACjE,IAAI,CAAC,KAAK,CAAC,KAAK,EAAE,EAAE,CAAC;QACrB,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,6BAA6B,EAAE;YAC9C,cAAc,EAAE,IAAI,CAAC,cAAc;YACnC,cAAc,EAAE,mBAAmB,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,GAAG,KAAK,CAAC,CAAC;SACtE,CAAC,CAAC;IACL,CAAC;IAED,IAAI;QACF,IAAI,IAAI,CAAC,KAAK,EAAE,CAAC;YACf,aAAa,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YAC1B,IAAI,CAAC,KAAK,GAAG,IAAI,CAAC;YAClB,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,6BAA6B,CAAC,CAAC;QAClD,CAAC;IACH,CAAC;IAED;;;;;OAKG;IACH,mBAAmB,CAAC,KAInB;QACC,IAAI,CAAC,qBAAqB,CAAC,KAAK,CAAC,IAAI,CAAC;YAAE,OAAO;QAC/C,+DAA+D;QAC/D,uEAAuE;QACvE,qEAAqE;QACrE,uEAAuE;QACvE,sEAAsE;QACtE,2BAA2B;QAC3B,IAAI,oBAAoB,CAAC,KAAK,CAAC,WAAW,CAAC,EAAE,CAAC;YAC5C,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,uDAAuD,EAAE;gBACzE,cAAc,EAAE,KAAK,CAAC,cAAc;aACrC,CAAC,CAAC;YACH,OAAO;QACT,CAAC;QACD,MAAM,GAAG,GAAG,wBAAwB,CAAC,KAAK,CAAC,cAAc,CAAC,CAAC;QAC3D,IAAI,CAAC,GAAG;YAAE,OAAO,CAAC,8BAA8B;QAEhD,MAAM,CAAC,GAAG,YAAY,CAAC,GAAG,CAAC,CAAC;QAC5B,MAAM,GAAG,GAAG,IAAI,CAAC,GAAG,EAAE,CAAC;QACvB,MAAM,OAAO,GAAG,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,CAAC;QACzC,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,EAAE;YAClB,GAAG;YACH,cAAc,EAAE,KAAK,CAAC,cAAc;YACpC,WAAW,EAAE,KAAK,CAAC,WAAW;YAC9B,kBAAkB,EAAE,OAAO;YAC3B,MAAM,EAAE,GAAG;YACX,cAAc,EAAE,CAAC;YACjB,SAAS,EAAE,GAAG,GAAG,mBAAmB,CAAC,CAAC,CAAC;SACxC,CAAC,CAAC;QACH,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,+CAA+C,EAAE;YAChE,cAAc,EAAE,KAAK,CAAC,cAAc;YACpC,WAAW,EAAE,KAAK,CAAC,WAAW;YAC9B,cAAc,EAAE,OAAO,CAAC,KAAK,CAAC,CAAC,EAAE,EAAE,CAAC;YACpC,kBAAkB,EAAE,mBAAmB,CAAC,CAAC,CAAC,GAAG,IAAI;SAClD,CAAC,CAAC;IACL,CAAC;IAED;;;OAGG;IACH,aAAa,CAAC,KAAsD;QAClE,IAAI,CAAC,KAAK,CAAC,SAAS,IAAI,CAAC,KAAK,CAAC,QAAQ;YAAE,OAAO;QAChD,MAAM,CAAC,GAAG,YAAY,CAAC,EAAE,SAAS,EAAE,KAAK,CAAC,SAAS,EAAE,QAAQ,EAAE,KAAK,CAAC,QAAQ,EAAE,CAAC,CAAC;QACjF,MAAM,GAAG,GAAG,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC;QACnC,IAAI,GAAG,EAAE,CAAC;YACR,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,qDAAqD,EAAE;gBACtE,SAAS,EAAE,KAAK,CAAC,SAAS;gBAC1B,QAAQ,EAAE,KAAK,CAAC,QAAQ;aACzB,CAAC,CAAC;QACL,CAAC;IACH,CAAC;IAED,sDAAsD;IACtD,YAAY;QACV,OAAO,CAAC,GAAG,IAAI,CAAC,OAAO,CAAC,MAAM,EAAE,CAAC,CAAC;IACpC,CAAC;IAED;;;OAGG;IACH,IAAI,CAAC,MAAc,IAAI,CAAC,GAAG,EAAE;QAC3B,MAAM,QAAQ,GAAa,EAAE,CAAC;QAC9B,KAAK,MAAM,CAAC,CAAC,EAAE,IAAI,CAAC,IAAI,IAAI,CAAC,OAAO,EAAE,CAAC;YACrC,IAAI,GAAG,GAAG,IAAI,CAAC,SAAS;gBAAE,SAAS;YACnC,IAAI,IAAI,CAAC,cAAc,IAAI,mBAAmB,CAAC,MAAM,EAAE,CAAC;gBACtD,+DAA+D;gBAC/D,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC;gBACvB,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,2DAA2D,EAAE;oBAC5E,cAAc,EAAE,IAAI,CAAC,cAAc;oBACnC,cAAc,EAAE,IAAI,CAAC,cAAc;iBACpC,CAAC,CAAC;gBACH,SAAS;YACX,CAAC;YAED,MAAM,IAAI,GAAG,IAAI,CAAC,cAAc,CAAC,IAAI,CAAC,CAAC;YACvC,IAAI,CAAC;gBACH,IAAI,CAAC,YAAY,CAAC;oBAChB,cAAc,EAAE,IAAI,CAAC,cAAc;oBACnC,IAAI;iBACL,CAAC,CAAC;gBACH,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,cAAc,CAAC,CAAC;gBACnC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,oCAAoC,EAAE;oBACrD,cAAc,EAAE,IAAI,CAAC,cAAc;oBACnC,WAAW,EAAE,IAAI,CAAC,WAAW;oBAC7B,aAAa,EAAE,IAAI,CAAC,cAAc;oBAClC,gBAAgB,EAAE,IAAI,CAAC,KAAK,CAAC,CAAC,GAAG,GAAG,IAAI,CAAC,MAAM,CAAC,GAAG,KAAK,CAAC;iBAC1D,CAAC,CAAC;YACL,CAAC;YAAC,OAAO,GAAG,EAAE,CAAC;gBACb,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,oDAAoD,EAAE;oBACrE,KAAK,EAAG,GAAa,CAAC,OAAO;oBAC7B,cAAc,EAAE,IAAI,CAAC,cAAc;iBACpC,CAAC,CAAC;YACL,CAAC;YACD,IAAI,CAAC,cAAc,IAAI,CAAC,CAAC;YACzB,MAAM,UAAU,GAAG,mBAAmB,CAAC,IAAI,CAAC,cAAc,CAAC,CAAC;YAC5D,IAAI,UAAU,KAAK,SAAS,EAAE,CAAC;gBAC7B,6DAA6D;gBAC7D,kCAAkC;gBAClC,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC;YACzB,CAAC;iBAAM,CAAC;gBACN,IAAI,CAAC,SAAS,GAAG,GAAG,GAAG,UAAU,CAAC;YACpC,CAAC;QACH,CAAC;QACD,OAAO,EAAE,QAAQ,EAAE,CAAC;IACtB,CAAC;IAEO,cAAc,CAAC,IAAqB;QAC1C,MAAM,OAAO,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,GAAG,EAAE,GAAG,IAAI,CAAC,MAAM,CAAC,GAAG,KAAK,CAAC,CAAC;QAC/D,OAAO;YACL,wEAAwE,IAAI,CAAC,cAAc,GAAG;YAC9F,EAAE;YACF,WAAW,IAAI,CAAC,WAAW,oBAAoB,OAAO,uCAAuC;YAC7F,KAAK,IAAI,CAAC,kBAAkB,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,GAAG,IAAI,CAAC,kBAAkB,CAAC,MAAM,GAAG,GAAG,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE;YAC9F,EAAE;YACF,wEAAwE;YACxE,sEAAsE;YACtE,sEAAsE;YACtE,0EAA0E;YAC1E,wEAAwE;SACzE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACf,CAAC;;AAGH,gFAAgF;AAChF,iCAAiC;AACjC,gFAAgF;AAEhF,MAAM,UAAU,qBAAqB,CAAC,IAAY;IAChD,IAAI,CAAC,IAAI;QAAE,OAAO,KAAK,CAAC;IACxB,MAAM,KAAK,GAAG,IAAI,CAAC,WAAW,EAAE,CAAC;IACjC,OAAO,gBAAgB,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAC;AACzD,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,wBAAwB,CACtC,cAAsB;IAEtB,IAAI,CAAC,cAAc,IAAI,CAAC,cAAc,CAAC,UAAU,CAAC,QAAQ,CAAC;QAAE,OAAO,IAAI,CAAC;IACzE,uEAAuE;IACvE,yEAAyE;IACzE,oEAAoE;IACpE,sEAAsE;IACtE,kEAAkE;IAClE,MAAM,QAAQ,GAAG,cAAc,CAAC,OAAO,CAAC,SAAS,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,gBAAgB,EAAE,EAAE,CAAC,CAAC;IACrF,MAAM,IAAI,GAAG,QAAQ,CAAC,KAAK,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC;IAC7C,MAAM,QAAQ,GAAG,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,CAAC;IACvC,IAAI,QAAQ,GAAG,CAAC;QAAE,OAAO,IAAI,CAAC;IAC9B,MAAM,SAAS,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,EAAE,QAAQ,CAAC,CAAC;IAC1C,MAAM,QAAQ,GAAG,IAAI,CAAC,KAAK,CAAC,QAAQ,GAAG,CAAC,CAAC,CAAC;IAC1C,+DAA+D;IAC/D,+DAA+D;IAC/D,sBAAsB;IACtB,IAAI,OAAO,CAAC,IAAI,CAAC,QAAQ,CAAC,EAAE,CAAC;QAC3B,0DAA0D;QAC1D,MAAM,UAAU,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,EAAE,QAAQ,CAAC,CAAC;QAC3C,MAAM,QAAQ,GAAG,UAAU,CAAC,WAAW,CAAC,GAAG,CAAC,CAAC;QAC7C,IAAI,QAAQ,GAAG,CAAC,EAAE,CAAC;YACjB,MAAM,SAAS,GAAG,GAAG,UAAU,CAAC,KAAK,CAAC,QAAQ,GAAG,CAAC,CAAC,IAAI,QAAQ,EAAE,CAAC;YAClE,IAAI,YAAY,CAAC,IAAI,CAAC,SAAS,CAAC,EAAE,CAAC;gBACjC,OAAO,EAAE,SAAS,EAAE,UAAU,CAAC,KAAK,CAAC,CAAC,EAAE,QAAQ,CAAC,EAAE,QAAQ,EAAE,SAAS,EAAE,CAAC;YAC3E,CAAC;QACH,CAAC;IACH,CAAC;IACD,gEAAgE;IAChE,OAAO,EAAE,SAAS,EAAE,QAAQ,EAAE,CAAC;AACjC,CAAC;AAED;;;;;;GAMG;AACH,MAAM,UAAU,oBAAoB,CAAC,MAAc;IACjD,MAAM,CAAC,GAAG,CAAC,MAAM,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC;IAC9C,OAAO,CAAC,KAAK,yBAAyB,CAAC,WAAW,EAAE,IAAI,CAAC,KAAK,cAAc,IAAI,CAAC,KAAK,KAAK,CAAC;AAC9F,CAAC;AAED,SAAS,YAAY,CAAC,CAAiB;IACrC,OAAO,GAAG,CAAC,CAAC,SAAS,KAAK,CAAC,CAAC,QAAQ,EAAE,CAAC;AACzC,CAAC"}

package/dist/cli/backend/src/services/orchestrator/improvement-marker.service.d.ts

@@ -0,0 +1,231 @@
+/**
+ * Improvement Marker Service
+ *
+ * Manages a persistent marker file that tracks self-improvement
+ * state across process restarts (including hot-reload).
+ *
+ * @module services/orchestrator/improvement-marker
+ */
+/**
+ * Improvement phases
+ */
+export type ImprovementPhase = 'planning' | 'backing_up' | 'changes_applied' | 'validating' | 'rolling_back' | 'rolled_back' | 'complete';
+/**
+ * File backup record
+ */
+export interface FileBackupRecord {
+    originalPath: string;
+    backupPath: string;
+    checksum: string;
+    existed: boolean;
+}
+/**
+ * Validation result
+ */
+export interface ValidationResult {
+    check: string;
+    passed: boolean;
+    output?: string;
+    duration?: number;
+}
+/**
+ * Improvement marker data
+ */
+export interface ImprovementMarker {
+    /** Unique improvement ID */
+    id: string;
+    /** Human-readable description */
+    description: string;
+    /** When improvement started */
+    startedAt: string;
+    /** Current phase */
+    phase: ImprovementPhase;
+    /** Number of times process has restarted during this improvement */
+    restartCount: number;
+    /** Last phase transition timestamp */
+    lastUpdatedAt: string;
+    /** Target files being modified */
+    targetFiles: string[];
+    /** Backup information */
+    backup: {
+        gitCommit?: string;
+        gitBranch?: string;
+        files: FileBackupRecord[];
+        createdAt: string;
+    };
+    /** Planned changes */
+    changes: Array<{
+        file: string;
+        type: 'create' | 'modify' | 'delete';
+        description: string;
+        applied: boolean;
+    }>;
+    /** Validation configuration and results */
+    validation: {
+        required: string[];
+        results: ValidationResult[];
+        startedAt?: string;
+        completedAt?: string;
+    };
+    /** Rollback information */
+    rollback?: {
+        reason: string;
+        startedAt: string;
+        completedAt?: string;
+        filesRestored: string[];
+        gitReset?: boolean;
+    };
+    /** Slack notification context */
+    slack?: {
+        channelId: string;
+        threadTs: string;
+        userId: string;
+    };
+    /** Error information if failed */
+    error?: {
+        message: string;
+        phase: ImprovementPhase;
+        timestamp: string;
+        stack?: string;
+    };
+}
+/**
+ * ImprovementMarkerService class
+ *
+ * Manages persistent markers for tracking self-improvement state across restarts.
+ */
+export declare class ImprovementMarkerService {
+    private markerPath;
+    private historyPath;
+    /**
+     * Creates an instance of ImprovementMarkerService.
+     *
+     * @param baseDir - Optional base directory for marker files
+     */
+    constructor(baseDir?: string);
+    /**
+     * Initialize the marker service by creating necessary directories.
+     */
+    initialize(): Promise<void>;
+    /**
+     * Check if there's a pending improvement.
+     *
+     * @returns True if a pending improvement marker exists
+     */
+    hasPendingImprovement(): Promise<boolean>;
+    /**
+     * Get the pending improvement marker.
+     *
+     * @returns The improvement marker or null if none exists
+     */
+    getPendingImprovement(): Promise<ImprovementMarker | null>;
+    /**
+     * Create a new improvement marker.
+     *
+     * @param id - Unique improvement ID
+     * @param description - Human-readable description
+     * @param targetFiles - Files to be modified
+     * @param slackContext - Optional Slack notification context
+     * @returns The created improvement marker
+     */
+    createMarker(id: string, description: string, targetFiles: string[], slackContext?: {
+        channelId: string;
+        threadTs: string;
+        userId: string;
+    }): Promise<ImprovementMarker>;
+    /**
+     * Update marker phase.
+     *
+     * @param phase - New phase to set
+     * @returns Updated marker or null if no pending marker
+     */
+    updatePhase(phase: ImprovementPhase): Promise<ImprovementMarker | null>;
+    /**
+     * Increment restart count (called on each startup).
+     *
+     * @returns New restart count
+     */
+    incrementRestartCount(): Promise<number>;
+    /**
+     * Record backup information.
+     *
+     * @param gitCommit - Git commit hash for checkpoint
+     * @param gitBranch - Git branch name
+     * @param files - File backup records
+     */
+    recordBackup(gitCommit: string | undefined, gitBranch: string | undefined, files: FileBackupRecord[]): Promise<void>;
+    /**
+     * Record that changes have been applied.
+     *
+     * @param changes - Array of applied changes
+     */
+    recordChangesApplied(changes: Array<{
+        file: string;
+        type: 'create' | 'modify' | 'delete';
+        description: string;
+    }>): Promise<void>;
+    /**
+     * Record validation result.
+     *
+     * @param result - Validation result to record
+     */
+    recordValidationResult(result: ValidationResult): Promise<void>;
+    /**
+     * Record rollback started.
+     *
+     * @param reason - Reason for rollback
+     */
+    recordRollbackStarted(reason: string): Promise<void>;
+    /**
+     * Record rollback completed.
+     *
+     * @param filesRestored - List of restored file paths
+     * @param gitReset - Whether git reset was used
+     */
+    recordRollbackCompleted(filesRestored: string[], gitReset: boolean): Promise<void>;
+    /**
+     * Record error information.
+     *
+     * @param message - Error message
+     * @param stack - Optional stack trace
+     */
+    recordError(message: string, stack?: string): Promise<void>;
+    /**
+     * Complete the improvement (move to history).
+     *
+     * @param success - Whether the improvement was successful
+     */
+    completeImprovement(success: boolean): Promise<void>;
+    /**
+     * Delete marker without saving to history (for cancelled improvements).
+     */
+    deleteMarker(): Promise<void>;
+    /**
+     * Save marker to disk atomically.
+     *
+     * @param marker - Marker to save
+     */
+    private saveMarker;
+    /**
+     * Cleanup old history files to maintain max limit.
+     */
+    private cleanupHistory;
+    /**
+     * Get improvement history.
+     *
+     * @param limit - Maximum number of history items to return
+     * @returns Array of historical improvement markers
+     */
+    getHistory(limit?: number): Promise<ImprovementMarker[]>;
+}
+/**
+ * Get singleton instance of ImprovementMarkerService.
+ *
+ * @returns The singleton ImprovementMarkerService instance
+ */
+export declare function getImprovementMarkerService(): ImprovementMarkerService;
+/**
+ * Reset singleton instance (for testing).
+ */
+export declare function resetImprovementMarkerService(): void;
+//# sourceMappingURL=improvement-marker.service.d.ts.map

package/dist/cli/backend/src/services/orchestrator/improvement-marker.service.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"improvement-marker.service.d.ts","sourceRoot":"","sources":["../../../../../../backend/src/services/orchestrator/improvement-marker.service.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAMH;;GAEG;AACH,MAAM,MAAM,gBAAgB,GACxB,UAAU,GACV,YAAY,GACZ,iBAAiB,GACjB,YAAY,GACZ,cAAc,GACd,aAAa,GACb,UAAU,CAAC;AAEf;;GAEG;AACH,MAAM,WAAW,gBAAgB;IAC/B,YAAY,EAAE,MAAM,CAAC;IACrB,UAAU,EAAE,MAAM,CAAC;IACnB,QAAQ,EAAE,MAAM,CAAC;IACjB,OAAO,EAAE,OAAO,CAAC;CAClB;AAED;;GAEG;AACH,MAAM,WAAW,gBAAgB;IAC/B,KAAK,EAAE,MAAM,CAAC;IACd,MAAM,EAAE,OAAO,CAAC;IAChB,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,QAAQ,CAAC,EAAE,MAAM,CAAC;CACnB;AAED;;GAEG;AACH,MAAM,WAAW,iBAAiB;IAChC,4BAA4B;IAC5B,EAAE,EAAE,MAAM,CAAC;IACX,iCAAiC;IACjC,WAAW,EAAE,MAAM,CAAC;IACpB,+BAA+B;IAC/B,SAAS,EAAE,MAAM,CAAC;IAClB,oBAAoB;IACpB,KAAK,EAAE,gBAAgB,CAAC;IACxB,oEAAoE;IACpE,YAAY,EAAE,MAAM,CAAC;IACrB,sCAAsC;IACtC,aAAa,EAAE,MAAM,CAAC;IAEtB,kCAAkC;IAClC,WAAW,EAAE,MAAM,EAAE,CAAC;IAEtB,yBAAyB;IACzB,MAAM,EAAE;QACN,SAAS,CAAC,EAAE,MAAM,CAAC;QACnB,SAAS,CAAC,EAAE,MAAM,CAAC;QACnB,KAAK,EAAE,gBAAgB,EAAE,CAAC;QAC1B,SAAS,EAAE,MAAM,CAAC;KACnB,CAAC;IAEF,sBAAsB;IACtB,OAAO,EAAE,KAAK,CAAC;QACb,IAAI,EAAE,MAAM,CAAC;QACb,IAAI,EAAE,QAAQ,GAAG,QAAQ,GAAG,QAAQ,CAAC;QACrC,WAAW,EAAE,MAAM,CAAC;QACpB,OAAO,EAAE,OAAO,CAAC;KAClB,CAAC,CAAC;IAEH,2CAA2C;IAC3C,UAAU,EAAE;QACV,QAAQ,EAAE,MAAM,EAAE,CAAC;QACnB,OAAO,EAAE,gBAAgB,EAAE,CAAC;QAC5B,SAAS,CAAC,EAAE,MAAM,CAAC;QACnB,WAAW,CAAC,EAAE,MAAM,CAAC;KACtB,CAAC;IAEF,2BAA2B;IAC3B,QAAQ,CAAC,EAAE;QACT,MAAM,EAAE,MAAM,CAAC;QACf,SAAS,EAAE,MAAM,CAAC;QAClB,WAAW,CAAC,EAAE,MAAM,CAAC;QACrB,aAAa,EAAE,MAAM,EAAE,CAAC;QACxB,QAAQ,CAAC,EAAE,OAAO,CAAC;KACpB,CAAC;IAEF,iCAAiC;IACjC,KAAK,CAAC,EAAE;QACN,SAAS,EAAE,MAAM,CAAC;QAClB,QAAQ,EAAE,MAAM,CAAC;QACjB,MAAM,EAAE,MAAM,CAAC;KAChB,CAAC;IAEF,kCAAkC;IAClC,KAAK,CAAC,EAAE;QACN,OAAO,EAAE,MAAM,CAAC;QAChB,KAAK,EAAE,gBAAgB,CAAC;QACxB,SAAS,EAAE,MAAM,CAAC;QAClB,KAAK,CAAC,EAAE,MAAM,CAAC;KAChB,CAAC;CACH;AAmBD;;;;GAIG;AACH,qBAAa,wBAAwB;IACnC,OAAO,CAAC,UAAU,CAAS;IAC3B,OAAO,CAAC,WAAW,CAAS;IAE5B;;;;OAIG;gBACS,OAAO,CAAC,EAAE,MAAM;IAM5B;;OAEG;IACG,UAAU,IAAI,OAAO,CAAC,IAAI,CAAC;IAKjC;;;;OAIG;IACG,qBAAqB,IAAI,OAAO,CAAC,OAAO,CAAC;IAS/C;;;;OAIG;IACG,qBAAqB,IAAI,OAAO,CAAC,iBAAiB,GAAG,IAAI,CAAC;IAahE;;;;;;;;OAQG;IACG,YAAY,CAChB,EAAE,EAAE,MAAM,EACV,WAAW,EAAE,MAAM,EACnB,WAAW,EAAE,MAAM,EAAE,EACrB,YAAY,CAAC,EAAE;QAAE,SAAS,EAAE,MAAM,CAAC;QAAC,QAAQ,EAAE,MAAM,CAAC;QAAC,MAAM,EAAE,MAAM,CAAA;KAAE,GACrE,OAAO,CAAC,iBAAiB,CAAC;IAyB7B;;;;;OAKG;IACG,WAAW,CAAC,KAAK,EAAE,gBAAgB,GAAG,OAAO,CAAC,iBAAiB,GAAG,IAAI,CAAC;IAW7E;;;;OAIG;IACG,qBAAqB,IAAI,OAAO,CAAC,MAAM,CAAC;IAW9C;;;;;;OAMG;IACG,YAAY,CAChB,SAAS,EAAE,MAAM,GAAG,SAAS,EAC7B,SAAS,EAAE,MAAM,GAAG,SAAS,EAC7B,KAAK,EAAE,gBAAgB,EAAE,GACxB,OAAO,CAAC,IAAI,CAAC;IAgBhB;;;;OAIG;IACG,oBAAoB,CACxB,OAAO,EAAE,KAAK,CAAC;QAAE,IAAI,EAAE,MAAM,CAAC;QAAC,IAAI,EAAE,QAAQ,GAAG,QAAQ,GAAG,QAAQ,CAAC;QAAC,WAAW,EAAE,MAAM,CAAA;KAAE,CAAC,GAC1F,OAAO,CAAC,IAAI,CAAC;IAWhB;;;;OAIG;IACG,sBAAsB,CAAC,MAAM,EAAE,gBAAgB,GAAG,OAAO,CAAC,IAAI,CAAC;IAerE;;;;OAIG;IACG,qBAAqB,CAAC,MAAM,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC;IAe1D;;;;;OAKG;IACG,uBAAuB,CAAC,aAAa,EAAE,MAAM,EAAE,EAAE,QAAQ,EAAE,OAAO,GAAG,OAAO,CAAC,IAAI,CAAC;IAaxF;;;;;OAKG;IACG,WAAW,CAAC,OAAO,EAAE,MAAM,EAAE,KAAK,CAAC,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC;IAejE;;;;OAIG;IACG,mBAAmB,CAAC,OAAO,EAAE,OAAO,GAAG,OAAO,CAAC,IAAI,CAAC;IAsB1D;;OAEG;IACG,YAAY,IAAI,OAAO,CAAC,IAAI,CAAC;IAUnC;;;;OAIG;YACW,UAAU;IAMxB;;OAEG;YACW,cAAc;IAa5B;;;;;OAKG;IACG,UAAU,CAAC,KAAK,GAAE,MAAW,GAAG,OAAO,CAAC,iBAAiB,EAAE,CAAC;CAgBnE;AAOD;;;;GAIG;AACH,wBAAgB,2BAA2B,IAAI,wBAAwB,CAKtE;AAED;;GAEG;AACH,wBAAgB,6BAA6B,IAAI,IAAI,CAEpD"}