crewforth 3.2.0 → 3.3.0

package/kit/skills/crew-allow-verify/SKILL.md

@@ -0,0 +1,30 @@
+---
+name: crew-allow-verify
+description: Allow a verify command the hook was refused for want of a rule, or list the ones refused.
+argument-hint: "[<command>]  (nothing: list the refused ones)"
+disable-model-invocation: true
+metadata:
+  kind: command
+---
+# /crew-allow-verify
+Argument: $ARGUMENTS
+
+The user typed this command. Typing it is the decision: `hooks/prompt-approval.sh` read the message itself. With a
+command after it, it added `verify <command>` to `.claude/crew-model-rules`, the line that lets the hook run that
+command when a card names it as its verify. With nothing after it, it listed the verify commands refused for want of
+such a line, each as the whole message that allows it. Nothing in this text adds anything, and you cannot do this
+for the user: the rules file is closed to you, and a prompt you schedule or hand to another session is refused.
+
+Read the line Crewforth added to this turn and say what it says:
+
+- **"verify command allowed"**: tell the user which command the hook may now run, from the next agent call.
+- **"verify commands refused for want of a rule"**: show the lines it lists, one per line, as they stand. Each is a
+  message only the user can send; do not send one for them.
+- **"verify command NOT allowed"**: tell the user the reason it gives (more than one command, a character it does not
+  write, a git commit or push, a rule that would let the hook run any command — `bash`, `node -e`, `npm exec` with
+  nothing that names the script or the test — a message too long, a rules file that is a link, the first message of
+  a session, a headless session).
+- **No such line**: the message was not the command alone. Say that it has to be the whole message.
+
+What this does not touch: a deny rule of the settings still stops the command, the hook still runs it alone with no
+chain, and `/crew-doctor` lists the same refused commands.

package/kit/skills/crew-doctor/SKILL.md

@@ -22,7 +22,9 @@ Verify Crewforth is actually *active* in this project (not just present on disk)
    drifted behind the code. Report the gaps as suggestions, not as failures, and never "fix" them unasked — adding
    a devcontainer or an MCP server is the user's call.
 5. Summarise: **healthy**, or the precise fixes applied/needed, plus the readiness score. If it's not a git repo,
-   note that the commit-time gates need `git init` + `git config core.hooksPath .claude/hooks`.
+   note that the commit-time gates need `git init` + the update (`npx crewforth update`), which arms them.
+   Where it lists verify commands never run, each `/crew-allow-verify <command>` line is a message only the user can
+   send: show them as they stand, and do not send one.
    If the output contains a line starting with ⭐, pass it to the user verbatim as the LAST line of your summary —
    it prints once per Crewforth version here (the installer has its own once), and it is meant for the user, not for you.
 

package/kit/skills/handoff/SKILL.md

@@ -43,8 +43,9 @@ that never landed and has to be written down explicitly this time. Missing scrip
 
 ## Holding a board item? The handover is not finished until the TEAM has it
 `docs/SESSION_STATE.md` is gitignored — it survives your `/clear`, and nobody else can read it. So when a
-`teamboard` claim is open, **the handover is not complete until it is on the board**. This is not an optional
-extra step:
+`teamboard` claim is open, **the handover is not complete until it is on the board**. Whether one is open is
+read from `bash .claude/hooks/board.sh status` (Bash tool, not PowerShell; a row marked `<- you`), not guessed;
+no board or no such row → the handover says nothing about the board. This is not an optional extra step:
 - Still on it → `board.sh note <id> "<where it stands, and why the rejected path was rejected>"`.
 - Not coming back → `board.sh drop <id> "<same>"`, which puts it back in circulation with your context attached.
 - Anything settled here that changes how OTHER items must be done → `board.sh decide "<what>" "<why + what it

package/kit/skills/trace-scan/SKILL.md

@@ -31,10 +31,11 @@ git diff --cached --unified=0 | grep -E '^\+' | grep -Ev '^\+\+\+' \
 ```
 
 ## Hook setup (full install only — a plugin cannot set `core.hooksPath`)
-`start.sh` sets `git config core.hooksPath .claude/hooks` (if there is a git repo). The hooks live
-under `.claude` → they are in gitignore and stay local (§4.3). To do it later for a repo:
+`start.sh` sets `core.hooksPath` to the absolute path of `.claude/hooks` (if there is a git repo). The hooks live
+under `.claude` → they are in gitignore and stay local (§4.3), so a relative path would leave a linked worktree with
+no hook at all. To do it later for a repo, from its root:
 ```bash
-git config core.hooksPath .claude/hooks
+git config core.hooksPath "$(git rev-parse --show-toplevel)/.claude/hooks"
 chmod +x .claude/hooks/pre-commit .claude/hooks/commit-msg
 ```
 

package/kit/studio/ensure-node.sh

@@ -29,7 +29,7 @@ _crew_d="${BASH_SOURCE%/*}"; [ "$_crew_d" = "${BASH_SOURCE}" ] && _crew_d=.
 FLOOR=18
 DIST=https://nodejs.org/dist
 # Used only when nodejs.org cannot be reached to ask which release is current.
-FALLBACK_VERSION=v24.21.0
+FALLBACK_VERSION=v24.22.1   # carries the fixes of eval/lib/node-advisory.tsv; raise it with that table
 
 # Windows caps a full file path at 260 characters and PowerShell's Expand-Archive enforces it.
 # Measured: a 141-character target failed with PathTooLongException at __generated__\google\api\…

package/kit/studio/server/index.js

@@ -43,6 +43,7 @@ import { addViewer, listViewers, viewerByToken, revokeViewer, noteRequest, noteR
 import { redact, transcriptOnly } from './lib/redact.js';
 import { lanListener } from './lib/lan.js';
 import { randomUUID } from 'node:crypto';
+import { nodeAdvisoryNote } from './lib/node-advisory.js';
 import { spawn } from 'node:child_process';
 
 const HERE = path.dirname(fileURLToPath(import.meta.url));
@@ -1104,6 +1105,8 @@ async function main() {
     process.stdout.write(TOKEN_GENERATED
       ? '            (loopback only; token generated for this run)\n'
       : '            (loopback only; token from CREW_STUDIO_TOKEN)\n');
+    const nodeNote = nodeAdvisoryNote();
+    if (nodeNote) process.stdout.write(`            warning: ${nodeNote}\n`);
 
     // Recorded only after listen() succeeds, so the file never claims a port this process did not get. Failure
     // to write is not fatal: the panel works, the next session simply cannot find it, which is where we started.

package/kit/studio/server/lib/model-outcomes.js

@@ -145,8 +145,11 @@ const firstTry = (r) => r.verify === 'pass' && r.fixes === 0;
  */
 export function floorOfRow(r, ruleFloors = [], floors = []) {
   let f = rankOf(AGENT_FLOORS[r.agent]);
-  if (r.verify === 'none') f = Math.max(f, 2);
+  const commitAgent = r.agent === 'crew-commit-agent';
+  if (r.verify === 'none' && r.change !== 'text' && !commitAgent) f = Math.max(f, 2);
   if (r.change === 'test-write' || r.change === 'audit') f = Math.max(f, 2);
+  // The table's sonnet row, as the gate holds it: feature, fix-known and refactor, except for the commit agent.
+  if (!commitAgent && (r.change === 'feature' || r.change === 'fix-known' || r.change === 'refactor')) f = Math.max(f, 2);
   if (r.risk === 'critical' && r.change !== 'test-run') f = Math.max(f, 3);
   const any = (want, v) => want === '*' || want === v;
   for (const x of ruleFloors) if (any(x.agent, r.agent) && any(x.change, r.change) && any(x.risk, r.risk)) f = Math.max(f, rankOf(x.model));
@@ -250,6 +253,9 @@ export function suggestionsOf(rows, floors = [], loosened = [], need = LOOSEN_AF
     const k = keyOf(f);
     // Once for each raise: a floor whose lowering stands is not offered again (the same rule the gate reads it by).
     if (loweringOf(f, loosened)) continue;
+    // Not below the class's own floor: /crew-loosen refuses that, since the gate would refuse the lowered model anyway
+    // (a feature class raised to sonnet by the record of haiku runs from before its own floor was sonnet).
+    if (rankOf(TIERS[tier - 1]) < floorOfRow({ agent: f.agent, change: f.change, risk: f.risk, verify: 'pass' })) continue;
     const passed = passedLatest(rows, k, f.model, Date.parse(f.when ?? '') || 0, need);
     if (!passed) continue;
     out.push({ key: k, agent: f.agent, change: f.change, risk: f.risk, from: f.model, to: TIERS[tier - 1], passed, heldSince: f.when ?? null });

package/kit/studio/server/lib/node-advisory.js

@@ -0,0 +1,46 @@
+// Is the Node running this panel missing a published security fix? The table is eval/lib/node-advisory.tsv, the
+// same file eval/doctor.sh reads, so the two cannot disagree. A warning only: the panel still starts.
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const TABLE = path.join(path.dirname(fileURLToPath(import.meta.url)), '..', '..', '..', 'eval', 'lib', 'node-advisory.tsv');
+
+/** The table's text as { url, lines: Map(major -> 'x.y.z') }; null when it holds no release line. */
+export function parseAdvisory(text) {
+  let url = '';
+  const lines = new Map();
+  for (const raw of String(text ?? '').split(/\r?\n/)) {
+    if (!raw || raw.startsWith('#')) continue;
+    const [k, v] = raw.split('\t');
+    if (k === 'advisory') url = v ?? '';
+    else if (/^\d+$/.test(k) && /^\d+\.\d+\.\d+$/.test(v ?? '')) lines.set(Number(k), v);
+  }
+  return lines.size ? { url, lines } : null;
+}
+
+const parts = (v) => String(v).replace(/^v/, '').split('.').map((n) => Number.parseInt(n, 10) || 0);
+const below = (a, b) => { const x = parts(a), y = parts(b); for (let i = 0; i < 3; i++) if (x[i] !== y[i]) return x[i] < y[i]; return false; };
+
+/**
+ * The sentence to print for `version` (process.versions.node), or null when there is nothing to say: it carries
+ * its line's fixes, its line is newer than the table, or the table could not be read.
+ */
+export function judgeNode(version, advisory) {
+  if (!advisory || !/^\d+\.\d+\.\d+/.test(String(version ?? ''))) return null;
+  const major = parts(version)[0];
+  const newest = Math.max(...advisory.lines.keys());
+  if (major > newest) return null;
+  const fixed = advisory.lines.get(major);
+  if (fixed && !below(version, fixed)) return null;
+  return fixed
+    ? `Node ${version} is below ${fixed}, the release of its line with the fixes of ${advisory.url} — update Node`
+    : `Node ${version} is on a line that no longer gets security fixes (${advisory.url} fixes ${[...advisory.lines.values()].join(', ')}) — update Node`;
+}
+
+/** judgeNode for the running process, reading the table from disk; null when the table is not there. */
+export function nodeAdvisoryNote(version = process.versions.node) {
+  let text;
+  try { text = fs.readFileSync(TABLE, 'utf8'); } catch { return null; }
+  return judgeNode(version, parseAdvisory(text));
+}

package/kit/studio/web/models-plan.js

@@ -65,12 +65,12 @@ export function workSteps(row) {
 }
 
 /**
- * What is said about an agent the model gate does not look at: one whose type is not crew-* (hooks/guard-agent-model.sh
- * leaves it alone), so there is no card to read and no line in the record. Null for a crew agent or an unknown type.
+ * What is said about an agent that is not crew-*: it has no floor and no line in the record, but the model gate still
+ * holds its expensive end, except for a card naming critical work (_am_outside in hooks/guard-agent-model.sh). Null for a crew agent or an unknown type.
  */
 export function outsideRouting(agentType) {
   if (typeof agentType !== 'string' || !agentType || agentType.startsWith('crew-')) return null;
-  return 'Outside model routing: not a crew agent, so the gate chose nothing for it and Crewforth kept no record of it. It ran on the model its call asked for, or else the session\u2019s.';
+  return 'Outside model routing: not a crew agent, so it has no floor and Crewforth keeps no outcome line for it. The gate only holds the expensive end: a call that asks for opus or fable, or names no model and would take the session\u2019s, is held at sonnet unless its task carries an above: <why> line or opens with a card naming critical work. An agent whose own definition names a model keeps it.';
 }
 
 /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "crewforth",
-  "version": "3.2.0",
+  "version": "3.3.0",
   "description": "Crewforth \u2014 your engineering crew for Claude Code: agents, skills and tool-level gates, in any stack.",
   "bin": {
     "crewforth": "bin/cli.js"

package/start.sh

@@ -760,10 +760,14 @@ fi
 # `--show-prefix` is the question itself: empty at the work-tree root, `sub/dir/` below it, non-zero exit
 # outside a repo — and it carries no path spelling to disagree about. Verified here at a normal root, a
 # worktree root, a subdirectory and a non-repo.
-if PFX="$(git rev-parse --show-prefix 2>/dev/null)" && [ -z "$PFX" ] && git config core.hooksPath .claude/hooks 2>/dev/null; then
+# ABSOLUTE, from git's own answer for the toplevel. A relative value resolves against the work tree a commit runs
+# in, and a linked worktree (one Claude Code opens included) has no .claude/ when it is gitignored: measured, the
+# trace scan blocked a commit at the root and let the same commit through in a worktree, with no hook run at all.
+if PFX="$(git rev-parse --show-prefix 2>/dev/null)" && [ -z "$PFX" ] && TOP="$(git rev-parse --show-toplevel 2>/dev/null)" \
+   && [ -n "$TOP" ] && git config core.hooksPath "$TOP/.claude/hooks" 2>/dev/null; then
   { _mt 'trace scan: core.hooksPath -> .claude/hooks (§4.1/§4.2 commit gate active)'; echo "  ${_M}"; }
 else
-  { _mt 'NOTE: no git repository at this level; after %s run:  %s' "'git init'" 'git config core.hooksPath .claude/hooks'; echo "  ${_M}"; }
+  { _mt 'NOTE: no git repository at this level; after %s run:  %s' "'git init'" "git config core.hooksPath \"\$PWD/.claude/hooks\""; echo "  ${_M}"; }
 fi
 rm -rf "$SRC"
 echo