crewforth 3.2.0 → 3.3.0

package/kit/eval/lib/verify-cmd.sh

@@ -15,3 +15,75 @@ crew_verify_split(){  # $1 = the command, $2 = the project root -> _AMVD the fol
   [ -n "$r" ] && [ -d "$root/$d" ] || return 0
   _AMVD="$d"; _AMVC="$r"
 }
+
+# The verify commands the hook was refused for want of a rule, read from the record of results: one definition, for
+# doctor, which lists them, and for /crew-allow-verify (hooks/prompt-approval.sh), which adds the one the user names.
+# Two lists, one entry per line: a command (the one a `verify <command>` line would allow, without its cd), and a line
+# that is no command at all: a parenthesis or ` + `, or a first word that is no path, no assignment and nothing this
+# machine runs ("measured numbers"). A command a `verify` line of crew-model-rules already allows is left out: it was
+# refused before the user allowed it. Each is counted every time it was refused, and listed once.
+crew_verify_blocked(){  # $1 = project root -> _VB_N _VB_CMDS, _VB_PN _VB_SENT (lists end in a newline)
+  local root="${1:-.}" f l vb vw vc v1 vs nl='
+' allowed=""
+  _VB_N=0; _VB_CMDS=""; _VB_PN=0; _VB_SENT=""
+  if [ -f "$root/.claude/crew-model-rules" ]; then
+    while IFS= read -r l || [ -n "$l" ]; do l="${l%$'\r'}"; case "$l" in 'verify '*) allowed="$allowed${l#verify }$nl" ;; esac; done < "$root/.claude/crew-model-rules"
+  fi
+  for f in "$root"/.claude/state/crew-model/results/*; do
+    [ -f "$f" ] || continue
+    vb=0; vw=""; vc=""
+    while IFS= read -r l || [ -n "$l" ]; do
+      case "$l" in verify=blocked) vb=1 ;; whynot=*) vw="${l#whynot=}" ;; cmd=*) vc="${l#cmd=}" ;; esac
+    done < "$f"
+    [ "$vb" = 1 ] || continue
+    # Both ways of saying "nothing allows it": in auto/bypassPermissions (not on the runner list) and in the other
+    # modes (Claude Code itself would not run it unallowed). Measured on Windows: the second was not listed at all.
+    case "$vw" in *"not a test or build command on this hook's list"*|*"does not run a command the user has not allowed"*) ;; *) continue ;; esac
+    # A rule names the command alone: `cd sub && ./check.sh` is allowed by `verify ./check.sh` (measured on Windows:
+    # the line with the cd in it did not allow it).
+    crew_verify_split "$vc" "$root"; vc="$_AMVC"
+    [ -n "$vc" ] || continue
+    case "$nl$allowed" in *"$nl$vc$nl"*) continue ;; esac
+    v1="${vc%% *}"; vs=0
+    case "$vc" in *'('*|*' + '*) vs=1 ;; esac
+    case "$v1" in */*|*=*) ;; *) command -v -- "$v1" >/dev/null 2>&1 || vs=1 ;; esac
+    # A rule that would allow any command is not offered at all (see crew_verify_open_ended below).
+    [ "$vs" = 0 ] && declare -F crew_verify_open_ended >/dev/null && crew_verify_open_ended "$vc" && continue
+    if [ "$vs" = 1 ]; then
+      # Whole for a command (a rule cut short allows nothing); a sentence is shortened, at a word.
+      [ "${#vc}" -gt 80 ] && { vc="${vc:0:80}"; vc="${vc% *} …"; }
+      _VB_PN=$((_VB_PN+1)); case "$nl$_VB_SENT" in *"$nl$vc$nl"*) ;; *) _VB_SENT="$_VB_SENT$vc$nl" ;; esac
+    else
+      _VB_N=$((_VB_N+1)); case "$nl$_VB_CMDS" in *"$nl$vc$nl"*) ;; *) _VB_CMDS="$_VB_CMDS$vc$nl" ;; esac
+    fi
+  done
+  return 0
+}
+
+# A rule that would let the hook run ANY command. A `verify` rule allows its command and the same command with more
+# words after it (guard-agent-model.sh `_am_starts`), so `verify bash` allows `bash evil.sh` and `verify node -e`
+# allows any script (found in review). Such a rule is neither offered nor written by /crew-allow-verify: an
+# interpreter, a shell, a wrapper that runs what follows it, or a package runner that fetches what it runs, when
+# nothing after it names the file or the task, or when what follows is an option (`bash -c`, `node -e`).
+crew_verify_open_ended(){  # $1 = command -> 0 when the rule would allow any command
+  local c="$1" w1 w2 w3 rest
+  # Leading assignments and `env` decide nothing about what runs: `env FOO=1 python3` is `python3` (found in review).
+  while :; do
+    w1="${c%% *}"
+    case "$w1" in env|*/env) [ "$c" = "$w1" ] && return 0; c="${c#"$w1" }" ;; [A-Za-z_]*=*) [ "$c" = "$w1" ] && return 0; c="${c#"$w1" }" ;; *) break ;; esac
+  done
+  rest="${c#"$w1"}"; rest="${rest# }"; w2="${rest%% *}"; rest="${rest#"$w2"}"; rest="${rest# }"; w3="${rest%% *}"
+  case "${w1##*/}" in
+    python|python2|python3)
+      [ -z "$w2" ] && return 0
+      # `python3 -m pytest` names the module it runs; `-c`, `-` or a bare `-m` do not.
+      case "$w2" in -m) [ -z "$w3" ] && return 0; case "$w3" in -*) return 0 ;; esac; return 1 ;; -*) return 0 ;; esac ;;
+    bash|sh|zsh|dash|ksh|fish|pwsh|powershell|cmd|xargs|sudo|doas|nice|nohup|timeout|command|exec|eval|time|watch|node|deno|bun|ruby|perl|php|lua|osascript|npx|pnpx|bunx|curl|wget|rm|git|make|ssh|docker|kubectl)
+      [ -z "$w2" ] && return 0
+      case "$w2" in -*) return 0 ;; esac ;;
+    npm|pnpm|yarn)
+      [ -z "$w2" ] && return 0
+      case "$w2" in -*|exec|x|dlx|install|i|add|ci|create|init) return 0 ;; esac ;;
+  esac
+  return 1
+}