create-agent-rig 0.5.0 → 0.6.0

package/templates/agent-os/universal/.claude/scripts/lib/verdict.mjs

@@ -70,7 +70,9 @@
  *    one.** A caller that read absence as "the head I am holding" would take a
  *    verdict about a diff nobody named as a verdict about the diff it is about
  *    to merge, so a caller that needs the answer keyed to a commit handles
- *    absence itself.
+ *    absence itself — `lib/gate-coverage.mjs` is the one that does, and it puts
+ *    such a verdict in its own list rather than counting it either way. When
+ *    present the value is a commit SHAPE, not free text: see `isCommitId`.
  */
 
 /** Every word any gate in this rulebook may return. */
@@ -166,11 +168,14 @@ const DIAGNOSIS_LIMIT = 120;
  * worst they buy is a misread within those backticks. Escape sequences are the ones
  * that rewrite the operator's screen, and those are what this removes.
  *
- * ⚠ **The CLI's own argv is not passed through it.** The report's path and the
- * subcommand are printed exactly as the caller wrote them, because their whole job
- * is to be pasted back into a command; the expected-gate argument IS sanitised,
- * because it is printed beside a reviewer-written gate as one of two names the
- * operator compares, and a value that can repaint that comparison defeats it.
+ * ⚠ **Two of the CLI's own arguments are passed through it, and two are not.**
+ * The report's path and the subcommand are printed exactly as the caller wrote
+ * them, because their whole job is to be pasted back into a command. The
+ * expected-gate argument IS sanitised, because it is printed beside a
+ * reviewer-written gate as one of two names the operator compares, and a value
+ * that can repaint that comparison defeats it. So is `coverage`'s commit
+ * argument, which is printed beside journal-written reviewer names for the same
+ * reason.
  *
  * It never throws — it is called only where something has already gone wrong, and a
  * sanitiser that throws there turns a diagnosis into a crash the caller reads as
@@ -210,6 +215,29 @@ const isPlainObject = (value) =>
 
 const isText = (value) => typeof value === 'string' && value.trim() !== '';
 
+/**
+ * A commit id, checked as a SHAPE rather than as text (AR-79).
+ *
+ * `headSha` arrived as "any non-blank text". **No consumer interpolates it
+ * today** — the only reader compares it as a string (`lib/gate-coverage.mjs`),
+ * and the merge criterion takes its SHA from `gh pr view --json headRefOid`, not
+ * from a verdict. The shape is fixed here so that the first consumer that does
+ * put it in an argument position inherits the check instead of having to
+ * remember it; `--upload-pack=…`, a leading `-` and `../…` are not commits, and
+ * a field that only ever holds commits is the cheap way to keep them out.
+ *
+ * ⚠ **This covers the value inside a verdict block, and nothing else.**
+ * `run-journal.mjs` takes `headSha` on a decision record as any non-blank
+ * string, and `pr-ship`'s fan-out record reaches it without passing through
+ * `parseVerdict` at all — so a commit id that never came from a reviewer's block
+ * is not shaped by this.
+ *
+ * **Checked on the raw value — never trimmed, never lowercased.** A value that
+ * needs rewriting to pass is a value the reviewer did not write, and rewriting it
+ * silently is how a near-miss becomes a match.
+ */
+export const isCommitId = (value) => typeof value === 'string' && /^[0-9a-f]{7,64}$/i.test(value);
+
 /**
  * The last fenced ```json block, as one of three answers: `{ raw }` for a block
  * whose extent is unambiguous, `{ ambiguous: true }` for one carrying a fence of
@@ -398,10 +426,11 @@ export function parseVerdict(text) {
   }
 
   const headSha = parsed.headSha;
-  if (headSha !== undefined && !isText(headSha)) {
+  if (headSha !== undefined && !isCommitId(headSha)) {
     problems.push(
       `\`headSha\` is \`${safeForDiagnosis(headSha)}\`, which is not a commit this verdict ` +
-        'could have answered for. It is optional, and a line of text when present.',
+        'could have answered for. It is optional, and 7 to 64 hex characters (0-9a-f) when ' +
+        'present — nothing else, and with no surrounding space.',
     );
   }
 

package/templates/agent-os/universal/.claude/scripts/preflight.mjs

@@ -11,7 +11,7 @@
 // reason it is safe to script half a checklist. The honest objection to a partial
 // script — "a script that half-checks is worse than a list the run actually
 // reads" — is true exactly while the boundary is invisible. A silent script would
-// let a GO on three items read as a pass on six.
+// let a GO on four items read as a pass on seven.
 //
 // 🔴 **`unknown` never becomes `pass`.** A probe that could not run tells you
 // nothing, and "I could not look" recorded as "it is fine" is the failure this
@@ -95,6 +95,31 @@ export const checkDefaultBranchFresh = () => {
   }
 };
 
+/**
+ * `RIG_RUN_DIR` must not already be exported when preflight runs (AR-139).
+ *
+ * Preflight walks BEFORE this run declares its directory (`loop` §1), so a
+ * value already in the environment is a leak — an `export` that outlived an
+ * earlier run, or a shell that inherited one. Everything the run then spawns
+ * inherits it too: the queue CLI under test, the gate scripts, and the real
+ * run's append-only trace receives their fixture records. Measured at 38
+ * fixture selections and 22 fixture revalidation events, plus two tests
+ * exiting 1 and blamed on load. A hard failure, because starting on it puts
+ * this run's stops in somebody else's file.
+ */
+export const checkRunDirNotExported = (env = process.env) => {
+  const value = env.RIG_RUN_DIR;
+  return value
+    ? {
+        ok: false,
+        detail:
+          `RIG_RUN_DIR is already exported (${value}) — a leak from an earlier run. ` +
+          '`unset RIG_RUN_DIR`, then declare this run\'s own directory; an inherited ' +
+          "one lands this run's trace and stop conditions in somebody else's file",
+      }
+    : { ok: true, detail: 'not exported' };
+};
+
 /** The last deploy must have concluded successfully — never start on a broken runtime. */
 export const checkLastDeploy = ({ workflow = 'deploy' } = {}) => {
   try {
@@ -172,6 +197,7 @@ const invokedDirectly = () => {
 if (invokedDirectly()) {
   const checks = {
     killSwitch: checkKillSwitch(),
+    runDirNotExported: checkRunDirNotExported(),
     defaultBranchFresh: checkDefaultBranchFresh(),
     lastDeploy: checkLastDeploy(),
   };

package/templates/agent-os/universal/.claude/scripts/queue/as-of.mjs

@@ -0,0 +1,51 @@
+// The two git questions a proposal's `asOf` needs answered (AR-116):
+// which commit is HEAD, and what changed between a commit and HEAD.
+//
+// Kept out of `core.mjs`, which is pure, and out of the adapters, which would
+// otherwise each spawn git their own way. Both answers are `null` when git
+// cannot answer — no checkout, an unknown commit, a shallow clone — and
+// `overtakenOf` in core.mjs turns that `null` into an "unanswerable" finding
+// rather than a clean one.
+
+import { execFileSync } from 'node:child_process';
+import { dirname, join } from 'node:path';
+import { fileURLToPath } from 'node:url';
+import { withoutGitLocation } from '../git-env.mjs';
+
+const git = (args, cwd) =>
+  execFileSync('git', args, {
+    cwd,
+    encoding: 'utf8',
+    stdio: ['ignore', 'pipe', 'ignore'],
+    env: withoutGitLocation(),
+  }).trim();
+
+/** HEAD of the checkout at `cwd`, or null where there is none. */
+export const headShaOf = ({ cwd = process.cwd() } = {}) => {
+  try {
+    const sha = git(['rev-parse', 'HEAD'], cwd);
+    return /^[0-9a-f]{40}$/.test(sha) ? sha : null;
+  } catch {
+    return null;
+  }
+};
+
+/** Paths changed between `asOf` and `head`, or null when git cannot say. */
+export const changedSinceOf = ({ cwd = process.cwd(), asOf, head = 'HEAD' } = {}) => {
+  if (typeof asOf !== 'string' || !/^[0-9a-f]{7,40}$/.test(asOf)) return null;
+  try {
+    return git(['diff', '--name-only', '-z', asOf, head], cwd).split('\0').filter(Boolean);
+  } catch {
+    return null;
+  }
+};
+
+/**
+ * The commit a proposal is measured against: what the caller says, or HEAD of
+ * the project this script belongs to. `null` files without one — and hygiene
+ * then reports the proposal as unanswerable rather than current. One
+ * implementation for all three adapters, so they cannot answer differently.
+ */
+const PROJECT_ROOT = join(dirname(fileURLToPath(import.meta.url)), '..', '..', '..');
+export const withAsOf = (proposal) =>
+  proposal.asOf === undefined ? { ...proposal, asOf: headShaOf({ cwd: PROJECT_ROOT }) } : proposal;

package/templates/agent-os/universal/.claude/scripts/queue/checkout.mjs

@@ -14,7 +14,7 @@
  */
 
 import { execFileSync } from 'node:child_process';
-import { dirname } from 'node:path';
+import { dirname, resolve } from 'node:path';
 
 // The sanitiser is IMPORTED, never re-derived. This repo had already ruled on
 // which git variables to strip, exported the answer with its stated limit, and
@@ -76,7 +76,9 @@ export const mainCheckoutRoot = (startDir) => {
         env: { ...withoutGitLocation(), LC_ALL: 'C', LANGUAGE: '' },
       },
     ).trim();
-    return gitDir ? dirname(gitDir) : startDir;
+    // `resolve`, because git answers with forward slashes on Windows
+    // (`C:/Users/...`) and every caller compares against a native path.
+    return gitDir ? resolve(dirname(gitDir)) : startDir;
   } catch (error) {
     if (error?.code === 'ENOENT') return startDir; // git is not installed
     const stderr = String(error?.stderr ?? '');
@@ -87,3 +89,61 @@ export const mainCheckoutRoot = (startDir) => {
     );
   }
 };
+
+/**
+ * Is this checkout in a state a gate round may be counted against (AR-141)?
+ *
+ * A round is counted per branch and the fan-out's verdicts name a head. On one
+ * branch two rounds were counted before a commit that pre-commit then refused,
+ * so the counter and the records named a head that never shipped. The three
+ * states that make a head unshippable are decidable from git alone: a dirty
+ * working tree (tracked or untracked), a branch with no upstream, and commits
+ * the upstream has not seen. `{ ok: true }` otherwise; a git that cannot answer
+ * is reported as such, never as clean.
+ *
+ * Bounded: two git calls, each with a timeout, and the porcelain output is
+ * read only for emptiness. The upstream question has one catch for three
+ * states — a detached HEAD, a branch with no upstream, an upstream that is
+ * gone — and names none of them apart; the refusal is right for all three.
+ */
+export const checkoutIsShippable = (root) => {
+  const git = (args) =>
+    execFileSync('git', args, {
+      cwd: root,
+      encoding: 'utf8',
+      stdio: ['ignore', 'pipe', 'ignore'],
+      env: withoutGitLocation(),
+      timeout: 30_000,
+    }).trim();
+  let status;
+  try {
+    status = git(['status', '--porcelain']);
+  } catch (error) {
+    return { ok: false, why: `git could not read the working tree at ${root}: ${error.message}` };
+  }
+  if (status !== '') {
+    return {
+      ok: false,
+      why: 'the working tree is dirty — a round counted now would name a head that has not ' +
+        'been committed; commit (and push) first',
+    };
+  }
+  let ahead;
+  try {
+    ahead = git(['rev-list', '--count', '@{upstream}..HEAD']);
+  } catch {
+    return {
+      ok: false,
+      why: 'HEAD has no upstream — push the branch first, so the round names a head the ' +
+        'reviewers and CI can see',
+    };
+  }
+  if (ahead !== '0') {
+    return {
+      ok: false,
+      why: `HEAD is ${ahead} commit(s) ahead of its upstream — push first, so the round names ` +
+        'the head that ships',
+    };
+  }
+  return { ok: true };
+};