create-agent-rig 0.5.0 → 0.6.0

package/templates/agent-os/universal/.claude/scripts/doctor.mjs

@@ -0,0 +1,351 @@
+#!/usr/bin/env node
+// doctor — the harness audits itself (AR-5).
+//
+//   node .claude/scripts/doctor.mjs                 # the report, ready to paste
+//   node .claude/scripts/doctor.mjs --root <dir>    # audit another checkout
+//   node .claude/scripts/doctor.mjs --json
+//
+// One question, asked of every hook this project runs: **does the hook the
+// project OWNS have a test beside it?** The three-part pattern in
+// `.claude/rules/invariants.md` — a stated rule, a mechanical check, a test for
+// the check — is decoration with any part missing, and the part a rig loses
+// first is the third: the shipped hooks arrive with their tests in the generator
+// that produced them, and the moment one is edited its test is the rig's own.
+//
+// Ownership is read from `.claude/.rig-manifest.json`, the install manifest the
+// generator writes (its `files` map is install-relative path → sha256 of the
+// bytes it wrote). It is evidence, and three answers come out of it:
+//
+//   - `shipped`  — the bytes on disk still hash to the manifest's entry: the
+//                  hook is the generator's, tested upstream. Not a finding.
+//   - `owned`    — the hash differs, or the manifest has no entry for the file:
+//                  authored or edited here, so its test is this project's.
+//   - `unknown`  — there is no manifest to read (a pre-0.4.0 rig, or the
+//                  generator's own checkout). A hook with a test beside it still
+//                  passes — the test is there whoever owns it; one without is
+//                  reported `unknown`, never as a pass: "could not look" is not
+//                  "it is fine".
+//
+// The manifest is the only ownership source this script reads. The generator's
+// CLI also carries a hash history of every release for manifest-less rigs; it
+// lives in the CLI, and a rig script that re-implemented it would be a second
+// copy of a table nobody here maintains (`invariants.md`, "one mechanism, one
+// implementation"). A rig without a manifest gets `unknown` on every untested
+// hook and the advice to run `upgrade`, which writes one.
+//
+// A test neighbour is `<hook>.test.mjs` in the same directory — the shape
+// `.claude/skills/new-invariant/guard-invariant.example.test.mjs` prescribes and
+// `node --test` runs. Exemptions are an explicit file list with reasons, in
+// `.claude/doctor-exemptions.json` (`{ "<rel path>": "<reason>" }`): an exempt
+// hook is reported as `exempt` with its reason, an exemption with no reason is a
+// finding, and an exemption naming a file that is not there is a finding too —
+// a list that outlives what it exempts is how a check goes quiet by accident.
+//
+// Scope: every `.mjs` directly in `.claude/hooks/` (not `*.test.mjs`, not
+// `lib/`), and EVERY file directly in `.husky/` when that directory exists — a
+// husky hook is never in the manifest, so it is `owned` whenever ownership can
+// be read at all, and a stray file there (a README, a dotfile) is audited like a
+// hook — the generator's `test/template/doctor.test.ts` › "audits every file in
+// .husky/ as a hook — a stray README there is a finding until it is exempted
+// with a reason" pins it: exempt it with a reason rather than teaching this
+// script which names are not hooks. One entry that cannot be stat'ed (a
+// dangling symlink) is reported by name and the rest of the listing survives —
+// › "a dangling symlink among the hooks is reported by name as unreadable, and
+// never nulls the listing". A `.claude/hooks/` that is missing or unreadable is a FAIL and the
+// run is STOP — a doctor that looked nowhere must never say clean — and so is
+// an exemption file that is present but not readable JSON. When `.husky/` is absent the report says so rather than
+// staying silent about a directory it never looked at — the generator's
+// `test/template/doctor.test.ts` › "names an absent .husky/ instead of staying
+// silent about it" pins the line.
+//
+// 🔴 What this script does NOT check is printed at the end of every report, the
+// same way `preflight.mjs` prints its unchecked items: a script that half-checks
+// is only safe while the boundary is visible.
+import { createHash } from 'node:crypto';
+import { existsSync, readdirSync, readFileSync, realpathSync, statSync } from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+export const MANIFEST_REL = '.claude/.rig-manifest.json';
+export const EXEMPTIONS_REL = '.claude/doctor-exemptions.json';
+export const HOOKS_DIR = '.claude/hooks';
+export const HUSKY_DIR = '.husky';
+
+/** What this script cannot decide from the file system alone. */
+export const UNCHECKED = [
+  'that the neighbour test exercises the hook it sits beside — a file named ' +
+    '`<hook>.test.mjs` that asserts nothing satisfies this check; run `node --test` on it',
+  'that the hook is wired in .claude/settings.json (or .codex/hooks.json) — an ' +
+    'unwired hook passes its own test and guards nothing',
+  'that a `shipped` hook still matches the rule it enforces — the manifest says ' +
+    'the bytes are the generator’s, not that the generator’s rule is this project’s',
+];
+
+export const sha256 = (data) => createHash('sha256').update(data).digest('hex');
+
+/**
+ * Who owns a hook, from the manifest's evidence.
+ *
+ * `recorded` is the manifest's hash for the file, `undefined` when the manifest
+ * has no entry, and `null` when there is no manifest at all — three inputs that
+ * must stay three, because collapsing "no entry" into "no manifest" would read
+ * an authored hook as unknowable, and the reverse would read a manifest-less
+ * rig's every hook as authored here.
+ */
+export const ownershipOf = ({ recorded, actual }) => {
+  if (recorded === null) return 'unknown';
+  if (typeof recorded === 'string' && recorded === actual) return 'shipped';
+  return 'owned';
+};
+
+/** The test neighbour's path: `guard-x.mjs` → `guard-x.test.mjs`, `pre-commit` → `pre-commit.test.mjs`. */
+export const neighbourOf = (rel) => {
+  const dir = path.posix.dirname(rel);
+  const base = path.posix.basename(rel);
+  const stem = base.endsWith('.mjs') ? base.slice(0, -'.mjs'.length) : base;
+  return path.posix.join(dir, `${stem}.test.mjs`);
+};
+
+/** The same ladder `preflight.mjs` uses: any FAIL stops, any unknown cautions. */
+export const verdictOf = (marks) => {
+  if (marks.some((mark) => mark === 'FAIL')) return 'STOP';
+  if (marks.some((mark) => mark === 'unknown')) return 'CAUTION';
+  return 'GO';
+};
+
+/**
+ * Control bytes stripped before a string from a repo file reaches the terminal
+ * (the same concern `queue/core.mjs` › printable has): an exemption reason
+ * carrying an escape sequence could repaint the line above it. Printable
+ * Unicode stays — a reason is prose.
+ */
+// eslint-disable-next-line no-control-regex -- the control range IS the subject of this regex
+export const printable = (text) => String(text).replace(/[\x00-\x1F\x7F-\x9F]/g, '');
+
+const reasonOf = (exemptions, rel) => {
+  if (!exemptions || typeof exemptions !== 'object' || Array.isArray(exemptions)) return undefined;
+  return Object.prototype.hasOwnProperty.call(exemptions, rel) ? exemptions[rel] : undefined;
+};
+
+/**
+ * The audit, pure: hooks in, marks out. Each hook is `{ rel, ownership,
+ * hasTest }`; each result adds `mark` (`pass` | `FAIL` | `unknown` | `exempt`)
+ * and a `detail` a reader can act on.
+ *
+ * Bounded by construction: one pass over the hooks, one over the exemptions.
+ */
+export const auditHooks = ({ hooks = [], exemptions = {} } = {}) => {
+  const seen = new Set();
+  const results = [];
+  for (const hook of hooks) {
+    const { rel, ownership, hasTest } = hook;
+    seen.add(rel);
+    const reason = reasonOf(exemptions, rel);
+    const exempt = reason !== undefined;
+    let mark;
+    let detail;
+    if (exempt && (typeof reason !== 'string' || reason.trim() === '')) {
+      mark = 'FAIL';
+      detail = `exempted without a reason in ${EXEMPTIONS_REL} — an exemption is a file AND why`;
+    } else if (hasTest) {
+      mark = 'pass';
+      detail =
+        ownership === 'shipped'
+          ? `test neighbour ${neighbourOf(rel)} (and the generator’s upstream tests)`
+          : `test neighbour ${neighbourOf(rel)}`;
+    } else if (ownership === 'shipped') {
+      mark = 'pass';
+      detail = 'unchanged since install — tested upstream, in the generator that produced it';
+    } else if (exempt) {
+      mark = 'exempt';
+      detail = `no test neighbour; exempt — ${printable(reason.trim())}`;
+    } else if (ownership === 'owned') {
+      mark = 'FAIL';
+      detail =
+        `owned here (${'edited or authored in this project'}) and no ${neighbourOf(rel)} — ` +
+        'copy .claude/skills/new-invariant/guard-invariant.example.test.mjs beside it';
+    } else {
+      mark = 'unknown';
+      detail =
+        `no ${MANIFEST_REL} to say who owns it, and no ${neighbourOf(rel)} — ` +
+        'not a pass; `upgrade` writes a manifest, or add the test';
+    }
+    results.push({ rel, ownership, hasTest, mark, detail });
+  }
+  if (exemptions && typeof exemptions === 'object' && !Array.isArray(exemptions)) {
+    for (const rel of Object.keys(exemptions)) {
+      if (seen.has(rel)) continue;
+      results.push({
+        rel: printable(rel),
+        ownership: 'absent',
+        hasTest: false,
+        mark: 'FAIL',
+        detail: `stale-exemption: ${EXEMPTIONS_REL} names a file this audit did not find — remove the entry`,
+      });
+    }
+  }
+  return { verdict: verdictOf(results.map((r) => r.mark)), hooks: results };
+};
+
+// --- the file-system half -----------------------------------------------------
+
+const readJson = (file) => {
+  try {
+    return JSON.parse(readFileSync(file, 'utf8'));
+  } catch {
+    return null;
+  }
+};
+
+/** The manifest's `files` map, or `null` when there is nothing trustworthy to read. */
+export const manifestFilesOf = (root) => {
+  const parsed = readJson(path.join(root, ...MANIFEST_REL.split('/')));
+  const files = parsed?.files;
+  if (!files || typeof files !== 'object' || Array.isArray(files)) return null;
+  return files;
+};
+
+/**
+ * The files directly in `dir`: `{ names, unreadable }`, or `null` when the
+ * directory itself cannot be listed. One entry that cannot be stat'ed (a dangling
+ * symlink) is reported by name, never allowed to null the whole listing.
+ */
+const listFiles = (dir) => {
+  let entries;
+  try {
+    entries = readdirSync(dir).sort();
+  } catch {
+    return null;
+  }
+  const names = [];
+  const unreadable = [];
+  for (const name of entries) {
+    try {
+      if (statSync(path.join(dir, name)).isFile()) names.push(name);
+    } catch {
+      unreadable.push(name);
+    }
+  }
+  return { names, unreadable };
+};
+
+/** A finding the audit itself raises — a scope it could not read. */
+const problem = (rel, detail) => ({ rel, ownership: 'absent', hasTest: false, mark: 'FAIL', detail });
+
+/** Every hook in scope, as `{ rel, ownership, hasTest }`, plus the scopes it looked at. */
+export const collectHooks = (root) => {
+  const files = manifestFilesOf(root);
+  const hooks = [];
+  const scopes = [];
+  const problems = [];
+  const hookDir = listFiles(path.join(root, ...HOOKS_DIR.split('/')));
+  scopes.push({ dir: HOOKS_DIR, present: hookDir !== null });
+  if (hookDir === null) {
+    // Not a rig, or not the directory the caller meant: never a clean report.
+    problems.push(problem(HOOKS_DIR, `not found or unreadable under ${root} — nothing was audited`));
+  }
+  for (const name of hookDir?.names ?? []) {
+    if (!name.endsWith('.mjs') || name.endsWith('.test.mjs')) continue;
+    hooks.push(`${HOOKS_DIR}/${name}`);
+  }
+  const husky = listFiles(path.join(root, HUSKY_DIR));
+  scopes.push({ dir: HUSKY_DIR, present: husky !== null });
+  for (const name of husky?.names ?? []) {
+    if (name.endsWith('.test.mjs')) continue;
+    hooks.push(`${HUSKY_DIR}/${name}`);
+  }
+  for (const [dir, listing] of [
+    [HOOKS_DIR, hookDir],
+    [HUSKY_DIR, husky],
+  ]) {
+    for (const name of listing?.unreadable ?? []) {
+      problems.push(problem(`${dir}/${printable(name)}`, 'cannot be read (a dangling symlink?) — not audited, not a pass'));
+    }
+  }
+  return {
+    scopes,
+    problems,
+    hooks: hooks.map((rel) => {
+      const actual = sha256(readFileSync(path.join(root, ...rel.split('/'))));
+      const recorded = files === null ? null : files[rel];
+      return {
+        rel,
+        ownership: ownershipOf({ recorded, actual }),
+        hasTest: existsSync(path.join(root, ...neighbourOf(rel).split('/'))),
+      };
+    }),
+  };
+};
+
+export const report = (root) => {
+  const { hooks, scopes, problems } = collectHooks(root);
+  // One read, two outcomes: absent is an empty list, present-but-unreadable is a
+  // finding. Testing for existence first and reading second would be two truths.
+  let exemptions = {};
+  let raw = null;
+  try {
+    raw = readFileSync(path.join(root, ...EXEMPTIONS_REL.split('/')), 'utf8');
+  } catch (error) {
+    if (error?.code !== 'ENOENT') {
+      problems.push(problem(EXEMPTIONS_REL, `present but unreadable — ${error?.code ?? 'read failed'}`));
+    }
+  }
+  if (raw !== null) {
+    let parsed;
+    try {
+      parsed = JSON.parse(raw);
+    } catch {
+      parsed = null;
+    }
+    if (parsed && typeof parsed === 'object' && !Array.isArray(parsed)) exemptions = parsed;
+    else problems.push(problem(EXEMPTIONS_REL, 'present but unreadable — not JSON, or not an object of path → reason'));
+  }
+  const audited = auditHooks({ hooks, exemptions });
+  const all = [...problems, ...audited.hooks];
+  const audit = { verdict: verdictOf(all.map((r) => r.mark)), hooks: all };
+  const absent = scopes.filter((scope) => !scope.present && scope.dir !== HOOKS_DIR).map((scope) => scope.dir);
+  const lines = [
+    `**doctor** — verdict: ${audit.verdict}`,
+    '',
+    // Names come from the file system, reasons from a repo file; both are
+    // stripped of control bytes here, once, where they reach the terminal.
+    ...audit.hooks.map((hook) => `- ${hook.mark} · ${printable(hook.rel)} — ${printable(hook.detail)}`),
+    ...(absent.length > 0
+      ? ['', `_Not present, so not audited: ${absent.join(', ')}._`]
+      : []),
+    '',
+    `_Not checked by this script — still yours (${UNCHECKED.length}):_`,
+    ...UNCHECKED.map((item) => `- ${item}`),
+  ];
+  return { ...audit, scopes, unchecked: UNCHECKED, rendered: lines.join('\n') };
+};
+
+const invokedDirectly = () => {
+  if (!process.argv[1]) return false;
+  const real = (p) => {
+    try {
+      return realpathSync(p);
+    } catch {
+      return p;
+    }
+  };
+  return real(fileURLToPath(import.meta.url)) === real(process.argv[1]);
+};
+
+if (invokedDirectly()) {
+  const args = process.argv.slice(2);
+  const rootIndex = args.indexOf('--root');
+  const rootArg = rootIndex === -1 ? null : args[rootIndex + 1];
+  if (rootIndex !== -1 && (rootArg === undefined || rootArg.startsWith('--'))) {
+    process.stderr.write('doctor: --root needs a directory — auditing the working directory instead would be a guess\n');
+    process.exit(1);
+  }
+  const root = path.resolve(rootArg ?? process.cwd());
+  const result = report(root);
+  process.stdout.write(
+    args.includes('--json')
+      ? `${JSON.stringify({ verdict: result.verdict, hooks: result.hooks, scopes: result.scopes, unchecked: result.unchecked }, null, 2)}\n`
+      : `${result.rendered}\n`,
+  );
+  process.exit(result.verdict === 'STOP' ? 1 : 0);
+}

package/templates/agent-os/universal/.claude/scripts/lib/gate-coverage.mjs

@@ -0,0 +1,306 @@
+/**
+ * Gate coverage — did every reviewer this round asked for actually answer, and
+ * for the commit being merged?
+ *
+ * Three writers already record the three halves of a gate round, and until this
+ * module existed nothing compared them:
+ *
+ *   - `decision-router.mjs` journals the set the route ASKED FOR, on the lane it
+ *     actually took (`gate: "review-routing:<lane>"`, with `reviewers`);
+ *   - `pr-ship` journals the set it actually LAUNCHED, with the head it launched
+ *     against (`gate: "reviewer-fan-out"`);
+ *   - each verdict that PARSED is journalled under the reviewer's own name.
+ *
+ * The two failures that hide in the gap between them both end in a merge that
+ * reads as fully gated: a reviewer the router named and nobody started, and a
+ * reviewer that answered — about a commit two pushes ago.
+ *
+ * 🔴 **A verdict that names no commit is not coverage of this one.** `headSha` is
+ * optional in the schema — every report written before it existed omits one — and
+ * reading absence as "it must have meant the head I am holding" is the inference
+ * the schema's own limit 6 forbids. It gets its own list rather than a pass.
+ *
+ * 🔴 **No fan-out record is not a clean round.** A run whose journal records no
+ * fan-out has not been shown to be covered, it has been shown to be unreadable —
+ * and four empty lists are exactly what a clean round looks like. That case
+ * answers `ok: false` and says why in `reason`. A missing fan-out, a missing route,
+ * an unconsumed route, a fan-out missing its head commit, and a fan-out for a different head
+ * commit are the unreadable-round answers; each reason names the evidence boundary the journal
+ * could not establish.
+ *
+ * 🔴 **A round is judged against its OWN route, not the run's last one.** The
+ * answers are scoped to the records after the last fan-out; the route needs the
+ * mirror of that, and not having it made the refusal above vacuous in the case it
+ * was written for. A run directory spans several rounds and several PRs, so an
+ * earlier round's route would otherwise satisfy a later round that journalled
+ * none — and its *set* would be inherited too, which after a `deterministic` lane
+ * means `neverLaunched` is empty for the rest of the run whatever the route asked
+ * for. So the route that counts is the last one carrying `reviewers` **between the
+ * previous fan-out and the last one**: the route that produced the fan-out being
+ * judged.
+ *
+ * 🔴 **An unconsumed route after the last fan-out is an unreadable boundary.**
+ * The journal cannot say whether this round's fan-out record is missing or the
+ * router was re-run after a completed fan-out. Both readings refuse coverage;
+ * re-running the fan-out for this head records the boundary either one needs.
+ */
+
+/** The gate name `pr-ship` writes its fan-out under. */
+const FAN_OUT = 'reviewer-fan-out';
+
+/** Every lane the router reports on shares this prefix; only the taken one carries a set. */
+const ROUTING = 'review-routing:';
+
+const gateOf = (record) => (typeof record?.gate === 'string' ? record.gate : '');
+
+/**
+ * The reviewer names in a journalled set.
+ *
+ * `recordDecision` checks for a list of strings and nothing about what a name
+ * is, so a blank one is dropped here rather than reported as a reviewer nobody
+ * can launch.
+ */
+const namesOf = (value) =>
+  Array.isArray(value) ? value.filter((name) => typeof name === 'string' && name.trim() !== '') : [];
+
+/** Order-preserving, because the output is read by a human looking for a name. */
+const uniq = (names) => [...new Set(names)];
+
+/**
+ * The shortest commit id the verdict schema accepts, and the floor a prefix
+ * match needs to be worth anything (`lib/verdict.mjs`, `isCommitId`).
+ */
+const SHORTEST_COMMIT = 7;
+
+/**
+ * The lengths a COMPLETE commit id has: sha-1 and sha-256.
+ *
+ * An abbreviation resolves against a complete id and nothing else. Without this,
+ * any strict extension of a full id prefix-matched it — a 50-character value
+ * built by appending to a 40-character commit was counted as coverage of that
+ * commit, and it passes the schema (7–64 hex), so it arrives through the fully
+ * validated path rather than as obvious junk.
+ */
+const COMPLETE_COMMIT_LENGTHS = new Set([40, 64]);
+
+/**
+ * Are these two ids the same commit?
+ *
+ * 🔴 **Not string equality, and the difference is a false HOLD.** The schema
+ * accepts an abbreviated id, so a reviewer may answer `b4e3ef0` about the commit
+ * `git rev-parse HEAD` prints in full — the same commit, written shorter. Exact
+ * comparison reports that as answered-for-another-commit and holds the merge on
+ * honest work, which is the way a guard loses the room.
+ *
+ * So: equal ids match, and otherwise the shorter must be a prefix of a
+ * **complete** one, case-insensitively — the way git resolves an abbreviation.
+ * Two bounds, each closing one direction:
+ *
+ * - **the floor.** Both must reach `SHORTEST_COMMIT`. A shorter value is one the
+ *   verdict schema refuses, and stretching it into a match would let a value
+ *   nothing accepted decide that a gate was covered. ⚠ The journal is the other
+ *   way in and it does not apply that schema (`run-journal.mjs` takes `headSha`
+ *   as any non-blank string), so this floor is enforced here on its own account,
+ *   not on the strength of an upstream check.
+ * - **the ceiling.** The longer must be a complete id. An abbreviation resolves
+ *   against a whole commit; a value that merely *extends* one is not that commit
+ *   written shorter, and counting it as coverage fails in the unsafe direction.
+ *
+ * One case is decided rather than left ambiguous: a 40-character value that
+ * prefixes a 64-character one matches, because the longer is complete. It could
+ * be a sha-256 abbreviated to 40 or a sha-1 with characters appended, and nothing
+ * here can resolve which — a pure function has no repository to ask. The first
+ * reading is the one an honest run produces.
+ */
+const sameCommit = (one, other) => {
+  if (one.length < SHORTEST_COMMIT || other.length < SHORTEST_COMMIT) return false;
+  const first = one.toLowerCase();
+  const second = other.toLowerCase();
+  if (first === second) return true;
+  const [shorter, longer] = first.length <= second.length ? [first, second] : [second, first];
+  if (!COMPLETE_COMMIT_LENGTHS.has(longer.length)) return false;
+  return longer.startsWith(shorter);
+};
+
+/**
+ * Which reviewers are outstanding for `headSha`, and in which of the four ways.
+ *
+ * @param {{ records?: unknown, headSha?: unknown }} input
+ *   `records` is `readRun(...).decisions` — the run's decision journal, in
+ *   journal order. `headSha` is the commit the round is about.
+ * @returns {{
+ *   ok: boolean, routed: string[], launched: string[],
+ *   neverLaunched: string[], unanswered: string[],
+ *   unattributed: string[], stale: string[], reason?: string,
+ * }}
+ */
+export const coverageOf = ({ records, headSha } = {}) => {
+  const journal = Array.isArray(records) ? records : [];
+  const target = typeof headSha === 'string' ? headSha : '';
+
+  // One forward pass, keeping the LAST of each: a branch gets a second gate
+  // round after fixes, and the round's whole question is whether THIS round's
+  // reviewers answered. An earlier fan-out answers about a round already over.
+  //
+  // `pendingRoute` is what makes the route round-scoped: a routing record is held
+  // until a fan-out consumes it, and each fan-out takes only what was journalled
+  // since the previous one. Nothing survives a fan-out, so no round can inherit
+  // the round before it.
+  let pendingRoute = null;
+  let routeOfRound = null;
+  let fanOutAt = -1;
+  let launchedNames = [];
+  let fanOutHead = null;
+
+  for (let index = 0; index < journal.length; index += 1) {
+    const record = journal[index];
+    const gate = gateOf(record);
+    // Only the taken lane carries a set; a declined lane's line has no
+    // `reviewers` key at all, and reading one off it would compare the answers
+    // against a lane nobody took.
+    if (gate.startsWith(ROUTING) && Array.isArray(record?.reviewers)) {
+      // A set was RECORDED, which is a different fact from the set being empty.
+      // The `deterministic` lane legitimately routes nobody; a round that never
+      // journalled a route knows nothing about who should have been launched.
+      pendingRoute = namesOf(record.reviewers);
+    }
+    if (gate === FAN_OUT) {
+      fanOutAt = index;
+      launchedNames = namesOf(record?.reviewers);
+      fanOutHead = typeof record?.headSha === 'string' ? record.headSha : null;
+      routeOfRound = pendingRoute;
+      pendingRoute = null;
+    }
+  }
+
+  if (pendingRoute !== null) {
+    return {
+      ok: false,
+      routed: uniq(pendingRoute),
+      launched: [],
+      neverLaunched: [],
+      unanswered: [],
+      unattributed: [],
+      stale: [],
+      reason:
+        'a routed reviewer set was journalled after the last fan-out, so the round ' +
+        'boundary is unreadable: either this round\'s fan-out record is missing, or the ' +
+        'router ran again after the fan-out. Rerun the fan-out step for this head so ' +
+        'the round it belongs to has a record.',
+    };
+  }
+
+  const routeRecorded = routeOfRound !== null;
+  const routedNames = routeOfRound ?? [];
+
+  const routed = uniq(routedNames);
+
+  if (fanOutAt === -1) {
+    return {
+      ok: false,
+      routed,
+      launched: [],
+      neverLaunched: [],
+      unanswered: [],
+      unattributed: [],
+      stale: [],
+      reason:
+        'this run journalled no reviewer fan-out, so there is no set to check the verdicts ' +
+        'against. That is not a round with nothing outstanding — it is a round nothing can ' +
+        'read, and the two look identical from the lists alone.',
+    };
+  }
+
+  if (fanOutHead === null) {
+    return {
+      ok: false,
+      routed: [],
+      launched: [],
+      neverLaunched: [],
+      unanswered: [],
+      unattributed: [],
+      stale: [],
+      reason:
+        'the last reviewer fan-out names no head commit, so it cannot be coverage of ' +
+        'this one. Rerun the fan-out step for this head and record the commit it launched.',
+    };
+  }
+
+  if (!sameCommit(fanOutHead, target)) {
+    return {
+      ok: false,
+      routed: [],
+      launched: [],
+      neverLaunched: [],
+      unanswered: [],
+      unattributed: [],
+      stale: [],
+      reason:
+        'the last reviewer fan-out names a different head commit, so its launched set ' +
+        'does not cover this one. Rerun the fan-out step for this head before reading verdicts.',
+    };
+  }
+
+  const launched = uniq(launchedNames);
+  // Answers are the records that come AFTER the fan-out. A verdict from the
+  // previous round is still in the journal, and a reader that scanned the whole
+  // file would find an answer and report the current round covered.
+  const after = journal.slice(fanOutAt + 1);
+
+  // The lane is a floor and never a ceiling — the triggers may only ADD
+  // reviewers — so a launched set larger than the routed one is the ordinary
+  // case and is not a finding. Only the other direction is.
+  const neverLaunched = routed.filter((name) => !launched.includes(name));
+
+  const unanswered = [];
+  const unattributed = [];
+  const stale = [];
+
+  for (const name of launched) {
+    // Matched by gate name, which is what keeps another writer's record — the
+    // router's own line, `pr-ship`'s, a deploy verdict — from being read as a
+    // reviewer's answer.
+    const commits = after
+      .filter((record) => gateOf(record) === name)
+      .map((record) => record?.headSha)
+      .filter((commit) => typeof commit === 'string' && commit !== '');
+
+    const answered = after.some((record) => gateOf(record) === name);
+    if (!answered) {
+      unanswered.push(name);
+    } else if (commits.some((commit) => sameCommit(commit, target))) {
+      // Covered. A HOLD counts here exactly as a SHIP does: coverage is about
+      // who spoke for which commit, never about what they said.
+    } else if (commits.length === 0) {
+      unattributed.push(name);
+    } else {
+      stale.push(name);
+    }
+  }
+
+  const outstanding =
+    neverLaunched.length + unanswered.length + unattributed.length + stale.length;
+
+  return {
+    ok: routeRecorded && outstanding === 0,
+    routed,
+    launched,
+    neverLaunched,
+    unanswered,
+    unattributed,
+    stale,
+    // Unlike the missing fan-out, this one still has a launched set and answers
+    // to compare, so the four lists are computed and returned — the reason says
+    // which half of the check could not run, rather than replacing the half that
+    // could.
+    ...(routeRecorded
+      ? {}
+      : {
+          reason:
+            'this round journalled no routed reviewer set, so `neverLaunched` was compared ' +
+            'against nothing: a reviewer the route asked for and nobody launched would not ' +
+            'appear. An empty route that WAS recorded is a different answer, and so is a ' +
+            'route belonging to an earlier round — neither is this one.',
+        }),
+  };
+};

package/templates/agent-os/universal/.claude/scripts/lib/revalidation-points.mjs

@@ -0,0 +1,28 @@
+/**
+ * The revalidation points — ONE spelling of the fact (AR-137).
+ *
+ * `queue/index.mjs next` writes the SELECT record; `revalidate.mjs` writes the
+ * other two and answers outcomes at all three; `revalidation-report.mjs`
+ * counts all three. Before this module each carried its own list, and one
+ * computed a fourth (`['SELECT', ...POINTS]`). Four spellings of one fact is
+ * how a point gets added to the report and not to the script, silently.
+ *
+ * `REVALIDATES` is DERIVED, not restated: the asymmetry that SELECT is written
+ * elsewhere is encoded here once, where a reader looks for it.
+ *
+ * The prose that names these points is kept in step by a two-direction check —
+ * the generator's test/template/correspondence.test.ts › "every point the
+ * module knows is named by the loop or pr-ship skill, and vice versa".
+ *
+ * Maintenance and noise cost, recorded (AR-137): adding a point touches this
+ * list and the prose that names it as `--point X` or `point: X`, and the check
+ * says which side was forgotten. The check reads only the `loop` and `pr-ship`
+ * skills — a point named anywhere else is invisible to it — and it parses
+ * those two by that exact spelling, so a rewording breaks it loudly, as a named
+ * failure, never silently.
+ */
+
+export const POINTS = Object.freeze(['SELECT', 'BEFORE_PR', 'BEFORE_CLOSE']);
+
+/** What `revalidate.mjs` can revalidate itself: every point but SELECT. */
+export const REVALIDATES = Object.freeze(POINTS.filter((point) => point !== 'SELECT'));