contextos-mcp 0.4.0

package/dist/orchestration/reviewer-gate.js

@@ -0,0 +1,280 @@
+/**
+ * Independent Reviewer Gate (Dual Verdict) & Final Combined Review.
+ *
+ * Implements Superpowers-inspired single-reviewer dual-verdict gate:
+ * - specCompliance: "PASS" | "FAIL"
+ * - codeQuality: "PASS" | "FAIL"
+ *
+ * Enforces Reviewer != Implementer policy and prevents self-approval.
+ */
+import { execFile } from "node:child_process";
+import { randomUUID } from "node:crypto";
+import { promisify } from "node:util";
+import { getAgent, listAgents } from "../agents/provider.js";
+import { assertWithinRepository } from "../security/repository-boundary.js";
+import { isWithinWriteScope } from "../worktree/manager.js";
+import { buildCombinedStagingReviewPrompt, buildReviewerUserPrompt, getReviewerSystemPrompt, } from "./reviewer-prompt.js";
+const execFileAsync = promisify(execFile);
+const LAZY_STUB_PATTERNS = [
+    /\/\/\s*TODO:?\s*(implement|fill in|rest of code)/i,
+    /\/\/\s*\.\.\.\s*rest of code/i,
+    /\/\*\s*\.\.\.\s*rest of code\s*\*\//i,
+    /\/\/\s*implement\s+later/i,
+    /__PLACEHOLDER__/i,
+];
+function containsLazyStubs(diff) {
+    for (const pattern of LAZY_STUB_PATTERNS) {
+        if (pattern.test(diff))
+            return true;
+    }
+    return false;
+}
+function parseVerdictJson(text) {
+    try {
+        const jsonMatch = text.match(/\{[\s\S]*\}/);
+        if (!jsonMatch)
+            return null;
+        const parsed = JSON.parse(jsonMatch[0]);
+        const spec = parsed.specCompliance?.toUpperCase();
+        const quality = parsed.codeQuality?.toUpperCase();
+        if ((spec === "PASS" || spec === "FAIL") && (quality === "PASS" || quality === "FAIL")) {
+            return {
+                specCompliance: spec,
+                codeQuality: quality,
+                summary: typeof parsed.summary === "string" ? parsed.summary : "",
+            };
+        }
+    }
+    catch {
+        // Ignore JSON parse errors
+    }
+    return null;
+}
+/**
+ * Determine a distinct reviewer backend to enforce Reviewer != Implementer.
+ */
+export function resolveReviewerAgent(implementerAgent, requestedReviewer) {
+    if (requestedReviewer && requestedReviewer !== implementerAgent) {
+        return requestedReviewer;
+    }
+    const available = listAgents();
+    const candidates = available.filter((a) => a !== implementerAgent && a !== "mock");
+    if (candidates.length > 0) {
+        return candidates[0];
+    }
+    return "reviewer-independent";
+}
+/**
+ * Evaluates an implementer's changes against the assigned TaskBrief.
+ */
+export async function evaluateReviewerGate(options) {
+    const { taskBrief, diff, filesChanged, verificationVerdict, testOutput, implementerAgent, implementerModel, reviewerAgent: requestedReviewer, reviewerModel, workDir, } = options;
+    const effectiveReviewer = resolveReviewerAgent(implementerAgent, requestedReviewer);
+    const reviewerId = `reviewer-${effectiveReviewer}-${randomUUID().slice(0, 8)}`;
+    // 1. Static Scope Check
+    if (taskBrief.writeScope && taskBrief.writeScope.length > 0) {
+        for (const file of filesChanged) {
+            if (!isWithinWriteScope(file, taskBrief.writeScope)) {
+                return {
+                    reviewerId,
+                    specCompliance: "FAIL",
+                    codeQuality: "FAIL",
+                    summary: `Review failed: touched file "${file}" violates declared writeScope [${taskBrief.writeScope.join(", ")}]`,
+                    reviewedAt: Date.now(),
+                };
+            }
+        }
+    }
+    // 2. Automated Test Verification Check
+    if (verificationVerdict === "FAIL") {
+        return {
+            reviewerId,
+            specCompliance: "FAIL",
+            codeQuality: "FAIL",
+            summary: `Review failed: automated verification test command failed.\n${testOutput || ""}`.trim(),
+            reviewedAt: Date.now(),
+        };
+    }
+    // 3. Static Anti-Slop / Zero-Placeholder Inspection
+    if (containsLazyStubs(diff)) {
+        return {
+            reviewerId,
+            specCompliance: "FAIL",
+            codeQuality: "FAIL",
+            summary: "Review failed: diff contains lazy stub placeholders (e.g. // TODO, ... rest of code stays here)",
+            reviewedAt: Date.now(),
+        };
+    }
+    // 4. Run Reviewer Provider (Fail-closed)
+    let agentProvider = null;
+    try {
+        agentProvider = getAgent(effectiveReviewer);
+    }
+    catch {
+        return {
+            reviewerId,
+            specCompliance: "UNAVAILABLE",
+            codeQuality: "UNAVAILABLE",
+            summary: `Review failed: requested reviewer agent "${effectiveReviewer}" is not registered or available.`,
+            reviewedAt: Date.now(),
+        };
+    }
+    const effectiveWorkDir = workDir || options.repoRoot || process.cwd();
+    try {
+        const systemPrompt = getReviewerSystemPrompt();
+        const userPrompt = buildReviewerUserPrompt({
+            taskBrief,
+            diff,
+            filesChanged,
+            verificationVerdict,
+            testOutput,
+        });
+        const reviewTask = `${systemPrompt}\n\n${userPrompt}`;
+        const result = await agentProvider.run({
+            task: reviewTask,
+            workDir: effectiveWorkDir,
+            model: reviewerModel || implementerModel || "default",
+            signal: AbortSignal.timeout(30000),
+        });
+        if (!result.success) {
+            return {
+                reviewerId,
+                specCompliance: "ERROR",
+                codeQuality: "ERROR",
+                summary: `Review failed: agent execution failed: ${result.error || "unknown error"}`,
+                reviewedAt: Date.now(),
+            };
+        }
+        const parsed = parseVerdictJson(result.output || "");
+        if (parsed?.specCompliance && parsed?.codeQuality) {
+            // Forged PASS prevention (W5.5): static invariants override forged positive verdicts
+            if ((parsed.specCompliance === "PASS" || parsed.codeQuality === "PASS") && containsLazyStubs(diff)) {
+                return {
+                    reviewerId,
+                    specCompliance: "FAIL",
+                    codeQuality: "FAIL",
+                    summary: "Review failed: forged PASS rejected — diff contains forbidden lazy stubs.",
+                    reviewedAt: Date.now(),
+                };
+            }
+            return {
+                reviewerId,
+                specCompliance: parsed.specCompliance,
+                codeQuality: parsed.codeQuality,
+                summary: parsed.summary || "Independent review completed successfully.",
+                reviewedAt: Date.now(),
+            };
+        }
+        return {
+            reviewerId,
+            specCompliance: "MALFORMED",
+            codeQuality: "MALFORMED",
+            summary: "Review failed: reviewer returned malformed or unparseable JSON verdict.",
+            reviewedAt: Date.now(),
+        };
+    }
+    catch (err) {
+        const isTimeout = err?.name === "TimeoutError" || String(err).includes("timeout");
+        return {
+            reviewerId,
+            specCompliance: isTimeout ? "TIMEOUT" : "ERROR",
+            codeQuality: isTimeout ? "TIMEOUT" : "ERROR",
+            summary: `Review failed with ${isTimeout ? "timeout" : "error"}: ${err?.message || String(err)}`,
+            reviewedAt: Date.now(),
+        };
+    }
+}
+/**
+ * Task 2.5f: Final holistic review of combined staging changes before merge to main.
+ */
+export async function reviewCombinedStaging(options) {
+    const { repoRoot, baseSha, stagingBranch, taskSummaries = [], reviewerAgent, reviewerModel } = options;
+    const canonicalRoot = assertWithinRepository(repoRoot, repoRoot);
+    const reviewerId = `combined-reviewer-${reviewerAgent || "audit"}-${randomUUID().slice(0, 8)}`;
+    const effectiveReviewer = resolveReviewerAgent(undefined, reviewerAgent);
+    let agentProvider = null;
+    try {
+        agentProvider = getAgent(effectiveReviewer);
+    }
+    catch {
+        return {
+            reviewerId,
+            specCompliance: "UNAVAILABLE",
+            codeQuality: "UNAVAILABLE",
+            summary: `Combined staging review failed: reviewer agent "${effectiveReviewer}" is not available.`,
+            reviewedAt: Date.now(),
+        };
+    }
+    let combinedDiff = "";
+    try {
+        const { stdout } = await execFileAsync("git", ["diff", `${baseSha}...${stagingBranch}`], {
+            cwd: canonicalRoot,
+            maxBuffer: 10 * 1024 * 1024,
+        });
+        combinedDiff = stdout;
+    }
+    catch (err) {
+        return {
+            reviewerId,
+            specCompliance: "ERROR",
+            codeQuality: "ERROR",
+            summary: `Failed to inspect staging diff: ${err instanceof Error ? err.message : String(err)}`,
+            reviewedAt: Date.now(),
+        };
+    }
+    if (containsLazyStubs(combinedDiff)) {
+        return {
+            reviewerId,
+            specCompliance: "FAIL",
+            codeQuality: "FAIL",
+            summary: "Combined staging diff contains lazy placeholder stubs or uncommitted remnants.",
+            reviewedAt: Date.now(),
+        };
+    }
+    try {
+        const prompt = buildCombinedStagingReviewPrompt(baseSha, stagingBranch, combinedDiff, taskSummaries);
+        const result = await agentProvider.run({
+            task: prompt,
+            workDir: canonicalRoot,
+            model: reviewerModel || "default",
+            signal: AbortSignal.timeout(30000),
+        });
+        if (!result.success) {
+            return {
+                reviewerId,
+                specCompliance: "ERROR",
+                codeQuality: "ERROR",
+                summary: `Combined staging review failed: agent execution error: ${result.error || "unknown error"}`,
+                reviewedAt: Date.now(),
+            };
+        }
+        const parsed = parseVerdictJson(result.output || "");
+        if (parsed?.specCompliance && parsed?.codeQuality) {
+            return {
+                reviewerId,
+                specCompliance: parsed.specCompliance,
+                codeQuality: parsed.codeQuality,
+                summary: parsed.summary || "Combined staging review passed.",
+                reviewedAt: Date.now(),
+            };
+        }
+        return {
+            reviewerId,
+            specCompliance: "MALFORMED",
+            codeQuality: "MALFORMED",
+            summary: "Combined staging review failed: reviewer returned invalid JSON verdict.",
+            reviewedAt: Date.now(),
+        };
+    }
+    catch (err) {
+        const isTimeout = err?.name === "TimeoutError" || String(err).includes("timeout");
+        return {
+            reviewerId,
+            specCompliance: isTimeout ? "TIMEOUT" : "ERROR",
+            codeQuality: isTimeout ? "TIMEOUT" : "ERROR",
+            summary: `Combined staging review failed with ${isTimeout ? "timeout" : "error"}: ${err?.message || String(err)}`,
+            reviewedAt: Date.now(),
+        };
+    }
+}
+//# sourceMappingURL=reviewer-gate.js.map

package/dist/orchestration/reviewer-gate.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"reviewer-gate.js","sourceRoot":"","sources":["../../src/orchestration/reviewer-gate.ts"],"names":[],"mappings":"AAAA;;;;;;;;GAQG;AAEH,OAAO,EAAE,QAAQ,EAAE,MAAM,oBAAoB,CAAC;AAC9C,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAC;AACzC,OAAO,EAAE,SAAS,EAAE,MAAM,WAAW,CAAC;AACtC,OAAO,EAAE,QAAQ,EAAE,UAAU,EAAE,MAAM,uBAAuB,CAAC;AAE7D,OAAO,EAAE,sBAAsB,EAAE,MAAM,oCAAoC,CAAC;AAC5E,OAAO,EAAE,kBAAkB,EAAE,MAAM,wBAAwB,CAAC;AAC5D,OAAO,EACN,gCAAgC,EAChC,uBAAuB,EACvB,uBAAuB,GACvB,MAAM,sBAAsB,CAAC;AAE9B,MAAM,aAAa,GAAG,SAAS,CAAC,QAAQ,CAAC,CAAC;AAyB1C,MAAM,kBAAkB,GAAG;IAC1B,mDAAmD;IACnD,+BAA+B;IAC/B,sCAAsC;IACtC,2BAA2B;IAC3B,kBAAkB;CAClB,CAAC;AAEF,SAAS,iBAAiB,CAAC,IAAY;IACtC,KAAK,MAAM,OAAO,IAAI,kBAAkB,EAAE,CAAC;QAC1C,IAAI,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC;YAAE,OAAO,IAAI,CAAC;IACrC,CAAC;IACD,OAAO,KAAK,CAAC;AACd,CAAC;AAED,SAAS,gBAAgB,CAAC,IAAY;IAKrC,IAAI,CAAC;QACJ,MAAM,SAAS,GAAG,IAAI,CAAC,KAAK,CAAC,aAAa,CAAC,CAAC;QAC5C,IAAI,CAAC,SAAS;YAAE,OAAO,IAAI,CAAC;QAC5B,MAAM,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC;QACxC,MAAM,IAAI,GAAG,MAAM,CAAC,cAAc,EAAE,WAAW,EAAE,CAAC;QAClD,MAAM,OAAO,GAAG,MAAM,CAAC,WAAW,EAAE,WAAW,EAAE,CAAC;QAClD,IAAI,CAAC,IAAI,KAAK,MAAM,IAAI,IAAI,KAAK,MAAM,CAAC,IAAI,CAAC,OAAO,KAAK,MAAM,IAAI,OAAO,KAAK,MAAM,CAAC,EAAE,CAAC;YACxF,OAAO;gBACN,cAAc,EAAE,IAAI;gBACpB,WAAW,EAAE,OAAO;gBACpB,OAAO,EAAE,OAAO,MAAM,CAAC,OAAO,KAAK,QAAQ,CAAC,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE;aACjE,CAAC;QACH,CAAC;IACF,CAAC;IAAC,MAAM,CAAC;QACR,2BAA2B;IAC5B,CAAC;IACD,OAAO,IAAI,CAAC;AACb,CAAC;AAED;;GAEG;AACH,MAAM,UAAU,oBAAoB,CAAC,gBAAyB,EAAE,iBAA0B;IACzF,IAAI,iBAAiB,IAAI,iBAAiB,KAAK,gBAAgB,EAAE,CAAC;QACjE,OAAO,iBAAiB,CAAC;IAC1B,CAAC;IAED,MAAM,SAAS,GAAG,UAAU,EAAE,CAAC;IAC/B,MAAM,UAAU,GAAG,SAAS,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,KAAK,gBAAgB,IAAI,CAAC,KAAK,MAAM,CAAC,CAAC;IACnF,IAAI,UAAU,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC3B,OAAO,UAAU,CAAC,CAAC,CAAC,CAAC;IACtB,CAAC;IAED,OAAO,sBAAsB,CAAC;AAC/B,CAAC;AAED;;GAEG;AACH,MAAM,CAAC,KAAK,UAAU,oBAAoB,CAAC,OAA4B;IACtE,MAAM,EACL,SAAS,EACT,IAAI,EACJ,YAAY,EACZ,mBAAmB,EACnB,UAAU,EACV,gBAAgB,EAChB,gBAAgB,EAChB,aAAa,EAAE,iBAAiB,EAChC,aAAa,EACb,OAAO,GACP,GAAG,OAAO,CAAC;IAEZ,MAAM,iBAAiB,GAAG,oBAAoB,CAAC,gBAAgB,EAAE,iBAAiB,CAAC,CAAC;IACpF,MAAM,UAAU,GAAG,YAAY,iBAAiB,IAAI,UAAU,EAAE,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,CAAC;IAE/E,wBAAwB;IACxB,IAAI,SAAS,CAAC,UAAU,IAAI,SAAS,CAAC,UAAU,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC7D,KAAK,MAAM,IAAI,IAAI,YAAY,EAAE,CAAC;YACjC,IAAI,CAAC,kBAAkB,CAAC,IAAI,EAAE,SAAS,CAAC,UAAU,CAAC,EAAE,CAAC;gBACrD,OAAO;oBACN,UAAU;oBACV,cAAc,EAAE,MAAM;oBACtB,WAAW,EAAE,MAAM;oBACnB,OAAO,EAAE,gCAAgC,IAAI,mCAAmC,SAAS,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG;oBAClH,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE;iBACtB,CAAC;YACH,CAAC;QACF,CAAC;IACF,CAAC;IAED,uCAAuC;IACvC,IAAI,mBAAmB,KAAK,MAAM,EAAE,CAAC;QACpC,OAAO;YACN,UAAU;YACV,cAAc,EAAE,MAAM;YACtB,WAAW,EAAE,MAAM;YACnB,OAAO,EAAE,+DAA+D,UAAU,IAAI,EAAE,EAAE,CAAC,IAAI,EAAE;YACjG,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE;SACtB,CAAC;IACH,CAAC;IAED,oDAAoD;IACpD,IAAI,iBAAiB,CAAC,IAAI,CAAC,EAAE,CAAC;QAC7B,OAAO;YACN,UAAU;YACV,cAAc,EAAE,MAAM;YACtB,WAAW,EAAE,MAAM;YACnB,OAAO,EAAE,iGAAiG;YAC1G,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE;SACtB,CAAC;IACH,CAAC;IAED,yCAAyC;IACzC,IAAI,aAAa,GAAG,IAAI,CAAC;IACzB,IAAI,CAAC;QACJ,aAAa,GAAG,QAAQ,CAAC,iBAAiB,CAAC,CAAC;IAC7C,CAAC;IAAC,MAAM,CAAC;QACR,OAAO;YACN,UAAU;YACV,cAAc,EAAE,aAAa;YAC7B,WAAW,EAAE,aAAa;YAC1B,OAAO,EAAE,4CAA4C,iBAAiB,mCAAmC;YACzG,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE;SACtB,CAAC;IACH,CAAC;IAED,MAAM,gBAAgB,GAAG,OAAO,IAAI,OAAO,CAAC,QAAQ,IAAI,OAAO,CAAC,GAAG,EAAE,CAAC;IACtE,IAAI,CAAC;QACJ,MAAM,YAAY,GAAG,uBAAuB,EAAE,CAAC;QAC/C,MAAM,UAAU,GAAG,uBAAuB,CAAC;YAC1C,SAAS;YACT,IAAI;YACJ,YAAY;YACZ,mBAAmB;YACnB,UAAU;SACV,CAAC,CAAC;QAEH,MAAM,UAAU,GAAG,GAAG,YAAY,OAAO,UAAU,EAAE,CAAC;QACtD,MAAM,MAAM,GAAG,MAAM,aAAa,CAAC,GAAG,CAAC;YACtC,IAAI,EAAE,UAAU;YAChB,OAAO,EAAE,gBAAgB;YACzB,KAAK,EAAE,aAAa,IAAI,gBAAgB,IAAI,SAAS;YACrD,MAAM,EAAE,WAAW,CAAC,OAAO,CAAC,KAAK,CAAC;SAClC,CAAC,CAAC;QAEH,IAAI,CAAC,MAAM,CAAC,OAAO,EAAE,CAAC;YACrB,OAAO;gBACN,UAAU;gBACV,cAAc,EAAE,OAAO;gBACvB,WAAW,EAAE,OAAO;gBACpB,OAAO,EAAE,0CAA0C,MAAM,CAAC,KAAK,IAAI,eAAe,EAAE;gBACpF,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE;aACtB,CAAC;QACH,CAAC;QAED,MAAM,MAAM,GAAG,gBAAgB,CAAC,MAAM,CAAC,MAAM,IAAI,EAAE,CAAC,CAAC;QACrD,IAAI,MAAM,EAAE,cAAc,IAAI,MAAM,EAAE,WAAW,EAAE,CAAC;YACnD,qFAAqF;YACrF,IAAI,CAAC,MAAM,CAAC,cAAc,KAAK,MAAM,IAAI,MAAM,CAAC,WAAW,KAAK,MAAM,CAAC,IAAI,iBAAiB,CAAC,IAAI,CAAC,EAAE,CAAC;gBACpG,OAAO;oBACN,UAAU;oBACV,cAAc,EAAE,MAAM;oBACtB,WAAW,EAAE,MAAM;oBACnB,OAAO,EAAE,2EAA2E;oBACpF,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE;iBACtB,CAAC;YACH,CAAC;YAED,OAAO;gBACN,UAAU;gBACV,cAAc,EAAE,MAAM,CAAC,cAAc;gBACrC,WAAW,EAAE,MAAM,CAAC,WAAW;gBAC/B,OAAO,EAAE,MAAM,CAAC,OAAO,IAAI,4CAA4C;gBACvE,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE;aACtB,CAAC;QACH,CAAC;QAED,OAAO;YACN,UAAU;YACV,cAAc,EAAE,WAAW;YAC3B,WAAW,EAAE,WAAW;YACxB,OAAO,EAAE,yEAAyE;YAClF,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE;SACtB,CAAC;IACH,CAAC;IAAC,OAAO,GAAQ,EAAE,CAAC;QACnB,MAAM,SAAS,GAAG,GAAG,EAAE,IAAI,KAAK,cAAc,IAAI,MAAM,CAAC,GAAG,CAAC,CAAC,QAAQ,CAAC,SAAS,CAAC,CAAC;QAClF,OAAO;YACN,UAAU;YACV,cAAc,EAAE,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,OAAO;YAC/C,WAAW,EAAE,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,OAAO;YAC5C,OAAO,EAAE,sBAAsB,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,OAAO,KAAK,GAAG,EAAE,OAAO,IAAI,MAAM,CAAC,GAAG,CAAC,EAAE;YAChG,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE;SACtB,CAAC;IACH,CAAC;AACF,CAAC;AAED;;GAEG;AACH,MAAM,CAAC,KAAK,UAAU,qBAAqB,CAAC,OAA8B;IACzE,MAAM,EAAE,QAAQ,EAAE,OAAO,EAAE,aAAa,EAAE,aAAa,GAAG,EAAE,EAAE,aAAa,EAAE,aAAa,EAAE,GAAG,OAAO,CAAC;IACvG,MAAM,aAAa,GAAG,sBAAsB,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC;IACjE,MAAM,UAAU,GAAG,qBAAqB,aAAa,IAAI,OAAO,IAAI,UAAU,EAAE,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,CAAC;IAE/F,MAAM,iBAAiB,GAAG,oBAAoB,CAAC,SAAS,EAAE,aAAa,CAAC,CAAC;IACzE,IAAI,aAAa,GAAQ,IAAI,CAAC;IAC9B,IAAI,CAAC;QACJ,aAAa,GAAG,QAAQ,CAAC,iBAAiB,CAAC,CAAC;IAC7C,CAAC;IAAC,MAAM,CAAC;QACR,OAAO;YACN,UAAU;YACV,cAAc,EAAE,aAAa;YAC7B,WAAW,EAAE,aAAa;YAC1B,OAAO,EAAE,mDAAmD,iBAAiB,qBAAqB;YAClG,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE;SACtB,CAAC;IACH,CAAC;IAED,IAAI,YAAY,GAAG,EAAE,CAAC;IACtB,IAAI,CAAC;QACJ,MAAM,EAAE,MAAM,EAAE,GAAG,MAAM,aAAa,CAAC,KAAK,EAAE,CAAC,MAAM,EAAE,GAAG,OAAO,MAAM,aAAa,EAAE,CAAC,EAAE;YACxF,GAAG,EAAE,aAAa;YAClB,SAAS,EAAE,EAAE,GAAG,IAAI,GAAG,IAAI;SAC3B,CAAC,CAAC;QACH,YAAY,GAAG,MAAM,CAAC;IACvB,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACd,OAAO;YACN,UAAU;YACV,cAAc,EAAE,OAAO;YACvB,WAAW,EAAE,OAAO;YACpB,OAAO,EAAE,mCAAmC,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,EAAE;YAC9F,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE;SACtB,CAAC;IACH,CAAC;IAED,IAAI,iBAAiB,CAAC,YAAY,CAAC,EAAE,CAAC;QACrC,OAAO;YACN,UAAU;YACV,cAAc,EAAE,MAAM;YACtB,WAAW,EAAE,MAAM;YACnB,OAAO,EAAE,gFAAgF;YACzF,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE;SACtB,CAAC;IACH,CAAC;IAED,IAAI,CAAC;QACJ,MAAM,MAAM,GAAG,gCAAgC,CAAC,OAAO,EAAE,aAAa,EAAE,YAAY,EAAE,aAAa,CAAC,CAAC;QACrG,MAAM,MAAM,GAAG,MAAM,aAAa,CAAC,GAAG,CAAC;YACtC,IAAI,EAAE,MAAM;YACZ,OAAO,EAAE,aAAa;YACtB,KAAK,EAAE,aAAa,IAAI,SAAS;YACjC,MAAM,EAAE,WAAW,CAAC,OAAO,CAAC,KAAK,CAAC;SAClC,CAAC,CAAC;QACH,IAAI,CAAC,MAAM,CAAC,OAAO,EAAE,CAAC;YACrB,OAAO;gBACN,UAAU;gBACV,cAAc,EAAE,OAAO;gBACvB,WAAW,EAAE,OAAO;gBACpB,OAAO,EAAE,0DAA0D,MAAM,CAAC,KAAK,IAAI,eAAe,EAAE;gBACpG,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE;aACtB,CAAC;QACH,CAAC;QACD,MAAM,MAAM,GAAG,gBAAgB,CAAC,MAAM,CAAC,MAAM,IAAI,EAAE,CAAC,CAAC;QACrD,IAAI,MAAM,EAAE,cAAc,IAAI,MAAM,EAAE,WAAW,EAAE,CAAC;YACnD,OAAO;gBACN,UAAU;gBACV,cAAc,EAAE,MAAM,CAAC,cAAc;gBACrC,WAAW,EAAE,MAAM,CAAC,WAAW;gBAC/B,OAAO,EAAE,MAAM,CAAC,OAAO,IAAI,iCAAiC;gBAC5D,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE;aACtB,CAAC;QACH,CAAC;QACD,OAAO;YACN,UAAU;YACV,cAAc,EAAE,WAAW;YAC3B,WAAW,EAAE,WAAW;YACxB,OAAO,EAAE,yEAAyE;YAClF,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE;SACtB,CAAC;IACH,CAAC;IAAC,OAAO,GAAQ,EAAE,CAAC;QACnB,MAAM,SAAS,GAAG,GAAG,EAAE,IAAI,KAAK,cAAc,IAAI,MAAM,CAAC,GAAG,CAAC,CAAC,QAAQ,CAAC,SAAS,CAAC,CAAC;QAClF,OAAO;YACN,UAAU;YACV,cAAc,EAAE,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,OAAO;YAC/C,WAAW,EAAE,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,OAAO;YAC5C,OAAO,EAAE,uCAAuC,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,OAAO,KAAK,GAAG,EAAE,OAAO,IAAI,MAAM,CAAC,GAAG,CAAC,EAAE;YACjH,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE;SACtB,CAAC;IACH,CAAC;AACF,CAAC"}

package/dist/orchestration/reviewer-prompt.d.ts

@@ -0,0 +1,18 @@
+/**
+ * Reviewer prompt generator for the independent subagent reviewer gate.
+ *
+ * Provides specialized evaluation prompts enforcing:
+ * 1. specCompliance: did the agent fulfill the objective and stay within writeScope?
+ * 2. codeQuality: are there syntax errors, placeholder comments, unhandled rejections, or leaks?
+ */
+import type { TaskBrief, VerificationVerdict } from "../core/types.js";
+export interface ReviewPromptContext {
+    taskBrief: TaskBrief;
+    diff: string;
+    filesChanged: string[];
+    verificationVerdict: VerificationVerdict;
+    testOutput?: string;
+}
+export declare function getReviewerSystemPrompt(): string;
+export declare function buildReviewerUserPrompt(ctx: ReviewPromptContext): string;
+export declare function buildCombinedStagingReviewPrompt(baseSha: string, stagingBranch: string, combinedDiff: string, taskSummaries: string[]): string;

package/dist/orchestration/reviewer-prompt.js

@@ -0,0 +1,67 @@
+/**
+ * Reviewer prompt generator for the independent subagent reviewer gate.
+ *
+ * Provides specialized evaluation prompts enforcing:
+ * 1. specCompliance: did the agent fulfill the objective and stay within writeScope?
+ * 2. codeQuality: are there syntax errors, placeholder comments, unhandled rejections, or leaks?
+ */
+export function getReviewerSystemPrompt() {
+    return `You are the ContextOS Independent Code Reviewer.
+Your role is to strictly audit changes produced by an implementer agent against their assigned TaskBrief.
+
+You MUST evaluate two discrete dimensions:
+1. "specCompliance":
+   - PASS: All changes strictly align with the objective. Only files declared in writeScope were touched. No undeclared files were modified or deleted. Acceptance criteria are met.
+   - FAIL: Objective is not met, files outside writeScope were altered, or scope was violated.
+
+2. "codeQuality":
+   - PASS: The code is clean, robust, and production-ready. Zero placeholder stubs (e.g. "// TODO", "implement later", "..."), proper error handling, no syntax errors, no hardcoded secrets, and no regressions.
+   - FAIL: Contains lazy stubs, placeholders, obvious runtime/type bugs, security vulnerabilities, or broken logic.
+
+You MUST reply ONLY with a valid JSON object matching this schema:
+{
+  "specCompliance": "PASS" | "FAIL",
+  "codeQuality": "PASS" | "FAIL",
+  "summary": "Concise 1-3 sentence evaluation explaining verdicts and required fixes if any"
+}`;
+}
+export function buildReviewerUserPrompt(ctx) {
+    const { taskBrief, diff, filesChanged, verificationVerdict, testOutput } = ctx;
+    const scopeList = taskBrief.writeScope.length > 0 ? taskBrief.writeScope.join(", ") : "(any)";
+    const filesList = filesChanged.length > 0 ? filesChanged.join(", ") : "(no files changed)";
+    return `Task Brief:
+- Task ID: ${taskBrief.taskId || taskBrief.id}
+- Base SHA: ${taskBrief.baseSha || "HEAD"}
+- Objective: ${taskBrief.objective || taskBrief.task || "(none)"}
+- Declared writeScope: ${scopeList}
+- Test Command: ${taskBrief.testCommand || "(none)"}
+- Expected Result: ${taskBrief.expectedResult || "(none)"}
+
+Implementer Changes:
+- Files Changed: ${filesList}
+- Automated Verification: ${verificationVerdict}
+${testOutput ? `- Verification Output:\n\`\`\`\n${testOutput.slice(0, 3000)}\n\`\`\`` : ""}
+
+Git Diff:
+\`\`\`diff
+${diff.slice(0, 15000)}
+\`\`\`
+
+Evaluate the diff against the TaskBrief and output your JSON verdict.`;
+}
+export function buildCombinedStagingReviewPrompt(baseSha, stagingBranch, combinedDiff, taskSummaries) {
+    return `Staging Branch Audit:
+- Base SHA: ${baseSha}
+- Staging Branch: ${stagingBranch}
+- Tasks Merged:
+${taskSummaries.map((s, idx) => `  ${idx + 1}. ${s}`).join("\n")}
+
+Combined Diff:
+\`\`\`diff
+${combinedDiff.slice(0, 20000)}
+\`\`\`
+
+Perform a holistic integration review across all merged tasks. Check for cross-thread incompatibilities, global regressions, or conflicting changes.
+Return your JSON verdict with "specCompliance", "codeQuality", and "summary".`;
+}
+//# sourceMappingURL=reviewer-prompt.js.map

package/dist/orchestration/reviewer-prompt.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"reviewer-prompt.js","sourceRoot":"","sources":["../../src/orchestration/reviewer-prompt.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;AAYH,MAAM,UAAU,uBAAuB;IACtC,OAAO;;;;;;;;;;;;;;;;;EAiBN,CAAC;AACH,CAAC;AAED,MAAM,UAAU,uBAAuB,CAAC,GAAwB;IAC/D,MAAM,EAAE,SAAS,EAAE,IAAI,EAAE,YAAY,EAAE,mBAAmB,EAAE,UAAU,EAAE,GAAG,GAAG,CAAC;IAE/E,MAAM,SAAS,GAAG,SAAS,CAAC,UAAU,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC;IAC9F,MAAM,SAAS,GAAG,YAAY,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,oBAAoB,CAAC;IAE3F,OAAO;aACK,SAAS,CAAC,MAAM,IAAK,SAAiB,CAAC,EAAE;cACxC,SAAS,CAAC,OAAO,IAAI,MAAM;eAC1B,SAAS,CAAC,SAAS,IAAK,SAAiB,CAAC,IAAI,IAAI,QAAQ;yBAChD,SAAS;kBAChB,SAAS,CAAC,WAAW,IAAI,QAAQ;qBAC9B,SAAS,CAAC,cAAc,IAAI,QAAQ;;;mBAGtC,SAAS;4BACA,mBAAmB;EAC7C,UAAU,CAAC,CAAC,CAAC,mCAAmC,UAAU,CAAC,KAAK,CAAC,CAAC,EAAE,IAAI,CAAC,UAAU,CAAC,CAAC,CAAC,EAAE;;;;EAIxF,IAAI,CAAC,KAAK,CAAC,CAAC,EAAE,KAAK,CAAC;;;sEAGgD,CAAC;AACvE,CAAC;AAED,MAAM,UAAU,gCAAgC,CAC/C,OAAe,EACf,aAAqB,EACrB,YAAoB,EACpB,aAAuB;IAEvB,OAAO;cACM,OAAO;oBACD,aAAa;;EAE/B,aAAa,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,GAAG,EAAE,EAAE,CAAC,KAAK,GAAG,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC;;;;EAI9D,YAAY,CAAC,KAAK,CAAC,CAAC,EAAE,KAAK,CAAC;;;;8EAIgD,CAAC;AAC/E,CAAC"}

package/dist/orchestration/verification-runner.d.ts

@@ -0,0 +1,53 @@
+/**
+ * Worktree test command execution engine with strict security guards and lifecycle hardening.
+ *
+ * Implements Section 16 & Milestones W5.1 and W5.2:
+ * - Structured VerificationSpec with validation and legacy reader
+ * - Command trust validation (bans npx in host mode, whitelist, forbidden eval args)
+ * - Cross-platform process tree termination (Windows taskkill /T /F, POSIX process groups)
+ * - Sensitive output redaction (API keys, tokens, passwords)
+ * - Post-execution candidate immutability verification (HEAD and dirty working tree checks)
+ */
+import type { VerificationSpec, VerificationStatus } from "../core/types.js";
+import { ExecutionSandbox, type SandboxMode } from "../sandbox/execution.js";
+import { getSanitizedEnv, killProcessTree, redactSensitiveOutput, STRICT_ENV_ALLOWLIST } from "../utils/process-security.js";
+export { getSanitizedEnv, killProcessTree, redactSensitiveOutput, STRICT_ENV_ALLOWLIST };
+export declare const ALLOWED_VERIFY_TOOLS: Set<string>;
+export declare const FORBIDDEN_VERIFY_ARGS: Set<string>;
+/**
+ * Parses a string command or object into a canonical VerificationSpec (Section 16.1).
+ */
+export declare function parseVerificationSpec(input: unknown): VerificationSpec;
+/**
+ * Enforces command trust policy (Section 16.2).
+ */
+export declare function validateCommandTrust(spec: VerificationSpec, options?: {
+    runnerMode?: "host-unsafe" | "oci";
+    trusted?: boolean;
+}): void;
+/**
+ * Checks that the working tree and candidate commit remained immutable (Section 16.3).
+ */
+export declare function verifyCandidateImmutability(worktreePath: string, expectedHeadSha?: string): {
+    clean: boolean;
+    mutatedHead?: boolean;
+    dirtyFiles?: string[];
+};
+export interface VerificationOptions {
+    expectedHeadSha?: string;
+    runnerMode?: "host-unsafe" | "oci";
+    sandboxMode?: SandboxMode;
+    sandbox?: ExecutionSandbox;
+    trusted?: boolean;
+    signal?: AbortSignal;
+}
+/**
+ * Executes worktree verification with strict security guards and lifecycle management.
+ */
+export declare function runWorktreeVerification(worktreePath: string, commandOrSpec: string | VerificationSpec, options?: VerificationOptions): Promise<{
+    verdict: VerificationStatus;
+    verified: boolean;
+    output: string;
+    exitCode: number | null;
+    runnerMode?: "oci" | "host-unsafe";
+}>;