commandmate 0.44.2 → 0.44.3

package/dist/server/src/lib/detection/idle-evidence-observation.js

@@ -20,8 +20,8 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.recordIdleEvidenceObservation = recordIdleEvidenceObservation;
 exports.getIdleEvidenceObservations = getIdleEvidenceObservations;
 exports.resetIdleEvidenceObservations = resetIdleEvidenceObservations;
-const observations = globalThis.__idleEvidenceObservations ??
-    (globalThis.__idleEvidenceObservations = new Map());
+const global_state_1 = require("../global-state");
+const observations = (0, global_state_1.getOrInitGlobal)('__idleEvidenceObservations', () => new Map());
 /**
  * Fold one frame's idle-evidence verdict into the tally for `tool`.
  *

package/dist/server/src/lib/detection/prompt-detect-multiple-choice.js

@@ -12,6 +12,7 @@ exports.buildMultipleChoiceResult = buildMultipleChoiceResult;
 exports.detectMultipleChoicePrompt = detectMultipleChoicePrompt;
 const tui_detection_frame_1 = require("./tui-detection-frame");
 const cli_patterns_1 = require("./cli-patterns");
+const prompt_view_1 = require("../../lib/session/prompt-view");
 const picker_chrome_1 = require("./tools/claude/picker-chrome");
 // ============================================================================
 // Constants
@@ -411,48 +412,22 @@ const TEXT_INPUT_PATTERNS = [
     /custom/i,
     /differently/i,
 ];
-/**
- * Labels of the rows measured to BE a text field on screen (Issue #2573).
- *
- * `requiresTextInput` (from {@link TEXT_INPUT_PATTERNS}) reads the WORDS of a
- * label — "tell … what to do differently", "custom", "enter …" — and says the
- * option is about the user's own text. It does not say where typed characters
- * land, and for two rows it flags alike the measured answer is opposite:
- *
- * | row | on screen | free text + Enter |
- * |-----|-----------|-------------------|
- * | Command Code `AskUserQuestion` `Type something...` (#2522) | a `TextInput` | lands in the field — the answer |
- * | Command Code permission `No, tell Command Code what to do differently` | a menu row | ignored; the Enter confirms the highlighted `1. Yes` |
- *
- * The second is how a "No + reason" was delivered as an approval. The same
- * words sit on codex's and copilot's approval rows (codex's also name letter
- * hotkeys, `(y)` / `(p)`), and the generic patterns match inside the command an
- * approval row quotes (`… commands that start with 'npm run custom'`).
- *
- * So this is an allowlist of what was measured, not a denylist of what went
- * wrong: a flagged row is a field only when its label is one of these. Anchored
- * at the start so Command Code's folded description (`Type something... Give me
- * a branch name …`) still matches. Command Code's reader
- * (`tools/command-code/dialog.ts`) marks the same rows with the same expression.
- */
-const TYPED_TEXT_FIELD_LABEL_PATTERNS = [
-    /^[^\S\n]*type\s+something\b/i,
-];
 /**
  * Whether typed text reaches this option as its answer (Issue #2573).
  *
  * `true` only for a `requiresTextInput` row whose label is a measured text field
- * ({@link TYPED_TEXT_FIELD_LABEL_PATTERNS}). Every other flagged row is a menu
+ * (`TYPED_TEXT_FIELD_LABEL_PATTERNS` in `lib/session/prompt-view`, read through
+ * {@link optionTakesTypedText}). Every other flagged row is a menu
  * row: it is answered by its NUMBER, and free text sent at it is swallowed while
  * the Enter after it confirms whatever is highlighted.
  *
- * Pure, and restated in `components/worktree/PromptPanel.tsx` for the answer
- * panels, which cannot import this module (its graph reaches `lib/env`'s `fs`);
+ * Pure, and since Issue #3218 a call to `optionTakesTypedText`, which the answer
+ * panels read directly (through `hooks/usePromptAnswerState`) because they
+ * cannot import this module (its graph reaches `lib/env`'s `fs`);
  * `tests/unit/components/PromptPanel.test.tsx` asserts the two agree.
  */
 function isTypedTextFieldOption(option) {
-    return option.requiresTextInput === true
-        && TYPED_TEXT_FIELD_LABEL_PATTERNS.some((pattern) => pattern.test(option.label));
+    return (0, prompt_view_1.optionTakesTypedText)(option);
 }
 // ============================================================================
 // Helper functions

package/dist/server/src/lib/detection/prompt-detector.js

@@ -11,6 +11,7 @@ exports.resetDetectPromptCache = resetDetectPromptCache;
 const logger_1 = require("../../lib/logger");
 const prompt_detect_multiple_choice_1 = require("./prompt-detect-multiple-choice");
 const tui_detection_frame_1 = require("./tui-detection-frame");
+const truncate_raw_content_1 = require("./truncate-raw-content");
 const logger = (0, logger_1.createLogger)('prompt-detector');
 /**
  * Last output tail used for duplicate log suppression.
@@ -25,40 +26,6 @@ const logger = (0, logger_1.createLogger)('prompt-detector');
  * @internal
  */
 let lastOutputTail = null;
-/**
- * Maximum number of lines to retain in rawContent.
- * Tail lines are preserved (instruction text typically appears just before the prompt).
- * @see truncateRawContent
- */
-const RAW_CONTENT_MAX_LINES = 200;
-/**
- * Maximum number of characters to retain in rawContent.
- * Tail characters are preserved.
- * @see truncateRawContent
- */
-const RAW_CONTENT_MAX_CHARS = 5000;
-/**
- * Truncate raw content to fit within size limits.
- * Preserves the tail (end) of the content since instruction text
- * typically appears just before the prompt at the end of output.
- *
- * Security: No regular expressions used -- no ReDoS risk. [SF-S4-002]
- * String.split('\n') and String.slice() are literal string operations only.
- *
- * @param content - The content to truncate
- * @returns Truncated content (last RAW_CONTENT_MAX_LINES lines, max RAW_CONTENT_MAX_CHARS characters)
- */
-function truncateRawContent(content) {
-    const lines = content.split('\n');
-    const truncatedLines = lines.length > RAW_CONTENT_MAX_LINES
-        ? lines.slice(-RAW_CONTENT_MAX_LINES)
-        : lines;
-    let result = truncatedLines.join('\n');
-    if (result.length > RAW_CONTENT_MAX_CHARS) {
-        result = result.slice(-RAW_CONTENT_MAX_CHARS);
-    }
-    return result;
-}
 /**
  * Yes/no pattern definitions for data-driven matching.
  * Each entry defines a regex pattern and its associated default option.
@@ -190,7 +157,7 @@ function detectPrompt(output, options) {
     // ❯ 1. Yes
     //   2. No
     //   3. Cancel
-    const multipleChoiceResult = (0, prompt_detect_multiple_choice_1.detectMultipleChoicePrompt)(detectionOutput, options, truncateRawContent);
+    const multipleChoiceResult = (0, prompt_detect_multiple_choice_1.detectMultipleChoicePrompt)(detectionOutput, options, truncate_raw_content_1.truncateRawContent);
     if (multipleChoiceResult.isPrompt) {
         // D2-004: Suppress duplicate multipleChoice info log
         if (!isDuplicate) {

package/dist/server/src/lib/detection/selection-shape-patterns.js

@@ -0,0 +1,69 @@
+"use strict";
+/**
+ * Regexes shared by the shape reader and the Command Code block of
+ * `selection-shape.ts`. Split out first so the Command Code block can move
+ * without a cycle (Issue #3218). Imports nothing: this file is reached from
+ * browser-side modules too.
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.COMMAND_CODE_PLAN_REVIEW_FOOTER = exports.FILTER_INPUT_PATTERN = void 0;
+/**
+ * A focused search/filter row inside the dialog.
+ *
+ * Three measured spellings, and nothing wider — this predicate SUPPRESSES a
+ * control, so a false positive costs the user their number buttons:
+ *  - `Type to search models...` / `type to search` (Command Code 1.40.1);
+ *  - `Search models…` (copilot 1.0.80's `/model`, recorded verbatim in
+ *    `cli-patterns.ts`'s `COPILOT_SELECTION_FOOTER_PATTERN` docblock);
+ *  - `/ search` (copilot's `/session` and `/settings` footers).
+ *
+ * Deliberately does NOT match claude's `/model` blurb ("Switch between Claude
+ * models…") or codex's ("Access legacy models by running codex -m…"), neither of
+ * which contains the word.
+ */
+exports.FILTER_INPUT_PATTERN = /\btype\s+to\s+search\b|\bsearch\s+\w+\s*(?:…|\.\.\.)|(?:^|·)\s*\/\s+search\b/im;
+/**
+ * The two footer rows of Command Code's plan review overlay (Issue #2761).
+ *
+ * Measured on 1.58.0 at 200x1000. The overlay is a rule, a `Plan review: <title>
+ * · <path> · v1` header, the plan with a line-number gutter, a second rule, a
+ * ` REVIEW ` badge and then, verbatim:
+ *
+ *     Approve ctrl+a   executes the plan
+ *     Cancel esc
+ *
+ * BOTH rows, adjacent, because each half alone is weak: `Cancel esc` is two
+ * words any picker might print, and `Approve` is a word an agent writes in a
+ * plan. Multi-line on purpose — it is tested against a joined tail
+ * (`NormalizedFrame.lastLines`, or the tail {@link readSelectionListShape}
+ * builds), never against a single row.
+ *
+ * Swept against every fixture in `tests/fixtures` and
+ * `tests/unit/lib/detection/fixtures` when this was written (300 files): the
+ * only match is the plan review capture itself.
+ *
+ * ## The `❯` either row may carry (Issue #2793)
+ *
+ * `↓` past the plan's last line moves the focus onto the ACTION list, and the
+ * focused action is drawn with a `❯ ` in front of it and two spaces before its
+ * key (`tests/fixtures/command-code-plan-review-2763/`, 1.58.0):
+ *
+ *     ❯ Approve  ctrl+a   executes the plan        ← `plan-review-action-focus-approve.txt`
+ *     Cancel esc
+ *
+ *     Approve ctrl+a   executes the plan · comments go along as notes
+ *     ❯ Cancel  esc                                ← `plan-review-long-scrolled-cancel-focused.txt`
+ *
+ * Without the optional `❯ ` this pattern missed both frames, and they went on to
+ * the composer check, where `COMMAND_CODE_PROMPT_PATTERN` (`^❯(\s*$|\s+\S)`)
+ * read the cursor row as the composer and published `ready` / `input_prompt`:
+ * `wait` exited 0 on a plan nobody had approved — #2754's `❯`-outside-the-list
+ * family. It is also the frame on which `Enter` EXECUTES the focused action, so
+ * missing it here would also have left the chat surface's `Enter` on screen
+ * (see {@link SelectionListShape.offersPlanApprove}). Only `❯`, and only as a
+ * prefix: `❯ ` + the row is the one measured spelling of a focused action.
+ * Re-swept over the same two directories with the widened pattern: every match
+ * is still a `command-code-plan-review-*` capture, which
+ * `command-code-plan-review-2793.test.ts` keeps pinned.
+ */
+exports.COMMAND_CODE_PLAN_REVIEW_FOOTER = /^\s*(?:❯ +)?Approve\s+ctrl\+a\b[^\n]*\n\s*(?:❯ +)?Cancel\s+esc\s*$/im;