com.wallstop-studios.unity-helpers 2.0.0-rc03 → 2.0.0-rc05

package/Tests/Runtime/Performance/RandomPerformanceTests.cs

@@ -10,28 +10,34 @@
         [Test]
         public void Benchmark()
         {
-            TimeSpan timeout = TimeSpan.FromSeconds(1);
+            TimeSpan timeout = TimeSpan.FromSeconds(1.125);
 
             UnityEngine.Debug.Log($"| Random | Next | NextFloat | NextDouble |");
             UnityEngine.Debug.Log($"| ------ | ---- | --------- | ---------- |");
-            
+
             RunTest(new PcgRandom(), timeout);
             RunTest(new SystemRandom(), timeout);
             RunTest(new SquirrelRandom(), timeout);
             RunTest(new XorShiftRandom(), timeout);
+            RunTest(new DotNetRandom(), timeout);
+            RunTest(new WyRandom(), timeout);
         }
 
-        private void RunTest<T>(T random, TimeSpan timeout) where T : IRandom
+        private static void RunTest<T>(T random, TimeSpan timeout)
+            where T : IRandom
         {
             int nextInt = RunNext(timeout, random);
             int nextFloat = RunNextFloat(timeout, random);
             int nextDouble = RunNextDouble(timeout, random);
 
-            UnityEngine.Debug.Log($"| {random.GetType().Name} | {(nextInt / timeout.TotalSeconds):N0} | {(nextFloat / timeout.TotalSeconds):N0} | {(nextDouble / timeout.TotalSeconds):N0} |");
+            UnityEngine.Debug.Log(
+                $"| {random.GetType().Name} | {(nextInt / timeout.TotalSeconds):N0} | {(nextFloat / timeout.TotalSeconds):N0} | {(nextDouble / timeout.TotalSeconds):N0} |"
+            );
         }
 
         // Copy-pasta'd for maximum speed
-        private int RunNext<T>(TimeSpan timeout, T random) where T : IRandom
+        private static int RunNext<T>(TimeSpan timeout, T random)
+            where T : IRandom
         {
             int count = 0;
             Stopwatch timer = Stopwatch.StartNew();
@@ -39,13 +45,13 @@
             {
                 _ = random.Next();
                 ++count;
-            }
-            while (timer.Elapsed < timeout);
+            } while (timer.Elapsed < timeout);
 
             return count;
         }
 
-        private int RunNextFloat<T>(TimeSpan timeout, T random) where T : IRandom
+        private static int RunNextFloat<T>(TimeSpan timeout, T random)
+            where T : IRandom
         {
             int count = 0;
             Stopwatch timer = Stopwatch.StartNew();
@@ -53,13 +59,13 @@
             {
                 _ = random.NextFloat();
                 ++count;
-            }
-            while (timer.Elapsed < timeout);
+            } while (timer.Elapsed < timeout);
 
             return count;
         }
 
-        private int RunNextDouble<T>(TimeSpan timeout, T random) where T : IRandom
+        private static int RunNextDouble<T>(TimeSpan timeout, T random)
+            where T : IRandom
         {
             int count = 0;
             Stopwatch timer = Stopwatch.StartNew();
@@ -67,8 +73,7 @@
             {
                 _ = random.NextDouble();
                 ++count;
-            }
-            while (timer.Elapsed < timeout);
+            } while (timer.Elapsed < timeout);
 
             return count;
         }

package/Tests/Runtime/Random/DotNetRandomTests.cs

@@ -0,0 +1,9 @@
+namespace UnityHelpers.Tests.Random
+{
+    using Core.Random;
+
+    public sealed class DotNetRandomTests : RandomTestBase
+    {
+        protected override IRandom NewRandom() => new DotNetRandom();
+    }
+}

package/Tests/Runtime/Random/DotNetRandomTests.cs.meta

@@ -0,0 +1,3 @@
+fileFormatVersion: 2
+guid: 45efbe46a3704e97b7d86757c8528a5c
+timeCreated: 1732482168

package/Tests/Runtime/Random/RandomTestBase.cs

@@ -8,9 +8,9 @@
 
     public abstract class RandomTestBase
     {
-        protected const int SampleCount = 10_000_000;
+        private const int SampleCount = 12_500_000;
 
-        protected readonly int[] _samples = new int[1_000];
+        private readonly int[] _samples = new int[1_000];
 
         protected abstract IRandom NewRandom();
 
@@ -48,22 +48,37 @@
         public void Byte()
         {
             TestAndVerify(
-                random => random.NextByte(0, (byte)(_samples.Length < byte.MaxValue ? _samples.Length : byte.MaxValue)),
-                byte.MaxValue);
+                random =>
+                    random.NextByte(
+                        0,
+                        (byte)(_samples.Length < byte.MaxValue ? _samples.Length : byte.MaxValue)
+                    ),
+                byte.MaxValue
+            );
         }
 
         [Test]
         public void Float()
         {
-            TestAndVerify(
-                random => Math.Clamp((int)Math.Floor(random.NextFloat(0, _samples.Length)), 0, _samples.Length - 1));
+            TestAndVerify(random =>
+                Math.Clamp(
+                    (int)Math.Floor(random.NextFloat(0, _samples.Length)),
+                    0,
+                    _samples.Length - 1
+                )
+            );
         }
 
         [Test]
         public void Double()
         {
-            TestAndVerify(
-                random => Math.Clamp((int)Math.Floor(random.NextDouble(0, _samples.Length)), 0, _samples.Length - 1));
+            TestAndVerify(random =>
+                Math.Clamp(
+                    (int)Math.Floor(random.NextDouble(0, _samples.Length)),
+                    0,
+                    _samples.Length - 1
+                )
+            );
         }
 
         [Test]
@@ -78,7 +93,37 @@
             TestAndVerify(random => (int)random.NextUlong(0, (ulong)_samples.Length));
         }
 
-        protected void TestAndVerify(Func<IRandom, int> sample, int? maxLength = null)
+        [Test]
+        public void Copy()
+        {
+            const int numGeneratorChecks = 1_000;
+            IRandom random1 = NewRandom();
+            IRandom random2 = random1.Copy();
+            Assert.AreEqual(random1.InternalState, random2.InternalState);
+            // UnityRandom has shared state, the below test is not possible for it. We did all we could.
+            if (NewRandom() is not UnityRandom)
+            {
+                for (int i = 0; i < numGeneratorChecks; ++i)
+                {
+                    Assert.AreEqual(random1.Next(), random2.Next());
+                    Assert.AreEqual(random1.InternalState, random2.InternalState);
+                }
+            }
+
+            Assert.AreEqual(random1.InternalState, random2.InternalState);
+            IRandom random3 = random1.Copy();
+            Assert.AreEqual(random1.InternalState, random3.InternalState);
+            if (NewRandom() is not UnityRandom)
+            {
+                for (int i = 0; i < numGeneratorChecks; ++i)
+                {
+                    Assert.AreEqual(random1.Next(), random3.Next());
+                    Assert.AreEqual(random1.InternalState, random3.InternalState);
+                }
+            }
+        }
+
+        private void TestAndVerify(Func<IRandom, int> sample, int? maxLength = null)
         {
             IRandom random = NewRandom();
             for (int i = 0; i < SampleCount; ++i)
@@ -114,12 +159,21 @@
             }
 
             Assert.AreEqual(
-                0, zeroCountIndexes.Count, "No samples at {0} indices: [{1}]", zeroCountIndexes.Count,
-                string.Join(",", zeroCountIndexes));
+                0,
+                zeroCountIndexes.Count,
+                "No samples at {0} indices: [{1}]",
+                zeroCountIndexes.Count,
+                string.Join(",", zeroCountIndexes)
+            );
             Assert.AreEqual(
-                0, outsideRange.Count, "{0} indexes outside of dev {1:0.00}. Expected: {2:0.00}. Found: [{3}]",
-                outsideRange.Count, deviationAllowed, average,
-                string.Join(",", outsideRange.Select(index => _samples[index])));
+                0,
+                outsideRange.Count,
+                "{0} indexes outside of dev {1:0.00}. Expected: {2:0.00}. Found: [{3}]",
+                outsideRange.Count,
+                deviationAllowed,
+                average,
+                string.Join(",", outsideRange.Select(index => _samples[index]))
+            );
         }
     }
-}
+}

package/Tests/Runtime/Random/WyRandomTests.cs

@@ -0,0 +1,9 @@
+namespace UnityHelpers.Tests.Random
+{
+    using Core.Random;
+
+    public sealed class WyRandomTests : RandomTestBase
+    {
+        protected override IRandom NewRandom() => new WyRandom();
+    }
+}

package/Tests/Runtime/Random/WyRandomTests.cs.meta

@@ -0,0 +1,3 @@
+fileFormatVersion: 2
+guid: 700b0f9e94074d7fb2177d37ff9bcd4f
+timeCreated: 1732481488

package/Tests.meta

@@ -1,8 +1,8 @@
-fileFormatVersion: 2
-guid: 95113a6d0bd1caa45a97f7f4db1e7c0a
-folderAsset: yes
-DefaultImporter:
-  externalObjects: {}
-  userData: 
-  assetBundleName: 
-  assetBundleVariant: 
+fileFormatVersion: 2
+guid: 95113a6d0bd1caa45a97f7f4db1e7c0a
+folderAsset: yes
+DefaultImporter:
+  externalObjects: {}
+  userData: 
+  assetBundleName: 
+  assetBundleVariant: 

package/Third Party Notices.md.meta

@@ -1,7 +1,7 @@
-fileFormatVersion: 2
-guid: 4908409161853e24bbbd3b2522b0fcc2
-TextScriptImporter:
-  externalObjects: {}
-  userData: 
-  assetBundleName: 
-  assetBundleVariant: 
+fileFormatVersion: 2
+guid: 4908409161853e24bbbd3b2522b0fcc2
+TextScriptImporter:
+  externalObjects: {}
+  userData: 
+  assetBundleName: 
+  assetBundleVariant: 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "com.wallstop-studios.unity-helpers",
-  "version": "2.0.0-rc03",
+  "version": "2.0.0-rc05",
   "displayName": "Unity Helpers",
   "description": "Various Unity Helper Library",
   "dependencies": {},

package/package.json.meta

@@ -1,7 +1,7 @@
-fileFormatVersion: 2
-guid: 37c8a4d958841ed4b9cf38ef3b01ea92
-PackageManifestImporter:
-  externalObjects: {}
-  userData: 
-  assetBundleName: 
-  assetBundleVariant: 
+fileFormatVersion: 2
+guid: 37c8a4d958841ed4b9cf38ef3b01ea92
+PackageManifestImporter:
+  externalObjects: {}
+  userData: 
+  assetBundleName: 
+  assetBundleVariant: