com.wallstop-studios.dxmessaging 2.2.0 → 3.1.0

package/Samples~/DI/README.md

@@ -1,51 +1,51 @@
-# DxMessaging DI Samples
-
-These snippets illustrate how to consume `IMessageRegistrationBuilder` inside common Unity dependency injection containers. The scripts compile only when the corresponding scripting define is enabled and the container package is present.
-
-## Setup
-
-1. Install the relevant container package (Zenject/Extenject, VContainer, or Reflex) into your Unity project.
-2. Enable the matching scripting define symbol in **Project Settings › Player › Scripting Define Symbols**:
-   - `ZENJECT_PRESENT`
-   - `VCONTAINER_PRESENT`
-   - `REFLEX_PRESENT`
-3. Import the sample folder you need into your Unity project (`Assets/Samples/DxMessaging/*`).
-
-Each sample shows:
-
-- Registering `IMessageRegistrationBuilder` via the provided shim under [Runtime/Unity/Integrations](../../Runtime/Unity/Integrations/).
-- Constructing a `MessageRegistrationLease` in a container-managed service.
-- Activating/deactivating the lease using the container lifecycle.
-
-### Structure
-
-- Zenject sample installer: [SampleInstaller.cs](./Zenject/SampleInstaller.cs)
-- VContainer sample lifetime scope: [SampleLifetimeScope.cs](./VContainer/SampleLifetimeScope.cs)
-- Reflex sample installer: [SampleInstaller.cs](./Reflex/SampleInstaller.cs)
-- Current global message bus provider asset: [GlobalMessageBusProvider.asset](./Providers/GlobalMessageBusProvider.asset) — ScriptableObject that resolves whichever bus is currently configured as global.
-- Initial global message bus provider asset: [InitialGlobalMessageBusProvider.asset](./Providers/InitialGlobalMessageBusProvider.asset) — ScriptableObject that always returns the original startup global bus, ignoring later overrides.
-- Prefab setup: [MessagingInstallerSample.prefab](./Prefabs/MessagingInstallerSample.prefab) — ready-to-use hierarchy with `MessagingComponentInstaller` configuring a child `MessagingComponent` using the provider asset. Drop it into a scene to see provider-driven wiring without writing setup code.
-
-## Walkthrough
-
-1. **Place the prefab**  
-   Drag `Prefabs/MessagingInstallerSample.prefab` into your test scene. The root object carries `MessagingComponentInstaller` with its provider handle already pointing at the global provider ScriptableObject.
-
-2. **Hook up the container**  
-   - **Zenject**:  
-     - Add `DxMessagingRegistrationInstaller` (from [Runtime/Unity/Integrations](../../Runtime/Unity/Integrations/)) to your ProjectContext or scene installer list.  
-     - Drop [SampleInstaller.cs](./Zenject/SampleInstaller.cs) into your project and register it alongside other installers. When the scene runs, the installer resolves `IMessageRegistrationBuilder`, stages a `PlayerSpawned` listener, and activates via the Zenject lifecycle.
-   - **VContainer**:  
-     - Define `VCONTAINER_PRESENT` and reference the optional extension under [VContainerRegistrationExtensions.cs](../../Runtime/Unity/Integrations/VContainerRegistrationExtensions.cs).  
-     - Add [SampleLifetimeScope.cs](./VContainer/SampleLifetimeScope.cs) to the scene (or derive from it); the sample scope registers the builder and an entry point that emits/consumes `ScoreUpdated` messages each tick.
-   - **Reflex**:  
-     - Enable `REFLEX_PRESENT` and install `DxMessagingRegistrationInstaller` into your container bootstrap.  
-     - Include [SampleInstaller.cs](./Reflex/SampleInstaller.cs) in your installer chain. The sample service resolves `IMessageRegistrationBuilder`, subscribes to `PlayerAlert`, and can emit alerts via `EmitAlertFor`.
-
-3. **Emit a message**  
-   Use the service exposed by the container (e.g., call into `ScoreboardService` or `PlayerAlertService`) to emit a message. Because the prefab already configured `MessagingComponent` instances via the installer, the listeners run immediately.
-
-4. **Swap providers** (optional)  
-   Duplicate [GlobalMessageBusProvider.asset](./Providers/GlobalMessageBusProvider.asset), modify it to return a custom bus, assign it on the prefab root, and observe how builder-created leases now resolve that bus instead.
-
-Feel free to duplicate these scripts into your own project and adjust lifecycles or message types as needed.
+# DxMessaging DI Samples
+
+These snippets illustrate how to consume `IMessageRegistrationBuilder` inside common Unity dependency injection containers. The scripts compile only when the corresponding scripting define is enabled and the container package is present.
+
+## Setup
+
+1. Install the relevant container package (Zenject/Extenject, VContainer, or Reflex) into your Unity project.
+1. Enable the matching scripting define symbol in **Project Settings > Player > Scripting Define Symbols**:
+   - `ZENJECT_PRESENT`
+   - `VCONTAINER_PRESENT`
+   - `REFLEX_PRESENT`
+1. Import the sample folder you need into your Unity project (`Assets/Samples/DxMessaging/*`).
+
+Each sample shows:
+
+- Registering `IMessageRegistrationBuilder` via the provided shim under [Runtime/Unity/Integrations](../../Runtime/Unity/Integrations/).
+- Constructing a `MessageRegistrationLease` in a container-managed service.
+- Activating/deactivating the lease using the container lifecycle.
+
+### Structure
+
+- Zenject sample installer: [SampleInstaller.cs](./Zenject/SampleInstaller.cs)
+- VContainer sample lifetime scope: [SampleLifetimeScope.cs](./VContainer/SampleLifetimeScope.cs)
+- Reflex sample installer: [SampleInstaller.cs](./Reflex/SampleInstaller.cs)
+- Current global message bus provider asset: [GlobalMessageBusProvider.asset](./Providers/GlobalMessageBusProvider.asset) -- ScriptableObject that resolves whichever bus is currently configured as global.
+- Initial global message bus provider asset: [InitialGlobalMessageBusProvider.asset](./Providers/InitialGlobalMessageBusProvider.asset) -- ScriptableObject that always returns the original startup global bus, ignoring later overrides.
+- Prefab setup: [MessagingInstallerSample.prefab](./Prefabs/MessagingInstallerSample.prefab) -- ready-to-use hierarchy with `MessagingComponentInstaller` configuring a child `MessagingComponent` using the provider asset. Drop it into a scene to see provider-driven wiring without writing setup code.
+
+## Walkthrough
+
+1. **Place the prefab**  
+   Drag `Prefabs/MessagingInstallerSample.prefab` into your test scene. The root object carries `MessagingComponentInstaller` with its provider handle already pointing at the global provider ScriptableObject.
+
+1. **Hook up the container**
+   - **Zenject**:
+     - Add `DxMessagingRegistrationInstaller` (from [Runtime/Unity/Integrations](../../Runtime/Unity/Integrations/)) to your ProjectContext or scene installer list.
+     - Drop [SampleInstaller.cs](./Zenject/SampleInstaller.cs) into your project and register it alongside other installers. When the scene runs, the installer resolves `IMessageRegistrationBuilder`, stages a `PlayerSpawned` listener, and activates via the Zenject lifecycle.
+   - **VContainer**:
+     - Define `VCONTAINER_PRESENT` and reference the optional extension under [VContainerRegistrationExtensions.cs](../../Runtime/Unity/Integrations/VContainer/VContainerRegistrationExtensions.cs).
+     - Add [SampleLifetimeScope.cs](./VContainer/SampleLifetimeScope.cs) to the scene (or derive from it); the sample scope registers the builder and an entry point that emits/consumes `ScoreUpdated` messages each tick.
+   - **Reflex**:
+     - Enable `REFLEX_PRESENT` and install `DxMessagingRegistrationInstaller` into your container bootstrap.
+     - Include [SampleInstaller.cs](./Reflex/SampleInstaller.cs) in your installer chain. The sample service resolves `IMessageRegistrationBuilder`, subscribes to `PlayerAlert`, and can emit alerts via `EmitAlertFor`.
+
+1. **Emit a message**  
+   Use the service exposed by the container (e.g., call into `ScoreboardService` or `PlayerAlertService`) to emit a message. Because the prefab already configured `MessagingComponent` instances via the installer, the listeners run immediately.
+
+1. **Swap providers** (optional)  
+   Duplicate [GlobalMessageBusProvider.asset](./Providers/GlobalMessageBusProvider.asset), modify it to return a custom bus, assign it on the prefab root, and observe how builder-created leases now resolve that bus instead.
+
+Feel free to duplicate these scripts into your own project and adjust lifecycles or message types as needed.

package/Samples~/DI/README.md.meta

@@ -1,7 +1,7 @@
-fileFormatVersion: 2
-guid: e3bac3e795986eb44becc1eadeb7756d
-TextScriptImporter:
-  externalObjects: {}
-  userData: 
-  assetBundleName: 
-  assetBundleVariant: 
+fileFormatVersion: 2
+guid: e3bac3e795986eb44becc1eadeb7756d
+TextScriptImporter:
+  externalObjects: {}
+  userData: 
+  assetBundleName: 
+  assetBundleVariant: 

package/Samples~/DI/Reflex/SampleInstaller.cs

@@ -17,6 +17,13 @@ namespace DxMessaging.Samples.DI.Reflex
     {
         protected override void InstallBindings()
         {
+            // Reflex today selects the public parameterless MessageBus constructor, so the bare
+            // Container.Bind<MessageBus>().AsSingleton() pattern works -- but it is fragile
+            // against future Reflex releases that broaden constructor scanning to non-public
+            // constructors (which would surface a clock-taking overload whose IDxMessagingClock
+            // dependency is not registered). When using the Reflex 8.0+ ContainerBuilder API,
+            // prefer ReflexRegistrationExtensions.AddDxMessagingBus, which uses an explicit
+            // factory that sidesteps reflection-based constructor selection entirely.
             Container.Bind<MessageBus>().AsSingleton();
             Container.Bind<IMessageBus>().FromContainer<MessageBus>();
 

package/Samples~/DI/Reflex/SampleInstaller.cs.meta

@@ -1,11 +1,11 @@
-fileFormatVersion: 2
-guid: 7d4c41a51a756ed40a140efe764197a9
-MonoImporter:
-  externalObjects: {}
-  serializedVersion: 2
-  defaultReferences: []
-  executionOrder: 0
-  icon: {instanceID: 0}
-  userData: 
-  assetBundleName: 
-  assetBundleVariant: 
+fileFormatVersion: 2
+guid: 7d4c41a51a756ed40a140efe764197a9
+MonoImporter:
+  externalObjects: {}
+  serializedVersion: 2
+  defaultReferences: []
+  executionOrder: 0
+  icon: {instanceID: 0}
+  userData: 
+  assetBundleName: 
+  assetBundleVariant: 

package/Samples~/DI/Reflex.meta

@@ -1,8 +1,8 @@
-fileFormatVersion: 2
-guid: 0ea2325747ab75e4589eac788c59b276
-folderAsset: yes
-DefaultImporter:
-  externalObjects: {}
-  userData: 
-  assetBundleName: 
-  assetBundleVariant: 
+fileFormatVersion: 2
+guid: 0ea2325747ab75e4589eac788c59b276
+folderAsset: yes
+DefaultImporter:
+  externalObjects: {}
+  userData: 
+  assetBundleName: 
+  assetBundleVariant: 

package/Samples~/DI/VContainer/SampleLifetimeScope.cs

@@ -18,7 +18,12 @@ namespace DxMessaging.Samples.DI.VContainer
     {
         protected override void Configure(IContainerBuilder builder)
         {
-            builder.Register<MessageBus.MessageBus>(Lifetime.Singleton).As<IMessageBus>();
+            // Always register MessageBus through RegisterDxMessagingBus. The bare pattern
+            // builder.Register<MessageBus>(Lifetime.Singleton).As<IMessageBus>() fails at
+            // resolution time because VContainer's TypeAnalyzer scans both public and private
+            // constructors and prefers the one with the most parameters; that overload takes
+            // an IDxMessagingClock that is not registered with the container.
+            builder.RegisterDxMessagingBus();
             builder.RegisterMessageRegistrationBuilder();
 
             builder.RegisterEntryPoint<ScoreboardService>(Lifetime.Singleton);

package/Samples~/DI/VContainer/SampleLifetimeScope.cs.meta

@@ -1,11 +1,11 @@
-fileFormatVersion: 2
-guid: 6dea981cef444594bbffa73a5e6905d5
-MonoImporter:
-  externalObjects: {}
-  serializedVersion: 2
-  defaultReferences: []
-  executionOrder: 0
-  icon: {instanceID: 0}
-  userData: 
-  assetBundleName: 
-  assetBundleVariant: 
+fileFormatVersion: 2
+guid: 6dea981cef444594bbffa73a5e6905d5
+MonoImporter:
+  externalObjects: {}
+  serializedVersion: 2
+  defaultReferences: []
+  executionOrder: 0
+  icon: {instanceID: 0}
+  userData: 
+  assetBundleName: 
+  assetBundleVariant: 

package/Samples~/DI/VContainer.meta

@@ -1,8 +1,8 @@
-fileFormatVersion: 2
-guid: e08544c97dd3b1540886f6b5f5f8f111
-folderAsset: yes
-DefaultImporter:
-  externalObjects: {}
-  userData: 
-  assetBundleName: 
-  assetBundleVariant: 
+fileFormatVersion: 2
+guid: e08544c97dd3b1540886f6b5f5f8f111
+folderAsset: yes
+DefaultImporter:
+  externalObjects: {}
+  userData: 
+  assetBundleName: 
+  assetBundleVariant: 

package/Samples~/DI/Zenject/SampleInstaller.cs

@@ -15,6 +15,14 @@ namespace DxMessaging.Samples.DI.Zenject
     {
         public override void InstallBindings()
         {
+            // The MessageBus is bound elsewhere (typically through
+            // ZenjectRegistrationExtensions.BindDxMessagingBus, which uses an explicit factory).
+            // Avoid the bare Container.Bind<MessageBus>().AsSingle() pattern: Zenject today picks
+            // the public parameterless constructor, but its constructor-selection behaviour is
+            // version-sensitive, and a future release could broaden scanning to non-public
+            // constructors -- which would surface a clock-taking overload whose
+            // IDxMessagingClock dependency is not registered. The helper sidesteps that risk.
+
             // Ensure the builder is available (provided by DxMessagingRegistrationInstaller).
             Container.BindInterfacesTo<PlayerSpawnTracker>().AsSingle();
         }

package/Samples~/DI/Zenject/SampleInstaller.cs.meta

@@ -1,11 +1,11 @@
-fileFormatVersion: 2
-guid: 85ad1f9014b26d34caddf778e694f493
-MonoImporter:
-  externalObjects: {}
-  serializedVersion: 2
-  defaultReferences: []
-  executionOrder: 0
-  icon: {instanceID: 0}
-  userData: 
-  assetBundleName: 
-  assetBundleVariant: 
+fileFormatVersion: 2
+guid: 85ad1f9014b26d34caddf778e694f493
+MonoImporter:
+  externalObjects: {}
+  serializedVersion: 2
+  defaultReferences: []
+  executionOrder: 0
+  icon: {instanceID: 0}
+  userData: 
+  assetBundleName: 
+  assetBundleVariant: 

package/Samples~/DI/Zenject.meta

@@ -1,8 +1,8 @@
-fileFormatVersion: 2
-guid: f772f4742ae2c4d4d8160700ab28009b
-folderAsset: yes
-DefaultImporter:
-  externalObjects: {}
-  userData: 
-  assetBundleName: 
-  assetBundleVariant: 
+fileFormatVersion: 2
+guid: f772f4742ae2c4d4d8160700ab28009b
+folderAsset: yes
+DefaultImporter:
+  externalObjects: {}
+  userData: 
+  assetBundleName: 
+  assetBundleVariant: 

package/Samples~/DI.meta

@@ -1,8 +1,8 @@
-fileFormatVersion: 2
-guid: 7f6cc70d4b4c2684b82c30c14d1ae67e
-folderAsset: yes
-DefaultImporter:
-  externalObjects: {}
-  userData: 
-  assetBundleName: 
-  assetBundleVariant: 
+fileFormatVersion: 2
+guid: 7f6cc70d4b4c2684b82c30c14d1ae67e
+folderAsset: yes
+DefaultImporter:
+  externalObjects: {}
+  userData: 
+  assetBundleName: 
+  assetBundleVariant: 

package/Samples~/Mini Combat/Boot.cs.meta

@@ -1,11 +1,11 @@
-fileFormatVersion: 2
-guid: c481ed585ce359a40a4ae7ff84ee2a17
-MonoImporter:
-  externalObjects: {}
-  serializedVersion: 2
-  defaultReferences: []
-  executionOrder: 0
-  icon: {instanceID: 0}
-  userData: 
-  assetBundleName: 
-  assetBundleVariant: 
+fileFormatVersion: 2
+guid: c481ed585ce359a40a4ae7ff84ee2a17
+MonoImporter:
+  externalObjects: {}
+  serializedVersion: 2
+  defaultReferences: []
+  executionOrder: 0
+  icon: {instanceID: 0}
+  userData: 
+  assetBundleName: 
+  assetBundleVariant: 

package/Samples~/Mini Combat/Enemy.cs.meta

@@ -1,11 +1,11 @@
-fileFormatVersion: 2
-guid: c29a2402fe384704a997386c3ce60936
-MonoImporter:
-  externalObjects: {}
-  serializedVersion: 2
-  defaultReferences: []
-  executionOrder: 0
-  icon: {instanceID: 0}
-  userData: 
-  assetBundleName: 
-  assetBundleVariant: 
+fileFormatVersion: 2
+guid: c29a2402fe384704a997386c3ce60936
+MonoImporter:
+  externalObjects: {}
+  serializedVersion: 2
+  defaultReferences: []
+  executionOrder: 0
+  icon: {instanceID: 0}
+  userData: 
+  assetBundleName: 
+  assetBundleVariant: 

package/Samples~/Mini Combat/Messages.cs.meta

@@ -1,11 +1,11 @@
-fileFormatVersion: 2
-guid: d37f729431cb3c84b9b2efd8aada7742
-MonoImporter:
-  externalObjects: {}
-  serializedVersion: 2
-  defaultReferences: []
-  executionOrder: 0
-  icon: {instanceID: 0}
-  userData: 
-  assetBundleName: 
-  assetBundleVariant: 
+fileFormatVersion: 2
+guid: d37f729431cb3c84b9b2efd8aada7742
+MonoImporter:
+  externalObjects: {}
+  serializedVersion: 2
+  defaultReferences: []
+  executionOrder: 0
+  icon: {instanceID: 0}
+  userData: 
+  assetBundleName: 
+  assetBundleVariant: 

package/Samples~/Mini Combat/Player.cs.meta

@@ -1,11 +1,11 @@
-fileFormatVersion: 2
-guid: 62939e09945c3bd488ceffabb9e01ed8
-MonoImporter:
-  externalObjects: {}
-  serializedVersion: 2
-  defaultReferences: []
-  executionOrder: 0
-  icon: {instanceID: 0}
-  userData: 
-  assetBundleName: 
-  assetBundleVariant: 
+fileFormatVersion: 2
+guid: 62939e09945c3bd488ceffabb9e01ed8
+MonoImporter:
+  externalObjects: {}
+  serializedVersion: 2
+  defaultReferences: []
+  executionOrder: 0
+  icon: {instanceID: 0}
+  userData: 
+  assetBundleName: 
+  assetBundleVariant: