cloudcms-server 0.9.301 → 3.2.280

package/middleware/cache/providers/redis.js

@@ -1,7 +1,5 @@
-var path = require("path");
-
-var redis = require("redis");
-var logFactory = require("../../../util/logger");
+var redisClientFactory = require("../../../clients/redis");
+const redisHelper = require("../../../util/redis");
 
 /**
  * Redis distributed cache.
@@ -11,123 +9,163 @@ var logFactory = require("../../../util/logger");
 exports = module.exports = function(cacheConfig)
 {
     var client = null;
-
-    var logger = this.logger = logFactory("REDIS CACHE");
-    logger.setLevel("error");
-
-    // allow for global redis default
-    // allow for redis broadcast specific
-    // otherwise default to error
-    if (typeof(process.env.CLOUDCMS_REDIS_DEBUG_LEVEL) !== "undefined") {
-        logger.setLevel(("" + process.env.CLOUDCMS_REDIS_DEBUG_LEVEL).toLowerCase(), true);
-    }
-    else if (typeof(process.env.CLOUDCMS_CACHE_REDIS_DEBUG_LEVEL) !== "undefined") {
-        logger.setLevel(("" + process.env.CLOUDCMS_CACHE_REDIS_DEBUG_LEVEL).toLowerCase(), true);
-    }
+    
+    var logger = redisHelper.redisLogger("REDIS_CACHE", "CLOUDCMS_CACHE_", "error")
 
     var r = {};
 
     r.init = function(callback)
     {
-        var redisPort = cacheConfig.port;
-        if (typeof(redisPort) === "undefined" || !redisPort)
-        {
-            redisPort = process.env.CLOUDCMS_CACHE_REDIS_PORT;
-        }
-        if (typeof(redisPort) === "undefined" || !redisPort)
-        {
-            redisPort = process.env.CLOUDCMS_REDIS_PORT;
-        }
-
-        var redisEndpoint = cacheConfig.endpoint;
-        if (typeof(redisEndpoint) === "undefined" || !redisEndpoint)
-        {
-            redisEndpoint = process.env.CLOUDCMS_CACHE_REDIS_ENDPOINT;
-        }
-        if (typeof(redisEndpoint) === "undefined" || !redisEndpoint)
-        {
-            redisEndpoint = process.env.CLOUDCMS_REDIS_ENDPOINT;
-        }
-
-        var redisOptions = {};
-
-        //redis.debug_mode = true;
-
-        client = redis.createClient(redisPort, redisEndpoint, redisOptions);
-
-        callback();
+        redisClientFactory.create(cacheConfig, function(err, _client) {
+    
+            if (err) {
+                return callback(err);
+            }
+    
+            client = _client;
+    
+            return callback();
+    
+        });
     };
 
     r.write = function(key, value, seconds, callback)
     {
-        if (seconds <= -1)
-        {
-            client.set([key, JSON.stringify(value)], function(err, reply) {
-                if (err) {
-                    logger.error("write error. key: " + key + " value: " + JSON.stringify(value) + ". error:" + err);
+        logger.info('write, key = ' + key + ', value = ' + value + ', seconds = ' + seconds + ', typeofval: ' + typeof(value));
+        (async function() {
+    
+            var reply = null;
+            var err = null;
+    
+            try
+            {
+                var config = {};
+                if (seconds >= 0) {
+                    config["EX"] = seconds;
                 }
+                
+                reply = await client.set(key, JSON.stringify(value), config);
+            }
+            catch (e)
+            {
+                err = e;
+            }
+    
+            if (reply) {
                 logger.info("write -> reply = " + reply);
-                callback(err, reply);
-            });
-        }
-        else
-        {
-            client.set([key, JSON.stringify(value), "EX", seconds], function(err, reply) {
-                if (err) {
-                    logger.error("write.ex error. key: " + key + " value: " + JSON.stringify(value) + ". error:" + err);
-                }
-                logger.info("write.ex -> reply = " + reply);
-                callback(err, reply);
-            });
-        }
+            }
+    
+            if (err) {
+                logger.error("write error. key: " + key + " value: " + JSON.stringify(value) + ". error:" + err + ", value type: " + typeof(value));
+            }
+    
+            callback(err, reply);
+            
+        })();
     };
 
-    r.read = function(key, callback)
-    {
-        client.get([key], function(err, reply) {
+    r.read = function(key, callback)
+    {
+        logger.info('read, key = ' + key);
 
+        (async function() {
+    
+            var err = null;
+            var reply = null;
+    
+            try
+            {
+                reply = await client.get(key);
+            }
+            catch (e)
+            {
+                err = e;
+            }
+    
             if (err) {
-                logger.error("read error. key: " + key + ". error:" + err);
+                logger.error("read error. key: " + key + ". error: " + err);
+            }
+    
+            if (reply) {
+                logger.info("read. key: " + key + " -> reply = " + reply);
             }
-            logger.info("read. key: " + key + " -> reply = " + reply);
-            
+    
             var result = null;
-            try
+            try
             {
-                result = JSON.parse(reply);
-            }
+                result = JSON.parse(reply);
+            }
             catch (ex)
             {
-                result = null;
-                err = ex;
-                if (err) {
+                result = null;
+                err = ex;
+        
+                if (err)
+                {
                     logger.error("error parsing reply. key: " + key + ". error:" + err);
                 }
-            }
-
+            }
+    
             callback(err, result);
-        });
-    };
+        })();
+    };
 
     r.remove = function(key, callback)
     {
-        logger.info("remove. key: " + key);
-        client.del([key], function(err) {
+        logger.info('remove, key = ' + key);
+    
+        (async function() {
+    
+            var err = null;
+            
+            try
+            {
+                await client.del(key);
+                logger.info("remove. key: " + key);
+            }
+            catch (e)
+            {
+                err = e;
+            }
+    
+            if (err) {
+                logger.error("del error. key: " + key + ". error: " + err);
+            }
+    
             callback(err);
-        });
+        })();
     };
     
     r.keys = function(prefix, callback)
-    {
-        logger.info('keys. prefix = ' + prefix);
-        client.keys([prefix + '*'], function(err, reply) {
+    {
+        logger.info('keys, prefix = ' + prefix);
+        
+        (async function() {
+    
+            var err = null;
+            var reply = null;
+    
+            try
+            {
+                reply = await client.keys(prefix + '*');
+            }
+            catch (e)
+            {
+                err = e;
+            }
+    
             if (err) {
-                logger.error("error reading prefix: " + prefix + ". error:" + err);
+                logger.error("error reading keys for prefix: " + prefix + ". error:" + err);
             }
-            logger.info("[keys -> reply = " + reply);
-            callback(err, reply);
-        });
-    };
+    
+            if (reply) {
+                logger.info("keys -> reply = " + reply);
+            }
+    
+            callback(err, reply);
+            
+        })();
+    };
 
     return r;
 };

package/middleware/cloudcms/cloudcms.js

@@ -436,8 +436,18 @@ exports = module.exports = function()
         }
 
         // only allow one "thread" at a time to load the branch
-        _LOCK(cacheKey, function(releaseLockFn) {
-
+        _LOCK(cacheKey, function(err, releaseLockFn) {
+            
+            if (err) {
+                return callback(err);
+            }
+    
+            var branch = CACHED_BRANCHES[cacheKey];
+            if (branch) {
+                callback(null, Chain(branch));
+                return releaseLockFn();
+            }
+            
             var loadFn = function(finished) {
 
                 Chain(repository).trap(function(e) {
@@ -464,23 +474,21 @@ exports = module.exports = function()
 
                         if (err) {
 
+                            callback(err);
+                            
                             // release the lock
-                            releaseLockFn();
-
-                            // do the callback
-                            return callback(err);
+                            return releaseLockFn();
                         }
 
                         // success!
 
                         // store in cache
                         CACHED_BRANCHES[cacheKey] = branch;
-
+    
+                        callback(null, branch);
+                        
                         // release the lock
-                        releaseLockFn();
-
-                        // do the callback
-                        return callback(null, branch);
+                        return releaseLockFn();
                     });
                 }
 
@@ -1439,11 +1447,10 @@ exports = module.exports = function()
 
                     // the range requested (for streaming)
                     //var range = req.headers["range"];
-
+    
                     cloudcmsUtil.preview(contentStore, gitana, repositoryId, branchId, nodeId, nodePath, attachmentId, locale, previewId, size, mimetype, forceReload, function(err, filePath, cacheInfo, releaseLock) {
 
-                        if (err)
-                        {
+                        if (err) {
                             req.log("Error on preview node: " + err.message + ", err: " + JSON.stringify(err));
                         }
 
@@ -1475,8 +1482,7 @@ exports = module.exports = function()
                                 // UZI: file deleted by invalidate before this gets called
                                 contentStore.sendFile(res, filePath, cacheInfo, function(err) {
 
-                                    if (err)
-                                    {
+                                    if (err) {
                                         util.handleSendFileError(req, res, filePath, cacheInfo, req.log, err);
                                     }
 

package/middleware/form/form.js

@@ -121,7 +121,7 @@ exports = module.exports = function()
             }
 
             // post form to Cloud CMS using public method
-            var URL = util.asURL(process.env.GITANA_PROXY_SCHEME, process.env.GITANA_PROXY_HOST, process.env.GITANA_PROXY_PORT) + url;
+            var URL = util.asURL(process.env.GITANA_PROXY_SCHEME, process.env.GITANA_PROXY_HOST, process.env.GITANA_PROXY_PORT, process.env.GITANA_PROXY_PATH) + url;
 
             var headers = {};
             headers["Authorization"] = req.gitana.platform().getDriver().getHttpHeaders()["Authorization"];
@@ -194,7 +194,7 @@ exports = module.exports = function()
 
             var url = branch.getUri() + "/alpaca/datasource";
 
-            var URL = util.asURL(process.env.GITANA_PROXY_SCHEME, process.env.GITANA_PROXY_HOST, process.env.GITANA_PROXY_PORT) + url;
+            var URL = util.asURL(process.env.GITANA_PROXY_SCHEME, process.env.GITANA_PROXY_HOST, process.env.GITANA_PROXY_PORT, process.env.GITANA_PROXY_PATH) + url;
 
             var headers = {};
             headers["Authorization"] = req.gitana.platform().getDriver().getHttpHeaders()["Authorization"];

package/middleware/proxy/proxy.js

@@ -1,16 +1,6 @@
 var path = require('path');
-// var fs = require('fs');
-// var http = require('http');
-// var https = require('https');
-
-// var httpProxy = require('http-proxy');
-
-// var oauth2 = require("../../util/oauth2")();
-
-// var async = require("async");
 
 var util = require("../../util/util");
-// var auth = require("../../util/auth");
 
 var proxyFactory = require("../../util/proxy-factory");
 
@@ -82,20 +72,17 @@ exports = module.exports = function()
         contentStore.existsFile(filePath, function(exists) {
 
             if (!exists) {
-                callback();
-                return;
+                return callback();
             }
 
             contentStore.fileStats(filePath, function(err, stats) {
 
                 if (err) {
-                    callback();
-                    return;
+                    return callback();
                 }
 
-                if (stats.size == 0) {
-                    callback();
-                    return;
+                if (stats.size === 0) {
+                    return callback();
                 }
 
                 var handleGoodStream = function()
@@ -117,8 +104,7 @@ exports = module.exports = function()
                 // check cacheInfo for expireTime
                 contentStore.readFile(filePath + ".cache", function(err, cacheInfoText) {
 
-                    if (err || !cacheInfoText)
-                    {
+                    if (err || !cacheInfoText) {
                         return handleBadStream();
                     }
 
@@ -215,7 +201,6 @@ exports = module.exports = function()
                 contentStore.writeFile(filePath + ".cache", JSON.stringify(cacheInfo), function() {
                     _end.call(res, data, encoding);
                 });
-
             };
 
             callback();
@@ -238,7 +223,7 @@ exports = module.exports = function()
                 {
                     req.url = "/";
                 }
-
+                
                 // caching scenario
                 _handleCacheRead(req, function (err, readStream) {
 
@@ -258,6 +243,7 @@ exports = module.exports = function()
                                 "message": "Missing baseURL from request bound gitana-config"
                             });
                         }
+                        
                         proxyFactory.acquireProxyHandler(proxyTarget, null, function(err, proxyHandler) {
                             if (err) {
                                 return next(err);

package/middleware/stores/stores.js

@@ -175,7 +175,7 @@ exports = module.exports = function()
             if (!stores) {
                 return afterCheck();
             }
-
+    
             return process.cache.read("module-descriptors-" + host, function(err, moduleDescriptorsForHost) {
 
                 if (err) {
@@ -481,7 +481,7 @@ exports = module.exports = function()
                         callback();
                     });
                 };
-
+    
                 process.cache.read("module-descriptors-" + host, function(err, moduleDescriptors) {
 
                     moduleDescriptors = null;

package/middleware/virtual-config/virtual-config.js

@@ -83,7 +83,7 @@ exports = module.exports = function()
 
                 var URL = configuration.virtualDriver.baseURL;
                 if (!URL) {
-                    URL = util.asURL(process.env.GITANA_PROXY_SCHEME, process.env.GITANA_PROXY_HOST, process.env.GITANA_PROXY_PORT);
+                    URL = util.asURL(process.env.GITANA_PROXY_SCHEME, process.env.GITANA_PROXY_HOST, process.env.GITANA_PROXY_PORT, process.env.GITANA_PROXY_PATH);
                 }
                 URL += "/virtual/driver/config";
                 var requestConfig = {
@@ -147,10 +147,10 @@ exports = module.exports = function()
         }
     };
 
-    var _LOCK = function(lockKey, workFunction)
-    {
-        process.locks.lock(lockKey, workFunction);
-    };
+    // var _LOCK = function(lockKey, workFunction)
+    // {
+    //     process.locks.lock(lockKey, workFunction);
+    // };
 
     var r = {};
 
@@ -217,7 +217,7 @@ exports = module.exports = function()
                         }
                         if (!gitanaJson.baseURL)
                         {
-                            gitanaJson.baseURL = util.cleanupURL(util.asURL(process.env.GITANA_PROXY_SCHEME, process.env.GITANA_PROXY_HOST, process.env.GITANA_PROXY_PORT));
+                            gitanaJson.baseURL = util.cleanupURL(util.asURL(process.env.GITANA_PROXY_SCHEME, process.env.GITANA_PROXY_HOST, process.env.GITANA_PROXY_PORT, process.env.GITANA_PROXY_PATH));
                         }
 
                         // mark as retrieved from virtual driver
@@ -340,7 +340,7 @@ exports = module.exports = function()
             // defaults
             if (!configuration.baseURL)
             {
-                configuration.baseURL = util.asURL(process.env.GITANA_PROXY_SCHEME, process.env.GITANA_PROXY_HOST, process.env.GITANA_PROXY_PORT);
+                configuration.baseURL = util.asURL(process.env.GITANA_PROXY_SCHEME, process.env.GITANA_PROXY_HOST, process.env.GITANA_PROXY_PORT, process.env.GITANA_PROXY_PATH);
             }
             if (!configuration.key) {
                 configuration.key = "virtual";

package/middleware/wcm/wcm.js

@@ -309,7 +309,7 @@ exports = module.exports = function()
                     req.application(function (err, application) {
 
                         var loadingPagesCacheKey = application._doc + "-wcm-loading-pages";
-                        _LOCK(null, loadingPagesCacheKey, function (releaseLockFn) {
+                        _LOCK(null, loadingPagesCacheKey, function (err, releaseLockFn) {
                             
                             // check again inside lock in case another request preloaded this before we arrived
                             req.cache.read(WCM_PAGES, function (err, cachedPages) {
@@ -716,7 +716,7 @@ exports = module.exports = function()
         var cacheFilePath = cloudcms.toCacheFilePath(pageFilePath);
 
         // take out a lock so that only one "request" can write to cache at a time for this path
-        _LOCK(contentStore, _lock_identifier(pageBasePath), function(releaseLockFn) {
+        _LOCK(contentStore, _lock_identifier(pageBasePath), function(err, releaseLockFn) {
 
             // write page file
             contentStore.writeFile(pageFilePath, text, function (err) {
@@ -773,7 +773,7 @@ exports = module.exports = function()
         var cacheFilePath = cloudcms.toCacheFilePath(pageFilePath);
 
         // take out a lock so that only one "request" can read from cache at a time for this path
-        _LOCK(contentStore, _lock_identifier(pageBasePath), function(releaseLockFn) {
+        _LOCK(contentStore, _lock_identifier(pageBasePath), function(err, releaseLockFn) {
 
             contentStore.readFile(cacheFilePath, function(err, cacheInfoString) {
 
@@ -858,7 +858,7 @@ exports = module.exports = function()
 
     var _handleCachePageInvalidate = function(contentStore, pageBasePath, callback)
     {
-        _LOCK(contentStore, _lock_identifier(pageBasePath), function(releaseLockFn) {
+        _LOCK(contentStore, _lock_identifier(pageBasePath), function(err, releaseLockFn) {
 
             contentStore.existsDirectory(pageBasePath, function (exists) {