cloudcms-server 0.9.301 → 3.2.280

package/util/cloudcms.js

@@ -68,26 +68,23 @@ exports = module.exports = function()
     {
         if (!repositoryId)
         {
-            callback({
+            return callback({
                 "message": "Missing repositoryId in ensureContentDirectory()"
             });
-            return;
         }
 
         if (!branchId)
         {
-            callback({
+            return callback({
                 "message": "Missing branchId in ensureContentDirectory()"
             });
-            return;
         }
 
         if (!locale)
         {
-            callback({
+            return callback({
                 "message": "Missing locale in ensureContentDirectory()"
             });
-            return;
         }
 
         var contentDirectoryPath = path.join(repositoryId, branchId, nodeId, locale);
@@ -148,21 +145,17 @@ exports = module.exports = function()
             if (err)
             {
                 // nothing found
-                callback({
+                return callback({
                     "message": "Nothing cached on disk"
                 });
-
-                return;
             }
 
             if (!cacheInfoString)
             {
                 // nothing found
-                callback({
+                return callback({
                     "message": "Nothing cached on disk"
                 });
-
-                return;
             }
 
             var invalidate = function () {
@@ -346,25 +339,40 @@ exports = module.exports = function()
         {
             if (attemptCount === maxAttemptsAllowed)
             {
-                cb({
+                return cb({
                     "message": "Maximum number of connection attempts exceeded(" + maxAttemptsAllowed + ")",
                     "err": previousError
                 });
-
-                return;
             }
-
-            contentStore.writeStream(filePath, function(err, tempStream) {
-
-                if (err)
+            
+            var failFast = function(contentStore, filePath, cb) {
+                var triggered = false;
+                
+                return function(tempStream, err)
                 {
+                    // don't allow this to be called twice
+                    if (triggered) {
+                        return;
+                    }
+    
+                    triggered = true;
+                    
                     // ensure stream is closed
-                    closeWriteStream(tempStream);
-
+                    if (tempStream) {
+                        closeWriteStream(tempStream);
+                    }
+    
                     // ensure cleanup
                     return safeRemove(contentStore, filePath, function () {
                         cb(err);
                     });
+                };
+            }(contentStore, filePath, cb);
+            
+            contentStore.writeStream(filePath, function(err, tempStream) {
+
+                if (err) {
+                    return failFast(tempStream, err);
                 }
 
                 var cacheFilePath = toCacheFilePath(filePath);
@@ -382,7 +390,7 @@ exports = module.exports = function()
                     agent = https.globalAgent;
                 }
 
-                var URL = util.asURL(process.env.GITANA_PROXY_SCHEME, process.env.GITANA_PROXY_HOST, process.env.GITANA_PROXY_PORT) + uri;
+                var URL = util.asURL(process.env.GITANA_PROXY_SCHEME, process.env.GITANA_PROXY_HOST, process.env.GITANA_PROXY_PORT, process.env.GITANA_PROXY_PATH) + uri;
                 request({
                     "method": "GET",
                     "url": URL,
@@ -398,18 +406,10 @@ exports = module.exports = function()
                     {
                         response.pipe(tempStream).on("close", function (err) {
 
-                            // TODO: not needed here?
-                            // ensure stream is closed
-                            // closeWriteStream(tempStream);
-
                             if (err)
                             {
                                 // some went wrong at disk io level?
-                                return safeRemove(contentStore, filePath, function () {
-                                    cb({
-                                        "message": "Failed to download: " + JSON.stringify(err)
-                                    });
-                                });
+                                return failFast(tempStream, err);
                             }
 
                             contentStore.existsFile(filePath, function (exists) {
@@ -418,55 +418,39 @@ exports = module.exports = function()
 
                                     // write cache file
                                     var cacheInfo = buildCacheInfo(response);
-                                    if (cacheInfo)
-                                    {
-                                        contentStore.writeFile(cacheFilePath, JSON.stringify(cacheInfo, null, "    "), function (err) {
-
-                                            if (err)
-                                            {
-                                                // failed to write cache file, thus the whole thing is invalid
-                                                safeRemove(contentStore, cacheFilePath, function () {
-                                                    safeRemove(contentStore, filePath, function () {
-                                                        cb({
-                                                            "message": "Failed to write cache file: " + cacheFilePath
-                                                        });
-                                                    });
+                                    if (!cacheInfo) {
+                                        return cb(null, filePath, null);
+                                    }
+                                    
+                                    contentStore.writeFile(cacheFilePath, JSON.stringify(cacheInfo, null, "    "), function (err) {
+
+                                        if (err)
+                                        {
+                                            // failed to write cache file, thus the whole thing is invalid
+                                            return safeRemove(contentStore, cacheFilePath, function () {
+                                                failFast(tempStream, {
+                                                    "message": "Failed to write cache file: " + cacheFilePath + ", err: " + JSON.stringify(err)
                                                 });
-                                            }
-                                            else
-                                            {
-                                                cb(null, filePath, cacheInfo);
-                                            }
+                                            });
+                                        }
 
-                                        });
-                                    }
-                                    else
-                                    {
                                         cb(null, filePath, cacheInfo);
-                                    }
+                                    });
                                 }
                                 else
                                 {
-                                    //process.log("WARN: exists false, " + filePath);
-
                                     // for some reason, file wasn't found
                                     // roll back the whole thing
                                     safeRemove(contentStore, cacheFilePath, function () {
-                                        safeRemove(contentStore, filePath, function () {
-                                            cb({
-                                                "message": "Failed to verify written cached file: " + filePath
-                                            });
+                                        failFast(tempStream, {
+                                            "message": "Failed to verify written cached file: " + filePath
                                         });
                                     });
                                 }
                             });
 
                         }).on("error", function (err) {
-
-                            // ensure stream is closed
-                            closeWriteStream(tempStream);
-
-                            process.log("Pipe error: " + err);
+                            failFast(tempStream, err);
                         });
                     }
                     else
@@ -480,10 +464,7 @@ exports = module.exports = function()
                         });
 
                         response.on('end', function () {
-
-                            // ensure stream is closed
-                            closeWriteStream(tempStream);
-
+                            
                             var afterCleanup = function () {
 
                                 // see if it is "invalid_token"
@@ -518,9 +499,11 @@ exports = module.exports = function()
                                     "code": response.statusCode,
                                     "body": body
                                 });
-
                             };
-
+    
+                            // ensure stream is closed
+                            closeWriteStream(tempStream);
+    
                             // clean things up
                             safeRemove(contentStore, cacheFilePath, function () {
                                 safeRemove(contentStore, filePath, function () {
@@ -532,12 +515,8 @@ exports = module.exports = function()
                     }
 
                 }).on('error', function (e) {
-
-                    // ensure stream is closed
-                    closeWriteStream(tempStream);
-
-                    process.log("_writeToDisk request timed out");
-                    process.log(e)
+                    failFast(tempStream, e);
+    
                 }).on('end', function (e) {
 
                     // ensure stream is closed
@@ -548,9 +527,11 @@ exports = module.exports = function()
                 tempStream.on("error", function (e) {
                     process.log("Temp stream errored out");
                     process.log(e);
+    
+                    failFast(tempStream, e);
 
                     // ensure stream is closed
-                    closeWriteStream(tempStream);
+                    //closeWriteStream(tempStream);
 
                 });
             });
@@ -608,8 +589,7 @@ exports = module.exports = function()
                 readFromDisk(contentStore, filePath, function (err, cacheInfo) {
 
                     if (!err && cacheInfo) {
-                        callback(err, filePath, cacheInfo);
-                        return;
+                        return callback(err, filePath, cacheInfo);
                     }
 
                     // either there was an error (in which case things were cleaned up)
@@ -631,13 +611,12 @@ exports = module.exports = function()
 
                         if (err) {
                             process.log("writeToDisk error, err: " + err.message + ", body: " + err.body);
-                            callback(err);
-                        }
-                        else {
-                            //process.log("Fetched: " + assetPath);
-                            //process.log("Retrieved from server: " + filePath);
-                            callback(null, filePath, cacheInfo);
+                            return callback(err);
                         }
+
+                        //process.log("Fetched: " + assetPath);
+                        //process.log("Retrieved from server: " + filePath);
+                        callback(null, filePath, cacheInfo);
                     });
                 });
             };
@@ -749,6 +728,7 @@ exports = module.exports = function()
                     writeToDisk(contentStore, gitana, uri, filePath, function (err, filePath, responseHeaders) {
 
                         if (err) {
+                            
                             if (err.code === 404) {
                                 return callback();
                             }
@@ -1072,7 +1052,7 @@ exports = module.exports = function()
     r.download = function(contentStore, gitana, repositoryId, branchId, nodeId, attachmentId, nodePath, locale, forceReload, callback)
     {
         // claim a lock around this node for this server
-        _LOCK(contentStore, _lock_identifier(repositoryId, branchId, nodeId), function(releaseLockFn) {
+        _LOCK(contentStore, _lock_identifier(repositoryId, branchId, nodeId), function(err, releaseLockFn) {
 
             // workhorse - pass releaseLockFn back to callback
             downloadNode(contentStore, gitana, repositoryId, branchId, nodeId, attachmentId, nodePath, locale, forceReload, function (err, filePath, cacheInfo) {
@@ -1085,7 +1065,7 @@ exports = module.exports = function()
     r.preview = function(contentStore, gitana, repositoryId, branchId, nodeId, nodePath, attachmentId, locale, previewId, size, mimetype, forceReload, callback)
     {
         // claim a lock around this node for this server
-        _LOCK(contentStore, _lock_identifier(repositoryId, branchId, nodeId), function(releaseLockFn) {
+        _LOCK(contentStore, _lock_identifier(repositoryId, branchId, nodeId), function(err, releaseLockFn) {
 
             // workhorse - pass releaseLockFn back to callback
             previewNode(contentStore, gitana, repositoryId, branchId, nodeId, nodePath, attachmentId, locale, previewId, size, mimetype, forceReload, function(err, filePath, cacheInfo) {
@@ -1098,10 +1078,9 @@ exports = module.exports = function()
     r.invalidate = function(contentStore, repositoryId, branchId, nodeId, paths, callback)
     {
         // claim a lock around this node for this server
-        _LOCK(contentStore, _lock_identifier(repositoryId, branchId, nodeId), function(releaseLockFn) {
+        _LOCK(contentStore, _lock_identifier(repositoryId, branchId, nodeId), function(err, releaseLockFn) {
 
             invalidateNode(contentStore, repositoryId, branchId, nodeId, function () {
-
                 invalidateNodePaths(contentStore, repositoryId, branchId, paths, function() {
 
                     // release lock
@@ -1118,7 +1097,7 @@ exports = module.exports = function()
     r.downloadAttachable = function(contentStore, gitana, datastoreTypeId, datastoreId, objectTypeId, objectId, attachmentId, locale, forceReload, callback)
     {
         // claim a lock around this node for this server
-        _LOCK(contentStore, _lock_identifier(datastoreId, objectId), function(releaseLockFn) {
+        _LOCK(contentStore, _lock_identifier(datastoreId, objectId), function(err, releaseLockFn) {
 
             // workhorse - pass releaseLockFn back to callback
             downloadAttachable(contentStore, gitana, datastoreTypeId, datastoreId, objectTypeId, objectId, attachmentId, locale, forceReload, function(err, filePath, cacheInfo) {
@@ -1131,7 +1110,7 @@ exports = module.exports = function()
     r.previewAttachable = function(contentStore, gitana, datastoreTypeId, datastoreId, objectTypeId, objectId, attachmentId, locale, previewId, size, mimetype, forceReload, callback)
     {
         // claim a lock around this node for this server
-        _LOCK(contentStore, _lock_identifier(datastoreId, objectId), function(releaseLockFn) {
+        _LOCK(contentStore, _lock_identifier(datastoreId, objectId), function(err, releaseLockFn) {
 
             // workhorse - pass releaseLockFn back to callback
             previewAttachable(contentStore, gitana, datastoreTypeId, datastoreId, objectTypeId, objectId, attachmentId, locale, previewId, size, mimetype, forceReload, function (err, filePath, cacheInfo) {
@@ -1144,7 +1123,7 @@ exports = module.exports = function()
     r.invalidateAttachable = function(contentStore, datastoreTypeId, datastoreId, objectTypeId, objectId, callback)
     {
         // claim a lock around this node for this server
-        _LOCK(contentStore, _lock_identifier(datastoreId, objectId), function(releaseLockFn) {
+        _LOCK(contentStore, _lock_identifier(datastoreId, objectId), function(err, releaseLockFn) {
 
             // TODO: not implemented
             callback();