claudeup 4.10.2 → 4.11.1

package/src/services/plugin-version-check.ts

@@ -0,0 +1,355 @@
+/**
+ * Plugin version mismatch detection and fix.
+ *
+ * Claude Code's plugin loader (pluginLoader.ts:2051) takes the FIRST entry
+ * from installed_plugins.json for each plugin ID:
+ *
+ *   const installEntry = installedPluginsData.plugins[pluginId]?.[0]
+ *
+ * This means the first project to install a plugin determines which version
+ * loads for ALL projects. When different projects install different versions,
+ * only the one at index [0] takes effect.
+ *
+ * Bug report: https://github.com/anthropics/claude-code/issues/45997
+ */
+
+import type { InstalledPluginEntry } from "../types/index.js";
+import {
+	getEnabledPlugins,
+	getGlobalEnabledPlugins,
+	getLocalEnabledPlugins,
+	readInstalledPluginsRegistry,
+	writeInstalledPluginsRegistry,
+} from "./claude-settings.js";
+
+const BUG_REPORT_URL = "https://github.com/anthropics/claude-code/issues/45997";
+
+// ── Types ────────────────────────────────────────────────────────────────────
+
+export interface VersionMismatchInfo {
+	/** Plugin ID, e.g. "terminal@magus" */
+	pluginId: string;
+	/** Version at entries[0] — the one Claude Code actually loads */
+	firstEntryVersion: string;
+	/** Project path of the entries[0] entry */
+	firstEntryProject: string | undefined;
+	/** Version this project has installed */
+	currentProjectVersion: string;
+	/** All entries for this plugin */
+	allEntries: InstalledPluginEntry[];
+}
+
+export interface FixResult {
+	/** Number of entries updated */
+	updated: number;
+	/** Project paths that were updated */
+	projects: string[];
+}
+
+// ── Detection ────────────────────────────────────────────────────────────────
+
+/**
+ * Check for plugin version mismatches caused by the [0] index bug.
+ *
+ * For each enabled plugin in the current project:
+ * 1. Reads the plugin's entry array from installed_plugins.json
+ * 2. Finds the entry matching the current project
+ * 3. Checks if entries[0] has a DIFFERENT version than the current project's entry
+ * 4. If yes: this project will load the wrong version
+ *
+ * @param projectPath - The current project path to check
+ * @returns Array of mismatch info for each affected plugin
+ */
+export async function checkPluginVersionMismatches(
+	projectPath: string,
+): Promise<VersionMismatchInfo[]> {
+	const registry = await readInstalledPluginsRegistry();
+	const enabledPluginIds = await collectEnabledPluginIds(projectPath);
+	const mismatches: VersionMismatchInfo[] = [];
+
+	for (const pluginId of enabledPluginIds) {
+		const entries = registry.plugins[pluginId];
+		if (!entries || entries.length < 2) continue;
+
+		// Find the entry for the current project
+		const currentEntry = entries.find(
+			(e) =>
+				e.scope === "project" &&
+				normalizePath(e.projectPath) === normalizePath(projectPath),
+		);
+		if (!currentEntry) continue;
+
+		const firstEntry = entries[0];
+
+		// Compare the version at [0] with the current project's version
+		if (firstEntry.version !== currentEntry.version) {
+			mismatches.push({
+				pluginId,
+				firstEntryVersion: firstEntry.version,
+				firstEntryProject: firstEntry.projectPath,
+				currentProjectVersion: currentEntry.version,
+				allEntries: entries,
+			});
+		}
+	}
+
+	return mismatches;
+}
+
+/**
+ * Check a single plugin for version mismatch (used after plugin update).
+ *
+ * @param pluginId - The plugin ID to check
+ * @param projectPath - The current project path
+ * @returns Mismatch info or null if no mismatch
+ */
+export async function checkSinglePluginMismatch(
+	pluginId: string,
+	projectPath: string,
+): Promise<VersionMismatchInfo | null> {
+	const registry = await readInstalledPluginsRegistry();
+	const entries = registry.plugins[pluginId];
+	if (!entries || entries.length < 2) return null;
+
+	const currentEntry = entries.find(
+		(e) =>
+			e.scope === "project" &&
+			normalizePath(e.projectPath) === normalizePath(projectPath),
+	);
+	if (!currentEntry) return null;
+
+	const firstEntry = entries[0];
+	if (firstEntry.version === currentEntry.version) return null;
+
+	return {
+		pluginId,
+		firstEntryVersion: firstEntry.version,
+		firstEntryProject: firstEntry.projectPath,
+		currentProjectVersion: currentEntry.version,
+		allEntries: entries,
+	};
+}
+
+// ── Fix ──────────────────────────────────────────────────────────────────────
+
+/**
+ * Fix a version mismatch by updating ALL entries for a plugin to use
+ * the target version. This is a JSON-only operation that rewrites
+ * installPath and version in each entry.
+ *
+ * IMPORTANT: This modifies installed_plugins.json which is Claude Code-owned.
+ * Only call after explicit user consent.
+ *
+ * @param pluginId - The plugin ID to fix
+ * @param targetVersion - The version to normalize all entries to
+ * @returns Number of updated entries and which projects were affected
+ */
+export async function fixPluginVersionMismatch(
+	pluginId: string,
+	targetVersion: string,
+): Promise<FixResult> {
+	const registry = await readInstalledPluginsRegistry();
+	const entries = registry.plugins[pluginId];
+	if (!entries || entries.length === 0) {
+		return { updated: 0, projects: [] };
+	}
+
+	// Find an existing entry with the target version to get the correct installPath
+	const templateEntry = entries.find((e) => e.version === targetVersion);
+	if (!templateEntry) {
+		return { updated: 0, projects: [] };
+	}
+
+	const targetInstallPath = templateEntry.installPath;
+	const updated: string[] = [];
+
+	for (const entry of entries) {
+		if (entry.version !== targetVersion) {
+			entry.version = targetVersion;
+			entry.installPath = targetInstallPath;
+			entry.lastUpdated = new Date().toISOString();
+			updated.push(entry.projectPath || "(global)");
+		}
+	}
+
+	if (updated.length > 0) {
+		await writeInstalledPluginsRegistry(registry);
+	}
+
+	return { updated: updated.length, projects: updated };
+}
+
+/**
+ * Fix all version mismatches by normalizing each plugin to its latest version.
+ *
+ * @param mismatches - Array of mismatches from checkPluginVersionMismatches
+ * @returns Map of pluginId to FixResult
+ */
+export async function fixAllPluginVersionMismatches(
+	mismatches: VersionMismatchInfo[],
+): Promise<Map<string, FixResult>> {
+	const results = new Map<string, FixResult>();
+
+	// Read registry once, apply all fixes, write once
+	const registry = await readInstalledPluginsRegistry();
+
+	for (const mismatch of mismatches) {
+		const entries = registry.plugins[mismatch.pluginId];
+		if (!entries || entries.length === 0) {
+			results.set(mismatch.pluginId, { updated: 0, projects: [] });
+			continue;
+		}
+
+		// Use the current project's version as the target (the version the user expects)
+		const targetVersion = mismatch.currentProjectVersion;
+		const templateEntry = entries.find((e) => e.version === targetVersion);
+		if (!templateEntry) {
+			results.set(mismatch.pluginId, { updated: 0, projects: [] });
+			continue;
+		}
+
+		const targetInstallPath = templateEntry.installPath;
+		const updated: string[] = [];
+
+		for (const entry of entries) {
+			if (entry.version !== targetVersion) {
+				entry.version = targetVersion;
+				entry.installPath = targetInstallPath;
+				entry.lastUpdated = new Date().toISOString();
+				updated.push(entry.projectPath || "(global)");
+			}
+		}
+
+		results.set(mismatch.pluginId, {
+			updated: updated.length,
+			projects: updated,
+		});
+	}
+
+	await writeInstalledPluginsRegistry(registry);
+	return results;
+}
+
+// ── Formatting ───────────────────────────────────────────────────────────────
+
+/**
+ * Format mismatch info for console output (prerunner).
+ */
+export function formatMismatchWarning(
+	mismatches: VersionMismatchInfo[],
+): string {
+	const lines: string[] = [];
+	lines.push(
+		"WARNING: Plugin version mismatch detected (Claude Code bug #45997)",
+	);
+	lines.push(
+		"Claude Code loads the first entry from installed_plugins.json for ALL projects.",
+	);
+	lines.push(
+		"The following plugins will load a different version than what this project has installed:\n",
+	);
+
+	for (const m of mismatches) {
+		const firstProject = m.firstEntryProject
+			? shortenPath(m.firstEntryProject)
+			: "(global)";
+		lines.push(`  ${m.pluginId}:`);
+		lines.push(`    Loading v${m.firstEntryVersion} (from ${firstProject})`);
+		lines.push(`    Expected v${m.currentProjectVersion} (this project)`);
+	}
+
+	lines.push("");
+	lines.push(`Bug report: ${BUG_REPORT_URL}`);
+	lines.push(
+		"Run claudeup to fix — it can align all projects to the same version.",
+	);
+
+	return lines.join("\n");
+}
+
+/**
+ * Format mismatch info for TUI modal display.
+ * Returns a multi-line string suitable for a modal message.
+ */
+export function formatMismatchModal(
+	mismatches: VersionMismatchInfo[],
+): string {
+	const lines: string[] = [];
+	lines.push(
+		"Claude Code has a bug where it loads the wrong plugin version.",
+	);
+	lines.push(
+		"It always uses the first entry in the registry, ignoring which",
+	);
+	lines.push("project you're in. These plugins are affected:\n");
+
+	for (const m of mismatches) {
+		const name = m.pluginId.split("@")[0];
+		lines.push(
+			`  ${name}: will load v${m.firstEntryVersion} instead of v${m.currentProjectVersion}`,
+		);
+	}
+
+	lines.push(`\nBug: github.com/anthropics/claude-code/issues/45997`);
+
+	return lines.join("\n");
+}
+
+// ── Helpers ──────────────────────────────────────────────────────────────────
+
+/**
+ * Collect all enabled plugin IDs across all scopes for a project.
+ */
+async function collectEnabledPluginIds(
+	projectPath: string,
+): Promise<Set<string>> {
+	const pluginIds = new Set<string>();
+
+	try {
+		const global = await getGlobalEnabledPlugins();
+		for (const [id, enabled] of Object.entries(global)) {
+			if (enabled) pluginIds.add(id);
+		}
+	} catch {
+		/* skip unreadable */
+	}
+
+	try {
+		const project = await getEnabledPlugins(projectPath);
+		for (const [id, enabled] of Object.entries(project)) {
+			if (enabled) pluginIds.add(id);
+		}
+	} catch {
+		/* skip unreadable */
+	}
+
+	try {
+		const local = await getLocalEnabledPlugins(projectPath);
+		for (const [id, enabled] of Object.entries(local)) {
+			if (enabled) pluginIds.add(id);
+		}
+	} catch {
+		/* skip unreadable */
+	}
+
+	return pluginIds;
+}
+
+/**
+ * Normalize a path for comparison (resolve and trailing-slash normalize).
+ */
+function normalizePath(p: string | undefined): string {
+	if (!p) return "";
+	return p.replace(/\/+$/, "");
+}
+
+/**
+ * Shorten a path for display by replacing homedir with ~.
+ */
+function shortenPath(p: string): string {
+	const home = process.env.HOME || process.env.USERPROFILE || "";
+	if (home && p.startsWith(home)) {
+		return `~${p.slice(home.length)}`;
+	}
+	return p;
+}

package/src/ui/App.js

@@ -8,6 +8,7 @@ import { ModalContainer } from "./components/modals/index.js";
 import { PluginsScreen, McpScreen, McpRegistryScreen, SettingsScreen, CliToolsScreen, ModelSelectorScreen, ProfilesScreen, SkillsScreen, } from "./screens/index.js";
 import { repairAllMarketplaces } from "../services/local-marketplace.js";
 import { migrateMarketplaceRename, recoverMarketplaceSettings, } from "../services/claude-settings.js";
+import { checkPluginVersionMismatches, fixAllPluginVersionMismatches, formatMismatchModal, } from "../services/plugin-version-check.js";
 import { checkForUpdates, getCurrentVersion, } from "../services/version-check.js";
 import { useKeyboardHandler } from "./hooks/useKeyboardHandler.js";
 import { ProgressBar } from "./components/layout/ProgressBar.js";
@@ -175,11 +176,25 @@ function UpdateBanner({ result }) {
 function ProgressIndicator({ message, current, total, }) {
     return (_jsx("box", { paddingLeft: 1, paddingRight: 1, children: _jsx(ProgressBar, { message: message, current: current, total: total }) }));
 }
-function AppContentInner({ showDebug, onDebugToggle, updateInfo, onExit, }) {
-    const { state, dispatch } = useApp();
+function AppContentInner({ showDebug, onDebugToggle, updateInfo, onExit, recoveryReport, }) {
+    const { state } = useApp();
     const { progress } = state;
     const dimensions = useDimensions();
+    return (_jsxs("box", { flexDirection: "column", height: dimensions.terminalHeight, children: [updateInfo?.updateAvailable && _jsx(UpdateBanner, { result: updateInfo }), recoveryReport && (_jsx("box", { paddingLeft: 1, paddingRight: 1, children: _jsxs("text", { fg: "green", children: ["\u2713 Fixed: ", recoveryReport] }) })), showDebug && (_jsx("box", { paddingLeft: 1, paddingRight: 1, children: _jsxs("text", { fg: "#888888", children: ["DEBUG: ", dimensions.terminalWidth, "x", dimensions.terminalHeight, " | content=", dimensions.contentHeight, " | screen=", state.currentRoute.screen] }) })), progress && _jsx(ProgressIndicator, { ...progress }), _jsx("box", { flexDirection: "column", height: dimensions.contentHeight, paddingLeft: 1, paddingRight: 1, children: _jsx(Router, {}) }), _jsx(GlobalKeyHandler, { onDebugToggle: onDebugToggle, onExit: onExit }), _jsx(ModalContainer, {})] }));
+}
+function AppContent({ onExit }) {
+    const { state, dispatch } = useApp();
+    const { progress } = state;
+    const [showDebug, setShowDebug] = useState(false);
+    const [updateInfo, setUpdateInfo] = useState(null);
     const [recoveryReport, setRecoveryReport] = useState(null);
+    const [mismatchData, setMismatchData] = useState(null);
+    // Check for updates on startup (non-blocking)
+    useEffect(() => {
+        checkForUpdates()
+            .then(setUpdateInfo)
+            .catch(() => { });
+    }, []);
     // Auto-dismiss recovery banner after 5 seconds
     useEffect(() => {
         if (!recoveryReport)
@@ -187,6 +202,72 @@ function AppContentInner({ showDebug, onDebugToggle, updateInfo, onExit, }) {
         const timer = setTimeout(() => setRecoveryReport(null), 5000);
         return () => clearTimeout(timer);
     }, [recoveryReport]);
+    // Show mismatch modal when data arrives
+    useEffect(() => {
+        if (!mismatchData || mismatchData.length === 0)
+            return;
+        dispatch({
+            type: "SHOW_MODAL",
+            modal: {
+                type: "select",
+                title: "⚠ Plugin Version Mismatch",
+                message: formatMismatchModal(mismatchData),
+                options: [
+                    {
+                        label: "Fix all projects",
+                        value: "fix",
+                        description: "Align all projects to this project's versions",
+                    },
+                    {
+                        label: "Dismiss",
+                        value: "dismiss",
+                        description: "Ignore for now",
+                    },
+                ],
+                onSelect: async (value) => {
+                    dispatch({ type: "HIDE_MODAL" });
+                    if (value === "fix") {
+                        dispatch({
+                            type: "SHOW_PROGRESS",
+                            state: { message: "Fixing plugin versions..." },
+                        });
+                        try {
+                            await fixAllPluginVersionMismatches(mismatchData);
+                            dispatch({ type: "HIDE_PROGRESS" });
+                            dispatch({
+                                type: "SHOW_MODAL",
+                                modal: {
+                                    type: "message",
+                                    title: "Fixed",
+                                    message: "All plugin versions aligned. Restart Claude Code for changes to take effect.",
+                                    variant: "success",
+                                    onDismiss: () => dispatch({ type: "HIDE_MODAL" }),
+                                },
+                            });
+                        }
+                        catch {
+                            dispatch({ type: "HIDE_PROGRESS" });
+                            dispatch({
+                                type: "SHOW_MODAL",
+                                modal: {
+                                    type: "message",
+                                    title: "Error",
+                                    message: "Failed to fix plugin versions. Try running claudeup again.",
+                                    variant: "error",
+                                    onDismiss: () => dispatch({ type: "HIDE_MODAL" }),
+                                },
+                            });
+                        }
+                    }
+                    setMismatchData(null);
+                },
+                onCancel: () => {
+                    dispatch({ type: "HIDE_MODAL" });
+                    setMismatchData(null);
+                },
+            },
+        });
+    }, [mismatchData, dispatch]);
     // Auto-refresh marketplaces on startup
     useEffect(() => {
         const noRefresh = process.argv.includes("--no-refresh");
@@ -196,9 +277,9 @@ function AppContentInner({ showDebug, onDebugToggle, updateInfo, onExit, }) {
             type: "SHOW_PROGRESS",
             state: { message: "Scanning marketplaces..." },
         });
-        // Migrate old marketplace names → magus (idempotent), then repair plugin.json files
+        // Migrate old marketplace names -> magus (idempotent), then repair plugin.json files
         migrateMarketplaceRename().catch(() => { }); // non-blocking, best-effort
-        // Recover stale marketplace registry entries (e.g. "directory" → "github")
+        // Recover stale marketplace registry entries (e.g. "directory" -> "github")
         recoverMarketplaceSettings()
             .then(async (recovery) => {
             const parts = [];
@@ -226,6 +307,14 @@ function AppContentInner({ showDebug, onDebugToggle, updateInfo, onExit, }) {
             }
         })
             .catch(() => { }); // non-fatal
+        // Check for plugin version mismatches (the [0] index bug)
+        checkPluginVersionMismatches(process.cwd())
+            .then((mismatches) => {
+            if (mismatches.length > 0) {
+                setMismatchData(mismatches);
+            }
+        })
+            .catch(() => { }); // non-fatal
         repairAllMarketplaces()
             .then(async () => {
             dispatch({ type: "HIDE_PROGRESS" });
@@ -235,20 +324,9 @@ function AppContentInner({ showDebug, onDebugToggle, updateInfo, onExit, }) {
             dispatch({ type: "HIDE_PROGRESS" });
         });
     }, [dispatch]);
-    return (_jsxs("box", { flexDirection: "column", height: dimensions.terminalHeight, children: [updateInfo?.updateAvailable && _jsx(UpdateBanner, { result: updateInfo }), recoveryReport && (_jsx("box", { paddingLeft: 1, paddingRight: 1, children: _jsxs("text", { fg: "green", children: ["\u2713 Fixed: ", recoveryReport] }) })), showDebug && (_jsx("box", { paddingLeft: 1, paddingRight: 1, children: _jsxs("text", { fg: "#888888", children: ["DEBUG: ", dimensions.terminalWidth, "x", dimensions.terminalHeight, " | content=", dimensions.contentHeight, " | screen=", state.currentRoute.screen] }) })), progress && _jsx(ProgressIndicator, { ...progress }), _jsx("box", { flexDirection: "column", height: dimensions.contentHeight, paddingLeft: 1, paddingRight: 1, children: _jsx(Router, {}) }), _jsx(GlobalKeyHandler, { onDebugToggle: onDebugToggle, onExit: onExit }), _jsx(ModalContainer, {})] }));
-}
-function AppContent({ onExit }) {
-    const { state } = useApp();
-    const { progress } = state;
-    const [showDebug, setShowDebug] = useState(false);
-    const [updateInfo, setUpdateInfo] = useState(null);
-    // Check for updates on startup (non-blocking)
-    useEffect(() => {
-        checkForUpdates()
-            .then(setUpdateInfo)
-            .catch(() => { });
-    }, []);
-    return (_jsx(DimensionsProvider, { showProgress: !!progress, showDebug: showDebug, showUpdateBanner: !!updateInfo?.updateAvailable, children: _jsx(AppContentInner, { showDebug: showDebug, onDebugToggle: () => setShowDebug((s) => !s), updateInfo: updateInfo, onExit: onExit }) }));
+    // Count transient banners for dimension calculation
+    const transientBannerCount = recoveryReport ? 1 : 0;
+    return (_jsx(DimensionsProvider, { showProgress: !!progress, showDebug: showDebug, showUpdateBanner: !!updateInfo?.updateAvailable, transientBannerCount: transientBannerCount, children: _jsx(AppContentInner, { showDebug: showDebug, onDebugToggle: () => setShowDebug((s) => !s), updateInfo: updateInfo, onExit: onExit, recoveryReport: recoveryReport }) }));
 }
 export function App({ onExit }) {
     return (_jsx(AppProvider, { children: _jsx(AppContent, { onExit: onExit }) }));