claudeup 4.10.2 → 4.11.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "claudeup",
-  "version": "4.10.2",
+  "version": "4.11.1",
   "description": "TUI tool for managing Claude Code plugins, MCPs, and configuration",
   "type": "module",
   "main": "src/main.tsx",

package/src/__tests__/plugin-setup.test.ts

@@ -0,0 +1,300 @@
+/**
+ * Tests for plugin-setup.ts: go package manager and required binary validator.
+ *
+ * Tests extractGoBinaryName (pure function), and uses module mocking to
+ * verify installPluginDeps() and checkMissingDeps() behavior for `go`
+ * and `required` setup keys.
+ */
+
+import { describe, it, expect, mock, beforeEach } from "bun:test";
+
+// ---------------------------------------------------------------------------
+// Mocks — must be set up BEFORE any import from plugin-setup
+// ---------------------------------------------------------------------------
+
+// Track which commands are "available" and what execFile calls return
+let availableBinaries: Set<string>;
+let execResults: Map<
+	string,
+	{ stdout: string; stderr: string; error?: boolean }
+>;
+
+// Mock command-utils BEFORE importing plugin-setup
+mock.module("../utils/command-utils.js", () => ({
+	which: async (cmd: string) => {
+		return availableBinaries.has(cmd) ? `/usr/bin/${cmd}` : null;
+	},
+}));
+
+// Mock child_process execFile — promisify wraps this callback-based API
+mock.module("node:child_process", () => ({
+	execFile: (
+		cmd: string,
+		args: string[],
+		opts: unknown,
+		cb?: (
+			err: Error | null,
+			result: { stdout: string; stderr: string },
+		) => void,
+	) => {
+		const key = `${cmd} ${args.join(" ")}`;
+
+		// Find matching result by prefix
+		let result = execResults.get(key);
+		if (!result) {
+			for (const [k, v] of execResults.entries()) {
+				if (key.startsWith(k)) {
+					result = v;
+					break;
+				}
+			}
+		}
+
+		if (!result) {
+			result = { stdout: "", stderr: "", error: false };
+		}
+
+		if (typeof cb === "function") {
+			if (result.error) {
+				const err = new Error(result.stderr) as Error & {
+					stdout: string;
+					stderr: string;
+				};
+				err.stdout = result.stdout;
+				err.stderr = result.stderr;
+				cb(err, { stdout: result.stdout, stderr: result.stderr });
+			} else {
+				cb(null, { stdout: result.stdout, stderr: result.stderr });
+			}
+		}
+	},
+}));
+
+// Import AFTER mocks are set up
+const {
+	extractGoBinaryName,
+	installPluginDeps,
+	checkMissingDeps,
+} = await import("../services/plugin-setup.js");
+
+// ---------------------------------------------------------------------------
+// 1. Pure function tests — extractGoBinaryName
+// ---------------------------------------------------------------------------
+
+describe("extractGoBinaryName", () => {
+	it("extracts binary name from module@version", () => {
+		expect(extractGoBinaryName("github.com/MadAppGang/tmux-mcp@latest")).toBe(
+			"tmux-mcp",
+		);
+	});
+
+	it("extracts binary name from module@semver", () => {
+		expect(extractGoBinaryName("github.com/user/tool@v1.2.3")).toBe("tool");
+	});
+
+	it("extracts binary name from module without version", () => {
+		expect(extractGoBinaryName("github.com/user/tool")).toBe("tool");
+	});
+
+	it("handles single-segment package name", () => {
+		expect(extractGoBinaryName("mytool")).toBe("mytool");
+	});
+
+	it("handles module with nested path and version", () => {
+		expect(
+			extractGoBinaryName("github.com/org/repo/cmd/mycli@v2.0.0"),
+		).toBe("mycli");
+	});
+
+	it("handles empty string gracefully", () => {
+		expect(extractGoBinaryName("")).toBe("");
+	});
+});
+
+// ---------------------------------------------------------------------------
+// 2. Integration tests — installPluginDeps with go packages
+// ---------------------------------------------------------------------------
+
+describe("installPluginDeps — go packages", () => {
+	beforeEach(() => {
+		availableBinaries = new Set(["go"]); // go is available by default
+		execResults = new Map();
+	});
+
+	it("skips go packages when binary already exists", async () => {
+		availableBinaries.add("tmux-mcp");
+
+		const result = await installPluginDeps({
+			go: ["github.com/MadAppGang/tmux-mcp@latest"],
+		});
+
+		expect(result.skipped).toContain(
+			"go:github.com/MadAppGang/tmux-mcp@latest",
+		);
+		expect(result.installed).toHaveLength(0);
+		expect(result.failed).toHaveLength(0);
+	});
+
+	it("installs go packages when binary not found", async () => {
+		// go is available but tmux-mcp is not
+		execResults.set("/usr/bin/go install", {
+			stdout: "",
+			stderr: "",
+		});
+
+		const result = await installPluginDeps({
+			go: ["github.com/MadAppGang/tmux-mcp@latest"],
+		});
+
+		expect(result.installed).toContain(
+			"go:github.com/MadAppGang/tmux-mcp@latest",
+		);
+		expect(result.failed).toHaveLength(0);
+	});
+
+	it("reports failure when go is not available", async () => {
+		availableBinaries.delete("go");
+
+		const result = await installPluginDeps({
+			go: ["github.com/MadAppGang/tmux-mcp@latest"],
+		});
+
+		expect(result.failed).toHaveLength(1);
+		expect(result.failed[0].pkg).toBe(
+			"go:github.com/MadAppGang/tmux-mcp@latest",
+		);
+		expect(result.failed[0].error).toBe("go not found");
+	});
+
+	it("reports failure when go install fails", async () => {
+		execResults.set("/usr/bin/go install", {
+			stdout: "",
+			stderr: "build error: something went wrong",
+			error: true,
+		});
+
+		const result = await installPluginDeps({
+			go: ["github.com/MadAppGang/tmux-mcp@latest"],
+		});
+
+		expect(result.failed).toHaveLength(1);
+		expect(result.failed[0].error).toContain("something went wrong");
+	});
+});
+
+// ---------------------------------------------------------------------------
+// 3. Integration tests — installPluginDeps with required binaries
+// ---------------------------------------------------------------------------
+
+describe("installPluginDeps — required binaries", () => {
+	beforeEach(() => {
+		availableBinaries = new Set();
+		execResults = new Map();
+	});
+
+	it("skips required binaries that are present", async () => {
+		availableBinaries.add("tmux");
+
+		const result = await installPluginDeps({
+			required: ["tmux"],
+		});
+
+		expect(result.skipped).toContain("required:tmux");
+		expect(result.failed).toHaveLength(0);
+	});
+
+	it("reports failure for missing required binaries", async () => {
+		const result = await installPluginDeps({
+			required: ["tmux"],
+		});
+
+		expect(result.failed).toHaveLength(1);
+		expect(result.failed[0].pkg).toBe("required:tmux");
+		expect(result.failed[0].error).toContain(
+			"Required binary 'tmux' not found in PATH",
+		);
+		expect(result.failed[0].error).toContain("install it manually");
+	});
+
+	it("handles multiple required binaries with mixed availability", async () => {
+		availableBinaries.add("tmux");
+		// ffmpeg is not available
+
+		const result = await installPluginDeps({
+			required: ["tmux", "ffmpeg"],
+		});
+
+		expect(result.skipped).toContain("required:tmux");
+		expect(result.failed).toHaveLength(1);
+		expect(result.failed[0].pkg).toBe("required:ffmpeg");
+	});
+});
+
+// ---------------------------------------------------------------------------
+// 4. checkMissingDeps tests — go packages
+// ---------------------------------------------------------------------------
+
+describe("checkMissingDeps — go packages", () => {
+	beforeEach(() => {
+		availableBinaries = new Set();
+		execResults = new Map();
+	});
+
+	it("detects missing go packages when binary not in PATH", async () => {
+		const missing = await checkMissingDeps({
+			go: ["github.com/MadAppGang/tmux-mcp@latest"],
+		});
+
+		expect(missing.go).toEqual(["github.com/MadAppGang/tmux-mcp@latest"]);
+	});
+
+	it("does not report go packages when binary exists", async () => {
+		availableBinaries.add("tmux-mcp");
+
+		const missing = await checkMissingDeps({
+			go: ["github.com/MadAppGang/tmux-mcp@latest"],
+		});
+
+		expect(missing.go).toBeUndefined();
+	});
+});
+
+// ---------------------------------------------------------------------------
+// 5. checkMissingDeps tests — required binaries
+// ---------------------------------------------------------------------------
+
+describe("checkMissingDeps — required binaries", () => {
+	beforeEach(() => {
+		availableBinaries = new Set();
+		execResults = new Map();
+	});
+
+	it("detects missing required binaries", async () => {
+		const missing = await checkMissingDeps({
+			required: ["tmux", "ffmpeg"],
+		});
+
+		expect(missing.required).toEqual(["tmux", "ffmpeg"]);
+	});
+
+	it("does not report present required binaries", async () => {
+		availableBinaries.add("tmux");
+		availableBinaries.add("ffmpeg");
+
+		const missing = await checkMissingDeps({
+			required: ["tmux", "ffmpeg"],
+		});
+
+		expect(missing.required).toBeUndefined();
+	});
+
+	it("reports only missing required binaries", async () => {
+		availableBinaries.add("tmux");
+
+		const missing = await checkMissingDeps({
+			required: ["tmux", "ffmpeg"],
+		});
+
+		expect(missing.required).toEqual(["ffmpeg"]);
+	});
+});