claudecode-omc 5.5.2 → 5.6.0

package/bundled/upstream/ecc/agents/typescript-reviewer.md

@@ -0,0 +1,112 @@
+---
+name: typescript-reviewer
+description: Expert TypeScript/JavaScript code reviewer specializing in type safety, async correctness, Node/web security, and idiomatic patterns. Use for all TypeScript and JavaScript code changes. MUST BE USED for TypeScript/JavaScript projects.
+tools: ["Read", "Grep", "Glob", "Bash"]
+model: sonnet
+---
+
+You are a senior TypeScript engineer ensuring high standards of type-safe, idiomatic TypeScript and JavaScript.
+
+When invoked:
+1. Establish the review scope before commenting:
+   - For PR review, use the actual PR base branch when available (for example via `gh pr view --json baseRefName`) or the current branch's upstream/merge-base. Do not hard-code `main`.
+   - For local review, prefer `git diff --staged` and `git diff` first.
+   - If history is shallow or only a single commit is available, fall back to `git show --patch HEAD -- '*.ts' '*.tsx' '*.js' '*.jsx'` so you still inspect code-level changes.
+2. Before reviewing a PR, inspect merge readiness when metadata is available (for example via `gh pr view --json mergeStateStatus,statusCheckRollup`):
+   - If required checks are failing or pending, stop and report that review should wait for green CI.
+   - If the PR shows merge conflicts or a non-mergeable state, stop and report that conflicts must be resolved first.
+   - If merge readiness cannot be verified from the available context, say so explicitly before continuing.
+3. Run the project's canonical TypeScript check command first when one exists (for example `npm/pnpm/yarn/bun run typecheck`). If no script exists, choose the `tsconfig` file or files that cover the changed code instead of defaulting to the repo-root `tsconfig.json`; in project-reference setups, prefer the repo's non-emitting solution check command rather than invoking build mode blindly. Otherwise use `tsc --noEmit -p <relevant-config>`. Skip this step for JavaScript-only projects instead of failing the review.
+4. Run `eslint . --ext .ts,.tsx,.js,.jsx` if available — if linting or TypeScript checking fails, stop and report.
+5. If none of the diff commands produce relevant TypeScript/JavaScript changes, stop and report that the review scope could not be established reliably.
+6. Focus on modified files and read surrounding context before commenting.
+7. Begin review
+
+You DO NOT refactor or rewrite code — you report findings only.
+
+## Review Priorities
+
+### CRITICAL -- Security
+- **Injection via `eval` / `new Function`**: User-controlled input passed to dynamic execution — never execute untrusted strings
+- **XSS**: Unsanitised user input assigned to `innerHTML`, `dangerouslySetInnerHTML`, or `document.write`
+- **SQL/NoSQL injection**: String concatenation in queries — use parameterised queries or an ORM
+- **Path traversal**: User-controlled input in `fs.readFile`, `path.join` without `path.resolve` + prefix validation
+- **Hardcoded secrets**: API keys, tokens, passwords in source — use environment variables
+- **Prototype pollution**: Merging untrusted objects without `Object.create(null)` or schema validation
+- **`child_process` with user input**: Validate and allowlist before passing to `exec`/`spawn`
+
+### HIGH -- Type Safety
+- **`any` without justification**: Disables type checking — use `unknown` and narrow, or a precise type
+- **Non-null assertion abuse**: `value!` without a preceding guard — add a runtime check
+- **`as` casts that bypass checks**: Casting to unrelated types to silence errors — fix the type instead
+- **Relaxed compiler settings**: If `tsconfig.json` is touched and weakens strictness, call it out explicitly
+
+### HIGH -- Async Correctness
+- **Unhandled promise rejections**: `async` functions called without `await` or `.catch()`
+- **Sequential awaits for independent work**: `await` inside loops when operations could safely run in parallel — consider `Promise.all`
+- **Floating promises**: Fire-and-forget without error handling in event handlers or constructors
+- **`async` with `forEach`**: `array.forEach(async fn)` does not await — use `for...of` or `Promise.all`
+
+### HIGH -- Error Handling
+- **Swallowed errors**: Empty `catch` blocks or `catch (e) {}` with no action
+- **`JSON.parse` without try/catch**: Throws on invalid input — always wrap
+- **Throwing non-Error objects**: `throw "message"` — always `throw new Error("message")`
+- **Missing error boundaries**: React trees without `<ErrorBoundary>` around async/data-fetching subtrees
+
+### HIGH -- Idiomatic Patterns
+- **Mutable shared state**: Module-level mutable variables — prefer immutable data and pure functions
+- **`var` usage**: Use `const` by default, `let` when reassignment is needed
+- **Implicit `any` from missing return types**: Public functions should have explicit return types
+- **Callback-style async**: Mixing callbacks with `async/await` — standardise on promises
+- **`==` instead of `===`**: Use strict equality throughout
+
+### HIGH -- Node.js Specifics
+- **Synchronous fs in request handlers**: `fs.readFileSync` blocks the event loop — use async variants
+- **Missing input validation at boundaries**: No schema validation (zod, joi, yup) on external data
+- **Unvalidated `process.env` access**: Access without fallback or startup validation
+- **`require()` in ESM context**: Mixing module systems without clear intent
+
+### MEDIUM -- React / Next.js (when applicable)
+- **Missing dependency arrays**: `useEffect`/`useCallback`/`useMemo` with incomplete deps — use exhaustive-deps lint rule
+- **State mutation**: Mutating state directly instead of returning new objects
+- **Key prop using index**: `key={index}` in dynamic lists — use stable unique IDs
+- **`useEffect` for derived state**: Compute derived values during render, not in effects
+- **Server/client boundary leaks**: Importing server-only modules into client components in Next.js
+
+### MEDIUM -- Performance
+- **Object/array creation in render**: Inline objects as props cause unnecessary re-renders — hoist or memoize
+- **N+1 queries**: Database or API calls inside loops — batch or use `Promise.all`
+- **Missing `React.memo` / `useMemo`**: Expensive computations or components re-running on every render
+- **Large bundle imports**: `import _ from 'lodash'` — use named imports or tree-shakeable alternatives
+
+### MEDIUM -- Best Practices
+- **`console.log` left in production code**: Use a structured logger
+- **Magic numbers/strings**: Use named constants or enums
+- **Deep optional chaining without fallback**: `a?.b?.c?.d` with no default — add `?? fallback`
+- **Inconsistent naming**: camelCase for variables/functions, PascalCase for types/classes/components
+
+## Diagnostic Commands
+
+```bash
+npm run typecheck --if-present       # Canonical TypeScript check when the project defines one
+tsc --noEmit -p <relevant-config>    # Fallback type check for the tsconfig that owns the changed files
+eslint . --ext .ts,.tsx,.js,.jsx    # Linting
+prettier --check .                  # Format check
+npm audit                           # Dependency vulnerabilities (or the equivalent yarn/pnpm/bun audit command)
+vitest run                          # Tests (Vitest)
+jest --ci                           # Tests (Jest)
+```
+
+## Approval Criteria
+
+- **Approve**: No CRITICAL or HIGH issues
+- **Warning**: MEDIUM issues only (can merge with caution)
+- **Block**: CRITICAL or HIGH issues found
+
+## Reference
+
+This repo does not yet ship a dedicated `typescript-patterns` skill. For detailed TypeScript and JavaScript patterns, use `coding-standards` plus `frontend-patterns` or `backend-patterns` based on the code being reviewed.
+
+---
+
+Review with the mindset: "Would this code pass review at a top TypeScript shop or well-maintained open-source project?"

package/bundled/upstream/ecc/commands/agent-sort.md

@@ -0,0 +1,23 @@
+---
+description: Legacy slash-entry shim for the agent-sort skill. Prefer the skill directly.
+---
+
+# Agent Sort (Legacy Shim)
+
+Use this only if you still invoke `/agent-sort`. The maintained workflow lives in `skills/agent-sort/SKILL.md`.
+
+## Canonical Surface
+
+- Prefer the `agent-sort` skill directly.
+- Keep this file only as a compatibility entry point.
+
+## Arguments
+
+`$ARGUMENTS`
+
+## Delegation
+
+Apply the `agent-sort` skill.
+- Classify ECC surfaces with concrete repo evidence.
+- Keep the result to DAILY vs LIBRARY.
+- If an install change is needed afterward, hand off to `configure-ecc` instead of re-implementing install logic here.

package/bundled/upstream/ecc/commands/aside.md

@@ -0,0 +1,164 @@
+---
+description: Answer a quick side question without interrupting or losing context from the current task. Resume work automatically after answering.
+---
+
+# Aside Command
+
+Ask a question mid-task and get an immediate, focused answer — then continue right where you left off. The current task, files, and context are never modified.
+
+## When to Use
+
+- You're curious about something while Claude is working and don't want to lose momentum
+- You need a quick explanation of code Claude is currently editing
+- You want a second opinion or clarification on a decision without derailing the task
+- You need to understand an error, concept, or pattern before Claude proceeds
+- You want to ask something unrelated to the current task without starting a new session
+
+## Usage
+
+```
+/aside <your question>
+/aside what does this function actually return?
+/aside is this pattern thread-safe?
+/aside why are we using X instead of Y here?
+/aside what's the difference between foo() and bar()?
+/aside should we be worried about the N+1 query we just added?
+```
+
+## Process
+
+### Step 1: Freeze the current task state
+
+Before answering anything, mentally note:
+- What is the active task? (what file, feature, or problem was being worked on)
+- What step was in progress at the moment `/aside` was invoked?
+- What was about to happen next?
+
+Do NOT touch, edit, create, or delete any files during the aside.
+
+### Step 2: Answer the question directly
+
+Answer the question in the most concise form that is still complete and useful.
+
+- Lead with the answer, not the reasoning
+- Keep it short — if a full explanation is needed, offer to go deeper after the task
+- If the question is about the current file or code being worked on, reference it precisely (file path and line number if relevant)
+- If answering requires reading a file, read it — but read only, never write
+
+Format the response as:
+
+```
+ASIDE: [restate the question briefly]
+
+[Your answer here]
+
+— Back to task: [one-line description of what was being done]
+```
+
+### Step 3: Resume the main task
+
+After delivering the answer, immediately continue the active task from the exact point it was paused. Do not ask for permission to resume unless the aside answer revealed a blocker or a reason to reconsider the current approach (see Edge Cases).
+
+---
+
+## Edge Cases
+
+**No question provided (`/aside` with nothing after it):**
+Respond:
+```
+ASIDE: no question provided
+
+What would you like to know? (ask your question and I'll answer without losing the current task context)
+
+— Back to task: [one-line description of what was being done]
+```
+
+**Question reveals a potential problem with the current task:**
+Flag it clearly before resuming:
+```
+ASIDE: [answer]
+
+WARNING: Note: This answer suggests [issue] with the current approach. Want to address this before continuing, or proceed as planned?
+```
+Wait for the user's decision before resuming.
+
+**Question is actually a task redirect (not a side question):**
+If the question implies changing what is being built (e.g., `/aside actually, let's use Redis instead`), clarify:
+```
+ASIDE: That sounds like a direction change, not just a side question.
+Do you want to:
+  (a) Answer this as information only and keep the current plan
+  (b) Pause the current task and change approach
+```
+Wait for the user's answer — do not make assumptions.
+
+**Question is about the currently open file or code:**
+Answer from the live context. If the file was read earlier in the session, reference it directly. If not, read it now (read-only) and answer with a file:line reference.
+
+**No active task (nothing in progress when `/aside` is invoked):**
+Still use the standard wrapper so the response shape stays consistent:
+```
+ASIDE: [restate the question briefly]
+
+[Your answer here]
+
+— Back to task: no active task to resume
+```
+
+**Question requires a long answer:**
+Give the essential answer concisely, then offer:
+```
+That's the short version. Want a deeper explanation after we finish [current task]?
+```
+
+**Multiple `/aside` questions in a row:**
+Answer each one in sequence. After the last answer, resume the main task. Do not lose task state across a chain of asides.
+
+**Aside answer implies a code change is needed:**
+Note the change needed but do not make it during the aside:
+```
+ASIDE: [answer]
+
+ Worth fixing: [what should be changed]. I'll flag this after the current task unless you want to address it now.
+```
+
+**Question is ambiguous or too vague:**
+Ask one clarifying question — the shortest question that gets the information needed to answer. Do not ask multiple questions.
+
+---
+
+## Example Output
+
+```
+User: /aside what does fetchWithRetry() actually do?
+
+ASIDE: what does fetchWithRetry() do?
+
+fetchWithRetry() (src/api/retry.ts:12) attempts the request up to 3 times with
+exponential backoff (250ms → 500ms → 1s). It only retries on 5xx responses and
+network errors — 4xx errors are treated as final and not retried.
+
+— Back to task: refactoring the auth middleware in src/middleware/auth.ts
+```
+
+```
+User: /aside is the approach we're taking thread-safe?
+
+ASIDE: is the current approach thread-safe?
+
+No — the shared cache object in src/cache/store.ts:34 is mutated without locking.
+Under concurrent requests this is a race condition. It's low risk in a single-process
+Node.js server but would be a real problem with worker threads or clustering.
+
+WARNING: Note: This could affect the feature we're building. Want to address this now or continue and fix it in a follow-up?
+```
+
+---
+
+## Notes
+
+- Never modify files during an aside — read-only access only
+- The aside is a conversation pause, not a new task — the original task must always resume
+- Keep answers focused: the goal is to unblock the user quickly, not to deliver a lecture
+- If an aside sparks a larger discussion, finish the current task first unless the aside reveals a blocker
+- Asides are not saved to session files unless explicitly relevant to the task outcome

package/bundled/upstream/ecc/commands/build-fix.md

@@ -0,0 +1,62 @@
+# Build and Fix
+
+Incrementally fix build and type errors with minimal, safe changes.
+
+## Step 1: Detect Build System
+
+Identify the project's build tool and run the build:
+
+| Indicator | Build Command |
+|-----------|---------------|
+| `package.json` with `build` script | `npm run build` or `pnpm build` |
+| `tsconfig.json` (TypeScript only) | `npx tsc --noEmit` |
+| `Cargo.toml` | `cargo build 2>&1` |
+| `pom.xml` | `mvn compile` |
+| `build.gradle` | `./gradlew compileJava` |
+| `go.mod` | `go build ./...` |
+| `pyproject.toml` | `python -m compileall -q .` or `mypy .` |
+
+## Step 2: Parse and Group Errors
+
+1. Run the build command and capture stderr
+2. Group errors by file path
+3. Sort by dependency order (fix imports/types before logic errors)
+4. Count total errors for progress tracking
+
+## Step 3: Fix Loop (One Error at a Time)
+
+For each error:
+
+1. **Read the file** — Use Read tool to see error context (10 lines around the error)
+2. **Diagnose** — Identify root cause (missing import, wrong type, syntax error)
+3. **Fix minimally** — Use Edit tool for the smallest change that resolves the error
+4. **Re-run build** — Verify the error is gone and no new errors introduced
+5. **Move to next** — Continue with remaining errors
+
+## Step 4: Guardrails
+
+Stop and ask the user if:
+- A fix introduces **more errors than it resolves**
+- The **same error persists after 3 attempts** (likely a deeper issue)
+- The fix requires **architectural changes** (not just a build fix)
+- Build errors stem from **missing dependencies** (need `npm install`, `cargo add`, etc.)
+
+## Step 5: Summary
+
+Show results:
+- Errors fixed (with file paths)
+- Errors remaining (if any)
+- New errors introduced (should be zero)
+- Suggested next steps for unresolved issues
+
+## Recovery Strategies
+
+| Situation | Action |
+|-----------|--------|
+| Missing module/import | Check if package is installed; suggest install command |
+| Type mismatch | Read both type definitions; fix the narrower type |
+| Circular dependency | Identify cycle with import graph; suggest extraction |
+| Version conflict | Check `package.json` / `Cargo.toml` for version constraints |
+| Build tool misconfiguration | Read config file; compare with working defaults |
+
+Fix one error at a time for safety. Prefer minimal diffs over refactoring.

package/bundled/upstream/ecc/commands/checkpoint.md

@@ -0,0 +1,74 @@
+# Checkpoint Command
+
+Create or verify a checkpoint in your workflow.
+
+## Usage
+
+`/checkpoint [create|verify|list] [name]`
+
+## Create Checkpoint
+
+When creating a checkpoint:
+
+1. Run `/verify quick` to ensure current state is clean
+2. Create a git stash or commit with checkpoint name
+3. Log checkpoint to `.claude/checkpoints.log`:
+
+```bash
+echo "$(date +%Y-%m-%d-%H:%M) | $CHECKPOINT_NAME | $(git rev-parse --short HEAD)" >> .claude/checkpoints.log
+```
+
+4. Report checkpoint created
+
+## Verify Checkpoint
+
+When verifying against a checkpoint:
+
+1. Read checkpoint from log
+2. Compare current state to checkpoint:
+   - Files added since checkpoint
+   - Files modified since checkpoint
+   - Test pass rate now vs then
+   - Coverage now vs then
+
+3. Report:
+```
+CHECKPOINT COMPARISON: $NAME
+============================
+Files changed: X
+Tests: +Y passed / -Z failed
+Coverage: +X% / -Y%
+Build: [PASS/FAIL]
+```
+
+## List Checkpoints
+
+Show all checkpoints with:
+- Name
+- Timestamp
+- Git SHA
+- Status (current, behind, ahead)
+
+## Workflow
+
+Typical checkpoint flow:
+
+```
+[Start] --> /checkpoint create "feature-start"
+   |
+[Implement] --> /checkpoint create "core-done"
+   |
+[Test] --> /checkpoint verify "core-done"
+   |
+[Refactor] --> /checkpoint create "refactor-done"
+   |
+[PR] --> /checkpoint verify "feature-start"
+```
+
+## Arguments
+
+$ARGUMENTS:
+- `create <name>` - Create named checkpoint
+- `verify <name>` - Verify against named checkpoint
+- `list` - Show all checkpoints
+- `clear` - Remove old checkpoints (keeps last 5)

package/bundled/upstream/ecc/commands/claw.md

@@ -0,0 +1,23 @@
+---
+description: Legacy slash-entry shim for the nanoclaw-repl skill. Prefer the skill directly.
+---
+
+# Claw Command (Legacy Shim)
+
+Use this only if you still reach for `/claw` from muscle memory. The maintained implementation lives in `skills/nanoclaw-repl/SKILL.md`.
+
+## Canonical Surface
+
+- Prefer the `nanoclaw-repl` skill directly.
+- Keep this file only as a compatibility entry point while command-first usage is retired.
+
+## Arguments
+
+`$ARGUMENTS`
+
+## Delegation
+
+Apply the `nanoclaw-repl` skill and keep the response focused on operating or extending `scripts/claw.js`.
+- If the user wants to run it, use `node scripts/claw.js` or `npm run claw`.
+- If the user wants to extend it, preserve the zero-dependency and markdown-backed session model.
+- If the request is really about long-running orchestration rather than NanoClaw itself, redirect to `dmux-workflows` or `autonomous-agent-harness`.