claude-remote-cli 3.10.0 → 3.11.0

package/dist/test/ticket-transitions.test.js

@@ -146,32 +146,18 @@ describe('ticket-transitions', () => {
         });
     });
 });
-// ─── Jira / Linear transition tests ─────────────────────────────────────────
-describe('ticket-transitions (Jira/Linear)', () => {
+// ─── Jira transition tests ────────────────────────────────────────────────────
+describe('ticket-transitions (Jira)', () => {
     let tmpDir;
     let configPath;
-    const origFetch = globalThis.fetch;
-    const origEnv = {};
     before(() => {
-        tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'tt-jira-linear-'));
+        tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'tt-jira-'));
         configPath = path.join(tmpDir, 'config.json');
-        // Save env vars
-        for (const key of ['JIRA_API_TOKEN', 'JIRA_EMAIL', 'JIRA_BASE_URL', 'LINEAR_API_KEY']) {
-            origEnv[key] = process.env[key];
-        }
     });
     after(() => {
-        globalThis.fetch = origFetch;
-        // Restore env vars
-        for (const [key, val] of Object.entries(origEnv)) {
-            if (val === undefined)
-                delete process.env[key];
-            else
-                process.env[key] = val;
-        }
         fs.rmSync(tmpDir, { recursive: true, force: true });
     });
-    function writeConfig(mappings) {
+    function writeJiraConfig(statusMappings) {
         const config = {
             host: '0.0.0.0',
             port: 3456,
@@ -185,29 +171,25 @@ describe('ticket-transitions (Jira/Linear)', () => {
             launchInTmux: false,
             defaultNotifications: true,
             integrations: {
-                ...(mappings.jira ? { jira: { projectKey: 'PROJ', statusMappings: mappings.jira } } : {}),
-                ...(mappings.linear ? { linear: { teamId: 'TEAM', statusMappings: mappings.linear } } : {}),
+                jira: { projectKey: 'PROJ', statusMappings },
             },
         };
         fs.writeFileSync(configPath, JSON.stringify(config, null, 2));
     }
-    function makeJiraLinearApp() {
+    function makeJiraApp(execOverride) {
         const { exec } = makeExecMock();
-        const deps = { configPath, execAsync: exec };
+        const effectiveExec = execOverride ?? exec;
+        const deps = { configPath, execAsync: effectiveExec };
         return createTicketTransitionsRouter(deps);
     }
-    test('detectTicketSource returns jira for PROJ-123 when JIRA_API_TOKEN is set', async () => {
-        process.env.JIRA_API_TOKEN = 'fake-token';
-        process.env.JIRA_EMAIL = 'test@test.com';
-        process.env.JIRA_BASE_URL = 'https://test.atlassian.net';
-        delete process.env.LINEAR_API_KEY;
-        writeConfig({ jira: { 'in-progress': '21' } });
-        const { transitionOnSessionCreate } = makeJiraLinearApp();
-        const fetchCalls = [];
-        globalThis.fetch = (async (input) => {
-            fetchCalls.push(String(input));
-            return { ok: true, status: 200, json: async () => ({}) };
-        });
+    test('transitionOnSessionCreate calls acli jira workitem transition for Jira ticket', async () => {
+        writeJiraConfig({ 'in-progress': 'In Progress' });
+        const acliCalls = [];
+        const trackingExec = async (cmd, args) => {
+            acliCalls.push({ cmd: cmd, args: args });
+            return { stdout: '', stderr: '' };
+        };
+        const { transitionOnSessionCreate } = makeJiraApp(trackingExec);
         const ctx = {
             ticketId: 'PROJ-123',
             title: 'Test',
@@ -217,47 +199,18 @@ describe('ticket-transitions (Jira/Linear)', () => {
             repoName: 'repo',
         };
         await transitionOnSessionCreate(ctx);
-        assert.ok(fetchCalls.some((u) => u.includes('/rest/api/3/issue/PROJ-123/transitions')), `Expected Jira transition call, got: ${fetchCalls.join(', ')}`);
+        const transitionCall = acliCalls.find((c) => c.cmd === 'acli' && c.args.includes('transition') && c.args.includes('PROJ-123'));
+        assert.ok(transitionCall, `Expected acli jira workitem transition call, got: ${JSON.stringify(acliCalls)}`);
+        assert.ok(transitionCall.args.includes('In Progress'), 'Should pass the mapped status name');
     });
-    test('detectTicketSource returns linear for TEAM-42 when LINEAR_API_KEY is set', async () => {
-        delete process.env.JIRA_API_TOKEN;
-        delete process.env.JIRA_EMAIL;
-        delete process.env.JIRA_BASE_URL;
-        process.env.LINEAR_API_KEY = 'fake-linear-key';
-        writeConfig({ linear: { 'in-progress': 'state-in-progress-id' } });
-        const { transitionOnSessionCreate } = makeJiraLinearApp();
-        const fetchCalls = [];
-        globalThis.fetch = (async (input) => {
-            fetchCalls.push(String(input));
-            return {
-                ok: true,
-                status: 200,
-                json: async () => ({ data: { issues: { nodes: [{ id: 'issue-uuid' }] } } }),
-            };
-        });
-        const ctx = {
-            ticketId: 'TEAM-42',
-            title: 'Test',
-            url: 'https://linear.app/team/issue/TEAM-42',
-            source: 'linear',
-            repoPath: '/fake/repo',
-            repoName: 'repo',
+    test('transitionOnSessionCreate skips when no status mapping configured', async () => {
+        writeJiraConfig({}); // Empty mappings — no 'in-progress' key
+        const acliCalls = [];
+        const trackingExec = async (cmd, args) => {
+            acliCalls.push({ cmd: cmd, args: args });
+            return { stdout: '', stderr: '' };
         };
-        await transitionOnSessionCreate(ctx);
-        assert.ok(fetchCalls.some((u) => u.includes('linear.app/graphql')), `Expected Linear GraphQL call, got: ${fetchCalls.join(', ')}`);
-    });
-    test('skips transition when no status mapping configured', async () => {
-        process.env.JIRA_API_TOKEN = 'fake-token';
-        process.env.JIRA_EMAIL = 'test@test.com';
-        process.env.JIRA_BASE_URL = 'https://test.atlassian.net';
-        // Config with empty mappings — no 'in-progress' mapping
-        writeConfig({ jira: {} });
-        const { transitionOnSessionCreate } = makeJiraLinearApp();
-        const fetchCalls = [];
-        globalThis.fetch = (async (input) => {
-            fetchCalls.push(String(input));
-            return { ok: true, status: 200, json: async () => ({}) };
-        });
+        const { transitionOnSessionCreate } = makeJiraApp(trackingExec);
         const ctx = {
             ticketId: 'PROJ-456',
             title: 'Test',
@@ -267,204 +220,46 @@ describe('ticket-transitions (Jira/Linear)', () => {
             repoName: 'repo',
         };
         await transitionOnSessionCreate(ctx);
-        assert.equal(fetchCalls.length, 0, 'Should not call fetch when no status mapping exists');
+        assert.equal(acliCalls.length, 0, 'Should not call acli when no status mapping exists');
     });
-    test('checkPrTransitions calls Jira transition for OPEN PR with mapped ticket', async () => {
-        process.env.JIRA_API_TOKEN = 'fake-token';
-        process.env.JIRA_EMAIL = 'test@test.com';
-        process.env.JIRA_BASE_URL = 'https://test.atlassian.net';
-        delete process.env.LINEAR_API_KEY;
-        writeConfig({ jira: { 'code-review': '31', 'ready-for-qa': '41' } });
-        const { checkPrTransitions } = makeJiraLinearApp();
-        const fetchCalls = [];
-        globalThis.fetch = (async (input, init) => {
-            const reqInit = init;
-            fetchCalls.push({ url: String(input), body: reqInit?.body ?? '' });
-            return { ok: true, status: 200, json: async () => ({}) };
-        });
-        const prs = [{ number: 10, headRefName: 'feat/jira-pr', state: 'OPEN' }];
-        const branchLinks = {
-            'PROJ-789': [{ repoPath: '/fake/repo', repoName: 'repo', branchName: 'feat/jira-pr', hasActiveSession: true }],
+    test('transitionOnSessionCreate is idempotent — second call blocked after success', async () => {
+        writeJiraConfig({ 'in-progress': 'In Progress' });
+        const acliCalls = [];
+        const trackingExec = async (cmd, args) => {
+            acliCalls.push({ cmd: cmd, args: args });
+            return { stdout: '', stderr: '' };
         };
-        await checkPrTransitions(prs, branchLinks);
-        const transitionCall = fetchCalls.find((c) => c.url.includes('/transitions'));
-        assert.ok(transitionCall, `Expected Jira transition call, got: ${fetchCalls.map((c) => c.url).join(', ')}`);
-        assert.ok(transitionCall.body.includes('"31"'), 'Should use code-review transition ID 31');
-    });
-    // ── New tests ────────────────────────────────────────────────────────────
-    test('Jira transitionOnSessionCreate — correct URL and transitionId, transitionMap updated only on success', async () => {
-        process.env.JIRA_API_TOKEN = 'fake-token';
-        process.env.JIRA_EMAIL = 'test@test.com';
-        process.env.JIRA_BASE_URL = 'https://my-org.atlassian.net';
-        delete process.env.LINEAR_API_KEY;
-        writeConfig({ jira: { 'in-progress': '21', 'code-review': '31' } });
-        const { transitionOnSessionCreate } = makeJiraLinearApp();
-        const fetchCalls = [];
-        globalThis.fetch = (async (input, init) => {
-            const reqInit = init;
-            fetchCalls.push({ url: String(input), body: reqInit?.body ?? '' });
-            return { ok: true, status: 204, json: async () => ({}) };
-        });
+        const { transitionOnSessionCreate } = makeJiraApp(trackingExec);
         const ctx = {
-            ticketId: 'MYPROJ-55',
+            ticketId: 'PROJ-55',
             title: 'Jira test issue',
-            url: 'https://my-org.atlassian.net/browse/MYPROJ-55',
+            url: 'https://jira.example.com/browse/PROJ-55',
             source: 'jira',
             repoPath: '/fake/repo',
             repoName: 'repo',
         };
         await transitionOnSessionCreate(ctx);
-        assert.equal(fetchCalls.length, 1, 'Should make exactly one fetch call');
-        assert.ok(fetchCalls[0].url.includes('/rest/api/3/issue/MYPROJ-55/transitions'), `Expected Jira transition URL, got: ${fetchCalls[0].url}`);
-        assert.ok(fetchCalls[0].body.includes('"21"'), 'Should pass in-progress transition ID 21');
-        // Verify idempotency — second call should be blocked because transitionMap was updated
-        fetchCalls.length = 0;
+        const firstCallCount = acliCalls.length;
+        assert.ok(firstCallCount > 0, 'First call should trigger acli');
+        // Second call — should be blocked by idempotency guard
         await transitionOnSessionCreate(ctx);
-        assert.equal(fetchCalls.length, 0, 'Second call should be blocked by idempotency guard after success');
+        assert.equal(acliCalls.length, firstCallCount, 'Second call should be blocked by idempotency guard after success');
     });
-    test('Linear transitionOnSessionCreate — calls issue lookup then state update mutation', async () => {
-        delete process.env.JIRA_API_TOKEN;
-        delete process.env.JIRA_EMAIL;
-        delete process.env.JIRA_BASE_URL;
-        process.env.LINEAR_API_KEY = 'lin_api_fake';
-        writeConfig({ linear: { 'in-progress': 'state-id-1', 'code-review': 'state-id-2' } });
-        const { transitionOnSessionCreate } = makeJiraLinearApp();
-        let callCount = 0;
-        const fetchCalls = [];
-        globalThis.fetch = (async (input, init) => {
-            const reqInit = init;
-            fetchCalls.push({ url: String(input), body: reqInit?.body ?? '' });
-            callCount++;
-            // First call: issue lookup — return issue UUID
-            if (callCount === 1) {
-                return {
-                    ok: true,
-                    status: 200,
-                    json: async () => ({ data: { issues: { nodes: [{ id: 'issue-uuid-abc' }] } } }),
-                };
-            }
-            // Second call: state update mutation
-            return {
-                ok: true,
-                status: 200,
-                json: async () => ({ data: { issueUpdate: { success: true } } }),
-            };
-        });
-        const ctx = {
-            ticketId: 'ENG-77',
-            title: 'Linear test issue',
-            url: 'https://linear.app/eng/issue/ENG-77',
-            source: 'linear',
-            repoPath: '/fake/repo',
-            repoName: 'repo',
+    test('checkPrTransitions calls acli jira workitem transition for OPEN PR with mapped Jira ticket', async () => {
+        writeJiraConfig({ 'code-review': 'Code Review', 'ready-for-qa': 'Ready for QA' });
+        const acliCalls = [];
+        const trackingExec = async (cmd, args) => {
+            acliCalls.push({ cmd: cmd, args: args });
+            return { stdout: '', stderr: '' };
         };
-        await transitionOnSessionCreate(ctx);
-        assert.equal(fetchCalls.length, 2, 'Should make two fetch calls — one lookup, one update');
-        assert.ok(fetchCalls.every((c) => c.url.includes('linear.app/graphql')), 'Both calls should target the Linear GraphQL endpoint');
-        // First call: issue lookup query
-        assert.ok(fetchCalls[0].body.includes('ENG-77'), 'Lookup should reference the ticket identifier');
-        // Second call: mutation with resolved issue UUID and target state ID
-        assert.ok(fetchCalls[1].body.includes('issue-uuid-abc'), 'Update mutation should use resolved issue UUID');
-        assert.ok(fetchCalls[1].body.includes('state-id-1'), 'Update mutation should pass in-progress state ID');
-        // Verify idempotency after success
-        fetchCalls.length = 0;
-        callCount = 0;
-        await transitionOnSessionCreate(ctx);
-        assert.equal(fetchCalls.length, 0, 'Second call should be blocked by idempotency guard after success');
-    });
-    test('F5 premature idempotency — failed fetch does not update transitionMap, second call retries', async () => {
-        process.env.JIRA_API_TOKEN = 'fake-token';
-        process.env.JIRA_EMAIL = 'test@test.com';
-        process.env.JIRA_BASE_URL = 'https://my-org.atlassian.net';
-        delete process.env.LINEAR_API_KEY;
-        writeConfig({ jira: { 'in-progress': '21', 'code-review': '31' } });
-        const { transitionOnSessionCreate } = makeJiraLinearApp();
-        const fetchCalls = [];
-        // First attempt: server returns 500
-        globalThis.fetch = (async (input) => {
-            fetchCalls.push(String(input));
-            return { ok: false, status: 500, json: async () => ({}) };
-        });
-        const ctx = {
-            ticketId: 'FAIL-99',
-            title: 'Failing ticket',
-            url: 'https://my-org.atlassian.net/browse/FAIL-99',
-            source: 'jira',
-            repoPath: '/fake/repo',
-            repoName: 'repo',
-        };
-        await transitionOnSessionCreate(ctx);
-        assert.equal(fetchCalls.length, 1, 'First call should attempt fetch');
-        // Second attempt after failure: transitionMap should NOT have been updated,
-        // so the guard should not block this retry
-        const fetchCallsBeforeRetry = fetchCalls.length;
-        globalThis.fetch = (async (input) => {
-            fetchCalls.push(String(input));
-            return { ok: true, status: 204, json: async () => ({}) };
-        });
-        await transitionOnSessionCreate(ctx);
-        assert.ok(fetchCalls.length > fetchCallsBeforeRetry, 'Second call should NOT be blocked — failed remote call must not update transitionMap');
-    });
-    test('Source detection via BranchLink source field — jira source overrides env-var heuristic', async () => {
-        // Set up env so that env-var heuristic would pick linear (if source field were ignored)
-        delete process.env.JIRA_API_TOKEN;
-        delete process.env.JIRA_EMAIL;
-        delete process.env.JIRA_BASE_URL;
-        process.env.LINEAR_API_KEY = 'lin_api_fake';
-        // But also set Jira env so jiraTransition can actually run
-        process.env.JIRA_API_TOKEN = 'fake-token';
-        process.env.JIRA_EMAIL = 'test@test.com';
-        process.env.JIRA_BASE_URL = 'https://my-org.atlassian.net';
-        writeConfig({ jira: { 'code-review': '31' }, linear: { 'code-review': 'state-id-2' } });
-        const { checkPrTransitions } = makeJiraLinearApp();
-        const fetchCalls = [];
-        globalThis.fetch = (async (input, init) => {
-            const reqInit = init;
-            fetchCalls.push({ url: String(input), body: reqInit?.body ?? '' });
-            return { ok: true, status: 200, json: async () => ({}) };
-        });
-        const prs = [{ number: 20, headRefName: 'feat/via-branch-link', state: 'OPEN' }];
-        // BranchLink explicitly declares source: 'jira'
+        const { checkPrTransitions } = makeJiraApp(trackingExec);
+        const prs = [{ number: 10, headRefName: 'feat/jira-pr', state: 'OPEN' }];
         const branchLinks = {
-            'XPROJ-10': [
-                {
-                    repoPath: '/fake/repo',
-                    repoName: 'repo',
-                    branchName: 'feat/via-branch-link',
-                    hasActiveSession: true,
-                    source: 'jira',
-                },
-            ],
+            'PROJ-789': [{ repoPath: '/fake/repo', repoName: 'repo', branchName: 'feat/jira-pr', hasActiveSession: true }],
         };
         await checkPrTransitions(prs, branchLinks);
-        const jiraCall = fetchCalls.find((c) => c.url.includes('/rest/api/3/issue/XPROJ-10/transitions'));
-        assert.ok(jiraCall, `Expected Jira transition call (source from BranchLink), got: ${fetchCalls.map((c) => c.url).join(', ')}`);
-        assert.ok(jiraCall.body.includes('"31"'), 'Should use code-review Jira transition ID');
-        const linearCall = fetchCalls.find((c) => c.url.includes('linear.app/graphql'));
-        assert.equal(linearCall, undefined, 'Should NOT call Linear when BranchLink.source is jira');
-    });
-    test('Jira URL validation — http non-localhost URL is rejected without making a fetch', async () => {
-        process.env.JIRA_API_TOKEN = 'fake-token';
-        process.env.JIRA_EMAIL = 'test@test.com';
-        // Insecure non-localhost URL — should be rejected
-        process.env.JIRA_BASE_URL = 'http://evil.com';
-        delete process.env.LINEAR_API_KEY;
-        writeConfig({ jira: { 'in-progress': '21' } });
-        const { transitionOnSessionCreate } = makeJiraLinearApp();
-        const fetchCalls = [];
-        globalThis.fetch = (async (input) => {
-            fetchCalls.push(String(input));
-            return { ok: true, status: 200, json: async () => ({}) };
-        });
-        const ctx = {
-            ticketId: 'EVIL-1',
-            title: 'Evil ticket',
-            url: 'http://evil.com/browse/EVIL-1',
-            source: 'jira',
-            repoPath: '/fake/repo',
-            repoName: 'repo',
-        };
-        await transitionOnSessionCreate(ctx);
-        assert.equal(fetchCalls.length, 0, 'Should not make any fetch call when JIRA_BASE_URL is http non-localhost');
+        const transitionCall = acliCalls.find((c) => c.cmd === 'acli' && c.args.includes('transition') && c.args.includes('PROJ-789'));
+        assert.ok(transitionCall, `Expected acli jira workitem transition call, got: ${JSON.stringify(acliCalls)}`);
+        assert.ok(transitionCall.args.includes('Code Review'), 'Should use code-review status name');
     });
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "claude-remote-cli",
-  "version": "3.10.0",
+  "version": "3.11.0",
   "description": "Remote web interface for Claude Code CLI sessions",
   "type": "module",
   "main": "dist/server/index.js",