claude-remote-cli 3.10.0 → 3.11.0

package/dist/test/integration-jira.test.js

@@ -1,59 +1,60 @@
-import { test, before, after } from 'node:test';
+import { test, after } from 'node:test';
 import assert from 'node:assert/strict';
 import express from 'express';
 import { createIntegrationJiraRouter } from '../server/integration-jira.js';
-// ─── Constants ────────────────────────────────────────────────────────────────
-const FAKE_BASE_URL = 'https://fake-jira.atlassian.net';
-const FAKE_TOKEN = 'test-api-token';
-const FAKE_EMAIL = 'test@example.com';
+// ─── Mock stdout constants ────────────────────────────────────────────────────
+const AUTH_STATUS_STDOUT = `✓ Authenticated
+  Site: fake-jira.atlassian.net
+  Email: test@example.com
+  Authentication Type: oauth
+`;
 // ─── Globals ──────────────────────────────────────────────────────────────────
 let server;
 let baseUrl;
-/**
- * The real Node.js fetch, saved before any test replaces globalThis.fetch.
- * All HTTP calls from the test itself to the local Express server must use this.
- */
-let realFetch;
 // ─── Helpers ──────────────────────────────────────────────────────────────────
 /**
- * Builds a minimal Jira REST API issue shape for use in mock responses.
+ * Builds a minimal AcliWorkItem for use in mock stdout payloads.
  */
-function makeJiraApiIssue(overrides) {
-    const { key = 'TEST-1', summary = 'Test issue', status = 'In Progress', priority = 'Medium', storyPoints = null, sprint = null, assignee = 'Jane Doe', updated = '2026-03-21T00:00:00.000+0000', } = overrides;
+function makeAcliWorkItem(overrides) {
+    const { key = 'TEST-1', summary = 'Test issue', statusId = '3', statusName = 'In Progress', priorityName = 'Medium', assigneeDisplayName = 'Jane Doe', } = overrides;
     return {
         key,
-        self: `${FAKE_BASE_URL}/rest/api/3/issue/${key}`,
         fields: {
             summary,
-            status: { name: status },
-            priority: priority !== null ? { name: priority } : null,
-            customfield_10016: storyPoints,
-            customfield_10020: sprint !== null ? [{ name: sprint }] : null,
-            assignee: assignee !== null ? { displayName: assignee } : null,
-            updated,
+            status: { id: statusId, name: statusName },
+            ...(priorityName !== null ? { priority: { name: priorityName } } : { priority: null }),
+            ...(assigneeDisplayName !== null ? { assignee: { displayName: assigneeDisplayName } } : { assignee: null }),
         },
     };
 }
 /**
- * Builds a real Response with a given status and JSON body.
+ * Creates a mock execAsync that routes calls based on the acli subcommand args:
+ * - `acli jira auth status` → returns AUTH_STATUS_STDOUT (or throws)
+ * - `acli jira workitem search` → returns the provided items as JSON stdout (or throws)
  */
-function makeJsonResponse(body, status = 200) {
-    return new Response(JSON.stringify(body), {
-        status,
-        headers: { 'Content-Type': 'application/json' },
-    });
+function makeMockExec(opts) {
+    return async (_cmd, args) => {
+        const argv = args;
+        if (argv.includes('auth') && argv.includes('status')) {
+            if (opts.authError)
+                throw opts.authError;
+            return { stdout: AUTH_STATUS_STDOUT, stderr: '' };
+        }
+        if (argv.includes('workitem') && argv.includes('search')) {
+            if (opts.searchError)
+                throw opts.searchError;
+            return { stdout: JSON.stringify(opts.searchItems ?? []), stderr: '' };
+        }
+        throw new Error(`Unexpected exec call: acli ${argv.join(' ')}`);
+    };
 }
 // ─── Server lifecycle ─────────────────────────────────────────────────────────
-/**
- * Starts a fresh Express server with a new Jira router instance (and therefore
- * a fresh in-memory cache). Call this AFTER setting globalThis.fetch so the
- * router uses the mock when handling requests.
- */
-function startServer() {
+function startServer(execAsyncFn) {
     return new Promise((resolve) => {
         const app = express();
         app.use(express.json());
-        app.use('/integration-jira', createIntegrationJiraRouter({ configPath: '' }));
+        const deps = { configPath: '', execAsync: execAsyncFn };
+        app.use('/integration-jira', createIntegrationJiraRouter(deps));
         server = app.listen(0, '127.0.0.1', () => {
             const addr = server.address();
             if (typeof addr === 'object' && addr) {
@@ -71,88 +72,34 @@ function stopServer() {
             resolve();
     });
 }
-// ─── Env var helpers ──────────────────────────────────────────────────────────
-function setEnvVars() {
-    process.env.JIRA_API_TOKEN = FAKE_TOKEN;
-    process.env.JIRA_EMAIL = FAKE_EMAIL;
-    process.env.JIRA_BASE_URL = FAKE_BASE_URL;
-}
-function clearEnvVars() {
-    delete process.env.JIRA_API_TOKEN;
-    delete process.env.JIRA_EMAIL;
-    delete process.env.JIRA_BASE_URL;
-}
-// ─── Suite setup / teardown ───────────────────────────────────────────────────
-before(() => {
-    realFetch = globalThis.fetch;
-    clearEnvVars();
-});
+// ─── Suite teardown ───────────────────────────────────────────────────────────
 after(async () => {
-    globalThis.fetch = realFetch;
-    clearEnvVars();
     await stopServer();
 });
 // ─── Tests ────────────────────────────────────────────────────────────────────
-test('GET /configured returns true when all env vars are set', async () => {
-    setEnvVars();
-    globalThis.fetch = realFetch;
-    await stopServer();
-    await startServer();
-    const res = await realFetch(`${baseUrl}/integration-jira/configured`);
-    assert.equal(res.status, 200);
-    const body = (await res.json());
-    assert.equal(body.configured, true);
-});
-test('GET /configured returns false when any env var is missing', async () => {
-    clearEnvVars();
-    // Set only two of the three required vars; JIRA_BASE_URL intentionally omitted
-    process.env.JIRA_API_TOKEN = FAKE_TOKEN;
-    process.env.JIRA_EMAIL = FAKE_EMAIL;
-    globalThis.fetch = realFetch;
+test('GET /issues returns mapped JiraIssue[] from mocked acli JSON output', async () => {
     await stopServer();
-    await startServer();
-    const res = await realFetch(`${baseUrl}/integration-jira/configured`);
-    assert.equal(res.status, 200);
-    const body = (await res.json());
-    assert.equal(body.configured, false);
-    clearEnvVars();
-});
-test('GET /issues returns mapped JiraIssue[] from mocked Jira search response', async () => {
-    setEnvVars();
-    const mockSearchPayload = {
-        issues: [
-            makeJiraApiIssue({
-                key: 'PROJ-42',
-                summary: 'Fix the login bug',
-                status: 'In Progress',
-                priority: 'High',
-                storyPoints: 3,
-                sprint: 'Sprint 5',
-                assignee: 'Alice',
-                updated: '2026-03-21T12:00:00.000+0000',
-            }),
-            makeJiraApiIssue({
-                key: 'PROJ-10',
-                summary: 'Update docs',
-                status: 'To Do',
-                priority: null,
-                storyPoints: null,
-                sprint: null,
-                assignee: null,
-                updated: '2026-03-20T08:00:00.000+0000',
-            }),
-        ],
-    };
-    globalThis.fetch = async (input) => {
-        const url = typeof input === 'string' ? input : input.toString();
-        if (url.includes('/rest/api/3/search')) {
-            return makeJsonResponse(mockSearchPayload);
-        }
-        return makeJsonResponse({ error: 'unexpected url' }, 500);
-    };
-    await stopServer();
-    await startServer();
-    const res = await realFetch(`${baseUrl}/integration-jira/issues`);
+    const searchItems = [
+        makeAcliWorkItem({
+            key: 'PROJ-42',
+            summary: 'Fix the login bug',
+            statusId: '3',
+            statusName: 'In Progress',
+            priorityName: 'High',
+            assigneeDisplayName: 'Alice',
+        }),
+        makeAcliWorkItem({
+            key: 'PROJ-10',
+            summary: 'Update docs',
+            statusId: '1',
+            statusName: 'To Do',
+            priorityName: null,
+            assigneeDisplayName: null,
+        }),
+    ];
+    const exec = makeMockExec({ searchItems });
+    await startServer(exec);
+    const res = await fetch(`${baseUrl}/integration-jira/issues`);
     assert.equal(res.status, 200);
     const data = (await res.json());
     assert.equal(data.error, undefined, `Unexpected error: ${data.error}`);
@@ -162,91 +109,83 @@ test('GET /issues returns mapped JiraIssue[] from mocked Jira search response',
     assert.equal(issue42.title, 'Fix the login bug');
     assert.equal(issue42.status, 'In Progress');
     assert.equal(issue42.priority, 'High');
-    assert.equal(issue42.storyPoints, 3);
-    assert.equal(issue42.sprint, 'Sprint 5');
     assert.equal(issue42.assignee, 'Alice');
-    assert.equal(issue42.url, `${FAKE_BASE_URL}/browse/PROJ-42`);
+    assert.equal(issue42.url, 'https://fake-jira.atlassian.net/browse/PROJ-42');
     assert.equal(issue42.projectKey, 'PROJ');
+    assert.equal(issue42.updatedAt, '');
+    assert.equal(issue42.sprint, null);
+    assert.equal(issue42.storyPoints, null);
     const issue10 = data.issues.find((i) => i.key === 'PROJ-10');
     assert.ok(issue10, 'Should contain PROJ-10');
     assert.equal(issue10.priority, null);
-    assert.equal(issue10.storyPoints, null);
-    assert.equal(issue10.sprint, null);
     assert.equal(issue10.assignee, null);
-    // Verify sorted descending by updatedAt — PROJ-42 (newer) should come first
-    assert.equal(data.issues[0]?.key, 'PROJ-42');
-    assert.equal(data.issues[1]?.key, 'PROJ-10');
+    assert.equal(issue10.url, 'https://fake-jira.atlassian.net/browse/PROJ-10');
+    assert.equal(issue10.projectKey, 'PROJ');
 });
-test('GET /issues caches results within TTL — fetch called only once for two requests', async () => {
-    setEnvVars();
-    let fetchCallCount = 0;
-    const mockPayload = {
-        issues: [makeJiraApiIssue({ key: 'CACHE-1', summary: 'Cached issue' })],
-    };
-    globalThis.fetch = async (input) => {
-        const url = typeof input === 'string' ? input : input.toString();
-        if (url.includes('/rest/api/3/search')) {
-            fetchCallCount++;
-            return makeJsonResponse(mockPayload);
+test('GET /issues returns acli_not_in_path when exec throws ENOENT', async () => {
+    await stopServer();
+    const err = new Error('spawn acli ENOENT');
+    err.code = 'ENOENT';
+    const exec = makeMockExec({ authError: err });
+    await startServer(exec);
+    const res = await fetch(`${baseUrl}/integration-jira/issues`);
+    assert.equal(res.status, 200);
+    const data = (await res.json());
+    assert.equal(data.error, 'acli_not_in_path');
+    assert.equal(data.issues.length, 0);
+});
+test('GET /issues returns acli_not_authenticated when exec stderr contains auth message', async () => {
+    await stopServer();
+    const err = Object.assign(new Error('acli auth error'), {
+        stderr: "not logged in, use 'acli jira auth login' to authenticate",
+    });
+    const exec = makeMockExec({ authError: err });
+    await startServer(exec);
+    const res = await fetch(`${baseUrl}/integration-jira/issues`);
+    assert.equal(res.status, 200);
+    const data = (await res.json());
+    assert.equal(data.error, 'acli_not_authenticated');
+    assert.equal(data.issues.length, 0);
+});
+test('GET /issues caches results within TTL — exec called only once for two requests', async () => {
+    await stopServer();
+    let searchCallCount = 0;
+    const baseExec = makeMockExec({
+        searchItems: [makeAcliWorkItem({ key: 'CACHE-1', summary: 'Cached issue' })],
+    });
+    const countingExec = async (...args) => {
+        const argv = args[1];
+        if (argv.includes('workitem') && argv.includes('search')) {
+            searchCallCount++;
         }
-        return makeJsonResponse({}, 500);
+        return baseExec(...args);
     };
-    await stopServer();
-    await startServer();
+    await startServer(countingExec);
     // First request — populates cache
-    const firstRes = await realFetch(`${baseUrl}/integration-jira/issues`);
+    const firstRes = await fetch(`${baseUrl}/integration-jira/issues`);
     const first = (await firstRes.json());
     assert.equal(first.error, undefined, `Unexpected error: ${first.error}`);
     assert.equal(first.issues.length, 1);
-    assert.equal(fetchCallCount, 1, 'fetch should be called once on first request');
-    // Second request — should be served from cache, no additional fetch
-    const secondRes = await realFetch(`${baseUrl}/integration-jira/issues`);
+    assert.equal(searchCallCount, 1, 'search should be called once on first request');
+    // Second request — should be served from cache, no additional exec call
+    const secondRes = await fetch(`${baseUrl}/integration-jira/issues`);
     const second = (await secondRes.json());
     assert.equal(second.error, undefined, `Unexpected error: ${second.error}`);
     assert.equal(second.issues.length, 1);
-    assert.equal(fetchCallCount, 1, 'fetch should not be called again within TTL (cache hit)');
+    assert.equal(searchCallCount, 1, 'search should not be called again within TTL (cache hit)');
 });
-test('GET /issues returns jira_not_configured when env vars missing', async () => {
-    clearEnvVars();
-    // fetch should never be called — use a mock that throws to verify early return
-    globalThis.fetch = async () => {
-        throw new Error('fetch should not be called when not configured');
-    };
+test('GET /statuses?projectKey=TEST returns deduplicated statuses', async () => {
     await stopServer();
-    await startServer();
-    const res = await realFetch(`${baseUrl}/integration-jira/issues`);
-    assert.equal(res.status, 200);
-    const data = (await res.json());
-    assert.equal(data.error, 'jira_not_configured');
-    assert.equal(data.issues.length, 0);
-});
-test('GET /statuses?projectKey=TEST returns deduplicated statuses from Jira project API', async () => {
-    setEnvVars();
-    // Jira returns one entry per issue type; statuses may overlap across types
-    const mockProjectStatuses = [
-        {
-            statuses: [
-                { id: '1', name: 'To Do' },
-                { id: '2', name: 'In Progress' },
-            ],
-        },
-        {
-            statuses: [
-                { id: '2', name: 'In Progress' }, // duplicate — should be filtered
-                { id: '3', name: 'Done' },
-            ],
-        },
+    // Items with overlapping status IDs — deduplication should collapse to 3 unique statuses
+    const searchItems = [
+        makeAcliWorkItem({ key: 'TEST-1', statusId: '1', statusName: 'To Do' }),
+        makeAcliWorkItem({ key: 'TEST-2', statusId: '2', statusName: 'In Progress' }),
+        makeAcliWorkItem({ key: 'TEST-3', statusId: '2', statusName: 'In Progress' }), // duplicate
+        makeAcliWorkItem({ key: 'TEST-4', statusId: '3', statusName: 'Done' }),
     ];
-    globalThis.fetch = async (input) => {
-        const url = typeof input === 'string' ? input : input.toString();
-        if (url.includes('/rest/api/3/project/TEST/statuses')) {
-            return makeJsonResponse(mockProjectStatuses);
-        }
-        return makeJsonResponse({}, 500);
-    };
-    await stopServer();
-    await startServer();
-    const res = await realFetch(`${baseUrl}/integration-jira/statuses?projectKey=TEST`);
+    const exec = makeMockExec({ searchItems });
+    await startServer(exec);
+    const res = await fetch(`${baseUrl}/integration-jira/statuses?projectKey=TEST`);
     assert.equal(res.status, 200);
     const data = (await res.json());
     assert.equal(data.error, undefined, `Unexpected error: ${data.error}`);
@@ -256,47 +195,27 @@ test('GET /statuses?projectKey=TEST returns deduplicated statuses from Jira proj
     const names = data.statuses.map((s) => s.name);
     assert.deepEqual(names, ['To Do', 'In Progress', 'Done']);
 });
-test('GET /issues returns jira_auth_failed on 401 from Jira API', async () => {
-    setEnvVars();
-    globalThis.fetch = async (input) => {
-        const url = typeof input === 'string' ? input : input.toString();
-        if (url.includes('/rest/api/3/search')) {
-            return makeJsonResponse({ message: 'Unauthorized' }, 401);
-        }
-        return makeJsonResponse({}, 500);
-    };
-    await stopServer();
-    await startServer();
-    const res = await realFetch(`${baseUrl}/integration-jira/issues`);
-    assert.equal(res.status, 200);
-    const data = (await res.json());
-    assert.equal(data.error, 'jira_auth_failed');
-    assert.equal(data.issues.length, 0);
-});
-test('GET /statuses returns jira_auth_failed on 401 from Jira project API', async () => {
-    setEnvVars();
-    globalThis.fetch = async (input) => {
-        const url = typeof input === 'string' ? input : input.toString();
-        if (url.includes('/rest/api/3/project')) {
-            return makeJsonResponse({ message: 'Unauthorized' }, 401);
-        }
-        return makeJsonResponse({}, 500);
-    };
-    await stopServer();
-    await startServer();
-    const res = await realFetch(`${baseUrl}/integration-jira/statuses?projectKey=TEST`);
-    assert.equal(res.status, 200);
-    const data = (await res.json());
-    assert.equal(data.error, 'jira_auth_failed');
-    assert.equal(data.statuses.length, 0);
-});
 test('GET /statuses returns 400 when projectKey query param is missing', async () => {
-    setEnvVars();
-    globalThis.fetch = realFetch;
     await stopServer();
-    await startServer();
-    const res = await realFetch(`${baseUrl}/integration-jira/statuses`);
+    const exec = makeMockExec({ searchItems: [] });
+    await startServer(exec);
+    const res = await fetch(`${baseUrl}/integration-jira/statuses`);
     assert.equal(res.status, 400);
     const data = (await res.json());
     assert.equal(data.error, 'missing_project_key');
 });
+test('GET /statuses returns 400 for invalid projectKey (lowercase or special chars)', async () => {
+    await stopServer();
+    const exec = makeMockExec({ searchItems: [] });
+    await startServer(exec);
+    // Lowercase key
+    const resLower = await fetch(`${baseUrl}/integration-jira/statuses?projectKey=test`);
+    assert.equal(resLower.status, 400);
+    const dataLower = (await resLower.json());
+    assert.equal(dataLower.error, 'invalid_project_key');
+    // Key with special characters
+    const resSpecial = await fetch(`${baseUrl}/integration-jira/statuses?projectKey=TEST%20PROJ`);
+    assert.equal(resSpecial.status, 400);
+    const dataSpecial = (await resSpecial.json());
+    assert.equal(dataSpecial.error, 'invalid_project_key');
+});