claude-flow-novice 2.8.1 → 2.9.0

package/.claude/skills/cfn-loop-validation/SKILL.md

@@ -1,353 +0,0 @@
-# CFN Loop Validation Skill
-
-**Purpose:** Implement multi-layer validation and quality gates for CFN Loop workflows with clean agent exit patterns.
-
-**Version:** 2.3.0  
-**Confidence:** 0.98  
-**Status:** Production Ready (Robustness Enhanced)
-
----
-
-## Core Architecture
-
-### Clean Agent Exit Protocol
-
-**Critical Principle:** Agents MUST exit immediately after reporting confidence. No waiting mode for implementers/validators.
-
-```bash
-# ✅ CORRECT - Agent completion protocol
-# Step 1: Complete work
-# Step 2: Signal completion
-redis-cli lpush "swarm:${TASK_ID}:${AGENT_ID}:done" "complete"
-
-# Step 3: Report confidence
-./.claude/skills/redis-coordination/invoke-waiting-mode.sh report \
-  --task-id "$TASK_ID" \
-  --agent-id "$AGENT_ID" \
-  --confidence 0.85 \
-  --iteration 1
-
-# Step 4: EXIT CLEANLY (no waiting mode)
-# Agent process terminates here
-```
-
-```bash
-# ❌ FORBIDDEN - Agents entering waiting mode
-./.claude/skills/redis-coordination/invoke-waiting-mode.sh enter \
-  --task-id "$TASK_ID" \
-  --agent-id "${AGENT_ID}" \
-  --context "iteration-complete"
-```
-
-**Why Clean Exit Matters:**
-- Prevents orchestrator blocking on `wait $PID`
-- Enables adaptive agent specialization (different agents per iteration)
-- Eliminates indefinite blocking scenarios
-- Supports true parallel execution
-
-### Validation Layers
-
-#### Layer 1: Gate Validation (Loop 3 Self-Validation)
-- **Threshold:** Mode-dependent (0.70-0.85)
-- **Purpose:** Implementers self-assess work quality
-- **Blocking:** Prevents validators from reviewing incomplete work
-
-#### Layer 2: Consensus Validation (Loop 2 Validators)
-- **Threshold:** Mode-dependent (0.80-0.95)
-- **Purpose:** Independent quality assessment
-- **Requirement:** Minimum 2 validators for robust consensus
-
-#### Layer 3: Product Owner Decision
-- **Purpose:** Strategic validation and scope enforcement
-- **Options:** PROCEED/ITERATE/ABORT
-- **Anti-Pattern Prevention:** Prevents "consensus on vapor"
-
-### Dependency Enforcement
-
-**Mandatory Flow:**
-1. Loop 3 agents complete work
-2. Gate check validates Loop 3 quality
-3. **IF gate passes →** Signal `swarm:${TASK_ID}:gate-passed`
-4. Loop 2 validators wait for gate signal via `blpop`
-5. Loop 2 validators review and report consensus
-6. Product Owner makes final decision
-
-**Redis Coordination:**
-```bash
-# Loop 2 agents wait for gate signal
-redis-cli blpop "swarm:${TASK_ID}:gate-passed" 0
-
-# Gate signal sent by orchestrator
-redis-cli lpush "swarm:${TASK_ID}:gate-passed" "true"
-```
-
----
-
-## Mode Configurations
-
-### MVP Mode (Fast Validation)
-- **Gate Threshold:** 0.70
-- **Consensus Threshold:** 0.80
-- **Max Iterations:** 5
-- **Validators:** 2
-- **Use Case:** Quick prototyping, proof-of-concepts
-
-### Standard Mode (Balanced Quality)
-- **Gate Threshold:** 0.75
-- **Consensus Threshold:** 0.90
-- **Max Iterations:** 10
-- **Validators:** 3-4
-- **Use Case:** Production features, standard development
-
-### Enterprise Mode (Maximum Quality)
-- **Gate Threshold:** 0.85
-- **Consensus Threshold:** 0.95
-- **Max Iterations:** 15
-- **Validators:** 5
-- **Use Case:** Critical systems, security-sensitive features
-
----
-
-## Agent Lifecycle Management
-
-### Coordinator Responsibilities
-- Spawn agents via CLI (cost optimization)
-- Manage Redis coordination
-- Handle iteration logic
-- Collect confidence scores
-- Enforce dependency blocking
-
-### Agent Responsibilities
-- Complete assigned work
-- Signal completion via Redis
-- Report confidence score
-- **Exit immediately (no waiting mode) - MANDATORY**
-
-### Updated Agent Completion Protocol (v2.3)
-```bash
-# ✅ NEW MANDATORY PROTOCOL - All agents MUST follow
-# Step 1: Complete work
-# Step 2: Signal completion
-redis-cli lpush "swarm:${TASK_ID}:${AGENT_ID}:done" "complete"
-
-# Step 3: Report confidence score
-./.claude/skills/redis-coordination/invoke-waiting-mode.sh report \
-  --task-id "$TASK_ID" \
-  --agent-id "$AGENT_ID" \
-  --confidence 0.92 \
-  --iteration 1
-
-# Step 4: EXIT CLEANLY (no waiting mode - agents MUST NOT enter waiting mode)
-# Agent process terminates here - orchestrator uses wait $PID
-exit 0
-```
-
-### Clean Exit Benefits
-1. **No Blocking:** Orchestrator uses `wait $PID` successfully
-2. **Adaptive Specialization:** Different agents per iteration
-3. **Resource Efficiency:** No idle agent processes
-4. **Simplified Debugging:** Clear agent lifecycle
-5. **Prevents Orchestration Deadlock:** Eliminates indefinite agent blocking
-6. **Enables True Parallelism:** Multiple agents can complete independently
-
-### Forbidden Patterns (Critical Anti-Patterns)
-```bash
-# ❌ FORBIDDEN - Agents MUST NOT enter waiting mode
-./.claude/skills/redis-coordination/invoke-waiting-mode.sh enter \
-  --task-id "$TASK_ID" \
-  --agent-id "${AGENT_ID}" \
-  --context "iteration-complete"
-
-# ❌ FORBIDDEN - Only coordinators use waiting mode
-if [[ "$AGENT_TYPE" != "coordinator" ]]; then
-  echo "ERROR: Non-coordinator agents cannot use waiting mode"
-  exit 1
-fi
-```
-
----
-
-## Context Injection Patterns
-
-### Multi-Layer Context Flow
-```
-Coordinator → Redis Storage → Orchestrator → Agent Spawning → Agent Context
-```
-
-**Critical Requirement:** Context must flow through ALL layers.
-
-#### Context Components
-- **Epic Context:** High-level goals and scope
-- **Phase Context:** Sprint-specific requirements
-- **Success Criteria:** Acceptance criteria and deliverables
-- **Thresholds:** Gate and consensus values
-
-#### Context Validation
-1. **Coordinator:** Validates context has deliverables before spawning
-2. **Orchestrator:** Validates Redis retrieval before agent spawning
-3. **Agents:** Validate received context has required fields
-
-**Anti-Pattern Prevention:** Avoid generic context when specifics exist in Redis.
-
----
-
-## Quality Gates Implementation
-
-### Deliverable Verification (STRAT-020)
-**Mandatory check:** Validate actual file creation for implementation tasks.
-
-```bash
-# Check for deliverable creation
-git_status=$(git status --porcelain 2>/dev/null || echo "")
-if [[ -z "$git_status" ]] && [[ "$task_type" == "implementation" ]]; then
-    # Force iteration - no files created
-    consensus=0.0
-    feedback="No deliverable files created. Must implement actual changes."
-fi
-```
-
-### Confidence Scoring Patterns
-- **Explicit Numeric:** `0.85` (preferred)
-- **Percentage:** `85%` (supported)
-- **Qualitative:** `high/medium/low` (converted to 0.8/0.5/0.2)
-- **Calculated:** Based on deliverable completion
-
-### Multi-Pattern Parsing (PATTERN-009)
-```bash
-# Extract confidence with fallback strategies
-confidence=$(echo "$output" | grep -o "confidence: [0-9.]*" | tail -1 | cut -d' ' -f2)
-if [[ -z "$confidence" ]]; then
-    confidence=$(echo "$output" | grep -o "[0-9]*%" | tail -1 | sed 's/%//')
-    if [[ -n "$confidence" ]]; then
-        confidence=$(echo "scale=2; $confidence/100" | bc -l)
-    fi
-fi
-```
-
----
-
-## Testing and Validation
-
-### Test Suite Requirements
-- Validate clean agent exit
-- Test dependency enforcement
-- Verify context injection
-- Check timeout handling
-- Validate consensus calculations
-
-### Key Test Cases
-1. **Clean Exit Test:** Agents exit without waiting mode
-2. **Blocking Test:** Loop 2 waits for Loop 3 gate signal
-3. **Context Test:** Deliverables flow through all layers
-4. **Iteration Test:** Quality gate triggers iteration
-5. **Timeout Test:** Agents respect phase timeouts
-
----
-
-## Integration Points
-
-### Redis Coordination Skill
-- Uses `invoke-waiting-mode.sh report` for confidence reporting
-- No `enter` calls for implementers/validators
-- Blocking via `blpop` for dependency enforcement
-
-### Agent Spawning Skill
-- CLI spawning for cost optimization
-- Agent ID assignment and tracking
-- Background process management
-
-### Product Owner Decision Skill
-- Structured decision parsing
-- Deliverable validation
-- Scope enforcement
-
----
-
-## Error Handling and Recovery
-
-### Timeout Scenarios
-- **Phase-specific timeouts:** Based on work complexity
-- **Agent timeout:** `timeout` command wrapper
-- **Orchestrator timeout:** Background execution with monitoring
-
-### Failure Recovery
-- **Redis state cleanup:** Clear iteration data
-- **Agent PID tracking:** Monitor and cleanup stuck processes
-- **Context validation:** Fail-fast on missing context
-
----
-
-## Performance Optimization
-
-### Cost Savings
-- **CLI Spawning:** 95-98% cost reduction vs Task()
-- **Zero-Token Waiting:** Redis BLPOP for coordination
-- **Parallel Execution:** Background agent spawning
-
-### Resource Management
-- **Clean Exit:** No idle agent processes
-- **Timeout Enforcement:** Prevent resource leaks
-- **Redis Cleanup:** Automatic state management
-
----
-
-## Usage Examples
-
-### Standard CFN Loop Execution
-```bash
-./.claude/skills/redis-coordination/orchestrate-cfn-loop.sh \
-  --task-id "feature-auth-123" \
-  --mode standard \
-  --loop3-agents "backend-dev,security-specialist" \
-  --loop2-agents "reviewer,tester,architect" \
-  --product-owner "product-owner" \
-  --phase-id "phase-2" \
-  --epic-context '{"epicGoal":"Build auth system","inScope":["JWT","OAuth"]}' \
-  --phase-context '{"deliverables":["auth.js","tests/auth.test.js"]}' \
-  --success-criteria '{"acceptanceCriteria":["JWT tokens work","Tests pass"]}'
-```
-
-### Agent Implementation Protocol
-```bash
-# Agent receives task context
-# Completes implementation work
-
-# Signal completion
-redis-cli lpush "swarm:${TASK_ID}:${AGENT_ID}:done" "complete"
-
-# Report confidence
-./.claude/skills/redis-coordination/invoke-waiting-mode.sh report \
-  --task-id "$TASK_ID" \
-  --agent-id "$AGENT_ID" \
-  --confidence 0.92 \
-  --iteration 1
-
-# EXIT CLEANLY - no waiting mode
-```
-
----
-
-## Monitoring and Debugging
-
-### Key Redis Keys
-- `swarm:${TASK_ID}:${AGENT_ID}:done` - Completion signal
-- `swarm:${TASK_ID}:${AGENT_ID}:confidence` - Confidence score
-- `swarm:${TASK_ID}:gate-passed` - Gate signal
-- `swarm:${TASK_ID}:epic-context` - Epic context
-- `swarm:${TASK_ID}:success-criteria` - Acceptance criteria
-
-### Debug Commands
-```bash
-# Check agent completion
-redis-cli lrange "swarm:${TASK_ID}:${AGENT_ID}:done" 0 -1
-
-# Check confidence scores
-redis-cli get "swarm:${TASK_ID}:${AGENT_ID}:confidence"
-
-# Monitor gate signals
-redis-cli blpop "swarm:${TASK_ID}:gate-passed" 1
-```
-
----
-
-**Maintenance:** Regular validation of clean exit patterns and dependency enforcement. Test suite should validate all lifecycle scenarios.

package/.claude/skills/cfn-loop-validation/check-dependencies.sh

@@ -1,31 +0,0 @@
-#!/bin/bash
-# Dependency checker for CFN Loop Validation
-
-check_command() {
-  if command -v "$1" &> /dev/null; then
-    VERSION=$($1 --version 2>&1 | head -n1)
-    echo "✅ $1: $VERSION"
-    return 0
-  else
-    echo "❌ $1: NOT FOUND"
-    return 1
-  fi
-}
-
-echo "Checking dependencies for CFN Loop Validation..."
-MISSING=0
-
-# Required dependencies
-check_command "bash" || MISSING=$((MISSING+1))
-check_command "jq" || MISSING=$((MISSING+1))
-check_command "bc" || MISSING=$((MISSING+1))
-
-if [ $MISSING -eq 0 ]; then
-  echo ""
-  echo "✅ All required dependencies installed"
-  exit 0
-else
-  echo ""
-  echo "❌ Missing $MISSING required dependencies"
-  exit 1
-fi

package/.claude/skills/cfn-loop-validation/config.json

@@ -1,161 +0,0 @@
-{
-  "modes": {
-    "mvp": {
-      "gateThreshold": 0.70,
-      "consensusThreshold": 0.85,
-      "maxIterations": 5,
-      "maxLoop2Iterations": 5,
-      "maxLoop3Iterations": 5,
-      "validatorCount": 2,
-      "validatorsToSpawn": 2,
-      "validatorTypes": ["reviewer", "tester"],
-      "productOwnerStructure": "single",
-      "description": "MVP mode - Fast iteration with minimal validation for rapid prototyping",
-      "features": [
-        "Basic syntax validation",
-        "Core functionality checks",
-        "Rapid iteration focus",
-        "Skip architecture review",
-        "Skip enterprise security audit"
-      ],
-      "skipValidations": ["architecture-review", "enterprise-security-audit"],
-      "specialInstructions": "MVP mode: Focus on rapid iteration and core functionality. Skip comprehensive architecture reviews. Acceptable to have technical debt for later refinement."
-    },
-    "standard": {
-      "gateThreshold": 0.80,
-      "consensusThreshold": 0.90,
-      "maxIterations": 10,
-      "maxLoop2Iterations": 10,
-      "maxLoop3Iterations": 10,
-      "validatorCount": 4,
-      "validatorsToSpawn": 4,
-      "validatorTypes": ["reviewer", "security-specialist", "tester", "analyst"],
-      "productOwnerStructure": "single",
-      "description": "Standard mode - Comprehensive validation with balanced performance",
-      "features": [
-        "Complete syntax validation",
-        "Resource dependency analysis",
-        "Security best practices",
-        "Performance optimization checks",
-        "Code quality metrics",
-        "Test coverage requirements"
-      ],
-      "specialInstructions": "Standard mode: Balance between quality and speed. Implement best practices and ensure adequate test coverage."
-    },
-    "enterprise": {
-      "gateThreshold": 0.90,
-      "consensusThreshold": 0.95,
-      "maxIterations": 15,
-      "maxLoop2Iterations": 15,
-      "maxLoop3Iterations": 15,
-      "validatorCount": 5,
-      "validatorsToSpawn": 8,
-      "validatorTypes": [
-        "reviewer",
-        "security-specialist",
-        "tester",
-        "analyst",
-        "architect"
-      ],
-      "productOwnerStructure": "team",
-      "planningConsensus": {
-        "enabled": true,
-        "architectTypes": ["architect", "system-architect", "security-specialist"],
-        "threshold": 0.85
-      },
-      "productOwnerTeam": {
-        "roles": [
-          { "name": "cto", "weight": 0.35 },
-          { "name": "product-owner", "weight": 0.30 },
-          { "name": "user-power", "weight": 0.20 },
-          { "name": "user-accessibility", "weight": 0.15 }
-        ],
-        "votingAlgorithm": "weighted-confidence"
-      },
-      "description": "Enterprise mode - Advanced validation with maximum security and compliance",
-      "features": [
-        "Complete syntax validation",
-        "Advanced dependency analysis",
-        "Enterprise security standards",
-        "Compliance validation (GDPR, SOC2, etc.)",
-        "Disaster recovery checks",
-        "Multi-region deployment analysis",
-        "Advanced performance optimization",
-        "Detailed cost analysis",
-        "Audit trail logging",
-        "Architecture review board",
-        "Planning consensus (Loop 0.5)",
-        "Product owner team decision (Loop 4)"
-      ],
-      "specialInstructions": "Enterprise mode: Maximum quality and security. All decisions require board approval. Implement comprehensive security measures and compliance checks."
-    }
-  },
-  "validators": {
-    "baseValidators": [
-      "SyntaxValidator",
-      "DependencyValidator",
-      "ResourceValidator"
-    ],
-    "standardValidators": [
-      "SyntaxValidator",
-      "DependencyValidator",
-      "ResourceValidator",
-      "SecurityValidator"
-    ],
-    "enterpriseValidators": [
-      "SyntaxValidator",
-      "DependencyValidator",
-      "ResourceValidator",
-      "SecurityValidator",
-      "ComplianceValidator",
-      "PerformanceValidator",
-      "CostValidator",
-      "DisasterRecoveryValidator"
-    ]
-  },
-  "retry": {
-    "backoffStrategy": "exponential",
-    "maxBackoffTime": 30000,
-    "initialBackoffTime": 1000,
-    "jitter": true
-  },
-  "evidence": {
-    "retentionPeriod": 2592000,
-    "maxEvidenceSize": "10MB",
-    "compression": true
-  },
-  "performance": {
-    "maxConcurrentValidators": 8,
-    "timeoutPerValidator": 30000,
-    "cacheResults": true,
-    "cacheTTL": 3600
-  },
-  "logging": {
-    "level": "info",
-    "format": "json",
-    "fileOutput": true,
-    "maxFileSize": "100MB",
-    "maxFiles": 5
-  },
-  "thresholdComparison": {
-    "description": "Comparison of threshold requirements across modes",
-    "mvp": {
-      "confidence_gate": 0.70,
-      "consensus": 0.85,
-      "planning": null,
-      "escalation_trigger": 0.60
-    },
-    "standard": {
-      "confidence_gate": 0.80,
-      "consensus": 0.90,
-      "planning": null,
-      "escalation_trigger": 0.70
-    },
-    "enterprise": {
-      "confidence_gate": 0.90,
-      "consensus": 0.95,
-      "planning": 0.85,
-      "escalation_trigger": 0.85
-    }
-  }
-}